1 2016-03-08 00:18:16 0|GitHub70|[13bitcoin] 15promag opened pull request #7649: Prevent multiple calls to CWallet::AvailableCoins (06master...06enhancement/prevent-multiple-calls-availablecoins) 02https://github.com/bitcoin/bitcoin/pull/7649
2 2016-03-08 01:12:11 0|sipa|btcdrak: exiting mining algorithm
3 2016-03-08 09:15:41 0|GitHub95|13bitcoin/06master 14b51ed40 15Eric Shaw: QT: Add 'copy full transaction details' option...
4 2016-03-08 09:15:41 0|GitHub95|[13bitcoin] 15jonasschnelli pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/9f33dba05c01...87d65622996d
5 2016-03-08 09:15:42 0|GitHub95|13bitcoin/06master 1487d6562 15Jonas Schnelli: Merge #7628: QT: Add 'copy full transaction details' option...
6 2016-03-08 09:15:51 0|GitHub135|[13bitcoin] 15jonasschnelli closed pull request #7628: QT: Add 'copy full transaction details' option (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/7628
7 2016-03-08 10:37:24 0|GitHub20|[13bitcoin] 15promag opened pull request #7650: Cache CBlockIndex::GetMedianTimePast (06master...06enhancement/cache-getmediantimepast) 02https://github.com/bitcoin/bitcoin/pull/7650
8 2016-03-08 10:38:28 0|GitHub19|[13bitcoin] 15rebroad opened pull request #7651: Only need to subtract 1 (originally time was in seconds). (06master...06AskforTime) 02https://github.com/bitcoin/bitcoin/pull/7651
9 2016-03-08 11:16:00 0|GitHub36|[13bitcoin] 15rebroad opened pull request #7652: Node id when misbehaving (06master...06NodeIdWhenMisbehaving) 02https://github.com/bitcoin/bitcoin/pull/7652
10 2016-03-08 13:38:02 0|GitHub63|[13bitcoin] 15Lewuathe opened pull request #7653: Suppress unused variable warning in automated test (06master...06suppress-unused-variable-warn) 02https://github.com/bitcoin/bitcoin/pull/7653
11 2016-03-08 15:09:40 0|wumpus|this logic in CFeeRate::GetFee is giving me a headache: https://github.com/bitcoin/bitcoin/blob/master/src/amount.cpp#L24 so it computes the fee from the fee/kb and the size of the transaction, so far so good. But why is there a check to set the fee to nSatoshisPerK if the resulting fee is 0?
12 2016-03-08 15:16:29 0|wumpus|is this a kind of 'rounding'?
13 2016-03-08 15:20:13 0|sdaftuar|wumpus: looks like it showed up in commit d88af560111863c3e9c1ae855dcc287f04dffb02
14 2016-03-08 15:21:07 0|sdaftuar|PR 4465
15 2016-03-08 15:21:27 0|wumpus|"fee fixes". Ominous.
16 2016-03-08 15:22:56 0|wumpus|rationale seems to be "CFeeRate::GetFee(..) currently returns zero for very small nSatoshisPerK. For example, if you set the voluntary fee to 1 satoshi, and the tx has less than 1000 bytes, payTxFee.GetFee(nTxBytes) returns zero, this results in CWallet::GetMinimumFee(..) to return pool.estimateFee(..) instead of the voluntary fee. So its not possible to set the voluntary fee as low as 1 satoshi."
17 2016-03-08 15:24:41 0|wumpus|interesting. Thanks for looking it up. Bah, such things should really be commented in the source code.
18 2016-03-08 15:28:05 0|wumpus|seems like a kind of layering violation to do it there, too, as CFeeRate is used not just in the wallet
19 2016-03-08 15:28:59 0|wumpus|in any case it isn't a big issue, just makes me a bit afraid that the fee code is full of such snags, I don't blame users for getting confused :)
20 2016-03-08 15:29:43 0|sdaftuar|agreed, confusing and scary :)
21 2016-03-08 15:38:48 0|kanzure|re: my question about dry run configuration with libbtcnet, the answer to my question was "yes"-- i noticed later that there was an explicit start() method.
22 2016-03-08 15:39:18 0|kanzure|so the connection configuration happens separately from connection initiation, and could be reviewed or analyzed or inspected prior to establishing active connections (yay)
23 2016-03-08 16:09:07 0|GitHub47|[13bitcoin] 15rebroad opened pull request #7654: Add net2 debug option (06master...06DebugNet2) 02https://github.com/bitcoin/bitcoin/pull/7654
24 2016-03-08 18:40:37 0|morcos|sipa: you traveling already? sorry i hadn't reveiwed versionbits for yesterday, but i have some further concerns
25 2016-03-08 18:41:01 0|morcos|before bip9 an old node would always detect when soft forks activated b/c the signal was permanent (version number incremented)
26 2016-03-08 18:41:33 0|morcos|after bip9 an old node needs to be able to detect transient activations, which means i think that the warning logic needs to run during IBD
27 2016-03-08 18:41:51 0|morcos|this should be combined with sdaftuar's per bit checking
28 2016-03-08 18:43:44 0|GitHub27|[13bitcoin] 15MarcoFalke opened pull request #7655: [qt] Add .clang-format (06master...06Mf1603-qt-clang-format-0.12) 02https://github.com/bitcoin/bitcoin/pull/7655
29 2016-03-08 18:44:49 0|morcos|and then i think there will need to be some special casing allowing block version <= 4 (indefinitely? or do we want to maybe soft fork out the ability to have block version = 4 blocks once the first version bits soft fork activates?)