1 2016-03-14 09:16:06	0|paveljanik|there is a global base
 2 2016-03-14 09:16:49	0|paveljanik|it can be removed from TorController::TorController and commented out around l. 365
 3 2016-03-14 09:17:19	0|paveljanik|I do not know if the global should be prefer or the private one there.
 4 2016-03-14 09:17:45	0|paveljanik|let's wait for wumpus
 5 2016-03-14 09:29:08	0|wumpus|we should probably rename the global one
 6 2016-03-14 09:29:27	0|wumpus|(I'd like to go without it completely, but I don't think that's possible)
 7 2016-03-14 09:30:19	0|wumpus|it would work if our initialization sequence was structured differently, and StartTorControl would return an instance instead, but with the global StartTorControl/InterruptTorControl/StopTorControl flow, some state needs to be global
 8 2016-03-14 09:30:29	0|wumpus|it shouldn't be called the same as an instance variable though
 9 2016-03-14 09:41:07	0|wumpus|e.g. like this https://github.com/laanwj/bitcoin/commit/0a48b56bdc60f9dafaea7a7b2a770eb819dbfe55
10 2016-03-14 09:42:26	0|jonasschnelli|ACK https://github.com/laanwj/bitcoin/commit/0a48b56bdc60f9dafaea7a7b2a770eb819dbfe55
11 2016-03-14 09:43:54	0|GitHub154|[13bitcoin] 15laanwj opened pull request #7676: torcontrol: rename global base, avoid overlap with field (06master...062016_03_torcontrol_rename_base) 02https://github.com/bitcoin/bitcoin/pull/7676
12 2016-03-14 09:44:53	0|wumpus|eventually we could want to move toward having one libevent base, instead of having separate ones for RPC and torcontrol, but best to do this after cfields_' net refactor
13 2016-03-14 09:45:13	0|wumpus|(which will introduce a third one for the P2P)
14 2016-03-14 09:48:00	0|wumpus|so, it looks like 0.12 finally broke windows XP compatibility (https://github.com/bitcoin/bitcoin/issues/7639, https://github.com/bitcoin/bitcoin/issues/7674)
15 2016-03-14 09:48:40	0|wumpus|I'd almost say 'congratulations', if it wasn't that I'm afraid that it's some kind of race that may be hiding on other platforms as well
16 2016-03-14 09:49:32	0|wumpus|on the other hand this could be simply the new mingw (from ubuntu 14.04 i.s.o 12.04)
17 2016-03-14 10:12:38	0|NicolasDorier|I would appreciate some feedback on https://github.com/bitcoin/bitcoin/issues/7677
18 2016-03-14 10:21:25	0|GitHub107|[13bitcoin] 15laanwj closed pull request #7676: torcontrol: rename global base, avoid overlap with field (06master...062016_03_torcontrol_rename_base) 02https://github.com/bitcoin/bitcoin/pull/7676
19 2016-03-14 10:27:28	0|GitHub42|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/b24266c20748...56d2c4e0fee3
20 2016-03-14 10:27:29	0|GitHub42|13bitcoin/06master 142fdaa25 15Mustafa: Move GetTempPath() to testutil.
21 2016-03-14 10:27:29	0|GitHub42|13bitcoin/06master 14393b22e 15Mustafa: Add a source file for unit test utils.
22 2016-03-14 10:27:30	0|GitHub42|13bitcoin/06master 1456d2c4e 15Wladimir J. van der Laan: Merge #7667: Move GetTempPath() to testutil...
23 2016-03-14 10:27:33	0|GitHub100|[13bitcoin] 15laanwj closed pull request #7667: Move GetTempPath() to testutil (06master...06patch-gettemppath) 02https://github.com/bitcoin/bitcoin/pull/7667
24 2016-03-14 10:30:25	0|GitHub97|[13bitcoin] 15laanwj pushed 4 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/56d2c4e0fee3...f1ca8915bb22
25 2016-03-14 10:30:26	0|GitHub97|13bitcoin/06master 142317ad7 15Wladimir J. van der Laan: test: Re-introduce JSON pretty printing in test builder
26 2016-03-14 10:30:26	0|GitHub97|13bitcoin/06master 14b0ff857 15Wladimir J. van der Laan: test: Move non-generated script_invalid test to the correct place...
27 2016-03-14 10:30:27	0|GitHub97|13bitcoin/06master 140ecb340 15Wladimir J. van der Laan: test: Script_error checking in script_invalid tests...
28 2016-03-14 10:30:30	0|GitHub32|[13bitcoin] 15laanwj closed pull request #7517: test: script_error checking in script_invalid tests (06master...062016_02_test_script_errors) 02https://github.com/bitcoin/bitcoin/pull/7517
29 2016-03-14 10:34:11	0|wumpus|paveljanik: I don't like that warning - it's correct, after #7637 we don't need to keep `base` around at all in TorController right now because we only use it in the constructor.  But I think it's good practice to do so anyway, in case it's needed again in later changes...
30 2016-03-14 10:35:09	0|GitHub160|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/f1ca8915bb22...5b3b5a7d711c
31 2016-03-14 10:35:10	0|GitHub160|13bitcoin/06master 1415e6e13 15Jonas Schnelli: [Wallet] optimize return value of InitLoadWallet()
32 2016-03-14 10:35:10	0|GitHub160|13bitcoin/06master 14fc7c60d 15Jonas Schnelli: [Wallet] move "load wallet phase" to CWallet
33 2016-03-14 10:35:11	0|GitHub160|13bitcoin/06master 145b3b5a7 15Wladimir J. van der Laan: Merge #7577: [Wallet] move "load wallet phase" to CWallet...
34 2016-03-14 10:35:17	0|GitHub41|[13bitcoin] 15laanwj closed pull request #7577: [Wallet] move "load wallet phase" to CWallet (06master...062016/02/wallet_ref2) 02https://github.com/bitcoin/bitcoin/pull/7577
35 2016-03-14 10:35:59	0|GitHub130|13bitcoin/06master 148d1de43 15Leviathn: Remove internal miner...
36 2016-03-14 10:35:59	0|GitHub130|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/5b3b5a7d711c...11c769966ad7
37 2016-03-14 10:36:00	0|GitHub130|13bitcoin/06master 1411c7699 15Wladimir J. van der Laan: Merge #7507: Remove internal miner...
38 2016-03-14 10:36:02	0|GitHub30|[13bitcoin] 15laanwj closed pull request #7507: Remove internal miner (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/7507
39 2016-03-14 10:36:37	0|GitHub155|13bitcoin/06master 148a253b3 15Pieter Wuille: Make the generate RPC call function for non-regtest
40 2016-03-14 10:36:37	0|GitHub155|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/11c769966ad7...c87f51e55bc3
41 2016-03-14 10:36:38	0|GitHub155|13bitcoin/06master 14c87f51e 15Wladimir J. van der Laan: Merge #7663: Make the generate RPC call function for non-regtest...
42 2016-03-14 10:36:47	0|GitHub3|[13bitcoin] 15laanwj closed pull request #7663: Make the generate RPC call function for non-regtest (06master...06generatenonreg) 02https://github.com/bitcoin/bitcoin/pull/7663
43 2016-03-14 10:37:01	0|paveljanik|wumpus, 8) When it is needed in later changes, it can be resurrected from git history 8)
44 2016-03-14 10:37:21	0|wumpus|paveljanik: of course, but I think the warning is over-eager
45 2016-03-14 10:38:29	0|paveljanik|every warning is disturbing, hides probles etc. But I know you have a different opinion :-)
46 2016-03-14 10:39:07	0|paveljanik|and I respect that.
47 2016-03-14 10:39:17	0|wumpus|sure, they're annoying, but in some cases it makes more sense to disable the warning than change the code
48 2016-03-14 10:40:02	0|paveljanik|I agree with that - in some cases. Like known compiler bug etc...
49 2016-03-14 10:40:06	0|wumpus|it's not up to compiler authors to decide about our code style
50 2016-03-14 10:40:45	0|wumpus|looks like they're making the compiler behave like a nanny with too much time on their hands
51 2016-03-14 10:41:00	0|paveljanik|I agree with that completely ;-)
52 2016-03-14 10:42:01	0|wumpus|all time spent on 'fixing' the code to be as acceptable as possible to the compiler is not spent on facing user-facing issues, ok and that concludes my rant on this
53 2016-03-14 11:10:25	0|GitHub102|[13bitcoin] 15laanwj closed pull request #7655: [qt] Add .clang-format (06master...06Mf1603-qt-clang-format-0.12) 02https://github.com/bitcoin/bitcoin/pull/7655
54 2016-03-14 11:23:07	0|GitHub7|13bitcoin/06master 14a6ee0ca 15Pavel Vasin: use cached block hash in blockToJSON()
55 2016-03-14 11:23:07	0|GitHub7|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/c87f51e55bc3...c9a12657545f
56 2016-03-14 11:23:08	0|GitHub7|13bitcoin/06master 14c9a1265 15Wladimir J. van der Laan: Merge #7670: use cached block hash in blockToJSON()...
57 2016-03-14 11:23:17	0|GitHub70|[13bitcoin] 15laanwj closed pull request #7670: use cached block hash in blockToJSON() (06master...06patch) 02https://github.com/bitcoin/bitcoin/pull/7670
58 2016-03-14 11:24:42	0|GitHub199|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/c9a12657545f...c15eb2824184
59 2016-03-14 11:24:43	0|GitHub199|13bitcoin/06master 14c15eb28 15Wladimir J. van der Laan: Merge #7658: Add curl to Gitian setup instructions...
60 2016-03-14 11:24:43	0|GitHub199|13bitcoin/06master 14ce41cf0 15BtcDrak: Add curl to Gitian setup instrustions...
61 2016-03-14 11:24:47	0|GitHub192|[13bitcoin] 15laanwj closed pull request #7658: Add curl to Gitian setup instructions (06master...06curl) 02https://github.com/bitcoin/bitcoin/pull/7658
62 2016-03-14 11:55:05	0|GitHub32|[13bitcoin] 15laanwj opened pull request #7680: qt: Remove reflection from `about` icon (06master...062016_03_image_optimize) 02https://github.com/bitcoin/bitcoin/pull/7680
63 2016-03-14 12:43:26	0|GitHub195|13bitcoin/06master 14322a7a2 15Wladimir J. van der Laan: qt: Remove reflection from `about` icon...
64 2016-03-14 12:43:26	0|GitHub195|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/c15eb2824184...41d2dfa9e73b
65 2016-03-14 12:43:27	0|GitHub195|13bitcoin/06master 1441d2dfa 15Wladimir J. van der Laan: Merge #7680: qt: Remove reflection from `about` icon...
66 2016-03-14 12:43:33	0|GitHub2|[13bitcoin] 15laanwj closed pull request #7680: qt: Remove reflection from `about` icon (06master...062016_03_image_optimize) 02https://github.com/bitcoin/bitcoin/pull/7680
67 2016-03-14 12:56:44	0|GitHub179|13bitcoin/06master 14fa19b18 15MarcoFalke: [wallet] Move hardcoded file name out of log messages
68 2016-03-14 12:56:44	0|GitHub179|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/41d2dfa9e73b...0735c0ca7c22
69 2016-03-14 12:56:45	0|GitHub179|13bitcoin/06master 140735c0c 15Wladimir J. van der Laan: Merge #7608: [wallet] Move hardcoded file name out of log messages...
70 2016-03-14 12:56:53	0|GitHub194|[13bitcoin] 15laanwj closed pull request #7608: [wallet] Move hardcoded file name out of log messages (06master...06Mf1602-walletFileName) 02https://github.com/bitcoin/bitcoin/pull/7608