1 2016-04-03 09:54:37 0|GitHub45|[13bitcoin] 15laanwj opened pull request #7792: depends: mac deploy Py3 compatibility (06master...062016_04_fix_macosx_gitian) 02https://github.com/bitcoin/bitcoin/pull/7792
2 2016-04-03 10:02:12 0|GitHub117|[13bitcoin] 15MarcoFalke opened pull request #7793: [doxygen] Fix member comments (06master...06Mf1604-doxygenMembers) 02https://github.com/bitcoin/bitcoin/pull/7793
3 2016-04-03 11:16:31 0|GitHub92|[13bitcoin] 15laanwj opened pull request #7795: UpdateTip: log only one line at most per block (06master...062016_04_block_warning_logging_inline) 02https://github.com/bitcoin/bitcoin/pull/7795
4 2016-04-03 11:22:31 0|GitHub86|[13bitcoin] 15MarcoFalke opened pull request #7796: [amount] Add support for negative fee rates (06master...06Mf1604-amountNeg64) 02https://github.com/bitcoin/bitcoin/pull/7796
5 2016-04-03 11:39:36 0|gmaxwell|Is there some computationally efficient way that I can take a mempool txn and determine its chain depth in the mempool?
6 2016-04-03 11:40:09 0|sipa|i'd say check the code that limits it?
7 2016-04-03 11:47:10 0|gmaxwell|Fair recommendation.. looks like it walks, I guess thats not that awful, was thinking of sorting invs but it needs to be a topological sort.
8 2016-04-03 11:48:09 0|sipa|given that it is limited in depth, walking is worst-case constant time :)
9 2016-04-03 11:48:33 0|gmaxwell|it's a bit annoying because a txn can have multiple parents, and you need to walk all to discover the worst case depth.
10 2016-04-03 11:48:52 0|gmaxwell|can't easily be cached since new blocks will invalidate.
11 2016-04-03 12:14:27 0|GitHub173|[13bitcoin] 15mruddy opened pull request #7797: RPC: fix generatetoaddress failing to parse address (06master...06generatetoaddress-fix) 02https://github.com/bitcoin/bitcoin/pull/7797
12 2016-04-03 12:32:23 0|GitHub108|[13bitcoin] 15MarcoFalke opened pull request #7798: [travis] Print the commit which was evaluated (06master...06Mf1604-travisCommitLog) 02https://github.com/bitcoin/bitcoin/pull/7798
13 2016-04-03 13:07:15 0|GitHub142|13bitcoin/06master 144b9dfd6 15Pavel JanÃk: Add note about using the Qt official binary installer.
14 2016-04-03 13:07:15 0|GitHub142|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/30c2dd8d0598...e0b3e19816b6
15 2016-04-03 13:07:16 0|GitHub142|13bitcoin/06master 14e0b3e19 15Wladimir J. van der Laan: Merge #7789: [Doc] Add note about using the Qt official binary installer....
16 2016-04-03 13:07:25 0|GitHub31|[13bitcoin] 15laanwj closed pull request #7789: [Doc] Add note about using the Qt official binary installer. (06master...0620160402_Qt56_official_installer_note) 02https://github.com/bitcoin/bitcoin/pull/7789
17 2016-04-03 13:54:52 0|GitHub60|[13bitcoin] 15laanwj pushed 5 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/e0b3e19816b6...ff5874bcf7e3
18 2016-04-03 13:54:53 0|GitHub60|13bitcoin/06master 14fa2cea1 15MarcoFalke: [qa] rpc-tests: Properly use integers, floats
19 2016-04-03 13:54:53 0|GitHub60|13bitcoin/06master 14fa524d9 15MarcoFalke: [qa] Use python2/3 syntax
20 2016-04-03 13:54:54 0|GitHub60|13bitcoin/06master 14faaa3c9 15MarcoFalke: [qa] mininode: Catch exceptions in got_data
21 2016-04-03 13:55:02 0|GitHub197|[13bitcoin] 15laanwj closed pull request #7778: [qa] Bug fixes and refactor (06master...06Mf1604-qaFixesRefactor) 02https://github.com/bitcoin/bitcoin/pull/7778
22 2016-04-03 13:55:44 0|MarcoFalke|Nice, looks like I can continue with the py3 switch.
23 2016-04-03 15:34:24 0|GitHub64|13bitcoin/06master 1460361ca 15mruddy: RPC: fix generatetoaddress failing to parse address and add unit test
24 2016-04-03 15:34:24 0|GitHub64|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/ff5874bcf7e3...e662a7628801
25 2016-04-03 15:34:25 0|GitHub64|13bitcoin/06master 14e662a76 15Wladimir J. van der Laan: Merge #7797: RPC: fix generatetoaddress failing to parse address...
26 2016-04-03 15:34:32 0|GitHub143|[13bitcoin] 15laanwj closed pull request #7797: RPC: fix generatetoaddress failing to parse address (06master...06generatetoaddress-fix) 02https://github.com/bitcoin/bitcoin/pull/7797
27 2016-04-03 16:04:00 0|btcdrak|MarcoFalke: after 0.12.1 is tagged, it might be worth backporting the stuff around python required for Ubuntu 16.04
28 2016-04-03 16:08:53 0|wumpus|yes, probably
29 2016-04-03 16:11:45 0|sdaftuar|gmaxwell: saw your comment above about topological sort
30 2016-04-03 16:12:29 0|sdaftuar|gmaxwell: if you don't actually care about "depth", and just want a sort that puts dependent transactions after their ancestors, then you can sort by nCountWithAncestors
31 2016-04-03 16:12:51 0|sdaftuar|which gets updated as blocks are found
32 2016-04-03 16:13:03 0|sipa|sdaftuar: i assume he also wants it sorted by decreasing feerate
33 2016-04-03 16:13:16 0|sdaftuar|ah
34 2016-04-03 16:13:28 0|sdaftuar|that sounds like what the new CNB does
35 2016-04-03 16:54:20 0|GitHub126|[13bitcoin] 15btcdrak opened pull request #7800: [0.12] Update release notes (060.12...06docs) 02https://github.com/bitcoin/bitcoin/pull/7800
36 2016-04-03 18:31:14 0|gmaxwell|sdaftuar: no thats exactly what I want. Glad I asked.
37 2016-04-03 18:51:55 0|gmaxwell|sdaftuar: ah, I didn't see that because I was on 0.12. :)
38 2016-04-03 19:12:51 0|btcdrak|gmaxwell: I took a stab at 0.12 release notes for the softfork, if you have time, could you check for accuracy/completeness? https://github.com/bitcoin/bitcoin/pull/7800
39 2016-04-03 19:15:57 0|sdaftuar|gmaxwell: if you're working on something that you intend for 0.12 (as opposed to master), i have some suggestions
40 2016-04-03 19:22:38 0|sdaftuar|gmaxwell: i wrote up code at one point (before i realized the nCountWithAncestors thing) that would walk the transaction graph, along the lines of Kahn's algorithm iirc
41 2016-04-03 19:23:07 0|sdaftuar|i could dig that up, but morcos had the idea of just first sorting by entry time to mempool, which should be close to right
42 2016-04-03 19:24:22 0|sdaftuar|and then looping over the resulting sorted list, and checking if the tx is clear of dependencies
43 2016-04-03 19:33:09 0|gmaxwell|I'm contemplating just using the same score to order them that createnewblock does now.
44 2016-04-03 19:38:07 0|GitHub11|[13bitcoin] 15MarcoFalke opened pull request #7801: [qa] Remove misleading "errorString syntax" (06master...06Mf1604-qaTestErrorString) 02https://github.com/bitcoin/bitcoin/pull/7801
45 2016-04-03 19:38:11 0|GitHub101|[13bitcoin] 15MarcoFalke opened pull request #7803: [qa] maxblocksinflight: Actually enable test (06master...06Mf1604-qaTestMaxBlocks) 02https://github.com/bitcoin/bitcoin/pull/7803
46 2016-04-03 19:38:12 0|GitHub61|[13bitcoin] 15MarcoFalke opened pull request #7802: [qa] httpbasics: Actually test second connection (06master...06Mf1604-qaTestHttp) 02https://github.com/bitcoin/bitcoin/pull/7802
47 2016-04-03 20:24:13 0|GitHub135|[13bitcoin] 15sipa opened pull request #7804: Track block download times per individual block (06master...06betterkicktimeout) 02https://github.com/bitcoin/bitcoin/pull/7804
48 2016-04-03 20:25:29 0|sipa|wumpus: i wonder if we could/should fetch the entire description (or even all discussion) of a PR, and include it in the merge commit...
49 2016-04-03 20:27:31 0|gmaxwell|I would like that.
50 2016-04-03 20:27:55 0|gmaxwell|it irritates the hell out of me that the git history often doesn't even include an adequate description of the change, because it's all in the PR.
51 2016-04-03 20:28:40 0|sipa|on the other hand, PR descriptions are sometimes not updated when the scope/implementation changes significantly
52 2016-04-03 20:29:21 0|sipa|you can consider that a bad thing, but if you see the description just as the first message of the discussion, maybe the correct solution is just including the entire discussion
53 2016-04-03 20:29:26 0|sipa|text is cheap
54 2016-04-03 20:30:38 0|sipa|that would make the commits also more independent from github (as currently the merge commit does list the github PR number, but to grasp all the details you often need to actually go to github)
55 2016-04-03 20:41:39 0|btcdrak|sipa: yeah I tried that once but really the merge script would have to be redone in something like python so you can parse the github API data.
56 2016-04-03 20:42:02 0|gmaxwell|whole thing need not be redone, it could call a helper.
57 2016-04-03 20:42:18 0|gmaxwell|could also add the phase of the moon and current best block, if we wanted. :)
58 2016-04-03 20:42:26 0|btcdrak|sipa: check #5623
59 2016-04-03 20:47:54 0|MarcoFalke|btcdrak, the script is already python /contrib/devtools/github-merge.py
60 2016-04-03 20:49:37 0|btcdrak|oh the shell script went away
61 2016-04-03 20:51:09 0|btcdrak|well then that's easy, just pull the title from a fetch of https://api.github.com/repos/$REPO/pulls/$PULL
62 2016-04-03 20:51:19 0|MarcoFalke|Should be trivial to include the text from GitHub, but I am worried that typing `git log` will make you scroll the whole day
63 2016-04-03 20:51:22 0|btcdrak|you can make a lot more interesting merge commit messages too
64 2016-04-03 20:52:01 0|MarcoFalke|we already fetch the title ;)
65 2016-04-03 20:53:02 0|btcdrak|omg. have been under a rock.
66 2016-04-03 20:54:11 0|sipa|btcdrak: yes, that's why i brought it up, because it should be easy to add more now
67 2016-04-03 20:55:00 0|btcdrak|sipa: +1 on adding the entire discussion history to the merge commit
68 2016-04-03 20:55:19 0|sipa|MarcoFalke: that's a decent concern... we could fetch the github discussion, make a commit that puts it in $REPO/share/github-discussion/$PR.md or something, and include that commit in the merge...
69 2016-04-03 20:56:07 0|MarcoFalke|sipa, exactly my thought. Just make a blob and do an octomerge
70 2016-04-03 20:57:30 0|sipa|it's something i dislike right now: commits that refer to pull requests; the git source tree is something that should make sense without having access to github
71 2016-04-03 21:06:34 0|btcdrak|I think the commit message should contain the PR body text.
72 2016-04-03 21:06:48 0|btcdrak|merge* commit message
73 2016-04-03 21:44:21 0|gmaxwell|Well this isn't a replacement for having a useful commit message.