1 2016-05-30 07:36:37	0|wumpus|interesting, I have a bitcoind that hangs at "Loading banlist..."
 2 2016-05-30 07:37:34	0|wumpus|well it responds to RPC requests with that
 3 2016-05-30 07:39:44	0|wumpus|it does actually seem to be syncing with the network
 4 2016-05-30 07:40:47	0|wumpus|ok initialization completed now, seems to be a case of misreporting what it is doing
 5 2016-05-30 10:14:26	0|GitHub101|[13bitcoin] 15jonasnick opened pull request #8118: Reduce unnecessary hashing in signrawtransaction (06master...06faster-signraw) 02https://github.com/bitcoin/bitcoin/pull/8118
 6 2016-05-30 10:39:45	0|GitHub154|13bitcoin/06master 14619d569 15Pieter Wuille: Benchmark SipHash
 7 2016-05-30 10:39:45	0|GitHub154|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/6ff2c8d29f6b...61b86848b163
 8 2016-05-30 10:39:46	0|GitHub154|13bitcoin/06master 1461b8684 15Wladimir J. van der Laan: Merge #8111: Benchmark SipHash...
 9 2016-05-30 10:40:00	0|GitHub166|[13bitcoin] 15laanwj closed pull request #8111: Benchmark SipHash (06master...06benchsiphash) 02https://github.com/bitcoin/bitcoin/pull/8111
10 2016-05-30 10:40:17	0|GitHub141|13bitcoin/06master 14fc95f6e 15Chris Moore: fix typo in help text...
11 2016-05-30 10:40:17	0|GitHub141|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/61b86848b163...989df7ecf3a1
12 2016-05-30 10:40:18	0|GitHub141|13bitcoin/06master 14989df7e 15Wladimir J. van der Laan: Merge #7896: fix typo in help text...
13 2016-05-30 10:40:22	0|GitHub103|[13bitcoin] 15laanwj closed pull request #7896: fix typo in help text (06master...06patch-1) 02https://github.com/bitcoin/bitcoin/pull/7896
14 2016-05-30 11:06:19	0|GitHub29|13bitcoin/06master 145fac1f3 15Yuri Zhykin: bench: Added base58 encoding/decoding benchmarks
15 2016-05-30 11:06:19	0|GitHub29|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/989df7ecf3a1...52b803e09b16
16 2016-05-30 11:06:20	0|GitHub29|13bitcoin/06master 1452b803e 15Wladimir J. van der Laan: Merge #8107: bench: Added base58 encoding/decoding benchmarks...
17 2016-05-30 11:06:28	0|GitHub51|[13bitcoin] 15laanwj closed pull request #8107: bench: Added base58 encoding/decoding benchmarks (06master...06benchmarks) 02https://github.com/bitcoin/bitcoin/pull/8107
18 2016-05-30 11:29:42	0|GitHub138|[13bitcoin] 15fanquake opened pull request #8119: [trivial] Add .DSYM to .gitignore (06master...06ignore_debug) 02https://github.com/bitcoin/bitcoin/pull/8119
19 2016-05-30 12:45:56	0|GitHub15|[13bitcoin] 15fanquake opened pull request #8121: [Doc] Update implemented BIPs list (06master...06missing_bips) 02https://github.com/bitcoin/bitcoin/pull/8121
20 2016-05-30 13:40:55	0|GitHub73|[13bitcoin] 15sipa opened pull request #8123: Use std::atomic for fRequestShutdown and fReopenDebugLog (06master...06notsigbutatomic) 02https://github.com/bitcoin/bitcoin/pull/8123
21 2016-05-30 14:00:15	0|GitHub196|[13bitcoin] 15sipa pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/52b803e09b16...950be19727a5
22 2016-05-30 14:00:16	0|GitHub196|13bitcoin/06master 14628cf14 15Pieter Wuille: Don't use assert for catching randomness failures
23 2016-05-30 14:00:16	0|GitHub196|13bitcoin/06master 14fa2637a 15Pieter Wuille: Always require OS randomness when generating secret keys
24 2016-05-30 14:00:17	0|GitHub132|[13bitcoin] 15sipa closed pull request #7891: Always require OS randomness when generating secret keys (06master...06betterrng) 02https://github.com/bitcoin/bitcoin/pull/7891
25 2016-05-30 14:00:17	0|GitHub196|13bitcoin/06master 14950be19 15Pieter Wuille: Merge #7891: Always require OS randomness when generating secret keys...
26 2016-05-30 15:43:55	0|gmaxwell|\O/ (randomness)
27 2016-05-30 16:04:20	0|GitHub170|[13bitcoin] 15sipa opened pull request #8126: std::shared_ptr based CTransaction storage in mempool (06master...06sharedmempool) 02https://github.com/bitcoin/bitcoin/pull/8126
28 2016-05-30 16:09:16	0|gmaxwell|\O/
29 2016-05-30 16:12:41	0|luke-jr|O.o
30 2016-05-30 16:14:27	0|sipa|^^
31 2016-05-30 16:17:12	0|sipa|gmaxwell: it also conflicts with a few of your PRs, but it should simplify them
32 2016-05-30 16:18:13	0|gmaxwell|I don't mind.
33 2016-05-30 16:18:51	0|btcdrak|a rebase is a small price to pay for randomness
34 2016-05-30 16:19:07	0|btcdrak|the new currency shall be called rebases.
35 2016-05-30 16:19:38	0|gmaxwell|sipa: Is CTxMempool::CompareDepthAndScore dead code after the change that puts int in the Comparitor directly?
36 2016-05-30 16:19:55	0|luke-jr|might be useful to have a typedef though?
37 2016-05-30 16:20:19	0|gmaxwell|btcdrak: Sipa and I were commenting there about the shared_ptr change.
38 2016-05-30 16:20:47	0|luke-jr|CTransactionRef or something?
39 2016-05-30 16:21:37	0|gmaxwell|I kinda like knowing that its a shared_ptr, but... nevermind my taste.
40 2016-05-30 16:22:16	0|luke-jr|I don't feel strongly about this, was mainly thinking if we ever had to go back to pre-C++11 for some reason
41 2016-05-30 16:22:27	0|luke-jr|which seems unlikely
42 2016-05-30 16:24:15	0|sipa|luke-jr: sounds fine... std::shared_ptr<const Ctransaction> is a bit awkward to type
43 2016-05-30 16:24:27	0|sipa|on the aother hand... auto works well :)
44 2016-05-30 16:24:52	0|sipa|gmaxwell: no, still used from the heapifier in message handling
45 2016-05-30 16:26:21	0|luke-jr|'auto' certainly tells even less that it is a shared_ptr :P
46 2016-05-30 16:27:03	0|luke-jr|so if the long type is going to encourage using auto everywhere, perhaps gmaxwell's goal is actually better suited by a typedef as well
47 2016-05-30 16:27:39	0|gmaxwell|I think I'm going to have to give up on editing this code using an editor that can't go and read faraway prototypes.  Auto for return types is pretty useful, but it currently results in me grepping to go find out what the type actually is.
48 2016-05-30 16:28:35	0|gmaxwell|I hope not. Don't change what you're doing because of my very C-like preferences.
49 2016-05-30 16:28:51	0|sipa|it's a valid argument
50 2016-05-30 16:29:26	0|gmaxwell|I think it is best when the return type is obvious. E.g. functions that give you an iterator.
51 2016-05-30 16:29:40	0|sipa|we could of course go back to strict hungarian notation :D
52 2016-05-30 16:30:01	0|sipa|luke-jr: oh, no, i mean improving my current shared_ptr PR
53 2016-05-30 16:30:05	0|luke-jr|oh, ok
54 2016-05-30 16:31:21	0|gmaxwell|sipa: is there something we can do at shutdown to tell if all the txn have been freed? even in just some debugging build?
55 2016-05-30 16:32:39	0|sipa|gmaxwell: how could they not?
56 2016-05-30 16:32:40	0|luke-jr|CTx constructor could increment a global, and destructor decrement it?
57 2016-05-30 16:33:01	0|sipa|luke-jr: yup
58 2016-05-30 16:33:26	0|sipa|an atomic global :)
59 2016-05-30 16:33:36	0|sipa|and on every decrement, print to stderr
60 2016-05-30 16:35:01	0|gmaxwell|in the current code, they couldn't AFAICT. But if we leaked some object with a shared ptr we'd leak the transaction. It's generally pretty hard to leak shared_ptr... but seems prudent to check for.
61 2016-05-30 16:35:08	0|gmaxwell|Yea, that would work.
62 2016-05-30 16:36:52	0|sipa|also: the glibc implementation of std::shared_ptr is not readable
63 2016-05-30 16:40:55	0|gmaxwell|BlueMatt: thoughts on #8126 ?  would you like to rebase compactblocks on that?
64 2016-05-30 16:46:53	0|sipa|with --patience i get much more readable diffs often
65 2016-05-30 17:16:56	0|gmaxwell|http://blog.invisiblethings.org/2016/05/30/build-security.html < on build enviroment security.
66 2016-05-30 19:49:27	0|BlueMatt|gmaxwell: I probably will after its merged, sure
67 2016-05-30 20:00:39	0|btcdrak|BlueMatt: could you say so on the ticket so people arent waiting for it?
68 2016-05-30 20:10:01	0|BlueMatt|btcdrak: who's waiting for what?
69 2016-05-30 20:17:06	0|sipa|it shouldn't interfere with review of compact blocks otherwise
70 2016-05-30 20:17:19	0|sipa|just the refcounting in the mempool can go away
71 2016-05-30 21:32:59	0|gmaxwell|BlueMatt: you might want to review sipa's patch (or try the rebase) to make sure it won't get in your way.
72 2016-05-30 21:35:37	0|sipa|i'll do the rebase for you, if it helps things forward
73 2016-05-30 22:27:24	0|gmaxwell|sipa: might be a good review excercise even if matt doesn't want to use the result.
74 2016-05-30 22:30:22	0|gmaxwell|Opinion piece against most uses of unit tests that I think makes some nice points: http://rbcs-us.com/documents/Why-Most-Unit-Testing-is-Waste.pdf  (the biggest exceptions he makes are cases where there is a clear formal defintion of correctness that can be tested against for the function, and also when the tests are realistically able to completely test the function; otherwise he favors system
75 2016-05-30 22:30:28	0|gmaxwell|tests and gives arguments from a number of angles).