1 2016-06-19 07:46:09	0|wumpus|luke-jr: no, I don't
 2 2016-06-19 07:54:47	0|wumpus|luke-jr: we do test windows on travis AFAIK?
 3 2016-06-19 08:03:38	0|wumpus|e.g. cross-build for windows, then run the tests in wine
 4 2016-06-19 08:04:14	0|wumpus|but not sure this covers all the tests
 5 2016-06-19 13:43:21	0|luke-jr|wumpus: the Trusty changes appear to have disabled the GUI build and WINE testing :/
 6 2016-06-19 13:43:33	0|luke-jr|ie, just builds bitcoind and doesn't test it
 7 2016-06-19 13:51:22	0|sipa|luke-jr: https://travis-ci.org/bitcoin/bitcoin/jobs/138611890#L2144
 8 2016-06-19 13:51:24	0|sipa|seems it does
 9 2016-06-19 13:51:53	0|luke-jr|hm
10 2016-06-19 13:52:07	0|sipa|ah, but not the RPC tests
11 2016-06-19 13:52:30	0|sipa|only comparison tool and unit tests
12 2016-06-19 13:54:03	0|sipa|wumpus: https://github.com/bitcoin/bitcoin/pull/5677#issuecomment-136646964
13 2016-06-19 13:54:09	0|sipa|wumpus: does that still apply?
14 2016-06-19 13:55:01	0|luke-jr|-      env: HOST=i686-w64-mingw32 PPA="ppa:ubuntu-wine/ppa" PACKAGES="nsis gcc-mingw-w64-i686 g++-mingw-w64-i686 binutils-mingw-w64-i686 mingw-w64-dev wine1.7 bc" RUN_TESTS=true GOAL="deploy" BITCOIN_CONFIG="--enable-gui --enable-reduce-exports" MAKEJOBS="-j2"
15 2016-06-19 13:55:02	0|luke-jr|+      env: HOST=i686-w64-mingw32 DPKG_ADD_ARCH="i386" DEP_OPTS="NO_QT=1" PACKAGES="nsis g++-mingw-w64-i686 wine1.6 bc" RUN_TESTS=true GOAL="install" BITCOIN_CONFIG="--enable-reduce-exports"
16 2016-06-19 13:55:34	0|luke-jr|I guess I misread the RUN_TESTS part, but what does the GOAL change imply?
17 2016-06-19 13:58:07	0|sipa|i think it just means we don't build the installer
18 2016-06-19 15:11:55	0|Chris_Stewart_5|sipa: Do you have any thoughts on property based checking? I'm starting to integrate it into a library I'm writing and it seems it would be useful in Bitcoin Core. I was looking at this library for C++
19 2016-06-19 15:11:57	0|Chris_Stewart_5|https://github.com/emil-e/rapidcheck
20 2016-06-19 15:12:18	0|Chris_Stewart_5|I'm wondering if there is any outright objections before I put more time into investigating this for Core..
21 2016-06-19 15:20:04	0|wumpus|luke-jr: yes the GUI build is disabled for travis, for all platforms, that's intentional as there is still some caching issue
22 2016-06-19 15:21:08	0|wumpus|sipa: no idea, could be that the RPC tests could be re-enabled, just no one has tried since
23 2016-06-19 15:21:49	0|sipa|Chris_Stewart_5: no objections to the concept, but i have no experience with the code/logistics of integrating it
24 2016-06-19 15:22:57	0|sipa|Chris_Stewart_5: perhaps you want to talk to Marco Falke (our qa maintainer)
25 2016-06-19 15:23:20	0|wumpus|Chris_Stewart_5: I have no experience with it either, if you can apply it to improve test coverage of bitcoin core, why not try it
26 2016-06-19 15:23:55	0|wumpus|at first glance it looks like a type of fuzzing, you could take a look at https://github.com/bitcoin/bitcoin/pull/7940
27 2016-06-19 15:24:08	0|Chris_Stewart_5|Will do. Is it best to submit a pull request with a [WIP] on it, or just develop on my own branch and submit a pull request later on?
28 2016-06-19 15:25:03	0|wumpus|that's really up to you
29 2016-06-19 15:25:35	0|wumpus|in both cases you develop on your own branch, in the former cast it has somewhat more visibility, which is useful if you want other people's opinions about things
30 2016-06-19 15:33:10	0|Chris_Stewart_5|good point, another question, is there any vetting process for dependencies that are being added to our src files?
31 2016-06-19 15:34:03	0|Chris_Stewart_5|I get that this one isn't as crucial since it is test dependecy, but it would be important if a dependency was affect src files
32 2016-06-19 15:34:48	0|Chris_Stewart_5|src meaning everything but the child test dir
33 2016-06-19 16:00:21	0|sipa|Chris_Stewart_5: if you add a dependency, you need to make sure that it's available in the depends system (see the depends subdir), so that it's available to the deterministic build system
34 2016-06-19 16:01:48	0|Chris_Stewart_5|Hmm ok. I'm just starting to look at this stuff. Doesn't look quite as simple as maven on the JVM :-). Cory is the build expert right?
35 2016-06-19 16:05:34	0|sipa|Chris_Stewart_5: indeed
36 2016-06-19 16:06:38	0|sipa|Chris_Stewart_5: deterministic building is a pretty new concept, and there are few tools available to do it for you, so it's all pretty custom
37 2016-06-19 16:07:09	0|sipa|Chris_Stewart_5: though, generally don't worry about that, if it's useful we'll find a way to integrate it
38 2016-06-19 16:08:50	0|Chris_Stewart_5|sipa: Ok, I'm just going to hack it together to start and submit a pull request testing a few simple properties
39 2016-06-19 16:12:38	0|GitHub4|[13bitcoin] 15wbinns opened pull request #8224: readme: Revise 'an experimental new' phrasing in reference to Bitcoin (06master...06binns-update-readme) 02https://github.com/bitcoin/bitcoin/pull/8224
40 2016-06-19 18:09:37	0|Chris_Stewart_5|So i've created a file inside of package giving the instructions of how to build the library, what is the next step? I've tried to add the header to the test file and it fails.
41 2016-06-19 18:10:03	0|Chris_Stewart_5|I've also added it to the first line in packages.mk
42 2016-06-19 18:12:03	0|Chris_Stewart_5|See https://github.com/Christewart/bitcoin/commit/18638a532a8977d19a104f7fca76783b74d5e9fb
43 2016-06-19 23:44:44	0|GitHub63|[13bitcoin] 15wbinns opened pull request #8226: contributing.md: Fix formatting (line lengths and smart quotes) (06master...06binns-contributing-formatting) 02https://github.com/bitcoin/bitcoin/pull/8226