1 2016-06-24 00:54:55 0|phantomcircuit|sipa: is the block/headers synchronziation strategy documented anywhere?
2 2016-06-24 00:55:15 0|phantomcircuit|(mostly im interested in the intended operation)
3 2016-06-24 05:10:12 0|sipa|phantomcircuit: it's complicated...
4 2016-06-24 05:16:46 0|phantomcircuit|sipa, that's uh
5 2016-06-24 05:16:51 0|phantomcircuit|sipa, can you explain it to me?
6 2016-06-24 05:29:21 0|sipa|yes
7 2016-06-24 05:30:04 0|sipa|during initial sync, we send a getheaders to one peer only; outside of it we send it to all
8 2016-06-24 05:30:24 0|sipa|from headers responses we learn what blocks peers have
9 2016-06-24 05:31:11 0|sipa|and then in sendmessages determine which blocks to fetch from whom, subject to various conditions
10 2016-06-24 05:31:34 0|sipa|that's the parallel fetch
11 2016-06-24 05:32:34 0|sipa|there is also the direct fetch, in response to a block 'inv', which (a) sends a getheaders from that inv (b) sends a getdata if we believe we're close to being synced
12 2016-06-24 05:33:17 0|sipa|and then there is bip130, which introduces direct fetch in response to headers
13 2016-06-24 05:34:38 0|sipa|phantomcircuit: for more detail i need to look at the code
14 2016-06-24 05:36:12 0|phantomcircuit|sipa, ok that's helpful
15 2016-06-24 05:37:14 0|sipa|an invariant is that we never send a second request for a block that is already in flight, but we have timeouts that will disconnect (but not ban) a peer that takes too long
16 2016-06-24 05:41:07 0|gmaxwell|with compact blocks that could potentially be relaxed in the future. fetching a redundant compact block is not going to push you over being able to keep up with the network.
17 2016-06-24 05:41:20 0|gmaxwell|nor would a redundant blocktxn so long as it was less than half the block worth of data.
18 2016-06-24 07:02:57 0|GitHub139|[13bitcoin] 15fanquake opened pull request #8252: [trivial] Add aarch64 to depends .gitignore (06master...06depends-aarch-gitignore) 02https://github.com/bitcoin/bitcoin/pull/8252
19 2016-06-24 07:18:08 0|GitHub135|[13bitcoin] 15fanquake opened pull request #8253: [TEST] [Travis] Remove hostname workaround (06master...06remove-travis-workaround) 02https://github.com/bitcoin/bitcoin/pull/8253
20 2016-06-24 07:35:43 0|GitHub29|[13bitcoin] 15fanquake opened pull request #8254: [doc] Add OSX ZMQ requirement to QA readme (06master...06qa-readme-zmq) 02https://github.com/bitcoin/bitcoin/pull/8254
21 2016-06-24 10:24:14 0|wumpus|so, time to merge segwit today?
22 2016-06-24 10:24:18 0|GitHub67|[13bitcoin] 15fsb4000 opened pull request #8256: BUG: bitcoin-qt crash (06master...06patch-4) 02https://github.com/bitcoin/bitcoin/pull/8256
23 2016-06-24 10:40:05 0|GitHub13|13bitcoin/06master 14d241487 15fanquake: [doc] Add OS X ZMQ requirement to QA readme
24 2016-06-24 10:40:05 0|GitHub13|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/08338942b50f...c2c69edf37b5
25 2016-06-24 10:40:06 0|GitHub13|13bitcoin/06master 14c2c69ed 15MarcoFalke: Merge #8254: [doc] Add OSX ZMQ requirement to QA readme...
26 2016-06-24 10:40:15 0|GitHub132|[13bitcoin] 15MarcoFalke closed pull request #8254: [doc] Add OSX ZMQ requirement to QA readme (06master...06qa-readme-zmq) 02https://github.com/bitcoin/bitcoin/pull/8254
27 2016-06-24 10:45:21 0|GitHub155|13bitcoin/06master 14133deb8 15Pieter Wuille: Mark my dnsseed as supporting filtering
28 2016-06-24 10:45:21 0|GitHub155|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/c2c69edf37b5...5cd35d3dbc8b
29 2016-06-24 10:45:22 0|GitHub155|13bitcoin/06master 145cd35d3 15Wladimir J. van der Laan: Merge #8247: Mark my dnsseed as supporting filtering...
30 2016-06-24 10:45:31 0|GitHub107|[13bitcoin] 15laanwj closed pull request #8247: Mark my dnsseed as supporting filtering (06master...06newseed) 02https://github.com/bitcoin/bitcoin/pull/8247
31 2016-06-24 11:48:35 0|GitHub66|13bitcoin/06master 14d7828ab 15fsb4000: check that transactionView->selectionModel()->selectedRows(0) exists
32 2016-06-24 11:48:35 0|GitHub66|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/5cd35d3dbc8b...af2421c291c4
33 2016-06-24 11:48:36 0|GitHub66|13bitcoin/06master 14af2421c 15Wladimir J. van der Laan: Merge #8256: BUG: bitcoin-qt crash...
34 2016-06-24 11:48:45 0|GitHub124|[13bitcoin] 15laanwj closed pull request #8256: BUG: bitcoin-qt crash (06master...06patch-4) 02https://github.com/bitcoin/bitcoin/pull/8256
35 2016-06-24 11:58:52 0|Lauda|Has the source of the re-index slowdown been discovered?
36 2016-06-24 12:03:36 0|wumpus|I don't think so? I don't think it's even clear yet whether there is one, but you should refer to the issue: https://github.com/bitcoin/bitcoin/issues/8245
37 2016-06-24 12:03:59 0|wumpus|you could help by doing reindex tests with different revisions/versions
38 2016-06-24 12:15:19 0|Lauda|Does someone have a link to download a/some version(s)? I'd waste additionaly time building them otherwise
39 2016-06-24 12:15:24 0|Lauda|I'd be happy to help.
40 2016-06-24 12:15:54 0|Lauda|additional*
41 2016-06-24 12:19:26 0|MarcoFalke|Lauda: there are nightly builds
42 2016-06-24 12:19:31 0|Lauda|Where?
43 2016-06-24 12:20:08 0|MarcoFalke|https://bitcoin.jonasschnelli.ch/nightlybuilds/
44 2016-06-24 12:20:53 0|Lauda|Thanks. I'm on it, and will post the results once done.
45 2016-06-24 13:55:47 0|sipa|the ThreadSafeMessageBox for "Do you want to reindex now" only has an BTN_ABORT button?
46 2016-06-24 13:57:08 0|sipa|why is it even a yes/no question then
47 2016-06-24 13:58:17 0|wumpus|it should have a yes/no button
48 2016-06-24 13:58:23 0|wumpus|if not, that's a regression
49 2016-06-24 14:00:11 0|wumpus|it's the only place where the return value of ThreadSafeMessageBox is used
50 2016-06-24 14:00:21 0|wumpus|if there is only one return value that's pertty pointless
51 2016-06-24 14:01:23 0|sipa|i think that function should just be replaced with two simpler functions void UIMessage(string) and bool UIQuestion(string)
52 2016-06-24 14:02:04 0|sipa|ah, MODAL is used for payment protocol
53 2016-06-24 14:02:18 0|sipa|isn't that unnecessarily intrusive?
54 2016-06-24 14:02:27 0|wumpus|adding an UIQuestion would make sense, it could return a default value in case of no ui
55 2016-06-24 14:02:35 0|wumpus|I don't think it's a good time to change the rest of that stuff
56 2016-06-24 14:03:05 0|sipa|agree
57 2016-06-24 14:04:44 0|sipa|i'll make a minimal change for 0.13, and a follow-up refactor for master post branching
58 2016-06-24 14:05:44 0|wumpus|sounds good to me
59 2016-06-24 14:06:33 0|wumpus|sipa: it should have an OK button too
60 2016-06-24 14:06:45 0|wumpus|sipa: MSG_ERROR = (ICON_ERROR | BTN_OK | MODAL)
61 2016-06-24 14:06:49 0|sipa|ah!
62 2016-06-24 14:06:58 0|wumpus|CClientUIInterface::MSG_ERROR | CClientUIInterface::BTN_ABORT
63 2016-06-24 14:07:03 0|sipa|that's confusing, but agree
64 2016-06-24 14:07:08 0|wumpus|so it has an OK and ABORT button
65 2016-06-24 14:07:55 0|wumpus|yes, well, that stuff was inherited from the wx client, I agree it would be better in terms of UIMessage, UIQuestion, the MODAL stuff is only used within the GUI code itself so could use something else
66 2016-06-24 14:08:56 0|wumpus|(the problem there is that paymentserver wasn't designed in the typical qt way with a model and view, so instead of displaying a alert directly, which would be weird in server code, it works around that by abusing the core->ui messaging system :-)
67 2016-06-24 14:09:50 0|wumpus|so once you start refactoring you'll probably bump against all kinds of things which grew over time and don't exactly fit into the new, cleaned vision
68 2016-06-24 14:12:47 0|wumpus|paymentserver should have a dedicated signal for messages to the user
69 2016-06-24 14:12:55 0|wumpus|(and the GUI should subscribe to that)
70 2016-06-24 14:13:22 0|sipa|there are 9 call sites to ThreadSafeMessageBox
71 2016-06-24 14:13:34 0|sipa|that's more than i expected, but not particularly much either
72 2016-06-24 14:14:01 0|wumpus|must of the calls are InitMessage/InitWarnings
73 2016-06-24 14:14:15 0|wumpus|InitError*
74 2016-06-24 14:14:18 0|sipa|i call those as a single call site
75 2016-06-24 14:14:21 0|sipa|*count
76 2016-06-24 14:14:31 0|wumpus|I know, but I mean, all in al the function is used quite a lot
77 2016-06-24 14:14:37 0|sipa|right
78 2016-06-24 14:15:04 0|wumpus|ideally the core would communicate with the GUI through status codes/bits instead of sending whole messages
79 2016-06-24 14:15:18 0|wumpus|I mean, the user-facing text belongs in the GUI
80 2016-06-24 14:15:43 0|wumpus|the _(...) workaround which is hooked by the GUI is pretty weird
81 2016-06-24 14:15:57 0|sipa|yes
82 2016-06-24 14:16:12 0|wumpus|then again, it was never really urgent to change, at least it works
83 2016-06-24 14:16:32 0|wumpus|these are things you can spent weeks on, without anything affecting the user-facing side
84 2016-06-24 14:35:55 0|GitHub195|[13bitcoin] 15sipa opened pull request #8257: Do not ask a UI question from bitcoind (06master...06noask) 02https://github.com/bitcoin/bitcoin/pull/8257
85 2016-06-24 16:07:37 0|wumpus|okay, here we go
86 2016-06-24 16:07:59 0|wumpus|IRC flood upcoming
87 2016-06-24 16:08:09 0|btcdrak|LOL
88 2016-06-24 16:09:54 0|GitHub54|[13bitcoin] 15laanwj pushed 28 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/af2421c291c4...d61283781402
89 2016-06-24 16:09:55 0|GitHub54|13bitcoin/06master 147030d9e 15Pieter Wuille: BIP144: Serialization, hashes, relay (sender side)...
90 2016-06-24 16:09:55 0|GitHub54|13bitcoin/06master 14ecacfd9 15Pieter Wuille: --- [SEGWIT] begin: P2P/node/consensus ---
91 2016-06-24 16:09:56 0|GitHub54|13bitcoin/06master 14449f9b8 15Pieter Wuille: BIP141: Witness program
92 2016-06-24 16:09:59 0|GitHub34|[13bitcoin] 15laanwj closed pull request #8149: Segregated witness rebased (06master...06segwit-master2) 02https://github.com/bitcoin/bitcoin/pull/8149
93 2016-06-24 16:10:28 0|wumpus|that's disappointing, does it print only at most three commits?
94 2016-06-24 16:10:36 0|jl2012|\o/
95 2016-06-24 16:11:04 0|achow101|woo!
96 2016-06-24 16:11:22 0|wumpus|sipa: yes like true developers, let's do a release now and go on holiday :')
97 2016-06-24 16:12:03 0|sipa|of course
98 2016-06-24 16:12:12 0|wumpus|it's deployed! seeya!
99 2016-06-24 16:12:14 0|Ylbam|lol
100 2016-06-24 16:12:23 0|Ylbam|anyway \o/
101 2016-06-24 16:12:47 0|GitHub158|13bitcoin/06master 14f70bcfc 15fanquake: [trivial] Add aarch64 to depends .gitignore
102 2016-06-24 16:12:47 0|GitHub158|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/d61283781402...5cdc54b4b62d
103 2016-06-24 16:12:48 0|GitHub158|13bitcoin/06master 145cdc54b 15Wladimir J. van der Laan: Merge #8252: [trivial] Add aarch64 to depends .gitignore...
104 2016-06-24 16:12:52 0|GitHub8|[13bitcoin] 15laanwj closed pull request #8252: [trivial] Add aarch64 to depends .gitignore (06master...06depends-aarch-gitignore) 02https://github.com/bitcoin/bitcoin/pull/8252
105 2016-06-24 16:12:57 0|achow101|so what about the deployment stuff for segwit?
106 2016-06-24 16:13:15 0|wumpus|achow101: it's all described here: https://bitcoincore.org/en/2016/06/24/segwit-next-steps/
107 2016-06-24 16:15:22 0|instagibbs|\o/
108 2016-06-24 16:15:26 0|achow101|When do we decide deployment parameters
109 2016-06-24 16:15:36 0|instagibbs|achow101, after/during backport i think
110 2016-06-24 16:16:00 0|wumpus|yes
111 2016-06-24 16:16:12 0|achow101|ok
112 2016-06-24 16:16:17 0|wumpus|needs to be determined for the 0.12.2 release
113 2016-06-24 16:21:08 0|GitHub18|[13bitcoin] 15sipa closed pull request #7910: Segregated witness (06master...06segwit-master) 02https://github.com/bitcoin/bitcoin/pull/7910
114 2016-06-24 16:44:36 0|gmaxwell|Yippie.
115 2016-06-24 16:48:31 0|wumpus|yes, congrats everyone!
116 2016-06-24 16:58:25 0|GitHub9|[13bitcoin] 15jl2012 opened pull request #8258: RPC: Hide softfork if timeout is 0 (06master...06bip9rpcdisable) 02https://github.com/bitcoin/bitcoin/pull/8258
117 2016-06-24 16:58:45 0|GitHub53|[13bitcoin] 15jl2012 closed pull request #8209: Showing "not_applicable" if BIP9 timeout is 0 (06master...06patch-13) 02https://github.com/bitcoin/bitcoin/pull/8209
118 2016-06-24 16:59:31 0|helo|pretty exciting
119 2016-06-24 21:01:04 0|GitHub154|[13bitcoin] 15NicolasDorier opened pull request #8259: Cache hashes (06master...06cachedhashes) 02https://github.com/bitcoin/bitcoin/pull/8259
120 2016-06-24 23:41:31 0|randy-waterhouse|so git head should run fine on on testnet3 without any additional config changes or needs to go on segnet?
121 2016-06-24 23:42:12 0|gmaxwell|yes, though there may not be enough testnet nodes with it yet that you can get it to work right without an addnode.
122 2016-06-24 23:42:27 0|gmaxwell|One of the todos coming out of the meeting this week was to get more segwit testnet nodes up.
123 2016-06-24 23:43:22 0|randy-waterhouse|k, thnx ... what is the "Rewinding" part doing?
124 2016-06-24 23:44:08 0|gmaxwell|What it says-- segwit has been active on testnet for a couple months-- but your node wasn't able to verify the segwit rules... so it's undoing the chain and revalidating it to make sure there were no violations since it activated.
125 2016-06-24 23:44:31 0|gmaxwell|If you had been running segwit code on testnet before it activated you wouldn't have expirenced that.
126 2016-06-24 23:45:35 0|randy-waterhouse|ok, looks like I'm gonna need some addnodes, can I find a list of seggers?
127 2016-06-24 23:46:02 0|randy-waterhouse|or is it segwitters?
128 2016-06-24 23:50:06 0|randy-waterhouse|nm ... found one randomly
129 2016-06-24 23:50:39 0|randy-waterhouse|119.246.245.241
130 2016-06-24 23:50:39 0|sipa|i think we should call transactions with an invalid witness segfaults
131 2016-06-24 23:50:59 0|randy-waterhouse|please no segfaults
132 2016-06-24 23:53:57 0|randy-waterhouse|and here come the blocks ... my blockchain will never be the same again
133 2016-06-24 23:54:08 0|randy-waterhouse|feels like I just exited something
134 2016-06-24 23:54:20 0|randy-waterhouse|blexit