1 2016-08-17 07:35:55 0|jonasschnelli|luke-jr: requesting BIP number for the authentication BIP: https://github.com/jonasschnelli/bips/blob/2016/07/auth_bip/bip-undef-0.mediawiki
2 2016-08-17 07:38:43 0|luke-jr|jonasschnelli: isn't that what we already gave BIP 150?
3 2016-08-17 07:39:03 0|luke-jr|hm, I guess it's still marked tentative on my end; so BIP 150 :p
4 2016-08-17 07:39:08 0|jonasschnelli|luke-jr: Could be? Wasn't aware of that. Thanks
5 2016-08-17 07:39:36 0|luke-jr|jonasschnelli: used to be part of https://github.com/bitcoin/bips/pull/362, right?
6 2016-08-17 07:39:53 0|jonasschnelli|Ah. Right... it was combine at the PR level once.
7 2016-08-17 10:00:04 0|GitHub26|13bitcoin/06master 14936c144 15Wladimir J. van der Laan: build: Remove check for `openssl/ec.h`...
8 2016-08-17 10:00:04 0|GitHub26|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/2c2d471e18f0...b40e19c6c48f
9 2016-08-17 10:00:05 0|GitHub26|13bitcoin/06master 14b40e19c 15Wladimir J. van der Laan: Merge #8520: build: Remove check for `openssl/ec.h`...
10 2016-08-17 10:00:19 0|GitHub114|[13bitcoin] 15laanwj closed pull request #8520: build: Remove check for `openssl/ec.h` (06master...062016_08_remove_openssl_ech_check) 02https://github.com/bitcoin/bitcoin/pull/8520
11 2016-08-17 10:01:09 0|GitHub99|13bitcoin/06master 14c1582d5 15Wladimir J. van der Laan: qa: Remove duplicate `hash160` implementation...
12 2016-08-17 10:01:09 0|GitHub99|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/b40e19c6c48f...b41ac928b89f
13 2016-08-17 10:01:10 0|GitHub99|13bitcoin/06master 14b41ac92 15Wladimir J. van der Laan: Merge #8521: qa: Remove duplicate `hash160` implementation...
14 2016-08-17 10:01:17 0|GitHub157|[13bitcoin] 15laanwj closed pull request #8521: qa: Remove duplicate `hash160` implementation (06master...062016_08_hash160_dupe) 02https://github.com/bitcoin/bitcoin/pull/8521
15 2016-08-17 10:02:07 0|GitHub138|13bitcoin/06master 146ffd996 15Sev: Corrected JSON typo on setban of net.cpp
16 2016-08-17 10:02:07 0|GitHub138|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/b41ac928b89f...29496fc9e095
17 2016-08-17 10:02:08 0|GitHub138|13bitcoin/06master 1429496fc 15Wladimir J. van der Laan: Merge #8512: Trivial: Corrected JSON typo on setban of net.cpp...
18 2016-08-17 10:02:22 0|GitHub20|[13bitcoin] 15laanwj closed pull request #8512: Trivial: Corrected JSON typo on setban of net.cpp (06master...06setban) 02https://github.com/bitcoin/bitcoin/pull/8512
19 2016-08-17 10:26:44 0|GitHub170|[13bitcoin] 15laanwj pushed 4 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/29496fc9e095...740cff5808c3
20 2016-08-17 10:26:45 0|GitHub170|13bitcoin/06master 14fa2d68f 15MarcoFalke: [qa] Adjust timeouts for micro-optimization of run time
21 2016-08-17 10:26:45 0|GitHub170|13bitcoin/06master 14fae596f 15MarcoFalke: [qa] Sort scripts by time for pull_tester and don't overwrite setup_chain
22 2016-08-17 10:26:46 0|GitHub170|13bitcoin/06master 14fad8cf6 15MarcoFalke: [qa] Use single cache dir for chains
23 2016-08-17 10:26:50 0|GitHub62|[13bitcoin] 15laanwj closed pull request #8296: [qa] Don't overwrite setup_chain and sort scripts (06master...06Mf1607-qaSetupChain) 02https://github.com/bitcoin/bitcoin/pull/8296
24 2016-08-17 10:26:55 0|GitHub83|[13bitcoin] 15laanwj closed pull request #8482: [qa] Use single cache dir for chains (06master...06Mf1608-qaCache) 02https://github.com/bitcoin/bitcoin/pull/8482
25 2016-08-17 10:33:23 0|GitHub110|13bitcoin/06master 148194a6e 15Jeremy Rubin: Fix a type error that would not compile on Apple LLVM version 6.1.0 (clang-602.0.53) (based on LLVM 3.6.0svn)
26 2016-08-17 10:33:23 0|GitHub110|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/740cff5808c3...65e644418106
27 2016-08-17 10:33:24 0|GitHub110|13bitcoin/06master 1465e6444 15Wladimir J. van der Laan: Merge #8513: Fix a type error that would not compile on OSX....
28 2016-08-17 10:33:33 0|GitHub120|[13bitcoin] 15laanwj closed pull request #8513: Fix a type error that would not compile on OSX. (06master...06fix-osx-break) 02https://github.com/bitcoin/bitcoin/pull/8513
29 2016-08-17 10:51:37 0|GitHub146|13bitcoin/06master 141aacfc2 15leijurv: various typos
30 2016-08-17 10:51:37 0|GitHub146|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/65e644418106...e753eaeb343c
31 2016-08-17 10:51:38 0|GitHub146|13bitcoin/06master 14e753eae 15Wladimir J. van der Laan: Merge #8505: Trivial: Fix typos in various files...
32 2016-08-17 10:51:47 0|GitHub132|[13bitcoin] 15laanwj closed pull request #8505: Trivial: Fix typos in various files (06master...06replacable-typo) 02https://github.com/bitcoin/bitcoin/pull/8505
33 2016-08-17 10:53:19 0|sipa|m-m-m-megamerge
34 2016-08-17 11:07:16 0|GitHub176|[13bitcoin] 15laanwj pushed 4 new commits to 060.13: 02https://github.com/bitcoin/bitcoin/compare/4374f0ee35f8...a402396dce64
35 2016-08-17 11:07:17 0|GitHub176|13bitcoin/060.13 1440d705c 15Luke Dashjr: doc/release-notes: Mention the relevance of Compact Blocks on non-mining nodes' influence on network policy
36 2016-08-17 11:07:17 0|GitHub176|13bitcoin/060.13 144f55293 15Luke Dashjr: doc/release-notes: Misc
37 2016-08-17 11:07:17 0|GitHub55|[13bitcoin] 15laanwj closed pull request #8490: [0.13] release notes: Mention new relevance of non-mining nodes on network policy; and misc fixes (060.13...06relnotes_013_misc) 02https://github.com/bitcoin/bitcoin/pull/8490
38 2016-08-17 11:07:18 0|GitHub176|13bitcoin/060.13 145e499e7 15Luke Dashjr: doc/release-notes: Document changed bytespersigop behaviour
39 2016-08-17 11:12:43 0|GitHub138|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/e753eaeb343c...733035bdb755
40 2016-08-17 11:12:44 0|GitHub138|13bitcoin/06master 143c5251d 15Wladimir J. van der Laan: test: Remove java comparison tool
41 2016-08-17 11:12:44 0|GitHub138|13bitcoin/06master 14eb0c52e 15Wladimir J. van der Laan: travis: Remove hostname hack...
42 2016-08-17 11:12:45 0|GitHub138|13bitcoin/06master 14733035b 15Wladimir J. van der Laan: Merge #8504: test: Remove java comparison tool...
43 2016-08-17 11:12:54 0|GitHub95|[13bitcoin] 15laanwj closed pull request #8504: test: Remove java comparison tool (06master...062016_08_jexit) 02https://github.com/bitcoin/bitcoin/pull/8504
44 2016-08-17 11:28:07 0|GitHub97|[13bitcoin] 15MarcoFalke opened pull request #8531: [qa] abandonconflict: Use assert_equal (06master...06Mf1608-qaAssert) 02https://github.com/bitcoin/bitcoin/pull/8531
45 2016-08-17 13:01:02 0|jonasschnelli|Is there a way to locally detect unsafe iterator usage? https://travis-ci.org/bitcoin/bitcoin/jobs/152408747#L1413
46 2016-08-17 13:01:18 0|jonasschnelli|I compiled it locally on different machines and can't get that test failure...
47 2016-08-17 13:02:08 0|sipa|jonasschnelli: it requires rebuilding glibc with debug options, i think
48 2016-08-17 13:02:11 0|jonasschnelli|It could be a bug in gcc, I'm using std::prev(myVector.end()) which should be valid and safe?
49 2016-08-17 13:02:26 0|sipa|jonasschnelli: only if the vector is not empty
50 2016-08-17 13:02:51 0|jonasschnelli|Yes. There is a check for empty vectors above..
51 2016-08-17 13:02:57 0|sipa|ah, right
52 2016-08-17 13:03:21 0|jonasschnelli|I stepped with the debugger through the whole unit test and cannot fine a invalid std::prev
53 2016-08-17 13:03:47 0|jonasschnelli|*find
54 2016-08-17 13:04:39 0|sipa|maybe it's not in a call to std::prev?
55 2016-08-17 13:05:48 0|jonasschnelli|wait.. found the issue! nm
56 2016-08-17 13:06:08 0|jonasschnelli|There is a call of std::prev(vector.begin()) which is invalid
57 2016-08-17 16:47:41 0|btcdrak|Seeking reviews of the 0.13.0 release blog post https://github.com/bitcoin-core/bitcoincore.org/pull/199
58 2016-08-17 17:37:02 0|Anduck|bitcoin core slack has leaked my e-mail to scammers
59 2016-08-17 17:37:17 0|Anduck|i used unique e-mail when i joined bitcoincore.slack.com
60 2016-08-17 17:38:06 0|Anduck|do bitcoincore.slack.com maintainer/admin have access to the e-mails or does slack only have them?
61 2016-08-17 17:45:17 0|brg444|Anduck unfortunately that is just how slack is set up, every user's email address is public
62 2016-08-17 17:46:13 0|Anduck|i've not received any attempts from other slacks
63 2016-08-17 17:47:23 0|btcdrak|Anduck, this is a feature of Slack and cannot be changed. Anyone can slurp up all member emails addresses.
64 2016-08-17 17:47:36 0|Anduck|ok.
65 2016-08-17 17:47:38 0|Anduck|thanks for replys
66 2016-08-17 17:47:47 0|btcdrak|Anduck, make sure you use 2FA and a unique password.
67 2016-08-17 17:47:50 0|brg444|It's likely Core's slack is particularly targeted, unfortunately :/
68 2016-08-17 17:50:58 0|Anduck|i see, i see
69 2016-08-17 17:57:20 0|GitHub166|[13bitcoin] 15jl2012 opened pull request #8533: Implement LOW_S and NULLDUMMY softfork (BIP146) (06master...06bip146) 02https://github.com/bitcoin/bitcoin/pull/8533
70 2016-08-17 17:59:16 0|GitHub170|[13bitcoin] 15jl2012 closed pull request #8514: Enforce LOW_S rules on all transactions with WITNESS BIP9 parameters (06master...06lows) 02https://github.com/bitcoin/bitcoin/pull/8514
71 2016-08-17 19:37:31 0|GitHub1|[13bitcoin] 15MarcoFalke opened pull request #8534: [travis] Drop java (06master...06Mf1608-qaJava) 02https://github.com/bitcoin/bitcoin/pull/8534
72 2016-08-17 20:54:13 0|Chris_Stewart_5|In the bitcoin developer reference, when decoding a partial merkle tree it says: Fail if there are unused flag bitsââ¬âexcept for the minimum number of bits necessary to pad up to the next full byte.
73 2016-08-17 20:54:30 0|Chris_Stewart_5|I can't seem to actually find this anywhere in Core though -- is this an actual requirement?
74 2016-08-17 20:54:59 0|Chris_Stewart_5|https://github.com/bitcoin/bitcoin/blob/master/src/merkleblock.cpp#L136
75 2016-08-17 20:55:24 0|sipa|line 177
76 2016-08-17 20:59:01 0|Chris_Stewart_5|Hmm I guess I thought it would be in TraverseAndExtract I guess. Thanks
77 2016-08-17 21:21:43 0|phantomcircuit|while trying to fix 8445 i noticed that pwalletMain is NULL if -disablewallet is passed
78 2016-08-17 21:22:21 0|phantomcircuit|and yet the disablewallet test passes despite there being things doing pwalletMain-> accesses
79 2016-08-17 21:22:24 0|phantomcircuit|sipa: ^
80 2016-08-17 21:22:42 0|phantomcircuit|jonasschnelli: ^
81 2016-08-17 21:22:47 0|phantomcircuit|am i missing something here?
82 2016-08-17 21:23:05 0|gmaxwell|may be due to the compiler rerorginzing things so that those accesses don't happen
83 2016-08-17 21:24:37 0|phantomcircuit|gmaxwell: oooh im dumb
84 2016-08-17 21:24:44 0|phantomcircuit|pwalletMain ? pwalletMain->GetKeyPoolSize() : 0
85 2016-08-17 21:28:27 0|gmaxwell|or that
86 2016-08-17 22:35:30 0|jeremyrubin|Hey, what's the preffered practice for rebasing a PR onto master?
87 2016-08-17 22:36:05 0|jeremyrubin|push -f onto my branch ok?
88 2016-08-17 22:37:26 0|sipa|sure
89 2016-08-17 23:06:53 0|achow101|what's up with this: https://bitcoin.org/en/alert/2016-08-17-binary-safety
90 2016-08-17 23:07:00 0|sipa|we don't know
91 2016-08-17 23:07:23 0|achow101|so cobra went rogue?
92 2016-08-17 23:07:59 0|Lauda|If by rogue, you mean skipping the peer review process, then yes.
93 2016-08-17 23:36:25 0|phantomcircuit|cfields: is travis broken?
94 2016-08-17 23:36:40 0|phantomcircuit|8445 passes on my local system but not on travis and the travis failures keep changing
95 2016-08-17 23:37:28 0|cfields|phantomcircuit: unsure, will have a look
96 2016-08-17 23:37:54 0|cfields|achow101: erm, i'd say. no mention of gitian...
97 2016-08-17 23:41:57 0|cfields|phantomcircuit: https://github.com/bitcoin/bitcoin/issues/8532
98 2016-08-17 23:50:35 0|kanzure|jeremyrubin: force-pushing to your branch might be a little rude if anyone has been doing work on top of your branch. if you're pretty sure that's not happening, then go for it.
99 2016-08-17 23:51:32 0|gmaxwell|the question was related to PRs against master. people should not generally be doing work on top of those.
100 2016-08-17 23:51:50 0|gmaxwell|And we will often _require_ people to tidy up their branches before merging in any case.