1 2016-08-29 01:15:44 0|dcousens|sipa: boo C++ lol
2 2016-08-29 01:17:47 0|dcousens|What was the original motivations for const members in CTransaction?
3 2016-08-29 02:50:54 0|luke-jr|dcousens: I was wondering that myself, actually. I think it might have been to cache the hash, but with as much overhead as it seems to be taking now, I wonder if we might be better off with just literally caching it..
4 2016-08-29 02:53:06 0|dcousens|luke-jr: if not even through some auxillary lazy datastructure that has just the [possibly computed] hash and the underlying TX
5 2016-08-29 02:59:26 0|luke-jr|that's what I mean
6 2016-08-29 02:59:47 0|luke-jr|clear a bool when data is changed, and set it when we update the cached hash
7 2016-08-29 03:00:11 0|luke-jr|possibly threading issues though, not sure
8 2016-08-29 03:01:19 0|dcousens|I know it would definitely be measurable, but I wonder how significant the performance difference is to no cached tx->getHash
9 2016-08-29 03:01:49 0|dcousens|and, if highly significant, whether a localized solution would be better
10 2016-08-29 03:02:02 0|dcousens|(aka, localized to the problem where it occurs, not just 'in general')
11 2016-08-29 03:19:52 0|GitHub97|[13bitcoin] 15rebroad closed pull request #8618: [WIP] Erase orphans only when banned (06master...06EraseOrphansOnlyWhenBanned) 02https://github.com/bitcoin/bitcoin/pull/8618
12 2016-08-29 04:00:23 0|GitHub48|[13bitcoin] 15rebroad reopened pull request #8484: [WIP] More granular debug (06master...06MoreGranularDebug) 02https://github.com/bitcoin/bitcoin/pull/8484
13 2016-08-29 05:32:11 0|GitHub120|[13bitcoin] 15rebroad opened pull request #8622: [WIP] Clarify variable names (06master...06ClarifyVariableNames) 02https://github.com/bitcoin/bitcoin/pull/8622
14 2016-08-29 05:41:05 0|GitHub45|[13bitcoin] 15rebroad closed pull request #8622: [WIP] Clarify variable names (06master...06ClarifyVariableNames) 02https://github.com/bitcoin/bitcoin/pull/8622
15 2016-08-29 05:49:16 0|GitHub148|[13bitcoin] 15rebroad reopened pull request #8622: [WIP] Clarify variable names (06master...06ClarifyVariableNames) 02https://github.com/bitcoin/bitcoin/pull/8622
16 2016-08-29 06:03:58 0|GitHub128|[13bitcoin] 15rebroad closed pull request #8571: [WIP] Disconnect when a node doesn't offer the relevant services. (06master...06UnexpectedServicesNoDisconnect) 02https://github.com/bitcoin/bitcoin/pull/8571
17 2016-08-29 06:05:03 0|GitHub7|[13bitcoin] 15rebroad closed pull request #8622: [WIP] Clarify variable names (06master...06ClarifyVariableNames) 02https://github.com/bitcoin/bitcoin/pull/8622
18 2016-08-29 06:07:44 0|GitHub57|[13bitcoin] 15rebroad reopened pull request #8622: [WIP] Clarify variable names (06master...06ClarifyVariableNames) 02https://github.com/bitcoin/bitcoin/pull/8622
19 2016-08-29 07:27:16 0|GitHub97|[13bitcoin] 15rebroad closed pull request #8622: [WIP] Clarify variable names (06master...06ClarifyVariableNames) 02https://github.com/bitcoin/bitcoin/pull/8622
20 2016-08-29 07:31:17 0|GitHub13|[13bitcoin] 15rebroad closed pull request #8484: [WIP] More granular debug (06master...06MoreGranularDebug) 02https://github.com/bitcoin/bitcoin/pull/8484
21 2016-08-29 07:44:11 0|GitHub6|[13bitcoin] 15rebroad reopened pull request #8484: [WIP] More granular debug (06master...06MoreGranularDebug) 02https://github.com/bitcoin/bitcoin/pull/8484
22 2016-08-29 07:44:36 0|GitHub184|[13bitcoin] 15rebroad closed pull request #8484: [WIP] More granular debug (06master...06MoreGranularDebug) 02https://github.com/bitcoin/bitcoin/pull/8484
23 2016-08-29 07:50:50 0|GitHub129|[13bitcoin] 15MarcoFalke reopened pull request #8484: [WIP] More granular debug (06master...06MoreGranularDebug) 02https://github.com/bitcoin/bitcoin/pull/8484
24 2016-08-29 08:09:03 0|GitHub171|[13bitcoin] 15rebroad reopened pull request #8622: [WIP] Clarify variable names (06master...06ClarifyVariableNames) 02https://github.com/bitcoin/bitcoin/pull/8622
25 2016-08-29 08:10:18 0|GitHub64|[13bitcoin] 15rebroad closed pull request #8622: [WIP] Clarify variable names (06master...06ClarifyVariableNames) 02https://github.com/bitcoin/bitcoin/pull/8622
26 2016-08-29 08:18:33 0|GitHub190|[13bitcoin] 15daddinuz opened pull request #8623: chainparams: Added parametric halving interval for regtest-only mode (06master...06parametric_halving_interval) 02https://github.com/bitcoin/bitcoin/pull/8623
27 2016-08-29 08:35:27 0|GitHub120|[13bitcoin] 15MarcoFalke opened pull request #8624: [doc] build: Mention curl (06master...06Mf1608-docCurl) 02https://github.com/bitcoin/bitcoin/pull/8624
28 2016-08-29 09:05:51 0|btcdrak|I was thinking the same,
29 2016-08-29 09:09:48 0|sipa|likewise
30 2016-08-29 09:28:58 0|sipa|maybe suggest that if he doesn't fully understand what the code is doing, his first reaction shouldn't be to go change it, but that PRs that just add comments to explain how/why things work would be welcome
31 2016-08-29 09:35:30 0|btcdrak|yes it is much easier to ask quickly on IRC to get clarity or direction.
32 2016-08-29 14:16:46 0|GitHub161|13bitcoin/06master 14beef966 15Jonas Schnelli: [Wallet] remove unused code/conditions in ReadAtCursor
33 2016-08-29 14:16:46 0|GitHub161|[13bitcoin] 15sipa pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/a5bb6387f751...01680195f8aa
34 2016-08-29 14:16:47 0|GitHub161|13bitcoin/06master 140168019 15Pieter Wuille: Merge #8564: [Wallet] remove unused code/conditions in ReadAtCursor...
35 2016-08-29 14:17:01 0|GitHub199|[13bitcoin] 15sipa closed pull request #8564: [Wallet] remove unused code/conditions in ReadAtCursor (06master...062016/08/bdb_abstraction_1) 02https://github.com/bitcoin/bitcoin/pull/8564
36 2016-08-29 14:18:01 0|GitHub154|13bitcoin/06master 14b729fcd 15Luke Dashjr: Include instructions to extract Mac OS X SDK on Linux using 7zip and SleuthKit
37 2016-08-29 14:18:01 0|GitHub154|[13bitcoin] 15sipa pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/01680195f8aa...de07fdcf77e9
38 2016-08-29 14:18:02 0|GitHub154|13bitcoin/06master 14de07fdc 15Pieter Wuille: Merge #8617: Include instructions to extract Mac OS X SDK on Linux using 7zip and SleuthKit...
39 2016-08-29 14:18:16 0|GitHub24|[13bitcoin] 15sipa closed pull request #8617: Include instructions to extract Mac OS X SDK on Linux using 7zip and SleuthKit (06master...06gitian_osx_extractor) 02https://github.com/bitcoin/bitcoin/pull/8617
40 2016-08-29 14:19:11 0|GitHub160|13bitcoin/06master 14fae6bb8 15MarcoFalke: [doc] build: Mention curl
41 2016-08-29 14:19:11 0|GitHub160|[13bitcoin] 15sipa pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/de07fdcf77e9...89de1538ce1f
42 2016-08-29 14:19:12 0|GitHub160|13bitcoin/06master 1489de153 15Pieter Wuille: Merge #8624: [doc] build: Mention curl...
43 2016-08-29 14:19:25 0|GitHub32|[13bitcoin] 15sipa closed pull request #8478: Ubuntu 14.04 server installs w/o curl (06master...06patch-3) 02https://github.com/bitcoin/bitcoin/pull/8478
44 2016-08-29 14:19:26 0|GitHub97|[13bitcoin] 15sipa closed pull request #8624: [doc] build: Mention curl (06master...06Mf1608-docCurl) 02https://github.com/bitcoin/bitcoin/pull/8624
45 2016-08-29 17:29:30 0|instagibbs|do we want backport of feeler connections for 0.13.1?
46 2016-08-29 17:29:47 0|sipa|i'd like to
47 2016-08-29 17:29:48 0|instagibbs|oh whoops, already marked
48 2016-08-29 17:29:55 0|instagibbs|I think it's a good idea
49 2016-08-29 17:30:03 0|sipa|but 0.13.1 is starting to look like a pretty big change
50 2016-08-29 17:37:22 0|gmaxwell|I think we should, because it will offset some of the peering loss, due to selective witness peering. At least it's a very small change.
51 2016-08-29 17:39:00 0|instagibbs|I did some review of it couple days ago, it's quite small indeed
52 2016-08-29 18:06:37 0|reveredge|anyone
53 2016-08-29 18:20:22 0|sipa|no