1 2016-09-20 00:45:05	0|dcousens|jonasschnelli: 8757 tag as wallet?
  2 2016-09-20 00:57:28	0|dcousens|also, just a crash after a long time running, only non RPC-related debug I have that was 'in the vicinity' is https://gist.githubusercontent.com/dcousens/be26e196b308fb3a8aa6c085a093d1d1/raw/f3e48e9f0283699727f4c2a4fff9f4bb2542a16f/gistfile1.txt
  3 2016-09-20 00:57:48	0|dcousens|not sure if there is enough info worth reporting as an issue
  4 2016-09-20 00:59:06	0|gmaxwell|dcousens: what code is that node running?
  5 2016-09-20 00:59:37	0|dcousens|gmaxwell: master + a ~5 custom RPC calls, though haven't had an issues with them for months
  6 2016-09-20 01:00:21	0|dcousens|will get commit hash, probably a few PRs behind
  7 2016-09-20 01:01:00	0|gmaxwell|I see no crashes on any of my 0.13 or master nodes at least.
  8 2016-09-20 01:01:07	0|dcousens|ddc308068d69c6c9aa629ee3c4ce75e1d1cf08b5 (Sep 8)
  9 2016-09-20 01:01:44	0|dcousens|gmaxwell: I'll keep watch, any debug options worth throwing on to catch if happens again?
 10 2016-09-20 01:02:00	0|gmaxwell|if you have space for it... debug=1 is most helpful.
 11 2016-09-20 01:02:27	0|gmaxwell|also run with daemon=0 in screen so if it crashes and spits anyhting on the console you can catch it.
 12 2016-09-20 01:02:45	0|dcousens|gmaxwell: sure,  I run it in tmux
 13 2016-09-20 01:02:56	0|dcousens|never as daemon anyway
 14 2016-09-20 01:03:20	0|gmaxwell|(running in gdb is an option too, though I believe it will slow it down some)
 15 2016-09-20 01:03:52	0|dcousens|its being used heavily, but not mission critical, so probably will avoid the slow down, for now anyway
 16 2016-09-20 01:04:47	0|dcousens|gmaxwell: cheers, will let you know if it happens again
 17 2016-09-20 01:05:12	0|dcousens|(and isn't an RPC issue)
 18 2016-09-20 02:20:14	0|GitHub27|[13bitcoin] 15murtyjones opened pull request #8762: Trivial: Fix typo (06master...06patch-1) 02https://github.com/bitcoin/bitcoin/pull/8762
 19 2016-09-20 05:43:54	0|GitHub2|[13bitcoin] 15CryptAxe opened pull request #8763: Optionally sweep funds from private key. (06master...062751PullRequest) 02https://github.com/bitcoin/bitcoin/pull/8763
 20 2016-09-20 06:08:39	0|gmaxwell|TD-Linux: ::sigh:: yea, 64kB is insanely small. I wonder why its so low.
 21 2016-09-20 06:12:42	0|TD-Linux|gmaxwell, dunno, it doesn't make much sense with a single-user system. probably just very few users of mlock() to complain
 22 2016-09-20 06:15:15	0|gmaxwell|TD-Linux: well it messes up all the realtime multimedia apps, but those just tell you to go radically increase it.
 23 2016-09-20 06:20:10	0|TD-Linux|is fedora the only distro that does it? maybe just post on fedora-devel. what are you trying to mlock, wallet private keys?
 24 2016-09-20 06:20:42	0|gmaxwell|TD-Linux: yes.
 25 2016-09-20 06:21:28	0|TD-Linux|I can also post... what's the max you'd expect to use?
 26 2016-09-20 06:22:19	0|gmaxwell|A large wallet will use about 300kB apparently.
 27 2016-09-20 06:23:36	0|gmaxwell|might want to look at what the ardour people ask users to set.
 28 2016-09-20 06:33:07	0|luke-jr|Gentoo seems to be 64k default also FWIW
 29 2016-09-20 06:35:01	0|gmaxwell|64
 30 2016-09-20 06:35:01	0|gmaxwell|$ ulimit -l
 31 2016-09-20 06:35:05	0|gmaxwell|^ sure enough
 32 2016-09-20 06:43:23	0|TD-Linux|looks like fedora has special rules for jackd that give it 4GB
 33 2016-09-20 07:58:32	0|wumpus|gmaxwell: that's useful to know but IMO an issue for another time and should not hold up progress on 8753. If only 32kb is available the first arena will be 32kb, which means it will at least use everything allotted to it. We coudl add a warning to the log in that case I guess but the only solution is to a) use a distribution with sane defaults b) change the ulimits
 34 2016-09-20 07:59:37	0|jonasschnelli|Anyone interested in reviewing/acking https://github.com/bitcoin/bitcoin/pull/7783 (nested commands for Qt), and https://github.com/bitcoin/bitcoin/pull/8371 (out-of-sync info layer)?
 35 2016-09-20 07:59:55	0|jonasschnelli|Getting them in asap leave enough time to polish them for 0.14
 36 2016-09-20 08:00:10	0|wumpus|I don't know exactly why it uses so much locked memory, I do know that the usage is about 50% less with 8753, so it's on the right track to improving things
 37 2016-09-20 08:01:02	0|gmaxwell|wumpus: I wouldn't consider suggesting delaying that PR.
 38 2016-09-20 08:01:09	0|wumpus|this makes it easier to figure out though, at least more statistics could be addede to getmemoryinfo
 39 2016-09-20 08:01:20	0|wumpus|e.g. number of allocated chunks may be useful
 40 2016-09-20 08:01:47	0|wumpus|could even use standard heap profiling techniques now such as storing the traceback for every alloc
 41 2016-09-20 08:03:11	0|GitHub102|13bitcoin/06master 140766d1c 15isle2983: [copyright] add MIT license headers to .sh scripts where missing...
 42 2016-09-20 08:03:11	0|GitHub102|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/d8b4b631c5be...82eacc786d8d
 43 2016-09-20 08:03:12	0|GitHub102|13bitcoin/06master 1482eacc7 15Wladimir J. van der Laan: Merge #8700: [copyright] add MIT license headers to .sh scripts where missing...
 44 2016-09-20 08:03:21	0|GitHub147|[13bitcoin] 15laanwj closed pull request #8700: [copyright] add MIT license headers to .sh scripts where missing (06master...06sh-copyright) 02https://github.com/bitcoin/bitcoin/pull/8700
 45 2016-09-20 08:03:23	0|gmaxwell|how many keys did your 300k-mlockedmemory wallet have?
 46 2016-09-20 08:05:08	0|wumpus|let me see. gah getwalletinfo is hanging
 47 2016-09-20 08:05:19	0|wumpus|"keypoolsize": 10000,
 48 2016-09-20 08:05:40	0|gmaxwell|well.. 300k ~= 10000*32
 49 2016-09-20 08:06:19	0|wumpus|yes :)
 50 2016-09-20 08:06:55	0|gmaxwell|It would be sad if we successfully get N bytes of locked ram, use it to store X encrypted keys, then when decrypting the decrypted keys end up in non-locked ram.
 51 2016-09-20 08:07:40	0|wumpus|it's not an encrypted wallet
 52 2016-09-20 08:07:58	0|wumpus|but yes that'd be sad, I don't think it's necessary to use locked ram for encrypted keys?
 53 2016-09-20 08:08:26	0|wumpus|I mean it's the same data as is in wallet.dat anyhow
 54 2016-09-20 08:08:28	0|gmaxwell|I'd guess we should only put the master key and unencrypted keys in locked ram. And if the wallet is encrypted then we should need very little locked ram, since we really only need to have one key actually decrypted at a time.
 55 2016-09-20 08:08:50	0|wumpus|this would only be an issue if you have an encrypted disk but not encrypted swap
 56 2016-09-20 08:08:57	0|wumpus|in which case your setup is stupid
 57 2016-09-20 08:09:24	0|gmaxwell|wumpus: I agree. (though also discovered that somehow my swap wasn't encrypted.. just recently)
 58 2016-09-20 08:09:24	0|wumpus|so yes, encrypted keys do not need to be stored in lcoked ram
 59 2016-09-20 08:09:55	0|wumpus|openbsd does that by default since 2005 *ducks*
 60 2016-09-20 08:10:20	0|gmaxwell|wumpus: I've done it by default since before then. :P
 61 2016-09-20 08:12:21	0|wumpus|I was surprised openbsd gives 5MiB or so of locked ram by default to processes, it's not usually known for its lenient ulimits (  https://github.com/bitcoin/bitcoin/blob/master/doc/build-openbsd.md#resource-limits :p)
 62 2016-09-20 08:57:34	0|wumpus|"chunks_used": 10190,    yes, the steady state seems a chunk for each key
 63 2016-09-20 09:01:15	0|wumpus|which makes sense. We should change the wallet to not use locked memory for encrypted keys, and it will go to around ~0
 64 2016-09-20 09:02:20	0|wumpus|(well, for encrypted wallets, but that's when you'd expect increased security. For the unencrypted wallet the attacker can grab wallet.dat instead of the swap file)
 65 2016-09-20 09:03:18	0|wumpus|also on platforms such as windows (I think), osx, ubuntu, openbsd it's no problem to use a lot of locked memory. It's mostly just fine
 66 2016-09-20 09:03:48	0|wumpus|(to be clear here I call 512kB 'a lot')
 67 2016-09-20 09:16:48	0|phantomcircuit|wumpus: can you take a look at 8696 ?
 68 2016-09-20 09:17:04	0|phantomcircuit|im blocked on other changes to the CWalletDB stuff
 69 2016-09-20 10:02:16	0|wumpus|jonasschnelli, phantomcircuit will take a look at those
 70 2016-09-20 10:04:14	0|mang0_|Does anyone know the best place to get a small fast bitcoin loan?
 71 2016-09-20 10:04:38	0|mang0_|whoops wrong channel
 72 2016-09-20 10:46:15	0|GitHub13|13bitcoin/06master 14faddd62 15MarcoFalke: init: Get rid of some ENABLE_WALLET
 73 2016-09-20 10:46:15	0|GitHub13|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/82eacc786d8d...02ac669730c0
 74 2016-09-20 10:46:16	0|GitHub13|13bitcoin/06master 1402ac669 15Wladimir J. van der Laan: Merge #8760: [init] Get rid of some ENABLE_WALLET...
 75 2016-09-20 10:46:29	0|GitHub78|[13bitcoin] 15laanwj closed pull request #8760: [init] Get rid of some ENABLE_WALLET (06master...06Mf1609-walletInitGuard) 02https://github.com/bitcoin/bitcoin/pull/8760
 76 2016-09-20 10:47:51	0|GitHub55|[13bitcoin] 15laanwj pushed 5 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/02ac669730c0...a1f8d3ed9569
 77 2016-09-20 10:47:52	0|GitHub55|13bitcoin/06master 1459adc86 15Patrick Strateman: Add CWallet::ListAccountCreditDebit...
 78 2016-09-20 10:47:52	0|GitHub55|13bitcoin/06master 14d2e678d 15Patrick Strateman: Add CWallet::ReorderTransactions and use in accounting_tests.cpp
 79 2016-09-20 10:47:53	0|GitHub55|13bitcoin/06master 1402e2a81 15Patrick Strateman: Remove pwalletdb parameter from CWallet::AddAccountingEntry
 80 2016-09-20 10:48:02	0|GitHub182|[13bitcoin] 15laanwj closed pull request #8696: [Wallet] Remove last external reference to CWalletDB (06master...062016-09-09-cwallet-listaccountcreditdebit) 02https://github.com/bitcoin/bitcoin/pull/8696
 81 2016-09-20 10:50:03	0|GitHub169|[13bitcoin] 15laanwj pushed 4 new commits to 060.13: 02https://github.com/bitcoin/bitcoin/compare/4731623777ab...8d9e8adc05f4
 82 2016-09-20 10:50:03	0|GitHub21|[13bitcoin] 15laanwj closed pull request #8744: [0.13.1] qa Backports (060.13...06Mf1609-qaBackports) 02https://github.com/bitcoin/bitcoin/pull/8744
 83 2016-09-20 10:50:04	0|GitHub169|13bitcoin/060.13 1463462c2 15whythat: [qa] remove root test directory for RPC tests...
 84 2016-09-20 10:50:04	0|GitHub169|13bitcoin/060.13 14ae8c7df 15MarcoFalke: [qa] create_cache: Delete temp dir when done...
 85 2016-09-20 10:50:05	0|GitHub169|13bitcoin/060.13 14d6ebe13 15MarcoFalke: [qa] Refactor RPCTestHandler to prevent TimeoutExpired...
 86 2016-09-20 10:50:54	0|phantomcircuit|wumpus: ty
 87 2016-09-20 12:00:58	0|wumpus|jonasschnelli: #7783 seems to work great, can't seem to break it on first try at least :)
 88 2016-09-20 12:01:21	0|jonasschnelli|wumpus: heh. Yes. It's surprisingly stable. :)
 89 2016-09-20 12:03:14	0|wumpus|created some monster expressions using echo/echon and it works
 90 2016-09-20 12:05:50	0|jonasschnelli|wumpus: It would also be not-very-complicate to add some expressions (basic math ops). Like sendtoaddress(getnewaddress(), getbalance()/2)
 91 2016-09-20 12:05:57	0|jonasschnelli|but meh
 92 2016-09-20 12:06:26	0|wumpus|nah, that's probably going too far
 93 2016-09-20 12:06:42	0|wumpus|may as well add a complete js interpreter then and ne done with it *ducks*
 94 2016-09-20 12:06:49	0|jonasschnelli|heh
 95 2016-09-20 12:07:07	0|jonasschnelli|we could include node.js ...
 96 2016-09-20 12:07:19	0|jonasschnelli|and migrate the whole Qt stack to CSS/HTML with node.js.
 97 2016-09-20 12:07:39	0|jonasschnelli|And.. while we'r at it,... include an app store
 98 2016-09-20 12:09:10	0|wumpus|hahahah there have actually been people proposing that last thing
 99 2016-09-20 12:09:39	0|wumpus|'wallet applications' that run inside bitcoin core
100 2016-09-20 12:09:46	0|wumpus|absolutely crazy from a security perspective
101 2016-09-20 12:10:35	0|jonasschnelli|heh. Yes. Full access to privat keys... the plugin may want to do a sweep operation. :)
102 2016-09-20 12:10:38	0|wumpus|even having a semi-capable interpreter in the address space makes exploitation easier, but ok, that's pretty far-out. But explicitly including a sandbox for third-party code in your wallet is plain sick.
103 2016-09-20 12:11:20	0|wumpus|yes :)
104 2016-09-20 12:13:18	0|wumpus|from a technical point of view it'd be really easy to do, just link qtscript/qjsengine
105 2016-09-20 12:15:13	0|wumpus|anyhow ACK on #7783
106 2016-09-20 12:15:58	0|GitHub67|13bitcoin/06master 141586044 15Jonas Schnelli: [Qt] RPC-Console: support nested commands and simple value queries...
107 2016-09-20 12:15:58	0|GitHub67|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/a1f8d3ed9569...4335d5a41bc2
108 2016-09-20 12:15:59	0|GitHub67|13bitcoin/06master 144335d5a 15Wladimir J. van der Laan: Merge #7783: [Qt] RPC-Console: support nested commands and simple value queries...
109 2016-09-20 12:16:03	0|GitHub141|[13bitcoin] 15laanwj closed pull request #7783: [Qt] RPC-Console: support nested commands and simple value queries (06master...062016/04/qt_console_nested) 02https://github.com/bitcoin/bitcoin/pull/7783
110 2016-09-20 12:57:31	0|GitHub129|[13bitcoin] 15jonasschnelli opened pull request #8764: [Wallet] get rid of pwalletMain, add simple CWallets infrastructure (06master...062016/09/wallet_pointer) 02https://github.com/bitcoin/bitcoin/pull/8764
111 2016-09-20 13:34:53	0|GitHub161|[13bitcoin] 15jonasschnelli pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/4335d5a41bc2...6052d5091057
112 2016-09-20 13:34:54	0|GitHub161|13bitcoin/06master 14c015634 15Hampus Sjöberg: qt: Adding transaction size to transaction details window
113 2016-09-20 13:34:54	0|GitHub161|13bitcoin/06master 14fdf82fb 15Hampus Sjöberg: Adding method GetTotalSize() to CTransaction...
114 2016-09-20 13:34:55	0|GitHub161|13bitcoin/06master 146052d50 15Jonas Schnelli: Merge #8672: Qt: Show transaction size in transaction details window...
115 2016-09-20 13:35:03	0|GitHub165|[13bitcoin] 15jonasschnelli closed pull request #8672: Qt: Show transaction size in transaction details window (06master...06qttxsizeindetails) 02https://github.com/bitcoin/bitcoin/pull/8672
116 2016-09-20 13:45:30	0|GitHub175|13bitcoin/06master 1412a721b 15Marty Jones: Trivial: Fix typo
117 2016-09-20 13:45:30	0|GitHub175|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/6052d5091057...aff69278063c
118 2016-09-20 13:45:31	0|GitHub175|13bitcoin/06master 14aff6927 15Wladimir J. van der Laan: Merge #8762: Trivial: Fix typo...
119 2016-09-20 13:45:42	0|GitHub164|[13bitcoin] 15laanwj closed pull request #8762: Trivial: Fix typo (06master...06patch-1) 02https://github.com/bitcoin/bitcoin/pull/8762
120 2016-09-20 13:48:10	0|jonasschnelli|https://github.com/bitcoin/bitcoin/blob/master/src/wallet/rpcdump.cpp#L347
121 2016-09-20 13:48:25	0|jonasschnelli|(doesn't this spin off another wallet flush thread that runs endless)?
122 2016-09-20 13:49:20	0|wumpus|eh ...
123 2016-09-20 13:49:48	0|wumpus|it changes a RPC thread to another wallet flush thread
124 2016-09-20 13:49:55	0|wumpus|good catch, that's weird
125 2016-09-20 13:50:27	0|wumpus|(to actually spawn a thread it'd need to do create_thread, but wtf why would it call a thread main function from aRPC call?!?)
126 2016-09-20 13:50:44	0|wumpus|does that RPC ever return? I'd guess not
127 2016-09-20 13:51:39	0|jonasschnelli|wumpus: Yes. It grabs the RPC thread and runs endless... right?
128 2016-09-20 13:53:04	0|jonasschnelli|I guess this occupies a rpc-thread per removeprunedfunds call
129 2016-09-20 13:53:49	0|wumpus|how the hell can the RPC test 'importprunedfunds.py' pass
130 2016-09-20 13:53:55	0|wumpus|it exercises that RPC
131 2016-09-20 13:54:25	0|wumpus|the same is done in IMportPrunedFunds btw
132 2016-09-20 13:54:52	0|jonasschnelli|I think it can pass because the test does not exceed the amount of parallel PRC threads...
133 2016-09-20 13:55:01	0|wumpus|but it should never return
134 2016-09-20 13:55:02	0|jonasschnelli|But... right.. the calls never returns?!
135 2016-09-20 13:55:26	0|wumpus|anyhow if the author wast rying to flush the wallet database, that's not the right way to do it
136 2016-09-20 13:55:28	0|jonasschnelli|wumpus: timeout?
137 2016-09-20 13:55:38	0|wumpus|not sure if explicit flushes are even needed?
138 2016-09-20 13:55:43	0|wumpus|timeout would be an error
139 2016-09-20 13:56:54	0|wumpus|it never gets to loopin, see the fOneThread check in the beginning
140 2016-09-20 13:56:58	0|jonasschnelli|I guess a CWallet::Flush() should also do it.
141 2016-09-20 13:57:15	0|wumpus|the whole thing is NOP, *apart* from renaming the RPC thread to 'bitcoin-wallet' :')
142 2016-09-20 13:57:19	0|jonasschnelli|wumpus: Ah. Right. the fOneThread
143 2016-09-20 13:57:49	0|wumpus|we should delete these, replace with CWallet::Flush if it needs explicit flush
144 2016-09-20 13:58:03	0|wumpus|although I don't see the logic here, why do some wallet calls need explicit flush and others don't?
145 2016-09-20 13:58:24	0|sipa|importing a key should flush
146 2016-09-20 13:58:50	0|sipa|sending a transaction maybe not
147 2016-09-20 13:58:52	0|jonasschnelli|A flush in pruning funds could be done for privacy ... but also on lots of other locations..
148 2016-09-20 13:59:15	0|sipa|what does privacy have to do with it?
149 2016-09-20 13:59:32	0|wumpus|apparently the importprunedfunds doesn't flush, only the removepruned funds tries to (in this weird way)
150 2016-09-20 13:59:43	0|wumpus|I think this requirement needs to be well-documented
151 2016-09-20 13:59:55	0|wumpus|when does the wallet need explicit flushes and how to do it
152 2016-09-20 14:00:04	0|wumpus|this easily confuses me at least
153 2016-09-20 14:00:27	0|sipa|well whenever you could otherwise lose data, i would say
154 2016-09-20 14:00:43	0|sipa|*lose funds
155 2016-09-20 14:00:54	0|wumpus|isn't that on all calls that mutate wallet state?
156 2016-09-20 14:01:10	0|wumpus|okay, only those that add or generate keys then
157 2016-09-20 14:02:05	0|sipa|getnewaddress no, but yes when the keypool was topped up
158 2016-09-20 14:02:28	0|wumpus|right
159 2016-09-20 14:02:56	0|wumpus|and we should rename THreadFlushWalletDB. It doesn't just flush, it periodically closes and checkpoints (compacts) the database.
160 2016-09-20 14:03:32	0|sipa|phantomcircuit: are you working on thatm
161 2016-09-20 14:03:34	0|wumpus|so it's different from cwallet->Flush which (I assume) does a flush
162 2016-09-20 14:05:29	0|jonasschnelli|ThreadFlushWalletDB directly operates with a file to the walletdb and with the global bitdb
163 2016-09-20 14:05:50	0|wumpus|yes. It's pretty serious magic.
164 2016-09-20 14:06:14	0|jonasschnelli|heh
165 2016-09-20 14:06:18	0|wumpus|we shoud be happy the the fOneTHread check is at the top of it, or I could imagine two of those threads shredding the wallet together
166 2016-09-20 14:07:18	0|jonasschnelli|I really wonder how a repetitive call `bitdb.CloseDb(strFile);` without a follow up "Open" does work
167 2016-09-20 14:07:34	0|wumpus|it's automagically reopened on next use
168 2016-09-20 14:07:43	0|jonasschnelli|hahaha
169 2016-09-20 14:08:00	0|jonasschnelli|automagically ... lol
170 2016-09-20 14:08:21	0|wumpus|but yes it's things like this that make people afraid to touch, maybe even look at the wallet code :)
171 2016-09-20 14:09:06	0|wumpus|I really wonder if it's necessary to be so hacky there, maybe it simply is, but it need 100% more comments
172 2016-09-20 14:09:30	0|jonasschnelli|Yes. I really dislike the time based periodical flushing...
173 2016-09-20 14:10:12	0|wumpus|well periodical flushing in itself makes sense I think
174 2016-09-20 14:10:33	0|wumpus|e.g. important changes flush and sync immediately, like adding new keys to the keypool
175 2016-09-20 14:10:45	0|wumpus|other changes can potentially wait until shutdown or the next timer
176 2016-09-20 14:12:03	0|jonasschnelli|I'm not opposed against periodical flushing.. but why time based in a separate thread.
177 2016-09-20 14:12:35	0|jonasschnelli|Hmm.. maybe it makes sense if the flushing takes a couple of seconds...
178 2016-09-20 14:13:12	0|wumpus|what is being done is not completely insane, it's just heavily underdocumented, and function names and variable names don't match what is being done, which is deceptive
179 2016-09-20 14:13:32	0|wumpus|yes, right, for big wallets this periodical compaction can take a while
180 2016-09-20 14:13:41	0|wumpus|so it makes sense to do it in a thread in that regard
181 2016-09-20 14:14:41	0|wumpus|but anyhow we should have caught the ThreadFlushWalletDB() in review :)
182 2016-09-20 14:15:14	0|wumpus|calling into another thread's main function is 100% of times a mistake
183 2016-09-20 14:16:03	0|wumpus|are you going to submit a pull to remove it or shoudl I?
184 2016-09-20 14:16:34	0|jonasschnelli|I think removing the line in rpcdump.cpp would probably the best solution for now (should not change the behavior).
185 2016-09-20 14:16:37	0|jonasschnelli|I can to a PR
186 2016-09-20 14:16:38	0|wumpus|it's in 0.12 too
187 2016-09-20 14:16:39	0|jonasschnelli|can do
188 2016-09-20 14:16:43	0|wumpus|yes
189 2016-09-20 14:22:04	0|btcdrak|https://github.com/bitcoin-core/bitcoincore.org/pull/214
190 2016-09-20 14:22:06	0|GitHub50|[13bitcoin] 15jonasschnelli opened pull request #8765: [Wallet] remove "unused" ThreadFlushWalletDB from removeprunedfunds (06master...062016/09/flush_wallet_dump) 02https://github.com/bitcoin/bitcoin/pull/8765
191 2016-09-20 14:22:43	0|GitHub189|13bitcoin/06master 14157254a 15Suhas Daftuar: Fix broken sendcmpct test in p2p-compactblocks.py...
192 2016-09-20 14:22:43	0|GitHub189|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/aff69278063c...1c24d5f63720
193 2016-09-20 14:22:44	0|GitHub189|13bitcoin/06master 141c24d5f 15Wladimir J. van der Laan: Merge #8739: [qa] Fix broken sendcmpct test in p2p-compactblocks.py...
194 2016-09-20 14:22:57	0|GitHub94|[13bitcoin] 15laanwj closed pull request #8739: [qa] Fix broken sendcmpct test in p2p-compactblocks.py (06master...06fix-cb-test) 02https://github.com/bitcoin/bitcoin/pull/8739
195 2016-09-20 14:27:43	0|GitHub110|[13bitcoin] 15unsystemizer opened pull request #8766: Fix URL for Debian 8.5.0 ISO (06master...06patch-3) 02https://github.com/bitcoin/bitcoin/pull/8766
196 2016-09-20 15:32:45	0|GitHub147|[13bitcoin] 15MarcoFalke opened pull request #8768: init: Get rid of fDisableWallet (06master...06Mf1609-initDisableWallet) 02https://github.com/bitcoin/bitcoin/pull/8768
197 2016-09-20 15:37:22	0|gmaxwell|jonasschnelli: luke-jr submitted a fix for removeprunedfunds a week or so ago, #8687
198 2016-09-20 15:40:11	0|wumpus|that doesn't seem to be the right solution
199 2016-09-20 15:40:20	0|wumpus|there's no need to call the compaction there
200 2016-09-20 17:47:53	0|tucker111|I recently updated btc core to 0.13.0 and my btc and transactions history is gone. pls help I ve re scan .dat to make sure and nothing happened
201 2016-09-20 17:49:11	0|sipa|what did you update from?
202 2016-09-20 17:49:43	0|tucker111|0.12
203 2016-09-20 17:51:59	0|tucker111|I have all addresses that I ve generated from the core and the amount I ve sent and received to authenticate...could it help?
204 2016-09-20 17:53:16	0|sipa|go to the debug window, and type "validateaddress <address>"
205 2016-09-20 17:53:31	0|sipa|without the "", and with <address> replaced by an address you know is yours
206 2016-09-20 17:53:42	0|sipa|that you've received funds on
207 2016-09-20 18:01:12	0|tucker111|do I type it in ''debug log file'' or ''console'' in debug window?
208 2016-09-20 18:01:33	0|achow101|the console tab on the textbox at the bottom
209 2016-09-20 18:04:11	0|sipa|console
210 2016-09-20 18:06:55	0|sipa|does it say ismine true or false?
211 2016-09-20 18:11:55	0|tucker111|false
212 2016-09-20 18:13:21	0|tucker111|''isvalid'' false
213 2016-09-20 18:14:43	0|sipa|that means you're not pasting an address
214 2016-09-20 18:15:03	0|sipa|maybe you left off some characters from the beginning or the end?
215 2016-09-20 18:16:50	0|tucker111|i ve checked the address 3 times
216 2016-09-20 18:17:22	0|gmaxwell|are you confusing addresses for different cryptocurrencies?
217 2016-09-20 18:17:36	0|tucker111|all in btcv
218 2016-09-20 18:17:45	0|tucker111|btc
219 2016-09-20 18:18:14	0|sipa|it should be
220 2016-09-20 18:18:30	0|sipa|validateaddress 1bcdefhdhduabandkdbsvag
221 2016-09-20 18:18:33	0|sipa|for example
222 2016-09-20 18:18:40	0|sipa|no other characters
223 2016-09-20 18:19:15	0|tucker111|without  < >?
224 2016-09-20 18:19:29	0|sipa|yes
225 2016-09-20 18:19:53	0|sipa|<> just means "replace something here"
226 2016-09-20 18:21:11	0|gmaxwell|sipa: you should have given a valid example.
227 2016-09-20 18:21:32	0|tucker111|sometimes theyre important tho
228 2016-09-20 18:22:12	0|tucker111|ismine false
229 2016-09-20 18:29:34	0|tucker111|what does ismine false means?
230 2016-09-20 18:30:58	0|achow101|it means that the address is not in your wallet
231 2016-09-20 18:31:55	0|tucker111|can I recover the btc that were on it?
232 2016-09-20 18:31:57	0|btcdrak|well it means you dont have the private key for it.
233 2016-09-20 18:32:16	0|tucker111|i do
234 2016-09-20 18:32:23	0|achow101|you don't have the private key so you can't get any of the Bitcoin that was associated with it
235 2016-09-20 18:32:36	0|achow101|if it isn't in your wallet, you don't have the key
236 2016-09-20 18:33:13	0|gmaxwell|tucker111: how did you upgrade?
237 2016-09-20 18:40:24	0|tucker111|actually I did a tails usb driver and then logged back into win10 and then plane mode was stuck, so I had to do a factory reset after trying millions solutions to get rid of plane mode
238 2016-09-20 18:40:46	0|tucker111|and then i download the core again...
239 2016-09-20 18:41:20	0|sipa|factory reset of what?
240 2016-09-20 18:41:23	0|achow101|doesn't the factory reset wipe everything?
241 2016-09-20 18:41:37	0|tucker111|couldnt login to btc core at all to do the transfer before hand
242 2016-09-20 18:41:42	0|achow101|did Core have to resync when you first started it after reinstall
243 2016-09-20 18:41:50	0|tucker111|it should
244 2016-09-20 18:41:53	0|tucker111|no it didnt
245 2016-09-20 18:42:18	0|tucker111|i m still reinstalling it so i dont know yet
246 2016-09-20 18:42:46	0|achow101|well if it wiped your wallet.dat file you're screwed
247 2016-09-20 18:43:09	0|sipa|if you type
248 2016-09-20 18:43:12	0|sipa|getblockcount
249 2016-09-20 18:43:20	0|sipa|in the debug console, what does it say?
250 2016-09-20 18:44:50	0|tucker111|278384
251 2016-09-20 18:45:30	0|achow101|well there's your problem
252 2016-09-20 18:45:48	0|tucker111|i not synced yet thats why?
253 2016-09-20 18:46:13	0|achow101|yes
254 2016-09-20 18:46:25	0|tucker111|should i get it afterward?
255 2016-09-20 18:46:38	0|achow101|right now you are still syncing. If your factory reset wiped the drive, then your wallet.dat and the blockchain got wiped to
256 2016-09-20 18:46:50	0|achow101|so if your wallet.dat is gone (as it likely is) then you have lost your bitcoin
257 2016-09-20 18:47:13	0|tucker111|i know but is there a way to go back to the same wallet since i cant use it offline?
258 2016-09-20 18:47:24	0|tucker111|ok
259 2016-09-20 18:47:28	0|gmaxwell|tucker111: do you have a backup of your wallet?
260 2016-09-20 18:47:41	0|tucker111|i couldnt do it!
261 2016-09-20 18:51:08	0|arubi|tucker111, did you use windows 10 "reset this pc" when you did factory reset?
262 2016-09-20 18:51:11	0|jonasschnelli|How would it be if we change __rpcfunc(const UniValue& params, bool fHelp) to __rpcfunc(const RPCContext& ctx), where ctx would contain const UniValue& params, bool fHelp along with info about the request
263 2016-09-20 18:51:22	0|MarcoFalke|Arg, the review divs won't collapse when they are outdated
264 2016-09-20 18:51:33	0|jonasschnelli|MarcoFalke: Yes. Thats bad.
265 2016-09-20 18:51:43	0|arubi|tucker111, -> #bitcoin
266 2016-09-20 18:51:45	0|jonasschnelli|Maybe they get removed when you do another github "review"?
267 2016-09-20 18:52:00	0|gmaxwell|tucker111: arubi: achow101: etc. please move to #bitcoin for further discussion. :)
268 2016-09-20 18:52:23	0|jonasschnelli|If we change it to __rpcfunc(const RPCContext& ctx), we could add the request URI, etc. which would allow accessing multiple wallets
269 2016-09-20 19:03:08	0|gmaxwell|wumpus: if your locked page ulimit is (say) 64k  and you try to lock 256k... will it fail to lock anything at all?  Might be useful to make the mlocks run in smaller increments to at least get some locked.
270 2016-09-20 19:10:40	0|gmaxwell|someone in #bitcoin with a gdb backtrace of a node that keeps crashing during sync running 0.13 ppa... crashing at assert(coins) in CheckTxInputs.
271 2016-09-20 19:10:50	0|gmaxwell|about to hop a flight, but someone might want to look at it.
272 2016-09-20 19:10:58	0|gmaxwell|user reports 0.12 was running fine before.
273 2016-09-20 19:11:20	0|gmaxwell|(user is nou1)
274 2016-09-20 19:11:21	0|sipa|gmaxwell: his PR checks the locked page limit, and if it nonzero, it first allocates that amount immediately
275 2016-09-20 19:11:35	0|gmaxwell|oh great!
276 2016-09-20 19:11:41	0|sipa|so if you have 64kb it will still allocate 64, even if the default is 256
277 2016-09-20 19:30:45	0|GitHub4|[13bitcoin] 15unsystemizer closed pull request #8766: Fix URL for Debian 8.5.0 ISO (06master...06patch-3) 02https://github.com/bitcoin/bitcoin/pull/8766
278 2016-09-20 19:39:10	0|GitHub79|[13bitcoin] 15unsystemizer opened pull request #8769: Trivial: Fix ISO URL, capitalization (06master...06patch-4) 02https://github.com/bitcoin/bitcoin/pull/8769
279 2016-09-20 19:39:51	0|phantomcircuit|sipa: yes that's something i am working on
280 2016-09-20 19:40:08	0|phantomcircuit|before trying to fix the flush logic im cleaning things up in general
281 2016-09-20 21:04:08	0|GitHub150|[13bitcoin] 15MarcoFalke closed pull request #8286: [doc] Docs and copyright headers bump (06master...06Mf1607-trivialPre13) 02https://github.com/bitcoin/bitcoin/pull/8286
282 2016-09-20 22:01:59	0|jtimon|is "functions start with uppercase" still part of our style guidelines? I can't find them (maybe they're now reduced to src/.clang-format )?
283 2016-09-20 22:07:56	0|sipa|yes it is
284 2016-09-20 22:22:53	0|jtimon|sipa: I was asking because ___tau___ and I are discussing the namin in https://github.com/bitcoin/bitcoin/pull/8493/commits/ca1f6622f49cf5653ba074a9392102ef515c9d3c#diff-646fe6309aabacfd041a20dcad10be05R11 and https://github.com/bitcoin/bitcoin/pull/8493/commits/3165f95cc2f60ebf37d073da10640fbfa141b765#diff-c2a099d775bac1dccc5f146a3cda81b8R16
285 2016-09-20 22:24:03	0|jtimon|he suggested get_ancestor_fn get_ancestor; is clearer, but since we have uppercase for functions as a style rule maybe GetAncestor_fn  GetAncestor; is a good compromise ?
286 2016-09-20 22:26:20	0|jtimon|nothing urgent, but yeah, AncestorGetter Ancestor; seems less clear
287 2016-09-20 22:26:20	0|___tau___|Ah, the point was to not drop the verbs from the function names rather than use underscores (that was just an example for explaining)
288 2016-09-20 22:28:29	0|jtimon|yeah, just saying that it will be free for me to change the names to anything else while I do that, so if there's any other bike-shedding to put in or reject (ie the _fn ending), now it's better than any other time
289 2016-09-20 22:28:46	0|jtimon|personally I like the _fn convention