1 2016-10-02 04:28:57	0|leangjia|Hi,all.
 2 2016-10-02 11:17:17	0|GitHub119|[13bitcoin] 15MarcoFalke opened pull request #8863: univalue: Pull subtree (06master...06Mf1610-univalue) 02https://github.com/bitcoin/bitcoin/pull/8863
 3 2016-10-02 12:30:56	0|luke-jr|weird, starting my node shows all transactions back to 2010 as "Offline" even after a few connections
 4 2016-10-02 12:31:10	0|luke-jr|would expect it to show the ones that confirmed in the past as confirmed at least..
 5 2016-10-02 12:31:25	0|luke-jr|(I can understand not trusting newly confirmed stuff with few connections)
 6 2016-10-02 12:33:31	0|sipa|transactions can be "offline" ?
 7 2016-10-02 12:34:30	0|luke-jr|sipa: apparently ☺
 8 2016-10-02 12:34:38	0|luke-jr|they showed normal after 5 or 6 connections
 9 2016-10-02 12:47:17	0|wumpus|yes, transactions (in the gui) can be "offline". That transaction classification code is pretty much what it was in satoshi's code, unchanged over all that time
10 2016-10-02 12:47:29	0|wumpus|GetAdjustedTime() - wtx.nTimeReceived > 2 * 60 && wtx.GetRequestCount() == 0
11 2016-10-02 12:49:32	0|wumpus|most notably it doesn't check the depth, so something can be 100/offline, for whatever that's worth
12 2016-10-02 12:50:28	0|wumpus|'longer than 2 hours old and never requested by other peers'
13 2016-10-02 13:03:45	0|luke-jr|wumpus: all of these have been long-confirmed by other peers :p
14 2016-10-02 13:31:57	0|wumpus|luke-jr: the logic makes little sense. I wouldn't mind removing that status completely. I don't think it's documented anywhere, and if it surprises even the devs :)
15 2016-10-02 16:34:59	0|wumpus|FYI no dev meeting this week https://lists.linuxfoundation.org/pipermail/bitcoin-core-dev/2016-October/000020.html
16 2016-10-02 16:50:14	0|achow101|how close are we to 0.13.1 release?
17 2016-10-02 16:53:07	0|btcdrak|achow101: see the milestone.
18 2016-10-02 16:53:08	0|BlueMatt|wumpus: whats you opinion on big code moves?
19 2016-10-02 16:53:31	0|BlueMatt|wumpus: specifically, https://github.com/TheBlueMatt/bitcoin/commit/af4caa3fd5000da6187a71dbba9b0ca3ff18e3d4
20 2016-10-02 16:54:10	0|BlueMatt|grrr, damn github...whatever, pulls out the CNodeState management from the top of main.cpp to the end as a part of https://github.com/TheBlueMatt/bitcoin/commits/net_processing_file, which disentangles that stuff somewhat and is like 2 functions away from splitting main.cpp in two
21 2016-10-02 17:27:21	0|wumpus|achow101: people keep adding new pulls for 0.13.1, but by far the largest change that still has to go in is https://github.com/bitcoin/bitcoin/pull/8393
22 2016-10-02 17:27:47	0|wumpus|BlueMatt: code moves are easy to review/verify, so if it makes sense from a code organization viewpoint (and people agree on that) it's fine
23 2016-10-02 17:32:20	0|btcdrak|wumpus: there are some trivial merges tho. I think can merge #8848, #8857 and #8817. Havent looked at #8862 but seems trivial enough.
24 2016-10-02 19:05:43	0|BlueMatt|wumpus: i was asking in the context of 0.14...when in the release cycle did we say we wanted to do code moves?
25 2016-10-02 19:20:41	0|paveljanik|BlueMatt, in the Next one :-)
26 2016-10-02 20:58:49	0|GitHub35|[13bitcoin] 15TheBlueMatt opened pull request #8865: Decouple peer-processing-logic from block-connection-logic (06master...06net_processing_1) 02https://github.com/bitcoin/bitcoin/pull/8865
27 2016-10-02 21:05:08	0|luke-jr|wumpus: well, we really should have better logic for the statuses in general. removing offline alone may make things worse.
28 2016-10-02 21:05:44	0|luke-jr|wumpus: if we have few peers or block rate suggests we may be partitioned, we should distrust confirmation
29 2016-10-02 21:15:00	0|GitHub168|13bitcoin/06master 14fa66609 15MarcoFalke: [qa] mininode: Only allow named args in wait_until
30 2016-10-02 21:15:00	0|GitHub168|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/6faffb8a83db...6013c73b3312
31 2016-10-02 21:15:01	0|GitHub168|13bitcoin/06master 146013c73 15MarcoFalke: Merge #8857: [qa] mininode: Only allow named args in wait_until...
32 2016-10-02 21:15:15	0|GitHub84|[13bitcoin] 15MarcoFalke closed pull request #8857: [qa] mininode: Only allow named args in wait_until (06master...06Mf1610-qaMininodeWaitUntil) 02https://github.com/bitcoin/bitcoin/pull/8857