1 2016-10-07 00:13:07	0|achow101|someone's spamming the github. please ban him
 2 2016-10-07 04:16:52	0|NicolasDorier|jl2012: I see that on https://github.com/bitcoin/bitcoin/pull/8499 we don't have any test in script_tests.json are you working on it or should I do it ?
 3 2016-10-07 04:17:52	0|jl2012|NicolasDorier: I'm trying to do. But since the signing is disabled now it's a bit tricky
 4 2016-10-07 04:18:03	0|jl2012|can't be automatic signing
 5 2016-10-07 04:18:17	0|NicolasDorier|signing disabled ? I missed an episode
 6 2016-10-07 04:18:35	0|jl2012|https://github.com/bitcoin/bitcoin/pull/8499/commits/3a4048de42e351d302c202ee8879a8fd4706e7f2
 7 2016-10-07 04:19:32	0|NicolasDorier|ok
 8 2016-10-07 04:19:33	0|NicolasDorier|I can do it
 9 2016-10-07 04:19:45	0|jl2012|there are several cases to test
10 2016-10-07 04:20:05	0|NicolasDorier|can you send that to me ? I will do it. Quite easy with nbitcoin
11 2016-10-07 04:20:30	0|jl2012|P2WPKH to uncompressed key (which is already tested in https://github.com/sdaftuar/bitcoin/commit/eeb9e9440fc0a6c1bfbbfc81905dae08af3dc0cb)
12 2016-10-07 04:20:50	0|jl2012|and some P2WSH cases
13 2016-10-07 04:21:23	0|jl2012|0 <sig1> 1 <c-key2> <u-key1> 2 CHECKMULTISIG   should fail
14 2016-10-07 04:21:23	0|jl2012|0 <sig1> 1 <u-key2> <c-key1> 2 CHECKMULTISIG   should pass
15 2016-10-07 04:21:23	0|jl2012|0 <sig2> 1 <c-key2> <u-key1> 2 CHECKMULTISIG   should also fail
16 2016-10-07 04:21:23	0|jl2012|0 <sig2> 1 <u-key2> <c-key1> 2 CHECKMULTISIG   should fail
17 2016-10-07 04:21:56	0|jl2012|the 3rd one should pass because the u-key2 is never used
18 2016-10-07 04:22:09	0|NicolasDorier|ok thanks, I'll do it
19 2016-10-07 04:22:39	0|jl2012|thanks!
20 2016-10-07 04:24:45	0|jl2012|i think it's obvious but "<sig> 0 IF <u-key> CHECKSIG ENDIF" should pass
21 2016-10-07 04:33:44	0|sipa|jl2012: script_tests has its own signer code for the automatically generated tests
22 2016-10-07 04:34:10	0|sipa|it should work fine with uncompressed pubkeys
23 2016-10-07 04:34:49	0|sipa|it's also advantageous to use such automatically generated tests, as they're easier to recreate or adapt to newer scenarios later
24 2016-10-07 04:35:48	0|jl2012|ok, I see what you mean
25 2016-10-07 04:36:21	0|jl2012|TestBuilder& PushSig
26 2016-10-07 04:53:28	0|sipa|you can disable the define at the top of the file
27 2016-10-07 04:53:48	0|sipa|and running the test will cause it to write out the json form
28 2016-10-07 04:54:14	0|sipa|which you can then copy-paste into the distribution file
29 2016-10-07 05:19:59	0|NicolasDorier|jl2012: do you have the private key for the tests P2WSH in script_tests ? I see that the tests changed and they don't pass in NBitcoin anymore :/
30 2016-10-07 05:22:19	0|NicolasDorier|actually this is strange... the public key hash of the test changed, but not the signature oO
31 2016-10-07 05:22:50	0|NicolasDorier|public key I mean
32 2016-10-07 05:23:20	0|NicolasDorier|well nevermind... investigating
33 2016-10-07 05:29:55	0|sipa|changing the compression of pubkeys does not change the signatures
34 2016-10-07 05:31:00	0|jl2012|NicolasDorier, I'm also working on script_tests
35 2016-10-07 05:31:25	0|NicolasDorier|sipa: that's not the problem, I'm catching up with the other recent changes in script_tests for now
36 2016-10-07 05:31:45	0|NicolasDorier|in NBitcoin test suite
37 2016-10-07 05:32:04	0|NicolasDorier|and now the test "Basic P2WSH"  fail for some reason
38 2016-10-07 05:32:07	0|NicolasDorier|trying to findout why
39 2016-10-07 05:32:29	0|NicolasDorier|on the signature
40 2016-10-07 05:32:40	0|NicolasDorier|if you know the private key, I can checkout why
41 2016-10-07 05:33:53	0|jl2012|i guess the key is generated on the fly?
42 2016-10-07 05:34:23	0|NicolasDorier|no, I'm talking about script_tests.json
43 2016-10-07 05:34:33	0|jl2012|NicolasDorier: https://github.com/jl2012/bitcoin/commits/badwitnesscheck-tmp
44 2016-10-07 05:34:58	0|jl2012|this is what I have done so far
45 2016-10-07 05:35:54	0|NicolasDorier|my problem right now is with the script_tests.json as is in master... will find out
46 2016-10-07 05:36:49	0|jl2012|ok, then I'll keep working on script_test.cpp .
47 2016-10-07 05:52:30	0|NicolasDorier|found the problem finally
48 2016-10-07 05:52:50	0|NicolasDorier|jl2012: what tests are you doing ? if you are speaking about the one for uncompressed public key, I can do them
49 2016-10-07 05:53:48	0|jl2012|yes, i'm doing it in script_test.cpp
50 2016-10-07 05:55:42	0|jl2012|check the last commit in https://github.com/jl2012/bitcoin/commits/badwitnesscheck-tmp
51 2016-10-07 08:01:02	0|jl2012|NicolasDorier: tests pushed to #8499
52 2016-10-07 08:24:32	0|NicolasDorier|jl2012: would be nice if the tests not impacted by this PR are not updated
53 2016-10-07 08:24:48	0|NicolasDorier|uh wait
54 2016-10-07 08:25:38	0|NicolasDorier|yes
55 2016-10-07 08:26:02	0|NicolasDorier|why are the previous tests modified ?
56 2016-10-07 08:27:09	0|NicolasDorier|I guess this one for example: https://github.com/bitcoin/bitcoin/pull/8499/commits/84cb3d462ae58f95acfaacfe6df6bdda0714a0ff#diff-a79f02a42f31e934e3bdb4f40500b908L2004
57 2016-10-07 08:27:16	0|NicolasDorier|was using non compressed key ?
58 2016-10-07 08:27:21	0|NicolasDorier|I think it should stay that way
59 2016-10-07 08:27:35	0|NicolasDorier|as it should pass if the flag is not set
60 2016-10-07 08:28:06	0|jl2012|ok, I just think there is no point to test uncompressed key
61 2016-10-07 08:28:19	0|jl2012|so I may just add more tests instead?
62 2016-10-07 08:28:36	0|jl2012|keep the original, and repeat with compressed key
63 2016-10-07 08:28:57	0|NicolasDorier|I don't think you need to repeat them with compressed
64 2016-10-07 08:29:09	0|NicolasDorier|just add the tests that should fail if the flag is set
65 2016-10-07 08:29:52	0|NicolasDorier|I mean only the tests with WITNESS_PUBKEYTYPE should be added imho
66 2016-10-07 08:40:53	0|sipa|jl2012: uncompressed keys are allowed by consensus, so we should adequately test them, even more so than policy flags
67 2016-10-07 08:41:09	0|sipa|so i don't think we should remove any of the old tests
68 2016-10-07 08:41:28	0|jl2012|Ok
69 2016-10-07 08:44:21	0|jl2012|pushed
70 2016-10-07 11:13:28	0|GitHub56|[13bitcoin] 15fanquake opened pull request #8899: Fix wake from sleep issue with Boost 1.59.0 (060.13...06backport-boost-windows-patch) 02https://github.com/bitcoin/bitcoin/pull/8899
71 2016-10-07 12:24:50	0|wumpus|arrived in Milan, but had a sleepless night and headache from the flight so resting a bit...
72 2016-10-07 12:27:18	0|paveljanik|not only Boost has sleep issues...
73 2016-10-07 12:33:47	0|wumpus|lol
74 2016-10-07 12:37:51	0|luke-jr|>_<
75 2016-10-07 12:42:18	0|Lightsword|anyone meeting up in milan soon? I’m finally somewhat awake
76 2016-10-07 12:56:37	0|wumpus|there should be a few people at Copernico already
77 2016-10-07 13:21:32	0|sipa|there are people at Copernico, 3rd floor, blockchain labd
78 2016-10-07 13:21:35	0|sipa|*labs
79 2016-10-07 13:41:54	0|instagibbs|take a right out the elevator*
80 2016-10-07 14:34:29	0|Lightsword|sipa, what’s the address for that?
81 2016-10-07 14:35:20	0|sipa|it's the same address as the reception tonight
82 2016-10-07 14:35:32	0|sipa|via copernico 38, i believe
83 2016-10-07 14:44:46	0|Lightsword|ok, cool looks like it’s in walking distance…will probably be there in about 15 minutes or so
84 2016-10-07 16:36:11	0|gmaxwell|sipa: luke-jr: can you check your seeders and report what percentage of listening nodes are currently on comcast IPs?
85 2016-10-07 16:48:16	0|sipa|gmaxwell: can't check now, but data is on bitcoin.sipa.be/seeds.txt