1 2016-11-08 00:00:56 0|phantomcircuit|there's no actual bug but it's kind of annoying
2 2016-11-08 00:01:14 0|phantomcircuit|there's a warding about nLowestTimestamp in importmulti
3 2016-11-08 00:01:24 0|phantomcircuit|potentially being used uninitalized
4 2016-11-08 00:01:32 0|sipa|phantomcircuit: yeah, we should fix that
5 2016-11-08 00:02:14 0|jtimon|I have understood and like some of the commits in the middle, just not enough to give an utACK in any of the PRs (note ven the merged ones yet)
6 2016-11-08 00:28:37 0|phantomcircuit|im kind of confused
7 2016-11-08 00:28:47 0|phantomcircuit|sipa: in 8831 you can see i moved IsKeyType
8 2016-11-08 00:28:52 0|phantomcircuit|but im getting wallet/walletdb.h:45: multiple definition of `IsKeyType(std::string)'
9 2016-11-08 00:29:04 0|phantomcircuit|it's protected by #ifndef BITCOIN_WALLET_WALLETDB_H
10 2016-11-08 00:29:08 0|phantomcircuit|so it shouldn't be doing that
11 2016-11-08 00:29:21 0|phantomcircuit|moving the definition to walletdb.cpp fixes this
12 2016-11-08 00:29:24 0|phantomcircuit|but i cant see why
13 2016-11-08 00:34:20 0|phantomcircuit|https://api.travis-ci.org/jobs/174075001/log.txt?deansi=true
14 2016-11-08 00:58:52 0|phantomcircuit|sipa: nvm i see where i went wrong
15 2016-11-08 00:58:55 0|phantomcircuit|derp
16 2016-11-08 00:59:45 0|bitcoin-git|[13bitcoin] 15dcousens opened pull request #9100: tx_valid: re-order inputs to how they are encoded (06master...06testorder) 02 https://github.com/bitcoin/bitcoin/pull/9100
17 2016-11-08 01:06:04 0|phantomcircuit|uh
18 2016-11-08 01:07:25 0|phantomcircuit|CWalletDB::Recover has a dummyWallet which only prints a line in debug.log if LoadKeyValue fails to parse the key/value pair
19 2016-11-08 01:07:44 0|phantomcircuit|this either should fail the recovery or just be removed
20 2016-11-08 01:23:23 0|bitcoin-git|[13bitcoin] 15pstratem opened pull request #9101: [Wallet] Do not parse ssValue in CWalletDB::Recover (06master...062016-11-07-cwalletdb-recover) 02 https://github.com/bitcoin/bitcoin/pull/9101
21 2016-11-08 02:05:31 0|bitcoin-git|[13bitcoin] 15instagibbs opened pull request #9102: Really don't validate genesis block (06master...06dontvalidategenesis) 02 https://github.com/bitcoin/bitcoin/pull/9102
22 2016-11-08 02:11:42 0|bitcoin-git|[13bitcoin] 15sipa pushed 4 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/9f554e03ebe5...dc6b9406bdfa
23 2016-11-08 02:11:43 0|bitcoin-git|13bitcoin/06master 1488c3549 15Suhas Daftuar: Fix compact block handling to not ban if block is invalid
24 2016-11-08 02:11:43 0|bitcoin-git|13bitcoin/06master 14c93beac 15Suhas Daftuar: [qa] Test that invalid compactblocks don't result in ban
25 2016-11-08 02:11:44 0|bitcoin-git|13bitcoin/06master 14d4833ff 15Suhas Daftuar: Bump the protocol version to distinguish new banning behavior....
26 2016-11-08 02:11:53 0|bitcoin-git|[13bitcoin] 15sipa closed pull request #9026: Fix handling of invalid compact blocks (06master...06fix-invalidcb-handling) 02 https://github.com/bitcoin/bitcoin/pull/9026
27 2016-11-08 07:42:19 0|bitcoin-git|13bitcoin/06master 14fa8278e 15MarcoFalke: test: Fix test_random includes
28 2016-11-08 07:42:19 0|bitcoin-git|[13bitcoin] 15jonasschnelli pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/dc6b9406bdfa...b8f43e33316c
29 2016-11-08 07:42:20 0|bitcoin-git|13bitcoin/06master 14b8f43e3 15Jonas Schnelli: Merge #9095: test: Fix test_random includes...
30 2016-11-08 07:42:33 0|bitcoin-git|[13bitcoin] 15jonasschnelli closed pull request #9095: test: Fix test_random includes (06master...06Mf1611-testRand) 02 https://github.com/bitcoin/bitcoin/pull/9095
31 2016-11-08 09:55:35 0|bitcoin-git|13bitcoin/06master 144441018 15UdjinM6: Every main()/exit() should return/use one of EXIT_ codes instead of magic numbers
32 2016-11-08 09:55:35 0|bitcoin-git|13bitcoin/06master 14bd0de13 15UdjinM6: Fix exit codes:...
33 2016-11-08 09:55:35 0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/b8f43e33316c...f53023dbb860
34 2016-11-08 09:55:36 0|bitcoin-git|13bitcoin/06master 14f53023d 15Wladimir J. van der Laan: Merge #9067: Fix exit codes...
35 2016-11-08 09:55:44 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9067: Fix exit codes (06master...06fixExitCodesBitcoin) 02 https://github.com/bitcoin/bitcoin/pull/9067
36 2016-11-08 09:56:09 0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/f53023dbb860...71ab476b0482
37 2016-11-08 09:56:10 0|bitcoin-git|13bitcoin/06master 14fab0f07 15MarcoFalke: [qa] rpc-tests: Apply random offset to portseed...
38 2016-11-08 09:56:10 0|bitcoin-git|13bitcoin/06master 14fae19aa 15MarcoFalke: [qa] test_framework: Exit when tmpdir exists
39 2016-11-08 09:56:11 0|bitcoin-git|13bitcoin/06master 1471ab476 15Wladimir J. van der Laan: Merge #9098: [qa] Handle zombies and cluttered tmpdirs...
40 2016-11-08 09:56:19 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9098: [qa] Handle zombies and cluttered tmpdirs (06master...06Mf1611-qaZombies) 02 https://github.com/bitcoin/bitcoin/pull/9098
41 2016-11-08 09:57:49 0|wumpus|now the tests can even jump over zombies in graveyards \o/
42 2016-11-08 10:05:38 0|bitcoin-git|13bitcoin/06master 1477cbbd9 15R E Broadley: Make warning message about wallet balance possibly...
43 2016-11-08 10:05:38 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/71ab476b0482...4e5782438c3d
44 2016-11-08 10:05:39 0|bitcoin-git|13bitcoin/06master 144e57824 15Wladimir J. van der Laan: Merge #9088: Reduce ambiguity of warning message...
45 2016-11-08 10:05:49 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9088: Reduce ambiguity of warning message (06master...06LessAmbiguousWalletWarning) 02 https://github.com/bitcoin/bitcoin/pull/9088
46 2016-11-08 10:05:51 0|MarcoFalke|Heh, I hope it is a good thing because whenever there is a zombie there is a prob of about 0.0016 that you will step on them :P
47 2016-11-08 10:06:38 0|MarcoFalke|Previously the prob was 1, so at least you knew there is a zombie
48 2016-11-08 12:17:05 0|wumpus|well the best way of deailng with zombies would be to no create them in the first place, make sure the test framework cleans up the dead properly
49 2016-11-08 12:17:20 0|wumpus|this is not always possible, of course
50 2016-11-08 14:56:42 0|bitcoin-git|13bitcoin/06master 141adf82a 15Jorge Timón: RPC: Give more details when "generate" fails
51 2016-11-08 14:56:42 0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/4e5782438c3d...924de0bd75a7
52 2016-11-08 14:56:43 0|bitcoin-git|13bitcoin/06master 14924de0b 15MarcoFalke: Merge #9087: RPC: why not give more details when "generate" fails?...
53 2016-11-08 14:56:51 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #9087: RPC: why not give more details when "generate" fails? (06master...060.13-errors-rpc-mining) 02 https://github.com/bitcoin/bitcoin/pull/9087
54 2016-11-08 19:11:56 0|gmaxwell|sipa: so perhaps the mempool saving functionality should be saving the mempoolminfee... as it goes to zero after a restart.
55 2016-11-08 19:15:57 0|sipa|gmaxwell: good point
56 2016-11-08 19:16:00 0|sipa|file an issue
57 2016-11-08 19:17:52 0|gmaxwell|sipa: #9103
58 2016-11-08 19:17:53 0|gribble|https://github.com/bitcoin/bitcoin/issues/9103 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
59 2016-11-08 19:34:37 0|morcos|sipa: i also thought mempool saving was going to be optional?
60 2016-11-08 19:35:15 0|morcos|on a separately question, is it fine to leave a bunch of BOOST_TEST_MESSAGE(..) in unit_tests or will they slow them down...
61 2016-11-08 19:35:37 0|morcos|coins_tests are so complicated, might be useful to not have to readd all this debugging information next time they are changed
62 2016-11-08 20:03:48 0|BlueMatt|jtimon: cool, thanks
63 2016-11-08 20:27:07 0|jtimon|wumpus: instagibbs I added the reindex rpc tests to #8994, to test #9102 (well, and #8994 in general), if you think of other rpc tests that would be interesting to duplicate for this or default values for the custom chain (ie maybe consensus.BIP34Height = 0 or whatever ) please let me know
64 2016-11-08 20:27:09 0|gribble|https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon ÷ Pull Request #8994 ÷ bitcoin/bitcoin ÷ GitHub
65 2016-11-08 20:27:10 0|gribble|https://github.com/bitcoin/bitcoin/issues/9102 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
66 2016-11-08 20:27:11 0|gribble|https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon ÷ Pull Request #8994 ÷ bitcoin/bitcoin ÷ GitHub
67 2016-11-08 20:28:10 0|jtimon|strangely enough locally walletbackup is failing, but only when I run all of them, not when I run it individually, there must be something I haven't cleanup up properly because travis seems to be happy
68 2016-11-08 20:42:07 0|sdaftuar|jtimon: if you're seeing failures related to block sync failure in sync_blocks(), there's a good chance that
69 2016-11-08 20:42:42 0|sdaftuar|is related to #9058
70 2016-11-08 20:42:44 0|gribble|https://github.com/bitcoin/bitcoin/issues/9058 | Fixes for p2p-compactblocks.py test timeouts on travis (#8842) by ryanofsky ÷ Pull Request #9058 ÷ bitcoin/bitcoin ÷ GitHub
71 2016-11-08 20:44:49 0|jtimon|I'm not really sure what's happening, it's not a very clear error and the fact that walletbackup passes individually makes it more weird, but I will take a look, thanks
72 2016-11-08 21:07:18 0|bitcoin-git|[13bitcoin] 15morcos opened pull request #9107: Safer modify new coins (06master...06saferModifyNewCoins) 02 https://github.com/bitcoin/bitcoin/pull/9107
73 2016-11-08 22:05:41 0|bitcoin-git|[13bitcoin] 15ryanofsky opened pull request #9108: WIP: Use importmulti timestamp when importing watch only keys (06master...06watchtime) 02 https://github.com/bitcoin/bitcoin/pull/9108
74 2016-11-08 22:25:13 0|gmaxwell|morcos: it's optional, you can totally kill -9 the process instead of calling stop. :P
75 2016-11-08 22:25:43 0|gmaxwell|(I suppose it would be reasonable to add an option to let people disable it, though I don't know why anyone would set it, except perhaps saving 150 mb of disk space.
76 2016-11-08 22:29:57 0|sipa|morcos: i'm not opposed to making it optional, i just didn't think it was a requirement for the first PR
77 2016-11-08 22:34:11 0|sipa|gmaxwell: i assume you're joking, but there are downsides to killing that may be worse, like not storing the latest blocks' effect to disk
78 2016-11-08 22:42:50 0|cfields|sdaftuar: regarding #9026, did you consider adding fMayBanPeerIfInvalid to CState rather than passing it around? I realize it's merged, just curious after starting to review 9075
79 2016-11-08 22:42:52 0|gribble|https://github.com/bitcoin/bitcoin/issues/9026 | Fix handling of invalid compact blocks by sdaftuar ÷ Pull Request #9026 ÷ bitcoin/bitcoin ÷ GitHub
80 2016-11-08 22:44:11 0|sipa|cfields: i dislike turning CValidationState into an input parameter as well
81 2016-11-08 22:49:24 0|cfields|sipa: fair enough, I suppose that would be the only input. I was thinking there were already some there.
82 2016-11-08 22:53:34 0|gmaxwell|sipa: well we should fix those downsides if they're actually a concern. :) losing a few blocks of verification should be a non-issue.
83 2016-11-08 22:54:28 0|phantomcircuit|gmaxwell: i think it can be more than a few
84 2016-11-08 23:02:21 0|sipa|gmaxwell: not needing a shutdown procedure is a nice design principle, but i don't think we're there
85 2016-11-08 23:07:47 0|gmaxwell|seems pretty fine to me.