1 2016-12-20 00:07:52	0|bitcoin-git|[13bitcoin] 15ryanofsky opened pull request #9384: CCoinsViewCache code cleanup & deduplication (based on #9107, #9308, #9310) (06master...06pr/ccoins-cleanup) 02https://github.com/bitcoin/bitcoin/pull/9384
  2 2016-12-20 05:30:01	0|BlueMatt|#9212 0.14 tag?
  3 2016-12-20 05:30:02	0|gribble|https://github.com/bitcoin/bitcoin/issues/9212 | Assertion failed: (nSendVersion != 0), function GetSendVersion, file ./net.h, line 775. · Issue #9212 · bitcoin/bitcoin · GitHub
  4 2016-12-20 07:01:09	0|jtimon|oh, morcos I missed https://github.com/bitcoin/bitcoin/pull/9276/commits/e2184ccc1da55d54917245dccfa9e30e87dfc6f2 nice thanks
  5 2016-12-20 07:54:25	0|bitcoin-git|[13bitcoin] 15kallewoof opened pull request #9387: RAII of libevent stuff using set of wrappers (06master...06raii-libevents) 02https://github.com/bitcoin/bitcoin/pull/9387
  6 2016-12-20 10:15:14	0|wumpus|tagged #9212
  7 2016-12-20 10:15:16	0|gribble|https://github.com/bitcoin/bitcoin/issues/9212 | Assertion failed: (nSendVersion != 0), function GetSendVersion, file ./net.h, line 775. · Issue #9212 · bitcoin/bitcoin · GitHub
  8 2016-12-20 10:30:33	0|bitcoin-git|13bitcoin/06master 14faf4ca8 15MarcoFalke: [wallet] Disable free transactions when relay is disabled
  9 2016-12-20 10:30:33	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/7f72568e6b15...3097ea40d719
 10 2016-12-20 10:30:34	0|bitcoin-git|13bitcoin/06master 143097ea4 15Wladimir J. van der Laan: Merge #9316: [wallet] Disable free transactions when relay is disabled...
 11 2016-12-20 10:30:48	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9316: [wallet] Disable free transactions when relay is disabled (06master...06Mf1612-sendFreeNo) 02https://github.com/bitcoin/bitcoin/pull/9316
 12 2016-12-20 11:09:53	0|btcdrak|wumpus: now that instagibbs  addressed the maps nit in 9262, is it mergeable?
 13 2016-12-20 11:10:28	0|btcdrak|i backported it aswell
 14 2016-12-20 12:12:16	0|wumpus|btcdrak: yes. I think so
 15 2016-12-20 12:27:29	0|bitcoin-git|[13bitcoin] 15laanwj pushed 5 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/3097ea40d719...5a70572049d0
 16 2016-12-20 12:27:30	0|bitcoin-git|13bitcoin/06master 140b2294a 15Gregory Sanders: SelectCoinsMinConf: Prefer coins with fewer ancestors
 17 2016-12-20 12:27:30	0|bitcoin-git|13bitcoin/06master 145882c09 15Gregory Sanders: CreateTransaction: Don't return success with too-many-ancestor txn
 18 2016-12-20 12:27:31	0|bitcoin-git|13bitcoin/06master 14af9bedb 15Gregory Sanders: Test for fix of txn chaining in wallet
 19 2016-12-20 12:27:39	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9262: Prefer coins that have fewer ancestors, sanity check txn before ATMP (06master...06toolong) 02https://github.com/bitcoin/bitcoin/pull/9262
 20 2016-12-20 12:33:47	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9382: [backport 0.13] Prefer coins that have fewer ancestors, sanity check txn before ATMP (060.13...06backport9262) 02https://github.com/bitcoin/bitcoin/pull/9382
 21 2016-12-20 12:36:04	0|bitcoin-git|13bitcoin/060.13 148e707e8 15Wladimir J. van der Laan: doc: Add #9382 to release notes
 22 2016-12-20 12:36:04	0|bitcoin-git|[13bitcoin] 15laanwj pushed 1 new commit to 060.13: 02https://github.com/bitcoin/bitcoin/commit/8e707e868d6020de0d352279eed4fcd0138f3695
 23 2016-12-20 12:43:16	0|wumpus|will label 0.13.2rc1 in a bit - doing last-minute checks
 24 2016-12-20 12:56:02	0|btcdrak|wumpus: exciting :)
 25 2016-12-20 12:56:50	0|rabidus_|nice
 26 2016-12-20 13:03:31	0|jtimon|yeah, nice
 27 2016-12-20 13:22:32	0|wumpus|* [new tag]         v0.13.2rc1 -> v0.13.2rc1
 28 2016-12-20 13:24:29	0|btcdrak|\o/
 29 2016-12-20 13:27:14	0|instagibbs|woohoo
 30 2016-12-20 13:28:27	0|thrasher`|nice :D
 31 2016-12-20 14:56:27	0|bitcoin-git|[13bitcoin] 15rebroad opened pull request #9388: Relative time (06master...06RelativeTime) 02https://github.com/bitcoin/bitcoin/pull/9388
 32 2016-12-20 17:48:59	0|achow101|eh, a tag. I'm late to the party!
 33 2016-12-20 17:49:43	0|MarcoFalke_web|first matching sig!
 34 2016-12-20 19:10:07	0|jtimon|I would really welcome help from experts on ./rpc-tests/segwit.py or ./rpc-tests/p2p-compactblocks.py I really can't understand why changing the genesis block of regtests should be an issue or how can I correct it or find my error
 35 2016-12-20 19:17:27	0|jtimon|sorry, I'm talking about #8994 again, which changes all rpc/py tests from "regtest" to "custom" (the tests should be identical except for the genesis block, those 2 tests resist)
 36 2016-12-20 19:17:30	0|gribble|https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub
 37 2016-12-20 19:56:14	0|instagibbs|jtimon, what error are you getting
 38 2016-12-20 19:57:52	0|jtimon|in each of them, one test is failing, let me go back to what line was failing on each
 39 2016-12-20 20:18:57	0|gmaxwell|\O/ hurray about the RC.
 40 2016-12-20 20:19:59	0|instagibbs|jtimon, please give more info thanks
 41 2016-12-20 20:20:49	0|jtimon|oh, sorry, I forgot
 42 2016-12-20 20:23:10	0|jtimon|in segwit.py the first error is in L428, in L844
 43 2016-12-20 20:23:52	0|jtimon|in segwit.py the first error is in L428, in qa/rpc-tests/p2p-compactblocks.py in L844
 44 2016-12-20 20:25:23	0|jtimon|in all the rest everything seems to be working fine, my fear is omse of them aren't calling setup_chain()
 45 2016-12-20 20:26:59	0|jtimon|in segwit.py the error is "missing inputs", my guess is that the tests are somehow using regtest genesis block instead of the custom chain one
 46 2016-12-20 20:27:56	0|MarcoFalke_web|Does the new chain work with the caching in the python tests?
 47 2016-12-20 20:28:52	0|MarcoFalke_web|looking at your pull, it should
 48 2016-12-20 20:30:41	0|jtimon|the custom chain should be completely identical for regtest and custom by default expect for the genesis block
 49 2016-12-20 20:32:24	0|jtimon|mhmm, this commit says I need to fix p2p-segwit too...https://github.com/bitcoin/bitcoin/pull/8994/commits/8e3de77110892e3684a9cb98ced9c9129997257c
 50 2016-12-20 20:33:13	0|jtimon|ideally, that commit would only touch test_framework.py and be squashed somewhere
 51 2016-12-20 20:37:47	0|jtimon|I'm pretty convinced it has something to do with the mininodes, but there still some chain-dependent code I'm looking fore
 52 2016-12-20 20:40:16	0|cfields|gitian builders: detached sigs for 0.13.2rc1 pushed.
 53 2016-12-20 20:40:28	0|timothy|hi, I have a slightly question. I'm trying to integrate bitcoin with tor under docker
 54 2016-12-20 20:40:28	0|timothy|it works, but unlucky -proxy and -torcontrol doesn't support hostnames, but only IPs and this doesn't work under docker-compose
 55 2016-12-20 20:41:08	0|gmaxwell|the tor support in Bitcoin Core really intends the tor daemon to be on localhost.
 56 2016-12-20 20:41:25	0|gmaxwell|if it's on another host right now it will end up banning the tor host.
 57 2016-12-20 20:41:28	0|timothy|well, it works also if you have the tor daemon on another host, but I need to specify the ip :P
 58 2016-12-20 20:41:39	0|gmaxwell|It doesn't work for long.
 59 2016-12-20 20:42:18	0|timothy|ok, wrong idea. thank you :)
 60 2016-12-20 20:42:57	0|sipa|-proxy certainly accepts IP addresses
 61 2016-12-20 20:43:42	0|gmaxwell|hopefully we'll fix that in an upcoming version.
 62 2016-12-20 20:43:59	0|gmaxwell|sipa: yes, outbound would be fine.
 63 2016-12-20 20:44:41	0|jtimon|right, for simple proxies an env variable for docker may be enough
 64 2016-12-20 20:45:00	0|gmaxwell|Proxy won't take a hostname?
 65 2016-12-20 20:45:34	0|btcdrak|I dont mean to be a stick in the mud, but why are merge commits not signed in the gitian.sigs repository?
 66 2016-12-20 20:45:49	0|MarcoFalke_web|What would it help?
 67 2016-12-20 20:45:50	0|sipa|gmaxwell: seems it doesn't
 68 2016-12-20 20:45:53	0|jtimon|no, but environment variable would give the ip, no? I'm not really sure what he is trying to do so probably I shouldn't talk
 69 2016-12-20 20:45:55	0|gmaxwell|lol, gitian sigs are already sigs.
 70 2016-12-20 20:46:19	0|MarcoFalke_web|btcdrak: Your linux has a mismatch
 71 2016-12-20 20:46:49	0|btcdrak|MarcoFalke_web: just the linux one?
 72 2016-12-20 20:46:54	0|MarcoFalke_web|jup
 73 2016-12-20 20:47:00	0|btcdrak|weird.
 74 2016-12-20 21:01:14	0|gmaxwell|A request for 0.13rc2 testers:  Please run ./qa/pull-tester/rpc-tests.py ... we have this fantastic test suite and I get the impression that a lot of people only use it via travis.  If there are bad interactions with your system and the software these tests are probably more likely to reveal them then just your local testing alone.
 75 2016-12-20 21:49:48	0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #9389: 0.13.2 release process (060.13...06Mf1612-01302Bump) 02https://github.com/bitcoin/bitcoin/pull/9389
 76 2016-12-20 21:55:27	0|achow101|a bunch of tests just failed for me
 77 2016-12-20 21:56:04	0|instagibbs|achow101, make sure you don't have zombie processes or cache folder lying around
 78 2016-12-20 21:56:19	0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #9390: travis: make distdir (06master...06Mf1612-travisDistDir) 02https://github.com/bitcoin/bitcoin/pull/9390
 79 2016-12-20 21:56:41	0|achow101|I'm gitian building at the same time, so that might be interfering with something too
 80 2016-12-20 21:56:56	0|MarcoFalke|Could be also OOM
 81 2016-12-20 21:57:59	0|achow101|could be
 82 2016-12-20 22:05:20	0|morcos|sipa: i've spent too long confused by move semantics already today, but i think there is an easily fixable potential bug... can you take a quick look
 83 2016-12-20 22:05:39	0|morcos|in wallet.cpp under the logic for -walletrejectlongchains
 84 2016-12-20 22:05:45	0|morcos|hasn't txNew been moved from?
 85 2016-12-20 22:06:27	0|sipa|what line?
 86 2016-12-20 22:06:42	0|morcos|search for walletrejectlongchains, i'm not on master
 87 2016-12-20 22:06:53	0|morcos|right under that
 88 2016-12-20 22:08:14	0|morcos|sorry second occurence, line 2566
 89 2016-12-20 22:08:23	0|sipa|yup
 90 2016-12-20 22:08:29	0|sipa|i wonder how that code works at all
 91 2016-12-20 22:08:35	0|morcos|thats what i mean by confused
 92 2016-12-20 22:09:05	0|morcos|i made the same error myself on some other wallet code i was working on earlier
 93 2016-12-20 22:09:12	0|sipa|txNew in practice will just have empty txin and txout
 94 2016-12-20 22:10:19	0|morcos|same bug in 0.13.2
 95 2016-12-20 22:10:50	0|morcos|if you don't mind taking it from here..  i have a couple things i'm rushing to finish before dinner
 96 2016-12-20 22:11:39	0|morcos|but out of curiousity, why is that such an easy mistake to make?  shouldn't there be a compiler warning or something
 97 2016-12-20 22:12:33	0|sipa|there can't be
 98 2016-12-20 22:12:42	0|sipa|well, it could be a suggestion
 99 2016-12-20 22:12:53	0|sipa|but in general, use after move is well defined
100 2016-12-20 22:22:15	0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #9391: wallet: Remove sendfree (06master...06Mf1612-015walletSendFreeNONO) 02https://github.com/bitcoin/bitcoin/pull/9391
101 2016-12-20 22:53:17	0|gmaxwell|rc1 appears to be reporting     "subver": "/Satoshi:0.13.1/",
102 2016-12-20 22:57:21	0|sipa|see #9389
103 2016-12-20 22:57:23	0|gribble|https://github.com/bitcoin/bitcoin/issues/9389 | 0.13.2 release process by MarcoFalke · Pull Request #9389 · bitcoin/bitcoin · GitHub
104 2016-12-20 22:58:49	0|gmaxwell|heh just went and made most of those changes.. should have paid more attention.
105 2016-12-20 23:42:31	0|achow101|for what reasons would core close a connection to another node besides shutdown on one side?
106 2016-12-20 23:45:09	0|phantomcircuit|achow101, various protocol violations which are eggregious
107 2016-12-20 23:46:29	0|achow101|would a getdata message with the segwit flags (msg_witness_tx, etc) cause that right now since segwit is not activated?
108 2016-12-20 23:46:57	0|achow101|also, would such a disconnect show up in the debug.log?
109 2016-12-20 23:57:09	0|BlueMatt|before anyone freaks out, no, I think #9392 is 0.14.0 tag not 0.13.2, as mentioned in the review of 9262
110 2016-12-20 23:57:10	0|gribble|https://github.com/bitcoin/bitcoin/issues/9392 | Wallet ancestor sanity-check ignores sigops · Issue #9392 · bitcoin/bitcoin · GitHub
111 2016-12-20 23:59:42	0|achow101|what's up with these 0.13.1 nodes with short sendcmpct messages?