1 2016-12-27 00:01:33	0|bitcoin-git|[13bitcoin] 15droark opened pull request #9433: Update the Windows build notes (06master...06docs) 02https://github.com/bitcoin/bitcoin/pull/9433
 2 2016-12-27 04:01:48	0|luke-jr|gmaxwell: so you custom made a private key based on the required signature?
 3 2016-12-27 04:07:23	0|jl2012|luke-jr: I think it's key recovery
 4 2016-12-27 04:08:24	0|luke-jr|jl2012: ?
 5 2016-12-27 04:08:47	0|jl2012|gmaxwell's tx
 6 2016-12-27 04:08:53	0|luke-jr|looks like the script is checking the hash of the signature rather than the pubkey
 7 2016-12-27 04:09:02	0|jl2012|public key recovery
 8 2016-12-27 04:09:07	0|luke-jr|but the signature needs to commit to the input txid
 9 2016-12-27 04:09:54	0|luke-jr|since the pubkey is not restricted, however, I assume the spender can just calculate a privkey from the signature + data, and provide the pubkey for that
10 2016-12-27 04:10:23	0|jl2012|no you can't
11 2016-12-27 04:10:42	0|jl2012|but with signature + data, you could have the pubkey
12 2016-12-27 04:10:48	0|jl2012|but you don't know the private key
13 2016-12-27 04:11:06	0|jl2012|if you could know private key this way, ECDSA is broken
14 2016-12-27 04:12:35	0|luke-jr|hmm
15 2016-12-27 04:12:37	0|gmaxwell|I didn't create that txn, someone on bct linked it asking for what was happening there, it's amusing though.
16 2016-12-27 04:13:00	0|jl2012|luke-jr: I did this with the same way: https://github.com/bitcoin/bitcoin/pull/8927
17 2016-12-27 04:13:04	0|gmaxwell|and yes, luke-jr you're right those coins can be stolen by anyone who has seen the preimage of the hash.
18 2016-12-27 04:13:42	0|luke-jr|oh, is it because of FindAndDelete?
19 2016-12-27 04:14:56	0|jl2012|you could do it without involving FindAndDelete. See the segwit tests in the same PR
20 2016-12-27 04:18:33	0|jl2012|to disallow this, we need to cover the pubkey in SignatureHash
21 2016-12-27 04:20:31	0|jl2012|luke-jr: you could find the python code here to do this: https://github.com/bitcoin/bitcoin/pull/8654
22 2016-12-27 06:53:12	0|arubi|it's my tx actually, indeed pubkey recovery :)
23 2016-12-27 06:54:18	0|arubi|basically a response to "signatures can't sign themselves" :)
24 2016-12-27 06:58:47	0|gmaxwell|the fact that it's the same as an orderinary pay to pubkey hash script, but with the swap makes it especitally cute.
25 2016-12-27 07:00:45	0|arubi|yea I was counting on it looking similar to that heh, another fun one is https://test.webbtc.com/script/795fd9db2300ea16bcd49ea85f2a0ecbe475c62b75fea317d1fa981aae34caca:0 , where R is not a valid X coordinate
26 2016-12-27 07:01:57	0|arubi|was trying to see if anyone who was implementing their own verifier would be forked off testnet.  nobody came forward so I guess we're ok :)
27 2016-12-27 07:01:57	0|gmaxwell|uhh
28 2016-12-27 07:02:50	0|arubi|well R+N is the valid X coordinate, but since we do % N, this non X coordinate R is what's left
29 2016-12-27 07:03:03	0|arubi|R+N < P
30 2016-12-27 07:03:03	0|gmaxwell|oh it's a wrap case, okay. whew.
31 2016-12-27 07:04:00	0|gmaxwell|I thought you were saying that R (the point) wasn't on the curve, rather than r (the scalar, R.x mod P).
32 2016-12-27 07:04:25	0|arubi|oh yes, capitalization is important
33 2016-12-27 07:04:27	0|gmaxwell|The former shouldn't verify.
34 2016-12-27 07:05:35	0|gmaxwell|reminds me that we need to add a case where R.x -> r overflows in signing to the libsecp256k1 tests.
35 2016-12-27 07:09:41	0|gmaxwell|arubi: sadly a lot of places don't run testnet nodes...
36 2016-12-27 07:12:43	0|gmaxwell|arubi: looks like webbtc is stuck as of the 4th in fact.
37 2016-12-27 07:13:20	0|gmaxwell|the first block it's missing is 00000000021d4ec041244b516e55d35f733ba8a1f538d26764b67e881b2e030f
38 2016-12-27 07:14:59	0|arubi|gmaxwell, yea, too bad..  not many stake holders like to keep an eye on testnet..  maybe when it's reset sometime it'll give people a chance to start a node
39 2016-12-27 07:16:52	0|gmaxwell|would be nice to know why it's rejecting that block.
40 2016-12-27 07:16:57	0|gmaxwell|it's seen it but considers it orphaned.
41 2016-12-27 07:17:51	0|gmaxwell|(so I wonder if it thinks its invalid)
42 2016-12-27 07:21:10	0|arubi|interesting.  looks like a simple block to validate.  will check when I'm back from work, cheers
43 2016-12-27 07:24:32	0|gmaxwell|yea, I don't see any obvious stunts in it.
44 2016-12-27 07:24:44	0|gmaxwell|it may just be that the site didn't survive a long reorg.
45 2016-12-27 12:40:41	0|bitcoin-git|[13bitcoin] 15ryanofsky opened pull request #9435: Removed unused variable in test, fixing warning. (06master...06pr/coins-unused) 02https://github.com/bitcoin/bitcoin/pull/9435
46 2016-12-27 13:20:36	0|gmaxwell|warren: do you know anything about https://www.ringingliberty.com/bitcoin/  ? doesn't appear to have a determinstic build process, anyone looked to see if these binaries are backdoored?  someone wandering into #bitcoin is using them.
47 2016-12-27 13:50:28	0|robert__|its the first result when you google fedora bitcoin
48 2016-12-27 14:39:25	0|luke-jr|is it intentional that CCoinsViewMemPool::Cursor doesn't work? :x
49 2016-12-27 14:56:37	0|sipa|luke-jr: CCoinsViewMemPool is generally broken
50 2016-12-27 14:56:46	0|sipa|it only works for a few use cases
51 2016-12-27 14:58:55	0|luke-jr|sipa: should I go ahead and document this? "* Its Cursor also doesn't work. In general, it is broken as a CCoinsView implementation outside of a few use cases." or something
52 2016-12-27 15:04:06	0|sipa|there is a comment about it somewhere
53 2016-12-27 15:04:13	0|sipa|i'm at a conference now, remind me later
54 2016-12-27 15:04:59	0|luke-jr|k, enjoy
55 2016-12-27 17:52:31	0|bitcoin-git|13bitcoin/06master 1435356b4 15Russell Yanofsky: Remove unused variable in test, fixing warning....
56 2016-12-27 17:52:31	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/0f921e6a0492...dbc8a8c86ae5
57 2016-12-27 17:52:32	0|bitcoin-git|13bitcoin/06master 14dbc8a8c 15MarcoFalke: Merge #9435: Removed unused variable in test, fixing warning....
58 2016-12-27 17:52:47	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #9435: Removed unused variable in test, fixing warning. (06master...06pr/coins-unused) 02https://github.com/bitcoin/bitcoin/pull/9435
59 2016-12-27 18:17:38	0|bitcoin-git|[13bitcoin] 15sipa pushed 8 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/dbc8a8c86ae5...7aa700424cbd
60 2016-12-27 18:17:39	0|bitcoin-git|13bitcoin/06master 142b5f085 15Matt Corallo: Fix non-const mapMultiArgs[] access after init....
61 2016-12-27 18:17:39	0|bitcoin-git|13bitcoin/06master 14c8042a4 15Matt Corallo: Remove arguments to ParseConfigFile
62 2016-12-27 18:17:40	0|bitcoin-git|13bitcoin/06master 140cf86a6 15Matt Corallo: Introduce (and use) an IsArgSet accessor method
63 2016-12-27 18:17:49	0|bitcoin-git|[13bitcoin] 15sipa closed pull request #9243: Clean up mapArgs and mapMultiArgs Usage (06master...062016-11-mapmultiargs) 02https://github.com/bitcoin/bitcoin/pull/9243
64 2016-12-27 18:18:35	0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #9436: test: Include tx data in EXTRA_DIST (06master...06Mf1612-inclTest) 02https://github.com/bitcoin/bitcoin/pull/9436
65 2016-12-27 19:04:39	0|bitcoin-git|13bitcoin/06master 142db4cbc 15Pieter Wuille: Merge #9349: Make CScript (and prevector) c++11 movable....
66 2016-12-27 19:04:39	0|bitcoin-git|13bitcoin/06master 142ddfcfd 15Pieter Wuille: Make CScript (and prevector) c++11 movable....
67 2016-12-27 19:04:39	0|bitcoin-git|[13bitcoin] 15sipa pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/7aa700424cbd...2db4cbcc437f
68 2016-12-27 19:04:53	0|bitcoin-git|[13bitcoin] 15sipa closed pull request #9349: Make CScript (and prevector) c++11 movable. (06master...06movescript) 02https://github.com/bitcoin/bitcoin/pull/9349