1 2016-12-28 09:32:07	0|NicolasDorier|jonasschnelli: luke-jr : about multi wallet support https://github.com/bitcoin/bitcoin/projects/2#card-205286 , is it ready to be tested or still stuff in the pipeline ? I plan to play with it if that is the case
 2 2016-12-28 09:32:42	0|jonasschnelli|NicolasDorier: I guess I need to rebase https://github.com/bitcoin/bitcoin/pull/8764/files
 3 2016-12-28 09:33:09	0|jonasschnelli|NicolasDorier: maybe review: https://github.com/bitcoin/bitcoin/pull/8776/files
 4 2016-12-28 09:33:19	0|jonasschnelli|#8776
 5 2016-12-28 09:33:21	0|gribble|https://github.com/bitcoin/bitcoin/issues/8776 | Wallet refactoring leading up to multiwallet by luke-jr · Pull Request #8776 · bitcoin/bitcoin · GitHub
 6 2016-12-28 09:33:35	0|NicolasDorier|ok thanks, doing it.
 7 2016-12-28 09:34:58	0|gmaxwell|cfields: https://github.com/bitcoin/bitcoin/pull/9075/commits/7c98ce584ec23bcddcba8cdb33efa6547212f6ef#r87104196  < you have my support to insist on better comments in the future.
 8 2016-12-28 09:35:52	0|gmaxwell|cfields: I just ran into this comment and thought it was excusing a data race, rather than a state machine race, wasted a while checking that all access to the structure were currently guarded about cs_main and then sending some lecturing to matt about there being no safe data races. :)
 9 2016-12-28 09:36:17	0|gmaxwell|I do thing some of our PR discussion really ought to end up in comments and commit messages...
10 2016-12-28 09:50:11	0|NicolasDorier|jonasschnelli: let me know when you rebase, I want to test it. When testing tumblebit, I am using same wallet for tumbler and the client, which is confusing, so I want to separate both. I use lots of wallet features, so it will be a good test case.
11 2016-12-28 09:50:43	0|jonasschnelli|NicolasDorier: Thanks. Yes. Multiwallet would be nice in 0.14
12 2016-12-28 09:53:58	0|NicolasDorier|jonasschnelli: will it be possible to scale the number of wallet ? or delete some ? A case I have: I am watching only some temporary escrow addresses, and currently I have no way of deleting them. Will I be able to segregate the watched addresses into several wallet, and delete the wallet when I do not need to track anymore ?
13 2016-12-28 09:54:58	0|jonasschnelli|Not planed. Also, some stuff needs to be written first.
14 2016-12-28 09:56:08	0|NicolasDorier|ok thanks, will review stuff more deeply soon
15 2016-12-28 11:59:24	0|bitcoin-git|13bitcoin/06master 14fa558be 15MarcoFalke: test: Include tx data in EXTRA_DIST
16 2016-12-28 11:59:24	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/2db4cbcc437f...dce853ef76ef
17 2016-12-28 11:59:25	0|bitcoin-git|13bitcoin/06master 14dce853e 15MarcoFalke: Merge #9436: test: Include tx data in EXTRA_DIST...
18 2016-12-28 11:59:39	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #9436: test: Include tx data in EXTRA_DIST (06master...06Mf1612-inclTest) 02https://github.com/bitcoin/bitcoin/pull/9436
19 2016-12-28 17:53:43	0|luke-jr|is it possible CCoinsViewDB::Cursor is broken too? :/
20 2016-12-28 17:56:43	0|luke-jr|467ff1966b03755492851de3b90caebdbd6912833b7805323970157f5a34b1e4 is confirmed on testnet, but doesn't seem to show up
21 2016-12-28 17:59:27	0|sipa|luke-jr: did you flush!
22 2016-12-28 17:59:38	0|sipa|?
23 2016-12-28 17:59:40	0|luke-jr|sipa: flush?
24 2016-12-28 18:00:51	0|luke-jr|FlushStateToDisk()? is that needed?
25 2016-12-28 18:02:37	0|sipa|yes
26 2016-12-28 18:03:12	0|luke-jr|aha, that's probably my issue then, thanks
27 2016-12-28 18:03:13	0|sipa|otherwise the utxo entries are pcoinsTip only, which is a CCoinsViewCache on top of CCoinsViewDB
28 2016-12-28 18:03:19	0|sipa|*in
29 2016-12-28 18:03:47	0|luke-jr|do I need cs_main for this? (how about for the cursor?)
30 2016-12-28 18:04:56	0|sipa|i believe it creates a snapshop
31 2016-12-28 18:04:58	0|sipa|snapshot
32 2016-12-28 18:05:22	0|sipa|you may need a lock to flush and grab the iterator
33 2016-12-28 18:05:33	0|sipa|but are then allowed to iterate without lock
34 2016-12-28 18:06:21	0|luke-jr|hmm
35 2016-12-28 18:07:35	0|sipa|(this is from memory, i have not checked)
36 2016-12-28 18:19:07	0|luke-jr|sipa: thanks, the flush fixed it