1 2016-12-31 00:20:22	0|morcos|the reason this doesn't happen with 9375 alone is that peer 0 hasn't requested that peer 1 be a HB peer, so the reorg isn't announced via the fast mechanism, i'm guessing 9400 changed that, but haven't looked into the details
 2 2016-12-31 01:08:32	0|gmaxwell|I wondered if that might also force us to cache more than one block.
 3 2016-12-31 01:09:32	0|gmaxwell|e.g. what happens if we get a second block instantly after the first, since they're tied will we still advertise the second?
 4 2016-12-31 03:06:35	0|morcos|gmaxwell: that sounds annoying.  seems like maybe we need to rework the signals a bit.  maybe make BlockChecked always called after ProcessNewBlock and we can hold a cache of all blocks from NewPowValidBlock until BlockChecked.
 5 2016-12-31 03:06:39	0|morcos|also always cache the tip
 6 2016-12-31 03:07:34	0|morcos|but then we have to figure out where the right place to call MaybeSetPeer.. is
 7 2016-12-31 03:08:30	0|morcos|But there is already another minor problem with the way the signals work now, mapBlockSource is never cleared of blocks which don't have BlockChecked called on them
 8 2016-12-31 03:09:31	0|morcos|and valid blocks that don't become your tip don't get that I don't think..  probably rare enough not to matter much now, but if we want to be have an alternate block request mechanism for SPV/hybrid whatever or something..
 9 2016-12-31 07:29:44	0|cfields|sipa: if you're here, please refresh your browser. You're reviewing stale commits :)
10 2016-12-31 07:31:40	0|sipa|:(
11 2016-12-31 07:31:50	0|sipa|i was reviewing from the app
12 2016-12-31 07:32:50	0|cfields|sipa: sorry. no clue what the app sees. I split them up into much more reviewable chunks, i hope.
13 2016-12-31 07:33:19	0|sipa|i see it now
14 2016-12-31 07:33:27	0|sipa|i guess it just caches a bit more aggressively
15 2016-12-31 07:33:33	0|sipa|no worries
16 2016-12-31 07:33:49	0|sipa|that's also why the result ends up with commit comments
17 2016-12-31 07:33:54	0|sipa|rather than PR comments
18 2016-12-31 07:34:33	0|cfields|ah, that's annoying. I was just looking at the page and saw no comments on the pr. Checked my mail on my phone on a whim.
19 2016-12-31 07:35:17	0|cfields|no worries though, i'll watch for that now
20 2016-12-31 08:48:49	0|sipa|cfields: i was surprised to see that 2*buffersize was still there, tbh
21 2016-12-31 08:50:03	0|cfields|sipa: i couldn't really imagine a scenario where it could be hit. I just imagined a response of "belt and suspenders"
22 2016-12-31 08:50:11	0|cfields|should've asked :)
23 2016-12-31 08:50:30	0|sipa|yeah, belt and suspenders indeed
24 2016-12-31 08:51:02	0|cfields|will nuke it though. I've certainly never seen it. And I've done enough stupid things in tests that would've prompted it.
25 2016-12-31 08:51:03	0|sipa|but if you want to keep it, don't just turn it into fPauseSend
26 2016-12-31 08:52:42	0|cfields|well, I think the checking now should be tight enough. But I'll add some tests. I think the corks could've been quite broken and gone unnotiiced.
27 2016-12-31 08:54:13	0|sipa|if you set max send size below the block size, you'll hit it automatically :)
28 2016-12-31 08:57:11	0|cfields|see 30ad8c069bcaf4ef8b6bf17498386bcb42e39fc3 :(
29 2016-12-31 08:58:15	0|cfields|s/send/recv/ though
30 2016-12-31 08:59:10	0|sipa|yeah, i saw
31 2016-12-31 09:02:53	0|cfields|headed to bed, thanks for having a look
32 2016-12-31 09:02:57	0|cfields|and happy new year!
33 2016-12-31 09:03:18	0|wumpus|happy new year!
34 2016-12-31 09:03:32	0|cfields|wumpus: !
35 2016-12-31 09:06:29	0|cannon-c|New year not for another day
36 2016-12-31 09:06:36	0|cannon-c|Happy New Years Eve!
37 2016-12-31 09:07:18	0|wumpus|yes, same here, it's still a few hours to go, just not sure I'm going to speak to cfields before that
38 2016-12-31 09:08:55	0|cannon-c|must be in Australia
39 2016-12-31 14:19:25	0|BlueMatt|morcos: hey, sorry, not been around much...
40 2016-12-31 14:19:31	0|BlueMatt|morcos: I'm looking at the stuff now
41 2016-12-31 18:06:09	0|bitcoin-git|[13bitcoin] 15isle2983 opened pull request #9450: Increment MIT licence copyright header year on files modified in 2016 (06master...06PR-increment-year) 02https://github.com/bitcoin/bitcoin/pull/9450
42 2016-12-31 18:09:52	0|bitcoin-git|[13bitcoin] 15robmcl4 opened pull request #9451: CScript: remove redundant bounds check (06master...06remove_extra_bounds_check) 02https://github.com/bitcoin/bitcoin/pull/9451
43 2016-12-31 18:41:31	0|bitcoin-git|[13bitcoin] 15isle2983 opened pull request #9452: Use TravisCI to enforce copyright header rules for source files (06master...06PR-travisci-copyright-enforce) 02https://github.com/bitcoin/bitcoin/pull/9452
44 2016-12-31 19:15:41	0|btcdrak|Happy New Year everyone
45 2016-12-31 19:41:41	0|instagibbs|yes happy new years, hoping for another year of successful releases
46 2016-12-31 19:45:10	0|paveljanik|Yay!
47 2016-12-31 19:48:51	0|btcdrak|let's tag 0.13.2 for New Year!
48 2016-12-31 20:04:55	0|bitcoin-git|[13bitcoin] 15jsmith-dev opened pull request #9453: Copyright notice year 2017 increment. Happy New Year! (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/9453