1 2017-01-20 00:07:34 0|CodeShark|luke-jr: for BIP123, I think either CC0 or GNU-all-permissive
2 2017-01-20 00:08:24 0|sipa|sdaftuar: well we do have CTransactionRef being a const reference to a CTransaction
3 2017-01-20 00:08:48 0|sipa|sdaftuar: we could have a wrapper class around CTransaction with mutable and self-synchronized fields
4 2017-01-20 00:09:05 0|sipa|that doesn't necessarily contain data that's part of CTransaction itself, but is relevant for validation
5 2017-01-20 03:01:37 0|bitcoin-git|[13bitcoin] 15gmaxwell opened pull request #9594: Send final alert message to older peers after connecting. (06master...06send_final_alert) 02 https://github.com/bitcoin/bitcoin/pull/9594
6 2017-01-20 03:11:49 0|achow101|gmaxwell: did you broadcast the final alert yet?
7 2017-01-20 03:17:10 0|gmaxwell|achow101: nope. Feel free! but it is set to not relay: so each node gives it out one host at a time.
8 2017-01-20 03:18:41 0|achow101|so the peers who receive it won't broadcast it too?
9 2017-01-20 03:19:10 0|gmaxwell|Correct.
10 2017-01-20 03:19:17 0|gmaxwell|This seemed safer to me in a number of respects.
11 2017-01-20 03:19:43 0|gmaxwell|they'll display it as soon as they connect to are connected from any node running that code and continue to display until they restart.
12 2017-01-20 03:20:46 0|achow101|will you be sending one that does relay?
13 2017-01-20 03:51:00 0|bitcoin-git|[13bitcoin] 15kallewoof opened pull request #9595: [consensus] make coinbase maturity a network parameter instead of an app-wide constant (06master...06consensus-coin-maturity) 02 https://github.com/bitcoin/bitcoin/pull/9595
14 2017-01-20 04:46:27 0|bitcoin-git|[13bitcoin] 15morcos opened pull request #9596: [bugfix] save feeDelta instead of priorityDelta in DumpMempool (06master...06dumpmapdeltas) 02 https://github.com/bitcoin/bitcoin/pull/9596
15 2017-01-20 04:47:34 0|gmaxwell|Argh.
16 2017-01-20 04:48:12 0|gmaxwell|"mapDeltas[i.first] = i.second.first;" probably belongs on some "why C++ sucks" page.
17 2017-01-20 04:48:53 0|luke-jr|lol
18 2017-01-20 04:49:37 0|luke-jr|wonder if there's an easy way to make a named-keys pair
19 2017-01-20 04:49:58 0|sipa|use an enum
20 2017-01-20 04:50:00 0|sipa|as key
21 2017-01-20 04:51:41 0|sipa|or a std::tuple with an enum that lists the field positions?
22 2017-01-20 06:31:27 0|cfields|grr, qt's buildsystem is an absolute nightmare
23 2017-01-20 06:31:50 0|cfields|BlueMatt: i know i owe you a PR. Just now coming up for air after battling qt all day
24 2017-01-20 07:37:20 0|fanquake|cfields need a hand with anything?
25 2017-01-20 08:18:50 0|bitcoin-git|[13bitcoin] 15practicalswift closed pull request #9590: Improve readability by removing redundant casts to same type (06master...06remove-redundant-casts) 02 https://github.com/bitcoin/bitcoin/pull/9590
26 2017-01-20 08:24:05 0|bitcoin-git|[13bitcoin] 15kallewoof opened pull request #9597: [rpc] Bug-fix: getdifficulty: use network parameters for minimum difficulty (06master...06getdifficulty-use-net-params) 02 https://github.com/bitcoin/bitcoin/pull/9597
27 2017-01-20 08:25:11 0|jonasschnelli|BlueMatt: I guess you are familiar with/using GetOldestKeyPoolTime... https://github.com/bitcoin/bitcoin/blob/master/src/wallet/wallet.cpp#L3081
28 2017-01-20 08:25:20 0|jonasschnelli|IMO this assumption is not really stable or even broken
29 2017-01-20 08:26:07 0|jonasschnelli|Haven't verified it, but the CKeyPool item at begin of the set must not always be the one with the olders nTime
30 2017-01-20 08:26:11 0|jonasschnelli|*oldest
31 2017-01-20 08:26:23 0|jonasschnelli|especially when using ReturnKey
32 2017-01-20 08:37:46 0|bitcoin-git|[13bitcoin] 15kallewoof closed pull request #9597: [rpc] Bug-fix: getdifficulty: use network parameters for minimum difficulty (06master...06getdifficulty-use-net-params) 02 https://github.com/bitcoin/bitcoin/pull/9597
33 2017-01-20 08:46:03 0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #9598: Improve readability by removing redundant casts to same type (on all platforms) (06master...06remove-redundant-casts) 02 https://github.com/bitcoin/bitcoin/pull/9598
34 2017-01-20 09:08:02 0|bitcoin-git|[13bitcoin] 15kallewoof reopened pull request #9597: [rpc] Bug-fix: getdifficulty: use network parameters for minimum difficulty (06master...06getdifficulty-use-net-params) 02 https://github.com/bitcoin/bitcoin/pull/9597
35 2017-01-20 09:33:48 0|jonasschnelli|Re: GetOldestKeyPoolTime. The assumption that the first item in the setKeyPool is always the oldest generated key holds.
36 2017-01-20 09:52:26 0|bitcoin-git|[13bitcoin] 15rebroad opened pull request #9599: [WIP] Perform validation in a separate thread to message handling. (06master...06ValidationThread) 02 https://github.com/bitcoin/bitcoin/pull/9599
37 2017-01-20 13:33:12 0|bitcoin-git|[13bitcoin] 15laanwj pushed 4 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/82274c02ed2d...fb75cd04bba3
38 2017-01-20 13:33:13 0|bitcoin-git|13bitcoin/06master 149aa4e6a 15Jonas Schnelli: [Wallet] Add an option to keep the change address key, true by default
39 2017-01-20 13:33:13 0|bitcoin-git|13bitcoin/06master 149eb325d 15Jonas Schnelli: [QA] Add test for fundrawtransactions new reserveChangeKey option
40 2017-01-20 13:33:14 0|bitcoin-git|13bitcoin/06master 14c9f3062 15Jonas Schnelli: Add fundrawtransactions new reserveChangeKey option to the release notes
41 2017-01-20 13:33:22 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9377: fundrawtransaction: Keep change-output keys by default, make it optional (06master...062016/12/fix_frt_adr) 02 https://github.com/bitcoin/bitcoin/pull/9377
42 2017-01-20 13:40:57 0|bitcoin-git|13bitcoin/06master 14b8d1b81 15Wladimir J. van der Laan: trivial: squash missing field 'argNames' initializer warning in qt tests...
43 2017-01-20 13:40:57 0|bitcoin-git|[13bitcoin] 15laanwj pushed 1 new commit to 06master: 02 https://github.com/bitcoin/bitcoin/commit/b8d1b81077e4d0efcf9aafc00954d6ecd3d72d31
44 2017-01-20 13:48:51 0|bitcoin-git|13bitcoin/06master 14af01cd3 15Wladimir J. van der Laan: qt: Periodic translation update
45 2017-01-20 13:48:51 0|bitcoin-git|[13bitcoin] 15laanwj pushed 1 new commit to 06master: 02 https://github.com/bitcoin/bitcoin/commit/af01cd3a3d0647c071e94d7b0bda7128fb9aeebe
46 2017-01-20 15:23:22 0|BlueMatt|cfields: no rush
47 2017-01-20 15:24:28 0|BlueMatt|cfields: no rush, is fine
48 2017-01-20 15:25:00 0|BlueMatt|jonasschnelli: really? I dont see how it couldnt be
49 2017-01-20 15:25:02 0|BlueMatt|?
50 2017-01-20 15:25:14 0|BlueMatt|ahh, yes, ok, didnt see your second comment
51 2017-01-20 15:58:56 0|BlueMatt|so someone should untag #9294 for 0.14
52 2017-01-20 15:58:59 0|gribble|https://github.com/bitcoin/bitcoin/issues/9294 | Use internal HD chain for change outputs (hd split) by jonasschnelli ÷ Pull Request #9294 ÷ bitcoin/bitcoin ÷ GitHub
53 2017-01-20 16:13:33 0|btcdrak|BlueMatt: I thought we agreed it would make it for 0.14
54 2017-01-20 16:13:43 0|BlueMatt|btcdrak: too late, didnt get merged and we froze
55 2017-01-20 16:31:35 0|cfields|sdaftuar: for the bip68-sequence test, i'm confused about how you tried to fix. Did you also try switching back to GetTime() rather than doubling down on GetTimeMicros()?
56 2017-01-20 16:31:55 0|cfields|sdaftuar: or were you just trying to nail down what actually depends on the mocktime?
57 2017-01-20 16:38:30 0|sdaftuar|cfields: i only tried to double-down on GetTimeMicros(), figuring that otherwise a mocktime that sets time too far into the future would trigger a bunch of disconnects?
58 2017-01-20 16:39:07 0|cfields|sdaftuar: i think there's a hack to account for that, sec
59 2017-01-20 16:40:40 0|cfields|sdaftuar: https://github.com/bitcoin/bitcoin/blob/master/src/rpc/misc.cpp#L434
60 2017-01-20 16:41:12 0|sdaftuar|ahh!
61 2017-01-20 16:41:57 0|sdaftuar|so maybe it would work to just go back to GetTime for everything? or add a way for mocktime to be used with GetTimeMicros, which I think some people have suggested before
62 2017-01-20 16:42:49 0|cfields|well, i think there are a few things we should do
63 2017-01-20 16:43:53 0|cfields|for one (though i'm not sure how much sense this makes practically), i'd like to see any consensus-critical time checks done outside of net code
64 2017-01-20 16:44:32 0|cfields|so that we can at least separate the things we're testing
65 2017-01-20 16:45:49 0|cfields|second, net code needs to move to a steady_clock, so we need to be mindful of how that conflicts with a mocktime
66 2017-01-20 16:47:43 0|cfields|(i don't think that the message timestamp is actually used in validation, but it apparently comes into play)
67 2017-01-20 16:48:20 0|sdaftuar|it gets passed in a couple places in net_processing, but I don't think it goes anywhere except for ping/pong handling?
68 2017-01-20 16:51:29 0|cfields|ok, yep. good. I was afraid that the mocktime was trickling in from there, but apparently not.
69 2017-01-20 16:55:39 0|cfields|sdaftuar: so maybe take the changes you tried, as well as killing the time reset in the setmocktime rpc?
70 2017-01-20 17:12:24 0|sdaftuar|cfields: still failing, though i haven't dug in yet. stepping away but i'll investigate more this afternoon
71 2017-01-20 17:31:09 0|bitcoin-git|[13bitcoin] 15morcos opened pull request #9602: Remove coin age priority and free transactions - implementation (06master...06nopriority) 02 https://github.com/bitcoin/bitcoin/pull/9602
72 2017-01-20 17:45:34 0|bitcoin-git|[13bitcoin] 15isle2983 opened pull request #9603: Add basic_style.py to automate some style checking. (06master...06PR-basic-style) 02 https://github.com/bitcoin/bitcoin/pull/9603
73 2017-01-20 19:19:05 0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #9604: [Trivial] add comment about setting peer as HB peer. (06master...06HBpeercomment) 02 https://github.com/bitcoin/bitcoin/pull/9604
74 2017-01-20 21:04:40 0|bitcoin-git|[13bitcoin] 15TheBlueMatt opened pull request #9605: Use CScheduler for wallet flushing, remove ThreadFlushWalletDB (06master...062017-01-cscheduler-cleanups) 02 https://github.com/bitcoin/bitcoin/pull/9605
75 2017-01-20 21:10:21 0|sdaftuar|cfields: looks like fixing the setmocktime rpc thing + replacing one GetTime() -> GetTimeMicros call that I missed is enough to fix things up, will open a PR shortly
76 2017-01-20 21:10:55 0|cfields|sdaftuar: great, thanks.
77 2017-01-20 21:12:11 0|cfields|meantime, i've coded up a steady_clock implementation that takes system time out of the equation, but it's invasive and will take a while to get in i'm sure
78 2017-01-20 21:14:15 0|sdaftuar|oh cool
79 2017-01-20 21:15:51 0|bitcoin-git|[13bitcoin] 15sdaftuar opened pull request #9606: net: Consistently use GetTimeMicros() for inactivity checks (06master...062017-01-net-time-comparisons) 02 https://github.com/bitcoin/bitcoin/pull/9606
80 2017-01-20 21:57:00 0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #9607: Remove redundant semicolons in Python code (06master...06remove-redundant-semicolons-in-python-code) 02 https://github.com/bitcoin/bitcoin/pull/9607
81 2017-01-20 23:57:41 0|bitcoin-git|[13bitcoin] 15fanquake closed pull request #9368: change to declarative sentences. simplify links (06master...06patch-13) 02 https://github.com/bitcoin/bitcoin/pull/9368