1 2017-01-23 01:08:27	0|bitcoin-git|[13bitcoin] 15kallewoof closed pull request #9595: [consensus] Make coinbase maturity a network parameter instead of an app-wide constant (06master...06consensus-coin-maturity) 02https://github.com/bitcoin/bitcoin/pull/9595
  2 2017-01-23 01:14:27	0|bitcoin-git|[13bitcoin] 15kallewoof opened pull request #9612: [trivial] Rephrase the definition of difficulty. (06master...06clarify-difficulty) 02https://github.com/bitcoin/bitcoin/pull/9612
  3 2017-01-23 01:14:45	0|bitcoin-git|[13bitcoin] 15kallewoof closed pull request #9597: [rpc] Bug-fix: getdifficulty: use network parameters for minimum difficulty (06master...06getdifficulty-use-net-params) 02https://github.com/bitcoin/bitcoin/pull/9597
  4 2017-01-23 06:44:12	0|bitcoin-git|13bitcoin/06master 149899893 15Matt Corallo: Move wallet callbacks into cs_main (this effectively reverts #7946)
  5 2017-01-23 06:44:12	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/ff58b1c3bdff...eafba4e273f0
  6 2017-01-23 06:44:13	0|bitcoin-git|13bitcoin/06master 14eafba4e 15Wladimir J. van der Laan: Merge #9583: Move wallet callbacks into cs_main (this effectively reverts #7946)...
  7 2017-01-23 06:44:28	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9583: Move wallet callbacks into cs_main (this effectively reverts #7946) (06master...062017-01-revert-7946) 02https://github.com/bitcoin/bitcoin/pull/9583
  8 2017-01-23 12:18:53	0|bitcoin-git|13bitcoin/06master 14116419e 15Alex Morcos: Don't overwrite validation state with corruption check...
  9 2017-01-23 12:18:53	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/eafba4e273f0...78849564144e
 10 2017-01-23 12:18:54	0|bitcoin-git|13bitcoin/06master 147884956 15Wladimir J. van der Laan: Merge #9511: Don't overwrite validation state with corruption check...
 11 2017-01-23 12:19:07	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9511: Don't overwrite validation state with corruption check (06master...06ATMPstate) 02https://github.com/bitcoin/bitcoin/pull/9511
 12 2017-01-23 13:03:22	0|bitcoin-git|13bitcoin/06master 145cdf106 15practicalswift: Remove redundant semicolons in Python code
 13 2017-01-23 13:03:22	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/78849564144e...5cf3c60fccb1
 14 2017-01-23 13:03:23	0|bitcoin-git|13bitcoin/06master 145cf3c60 15Wladimir J. van der Laan: Merge #9607: Remove redundant semicolons in Python code...
 15 2017-01-23 13:03:42	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9607: Remove redundant semicolons in Python code (06master...06remove-redundant-semicolons-in-python-code) 02https://github.com/bitcoin/bitcoin/pull/9607
 16 2017-01-23 14:30:45	0|BlueMatt|;;later tell MarcoFalke huh? why did you change the title on #9609? its super nice when titles refer to the bugs they fix.
 17 2017-01-23 14:30:46	0|gribble|The operation succeeded.
 18 2017-01-23 15:17:31	0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/5cf3c60fccb1...727a79836035
 19 2017-01-23 15:17:32	0|bitcoin-git|13bitcoin/06master 147ba0a00 15Karl-Johan Alm: Testing: listsinceblock should not use orphan block height.
 20 2017-01-23 15:17:32	0|bitcoin-git|13bitcoin/06master 14ee5c1ce 15Karl-Johan Alm: Bug-fix: listsinceblock: use closest common ancestor when a block hash was provided for a chain that was not the main chain.
 21 2017-01-23 15:17:33	0|bitcoin-git|13bitcoin/06master 14727a798 15Wladimir J. van der Laan: Merge #9516: Bug-fix: listsinceblock: use fork point as reference for blocks in reorg'd chains...
 22 2017-01-23 15:17:46	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9516: Bug-fix: listsinceblock: use fork point as reference for blocks in reorg'd chains (06master...06listsinceblock-reorg-fix) 02https://github.com/bitcoin/bitcoin/pull/9516
 23 2017-01-23 15:29:08	0|bitcoin-git|[13bitcoin] 15ryanofsky opened pull request #9613: [wallet] Clarify getbalance help string to explain interaction with bumpfee (06master...06pr/getbalance-help) 02https://github.com/bitcoin/bitcoin/pull/9613
 24 2017-01-23 15:57:16	0|bitcoin-git|[13bitcoin] 15jnewbery closed pull request #9591: [net] count mempool and extra pool matches correctly in PartiallyDownloadedBlock::InitData() (06master...06compactmatches) 02https://github.com/bitcoin/bitcoin/pull/9591
 25 2017-01-23 16:41:09	0|BlueMatt|lol, someone might want to remove "Add support for Segregated Witness to Bitcoin Core" from the in-progress projects list....
 26 2017-01-23 16:44:40	0|BlueMatt|also, maybe add "Rethink DoS protection methods, see #9530" and "Rethink time usage across codebase, see https://github.com/bitcoin/bitcoin/pull/9566#issuecomment-274542292 and #9606"
 27 2017-01-23 16:44:41	0|gribble|https://github.com/bitcoin/bitcoin/issues/9530 | [brainstorm] DoS protection for blocks · Issue #9530 · bitcoin/bitcoin · GitHub
 28 2017-01-23 16:44:43	0|gribble|https://github.com/bitcoin/bitcoin/issues/9606 | net: Consistently use GetTimeMicros() for inactivity checks by sdaftuar · Pull Request #9606 · bitcoin/bitcoin · GitHub
 29 2017-01-23 17:00:37	0|bitcoin-git|[13bitcoin] 15ryanofsky opened pull request #9614: [wallet] [refactor] Simplify getbalance implementation (06master...06pr/getbalance-cleanup) 02https://github.com/bitcoin/bitcoin/pull/9614
 30 2017-01-23 17:10:27	0|sipa|BlueMatt: is #1535 related to what you recently reported?
 31 2017-01-23 17:10:29	0|gribble|https://github.com/bitcoin/bitcoin/issues/1535 | Interrupting CWallet::AddToWallet requires rescan · Issue #1535 · bitcoin/bitcoin · GitHub
 32 2017-01-23 17:12:03	0|BlueMatt|sipa: I dont think so?
 33 2017-01-23 17:12:31	0|BlueMatt|sipa: I think that /might/ be fixed by #9583?
 34 2017-01-23 17:12:33	0|gribble|https://github.com/bitcoin/bitcoin/issues/9583 | Move wallet callbacks into cs_main (this effectively reverts #7946) by TheBlueMatt · Pull Request #9583 · bitcoin/bitcoin · GitHub
 35 2017-01-23 17:12:43	0|BlueMatt|no, nvm, that cantbe
 36 2017-01-23 17:13:24	0|sipa|ok
 37 2017-01-23 17:13:57	0|sipa|gmaxwell: i don't understand #2265
 38 2017-01-23 17:14:00	0|gribble|https://github.com/bitcoin/bitcoin/issues/2265 | signrawtransaction returns "complete" : false sometimes when it really is complete · Issue #2265 · bitcoin/bitcoin · GitHub
 39 2017-01-23 17:20:28	0|BlueMatt|sipa: do we even know if #1535 is still an issue???
 40 2017-01-23 17:20:30	0|gribble|https://github.com/bitcoin/bitcoin/issues/1535 | Interrupting CWallet::AddToWallet requires rescan · Issue #1535 · bitcoin/bitcoin · GitHub
 41 2017-01-23 17:20:41	0|sipa|BlueMatt: no clue
 42 2017-01-23 17:20:45	0|sipa|i'm going through old issues
 43 2017-01-23 17:21:28	0|BlueMatt|luke-jr: or gmaxwell might know, otherwise i say close
 44 2017-01-23 17:21:42	0|BlueMatt|I'll go do a code pass and see if i see anything surprising anywhere
 45 2017-01-23 17:41:13	0|MarcoFalke|BlueMatt: I don't like too much references to GitHub in the commits and stuff. It is already mentioned in one of the commits. No need to put it in the title (i.e. merge commit)
 46 2017-01-23 17:42:19	0|sipa|PR and issues
 47 2017-01-23 17:46:02	0|BlueMatt|ok
 48 2017-01-23 17:46:14	0|BlueMatt|i mean we fucking trust github for everything else, I'm not sure why thats the line, but ok :p
 49 2017-01-23 18:03:58	0|sipa|i still see the commit history as something that exists independently from github
 50 2017-01-23 18:05:36	0|midnightmagic|and independently verifiable
 51 2017-01-23 18:05:50	0|gwillen|BlueMatt: if github went away tomorrow, everything would be fine and the project would recover and go elsewhere, but all those issue and PR numbers would be permanently rendered nonsense pointers to nowhere.
 52 2017-01-23 18:06:30	0|midnightmagic|last I asked, there is someone mirroring all that data via either the github api or otherwise.
 53 2017-01-23 18:06:48	0|BlueMatt|yea, I mean I dont really want to copy all the details of an issue into a commitmsg just to reference it
 54 2017-01-23 18:07:03	0|BlueMatt|midnightmagic: I know i heard someone doing it...I assume kanzure?
 55 2017-01-23 18:07:16	0|BlueMatt|him or petertodd are probably timestamping it, too
 56 2017-01-23 18:07:30	0|midnightmagic|I sadly don't recall and would have to check logs.
 57 2017-01-23 18:07:44	0|kanzure|no no
 58 2017-01-23 18:07:58	0|kanzure|https://github.com/zw/bitcoin-gh-meta
 59 2017-01-23 18:08:07	0|kanzure|i have a single timestamp of this from a few weeks ago, but it's not regularly timesstamped
 60 2017-01-23 18:08:22	0|kanzure|we would need to find the person who runs that and ask them to timestamp each commit (a very simple thing to do)
 61 2017-01-23 18:09:23	0|BlueMatt|i mean make petertodd do it, doesnt he already run his timestamping service thing?
 62 2017-01-23 18:09:27	0|midnightmagic|is github still making the timestamping proofing thing available to anyone?
 63 2017-01-23 18:09:39	0|kanzure|BlueMatt: i think it's "zw". who is that?
 64 2017-01-23 18:09:46	0|BlueMatt|nfc
 65 2017-01-23 18:10:00	0|BlueMatt|"Zac Wilcox"
 66 2017-01-23 18:10:01	0|kanzure|midnightmagic: github? it's a petertodd thing. https://alice.btc.calendar.opentimestamps.org/
 67 2017-01-23 18:10:29	0|kanzure|https://petertodd.org//2016/opentimestamps-announcement
 68 2017-01-23 18:10:30	0|midnightmagic|Huh. I looked him up for some other reason entirely like..  yesterday.
 69 2017-01-23 18:10:56	0|kanzure|i think wilcox is the zooko family, but no doxxing
 70 2017-01-23 18:11:51	0|BlueMatt|kanzure: this isnt reddit, you may be ok :p
 71 2017-01-23 18:23:14	0|BlueMatt|I believe there is at least one case in #1535 which is an easy fix
 72 2017-01-23 18:23:16	0|gribble|https://github.com/bitcoin/bitcoin/issues/1535 | Interrupting CWallet::AddToWallet requires rescan · Issue #1535 · bitcoin/bitcoin · GitHub
 73 2017-01-23 18:29:14	0|MarcoFalke|#9596 looks ready for merge
 74 2017-01-23 18:29:16	0|gribble|https://github.com/bitcoin/bitcoin/issues/9596 | [bugfix] save feeDelta instead of priorityDelta in DumpMempool by morcos · Pull Request #9596 · bitcoin/bitcoin · GitHub
 75 2017-01-23 18:29:38	0|midnightmagic|Ah. I think that's iwilcox.
 76 2017-01-23 18:31:19	0|sipa|i believe that's correct
 77 2017-01-23 18:37:54	0|gribble|I have not seen iwilcox.
 78 2017-01-23 18:37:54	0|midnightmagic|;;seen iwilcox
 79 2017-01-23 18:38:27	0|BlueMatt|which version of gcc do we support?
 80 2017-01-23 18:38:36	0|sipa|4.8 and up, iirc
 81 2017-01-23 18:38:40	0|BlueMatt|good
 82 2017-01-23 18:43:01	0|bitcoin-git|13bitcoin/06master 14bd92f24 15Alex Morcos: [bugfix] save feeDelta instead of priorityDelta in DumpMempool
 83 2017-01-23 18:43:01	0|bitcoin-git|[13bitcoin] 15sipa pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/727a79836035...71148b8947fe
 84 2017-01-23 18:43:02	0|bitcoin-git|13bitcoin/06master 1471148b8 15Pieter Wuille: Merge #9596: [bugfix] save feeDelta instead of priorityDelta in DumpMempool...
 85 2017-01-23 18:43:22	0|bitcoin-git|[13bitcoin] 15sipa closed pull request #9596: [bugfix] save feeDelta instead of priorityDelta in DumpMempool (06master...06dumpmapdeltas) 02https://github.com/bitcoin/bitcoin/pull/9596
 86 2017-01-23 18:46:14	0|bitcoin-git|[13bitcoin] 15morcos opened pull request #9615: Wallet incremental fee (06master...06walletincremental) 02https://github.com/bitcoin/bitcoin/pull/9615
 87 2017-01-23 19:02:12	0|gmaxwell|sipa: what don't you understand?  signrawtransaction is pretty eager in returning complete: false in many situations when the transaction is actually complete.
 88 2017-01-23 19:03:00	0|sipa|gmaxwell: can you give an example?
 89 2017-01-23 19:06:01	0|sipa|ah, i think i see... when there is a pre-existing valid signature for an input, but not the prevout information to validate it?
 90 2017-01-23 19:09:29	0|gmaxwell|sipa: I think the issue mentioned one?  grab a random transaction out of a block, run signraw on it. complete will be false.
 91 2017-01-23 19:09:51	0|sipa|does it also if you pass the prevouts it spends?
 92 2017-01-23 19:10:04	0|gmaxwell|there are many different ways to run into it, but I think most of them reduce to not knowing the prevout.
 93 2017-01-23 19:10:17	0|gmaxwell|I believe it's still false if you do that, but I'm not sure, brain rot.
 94 2017-01-23 19:11:13	0|gmaxwell|what I was trying to say in the PR is that it's okay if we don't return complete true if we don't know... but we shouldn't return false when we don't know either.
 95 2017-01-23 19:11:48	0|sipa|i guess we should have made the output an array, which lists the status of each input
 96 2017-01-23 19:11:57	0|gmaxwell|I've ended up wasting time while offline multisigning things with people due to it falsely returning false making us think it wasn't working when it was.
 97 2017-01-23 19:12:05	0|sipa|complete/incomplete/unknown
 98 2017-01-23 19:12:47	0|gmaxwell|(after wasting a bunch of time because "scriptPubkey" is not "scriptPubKey")
 99 2017-01-23 19:23:30	0|bitcoin-git|[13bitcoin] 15thedigitalpatriot opened pull request #9616: Interested in Fixing Vulnerabilities. (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/9616
100 2017-01-23 19:28:14	0|gmaxwell|how are clueless people ending up doing that?
101 2017-01-23 19:46:55	0|BlueMatt|gmaxwell: apparently a ton of people get confused when you point them to github...somehow this is a common issue
102 2017-01-23 19:46:57	0|BlueMatt|:/
103 2017-01-23 19:47:15	0|BlueMatt|i guess the "open source" thing isnt clear to people - you dont have to ask to get the code
104 2017-01-23 19:48:22	0|sipa|yes, "pull request" sounds to many like that's what they do to pull the code
105 2017-01-23 19:48:30	0|sipa|gitlab calls it a merge request
106 2017-01-23 19:48:33	0|sipa|much better
107 2017-01-23 19:50:17	0|midnightmagic|+1 merge request, -1 antiquated ideas of theirs/yours
108 2017-01-23 19:50:32	0|gmaxwell|I just don't get what sequence of buttons that person pressed.
109 2017-01-23 19:51:29	0|sipa|browsing some fork branch of bitcoin, not realizing it's a fork, and clicking "New pull request"
110 2017-01-23 19:52:29	0|sipa|https://github.com/sipa/bitcoin/tree/multilocal -> click "New pull request"
111 2017-01-23 19:52:32	0|sipa|try it!
112 2017-01-23 19:55:11	0|BlueMatt|oh, yea, he just pr'd the bu codebase, so thats what he did, i suppose
113 2017-01-23 19:55:26	0|BlueMatt|or classic? ehh, whatever
114 2017-01-23 20:08:29	0|gmaxwell|ah, for some reason I thought it only showed that button on your own branches.
115 2017-01-23 20:11:06	0|luke-jr|GitHub could sure use some improvement of terminology ;)
116 2017-01-23 20:12:52	0|BlueMatt|someone email support@?
117 2017-01-23 20:13:01	0|BlueMatt|they're pretty responsive, at least get it in their internal issue tracker
118 2017-01-23 20:40:15	0|jtimon|sipa: what does git blame -w doe?
119 2017-01-23 20:40:51	0|sipa|jtimon: ignore whitespace changes in the analysis
120 2017-01-23 20:41:07	0|jtimon|yeah, just saw it, but thanks
121 2017-01-23 20:41:45	0|jtimon|yeah, that would remove the concern for the later indent
122 2017-01-23 22:50:44	0|bitcoin-git|[13bitcoin] 15laudaa opened pull request #9617: [Trivial] Update license year range to 2017 (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/9617
123 2017-01-23 23:32:03	0|jtimon|mhmm, https://github.com/bitcoin/bitcoin/pull/9294 returns 500 for me...
124 2017-01-23 23:34:45	0|achow101|we've broken github
125 2017-01-23 23:42:43	0|bitcoin-git|[13bitcoin] 15luke-jr opened pull request #9619: Bugfix: RPC/Mining: GBT should return 1 MB sizelimit before segwit activates (06master...06bugfix_gbt_presw) 02https://github.com/bitcoin/bitcoin/pull/9619