1 2017-02-07 07:56:10 0|bitcoin-git|[13bitcoin] 15rebroad opened pull request #9704: Store downloaded blocks prior to shutdown. (06master...06StoreBlocksAtShutdown) 02 https://github.com/bitcoin/bitcoin/pull/9704
2 2017-02-07 09:48:59 0|bitcoin-git|[13bitcoin] 15laanwj opened pull request #9705: build: Add options to override BDB location (06master...062017_02_bdb_location) 02 https://github.com/bitcoin/bitcoin/pull/9705
3 2017-02-07 12:04:26 0|bitcoin-git|13bitcoin/06master 14dd5b011 15John Newbery: [Trivial] add comment about setting peer as HB peer....
4 2017-02-07 12:04:26 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/02464da5e4aa...729de15b6365
5 2017-02-07 12:04:27 0|bitcoin-git|13bitcoin/06master 14729de15 15Wladimir J. van der Laan: Merge #9604: [Trivial] add comment about setting peer as HB peer....
6 2017-02-07 12:04:40 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9604: [Trivial] add comment about setting peer as HB peer. (06master...06HBpeercomment) 02 https://github.com/bitcoin/bitcoin/pull/9604
7 2017-02-07 14:21:30 0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #9706: Remove unicode characters from RPC user and password in QA tests (06master...06rpctestuser) 02 https://github.com/bitcoin/bitcoin/pull/9706
8 2017-02-07 14:29:17 0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/729de15b6365...b709fe7ffc44
9 2017-02-07 14:29:18 0|bitcoin-git|13bitcoin/06master 1490fd29b 15practicalswift: Remove unused int64_t nSinceLastSeen
10 2017-02-07 14:29:18 0|bitcoin-git|13bitcoin/06master 14ac4a095 15practicalswift: Remove unused Python variables
11 2017-02-07 14:29:19 0|bitcoin-git|13bitcoin/06master 14b709fe7 15Wladimir J. van der Laan: Merge #9532: Remove unused variables...
12 2017-02-07 14:29:39 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9532: Remove unused variables (06master...06remove-unused-variables) 02 https://github.com/bitcoin/bitcoin/pull/9532
13 2017-02-07 15:19:31 0|bitcoin-git|[13bitcoin] 15sdaftuar closed pull request #9700: Cache segwit signature hash components inside CTransaction to optimize validation performance (06master...062017-02-segwit-hash-cache-2) 02 https://github.com/bitcoin/bitcoin/pull/9700
14 2017-02-07 15:22:36 0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #9707: Fix RPC failure testing (06master...06rpctestassert) 02 https://github.com/bitcoin/bitcoin/pull/9707
15 2017-02-07 15:26:55 0|bitcoin-git|[13bitcoin] 15TheBlueMatt opened pull request #9708: Clean Up all known races/platform-specific UB (06master...062017-02-fix-copystats-races) 02 https://github.com/bitcoin/bitcoin/pull/9708
16 2017-02-07 15:29:19 0|bitcoin-git|[13bitcoin] 15jnewbery closed pull request #9706: Remove unicode characters from RPC user and password in QA tests (06master...06rpctestuser) 02 https://github.com/bitcoin/bitcoin/pull/9706
17 2017-02-07 15:52:42 0|bitcoin-git|[13bitcoin] 15fanquake closed pull request #9699: Remove contrib/debian/patches subdirectory (06master...06removedebpatches) 02 https://github.com/bitcoin/bitcoin/pull/9699
18 2017-02-07 16:10:54 0|bitcoin-git|[13bitcoin] 15sdaftuar opened pull request #9709: [WIP] Cache segwit signature hash components inside CTransactionRef to optimize validation performance (06master...062017-02-segwit-cache-3) 02 https://github.com/bitcoin/bitcoin/pull/9709
19 2017-02-07 16:22:16 0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #9711: [Trivial] Remove incorrect help message from gettxoutproof() (06master...06gettxoutproofhelp) 02 https://github.com/bitcoin/bitcoin/pull/9711
20 2017-02-07 17:17:44 0|Chris_Stewart_5|Do we limit the amount of sigops that can be in a tx *besides* the limitations of 201 script ops and 80000 sigop cost?
21 2017-02-07 17:18:41 0|Chris_Stewart_5|sigop cost for a block*
22 2017-02-07 18:09:18 0|bitcoin-git|[13bitcoin] 15laanwj opened pull request #9712: bench: Fix initialization order in registration (06master...062017_02_fiasco) 02 https://github.com/bitcoin/bitcoin/pull/9712
23 2017-02-07 18:31:07 0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #9713: Fix error causes and messages in rpc/net.cpp (06master...06fixsetbanerrormessages) 02 https://github.com/bitcoin/bitcoin/pull/9713
24 2017-02-07 19:11:47 0|BlueMatt|sipa: whats the point of invlockorders in sync.cpp? it looks entirely untested/unused-aside-from-insert/erase
25 2017-02-07 19:14:39 0|sipa|BlueMatt: yes, it's in order to implement DeleteLock
26 2017-02-07 19:15:12 0|BlueMatt|oh, i missed that its using it to delete from lockorders, sorry
27 2017-02-07 19:38:54 0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #9714: Return correct error codes from bumpfee() (06master...06bumpfeeerrormessages) 02 https://github.com/bitcoin/bitcoin/pull/9714
28 2017-02-07 20:40:18 0|gmaxwell|moments from the front lines:
29 2017-02-07 20:40:19 0|gmaxwell|12:36 < gmaxwell> Dorian_: Is your wallet still syncing?
30 2017-02-07 20:40:20 0|gmaxwell|12:37 < Dorian_> gmaxwell - yes but it says is gonna do it for 4 years (!)
31 2017-02-07 21:22:47 0|achow101|what's the style for brackets and if statements? Is it bracket on same line, next line? brackets with single line ifs?
32 2017-02-07 21:23:27 0|Chris_Stewart_5|I think adam3us had a good point about exploits and single line ifs awhile back
33 2017-02-07 21:31:38 0|BlueMatt|achow101: if (rainbows && unicorns) {
34 2017-02-07 21:31:44 0|BlueMatt|magic();
35 2017-02-07 21:31:45 0|BlueMatt|}
36 2017-02-07 21:32:17 0|achow101|cool.
37 2017-02-07 21:39:45 0|gmaxwell|I believe this is also permitted: if (rainbows && unicorns) magic(); < braceless but only if one line.
38 2017-02-07 21:40:13 0|BlueMatt|does mininode not support multiple simultaneous connections????
39 2017-02-07 21:40:17 0|BlueMatt|sdaftuar, maybe?
40 2017-02-07 21:40:51 0|gmaxwell|what is no loger prermitted is:
41 2017-02-07 21:40:54 0|gmaxwell|if (dragons)
42 2017-02-07 21:40:57 0|gmaxwell|slay()
43 2017-02-07 21:40:59 0|gmaxwell|else
44 2017-02-07 21:41:08 0|gmaxwell|party();
45 2017-02-07 21:41:17 0|gmaxwell|and similar things that have more ;.
46 2017-02-07 21:41:45 0|adam3us|Chris_Stewart_5 it was just a personal rant. have seen other things fail when the magic turns out to be a macro that wasnt defended by do { foo(); bar(); } while (0) and being #define magic() foo(); bar() and then bad bad things happening when an if is added
47 2017-02-07 21:42:46 0|achow101|ok. good to know.
48 2017-02-07 21:43:31 0|achow101|I was just doing changes and I noticed that the style for if statements is all over the place
49 2017-02-07 21:46:00 0|gmaxwell|yea, recent change.
50 2017-02-07 21:46:03 0|gmaxwell|(thank god)
51 2017-02-07 21:46:38 0|Chris_Stewart_5|If anyone needs inspiration for bad things you can do in C this is always fun to look at: https://en.wikipedia.org/wiki/Underhanded_C_Contest
52 2017-02-07 21:49:45 0|BlueMatt|heh, python is garbage....like all random python shit, asyncore decided you wanted magic to happen in the background so dont bother exposing the socket connected-ness until you send data on the socket
53 2017-02-07 21:49:57 0|BlueMatt|making it impossible to test disconnect by not sending anything
54 2017-02-07 22:45:23 0|bitcoin-git|[13bitcoin] 15TheBlueMatt opened pull request #9715: Disconnect peers which we do not receive VERACKs from within 60 sec (06master...062017-02-disconnect-no-verack) 02 https://github.com/bitcoin/bitcoin/pull/9715