1 2017-02-10 01:26:28 0|bitcoin-git|[13bitcoin] 15sipa opened pull request #9733: Add getchaintxstats RPC (06master...06chaintxstats) 02 https://github.com/bitcoin/bitcoin/pull/9733
2 2017-02-10 01:39:49 0|BlueMatt|cfields: 0.15, please
3 2017-02-10 01:40:13 0|BlueMatt|cfields: lets please get simple-to-review shit so we can (finally) get 0.14 out the door
4 2017-02-10 01:47:33 0|cfields|BlueMatt: see the PR. I really have no preference
5 2017-02-10 01:47:59 0|BlueMatt|wait, which pr?
6 2017-02-10 01:48:49 0|BlueMatt|oh, comment
7 2017-02-10 02:00:37 0|BlueMatt|cfields: I guess my (weak) preference is atomics
8 2017-02-10 02:01:00 0|BlueMatt|because it doesnt change the compiled code for x86 (well, ok, only if we use release/acquire, but close enough) and is more obviously correct (tm)
9 2017-02-10 02:01:46 0|cfields|BlueMatt: works for me.
10 2017-02-10 02:02:11 0|BlueMatt|cfields: want me to pull it into that pr or a new one? it already has acks....
11 2017-02-10 02:02:42 0|cfields|heh
12 2017-02-10 02:03:08 0|BlueMatt|hmm?
13 2017-02-10 02:03:57 0|cfields|BlueMatt: well, technically commit is buggy because it doesn't fix the race as advertised. So i'd call that a fix to the PR as opposed to something new
14 2017-02-10 02:04:43 0|cfields|so I think it makes sense to just stick on top and poke for quick re-acks
15 2017-02-10 02:05:47 0|BlueMatt|I'll change the pr title, then :p
16 2017-02-10 02:05:59 0|BlueMatt|wait, no pr title was valid when opened
17 2017-02-10 02:06:51 0|BlueMatt|"
18 2017-02-10 02:06:51 0|BlueMatt|"Clean up all known races/platform-specific UB at the time PR was opened #9708
19 2017-02-10 02:06:53 0|BlueMatt|happy now?
20 2017-02-10 02:06:53 0|gribble|https://github.com/bitcoin/bitcoin/issues/9708 | Clean up all known races/platform-specific UB at the time PR was opened by TheBlueMatt ÷ Pull Request #9708 ÷ bitcoin/bitcoin ÷ GitHub
21 2017-02-10 02:06:54 0|BlueMatt|:p
22 2017-02-10 02:07:08 0|cfields|heh, I was just making the point that it's a fix. I really don't care :)
23 2017-02-10 02:07:16 0|cfields|lol
24 2017-02-10 02:07:49 0|cfields|ok, i'm definitely closing mine now though, since 9708 is tagged for 0.14
25 2017-02-10 02:08:08 0|BlueMatt|ok, sounds good, open another one :)
26 2017-02-10 02:09:37 0|cfields|tell you what, I'll open another one based on master if it happens to not conflict with yours
27 2017-02-10 02:09:57 0|BlueMatt|great! :)
28 2017-02-10 02:09:58 0|cfields|without looking, i'd call it 50/50 :)
29 2017-02-10 02:10:23 0|BlueMatt|conflict on git's within-3-lines shit? probably....actually conflict? no
30 2017-02-10 02:13:37 0|bitcoin-git|[13bitcoin] 15theuni closed pull request #9695: net: fix a few races. Credit @TheBlueMatt (06master...06net-atomic) 02 https://github.com/bitcoin/bitcoin/pull/9695
31 2017-02-10 02:16:12 0|cfields|actually, I think I'll pass on it either way. I think fatigue of these race commits is starting to set in. And since it's two 1-bit comparisons that have existed in prior releases, it's just not worth holding things up
32 2017-02-10 02:17:30 0|BlueMatt|cfields: ok, I have no objections to that, either...when its std::string copies I'm not very happy, when its just pointer == NULL comparisons I suppose I dont care much
33 2017-02-10 02:18:06 0|cfields|BlueMatt: sure. The only reason I'd push for it is if it was the lone thing keeping valgrind/helgrind/tsan/etc. from running cleanly.
34 2017-02-10 02:18:20 0|BlueMatt|fair
35 2017-02-10 02:18:30 0|cfields|and I don't think that's the case?
36 2017-02-10 02:19:04 0|BlueMatt|my helgrind is still running cleanly :)
37 2017-02-10 03:10:14 0|bitcoin-git|[13bitcoin] 15sipa opened pull request #9734: Add updating of chainTxData to release process (06master...06chaintxnotes) 02 https://github.com/bitcoin/bitcoin/pull/9734
38 2017-02-10 03:43:34 0|gmaxwell|Whatever patch stack I'm running with here makes tsan clean except for some startup noise.
39 2017-02-10 03:43:51 0|gmaxwell|(by noise I mean real issues, in this case.)
40 2017-02-10 07:24:17 0|beyondsee|any one here?
41 2017-02-10 07:28:41 0|sipa|nope
42 2017-02-10 07:31:27 0|cannon-c|no
43 2017-02-10 07:36:02 0|paveljanik|haven't seen any one for a long time...
44 2017-02-10 07:36:20 0|sipa|paveljanik! what a surprise!
45 2017-02-10 07:43:57 0|paveljanik|gribble" later tell anyone Beyonce wanted to talk to you
46 2017-02-10 08:14:48 0|bitcoin-git|13bitcoin/06master 14ca9955e 15Jonas Schnelli: Remove bitseed.xf2.org form the dns seed list
47 2017-02-10 08:14:48 0|bitcoin-git|[13bitcoin] 15jonasschnelli pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/36f9d3ae6da4...33f3b21407a3
48 2017-02-10 08:14:49 0|bitcoin-git|13bitcoin/06master 1433f3b21 15Jonas Schnelli: Merge #9730: Remove bitseed.xf2.org form the dns seed list...
49 2017-02-10 08:15:07 0|bitcoin-git|[13bitcoin] 15jonasschnelli closed pull request #9730: Remove bitseed.xf2.org form the dns seed list (06master...062017/02/seeds) 02 https://github.com/bitcoin/bitcoin/pull/9730
50 2017-02-10 09:04:46 0|bitcoin-git|[13bitcoin] 15laanwj opened pull request #9735: devtools: Handle Qt formatting characters edge-case in update-translations.py (06master...062017_02_qt_translations) 02 https://github.com/bitcoin/bitcoin/pull/9735
51 2017-02-10 09:30:00 0|bitcoin-git|[13bitcoin] 15laanwj opened pull request #9736: Pre-0.14.0 hardcoded seeds update (06master...062017_02_dnsseeds) 02 https://github.com/bitcoin/bitcoin/pull/9736
52 2017-02-10 10:21:30 0|bitcoin-git|[13bitcoin] 15rebroad opened pull request #9737: Don't disconnect feeler connections prematurely (06master...06ServicesIrrelevantForFeelerConnections) 02 https://github.com/bitcoin/bitcoin/pull/9737
53 2017-02-10 10:21:58 0|jl2012|Is it useful to have an rpc command for calling TestBlockValidity, with or without checking PoW?
54 2017-02-10 10:28:07 0|wumpus|I don't know? what is your use case?
55 2017-02-10 11:34:52 0|jl2012|For example, I created a block and want to test if it is valid, before mining it
56 2017-02-10 11:37:36 0|wumpus|but sure, a "block proposals" thing could make sense, it has been discussed before on github
57 2017-02-10 11:43:19 0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/33f3b21407a3...2447c1024e60
58 2017-02-10 11:43:20 0|bitcoin-git|13bitcoin/06master 1445e2e08 15Cory Fields: net: rearrange so that socket accesses can be grouped together
59 2017-02-10 11:43:20 0|bitcoin-git|13bitcoin/06master 149a0b784 15Cory Fields: net: add a lock around hSocket
60 2017-02-10 11:43:21 0|bitcoin-git|13bitcoin/06master 142447c10 15Wladimir J. van der Laan: Merge #9698: net: fix socket close race...
61 2017-02-10 11:43:39 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9698: net: fix socket close race (06master...06fix-socket-disconnect2) 02 https://github.com/bitcoin/bitcoin/pull/9698
62 2017-02-10 11:44:34 0|wumpus|though I can't find it right now
63 2017-02-10 13:40:46 0|cfields|jl2012: https://github.com/bitcoin/bitcoin/pull/9000
64 2017-02-10 13:41:04 0|cfields|i'll rebase
65 2017-02-10 16:09:07 0|gmaxwell|jl2012: we have block proposals, use getblocktemplate with the mode "proposal" and it will check a block while ignoring the pow.
66 2017-02-10 16:12:19 0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #9738: gettxoutproof() should return consistent result (06master...06fixgettxoutproof) 02 https://github.com/bitcoin/bitcoin/pull/9738
67 2017-02-10 16:58:48 0|Chris_Stewart_5|Is there a reason there isn't more functionality exposed for the java secp256k1 api? Or is it a matter of some one just needs to write it?
68 2017-02-10 17:03:55 0|bitcoin-git|13bitcoin/06master 149db8eec 15John Newbery: Fix RPC failure testing...
69 2017-02-10 17:03:55 0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/2447c1024e60...b860915f8b0d
70 2017-02-10 17:03:56 0|bitcoin-git|13bitcoin/06master 14b860915 15MarcoFalke: Merge #9707: Fix RPC failure testing...
71 2017-02-10 17:04:15 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #9707: Fix RPC failure testing (06master...06rpctestassert) 02 https://github.com/bitcoin/bitcoin/pull/9707
72 2017-02-10 17:05:35 0|sipa|Chris_Stewart_5: what is missing?
73 2017-02-10 17:05:42 0|sipa|patches welcome
74 2017-02-10 17:10:03 0|Chris_Stewart_5|I think you had mentioned there is a CPubKey::IsValid function inside of secp256k1 which is the consensus check if the pubkey is valid?
75 2017-02-10 17:34:54 0|sipa|look at what bitcoin core does
76 2017-02-10 17:36:28 0|sipa|CPubKey::IsFullyValid
77 2017-02-10 17:54:30 0|Chris_Stewart_5|ahh, that makes much more sense.
78 2017-02-10 18:20:07 0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #9739: Fix BIP68 activation test (06master...06fixbip68testing) 02 https://github.com/bitcoin/bitcoin/pull/9739
79 2017-02-10 18:22:14 0|cfields|jnewbery: lots of great work!
80 2017-02-10 18:23:05 0|jnewbery|Thanks! I've uncovered some gnarly stuff in the course of my archaeology :)
81 2017-02-10 18:26:27 0|cfields|jnewbery: heh, i see that. Seems many of the tests have been accidentally working for a while
82 2017-02-10 18:27:14 0|jnewbery|yup. Hopefully once these PRs have gone through we'll be in a better place and the tests will actually be testing things!
83 2017-02-10 18:28:32 0|cfields|heh
84 2017-02-10 18:28:55 0|cfields|jnewbery: i ran into something similar to 9707 (i think) when writing a test recently. I suck at python, and the exception model in mininode is not clear to me. Mind taking look when you have a min and seeing if my approach is reasonable or i'm just piling on more brokenness?
85 2017-02-10 18:29:35 0|jnewbery|Absolutely. Very happy to look at it
86 2017-02-10 18:30:09 0|cfields|jnewbery: thanks! It's the test added in #9720
87 2017-02-10 18:30:11 0|gribble|https://github.com/bitcoin/bitcoin/issues/9720 | net: fix banning and disallow sending messages before receiving verack by theuni ÷ Pull Request #9720 ÷ bitcoin/bitcoin ÷ GitHub
88 2017-02-10 18:30:58 0|cfields|jnewbery: ping me when you have a min to look at it and i'll explain the problem?
89 2017-02-10 18:36:50 0|jnewbery|Sure. Give me a few minutes
90 2017-02-10 18:47:11 0|cfields|no rush
91 2017-02-10 19:01:03 0|jnewbery|did you get my private message?