1 2017-02-12 07:50:58	0|bitcoin-git|[13bitcoin] 1534ro opened pull request #9744: Remove unused module from rpc-tests (06master...06remove-unused-modules-from-rpc-tests) 02https://github.com/bitcoin/bitcoin/pull/9744
 2 2017-02-12 09:38:28	0|bitcoin-git|[13bitcoin] 1534ro opened pull request #9745: [RPC] Getting confirmations command (06master...06add-getconfirmations-to-rpc) 02https://github.com/bitcoin/bitcoin/pull/9745
 3 2017-02-12 16:48:09	0|bitcoin-git|[13bitcoin] 15kobake opened pull request #9747: Vs2015 (06master...06vs2015) 02https://github.com/bitcoin/bitcoin/pull/9747
 4 2017-02-12 16:50:08	0|bitcoin-git|[13bitcoin] 15kobake closed pull request #9747: Vs2015 (06master...06vs2015) 02https://github.com/bitcoin/bitcoin/pull/9747
 5 2017-02-12 18:04:31	0|arubi|I think I'm building the crediting transaction from script_tests.json wrong.  I can pass tests that don't have a checksig in them, but (e.g.) a p2pk test fails with a bad signature.  here's an example of both cases:  https://paste.fedoraproject.org/555262/92264814/raw/  .  the tests describe the crediting tx structure right at the beginning of the script_tests.json file.  would appreciate your input.
 6 2017-02-12 18:20:48	0|bitcoin-git|[13bitcoin] 15vosa88 opened pull request #9748: config.txt (06master...06patch-1) 02https://github.com/bitcoin/bitcoin/pull/9748
 7 2017-02-12 18:21:55	0|bitcoin-git|[13bitcoin] 15fanquake closed pull request #9748: config.txt (06master...06patch-1) 02https://github.com/bitcoin/bitcoin/pull/9748
 8 2017-02-12 20:08:43	0|jonasschnelli|sipa: re https://github.com/bitcoin/bitcoin/pull/9743/files ...
 9 2017-02-12 20:08:58	0|jonasschnelli|is std::unique_ptr<Secp256k1Init> ecc; not equivalent to ecc.reset(new Secp256k1Init());
10 2017-02-12 20:09:12	0|sipa|jonasschnelli: no
11 2017-02-12 20:09:14	0|jonasschnelli|I know I miss something... but I wonder what
12 2017-02-12 20:09:24	0|sipa|jonasschnelli: a unique_ptr is initialized to nullptr by default
13 2017-02-12 20:09:48	0|jonasschnelli|I stepped it in lldb and got a non nullptr after std::unique_ptr<Secp256k1Init> ecc;
14 2017-02-12 20:09:56	0|jonasschnelli|But maybe a -O0 issue?
15 2017-02-12 20:10:30	0|sipa|jonasschnelli: you must be doing something wrong :)
16 2017-02-12 20:10:39	0|jonasschnelli|heh.. okay. I see the point now.
17 2017-02-12 20:12:03	0|jonasschnelli|Ah. Yes. __first_ = 0x0000000000000000
18 2017-02-12 20:12:17	0|jonasschnelli|The question then remains, how could this have worked before your PR. :)
19 2017-02-12 20:43:34	0|sipa|because the secp library does right now not actually need a check the ctx pointer ther
20 2017-02-12 20:43:47	0|sipa|but it declares that argument is required to be nonnull
21 2017-02-12 20:44:03	0|sipa|so with sanitizers on, that's enforced at runtime