1 2017-02-14 02:24:02 0|achow101|does testnet use the bitcoin.conf in the datadir or one in datadir/testnet3?
2 2017-02-14 02:42:16 0|sipa|"it's complicated"
3 2017-02-14 02:44:34 0|achow101|one? both? something else?
4 2017-02-14 02:44:47 0|sipa|both...
5 2017-02-14 02:44:56 0|sipa|depending on whether you explicitly specify a datadir
6 2017-02-14 02:44:58 0|sipa|(i think)
7 2017-02-14 02:45:26 0|achow101|great
8 2017-02-14 03:30:45 0|luke-jr|AFAIK there isn't a bitcoin.conf in datadir/testnet3?
9 2017-02-14 03:30:51 0|luke-jr|(and if you make one it will be ignored)
10 2017-02-14 03:31:02 0|luke-jr|I could be wrong, but I recall expecting it to work, and finding it doesn't..
11 2017-02-14 05:26:58 0|jcorgan|i have a couple questions/comments about some of the init.cpp network parameter settings
12 2017-02-14 05:27:30 0|jcorgan|my goal is to allow hostname lookups for some of the params (-proxy, -onion, -torcontrol)
13 2017-02-14 05:28:10 0|jcorgan|there is a -dns parameter for enabling this for -connect, -addnode, and -seednode
14 2017-02-14 05:28:41 0|jcorgan|and it gets read into fAllowLookup
15 2017-02-14 05:29:14 0|jcorgan|the initialization for those eventually resolves to Lookup(...) with fAllowNode as the final parameter
16 2017-02-14 05:30:03 0|jcorgan|i changed the LookupNumeric to Lookup for -proxy and -onion, with the same args, and it works
17 2017-02-14 05:30:38 0|jcorgan|but only if i move the initialization for -dns up before this section so the fNameLookup is set already
18 2017-02-14 05:31:05 0|jcorgan|so, this is only a few lines change in init.cpp; is this all it takes?
19 2017-02-14 05:31:24 0|jcorgan|(i haven't touched torcontrol yet, but the other two are working for me now)
20 2017-02-14 05:32:17 0|jcorgan|is it ok to extend the meaning of -dns to cover these three other params in addition to the ones it affects now?
21 2017-02-14 05:32:49 0|jcorgan|oh, s/fAllowLookup/fNameLookup/
22 2017-02-14 05:33:05 0|jcorgan|would this be useful to anyone but me?
23 2017-02-14 05:36:04 0|jcorgan|maybe it would be easier to just do a PR
24 2017-02-14 05:39:24 0|sipa|jcorgan: seems reasonable to me
25 2017-02-14 05:42:18 0|jcorgan|i'll finish the torcontrol stuff and PR it then
26 2017-02-14 05:42:37 0|jcorgan|it will also need some documentation changes to reflect this
27 2017-02-14 06:00:43 0|jcorgan|ah, torcontrol is calling a raw address parser in libevent, will need to do some actual work to implement hostname lookup for that
28 2017-02-14 09:17:10 0|jonasschnelli|Would it make sense to mention something about the net refactoring in the 0.14er release notes? https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.14.0-Release-notes
29 2017-02-14 09:28:45 0|gmaxwell|jonasschnelli: need to do a measurement of a sync between a pair of old nodes and a pair of new nodes.
30 2017-02-14 09:29:25 0|gmaxwell|and just mention as a top level release note that the IBD speed went from x to y due to networking improvements, assume valid, validation cache improvements, and other optimizations.
31 2017-02-14 09:29:48 0|jonasschnelli|gmaxwell: I need to talk about the 0.14 release tomorrow,... do we have a rough estimation already?
32 2017-02-14 09:30:21 0|gmaxwell|A kazillion fold.
33 2017-02-14 09:30:51 0|gmaxwell|For a talk you can say reduced by hours.
34 2017-02-14 09:31:25 0|jonasschnelli|Okay. That seems to be vague but precise enough. :)
35 2017-02-14 09:31:41 0|gmaxwell|on fast computers the network changes and validation cache help a lot, and on really slow computers the assume valid change is more tens of hours reduction.
36 2017-02-14 09:32:27 0|jonasschnelli|Regardless of talks, etc. We should mention the sigcache and the network "refactor" in the release notes.
37 2017-02-14 09:33:01 0|gmaxwell|well as I said, we should mention the performance, and list why. The headline is the performance.
38 2017-02-14 09:33:01 0|jonasschnelli|It seems to me that the a major part of the effort for 0.14 is missing in the release notes
39 2017-02-14 09:33:25 0|jonasschnelli|I agree with performance as headline.
40 2017-02-14 10:10:14 0|bitcoin-git|[13bitcoin] 15jonasschnelli opened pull request #9758: Selectively suppress deprecation warnings (06master...062017/02/deprac_warns) 02https://github.com/bitcoin/bitcoin/pull/9758
41 2017-02-14 11:22:03 0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/d978c41e1ec4...ec66d06e6ef3
42 2017-02-14 11:22:04 0|bitcoin-git|13bitcoin/06master 145e903a5 15Wladimir J. van der Laan: devtools: Handle Qt formatting characters edge-case in update-translations.py...
43 2017-02-14 11:22:04 0|bitcoin-git|13bitcoin/06master 147179e7c 15Wladimir J. van der Laan: qt: Periodic translations update
44 2017-02-14 11:22:05 0|bitcoin-git|13bitcoin/06master 14ec66d06 15Wladimir J. van der Laan: Merge #9735: devtools: Handle Qt formatting characters edge-case in update-translations.py...
45 2017-02-14 11:22:18 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9735: devtools: Handle Qt formatting characters edge-case in update-translations.py (06master...062017_02_qt_translations) 02https://github.com/bitcoin/bitcoin/pull/9735
46 2017-02-14 11:30:17 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9751: Mini fix bincoin against bitcoin (06master...06patch-1) 02https://github.com/bitcoin/bitcoin/pull/9751
47 2017-02-14 11:33:46 0|wumpus|just bumped the expiration dates for my key (0x74810B012346C9A6) and the bitcoin core release signing key (0x90C8019E36C2E964) two years forward, you might want to re-fetch them
48 2017-02-14 11:41:19 0|wumpus|(or --refresh-keys)
49 2017-02-14 13:32:53 0|bitcoin-git|[13bitcoin] 15laanwj pushed 4 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/ec66d06e6ef3...edc9e63c5799
50 2017-02-14 13:32:54 0|bitcoin-git|13bitcoin/06master 143cf9917 15Russell Yanofsky: Add test to check new importmulti "now" value...
51 2017-02-14 13:32:54 0|bitcoin-git|13bitcoin/06master 14442887f 15Russell Yanofsky: Require timestamps for importmulti keys...
52 2017-02-14 13:32:55 0|bitcoin-git|13bitcoin/06master 14266a811 15Russell Yanofsky: Use MTP for importmulti "now" timestamps
53 2017-02-14 13:33:10 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9682: Require timestamps for importmulti keys (06master...06pr/multinow) 02https://github.com/bitcoin/bitcoin/pull/9682
54 2017-02-14 13:35:37 0|bitcoin-git|[13bitcoin] 15laanwj pushed 5 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/edc9e63c5799...b08656e34314
55 2017-02-14 13:35:38 0|bitcoin-git|13bitcoin/06master 142cbd119 15Matt Corallo: Disconnect peers which we do not receive VERACKs from within 60 sec
56 2017-02-14 13:35:38 0|bitcoin-git|13bitcoin/06master 148aaba7a 15Matt Corallo: qa: mininode learns when a socket connects, not its first action
57 2017-02-14 13:35:39 0|bitcoin-git|13bitcoin/06master 14b436f92 15Matt Corallo: qa: Expose on-connection to mininode listeners
58 2017-02-14 13:35:59 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9715: Disconnect peers which we do not receive VERACKs from within 60 sec (06master...062017-02-disconnect-no-verack) 02https://github.com/bitcoin/bitcoin/pull/9715
59 2017-02-14 13:40:15 0|jonasschnelli|Only two left: https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.14.0
60 2017-02-14 13:40:22 0|jonasschnelli|Going to test 9108 now
61 2017-02-14 13:42:55 0|bitcoin-git|[13bitcoin] 15laanwj pushed 7 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/b08656e34314...e87ce95fbdc6
62 2017-02-14 13:42:56 0|bitcoin-git|13bitcoin/06master 148502e7a 15Cory Fields: net: parse reject earlier...
63 2017-02-14 13:42:56 0|bitcoin-git|13bitcoin/06master 14c45b9fb 15Cory Fields: net: correctly ban before the handshake is complete...
64 2017-02-14 13:42:57 0|bitcoin-git|13bitcoin/06master 14cbfc5a6 15Cory Fields: net: require a verack before responding to anything else...
65 2017-02-14 13:43:10 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9720: net: fix banning and disallow sending messages before receiving verack (06master...06fix-ban) 02https://github.com/bitcoin/bitcoin/pull/9720
66 2017-02-14 13:55:19 0|jonasschnelli|luke-jr: I think your sensitive datafilter is nice,.. but we always dump the sent command into the console window... this should also be filtered, not?
67 2017-02-14 14:51:08 0|jonasschnelli|Is there a reason why the internal miner mines to p2pk instead of p2pkh?
68 2017-02-14 14:51:09 0|jonasschnelli|void CWallet::GetScriptForMining(boost::shared_ptr<CReserveScript> &script)
69 2017-02-14 14:51:16 0|jonasschnelli|seems to generate CScript() << ToByteVector(pubkey) << OP_CHECKSIG;
70 2017-02-14 14:57:28 0|bitcoin-git|13bitcoin/06master 140b4f273 15Luke Dashjr: Bugfix: Qt/Options: Restore persistent "restart required" notice
71 2017-02-14 14:57:28 0|bitcoin-git|[13bitcoin] 15jonasschnelli pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/e87ce95fbdc6...a441db01b527
72 2017-02-14 14:57:29 0|bitcoin-git|13bitcoin/06master 14a441db0 15Jonas Schnelli: Merge #9755: Bugfix: Qt/Options: Restore persistent "restart required" notice...
73 2017-02-14 14:58:06 0|bitcoin-git|[13bitcoin] 15jonasschnelli closed pull request #9755: Bugfix: Qt/Options: Restore persistent "restart required" notice (06master...06bugfix_gui_opts_restartreq) 02https://github.com/bitcoin/bitcoin/pull/9755
74 2017-02-14 15:33:53 0|bitcoin-git|[13bitcoin] 15ryanofsky opened pull request #9760: [wallet] Remove importmulti always-true check (06master...06pr/multitaut) 02https://github.com/bitcoin/bitcoin/pull/9760
75 2017-02-14 17:44:10 0|jl2012|jonasschnelli: I think it's overall cheaper to use P2PK
76 2017-02-14 20:47:59 0|luke-jr|jonasschnelli: dunno, maybe
77 2017-02-14 20:52:19 0|sipa|jonasschnelli: i think the real reason is just histoical
78 2017-02-14 20:52:23 0|sipa|*historical
79 2017-02-14 23:06:25 0|bitcoin-git|[13bitcoin] 15ryanofsky opened pull request #9761: Use 2 hour grace period for key timestamps in importmulti rescans (06master...06pr/multigrace) 02https://github.com/bitcoin/bitcoin/pull/9761
80 2017-02-14 23:37:34 0|bitcoin-git|[13bitcoin] 15pstratem opened pull request #9762: Add txdetails parameter to getblock. (06master...062017-02-14-getblock-includetxs) 02https://github.com/bitcoin/bitcoin/pull/9762