1 2017-02-21 00:55:22 0|gmaxwell|cfields: I'd like to see the vla warning go in ( #9789 ) -- but it really should be a warning, as we just encountered a fails in one compiler but not another.
2 2017-02-21 00:55:24 0|gribble|https://github.com/bitcoin/bitcoin/issues/9789 | build: disallow variable length arrays by theuni ÷ Pull Request #9789 ÷ bitcoin/bitcoin ÷ GitHub
3 2017-02-21 00:56:48 0|gmaxwell|BlueMatt: We're making too many changes with the network without good data on their improvements. The recent ones have been such obviously clear wins that it's okay-- but if we do not get good ways of benchmarking these things running constantly, we're going to eventually make dumb decisions. As a bonus, we'll be able to describe our improvements in ways more specific than mega-super-amazing. :)
4 2017-02-21 00:56:51 0|cfields|gmaxwell: ok. i thought on that a good bit after you raised the objection, and ultimately i agree
5 2017-02-21 00:57:24 0|cfields|gmaxwell: speaking of which, i'm futzing with gnuplot atm :)
6 2017-02-21 00:57:37 0|BlueMatt|gmaxwell: talk to jnewbery :)
7 2017-02-21 00:58:07 0|BlueMatt|(he's working on using the simulation framework stuff to build benchmark CI, and I told him he should set up mini-networks with simulated latency and benchmark that, too)
8 2017-02-21 00:58:11 0|cfields|gmaxwell: plotting out a few different data sets wrt ibd sync between 0.13/0.14
9 2017-02-21 00:58:21 0|gmaxwell|cfields: sweet.
10 2017-02-21 00:58:38 0|gmaxwell|title "Mega-super-amazing performance"
11 2017-02-21 06:12:58 0|cfields|gmaxwell: https://i.imgur.com/8M3wPM4.png
12 2017-02-21 06:13:25 0|cfields|i got tired of arguing with gnuplot over the x axis :\
13 2017-02-21 06:14:01 0|cfields|(it's linear)
14 2017-02-21 06:14:39 0|gmaxwell|set xdata time
15 2017-02-21 06:14:56 0|gmaxwell|set timefmt "%s" ?
16 2017-02-21 06:15:28 0|cfields|gmaxwell: it's real timestamps, not scaled down to 0. So it wants to show crazy-high second-values
17 2017-02-21 06:15:46 0|gmaxwell|it's a neat graph though it really hides a lot of the other improvements on 0.14 since it only goes to 295k
18 2017-02-21 06:16:00 0|sipa|cfields: so subtract the lowest timestamp?
19 2017-02-21 06:16:22 0|gmaxwell|using 1:($2-constant) with lines
20 2017-02-21 06:16:42 0|cfields|gmaxwell: well the 295k is where the checkpoint kicks in in 0.14. I'd prefer to see a separate graph syncing blocks 0 to 100,000 or so without checkpoints/assumevalid
21 2017-02-21 06:16:54 0|cfields|*in 0.13, sorry
22 2017-02-21 06:17:15 0|gmaxwell|it's not just that, the behavior of the blockchain is quite different in the last two years than the first two. :)
23 2017-02-21 06:17:18 0|sipa|i think it's a neat graph
24 2017-02-21 06:17:41 0|sipa|it doesn't show everything, but it's hard to put everything in one graph without misrepresenting one thing or another
25 2017-02-21 06:18:14 0|cfields|gmaxwell: very much so. Clearly 0.14 benefits most from the improved short bursts in the early blocks
26 2017-02-21 06:19:34 0|cfields|but yes, i'd like to do another where validation is forced for all
27 2017-02-21 06:23:51 0|gmaxwell|It would be nice to have a general figure reflecting user expirence for the release note. "With default settings syncing has been reduced from X hours to Y hours on a quad-core system from another local 0.14 node."
28 2017-02-21 06:25:32 0|cfields|gmaxwell: agreed. I have figures for 0.14->0.14 on an ec2 4xcpu, 8gb ram. It's ~3hrs. 0.13.2->0.13.2 was taking too long and i got impatent, wanting to run other tests :(
29 2017-02-21 06:25:41 0|cfields|i can fire that one up again tomorrow and just let it go
30 2017-02-21 06:26:29 0|cfields|(that was dbcache=4000, blocksonly=1, listen=0, disablewallet=1)
31 2017-02-21 06:27:00 0|gmaxwell|ec2 is really IO starved normally no?
32 2017-02-21 06:27:06 0|cfields|*impatient. That was a dangerous typo :)
33 2017-02-21 06:29:04 0|cfields|gmaxwell: unsure. I figured it was representative of how lots of nodes are run, so good data point
34 2017-02-21 06:29:09 0|cfields|no clue how true that is
35 2017-02-21 06:32:31 0|gmaxwell|I'm pretty sure any customization of dbcache limits it to representing <5% of nodes.
36 2017-02-21 06:33:44 0|cfields|mm, good point
37 2017-02-21 06:36:26 0|jeremyrubin|Hey I have an idea...
38 2017-02-21 06:36:38 0|jeremyrubin|what if during validating sync
39 2017-02-21 06:37:13 0|jeremyrubin|hmmm nevermind... let me read more
40 2017-02-21 06:44:07 0|cfields|luke-jr: atomic shared_ptr ?
41 2017-02-21 06:44:15 0|luke-jr|cfields: std::align
42 2017-02-21 06:45:06 0|cfields|huh, i wasn't aware of std::align. Only alignof/alignas
43 2017-02-21 07:02:20 0|gmaxwell|... idiot fake nodes, I have one connected to me that continually sends verack messages instead of pongs.
44 2017-02-21 07:04:45 0|sipa|lol
45 2017-02-21 07:05:24 0|luke-jr|XD
46 2017-02-21 07:05:54 0|sipa|Ḧello! speed v 70012?- sure, i can speak 70012 - have you heard about tx ab315fa5118? - sure i can speak 70012!
47 2017-02-21 07:07:06 0|gmaxwell|"It says ack, right in the name."
48 2017-02-21 07:08:19 0|cfields|heh
49 2017-02-21 07:08:35 0|cfields|makes sense, i think. From the laziest possible implementor's perspective
50 2017-02-21 07:08:35 0|luke-jr|gmaxwell: verack
51 2017-02-21 07:08:44 0|cfields|pretty sure we never penalized dupe veracks
52 2017-02-21 07:09:11 0|sipa|i thought we did
53 2017-02-21 07:09:12 0|cfields|so if you don't feel like coding an extra 3 lines, just always reply with verack. ship it!
54 2017-02-21 07:09:18 0|gmaxwell|yea, if your goal is just to record inv traffic; 'anytime you get anything send this canned verack' is the absolute minimum to make the protocol go.
55 2017-02-21 07:10:25 0|luke-jr|gmaxwell: why wait until you get something? XD
56 2017-02-21 07:10:56 0|cfields|sipa: doesn't look like it. Unless there's something subtle
57 2017-02-21 07:12:17 0|sipa|we do penalize duplicate version, right?
58 2017-02-21 07:12:32 0|cfields|both, now
59 2017-02-21 07:12:48 0|gmaxwell|I don't think we peanalize duplicate verack now, do we?
60 2017-02-21 07:13:51 0|luke-jr|gmaxwell: verack
61 2017-02-21 07:14:21 0|cfields|hmm, i guess not. Could've sworn that went in
62 2017-02-21 08:38:49 0|bitcoin-git|[13bitcoin] 15benma opened pull request #9815: Trivial: use EXIT_ codes instead of magic numbers (06master...06exitcode) 02https://github.com/bitcoin/bitcoin/pull/9815
63 2017-02-21 08:43:14 0|gmaxwell|I vaguely recall from some other project that there was a reason to not do that ^. ... probably on obscure platforms we don't support.
64 2017-02-21 08:44:43 0|gmaxwell|hm. perhaps I remember incorrectly.
65 2017-02-21 08:59:12 0|jonasschnelli|Still having troubles setting up gitian LXC. The LXC container can't connect to the internet. I don't have a VM for gitian. I run gbuild directly on a host. The host has a single public IPv4 addr. I'm not sure how I can setup the bridging..
66 2017-02-21 09:03:41 0|wumpus|gmaxwell: that's pretty late to start arguing against it we've already done it for 99% of the project
67 2017-02-21 09:04:19 0|wumpus|jonasschnelli: strange.
68 2017-02-21 09:05:06 0|wumpus|jonasschnelli: did you set the GITIAN_HOST_IP and LXC_GUEST_IP?
69 2017-02-21 09:06:29 0|wumpus|jonasschnelli: there's some setup here that you need https://github.com/bitcoin/bitcoin/blob/master/doc/gitian-building.md#setting-up-debian-for-gitian-building
70 2017-02-21 09:06:38 0|fanquake|wumpus I agree with your comments re gitian building and LXC. That is what I've always used, these problems are all that I've ever had with it. I think the gitian build guide also does a, lengthy, but good job of explaining setup.
71 2017-02-21 09:07:21 0|fanquake|That's using a debian & virtualbox on osx.
72 2017-02-21 09:07:42 0|wumpus|fanquake: thanks. we should just try to fix the guide, at least the parts people stumbling on. Writing another one for KVM, which proabably gets outdated just as quickly isn't much of a solution.
73 2017-02-21 09:08:26 0|fanquake|cfields If I start a node with those params, and quit after some syncing I get a segfault :o Investigating now.
74 2017-02-21 09:09:28 0|wumpus|also I think LXC is conceptually the right solution for this problem - what you want for building is an isolated container, not a full emulated operating system
75 2017-02-21 09:09:40 0|fanquake|wumpus yea, the guide could probably use some improving. I've tried to keep it up to date every now and then. I though we also had a gitian-building script that was meant to automate some of the setting up?
76 2017-02-21 09:10:05 0|gmaxwell|wumpus: fair enough!
77 2017-02-21 09:10:24 0|wumpus|fanquake: I'm kind of disappointed that the person adding the gitian-building script didn't update the guide to use it
78 2017-02-21 09:10:35 0|wumpus|fanquake: that kind of guarantees no one will use his script
79 2017-02-21 09:11:14 0|fanquake|We also link to that Docker setup. I checked the other day and it hasn't been updated in > 1yr. Think we could probably drop that link from the guide.
80 2017-02-21 09:11:16 0|wumpus|gmaxwell: according to the manpage it's even more portable "The use of EXIT_SUCCESS and EXIT_FAILURE is slightly more portable (to non-UNIX environments) than the use of 0 and some nonzero value like 1 or -1. In particular, VMS uses a different convention." VMS!
81 2017-02-21 09:11:21 0|luke-jr|wumpus: I think UML is a better solution :p
82 2017-02-21 09:11:35 0|wumpus|luke-jr: the 90's called and want UML back? :p
83 2017-02-21 09:12:05 0|gmaxwell|maybe thats what I'm remembering! :P
84 2017-02-21 09:12:08 0|luke-jr|â˺
85 2017-02-21 09:12:27 0|wumpus|luke-jr: more seriously, I haven't heard of anyone using UML in 10 years or so
86 2017-02-21 09:12:31 0|jonasschnelli|wumpus: I have set GITIAN_HOST_IP and LXC_GUEST_IP to the same public ipv4 addr. I'm not aware of any other IP address that could be used?!
87 2017-02-21 09:12:40 0|jonasschnelli|There is no LAN in my case
88 2017-02-21 09:12:48 0|fanquake|Can anyone confirm this. src/qt/bitcoin-qt --reindex --dbacache=8192 --par=10 --blocksonly=1 --listen=0 --disablewallet=1 quiting after any amount of time gives a segfault.
89 2017-02-21 09:13:01 0|luke-jr|wumpus: I'm surprised you remembered it
90 2017-02-21 09:13:10 0|luke-jr|well, slightly.
91 2017-02-21 09:13:36 0|wumpus|luke-jr: I remember a lot of useless things
92 2017-02-21 09:14:04 0|wumpus|jonasschnelli:i: if you set them to the same IP it will fail. The point is that the host and guest communicate with each other on this bridge network
93 2017-02-21 09:15:10 0|jonasschnelli|Hmm.. maybe I use ifconfig br0 10.0.3.2/24 up for the bridge and set 10.0.3.5 as guest IP and my public ip as host... let me try
94 2017-02-21 09:15:30 0|wumpus|jonasschnelli: so the sequence there is : set up a br0 network, assign ourlelves an IP on it and bring it up, set up masquerading for the interface to the outside, set up forwarding, then tell gitian-builder these things by the way of environment variables
95 2017-02-21 09:16:09 0|wumpus|GITIAN_HOST_IP should be the IP we assign ourselves using ifconfig br0
96 2017-02-21 09:16:23 0|wumpus|LXC_GUEST_IP is the IP that the guest should have, and should be within this subnet
97 2017-02-21 09:17:08 0|fanquake|Ok, the problem is just with ââ¬âdisablewallet=1 , running with that and then quitting will segfault on master.
98 2017-02-21 09:17:09 0|jonasschnelli|Okay. Then GITIAN_HOST_IP=10.0.3.2 and LXC_GUEST_IP=10.0.3.5 should work... ok let me try. I think i also enabled Ipv4 forwarding
99 2017-02-21 09:18:27 0|jonasschnelli|fanquake: Thanks for the report. Is there already an issue on github for that?
100 2017-02-21 09:18:39 0|jonasschnelli|I can try to fix this
101 2017-02-21 09:18:47 0|fanquake|jonasschnelli checking, if not ill open with some details.
102 2017-02-21 09:18:56 0|fanquake|Checking with 0.14.0rc1 that is.
103 2017-02-21 09:18:56 0|jonasschnelli|Thanks!
104 2017-02-21 09:19:22 0|jonasschnelli|Oh. Now install.log reports successful apt installed... thanks wumpus!
105 2017-02-21 09:25:00 0|jonasschnelli|Hmm... now I see in build.log that Fetching ccache-3.3.3.tar.bz2 has stalled (no progress at all). I guess this means the target can't connect to the internet?
106 2017-02-21 09:25:30 0|fanquake|Don't you have to clone the repositories first?
107 2017-02-21 09:30:37 0|jonasschnelli|fanquake. I think the nat is not working correctly..
108 2017-02-21 09:46:03 0|jonasschnelli|Can I somehow start the LXC container manually and execute commands in the container? lxc-ls returns an empy list
109 2017-02-21 09:46:54 0|luke-jr|lxc-execute? :p
110 2017-02-21 09:47:23 0|jonasschnelli|luke-jr: lxc-execute: missing container name? And lxc-ls doesn't show any container...
111 2017-02-21 09:59:05 0|jonasschnelli|Found it out. LXC_ARCH=amd64 LXC_SUITE=trusty on-target -u root ping 8.8.8.8
112 2017-02-21 10:08:34 0|jonasschnelli|Ping to the inet from within the lxc container now worked after re-setting up the bridge with 10.0.2.2 (instead of 10.0.3.2)
113 2017-02-21 10:17:22 0|jonasschnelli|hm... dns resolving does not work in the LXC container. That's the issue.
114 2017-02-21 10:39:08 0|jonasschnelli|Ah. I think there is a dnsmasq conflict with the bitcoin dns-seeder
115 2017-02-21 11:22:54 0|wumpus|yes AFAIK it uses the host as DNS server
116 2017-02-21 11:28:55 0|wumpus|it should be possible to make the client use a different DNS server
117 2017-02-21 11:29:25 0|wumpus|though you could avoid this with https://github.com/bitcoin/bitcoin/blob/master/doc/gitian-building.md#building-fully-offline
118 2017-02-21 11:34:56 0|wumpus|in principle the guest doesn't need a network connection to anything but the host
119 2017-02-21 11:34:59 0|bitcoin-git|13bitcoin/06master 14171fc91 15Pavel JanÃÂk: Read/write mempool.dat as a binary....
120 2017-02-21 11:34:59 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/7639d38f14b1...7d46b3ea8d6c
121 2017-02-21 11:35:00 0|bitcoin-git|13bitcoin/06master 147d46b3e 15Wladimir J. van der Laan: Merge #9813: Read/write mempool.dat as a binary....
122 2017-02-21 11:35:22 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9813: Read/write mempool.dat as a binary. (06master...0620170220_mempool_binary) 02https://github.com/bitcoin/bitcoin/pull/9813
123 2017-02-21 11:36:07 0|bitcoin-git|13bitcoin/060.14 143972a8e 15Pavel JanÃÂk: Read/write mempool.dat as a binary....
124 2017-02-21 11:36:07 0|bitcoin-git|[13bitcoin] 15laanwj pushed 1 new commit to 060.14: 02https://github.com/bitcoin/bitcoin/commit/3972a8efb2f8fd727ca045dcf89104c9f8a2f846
125 2017-02-21 12:17:16 0|fanquake|#9464 has been labelled low-priority, but I'm wondering if this is actually something we want to fix for 0.14.0 ?
126 2017-02-21 12:17:17 0|gribble|https://github.com/bitcoin/bitcoin/issues/9464 | [GUI] "Number of blocks left" never updates when running with -reindex-chainstate ÷ Issue #9464 ÷ bitcoin/bitcoin ÷ GitHub
127 2017-02-21 12:17:48 0|fanquake|You get a similar problem was running with ââ¬âreindex, in that number of blocks is unknown, but both progress increase and estimated time left are both "calculating".
128 2017-02-21 12:18:08 0|fanquake|So you basically get no gui output expect for the progress bar, and when you hover over it.
129 2017-02-21 12:19:13 0|fanquake|Even the debug window doesn't update with progress.
130 2017-02-21 12:19:36 0|fanquake|Seems less than ideal, and user forced to reindex will have no idea of progress, or how long it's going to take.
131 2017-02-21 12:19:43 0|fanquake|*any
132 2017-02-21 12:20:22 0|wumpus|if it's another lock contention issue it's less than trivial to solve
133 2017-02-21 12:20:37 0|wumpus|so I would prefer not to hold up 0.14.0 for that, no
134 2017-02-21 12:21:20 0|fanquake|Something for 0.14.1 then? I'm sure the complaints of "reindexing with no progress output!" "How long is it going to take!" will roll in.
135 2017-02-21 12:21:24 0|wumpus|but if someone comes up with a solution it could be backported to 0.14
136 2017-02-21 12:21:32 0|wumpus|sure
137 2017-02-21 12:22:14 0|fanquake|I'll update the above issue with some more info, and create a 0.14.1 milestone.
138 2017-02-21 12:22:17 0|wumpus|it'd nice to not have the problem, but reindexing GUI output just isn't critical, in the way that say a crash is
139 2017-02-21 12:22:41 0|wumpus|luke-jr: you should be able to resize the columns?
140 2017-02-21 12:22:54 0|luke-jr|wumpus: tried 3 or 4 different ways, none seem to work :/
141 2017-02-21 12:23:09 0|wumpus|luke-jr: we resize tables in various parts of the source, don't know by heart how though
142 2017-02-21 12:23:24 0|luke-jr|yeah, I must be missing something stupid
143 2017-02-21 12:23:24 0|wumpus|the most tricky thing is not the resizing itself
144 2017-02-21 12:23:29 0|luke-jr|?
145 2017-02-21 12:23:31 0|wumpus|but *how large* to make the columns
146 2017-02-21 12:23:43 0|luke-jr|QFontMetrics::width?
147 2017-02-21 12:23:48 0|wumpus|font sizes can differ, high-dpi versus normal-dpi columns, and so on
148 2017-02-21 12:24:02 0|wumpus|yeah it's possible to get it right, just tricky
149 2017-02-21 13:20:52 0|bitcoin-git|13bitcoin/060.14 14ae1c4e2 15Chris Moore: Fix typo in release notes.
150 2017-02-21 13:20:52 0|bitcoin-git|[13bitcoin] 15laanwj pushed 1 new commit to 060.14: 02https://github.com/bitcoin/bitcoin/commit/ae1c4e24a6510b2ace819eccbb928a3cb0074daf
151 2017-02-21 13:22:49 0|jonasschnelli|wumpus: thanks. I'll try to do use your offline building solution.
152 2017-02-21 13:23:25 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9803: Fix typo in release notes. (060.14...06patch-5) 02https://github.com/bitcoin/bitcoin/pull/9803
153 2017-02-21 13:33:22 0|bitcoin-git|13bitcoin/06master 1440f11f8 15kirit93: Fix for issue #9775. Added check for open() returning a NULL pointer.
154 2017-02-21 13:33:22 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/7d46b3ea8d6c...8ad31f9aa311
155 2017-02-21 13:33:23 0|bitcoin-git|13bitcoin/06master 148ad31f9 15Wladimir J. van der Laan: Merge #9798: Fix Issue #9775 (Check returned value of fopen)...
156 2017-02-21 13:33:42 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9798: Fix Issue #9775 (Check returned value of fopen) (06master...06issue) 02https://github.com/bitcoin/bitcoin/pull/9798
157 2017-02-21 13:34:13 0|bitcoin-git|[13bitcoin] 15laanwj pushed 1 new commit to 060.14: 02https://github.com/bitcoin/bitcoin/commit/e22c0671c74bc4db70b3ba04d093cd110f9f22a7
158 2017-02-21 13:34:14 0|bitcoin-git|13bitcoin/060.14 14e22c067 15kirit93: Fix for issue #9775. Added check for open() returning a NULL pointer....
159 2017-02-21 13:43:19 0|bitcoin-git|[13bitcoin] 15jonasschnelli opened pull request #9817: Fix segfault crash when shutdown the GUI in disablewallet mode (06master...062017/02/sf_gui) 02https://github.com/bitcoin/bitcoin/pull/9817
160 2017-02-21 13:54:36 0|jonasschnelli|wumpus: re your offline build mode in gitian: how does it can get the depends/packages in the offline mode?
161 2017-02-21 13:55:32 0|jonasschnelli|I still see "Fetching ccache-3.3.3.tar.bz2 from https://bitcoincore.org/depends-sources" in the build.log
162 2017-02-21 13:56:30 0|wumpus|jonasschnelli: the idea is that the cache is prepopulated
163 2017-02-21 13:56:38 0|wumpus|jonasschnelli: so that it won't try to download the tarballs
164 2017-02-21 13:57:06 0|jonasschnelli|wumpus: cd into the git bitcoin repository/depends and download all soucres?
165 2017-02-21 13:58:05 0|jonasschnelli|I think there is a "make download" (in the depends Makefile)
166 2017-02-21 13:58:18 0|wumpus|indeed, there is "make download"
167 2017-02-21 13:59:32 0|wumpus|you could also copy the directory from another build host, if you already have gitian-built before
168 2017-02-21 13:59:56 0|wumpus|I don't think the offline building section is very useful in that regard, it only talks about apt
169 2017-02-21 14:00:28 0|wumpus|which is the least issue as the host is used as apt-cache so that part never needs DNS lookups on the guest
170 2017-02-21 14:13:46 0|bitcoin-git|13bitcoin/06master 14312c4f1 15Jonas Schnelli: Fix segfault crash when shutdown the GUI in disablewallet mode
171 2017-02-21 14:13:46 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/8ad31f9aa311...8528d6ac6d51
172 2017-02-21 14:13:47 0|bitcoin-git|13bitcoin/06master 148528d6a 15Wladimir J. van der Laan: Merge #9817: Fix segfault crash when shutdown the GUI in disablewallet mode...
173 2017-02-21 14:14:08 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9817: Fix segfault crash when shutdown the GUI in disablewallet mode (06master...062017/02/sf_gui) 02https://github.com/bitcoin/bitcoin/pull/9817
174 2017-02-21 14:16:03 0|bitcoin-git|13bitcoin/060.14 147d75a5a 15Jonas Schnelli: Fix segfault crash when shutdown the GUI in disablewallet mode...
175 2017-02-21 14:16:03 0|bitcoin-git|[13bitcoin] 15laanwj pushed 1 new commit to 060.14: 02https://github.com/bitcoin/bitcoin/commit/7d75a5a93c161aa4de22ac862702ba0241e8faa2
176 2017-02-21 16:08:59 0|bitcoin-git|13bitcoin/06master 14056aba2 15Wladimir J. van der Laan: Remove fallbacks for boost_filesystem < v3...
177 2017-02-21 16:08:59 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/8528d6ac6d51...5f0556d0326b
178 2017-02-21 16:09:00 0|bitcoin-git|13bitcoin/06master 145f0556d 15Wladimir J. van der Laan: Merge #9727: Remove fallbacks for boost_filesystem < v3...
179 2017-02-21 16:09:22 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9727: Remove fallbacks for boost_filesystem < v3 (06master...062017_02_boostfs_flailbacks) 02https://github.com/bitcoin/bitcoin/pull/9727
180 2017-02-21 16:11:10 0|bitcoin-git|[13bitcoin] 15ryanofsky opened pull request #9818: Save watch only key timestamps when reimporting keys (06master...06pr/multirewatch) 02https://github.com/bitcoin/bitcoin/pull/9818
181 2017-02-21 16:16:02 0|bitcoin-git|[13bitcoin] 15morcos opened pull request #9819: Remove harmless read of unusued priority estimates (06master...06removeExtraRead) 02https://github.com/bitcoin/bitcoin/pull/9819
182 2017-02-21 16:51:47 0|bitcoin-git|[13bitcoin] 15laanwj pushed 5 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/5f0556d0326b...61a640ea9741
183 2017-02-21 16:51:48 0|bitcoin-git|13bitcoin/06master 145406d51 15Bob McElrath: Rewrite to not use Polling wrapper for asyncio, link to python2.7 example
184 2017-02-21 16:51:48 0|bitcoin-git|13bitcoin/06master 145ea5368 15Bob McElrath: ZMQ example using python3 and asyncio
185 2017-02-21 16:51:49 0|bitcoin-git|13bitcoin/06master 144bb7d1b 15Bob McElrath: Add python version checks and 3.4 example
186 2017-02-21 16:51:58 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9485: ZMQ example using python3 and asyncio (06master...06python3zmq) 02https://github.com/bitcoin/bitcoin/pull/9485
187 2017-02-21 16:52:53 0|morcos|Just a heads up that pruning.py is broken in 0.14 and master, cause seems to be the 2 hour buffer added in #9778. I think ryanofsky is working on a fix.
188 2017-02-21 16:52:56 0|gribble|https://github.com/bitcoin/bitcoin/issues/9778 | Add two hour buffer to manual pruning by morcos ÷ Pull Request #9778 ÷ bitcoin/bitcoin ÷ GitHub
189 2017-02-21 18:02:27 0|bitcoin-git|[13bitcoin] 15ryanofsky opened pull request #9820: Fix pruning test broken by 2 hour manual prune window (06master...06pr/prunewind) 02https://github.com/bitcoin/bitcoin/pull/9820
190 2017-02-21 18:26:46 0|morcos|Question re fee estimation improvements. We have two rpc calls now. estimatefee and estimatesmartfee. I'd like to improve estimatesmartfee to be even "more smarter" and perhaps return more data to you about how it arrived at its estimates.
191 2017-02-21 18:27:19 0|morcos|And I'd like to turn estimatefee into more of a raw call that allows you to generate your own smart estimation through repeated calls to estimatefee with various parameters
192 2017-02-21 18:29:25 0|morcos|but that would imply re-enabling estimates for a target of 1 in the estimatefee call. does anyone think that's necessarily an issue. seems a bit odd to disable for a release and then reenable, but it becomes more of a raw utility, it makes sense to not constrain it
193 2017-02-21 18:30:04 0|morcos|does this make sense as a way forward for improving and extending fee estimation?
194 2017-02-21 18:30:56 0|morcos|or would it perhaps make sense to make a new rpc call for low level functionality that is even more raw and could give you direct acess to the saved data?
195 2017-02-21 18:32:29 0|ryanofsky|imo, disabling and reenabling is nicer than disabling and then adding a new rpc to do what the disabled thing did
196 2017-02-21 18:46:47 0|gmaxwell|funny, I was going to say the opposite!
197 2017-02-21 18:47:03 0|gmaxwell|the purpose of it is changing, so perhaps it should have a new name. "feeestimationdata"
198 2017-02-21 18:50:20 0|ryanofsky|yeah, it's a tradeoff. personally when i am a user of an api, i just want it to be as straightforward as possible what the various options in the api do, and what the behavioral differences are
199 2017-02-21 18:50:58 0|ryanofsky|i care a lot more about the actual behavior of the api, than whatever the intended "purpose" of the api was when it was developed
200 2017-02-21 18:54:58 0|morcos|after some discussion i'm leaning towards this: adding a new hidden rpc call estimaterawfee that allows raw access to the model data. It can be useful for debugging people with fee estimate problems or for super advanced users that want to implement their own smartness
201 2017-02-21 18:55:14 0|morcos|estimatefee itself will continue as is to hopefully eventually be deprecated
202 2017-02-21 18:56:05 0|morcos|and most people will use estimatesmartfee which may return more information to help people who want to read more than one number understand the tradeoffs.. but is more user friendly and doesn't take a whole lot of parameters, just how quickly you want the damn tx confirmed
203 2017-02-21 20:07:59 0|bitcoin-git|[13bitcoin] 15laanwj opened pull request #9821: util: Specific GetOSRandom for Linux/FreeBSD/OpenBSD (06master...062017_02_osrandom) 02https://github.com/bitcoin/bitcoin/pull/9821
204 2017-02-21 23:03:18 0|jtimon|post-0.14-fork review begging https://github.com/bitcoin/bitcoin/pull/8855
205 2017-02-21 23:03:22 0|jtimon|also #8994
206 2017-02-21 23:03:24 0|gribble|https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon ÷ Pull Request #8994 ÷ bitcoin/bitcoin ÷ GitHub
207 2017-02-21 23:06:24 0|bitcoin-git|13bitcoin/06master 1441e7219 15fanquake: [trivial] Add tests_config.ini to .gitignore
208 2017-02-21 23:06:24 0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/61a640ea9741...5628c70f2a44
209 2017-02-21 23:06:25 0|bitcoin-git|13bitcoin/06master 14851f6a3 15fanquake: [qa][doc] Correct rpc test options in readme
210 2017-02-21 23:06:26 0|bitcoin-git|13bitcoin/06master 145628c70 15MarcoFalke: Merge #9807: RPC doc fix-ups....
211 2017-02-21 23:06:47 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #9807: RPC doc fix-ups. (06master...06rpc-test-trivial-fixups) 02https://github.com/bitcoin/bitcoin/pull/9807