1 2017-02-22 06:24:30	0|bitcoin-git|[13bitcoin] 15benma opened pull request #9822: Refactor: Split part of AppInitMain() into a new function (06master...06appinitmain) 02https://github.com/bitcoin/bitcoin/pull/9822
  2 2017-02-22 07:09:40	0|wumpus|jonasschnelli, others: any idea about OS-specific random API on OSX? I heard about "SecRandom" (https://opensource.apple.com/source/Security/Security-55471/sec/Security/SecRandom.h), is that what should be used?
  3 2017-02-22 07:09:55	0|jonasschnelli|wumpus: Yes. That's simple
  4 2017-02-22 07:10:26	0|wumpus|will try to add it to #9821. So SecRandomRef can be left NULL?
  5 2017-02-22 07:10:28	0|gribble|https://github.com/bitcoin/bitcoin/issues/9821 | util: Specific GetOSRandom for Linux/FreeBSD/OpenBSD by laanwj · Pull Request #9821 · bitcoin/bitcoin · GitHub
  6 2017-02-22 07:11:08	0|jonasschnelli|Let me look at it...
  7 2017-02-22 07:11:17	0|jonasschnelli|I know there are other projects that already did this
  8 2017-02-22 07:13:04	0|sipa|that's a psuedo random number
  9 2017-02-22 07:13:13	0|sipa|i believe we're looking for a pseudo random number!
 10 2017-02-22 07:13:53	0|wumpus|kSecRandomDefault
 11 2017-02-22 07:14:33	0|sipa|defining a new name for NULL through an external symbol?
 12 2017-02-22 07:14:36	0|wumpus|very random, just happens to have all the bits turned off every time
 13 2017-02-22 07:14:47	0|sipa|that's pretty inefficient!
 14 2017-02-22 07:14:48	0|jonasschnelli|@abstract Return count random bytes in *bytes, allocated by the caller.
 15 2017-02-22 07:14:48	0|jonasschnelli|@function SecRandomCopyBytes
 16 2017-02-22 07:14:48	0|jonasschnelli|It is critical to check the return value for error
 17 2017-02-22 07:15:09	0|jonasschnelli|"Generates an array of cryptographically secure random bytes"
 18 2017-02-22 07:15:18	0|jonasschnelli|IMO SecRandomCopyBytes is CPRNG
 19 2017-02-22 07:15:33	0|wumpus|it's inefficient, though that is not really our worry here, this is the slow path
 20 2017-02-22 07:16:05	0|jonasschnelli|I think this is the way to go: "if (SecRandomCopyBytes(kSecRandomDefault, entropy.length, entropy.mutableBytes) != 0) return nil;"
 21 2017-02-22 07:16:10	0|wumpus|jonasschnelli: I guess MacOSX also supports the sysctl(ARND), inherited from NetBSD?
 22 2017-02-22 07:16:56	0|jonasschnelli|Yes. I think so. But not sure which makes more sense. Maybe add entropy from both?
 23 2017-02-22 07:17:52	0|jonasschnelli|I quickly check what apples recommends (that doesn't say it the solution we should go()
 24 2017-02-22 07:18:10	0|wumpus|I'd like to keep the GetOSRandom abtraction simple - just get random from the OS, whatever a good option is for that OS. Combining shouldn't make sense there
 25 2017-02-22 07:19:53	0|wumpus|an alternative way of going about this would be to check all randomness sources that are available , and somehow call all of them every time and combine them, but I'm not sure whether that's voodoo coding or sensible paranoia
 26 2017-02-22 07:20:30	0|wumpus|and note we already combine the output with randomness from other sources in an outer function
 27 2017-02-22 07:22:52	0|jonasschnelli|wumpus: has the idea with using fortuna for mixing all sorts of entropy died?
 28 2017-02-22 07:23:05	0|wumpus|using the MacOSX API doesn't mean anything scary like using objective c++ does it? all the examples I see have NSLog and NSMutableString etc in them
 29 2017-02-22 07:23:14	0|jonasschnelli|No. It's pure C
 30 2017-02-22 07:23:33	0|jonasschnelli|You need to link against the Security.frameowkr
 31 2017-02-22 07:23:38	0|jonasschnelli|T
 32 2017-02-22 07:23:44	0|jonasschnelli|We already link against other framework...
 33 2017-02-22 07:23:51	0|wumpus|jonasschnelli: I don't know, but I don't see a reason to combine multiple random streams coming from the OS and portrayed as cryptographic APIs
 34 2017-02-22 07:24:27	0|jonasschnelli|wumpus: I think the only reason could be if you are enough paranoid. :)
 35 2017-02-22 07:24:55	0|jonasschnelli|What speaks against using /dev/(u)random on OSX? Concurrency? It would be the simplest approach?
 36 2017-02-22 07:25:08	0|jonasschnelli|Apples states that /dev/random is CPRNG
 37 2017-02-22 07:25:12	0|wumpus|we already use /dev/urandom
 38 2017-02-22 07:25:31	0|jonasschnelli|wumpus: So SecRandomCopyBytes would give additional entrtopy?
 39 2017-02-22 07:25:40	0|wumpus|and that will remain the fallback if nothing else is availalbe, however in sandboxes it's not always available
 40 2017-02-22 07:26:07	0|wumpus|that was what prompted this, not 'we don't trust /dev/urandom'
 41 2017-02-22 07:27:52	0|wumpus|e.g. user created containers and chroots won't have the /dev/urandom device, some sandboxes (such as cluodabi/capsicum) don' t have file access at all (not that we can support those at the moment in bitcoin core). Direct system calls are the new way to get randomness from the OS.
 42 2017-02-22 07:29:07	0|jonasschnelli|Apples says "This function reads from /dev/random to obtain an array of cryptographically-secure random bytes" about SecRandomCopyBytes
 43 2017-02-22 07:29:19	0|wumpus|lol. okay, so it won't help :)
 44 2017-02-22 07:29:20	0|jonasschnelli|Not sure what internal fallback mechanisms are provided
 45 2017-02-22 07:29:30	0|jonasschnelli|I think that part is closed source
 46 2017-02-22 07:29:32	0|wumpus|thanks for looking that up, that's very useful information
 47 2017-02-22 07:30:07	0|jonasschnelli|Heres to code: https://opensource.apple.com/source/Security/Security-55179.11/sec/Security/SecFramework.c
 48 2017-02-22 07:30:57	0|jonasschnelli|And yes. It reads from /dev/random :)
 49 2017-02-22 07:31:18	0|jonasschnelli|If that's not available, it returns 0.
 50 2017-02-22 07:31:23	0|wumpus|yup. So going through all the trouble to link another framework and calling it isn't worth it
 51 2017-02-22 07:31:29	0|jonasschnelli|Yes.
 52 2017-02-22 07:33:03	0|cfields|er, i don't think we link in frameworks for bitcoind do we?
 53 2017-02-22 07:33:13	0|cfields|(seems the point's moot anyway now, though)
 54 2017-02-22 07:36:46	0|jonasschnelli|cfields: Good point. I guess only for the Qt parts.
 55 2017-02-22 07:36:58	0|wumpus|a different thing I noticed is that our code is opening and closing the /dev/urandom device every call to GetOSRand. Nothing wrong with that in itself, though reserving a fd for it would mean it's always available.
 56 2017-02-22 07:38:04	0|jonasschnelli|I wonder if it would make more sense to have the random
 57 2017-02-22 07:38:07	0|jonasschnelli|...
 58 2017-02-22 07:38:14	0|jonasschnelli|the randomness thins abstracted into a library...
 59 2017-02-22 07:38:29	0|jonasschnelli|I think there are lots of other application that also wants to deal with this without openssl
 60 2017-02-22 07:38:35	0|wumpus|well it's abstracted to random.o now :-)
 61 2017-02-22 07:39:01	0|wumpus|which is sort of a one-file randomness library. Idon't think it depends on any bitcoin specific things
 62 2017-02-22 07:39:03	0|jonasschnelli|Hah. indeed. What are the dependencies?
 63 2017-02-22 07:39:04	0|luke-jr|jonasschnelli: gnutls? :P
 64 2017-02-22 07:40:59	0|jonasschnelli|my testnet dns seeder will be down for a couple of hours (moving location)
 65 2017-02-22 07:45:06	0|wumpus|ok, thanks for letting us know
 66 2017-02-22 07:57:51	0|jonasschnelli|Does anyone know how I can avoid sudo password prompt in gbuild using LXC? I have added /usr/bin/lxc-start and execute to sudoers (nopassword)
 67 2017-02-22 07:59:12	0|Victorsueca|sudo -i ?
 68 2017-02-22 07:59:35	0|luke-jr|jonasschnelli: check syslog
 69 2017-02-22 07:59:36	0|wumpus|to have passwordless sudo you need to edit sudoers, you can either make all sudo use passwordless or specific commands
 70 2017-02-22 07:59:56	0|wumpus|I don't know the syntax by heart, though. Always have to look at up (and fail at leat three times at it)
 71 2017-02-22 07:59:58	0|jonasschnelli|But why does gbuild require root?
 72 2017-02-22 07:59:59	0|luke-jr|also, some distros have non-root LXC now
 73 2017-02-22 08:00:10	0|luke-jr|because LXC historically has required root
 74 2017-02-22 08:00:19	0|wumpus|jonasschnelli: spinning up a fully featured LXC container requires root
 75 2017-02-22 08:00:34	0|jonasschnelli|okay... I see.
 76 2017-02-22 08:00:48	0|wumpus|this is because the user creating the LXC container will be root in the container (without capabilities), which can be somewhat dangerous if there are security bugs in the kernel
 77 2017-02-22 08:01:02	0|luke-jr|(which there have been)
 78 2017-02-22 08:01:31	0|wumpus|and indeed as luke-jr says it is possible on more recent kernels to create a user LXC, but these have a few restrictions which I'm fairly sure we can't cope with right now
 79 2017-02-22 08:01:37	0|jonasschnelli|it's not just lxc-start and lxc-execute that requires root?
 80 2017-02-22 08:02:01	0|wumpus|it's just those no
 81 2017-02-22 08:02:08	0|wumpus|no->two
 82 2017-02-22 08:02:11	0|wumpus|maybe only lxc-execute
 83 2017-02-22 08:02:39	0|wumpus|not sure. I think there's an example of editing your sudoers file to allow this in gitian-building?
 84 2017-02-22 08:02:51	0|jonasschnelli|Yes. I have set those... still got the sudo promot
 85 2017-02-22 08:03:35	0|jonasschnelli|Ah! Wrong machine... damit
 86 2017-02-22 08:03:53	0|jonasschnelli|Can we have different shell background colors per host?!
 87 2017-02-22 08:04:02	0|wumpus|jonasschnelli: I have different prompt colors per host
 88 2017-02-22 08:04:13	0|wumpus|(even a script to randomly generate them :-)
 89 2017-02-22 08:04:19	0|jonasschnelli|wumpus: That is very clever... I need to do this as well...
 90 2017-02-22 08:05:54	0|wumpus|https://gist.github.com/laanwj/3c8c116fc763a149842a07070ca4d6cd
 91 2017-02-22 08:06:09	0|jonasschnelli|wumpus: thanks!
 92 2017-02-22 08:06:49	0|wumpus|setting terminal background is more involved; you can set it with the same escape sequences, however many programs will reset the background
 93 2017-02-22 08:07:40	0|jonasschnelli|I think the background switch should be done on the client side... but the prompt is good enought
 94 2017-02-22 08:08:07	0|wumpus|fairly sure tmux and some terminal emulators such as gnome=terminal have the option of having different profiles, so you could e.g. launch a different profile before ssh'ing. But yeah too much hassle
 95 2017-02-22 08:08:26	0|luke-jr|deterministic generation might be more useful
 96 2017-02-22 08:08:46	0|wumpus|KDE term had/has a nice feature where you could set an icon for the tab too
 97 2017-02-22 08:09:06	0|wumpus|luke-jr: but some combinations are ugly, so I determine them once when setting up the host then just write that into ~/.profile
 98 2017-02-22 08:09:34	0|luke-jr|too bad there's not a nice way to have it colour differently for local vs remote
 99 2017-02-22 08:11:30	0|wumpus|yes I started doing this consistently after shutting down the wrong host one time too many :-)
100 2017-02-22 08:12:13	0|luke-jr|I disabled the rm command for root, and alias'd it with -i for my normal user :p
101 2017-02-22 08:12:50	0|wumpus|that's a good idea. Some historical UNIXes had that as default IIRC
102 2017-02-22 08:13:11	0|wumpus|well the -i thing. Don't know about disabling rm completely
103 2017-02-22 08:29:28	0|Victorsueca|is there going to be a 0.14.0rc2 or is the rc1 definitive so far unless a critical issue appears in the wild?
104 2017-02-22 08:29:42	0|wumpus|there have already been some issues to warrant rc2
105 2017-02-22 08:30:12	0|wumpus|for example #9810
106 2017-02-22 08:30:14	0|gribble|https://github.com/bitcoin/bitcoin/issues/9810 | 0.14 not loading mempool.dat? · Issue #9810 · bitcoin/bitcoin · GitHub
107 2017-02-22 08:32:26	0|jonasschnelli|Gitian does by default avoid recompiling the dependencies on every build? Right?
108 2017-02-22 08:32:27	0|wumpus|and #9817
109 2017-02-22 08:32:29	0|gribble|https://github.com/bitcoin/bitcoin/issues/9817 | Fix segfault crash when shutdown the GUI in disablewallet mode by jonasschnelli · Pull Request #9817 · bitcoin/bitcoin · GitHub
110 2017-02-22 08:32:45	0|wumpus|jonasschnelli: yes, the dependency caching system should make sure of that
111 2017-02-22 08:33:10	0|Victorsueca|ahh how not, it had to be yet another thing windows copied and changed slightly to make it incompatible
112 2017-02-22 08:33:10	0|wumpus|it will recompile if either the dependency definitions changed, or the compilation environment changed
113 2017-02-22 08:33:17	0|Victorsueca|such CRLF
114 2017-02-22 08:33:27	0|jonasschnelli|I wonder why that crash (https://github.com/bitcoin/bitcoin/issues/9814) happens
115 2017-02-22 08:33:29	0|wumpus|Victorsueca: yep :/ the DOS legacy in this case
116 2017-02-22 08:34:30	0|wumpus|jonasschnelli: yes it's weird
117 2017-02-22 08:35:23	0|wumpus|jonasschnelli: it happens deep in the bowels of qt, in the X platform handling
118 2017-02-22 08:35:33	0|jonasschnelli|Yes. Looks like.
119 2017-02-22 08:36:14	0|jonasschnelli|I wonder if he would get the same crashed building 0.13.1 (I would say so).
120 2017-02-22 08:36:21	0|jonasschnelli|*crashes
121 2017-02-22 08:36:40	0|wumpus|jonasschnelli:  weird. it looks like both Thread 1 and Thread 2 are in libqxcb.so
122 2017-02-22 08:37:06	0|wumpus|is some auxiliary thread trying to do rendering / change the GUI?
123 2017-02-22 08:38:02	0|wumpus|ok on the other hand this is just "xcb_wait_for_event" so probably this is just the event loop
124 2017-02-22 08:38:18	0|wumpus|no, doesn't seem worrying
125 2017-02-22 08:40:39	0|wumpus|the traceback of Thread 1 is completely Qt and upstream libraries - none of our own code
126 2017-02-22 08:40:41	0|jonasschnelli|wumpus: I can't find any link between the crash(es) and our code in both stack traces
127 2017-02-22 08:40:58	0|jonasschnelli|I think we should recommend to try to compile against a different Qt version
128 2017-02-22 08:41:09	0|wumpus|thread 1 is the GUI thread so should be the only one that matters here
129 2017-02-22 08:41:44	0|wumpus|so this is either a race with cleaning up objects (deleteLater or such), or something in Qt/X11 itself. I suspect the second as it happens in the X library not in Qt.
130 2017-02-22 08:42:39	0|wumpus|cfields: didn't we have some scary xcb compatibility issues before?
131 2017-02-22 08:43:04	0|cfields|wumpus: heh, i was just clicking the above link with the same thought
132 2017-02-22 08:43:12	0|cfields|wumpus: only applies to static qt builds
133 2017-02-22 08:43:29	0|cfields|(it's qt's internal x stubs that cause that issue)
134 2017-02-22 08:44:52	0|cfields|it's possible that qt manages to crash there in some ugly way if there's no display plugin available, though
135 2017-02-22 08:46:23	0|cfields|(i haven't read the logs yet, if bitcoin-qt launches at all obviously that's not the culprit)
136 2017-02-22 08:48:07	0|cfields|wumpus: there was a touchscreen bug like that that rings a bell, though
137 2017-02-22 08:48:26	0|cfields|wacom, iirc
138 2017-02-22 08:53:07	0|cfields|headed to bed, nnite
139 2017-02-22 09:51:01	0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #9823: qa: Set correct path for binaries in rpc tests (06master...06Mf1702-qaPath) 02https://github.com/bitcoin/bitcoin/pull/9823
140 2017-02-22 10:18:43	0|jonasschnelli|wumpus: F.Y.I: "%sudo ALL=NOPASSWD: /usr/bin/lxc-execute" hasn't worked for me... I had to allow it per user "jonasschnelli    ALL=NOPASSWD:/usr/bin/lxc-execute".
141 2017-02-22 10:19:59	0|wumpus|strange. It does seem to be the right syntax
142 2017-02-22 10:20:16	0|jonasschnelli|The goup or per user line?
143 2017-02-22 10:20:33	0|wumpus|oh, you're not in the sudo group?
144 2017-02-22 10:20:53	0|wumpus|both
145 2017-02-22 10:20:58	0|jonasschnelli|Ah... yes.. that could be the issue.. :)
146 2017-02-22 10:22:15	0|jonasschnelli|Do I need to assign the LXC container specific amount of ram? Or does it share it with the host?
147 2017-02-22 10:22:25	0|jonasschnelli|I try now -j5
148 2017-02-22 10:23:05	0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #9824: qa: Check return code when stopping nodes (06master...06Mf1702-qaRet) 02https://github.com/bitcoin/bitcoin/pull/9824
149 2017-02-22 10:26:10	0|wumpus|jonasschnelli: LXC limits work in a different way, I've never set any at least
150 2017-02-22 10:27:35	0|MarcoFalke|wumpus: Can you add jnewbery_ to the list of members on github?
151 2017-02-22 10:28:06	0|MarcoFalke|Maybe also ryanofsky
152 2017-02-22 10:28:28	0|wumpus|yes, good idea
153 2017-02-22 10:31:26	0|wumpus|ok invited both to bitcoin and bitcoin-core
154 2017-02-22 10:35:44	0|wumpus|re: release notes, would it make sense to group the two qt debug console changes?
155 2017-02-22 10:37:07	0|wumpus|I mena "Nested RPC Commands in Debug Console"  and "Sensitive Data Is No Longer Stored In Debug Console History"
156 2017-02-22 10:37:17	0|wumpus|we also have "GUI Changes"
157 2017-02-22 10:38:18	0|Victorsueca|that's a nice thing, I used to CTRL+L after typing sensitive data
158 2017-02-22 10:42:39	0|wumpus|yes, it's certainly a nice thing, it's just spread out a bit haphazardly
159 2017-02-22 10:42:43	0|wumpus|in the release notes
160 2017-02-22 10:49:20	0|bitcoin-git|13bitcoin/06master 14a87d02a 15Marko Bencun: use EXIT_ codes instead of magic numbers...
161 2017-02-22 10:49:20	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/5628c70f2a44...92dd6c8dfdd6
162 2017-02-22 10:49:21	0|bitcoin-git|13bitcoin/06master 1492dd6c8 15Wladimir J. van der Laan: Merge #9815: Trivial: use EXIT_ codes instead of magic numbers...
163 2017-02-22 10:49:43	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9815: Trivial: use EXIT_ codes instead of magic numbers (06master...06exitcode) 02https://github.com/bitcoin/bitcoin/pull/9815
164 2017-02-22 11:14:59	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/92dd6c8dfdd6...5b583efaa721
165 2017-02-22 11:15:00	0|bitcoin-git|13bitcoin/06master 143b4dd2a 15Peter Todd: Add seed.btc.petertodd.org to mainnet DNS seeds
166 2017-02-22 11:15:00	0|bitcoin-git|13bitcoin/06master 145b583ef 15Wladimir J. van der Laan: Merge #9805: Add seed.btc.petertodd.org to mainnet DNS seeds...
167 2017-02-22 11:15:26	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9805: Add seed.btc.petertodd.org to mainnet DNS seeds (06master...062017-02-add-pt-mainnet-seed) 02https://github.com/bitcoin/bitcoin/pull/9805
168 2017-02-22 11:19:01	0|bitcoin-git|13bitcoin/06master 14eaea2bb 15gubatron: Removed redundant parameter from mempool.PrioritiseTransaction...
169 2017-02-22 11:19:01	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/5b583efaa721...a8c575103815
170 2017-02-22 11:19:02	0|bitcoin-git|13bitcoin/06master 14a8c5751 15Wladimir J. van der Laan: Merge #9801: Removed redundant parameter from mempool.PrioritiseTransaction...
171 2017-02-22 11:19:20	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9801: Removed redundant parameter from mempool.PrioritiseTransaction (06master...06refactor-mempool-prioritisetx) 02https://github.com/bitcoin/bitcoin/pull/9801
172 2017-02-22 11:43:32	0|bitcoin-git|13bitcoin/06master 14e2e2f4c 15Russell Yanofsky: Return errors from importmulti if complete rescans are not successful
173 2017-02-22 11:43:32	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/a8c575103815...ba7220b5e82f
174 2017-02-22 11:43:33	0|bitcoin-git|13bitcoin/06master 14ba7220b 15Wladimir J. van der Laan: Merge #9773: Return errors from importmulti if complete rescans are not successful...
175 2017-02-22 11:43:53	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9773: Return errors from importmulti if complete rescans are not successful (06master...06pr/multicheck) 02https://github.com/bitcoin/bitcoin/pull/9773
176 2017-02-22 11:59:31	0|bitcoin-git|13bitcoin/060.14 149072395 15Russell Yanofsky: Return errors from importmulti if complete rescans are not successful...
177 2017-02-22 11:59:31	0|bitcoin-git|[13bitcoin] 15laanwj pushed 1 new commit to 060.14: 02https://github.com/bitcoin/bitcoin/commit/9072395e5fddb1f2590138a179ab0868646a38a0
178 2017-02-22 12:02:34	0|bitcoin-git|13bitcoin/06master 14bc8fd12 15Alex Morcos: Remove harmless read of unusued priority estimates
179 2017-02-22 12:02:34	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/ba7220b5e82f...1efc99c4dc4d
180 2017-02-22 12:02:35	0|bitcoin-git|13bitcoin/06master 141efc99c 15Wladimir J. van der Laan: Merge #9819: Remove harmless read of unusued priority estimates...
181 2017-02-22 12:02:54	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9819: Remove harmless read of unusued priority estimates (06master...06removeExtraRead) 02https://github.com/bitcoin/bitcoin/pull/9819
182 2017-02-22 12:04:06	0|bitcoin-git|13bitcoin/06master 149949ebf 15John Newbery: [Trivial] Remove incorrect help message from gettxoutproof()
183 2017-02-22 12:04:06	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/1efc99c4dc4d...bed5b30a5622
184 2017-02-22 12:04:07	0|bitcoin-git|13bitcoin/06master 14bed5b30 15Wladimir J. van der Laan: Merge #9711: [Trivial] Remove incorrect help message from gettxoutproof()...
185 2017-02-22 12:04:23	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9711: [Trivial] Remove incorrect help message from gettxoutproof() (06master...06gettxoutproofhelp) 02https://github.com/bitcoin/bitcoin/pull/9711
186 2017-02-22 14:16:16	0|abhishekcs10_|Hello everyone :)
187 2017-02-22 14:16:53	0|abhishekcs10_|I am new to bitcoin and eager to learn about it.
188 2017-02-22 14:20:53	0|lopp|I recently pulled down the changes for Bitcoin Core 0.14 into my Statoshi fork, but one of the metrics is no longer populating and I'm hoping someone can explain if this is by design or if I screwed up
189 2017-02-22 14:21:24	0|lopp|the specific metric is the "block" inv message (MSG_BLOCK) that I'm populating here: https://github.com/jlopp/statoshi/blob/master/src/net_processing.cpp#L1571
190 2017-02-22 14:21:53	0|lopp|the "MSG_TX" inv type metric is populating fine (several lines earlier)
191 2017-02-22 14:22:04	0|abhishekcs10_|I am having problem understanding following parameters in bitcoin/src/chainparams.cpp
192 2017-02-22 14:22:22	0|abhishekcs10_|https://www.irccloud.com/pastebin/vVGQDoUJ
193 2017-02-22 14:49:34	0|abhishekcs10_|How can I edit interblock timing
194 2017-02-22 14:50:34	0|abhishekcs10_|Eg. Setting it to 1min retargetted every 5min
195 2017-02-22 15:14:40	0|sdaftuar|lopp: i'm guessing that is because your peers are using headers or cmpctblocks to announce new blocks, rather than inv's
196 2017-02-22 15:15:15	0|sdaftuar|lopp: if all your peers or 0.12 or later - i think? - then it's unlikely you'll get block invs, except in rare cases
197 2017-02-22 15:15:26	0|sdaftuar|maybe 0.11 or later
198 2017-02-22 15:15:45	0|jlopp|OK I figured it was likely due to protocol changes; my test node is behind a NAT that I don't port forward so it only has 8 peers
199 2017-02-22 15:16:23	0|jlopp|I'll double check the peer versions
200 2017-02-22 15:16:25	0|sdaftuar|oh yep that will do it then
201 2017-02-22 15:16:45	0|sdaftuar|we have preferential peering logic that will make it unlikely for you to connect outbound to older peers (in preparation for segwit)
202 2017-02-22 15:16:53	0|jlopp|ahhh
203 2017-02-22 15:17:14	0|sdaftuar|so most likely all your peers are 0.13.1 or later
204 2017-02-22 15:19:51	0|lopp|@sdaftuar confirmed; they're all 0.13.1+
205 2017-02-22 17:47:58	0|BlueMatt|Review as a Service, that is
206 2017-02-22 17:48:26	0|BlueMatt|in exchange for review of #9725
207 2017-02-22 17:48:33	0|gribble|https://github.com/bitcoin/bitcoin/issues/9725 | CValidationInterface Cleanups by TheBlueMatt · Pull Request #9725 · bitcoin/bitcoin · GitHub
208 2017-02-22 18:34:17	0|bitcoin-git|[13bitcoin] 15ryanofsky opened pull request #9827: Improve ScanForWalletTransactions return value (06master...06pr/scanret) 02https://github.com/bitcoin/bitcoin/pull/9827
209 2017-02-22 18:50:12	0|luke-jr|fun, left my CTableView bitcoin tx log overnight and no substantial memory usage growth. :D
210 2017-02-22 18:50:52	0|luke-jr|(I haven't implemented a limit to the log yet, but set it up to use only weak_ptrs)
211 2017-02-22 18:51:40	0|luke-jr|thinking of making it use maybe 500 lines of non-weak ptrs, and up to 10000 lines of weak_ptrs, or something
212 2017-02-22 19:17:21	0|bitcoin-git|[13bitcoin] 15ryanofsky opened pull request #9828: Avoid -Wshadow warnings in wallet_tests (06master...06pr/multishadow) 02https://github.com/bitcoin/bitcoin/pull/9828
213 2017-02-22 20:05:20	0|bitcoin-git|[13bitcoin] 15ryanofsky opened pull request #9829: Fix importmulti returning rescan errors for wrong keys (06master...06pr/multiinc) 02https://github.com/bitcoin/bitcoin/pull/9829
214 2017-02-22 21:35:25	0|jtimon|mhmm, in rpcwallet and rpcdump, ensure EnsureWalletIsAvailable( is called before showing the help. if the user selected help but the wallet is not available, the function will return NullUniValue instead of actually showing the help
215 2017-02-22 21:35:33	0|jtimon|is this the desired behaviour?
216 2017-02-22 21:35:55	0|jtimon|it seems not, and it's simple to fix
217 2017-02-22 21:42:02	0|warren|itcoind source.
218 2017-02-22 21:42:02	0|warren|I used linearize-data.py to generate in-order *.blk files.  I want to make the very deep historical blocks read-only at the filesystem level and hard-linked into the blocks/ directory to be used by multiple separate instances of bitcoind on the same machine.  It seems that bitcoind currently requires opening all *.blk files as writable so it is incompatible with this use case.  http://pastebin.com/DMUcTJuT  debug.log and relevant parts of b
219 2017-02-22 21:42:39	0|warren|I could make a temporary hack for myself, but is there any reason to not support this in the future?
220 2017-02-22 22:09:10	0|luke-jr|jtimon: it's the intended behaviour, presumably so -wallet=0 behaves the same as if it was compiled without
221 2017-02-22 22:09:56	0|luke-jr|(I don't mind if someone changes it though)
222 2017-02-22 22:18:04	0|warren|oh, *.dat files
223 2017-02-22 22:18:16	0|warren|blk*.dat
224 2017-02-22 22:44:02	0|jtimon|luke-jr: I see, the other 2 options would be to either throw the error even if fHelp is true, or show the help even if the wallet is not available
225 2017-02-22 22:45:27	0|luke-jr|wouldn't throwing an error break `help`?
226 2017-02-22 23:02:08	0|tussssss|Buy/Sell ( Bitcoin - Perfect money - webmoney - western union - moneygram - skrill - neteller ) & giftcards/prepaids ( llike amazon-ebay etc... ) Contact Skype : rodrige.amin ICQ : 690490649
227 2017-02-22 23:19:24	0|jtimon|luke-jr: help is already broken if the wallet is not available
228 2017-02-22 23:19:44	0|jtimon|why are all these functions declared as extern? https://github.com/bitcoin/bitcoin/blob/master/src/rpc/server.h#L188
229 2017-02-22 23:20:33	0|luke-jr|jtimon: is it? :/
230 2017-02-22 23:22:26	0|jtimon|luke-jr: if the wallet is not available, the function returns NullUniValue before having the opportunity to check     if (fHelp || params.size() < 2 || params.size() > 6) (well, of course the exact check depends on the function)
231 2017-02-22 23:23:21	0|luke-jr|jtimon: and `help` upon getting null just skips it, no?
232 2017-02-22 23:23:45	0|jtimon|my preferred behaviour would be to only check if the wallet is available after checking if it should show the help, and when doing so, if it's not available just throw the error as if fHelp was false
233 2017-02-22 23:24:57	0|jtimon|luke-jr: no, if fHelp=false, it returns false, EnsureWalletIsAvailable() returns false instead of throwing the error, thus the calling function returns NullUniValue before having the chance to check if the help should be shown
234 2017-02-22 23:25:35	0|jtimon|I guess I'll just write my prefferred fix and see what people think
235 2017-02-22 23:25:37	0|luke-jr|jtimon: …
236 2017-02-22 23:25:48	0|luke-jr|jtimon: foomethod() returns null to help(), which just skips foomethod
237 2017-02-22 23:26:24	0|jtimon|what help() function ?
238 2017-02-22 23:26:34	0|luke-jr|rpc/server.cpp
239 2017-02-22 23:26:41	0|luke-jr|std::string CRPCTable::help(const std::string& strCommand) const
240 2017-02-22 23:27:58	0|jtimon|oh, no I don't mean the general help, I mean the help for a specific rpc call (or when you have an invalid number of parameters for that call)
241 2017-02-22 23:28:16	0|jtimon|but let me read that method...
242 2017-02-22 23:30:18	0|jtimon|I see, yeah, that's the point of returning null instead of launching the error or giving it the opportunity to get the help first
243 2017-02-22 23:30:24	0|luke-jr|fHelp is only ever true via that method
244 2017-02-22 23:38:14	0|jtimon|mhmm, if I start the deamon with -wallet=0 and then with the client do sendtoaddress --help it shows the doc...
245 2017-02-22 23:39:20	0|jtimon|how can I make pwalletMain=NULL ?
246 2017-02-22 23:41:51	0|jtimon|btw, IIRC we talked before about moving the rpc wallet stuff from BTC to satoshis, but it breaks the interface. Are we decided to never do that?
247 2017-02-22 23:42:04	0|jtimon|would this be a good time?
248 2017-02-22 23:42:23	0|luke-jr|`sendtoaddress --help` is simply an invalid address
249 2017-02-22 23:43:35	0|jtimon|?? then why it shows the help instead of "Invalid Bitcoin address"
250 2017-02-22 23:43:55	0|ryanofsky|i know "sendfrom" RPC is deprecated, but is it also broken? I don't see 'fromaccount'
251 2017-02-22 23:44:02	0|ryanofsky|argument actually used for coin selection
252 2017-02-22 23:56:41	0|jeremyrubin|no that's not broken
253 2017-02-22 23:56:57	0|jeremyrubin|As far as I understand, accounts were meant to be internal accounting
254 2017-02-22 23:57:06	0|jeremyrubin|meaning negative balances could be reported
255 2017-02-22 23:57:49	0|jeremyrubin|So if I spend 2 from account Y with real balance 1, Y's new balance should be -1
256 2017-02-22 23:59:22	0|jeremyrubin|so account info has no bearing on coin selection
257 2017-02-22 23:59:40	0|sipa|that ^
258 2017-02-22 23:59:52	0|sipa|coins are independent from accounts
259 2017-02-22 23:59:58	0|sipa|accounts only have a balance