1 2017-03-21 00:31:09 0|BlueMatt|wtf github just lost my comments
2 2017-03-21 00:32:49 0|gmaxwell|they probably weren't that important anyways...
3 2017-03-21 00:33:25 0|BlueMatt|no, i hit "finish review" on the wrong pr (and apparently you cant delete that kind of comment?)
4 2017-03-21 00:34:24 0|gmaxwell|the whole review thing is kinda crap. I've been trying to use it but ... ugh.
5 2017-03-21 00:35:14 0|BlueMatt|i treat it as just a batch-comment system
6 2017-03-21 00:35:16 0|BlueMatt|as such its not bad
7 2017-03-21 00:35:40 0|BlueMatt|(lack of back-comments, or, really, cache comments that you can delete before posting, was always one of my bigger complaints)
8 2017-03-21 00:53:13 0|roasbeef|adiabat: might be a good idea to use testing/quick (https://golang.org/pkg/testing/quick/, basically a fuzztester/quickcheck) against the current ref implementations, then add as test vectors divergences that the fuzzer catches
9 2017-03-21 00:53:34 0|sipa|roasbeef: that sounds cool, indeed
10 2017-03-21 05:28:48 0|warren|2017-03-11 02:25:53 Loaded 169 blocks from external file in 2224m 2017-03-11 02:25:53 Reindexing block file blk00658.dat... when did -reindex change to no longer display progress in debug.log? I have no idea how far along it is.
11 2017-03-21 05:36:17 0|warren|oh, it shows the block progress quite a bit later now
12 2017-03-21 05:36:49 0|sipa|warren: reindexing is split into 2 phases
13 2017-03-21 05:37:29 0|sipa|one which is the real reindexing: go through the block files, and record them in the block index
14 2017-03-21 05:37:54 0|sipa|the second phase is activating the main chain, after the chain is fully known
15 2017-03-21 05:59:59 0|warren|sipa: why does it not do the first part in cases where there is no block index yet but blk*.dat files already exist?
16 2017-03-21 06:00:44 0|sipa|it only does the first part when you pass -reindex
17 2017-03-21 06:01:17 0|sipa|it does the second part if you pass -reindex-chainstate, or there are unconnected blocks in the index
18 2017-03-21 06:09:18 0|warren|Would there be any drawback to it doing the first part if blk*.dat already exists and there is no block index yet?
19 2017-03-21 06:09:41 0|sipa|probably not, but only if there is no index at all
20 2017-03-21 06:09:59 0|sipa|(i.e., not for cases where the index is out of date)
21 2017-03-21 06:10:28 0|warren|yeah, that's desirable for the use case where you want to place read-only blk*.dat files into the blocks/ dir
22 2017-03-21 07:53:24 0|jonasschnelli|BlueMatt: seems to be the right key: CA1A2908DCE2F13074C62CDE1EB776BB03C7922D
23 2017-03-21 07:53:46 0|jonasschnelli|But I had a gpg binary mix on my system due to a shitty app that had it's own gpg binary included and messed up PATH
24 2017-03-21 07:55:47 0|jonasschnelli|How do I get gpg list the used Digest (or just the full gpg signature) when using --show-signature?
25 2017-03-21 07:55:53 0|jonasschnelli|s/gpg/git
26 2017-03-21 08:43:47 0|sipa|jonasschnelli: not sure if you can
27 2017-03-21 08:43:59 0|sipa|jonasschnelli: though you can make it reject signatures made with certain hash types
28 2017-03-21 08:44:12 0|jonasschnelli|sipa: okay.. I'll check that.
29 2017-03-21 08:44:44 0|jonasschnelli|sipa: BTW. Is the assumption correct that DER encoded privkeys second byte is always 0x81 for compressed keys and 0x82 for uncompressed?
30 2017-03-21 08:46:56 0|sipa|DER encoded privkeys? why are you using those?
31 2017-03-21 08:48:08 0|jonasschnelli|sipa: there is a bug in our source code.
32 2017-03-21 08:48:14 0|jonasschnelli|I mean in key.cpp
33 2017-03-21 08:48:18 0|jonasschnelli|I'd like to fix it.
34 2017-03-21 08:52:28 0|sipa|what bug?
35 2017-03-21 08:53:25 0|jonasschnelli|sipa: https://github.com/bitcoin/bitcoin/pull/10043
36 2017-03-21 08:53:35 0|bitcoin-git|[13bitcoin] 15jonasschnelli opened pull request #10043: 2017/03/fix der comp (06master...062017/03/fix_der_comp) 02https://github.com/bitcoin/bitcoin/pull/10043
37 2017-03-21 10:47:32 0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/3192e5278abc...919aaf650855
38 2017-03-21 10:47:33 0|bitcoin-git|13bitcoin/06master 14b5bec4e 15Russell Yanofsky: Avoid QTimer::singleShot compile error with Qt 5.3.2...
39 2017-03-21 10:47:33 0|bitcoin-git|13bitcoin/06master 14d5046e7 15Russell Yanofsky: Avoid scoped_connection compile error with boost 1.55.0...
40 2017-03-21 10:47:34 0|bitcoin-git|13bitcoin/06master 14919aaf6 15Wladimir J. van der Laan: Merge #10039: Fix compile errors with Qt 5.3.2 and Boost 1.55.0...
41 2017-03-21 10:47:52 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10039: Fix compile errors with Qt 5.3.2 and Boost 1.55.0 (06master...06pr/jessie) 02https://github.com/bitcoin/bitcoin/pull/10039
42 2017-03-21 11:03:01 0|NicolasDorier|wumpus: since you merged https://github.com/bitcoin-core/leveldb/pull/16#event-1008318088 when will it be added to core ?
43 2017-03-21 11:04:26 0|wumpus|when the secp256k1 tree is updated
44 2017-03-21 11:04:56 0|wumpus|that will happen at least once before 0.15.0
45 2017-03-21 11:06:25 0|NicolasDorier|should I close https://github.com/bitcoin/bitcoin/pull/10000 ?
46 2017-03-21 11:08:31 0|wumpus|I don't know - I don't think there's anytning left to be done there, at least
47 2017-03-21 11:12:22 0|bitcoin-git|[13bitcoin] 15NicolasDorier closed pull request #10000: [DO NOT MERGE][LevelDB] Do no crash if filesystem can't fsync (06master...06fsync) 02https://github.com/bitcoin/bitcoin/pull/10000
48 2017-03-21 18:31:51 0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #10044: [WIP] Run functional tests in `make check` (06master...06reorg_makefiles) 02https://github.com/bitcoin/bitcoin/pull/10044
49 2017-03-21 18:55:10 0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #10045: [trivial] Fix typos in comments (06master...06typos-201703) 02https://github.com/bitcoin/bitcoin/pull/10045
50 2017-03-21 19:09:28 0|Chris_Stewart_5|Not sure if people have seen this, but apparently github is trying to protect against SHA1 collision attacks
51 2017-03-21 19:09:30 0|Chris_Stewart_5|https://github.com/blog/2338-sha-1-collision-detection-on-github-com
52 2017-03-21 19:10:43 0|BlueMatt|sdaftuar: was reading the paper behind that...it didnt seem to indicate that it was a foolproof solution, but more like "well, these are the test vectors we know about today....might not be it, though"
53 2017-03-21 19:53:34 0|bitcoin-git|[13bitcoin] 15pi opened pull request #10046: LevelDB: Fix Win32Env::GetFileSize(), Win32SequentialFile::_Init() and Win32RandomAccessFile::_Init() (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/10046
54 2017-03-21 23:21:00 0|bitcoin-git|[13bitcoin] 15pi closed pull request #10046: LevelDB: Fix Win32Env::GetFileSize(), Win32SequentialFile::_Init() and Win32RandomAccessFile::_Init() (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/10046