1 2017-03-23 00:44:22	0|bitcoin-git|[13bitcoin] 15tjps opened pull request #10059: [trivial] Removed one Boost usage and headers in util.cpp (06master...06tjps_boost) 02https://github.com/bitcoin/bitcoin/pull/10059
  2 2017-03-23 00:53:24	0|bitcoin-git|[13bitcoin] 15jnewbery closed pull request #10055: [test] [POC] Stop and start bitcoind nodes asynchronously in functional tests (06master...06stopstartasync) 02https://github.com/bitcoin/bitcoin/pull/10055
  3 2017-03-23 01:10:26	0|bitcoin-git|[13bitcoin] 15achow101 opened pull request #10060: [RPC] Ensure an item exists on the rpcconsole stack before adding (06master...06fix-rpcconsole-empty-stack) 02https://github.com/bitcoin/bitcoin/pull/10060
  4 2017-03-23 05:17:25	0|bitcoin-git|[13bitcoin] 15tjps opened pull request #10061: [net] Added SetSocketNoDelay() utility function (06master...06tjps_nodelay) 02https://github.com/bitcoin/bitcoin/pull/10061
  5 2017-03-23 06:26:19	0|bitcoin-git|[13bitcoin] 15kallewoof opened pull request #10062: [net] Clean up the net.h file. (06master...0620170322-cleanup-net) 02https://github.com/bitcoin/bitcoin/pull/10062
  6 2017-03-23 07:18:26	0|bitcoin-git|13bitcoin/06master 1497b8213 15practicalswift: Fix parameter naming inconsistencies between .h and .cpp files...
  7 2017-03-23 07:18:26	0|bitcoin-git|[13bitcoin] 15jonasschnelli pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/02d64bd929c9...86f7d5b69bb7
  8 2017-03-23 07:18:27	0|bitcoin-git|13bitcoin/06master 1486f7d5b 15Jonas Schnelli: Merge #10029: Fix parameter naming inconsistencies between .h and .cpp files...
  9 2017-03-23 07:18:47	0|bitcoin-git|[13bitcoin] 15jonasschnelli closed pull request #10029: Fix parameter naming inconsistencies between .h and .cpp files (06master...06fix-header-parameter-naming-inconsistencies) 02https://github.com/bitcoin/bitcoin/pull/10029
 10 2017-03-23 07:19:12	0|bitcoin-git|13bitcoin/06master 14c4a6929 15Matt Corallo: Clarify assumptions made about when BlockCheck is called
 11 2017-03-23 07:19:12	0|bitcoin-git|[13bitcoin] 15jonasschnelli pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/86f7d5b69bb7...7b585cf70ec5
 12 2017-03-23 07:19:13	0|bitcoin-git|13bitcoin/06master 147b585cf 15Jonas Schnelli: Merge #9558: Clarify assumptions made about when BlockCheck is called...
 13 2017-03-23 07:19:23	0|bitcoin-git|[13bitcoin] 15jonasschnelli closed pull request #9558: Clarify assumptions made about when BlockCheck is called (06master...062017-01-blockcheckeddocs) 02https://github.com/bitcoin/bitcoin/pull/9558
 14 2017-03-23 07:27:44	0|bitcoin-git|13bitcoin/06master 146d8fe35 15Andrew Chow: 'help' rpc commands autocomplete...
 15 2017-03-23 07:27:44	0|bitcoin-git|[13bitcoin] 15jonasschnelli pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/7b585cf70ec5...3568b30ca31d
 16 2017-03-23 07:27:45	0|bitcoin-git|13bitcoin/06master 143568b30 15Jonas Schnelli: Merge #9500: [Qt][RPC] Autocomplete commands for 'help' command in debug console...
 17 2017-03-23 07:28:12	0|bitcoin-git|[13bitcoin] 15jonasschnelli closed pull request #9500: [Qt][RPC] Autocomplete commands for 'help' command in debug console (06master...06help-rpc-autocomplete) 02https://github.com/bitcoin/bitcoin/pull/9500
 18 2017-03-23 10:39:39	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/3568b30ca31d...dfef6b6af080
 19 2017-03-23 10:39:40	0|bitcoin-git|13bitcoin/06master 143897459 15practicalswift: [tests] Remove unused variables
 20 2017-03-23 10:39:40	0|bitcoin-git|13bitcoin/06master 1472163d4 15practicalswift: [tests] Remove unused and duplicate imports
 21 2017-03-23 10:39:41	0|bitcoin-git|13bitcoin/06master 14dfef6b6 15MarcoFalke: Merge #10047: [tests] Remove unused variables and imports...
 22 2017-03-23 10:40:23	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #10047: [tests] Remove unused variables and imports (06master...06remove-unused-python-imports) 02https://github.com/bitcoin/bitcoin/pull/10047
 23 2017-03-23 11:23:28	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 6 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/dfef6b6af080...a230b0588788
 24 2017-03-23 11:23:29	0|bitcoin-git|13bitcoin/06master 1494b528b 15Russell Yanofsky: [qa] Remove bumpfee.py get_change_address hack
 25 2017-03-23 11:23:29	0|bitcoin-git|13bitcoin/06master 14e6b2963 15Russell Yanofsky: [qa] Get rid of nondeterminism in bumpfee.py...
 26 2017-03-23 11:23:30	0|bitcoin-git|13bitcoin/06master 141dfd64f 15Russell Yanofsky: [qa] Make bumpfee.py test function order consistent...
 27 2017-03-23 11:23:43	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #9701: Make bumpfee tests less fragile (06master...06pr/bumpfee-fragile) 02https://github.com/bitcoin/bitcoin/pull/9701
 28 2017-03-23 11:50:29	0|luke-jr|woo, sizefp code builds finally
 29 2017-03-23 11:51:01	0|luke-jr|although it's still incomplete.. need a good way to detect the "no full size proofs on right sides of duplicate merkle link hashes"
 30 2017-03-23 11:51:36	0|luke-jr|but I'd better get to bed so I can be up for the meeting :x
 31 2017-03-23 13:31:25	0|btcdrak|wow it's Thursday again already... how time flies
 32 2017-03-23 13:48:43	0|bitcoin-git|[13bitcoin] 15flack opened pull request #10063: add missing spaces so that markdown recognizes headline (06master...06patch-1) 02https://github.com/bitcoin/bitcoin/pull/10063
 33 2017-03-23 18:34:35	0|gmaxwell|meeting in 20 minutes.
 34 2017-03-23 18:47:10	0|petertodd|sipa: IIRC there's something not unlike that in rust with deref coercion
 35 2017-03-23 18:50:05	0|gmaxwell|luke-jr: does your prover optimize that it's cheaper to provide merkle membership proofs when you show transactions with common parents in the tree?  e.g.  Say that the sizes are   1000 900 100 910   you get more size-proof per proof-size if you select 1000,900  instead of 1000,910.
 36 2017-03-23 18:51:51	0|luke-jr|gmaxwell: the current code doesn't
 37 2017-03-23 18:55:52	0|gmaxwell|luke-jr: I would eliminate transactions by first assuming all are in and then asking "can I leave out this leaf?" for each interior node and child, then remove the one that eliminates the most proof size per transaction size proven.
 38 2017-03-23 18:56:47	0|gmaxwell|(proof size including the membership proofs, and the extra data, so it'll tend to remove txn that have a lot of extradata)
 39 2017-03-23 18:57:38	0|gmaxwell|luke-jr: this is another reason for a softfork increasing the minimum transaction size in the future.  Your proofs should also be able to prove that there is a transaction smaller than a minimum.
 40 2017-03-23 18:58:04	0|gmaxwell|would be interesting to profile your proofs on the existing chain with a fake block limit of 750k and also see how the proof size changes as a function of the minimum transaction size.
 41 2017-03-23 19:00:03	0|sipa|PING
 42 2017-03-23 19:00:14	0|gmaxwell|#bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier
 43 2017-03-23 19:00:17	0|jonasschnelli|hi
 44 2017-03-23 19:00:17	0|kanzure|hi.
 45 2017-03-23 19:00:18	0|petertodd|hi
 46 2017-03-23 19:00:20	0|lightningbot|Meeting started Thu Mar 23 19:00:20 2017 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
 47 2017-03-23 19:00:20	0|lightningbot|Useful Commands: #action #agreed #help #info #idea #link #topic.
 48 2017-03-23 19:00:20	0|wumpus|#startmeeting
 49 2017-03-23 19:00:21	0|achow101|hi
 50 2017-03-23 19:00:21	0|sipa|hi
 51 2017-03-23 19:00:27	0|gmaxwell|Welcome to meeting.
 52 2017-03-23 19:00:34	0|cfields|hi
 53 2017-03-23 19:00:50	0|btcdrak|greetings!
 54 2017-03-23 19:00:57	0|wumpus|proposed topics?
 55 2017-03-23 19:01:14	0|btcdrak|holiday at the beach?
 56 2017-03-23 19:01:28	0|petertodd|btcdrak: that's what the financial crypto conference is for
 57 2017-03-23 19:01:29	0|gmaxwell|wumpus: The segwit address proposal on the list.
 58 2017-03-23 19:01:35	0|petertodd|gmaxwell: +1
 59 2017-03-23 19:01:37	0|wumpus|sounds good to me
 60 2017-03-23 19:01:39	0|btcdrak|+1
 61 2017-03-23 19:01:44	0|wumpus|#topic  segwit address proposal
 62 2017-03-23 19:01:54	0|jonasschnelli|proposed topic: DER encoded priv keys in wallet
 63 2017-03-23 19:02:06	0|jonasschnelli|ack #sw addr format
 64 2017-03-23 19:02:13	0|sipa|general opinions/questions about the segwit addr format?
 65 2017-03-23 19:02:26	0|gmaxwell|We might have made a strategic error in getting 1:1 comments from too many people, causing a darth of comments on the list.  Comments on the list would be good even if they're just "I reviewed this before, LGTM"
 66 2017-03-23 19:02:26	0|jonasschnelli|Andreas S. concern about QRCode?
 67 2017-03-23 19:02:44	0|kanzure|who has reviewed bech32 by now?
 68 2017-03-23 19:02:45	0|btcdrak|ML post is here https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2017-March/013749.html
 69 2017-03-23 19:03:04	0|sipa|jonasschnelli: petertodd responded, by i can give some extra commemtd
 70 2017-03-23 19:03:05	0|petertodd|gmaxwell: along thsoe lines, I think making some of those 1:1 comments public might be helpful for new devs interested in learning how these processes work
 71 2017-03-23 19:03:06	0|sipa|*commemts
 72 2017-03-23 19:03:11	0|jonasschnelli|IMO QRCode have redundant parts while - as far as I understand bech32 – has also error correction.. seems a bit unefficient. Though QRCode are another layer I guess.
 73 2017-03-23 19:03:47	0|jonasschnelli|(need to read petertodd's response; wasn't aware(
 74 2017-03-23 19:03:56	0|gmaxwell|jonasschnelli: He suggested it use more characters but using anything non-alphanum makes it so double click copy doesn't work in browsers,  also being a non power-of-prime base makes strong error detection infesable, and at best could reduce the size by a couple percent.
 75 2017-03-23 19:04:10	0|gmaxwell|These points are all addressed in the document, I believe.
 76 2017-03-23 19:04:29	0|kanzure|tromp's MiXcAsE proposal was a joke right?
 77 2017-03-23 19:04:43	0|sipa|gmaxwell: base 43 is actually totally doable as it is a prime
 78 2017-03-23 19:04:46	0|petertodd|gmaxwell: there's a few things that the document doesn't mention as clearly as it could, like how non-alphanum poses barriers for non-english-speaking users
 79 2017-03-23 19:04:50	0|wumpus|jonasschnelli: I don't think the qr error detection/correction is strong enough for somthing as critical to get right as an address
 80 2017-03-23 19:04:51	0|gmaxwell|(in fact in an earlier revision we used - as a seperator but dropped it for click copy compatibility)
 81 2017-03-23 19:04:52	0|sipa|gmaxwell: but it requires bignum code to convert
 82 2017-03-23 19:05:04	0|jonasschnelli|wumpus: Yes. Agree.
 83 2017-03-23 19:05:25	0|sipa|petertodd: feel free to suggest better language :)
 84 2017-03-23 19:05:30	0|gmaxwell|wumpus: it would probably be fine if we only ever used QR codes.. but obviously that isn't possible.
 85 2017-03-23 19:06:03	0|petertodd|sipa: will do - also thanks for having such a great list of rationals already! really helpful to understand why something was chosen and what the tradeoffs are
 86 2017-03-23 19:06:09	0|gmaxwell|petertodd: yes, though really being num only be best for international support but the result is significantly bigger and slower to deal with. :(  I tried that out at one point.
 87 2017-03-23 19:06:14	0|wumpus|gmaxwell: a more compact format could be used with qr codes, in any case, if that's desirable. That doesn't affect this standard.
 88 2017-03-23 19:06:21	0|luke-jr|QR codes could hypothetically encode it in binary, but meh
 89 2017-03-23 19:06:43	0|kanzure|rationale section was good, although i think it would be worthwhile to describe the 'exhaustive search'
 90 2017-03-23 19:06:47	0|kanzure|in public
 91 2017-03-23 19:06:50	0|wumpus|luke-jr: right.
 92 2017-03-23 19:07:00	0|gmaxwell|luke-jr: if we had a binary QR only format I assume it would intentionally begin with something like a null byte to make sure it doesn't get mangled by text channels.
 93 2017-03-23 19:07:14	0|petertodd|gmaxwell: yeah, we're fortunate that lots of non-english-speakers still known the alphabet; even english speakers often don't know the names of punctuation symbols, and those names are also not entirely canonical
 94 2017-03-23 19:07:58	0|jonasschnelli|It's probably not worth to design an additional binary addr standard for QrCodes. Maybe they are only temporary? Gone in 3-4 yrs?
 95 2017-03-23 19:08:04	0|gmaxwell|There were a lot of other rational things we trimmed from the document. One of pieter's concerns was that the length of the document would make it seem complicated (though the proposal is pretty simple.); feedback on reddit seemed to somewhat validate that.
 96 2017-03-23 19:08:13	0|petertodd|luke-jr: so by matchin QR code's special-case character set support, we end up with an encoding that at the low level is basically binary anyway
 97 2017-03-23 19:08:36	0|gmaxwell|jonasschnelli: I think that it's probably not worth it for that, but industry feedback would be nice.
 98 2017-03-23 19:08:51	0|gmaxwell|petertodd: thats a point, though the unfortuate thing is that it's exposed to mangling.
 99 2017-03-23 19:09:05	0|sipa|the alphanuneric mode is pretty efficient; only 10% extra compared to binary
100 2017-03-23 19:09:13	0|sipa|it uses 5.5 bits per character
101 2017-03-23 19:09:17	0|gmaxwell|e.g. QR decoder -> something that munges up the strings -> software -> coins in sppppaccccceeee.
102 2017-03-23 19:09:25	0|sipa|so 5.5 bits per 5 bits of data is pretty goof
103 2017-03-23 19:09:27	0|sipa|good
104 2017-03-23 19:09:35	0|petertodd|jonasschnelli: I think the day Qr codes aren't heavily used will be the day bech32 is irrelevant anyway because people are all paying each other by very different means :)
105 2017-03-23 19:09:50	0|jonasschnelli|probably... :)
106 2017-03-23 19:10:05	0|sipa|while base58 uses 8 bits per 5.86 bits of data
107 2017-03-23 19:10:16	0|gmaxwell|sipas point is more important, only a 10%-ish overhead in this format vs some binary QR code.
108 2017-03-23 19:10:50	0|sipa|if you also drop the checksum, we get much larger savings of course
109 2017-03-23 19:11:13	0|sipa|in practice you'd get a 25% reduction for p2wpkh
110 2017-03-23 19:11:24	0|jonasschnelli|side note: could the Bech32 encoding also be used for private keys (== 32bit seeds)?
111 2017-03-23 19:11:29	0|gmaxwell|true. but ugh. the some text handling path replaces a character.
112 2017-03-23 19:11:31	0|sipa|jonasschnelli: good question!
113 2017-03-23 19:11:37	0|wumpus|indeed, for base58 addresses there also never has been a binary standard for qr codes
114 2017-03-23 19:11:45	0|sipa|jonasschnelli: we've been thinking about a stronger checksum for private keys
115 2017-03-23 19:11:46	0|Anduck|QR codes iirc can work even if 30% of the code misread
116 2017-03-23 19:11:46	0|wumpus|which would have saved a lot more
117 2017-03-23 19:12:03	0|petertodd|jonasschnelli: yes - in fact I'm planning on using it for non-bitcoin applications too
118 2017-03-23 19:12:06	0|sipa|possibly 12 checksum characters (which is the maximum doable with 64 bit arithmetic)
119 2017-03-23 19:12:25	0|jonasschnelli|Yes. An alternative for bip39?
120 2017-03-23 19:12:43	0|gmaxwell|For private keys additional error _correction_ is interesting, and additional overhead is not very consequential.
121 2017-03-23 19:13:00	0|sipa|bech32 can only correct 2 errors, but detect 4
122 2017-03-23 19:13:22	0|sipa|for addresses you really only care about detection
123 2017-03-23 19:13:30	0|sipa|but for private keys you want correction
124 2017-03-23 19:13:37	0|wumpus|yes, quite a different use case
125 2017-03-23 19:13:45	0|gmaxwell|So we've been working on that some in the background. So it would be a different spec but just very similar. (e.g. similar kind of 5 lines of code) for the 12 digit checksum or what not.
126 2017-03-23 19:13:59	0|sipa|with a 12 character checksum, correcting 3 errors is trivial
127 2017-03-23 19:14:07	0|jonasschnelli|current WIF can correct 0.
128 2017-03-23 19:14:16	0|sipa|but perhaps we can find one that can correct 4
129 2017-03-23 19:14:20	0|gmaxwell|kanzure: we left out a lot of technical manutia about the construction which is interesting but not really relevant to the spec.
130 2017-03-23 19:15:05	0|wumpus|makes sense to keep the spec focused and minimal, that way people will more likely read it :) you could link to an additional description, or include it as appendix or such
131 2017-03-23 19:15:43	0|sipa|earlier version explained finite field arithmetic and generator polynomials :)
132 2017-03-23 19:15:45	0|petertodd|wumpus: maybe good to make it a spec + design document? put rational/etc. in the latter. IIRC SHA3 had a document like that, among others.
133 2017-03-23 19:15:59	0|wumpus|petertodd: yes indeed
134 2017-03-23 19:16:06	0|jonasschnelli|The question about the level of complexity: We should't care. Pieter's stuff tend to be complicated. But only because its great and though through well. Awesome work IMO!
135 2017-03-23 19:16:06	0|jtimon|I haven't fully reviewed it, but I've had a fast read on several versions of the doc and asked questions to sipa
136 2017-03-23 19:16:42	0|gmaxwell|Finding a 12-digit code that corrects 4 may take more computing power than we have with just the a hundred cores here... though sipa has done a lot to take that search from completely intractable to plausable. :)   I think this work is a lot lower priority though other things we could be working on (like utxo database refactors and tx compaction) ....
137 2017-03-23 19:17:27	0|sipa|jonasschnelli: i think the result is actually surprisingly simple
138 2017-03-23 19:17:51	0|sipa|(but i'm probably biased)
139 2017-03-23 19:17:53	0|gmaxwell|In any case, review and comment please!
140 2017-03-23 19:17:59	0|luke-jr|I think it's more important to *detect* errors, than to correct them
141 2017-03-23 19:18:08	0|sipa|luke-jr: for addresses, absolutely
142 2017-03-23 19:18:19	0|luke-jr|4 seems a bit low in that regard
143 2017-03-23 19:18:52	0|jonasschnelli|sipa: I think deeply understanding the specs takes a coupe of hours... and it's different to the current base58check. This may frighten off people... but that shouldn't be something that should affect the process of selecting the *next* addr encoding format IMO
144 2017-03-23 19:18:53	0|gmaxwell|luke-jr: for private keys you can generate the resulting wallet and check against the blockchain.. so correcting can be very useful.
145 2017-03-23 19:18:54	0|petertodd|luke-jr: what do you mean by "4" in the above?
146 2017-03-23 19:19:12	0|luke-jr|[19:12:59] <sipa> bech32 can only correct 2 errors, but detect 4
147 2017-03-23 19:19:36	0|gmaxwell|Well it is _guarenteed_ to detect 4 errors, more than 4 you have a 1:2^30 chance of detecting.
148 2017-03-23 19:19:56	0|sipa|luke-jr: well it has a 99.9999999068% chance to detect more errors
149 2017-03-23 19:19:59	0|luke-jr|if I carefully construct gibberish, I'd expect it to be rejected
150 2017-03-23 19:20:14	0|luke-jr|sipa: ah, okay
151 2017-03-23 19:20:39	0|petertodd|luke-jr: for this application, the threat is random mistakes, not malice - in the malice case someone could just replace the address anyway
152 2017-03-23 19:20:51	0|gmaxwell|This graph shows the probablity of an error going undetected (y) as a function of how likely the user is to make mistakes (x):
153 2017-03-23 19:20:54	0|gmaxwell|https://people.xiph.org/~greg/temp/bch-eff3.png
154 2017-03-23 19:21:08	0|sipa|jonasschnelli: https://github.com/sipa/bech32/blob/master/ref/python/segwit_addr.py <- full encoder/decoder implementation
155 2017-03-23 19:21:13	0|cfields|great work indeed. From what I remember from our discussions before, the work to derive the function was complex, but afterwards, implementing it is simple. Seems best-case to me :). Will review now that it's final.
156 2017-03-23 19:21:42	0|jonasschnelli|sipa: 121 lines... yes. thats indeed very simple.
157 2017-03-23 19:21:51	0|gmaxwell|As you can see, if the user's error rate is below 3.53 errors per address entered, this code has better protection than a 32bit hash (like base58 check uses).  And because of case modulation, users are MUCH less likely to make mistakes with this format.
158 2017-03-23 19:22:39	0|gmaxwell|If the user is unlikely to make errors, then the effective protection of this scheme tends to infinity.
159 2017-03-23 19:23:22	0|gmaxwell|e.g. 0.1% chance of error per character and the probablity that an errored string goes undetected is 1:2^60.
160 2017-03-23 19:23:41	0|sipa|enough on this topic, i guess
161 2017-03-23 19:24:10	0|wumpus|other topics?
162 2017-03-23 19:24:19	0|gmaxwell|jonasschnelli suggested the der wallet thing.
163 2017-03-23 19:24:30	0|jonasschnelli|Yes. We still keep all priv keys DER encoded in BDB
164 2017-03-23 19:24:48	0|jonasschnelli|I think we should bundle the next wallet db update with remvoing DER
165 2017-03-23 19:24:50	0|gmaxwell|The compressed flag has no effect on our operation. We should always set it IMO... make the wallet sightly smaller. Its dumb that the data is stored at all.. it's not used.  But since it's there, better to make it small.
166 2017-03-23 19:25:05	0|gmaxwell|if we make the format incompatible, sure.
167 2017-03-23 19:25:29	0|jonasschnelli|Reading DER (old versions) must be supported. But new wallets should store in plain.
168 2017-03-23 19:25:33	0|gmaxwell|Why are we even storing seralized private keys when BIP32 is in use?
169 2017-03-23 19:25:33	0|wumpus|#topic DER privkeys in wallet
170 2017-03-23 19:25:42	0|jonasschnelli|Yes.
171 2017-03-23 19:25:45	0|jonasschnelli|Importprivkey
172 2017-03-23 19:25:48	0|jonasschnelli|and old wallets
173 2017-03-23 19:26:00	0|jonasschnelli|But I think HD wallets should only have a single privkey (the HD seed)
174 2017-03-23 19:26:03	0|gmaxwell|okay, for that, sure. But I agree, fine to not use DER private keys for that.
175 2017-03-23 19:26:23	0|jonasschnelli|Also the seed key is also DER right now. :/
176 2017-03-23 19:26:27	0|gmaxwell|but otherwise there shouldn't be seralized private keys. Pubkeys yes. :)
177 2017-03-23 19:26:37	0|gmaxwell|wut
178 2017-03-23 19:26:53	0|jonasschnelli|Yes. Ideally it should be... and I think we are working in this direction...
179 2017-03-23 19:26:56	0|gmaxwell|okay well, whatever, there is only one there. We could encode it as cat pictures for all I care.
180 2017-03-23 19:26:56	0|phantomcircuit|yeah it's saved using the same format as other private keys
181 2017-03-23 19:26:56	0|wumpus|didn't we have an issue related to this?
182 2017-03-23 19:27:27	0|gmaxwell|wumpus: there is an issue open over the compressed flag, though its inconsequential.
183 2017-03-23 19:27:32	0|jonasschnelli|wumpus: Yes. https://github.com/bitcoin/bitcoin/issues/10041
184 2017-03-23 19:27:39	0|wumpus|gmaxwell: ok
185 2017-03-23 19:27:44	0|jonasschnelli|and a fix: https://github.com/bitcoin/bitcoin/pull/10043
186 2017-03-23 19:27:56	0|wumpus|I wasn't aware it was inconsequential
187 2017-03-23 19:27:58	0|gmaxwell|I think that to the extent that we continue to write those keys (e.g. for old wallets) that we should always use the compressed flag.
188 2017-03-23 19:28:02	0|wumpus|did anyone reply that to the issue?
189 2017-03-23 19:28:04	0|jonasschnelli|Though,... as long as nobody reads BDB from the outside it shoudn't matter
190 2017-03-23 19:28:07	0|gmaxwell|wumpus: we decided compressed/uncompressed from the pubkey.
191 2017-03-23 19:28:24	0|gmaxwell|wumpus: the public key inside the der private key does nothing.
192 2017-03-23 19:28:26	0|wumpus|luke-jr: would be nice to keep HD wallets 'pure'
193 2017-03-23 19:28:34	0|wumpus|luke-jr: at the least it should throw a warning
194 2017-03-23 19:28:52	0|jonasschnelli|luke-jr: Yes. We should reject... in that case
195 2017-03-23 19:28:52	0|wumpus|gmaxwell: weird :)
196 2017-03-23 19:28:55	0|luke-jr|if we could do warnings, importprivkey should always throw a warning anyway :p
197 2017-03-23 19:29:03	0|gmaxwell|Background: The DER private key format includes the public key, along with all the ECC group parameters, and other overheads all packed in hundreds of bytes of ASN1 parsing hell.
198 2017-03-23 19:29:14	0|jonasschnelli|wumpus: Yes. It wired... better DER is gone sooner then later
199 2017-03-23 19:29:30	0|jonasschnelli|It would be another thing that will make future devs stumbel
200 2017-03-23 19:29:35	0|wumpus|agreed
201 2017-03-23 19:29:50	0|wumpus|so if there is a backwards-incompatible wallet change, that could be included, I guess
202 2017-03-23 19:29:54	0|gmaxwell|Turns out we were trying to tell the der private key to use compressed or not on the basis of the key using compressed or not...  but the code was wrong. But it doesn't matter because we never did anything with the private key embedded public key.
203 2017-03-23 19:30:12	0|jonasschnelli|wumpus: Yes. The hd chain split...
204 2017-03-23 19:30:23	0|jonasschnelli|(which we hopefully can merge soon)
205 2017-03-23 19:30:28	0|wumpus|jonasschnelli: right
206 2017-03-23 19:30:55	0|jonasschnelli|I think we would have enought time post hd split merge to remove DER for 0.14
207 2017-03-23 19:31:01	0|gmaxwell|we should stage up several incompatible changes to make at once, the multitude of versions is a support burden. Changing the private key formats would be one of them.
208 2017-03-23 19:31:10	0|luke-jr|jonasschnelli: 0.14 is gone; you mean 0.15?
209 2017-03-23 19:31:13	0|BlueMatt|15
210 2017-03-23 19:31:22	0|jonasschnelli|Ergh.. yes.
211 2017-03-23 19:32:14	0|jonasschnelli|Do we expect that the wallet db handles error correction or should we directly switch to something like Bech32 for our internal privkey serialisation?
212 2017-03-23 19:32:19	0|BlueMatt|gmaxwell: the code looks the same either way? wallet version 14990 14991 14992 can all be in the same release, whatever...code is still wallet.AmUpgradedTo(THING)
213 2017-03-23 19:32:55	0|gmaxwell|in our code but not necessarily in other tools.
214 2017-03-23 19:33:01	0|gmaxwell|also we have to worry about interactions.
215 2017-03-23 19:33:28	0|BlueMatt|fair
216 2017-03-23 19:33:38	0|BlueMatt|gmaxwell: to be clear, are you suggesting they all happen in one wallet version, or in one release?
217 2017-03-23 19:33:38	0|wumpus|the wallet db has no error correction
218 2017-03-23 19:33:55	0|BlueMatt|(I mean we dont support wallet versions from mid-release, but it'd be really annoying...)
219 2017-03-23 19:34:02	0|jonasschnelli|wumpus: I think this would/should be very desirable
220 2017-03-23 19:34:04	0|wumpus|(berkeleydb doesn't and neither does leveldb, the latter only has detection)
221 2017-03-23 19:34:15	0|wumpus|jonasschnelli: yes, encoding privkeys in a resilient format makes sense
222 2017-03-23 19:34:21	0|wumpus|jonasschnelli: though doesn't encryption break that?
223 2017-03-23 19:34:31	0|wumpus|jonasschnelli: the error correction should be around the encryption, not inside it
224 2017-03-23 19:34:41	0|wumpus|otherwise one bit change will  completely mangle it anyway
225 2017-03-23 19:34:45	0|gmaxwell|BlueMatt: preferable to be one version, but certantly one release. I don't know that we really don't support midrelease wallets. "sorry dude, your funds are gone, you made the mistake of helping us test." :P  there are degrees of non-support.
226 2017-03-23 19:34:48	0|luke-jr|we have never broken wallet versions from mid-release AFAIK
227 2017-03-23 19:34:51	0|jonasschnelli|wumpus: good point
228 2017-03-23 19:35:19	0|gmaxwell|bech32 is not helpful for the kinds of errors we would find on disk.. you'll usually lose a whole sector at a time.
229 2017-03-23 19:35:24	0|wumpus|eh, wallets from mid-release should not suddenly break in later updates
230 2017-03-23 19:35:45	0|jonasschnelli|There is also a PR i'd like to bundle with chain-split/rm DER that would detatch the client version from the wallet version/migration handling (PR is called "wallet flags" or similar)
231 2017-03-23 19:35:49	0|gmaxwell|To make a wallet database master key error robust you should just repeat it across multiple disk sectors. :P
232 2017-03-23 19:36:02	0|wumpus|gmaxwell: I've seen single bit errors happen on disk too, though usually due to bus errors
233 2017-03-23 19:36:28	0|gmaxwell|wumpus: yea, but not as common. And it would be fine to have a wallet format with a 4kb master key. .. but I think thats stuff to think about for the post BDB world.
234 2017-03-23 19:36:30	0|petertodd|wumpus: repeating across multiple disk errors fixes that too :)
235 2017-03-23 19:36:33	0|wumpus|but some of the corrupted block files I"ve analyzed certainly had single bit errors
236 2017-03-23 19:36:47	0|gmaxwell|sorry I stated it too strongly.
237 2017-03-23 19:37:18	0|wumpus|in any case - for HD wallets we need to store way less private keys
238 2017-03-23 19:37:23	0|wumpus|so blowing up the master key to 4kb is fine
239 2017-03-23 19:37:33	0|gmaxwell|ya, t'was my intended point. :)
240 2017-03-23 19:37:35	0|wumpus|if that helps protect against various kinds of corruption
241 2017-03-23 19:37:40	0|BlueMatt|gmaxwell: ok, so multiple version numbers, but external tools only need support them as a group and -walletupgrade only supports them as a group?
242 2017-03-23 19:38:16	0|sipa|the wallet flags idea removes that release/walletversion inconsistency completely
243 2017-03-23 19:38:17	0|gmaxwell|BlueMatt: I think that would be okay but why multiple versions? add the code with the features, then a patch that turns all of them on with a single version.
244 2017-03-23 19:38:52	0|sipa|gmaxwell: that's very hard for testing
245 2017-03-23 19:39:17	0|sipa|as you'd need to be able to override the min version in tests to be able to even observe the feature
246 2017-03-23 19:39:19	0|BlueMatt|yea, was just thinking easier for review burden, but I suppose thats fine too
247 2017-03-23 19:39:36	0|BlueMatt|sipa: not so hard to have an extra commit in a pr that doesnt get merged
248 2017-03-23 19:39:44	0|sipa|BlueMatt: ugh
249 2017-03-23 19:39:49	0|gmaxwell|we just create support hurdles for ourselves supporting mixed features. "oh this change brakes bob's wallet because he had a mid-release version that had X and not Y"
250 2017-03-23 19:39:54	0|sipa|code in master should be testable
251 2017-03-23 19:40:19	0|sipa|wallet flags does not necessarily imply supporting mixed features
252 2017-03-23 19:40:41	0|gmaxwell|As long as it doesn't then I don't mind.
253 2017-03-23 19:40:56	0|gmaxwell|Just please lets not dribble in three different incompatible versions during a release cycle.
254 2017-03-23 19:41:04	0|BlueMatt|jonasschnelli: detaching client version, fine, but would strongly prefer a serially increasing version number and not flags
255 2017-03-23 19:41:07	0|gmaxwell|and end up with people with weird wallets that will break later.
256 2017-03-23 19:41:25	0|sipa|we could also detach walletversion from client version
257 2017-03-23 19:41:32	0|sipa|that would accomplish the same thing
258 2017-03-23 19:41:39	0|BlueMatt|yea, that ^
259 2017-03-23 19:41:41	0|gmaxwell|unless we're going to add tests for all the possible variations we shouldn't let people running master encounter them unawares.
260 2017-03-23 19:41:46	0|sipa|and just increment the wallet version when a new feature is added
261 2017-03-23 19:41:53	0|BlueMatt|wasnt sipa magic number picker for a while? can we just go back to that
262 2017-03-23 19:42:12	0|BlueMatt|or jonasschnelli, since he owns wallet these days, mostly
263 2017-03-23 19:42:22	0|gmaxwell|for testing you should just be able to set a commandline paramter that turns on future versions/features.
264 2017-03-23 19:42:52	0|gmaxwell|e.g. default wallet created is version X  but there is code for version Y (or flag Y) and you can ask for it for testing, but until its the default its unstable and all bets are off.
265 2017-03-23 19:43:14	0|jonasschnelli|Need to think about it. Flags seems to be good anyways (supports HD, watch only,...) but most not be linked to the wallet database version.. hmm..
266 2017-03-23 19:43:26	0|gmaxwell|I don't care if we retain compatiblity for a wallet someone created by running bitcoind with --force-wallet-screw-me-over-now-now-now
267 2017-03-23 19:43:28	0|jonasschnelli|s/most/must
268 2017-03-23 19:44:07	0|BlueMatt|jonasschnelli: flags just makes things more complicated to support (interactions, yuck), and I'm not sure we have a compelling use-case for turning on some stuff but not others, aside from "I want my wallet to work all the way back to version 0.X"
269 2017-03-23 19:44:11	0|gmaxwell|And I'm fine with flags too, of course, but not with supporting arbritary combinations. (unless someone really wants to build extensive automated testing for all the combinations)
270 2017-03-23 19:44:37	0|luke-jr|BlueMatt: Core isn't the only compatible wallet.
271 2017-03-23 19:44:47	0|gmaxwell|e.g. basically a version implies flags... and you use flags in the code, and that doesn't mean that all combinations of flags get tested.
272 2017-03-23 19:45:13	0|BlueMatt|luke-jr: all other wallets that read our wallet format are unsupported, I believe (and, hell, probably easier for them if we dont have flags with interactions...)
273 2017-03-23 19:45:15	0|jtimon|right, you can have flags and maybe even have debug option for experimental wallet features that we can remove in releases (or just not leave any wallet feature that doesn't have a version yet)
274 2017-03-23 19:45:22	0|jonasschnelli|Flags would allow flexible backporting? But I think we don't want to do this.
275 2017-03-23 19:45:35	0|jtimon|or just an extra commit that doesn't get merged like BlueMatt says
276 2017-03-23 19:45:41	0|luke-jr|BlueMatt: you're rather aggressive with "unsupported" IMO
277 2017-03-23 19:45:43	0|wumpus|we never backport wallet features
278 2017-03-23 19:45:55	0|gmaxwell|luke-jr: Our _binary_ wallet format isn't intended to be interoperable. If it is, great! but without a spec and a moving target, it isn't something we can guaretee.  To begin with there would need to be an extensive all features all flags test suite... and I think it would be a waste of time to construct that for this format (esp since we're never going to specify BDB itself).
279 2017-03-23 19:45:58	0|BlueMatt|luke-jr: we have limited resources, but, fair point
280 2017-03-23 19:46:11	0|wumpus|yes, the database formats are not an external interface
281 2017-03-23 19:46:58	0|wumpus|we reserve the right to change them completely from one release to another without advance notice, though that will usually not happen
282 2017-03-23 19:47:05	0|gmaxwell|I don't know if wallet format compatiblity is a reasonable goal in general, at least not this year-- just because it's so integrally tied to the functionality.
283 2017-03-23 19:47:27	0|wumpus|older wallets should *always* work
284 2017-03-23 19:47:34	0|wumpus|that's the only guarantee
285 2017-03-23 19:47:37	0|gmaxwell|but obviously we don't want to create unnecessary incompatiblity.
286 2017-03-23 19:47:43	0|gmaxwell|right.
287 2017-03-23 19:47:51	0|gmaxwell|okay, is this horse dead yet?
288 2017-03-23 19:47:56	0|wumpus|yes
289 2017-03-23 19:47:58	0|jonasschnelli|yes
290 2017-03-23 19:48:00	0|wumpus|other topics?
291 2017-03-23 19:48:08	0|sipa|lunch?
292 2017-03-23 19:48:11	0|gmaxwell|I'd like to know if people might be willing to sign onto a statement like this:
293 2017-03-23 19:48:12	0|luke-jr|wallet format changes move slowly. I try to avoid backporting pending PRs to Knots now, but IMO once they get merged they should be fair.
294 2017-03-23 19:48:16	0|gmaxwell|https://0bin.net/paste/vSuqwACPe8WzpCnI#4katsiFvmtzK85e8eNgNVuElwD8kTbjPVuQnkontSyF
295 2017-03-23 19:48:17	0|gribble|https://github.com/bitcoin/bitcoin/issues/4 | Export/Import wallet in a human readable, future-proof format · Issue #4 · bitcoin/bitcoin · GitHub
296 2017-03-23 19:48:29	0|jtimon|sorry, "--force-wallet-screw-me-over-now-now-now" is exactly what I meant
297 2017-03-23 19:48:32	0|petertodd|gmaxwell: ACK
298 2017-03-23 19:48:36	0|gmaxwell|(gee thanks for the link gribble)
299 2017-03-23 19:49:06	0|wumpus|#topic statement against running closed source node code
300 2017-03-23 19:49:17	0|kanzure|"If it ever does, you may safely assume that the actual contributors to the project are locked in a basement somewhere. In that case, please send help." and food
301 2017-03-23 19:49:22	0|luke-jr|gmaxwell: I haven't thought about it sufficiently to be certain about "never"
302 2017-03-23 19:49:23	0|wumpus|gmaxwell: ACK
303 2017-03-23 19:49:30	0|petertodd|gmaxwell: though I think the statement should be a little more clear on what the risks are - this is money so such a binary may very well be an attempt to steal your coins
304 2017-03-23 19:49:52	0|wumpus|or may have hidden vulnerabilities, bugdoors and backdoors
305 2017-03-23 19:50:01	0|BlueMatt|gmaxwell: seems reasonable
306 2017-03-23 19:50:05	0|jtimon|BlueMatt: the original flags can be replaced with the version flag once you have a version for a set of them
307 2017-03-23 19:50:08	0|kanzure|yep seems good to me
308 2017-03-23 19:50:20	0|gmaxwell|luke-jr: I think I have, plus 1001 other open source packages have. As I point out in the document even if all other options fail, "shut off" remains an option too.
309 2017-03-23 19:50:28	0|jonasschnelli|Yes. A statement would be good. Also.. github.binaries with a SHA256 on reddit is _not_ want you want for a such ecosystem
310 2017-03-23 19:50:31	0|luke-jr|true
311 2017-03-23 19:50:41	0|petertodd|wumpus: see, I think it's good to say in such a statement "hidden vulnerabilities, bugdoors and backdoors" and *also* give a 100% concrete example for the non-devs reading it
312 2017-03-23 19:50:42	0|jtimon|I mean, you can have a single fWalletForNextVersionExperimental flag
313 2017-03-23 19:50:43	0|gmaxwell|okay well I would welcome revisions. I didn't want to make it long and explaining all the options and risks.
314 2017-03-23 19:50:58	0|gmaxwell|Just saying "don't run these things if 'we' do" is protective to both the users and us.
315 2017-03-23 19:51:04	0|wumpus|we have this stringent gitian process which costs quite a lot of time, maybe we should put more focus on it...
316 2017-03-23 19:51:34	0|gmaxwell|In any earlier draft I had listed out some of the options we have (and have used before) and it was 3x longer than this just explining a couple of them. :)
317 2017-03-23 19:51:46	0|kanzure|also, submitting source code "later" is not acceptable either
318 2017-03-23 19:51:47	0|achow101|the statement should say "Bitcoin Core project", not "Bitcoin project" IMO
319 2017-03-23 19:51:53	0|wumpus|I sometimes have the feeling we're doing all this auditability for nothing if people are ready to just download random crap binaries of the internet and run them, though I guess some do validate it...
320 2017-03-23 19:52:08	0|gmaxwell|wumpus: well we know not everyone does that.
321 2017-03-23 19:52:19	0|sipa|wumpus: i think it's a slow process... the best we can do is talk about it, and highlight what we're doing
322 2017-03-23 19:52:37	0|sipa|and just the increase in number of gitian builders on itself is a good sign
323 2017-03-23 19:52:40	0|kanzure|mentioning bugdoors, backdoors and other malware is important
324 2017-03-23 19:52:46	0|sipa|(reminds me, i need to build 0.14...)
325 2017-03-23 19:53:05	0|petertodd|wumpus: I know for a fact that many high-value users do verify PGP signatures and the like, e.g. exchanges and custodians. That effort isn't wasted.
326 2017-03-23 19:53:08	0|gmaxwell|okay, well I can work with some people on some language twiddling. Sounds like a couple people are interested.
327 2017-03-23 19:53:21	0|wumpus|I guess the important thing is that some people do validate it, and can raise a stink if things don't match, which is not possible with random crap executables
328 2017-03-23 19:53:28	0|wumpus|petertodd: right.
329 2017-03-23 19:53:29	0|gmaxwell|and luke-jr if you want to talk later and have me convince you that we'd would never in the future do a binary release, I'd be happy to.
330 2017-03-23 19:53:40	0|BlueMatt|one of these days I'm gonna finally convince cfields to finish his "trusting trust" compiler-builder for use in gitian, then I'll be much louder...the trusting-ubuntu part of gitian is...irritating at best (but still infinitely better than the alternative)
331 2017-03-23 19:53:49	0|gmaxwell|(_NEVER_ I mean, in the strongest sense, I'm sure you already are convinced that almost never would hold)
332 2017-03-23 19:54:10	0|luke-jr|yeah, I certainly can't think of any circumstances that would ever justify it.
333 2017-03-23 19:54:43	0|cfields|BlueMatt: yea, that's a goal of mine for 0.15.
334 2017-03-23 19:54:44	0|petertodd|gmaxwell: I like that you explicitly mentioned in that doc that interruption of service is perferable
335 2017-03-23 19:54:54	0|BlueMatt|cfields: yippee
336 2017-03-23 19:55:02	0|BlueMatt|topic?
337 2017-03-23 19:55:27	0|gmaxwell|petertodd: well I tested some of this explination on reddit while talking to people 1:1 about some things. so I have an idea of what needs to be explained.
338 2017-03-23 19:55:34	0|jtimon|gmaxwell: I would prefer if we mentioned free software explicitly or even replace open source with free software, but I agree with everything said in that statement
339 2017-03-23 19:55:36	0|sipa|BlueMatt: sounds good to me
340 2017-03-23 19:55:43	0|sipa|BlueMatt: everyone gets to list 1 PR?
341 2017-03-23 19:55:50	0|BlueMatt|sipa: sure
342 2017-03-23 19:55:51	0|jonasschnelli|Maybe two? :)
343 2017-03-23 19:55:58	0|BlueMatt|mine is 9725
344 2017-03-23 19:56:03	0|gmaxwell|jtimon: ack. Thanks for the feedback I'll revise some and consult with others that had comments.
345 2017-03-23 19:56:06	0|jonasschnelli|#9725
346 2017-03-23 19:56:10	0|gribble|https://github.com/bitcoin/bitcoin/issues/9725 | CValidationInterface Cleanups by TheBlueMatt · Pull Request #9725 · bitcoin/bitcoin · GitHub
347 2017-03-23 19:56:12	0|wumpus|so jonasschnelli's wallet chain split seems important
348 2017-03-23 19:56:22	0|jonasschnelli|yes. please. #9294
349 2017-03-23 19:56:25	0|gribble|https://github.com/bitcoin/bitcoin/issues/9294 | Use internal HD chain for change outputs (hd split) by jonasschnelli · Pull Request #9294 · bitcoin/bitcoin · GitHub
350 2017-03-23 19:56:27	0|kanzure|on that last topic, uh, maybe wee should point out that backdoors have been found in node software already (ahem some exchanges come to mind..).
351 2017-03-23 19:56:34	0|BlueMatt|list from last week was #8694, 9294, 9725 and #7729
352 2017-03-23 19:56:36	0|gribble|https://github.com/bitcoin/bitcoin/issues/8694 | Basic multiwallet support by luke-jr · Pull Request #8694 · bitcoin/bitcoin · GitHub
353 2017-03-23 19:56:39	0|gribble|https://github.com/bitcoin/bitcoin/issues/7729 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
354 2017-03-23 19:57:06	0|BlueMatt|any additions/replacements or should we let the list stand?
355 2017-03-23 19:57:47	0|gmaxwell|#9959 could probably take some more reviews.
356 2017-03-23 19:57:48	0|wumpus|I'd also really like to have feedback on my patches to add UNIX sockets support at some point (#9979,  #9919) though it's not really urgent
357 2017-03-23 19:57:49	0|gribble|https://github.com/bitcoin/bitcoin/issues/9959 | Mining: Prevent slowdown in CreateNewBlock on large mempools by sdaftuar · Pull Request #9959 · bitcoin/bitcoin · GitHub
358 2017-03-23 19:57:51	0|gribble|https://github.com/bitcoin/bitcoin/issues/9979 | p2p: Bare minimum to support UNIX sockets by laanwj · Pull Request #9979 · bitcoin/bitcoin · GitHub
359 2017-03-23 19:57:52	0|gribble|https://github.com/bitcoin/bitcoin/issues/9919 | UNIX sockets support for RPC by laanwj · Pull Request #9919 · bitcoin/bitcoin · GitHub
360 2017-03-23 19:58:05	0|gmaxwell|(suhas doesn't appear to be here now, so I thought I'd mention it)
361 2017-03-23 19:58:31	0|luke-jr|I still have to look over BlueMatt's review on multiwallet, so I'll refrain from listing one this time ;)
362 2017-03-23 19:58:34	0|gmaxwell|wumpus: Those are a great idea. I will be trying them out. Did we find out if your patch to libevent is going to make it upstream?
363 2017-03-23 19:58:35	0|cfields|wumpus: ah, i hadn't seen the p2p one
364 2017-03-23 19:58:40	0|jonasschnelli|Can we keep the most important 1PR list on github somehow? A project?
365 2017-03-23 19:58:57	0|sipa|jonasschnelli: sounds good to me
366 2017-03-23 19:59:03	0|jonasschnelli|I think this would be great because priorizing reviews is hard right now
367 2017-03-23 19:59:10	0|wumpus|gmaxwell: still haven't heard about that one, but I don't think it should matter for getting these patches in
368 2017-03-23 19:59:11	0|sipa|a PR can belong to multiple projects, right?
369 2017-03-23 19:59:21	0|gmaxwell|keep in mind to prioritize things that we would want in a 0.14.1.
370 2017-03-23 19:59:23	0|wumpus|sipa: AFAIK yes
371 2017-03-23 19:59:27	0|jonasschnelli|hopefully
372 2017-03-23 19:59:30	0|luke-jr|PR labels seems workable for that too
373 2017-03-23 19:59:38	0|wumpus|we already have so many labels
374 2017-03-23 19:59:39	0|luke-jr|"Top Priority" or somethign perhaps
375 2017-03-23 19:59:49	0|luke-jr|wumpus: but labels are easy to filter :D
376 2017-03-23 19:59:59	0|wumpus|also I use those to classify pulls for the release notes, so I'd prefer not to use them for non-categoritical things
377 2017-03-23 20:00:04	0|jonasschnelli|Project seems to be the better choice...
378 2017-03-23 20:00:08	0|wumpus|yes
379 2017-03-23 20:00:13	0|gmaxwell|"author:wumpus" (since he does most of the merging any of his PRs are effectively 1-reviewer disadvantaged for getting in)
380 2017-03-23 20:00:17	0|sipa|DONG
381 2017-03-23 20:00:30	0|lightningbot|Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2017/bitcoin-core-dev.2017-03-23-19.00.log.html
382 2017-03-23 20:00:30	0|lightningbot|Meeting ended Thu Mar 23 20:00:29 2017 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
383 2017-03-23 20:00:30	0|lightningbot|Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2017/bitcoin-core-dev.2017-03-23-19.00.html
384 2017-03-23 20:00:30	0|lightningbot|Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2017/bitcoin-core-dev.2017-03-23-19.00.txt
385 2017-03-23 20:00:30	0|wumpus|#endmeeting
386 2017-03-23 20:00:32	0|gmaxwell|Okay, I think its time to feed sipa.
387 2017-03-23 20:00:35	0|luke-jr|lol
388 2017-03-23 20:00:38	0|jonasschnelli|hehe
389 2017-03-23 20:00:51	0|jtimon|I've been waiting on #8855 (previously #6907 previously part of other prs) for so long...
390 2017-03-23 20:00:52	0|sipa|must... not... chew PRs
391 2017-03-23 20:00:54	0|gribble|https://github.com/bitcoin/bitcoin/issues/8855 | Use a proper factory for creating chainparams by jtimon · Pull Request #8855 · bitcoin/bitcoin · GitHub
392 2017-03-23 20:00:54	0|kanzure|programmer chow is other programmers
393 2017-03-23 20:00:55	0|gribble|https://github.com/bitcoin/bitcoin/issues/6907 | Chainparams: Use a regular factory for creating chainparams by jtimon · Pull Request #6907 · bitcoin/bitcoin · GitHub
394 2017-03-23 20:00:58	0|luke-jr|when did we agree on a 1 hour limit to meetings anyway? IIRC there was only a set start time.. maybe they should go for 24 hours? :p
395 2017-03-23 20:01:02	0|sipa|jonasschnelli: cool!
396 2017-03-23 20:01:12	0|gmaxwell|luke-jr: because without a limit some people would starve.
397 2017-03-23 20:01:17	0|sipa|jonasschnelli: i may be in switzerland next month
398 2017-03-23 20:01:22	0|kanzure|luke-jr: maybe it should be based on time until 6 blocks
399 2017-03-23 20:01:32	0|jonasschnelli|sipa: If you are,... tell me and let's hand out.
400 2017-03-23 20:01:34	0|luke-jr|gmaxwell: am I the only one who eats during meetings sometimes?
401 2017-03-23 20:01:40	0|luke-jr|kanzure: hehe
402 2017-03-23 20:01:46	0|jonasschnelli|s/hand/hang
403 2017-03-23 20:01:46	0|jtimon|another old one with several previous attempts is #8498 but I guess that's my fault for saying "Optimization" without doing benchmarks...
404 2017-03-23 20:01:49	0|gribble|https://github.com/bitcoin/bitcoin/issues/8498 | Optimization: Minimize the number of times it is checked that no money... by jtimon · Pull Request #8498 · bitcoin/bitcoin · GitHub
405 2017-03-23 20:02:56	0|BlueMatt|we always have office space available for those who want a stopover between .eu and sf :P
406 2017-03-23 20:03:04	0|BlueMatt|and we have good flights :)
407 2017-03-23 20:04:05	0|luke-jr|does SF<->EU go that direction?
408 2017-03-23 20:04:34	0|jonasschnelli|BlueMatt: Ah.. man. I fly to SF over Iceland!
409 2017-03-23 20:04:41	0|jtimon|I suspect #9608 will also be open for ages, but at least that will force me to read every change in ProcessMessage...
410 2017-03-23 20:04:44	0|gribble|https://github.com/bitcoin/bitcoin/issues/9608 | Net: Divide ProcessMessage in smaller functions by jtimon · Pull Request #9608 · bitcoin/bitcoin · GitHub
411 2017-03-23 20:04:57	0|BlueMatt|jtimon: we said you get to pick one :P
412 2017-03-23 20:05:59	0|sipa|jonasschnelli: cool, wowair?
413 2017-03-23 20:06:01	0|cfields|jtimon: I'll chime in on that one.
414 2017-03-23 20:06:18	0|jtimon|just like #8329 and #8337 force me to review every change in certain functions
415 2017-03-23 20:06:19	0|jonasschnelli|sipa: Yes. :|
416 2017-03-23 20:06:21	0|gribble|https://github.com/bitcoin/bitcoin/issues/8329 | Consensus: MOVEONLY: Move functions for tx verification by jtimon · Pull Request #8329 · bitcoin/bitcoin · GitHub
417 2017-03-23 20:06:23	0|gribble|https://github.com/bitcoin/bitcoin/issues/8337 | Consensus: MOVEONLY: Move functions for header verification by jtimon · Pull Request #8337 · bitcoin/bitcoin · GitHub
418 2017-03-23 20:07:11	0|jtimon|BlueMatt: if only one, then #8855, actually it doesn't need rebase but I'll just do it in case there's new uses of Params(std::string)
419 2017-03-23 20:07:14	0|gribble|https://github.com/bitcoin/bitcoin/issues/8855 | Use a proper factory for creating chainparams by jtimon · Pull Request #8855 · bitcoin/bitcoin · GitHub
420 2017-03-23 20:16:22	0|jtimon|cfields: cool thanks, rebased, no new uses of Params(std::string)
421 2017-03-23 20:26:22	0|jtimon|gmaxwell: is there anything planned for 0.14.1 ?
422 2017-03-23 20:27:06	0|sipa|bug fixes
423 2017-03-23 20:35:02	0|bitcoin-git|[13bitcoin] 15jtimon closed pull request #9845: RPC: cleanups in rpc/server (06master...060.15-extern-rpc-server) 02https://github.com/bitcoin/bitcoin/pull/9845
424 2017-03-23 21:07:50	0|BlueMatt|wumpus: were we gonna label peoples' review-picks as "blocking someone" or should i just put up a list somewhere
425 2017-03-23 21:09:20	0|gmaxwell|jtimon: there are a number of fixes already merged.
426 2017-03-23 21:09:38	0|jtimon|I see
427 2017-03-23 21:09:46	0|gmaxwell|jtimon: I'd like to see one ship in the not far future.  I'm kinda surprised how few bugs we've had with 0.14.0
428 2017-03-23 21:10:49	0|BlueMatt|I believe the list was me: 9725
429 2017-03-23 21:10:49	0|BlueMatt|jonas: 9294
430 2017-03-23 21:10:49	0|BlueMatt|jorge: 8855
431 2017-03-23 21:10:49	0|BlueMatt|suhas: 9959
432 2017-03-23 21:10:49	0|BlueMatt|wlad: 7729 (+9979, 9919, though not blocking per se)
433 2017-03-23 21:11:43	0|jtimon|I think it had to do with delaying forking the 0.14 branch, or perhaps I just want to think that
434 2017-03-23 21:12:03	0|jtimon|BlueMatt: thanks, that's cool, perhaps we can do that at the end of every meeting
435 2017-03-23 21:12:23	0|BlueMatt|jtimon: that was my plan
436 2017-03-23 21:12:33	0|jtimon|well ack your plan then
437 2017-03-23 21:13:20	0|BlueMatt|though I think jonasschnelli has things to respond to from my review on 9294
438 2017-03-23 21:13:37	0|jtimon|that will save me "review begging" comments
439 2017-03-23 21:16:08	0|BlueMatt|oh, and I'll go ahead and add alex as 9942, because iirc he has a few things based on that too
440 2017-03-23 22:55:53	0|kanzure|testnet bug report (maybe) https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2017-March/013765.html
441 2017-03-23 22:57:06	0|sipa|segwit nodes don't download blocks from non-segwit nodes, by design
442 2017-03-23 23:30:30	0|gmaxwell|*when segwit is active.
443 2017-03-23 23:42:49	0|bitcoin-git|[13bitcoin] 15tjps opened pull request #10067: [trivial] Dead code removal (06master...06tjps_dead_code) 02https://github.com/bitcoin/bitcoin/pull/10067