1 2017-04-09 07:46:15	0|wumpus|luke-jr: ok, feel free to change that
 2 2017-04-09 11:31:06	0|stevenroose|I haven't looked into Core's code too much, but I feel like there is quite a lack of code documentation..
 3 2017-04-09 11:31:09	0|stevenroose|F.e. https://github.com/bitcoin/bitcoin/blob/f93f9b92969b4a3f77d3f1c2a30ba3bf558e0cac/src/txmempool.cpp#L759
 4 2017-04-09 11:31:23	0|stevenroose|It says "compare" and returns a bool.
 5 2017-04-09 11:31:49	0|stevenroose|Compare methods commonly return an int that is negative for <, 0 for == and positive for >
 6 2017-04-09 11:32:05	0|stevenroose|Also, it might be useful to document what it is basing the comparison on
 7 2017-04-09 11:32:52	0|stevenroose|Even thought the method name says depth and score, it doesn;t say if a higher depth and higher score mean higher ranking (which is then either true or false)
 8 2017-04-09 12:29:35	0|sipa|stevenroose: in C++ a comparator is a function that acts like (a < b)
 9 2017-04-09 12:35:58	0|gmaxwell|s/C++/stl/
10 2017-04-09 12:58:59	0|sipa|gmaxwell: which is part of the C++ standard, but ok, other libraries can do things differently
11 2017-04-09 13:47:25	0|sipa|gmaxwell: i guess i should have said "in c++ it is common practice to use comparators which compute the less-than relation"
12 2017-04-09 13:58:34	0|gmaxwell|it just sounded weird to say "in C++"
13 2017-04-09 14:43:49	0|bitcoin-git|[13bitcoin] 15sipa closed pull request #8087: Introduce CBlockchain and move CheckBlockHeader (06master...062016-05-22-cblockchain) 02https://github.com/bitcoin/bitcoin/pull/8087
14 2017-04-09 16:01:23	0|bitcoin-git|[13bitcoin] 15sipa closed pull request #9599: [WIP] Perform validation in a separate thread to message handling. (06master...06ValidationThread) 02https://github.com/bitcoin/bitcoin/pull/9599
15 2017-04-09 20:20:12	0|stevenroose|well, fwiw, Go's sort.Interface.Less() method does the same thing, so I figured as much. but still "Less()" is more explanatory than "operator()". but thanks, I'm making sense of the code
16 2017-04-09 22:02:09	0|sipa|stevenroose: and comments are always welcome :)