1 2017-04-18 00:27:04	0|bitcoin-git|[13bitcoin] 15jimmysong opened pull request #10223: Tests: Refactor to create witness script creation function (06master...06refactor_blocktools_for_segwit) 02https://github.com/bitcoin/bitcoin/pull/10223
  2 2017-04-18 01:47:27	0|bitcoin-git|[13bitcoin] 15jimmysong opened pull request #10224: Tests: Add simple test for getaddednodeinfo (06master...06test_getaddednodeinfo) 02https://github.com/bitcoin/bitcoin/pull/10224
  3 2017-04-18 02:31:24	0|midnightmagic|sipa: What does the green spike represent here in your graph? http://bitcoin.sipa.be/ver9-50k.png
  4 2017-04-18 02:32:16	0|achow101|midnightmagic: that's csv signalling
  5 2017-04-18 02:33:00	0|midnightmagic|achow101: Thanks. I'm colourblind. I thought the blue line next to the first 144 block average was green.
  6 2017-04-18 04:15:30	0|NicolasDorier|sipa: https://github.com/bitcoin/bitcoin/pull/10195 is really too hard to review for me. I think an easier approach for review, would be to make a first PR which only change CCoinView class while making no change to the underlying storage. Then a second PR dealing with the storage change/optimization.
  7 2017-04-18 04:17:45	0|NicolasDorier|by "change to CCoinView" I mean only the method signatures to be per txout
  8 2017-04-18 04:18:12	0|NicolasDorier|without changing any underlying storage
  9 2017-04-18 05:19:53	0|sipa|NicolasDorier: there is no easy way first do one without the other, but i'll try
 10 2017-04-18 05:20:24	0|sipa|NicolasDorier: and signatures have nothing to do with it
 11 2017-04-18 05:20:35	0|NicolasDorier|I said method signature
 12 2017-04-18 05:20:54	0|NicolasDorier|ie like GetCoins() is per Outpoint instead of uint256
 13 2017-04-18 05:21:09	0|gribble|https://github.com/bitcoin/bitcoin/issues/10408 | HTTP Error 404: Not Found
 14 2017-04-18 05:21:09	0|sipa|also, please review #10408 first
 15 2017-04-18 05:21:19	0|sipa|ah yes, my apologies!
 16 2017-04-18 05:22:08	0|NicolasDorier|you were in the wrong namespace => using OOP; :D
 17 2017-04-18 05:22:45	0|NicolasDorier|mmh 10408  does not exist
 18 2017-04-18 05:22:53	0|NicolasDorier|ha
 19 2017-04-18 05:23:00	0|NicolasDorier|https://github.com/bitcoin/bitcoin/pull/10148 you mean ?
 20 2017-04-18 05:26:13	0|sipa|yes indeed
 21 2017-04-18 05:26:26	0|sipa|sorry, i just woke up
 22 2017-04-18 05:30:24	0|NicolasDorier|sipa: I will try myself to just change CCoinView signature
 23 2017-04-18 05:30:36	0|NicolasDorier|method signatures
 24 2017-04-18 05:30:52	0|NicolasDorier|will make a PR if it is usable and indeed easier to review
 25 2017-04-18 05:31:35	0|NicolasDorier|will try that today after reviewing https://github.com/bitcoin/bitcoin/pull/10148
 26 2017-04-18 05:31:42	0|sipa|NicolasDorier: that's very nontrivial
 27 2017-04-18 05:31:54	0|sipa|you'd need a translation layer with ths database
 28 2017-04-18 05:32:27	0|sipa|if you create one, i'll happily include, though?
 29 2017-04-18 05:32:32	0|sipa|s/?/!/
 30 2017-04-18 05:32:37	0|NicolasDorier|ok I will try
 31 2017-04-18 05:33:26	0|sipa|it may be easier to do the opposite; first change the db and then CCoinsView
 32 2017-04-18 05:35:40	0|sipa|because all that needs is a loop at read or write time to merge the db records/split ccoims
 33 2017-04-18 05:36:38	0|NicolasDorier|Not really related to the PR but tricky: https://github.com/bitcoin/bitcoin/blob/2584925077f9658b3953ad931b74779006e59807/src/validation.cpp#L1591 . fClean is passed either as pointer or return value. If pointer is used, return value is useless.
 34 2017-04-18 05:38:54	0|sipa|no, the return value still indicates disk corruption
 35 2017-04-18 05:39:05	0|sipa|pfClean is only for database inconsistencies
 36 2017-04-18 05:39:57	0|sipa|i'll add a comment to explain
 37 2017-04-18 05:42:38	0|sipa|but thank you very much for having a look at these PRs
 38 2017-04-18 05:42:50	0|sipa|i know they're pretty invasive
 39 2017-04-18 06:05:53	0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/d86bb075bf6d...393160cf6cda
 40 2017-04-18 06:05:54	0|bitcoin-git|13bitcoin/06master 1475a08e7 15Kalle Alm: [wallet] Add support for aborting wallet transaction rescans.
 41 2017-04-18 06:05:54	0|bitcoin-git|13bitcoin/06master 149141622 15Kalle Alm: [rpc] Add abortrescan command to RPC interface.
 42 2017-04-18 06:05:55	0|bitcoin-git|13bitcoin/06master 14393160c 15Wladimir J. van der Laan: Merge #10208: [wallet] Rescan abortability...
 43 2017-04-18 06:06:13	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10208: [wallet] Rescan abortability (06master...06rescan-abortability) 02https://github.com/bitcoin/bitcoin/pull/10208
 44 2017-04-18 06:25:50	0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/393160cf6cda...a86255b11633
 45 2017-04-18 06:25:51	0|bitcoin-git|13bitcoin/06master 143ddd227 15Kalle Alm: [doc] Add blob about finding reviewers.
 46 2017-04-18 06:25:51	0|bitcoin-git|13bitcoin/06master 14846dc17 15Kalle Alm: [doc] Wording fixes in CONTRIBUTING.md.
 47 2017-04-18 06:25:52	0|bitcoin-git|13bitcoin/06master 14a86255b 15Wladimir J. van der Laan: Merge #10211: [doc] Contributor fixes & new "finding reviewers" section...
 48 2017-04-18 06:26:08	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10211: [doc] Contributor fixes & new "finding reviewers" section (06master...06contributor-finding-reviewers) 02https://github.com/bitcoin/bitcoin/pull/10211
 49 2017-04-18 06:49:28	0|sipa|wumpus: not sure if you know this, but you can run with -reindex, make it process a couple block files, and then abort and restart with -reindex-chainstate
 50 2017-04-18 06:49:46	0|sipa|that will just make it fully process those couple files
 51 2017-04-18 06:49:51	0|wumpus|didn't know that, thanks
 52 2017-04-18 07:29:20	0|bitcoin-git|13bitcoin/06master 14637706d 15Jimmy Song: Tests: Put Extended tests first when they're included...
 53 2017-04-18 07:29:20	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/a86255b11633...9111df9673be
 54 2017-04-18 07:29:21	0|bitcoin-git|13bitcoin/06master 149111df9 15MarcoFalke: Merge #10219: Tests: Order Python Tests Differently...
 55 2017-04-18 07:29:38	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #10219: Tests: Order Python Tests Differently (06master...06order_tests_by_duration) 02https://github.com/bitcoin/bitcoin/pull/10219
 56 2017-04-18 08:13:32	0|bitcoin-git|[13bitcoin] 15kallewoof opened pull request #10225: [test] Add aborttrescan tests (06master...06abort-rescan-tests) 02https://github.com/bitcoin/bitcoin/pull/10225
 57 2017-04-18 11:12:54	0|SopaXorzTaker|Can anyone do me a favor?
 58 2017-04-18 11:13:04	0|SopaXorzTaker|please broadcast this nonstandard tx: 0100000001af73ff160d0434f1d8da871552ba06b1c24af1e91b494b2f4cbe25457eb9734300000000080106010701000100ffffffff01e0090200000000001976a914f6746dece46a2cd331f9ff7960135bcb587862ac88ac00000000'
 59 2017-04-18 11:13:23	0|SopaXorzTaker|(remove the trailing quote, of course)
 60 2017-04-18 11:17:21	0|jonasschnelli|SopaXorzTaker: broadcast yourself?
 61 2017-04-18 11:17:28	0|wumpus|only makes sense to send it direct to miners, broadcasting it will just cause it to be ignored/rejected
 62 2017-04-18 11:17:52	0|wumpus|my nodes don't want it at least
 63 2017-04-18 11:18:43	0|jonasschnelli|Ah. It's non-std. Yes. maybe google the miners IP and use something like https://github.com/libbtc/libbtc#the-bitcoin-send-tx-cli
 64 2017-04-18 11:22:28	0|SopaXorzTaker|jonasschnelli, thanks
 65 2017-04-18 11:22:33	0|SopaXorzTaker|I alrready found that
 66 2017-04-18 11:22:42	0|SopaXorzTaker|I am currently doing just that, too
 67 2017-04-18 11:29:26	0|SopaXorzTaker|jonasschnelli, I can't
 68 2017-04-18 11:29:34	0|SopaXorzTaker|I will have to compile bitcoind
 69 2017-04-18 11:29:57	0|jonasschnelli|SopaXorzTaker: why?
 70 2017-04-18 11:30:41	0|SopaXorzTaker|lazy
 71 2017-04-18 11:30:50	0|SopaXorzTaker|Arch doesn't install it
 72 2017-04-18 11:31:02	0|SopaXorzTaker|and if it did, I'd have to download the blockchain
 73 2017-04-18 11:31:09	0|SopaXorzTaker|I have to compile it myself without the checks
 74 2017-04-18 11:31:54	0|sipa|no offence, but this channel is about development of bitcoin core
 75 2017-04-18 11:32:10	0|sipa|if you're not planning to even run it, why are you here?
 76 2017-04-18 11:32:30	0|SopaXorzTaker|I am compiling it now
 77 2017-04-18 11:32:36	0|SopaXorzTaker|that'd take a while
 78 2017-04-18 11:32:39	0|SopaXorzTaker|and I am bored
 79 2017-04-18 11:33:05	0|sipa|ok :)
 80 2017-04-18 11:46:03	0|SopaXorzTaker|tx e1995a7ee78fd11a24591e35f3a7d3cda92c6cf4126879a8e133377d85906284
 81 2017-04-18 12:01:33	0|SopaXorzTaker|sipa, could you do it
 82 2017-04-18 12:01:43	0|SopaXorzTaker|" sendrawtransaction 0100000001af73ff160d0434f1d8da871552ba06b1c24af1e91b494b2f4cbe25457eb9734300000000080106010701000100ffffffff01e0090200000000001976a914f6746dece46a2cd331f9ff7960135bcb587862ac88ac00000000"
 83 2017-04-18 12:01:51	0|SopaXorzTaker|with a full blockchain, obviously
 84 2017-04-18 12:02:27	0|sipa|SopaXorzTaker: i tried, it would reject it because it's nonstandard
 85 2017-04-18 12:02:39	0|sipa|SopaXorzTaker: and modifying the code wouldn't help, as other peers would reject it too
 86 2017-04-18 12:02:48	0|sipa|you need to send it directly to miners, as you were told above
 87 2017-04-18 12:04:40	0|wumpus|yes I tried that about an hour ago, on a few nodes. Please don't repeat yourself. This channel is not for idle bitcoin discussion or technical help but for development discussion
 88 2017-04-18 12:34:00	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10220: Experiment: test: Disable fsync in travis tests (06master...062017_04_tests_eatmydata) 02https://github.com/bitcoin/bitcoin/pull/10220
 89 2017-04-18 12:42:37	0|aguyonabike|Hi, I'm not sure if this is the right place to ask this question, but could Segwit be changed to be covert-asicboost-compatible? The way I figure this could be done is similar to the extension blocks proposal, adding a special transaction "at the end" instead of using coinbase space for the witness commit
 90 2017-04-18 12:44:43	0|wumpus|yes, wrong channel, this is about concrete development of the source code on github, may be better to ask in #bitcoin-wizards or such
 91 2017-04-18 12:45:10	0|aguyonabike|sorry about it :) thanks
 92 2017-04-18 12:46:41	0|SopaXorzTaker|sipa, eligius doesn't reject
 93 2017-04-18 12:46:53	0|SopaXorzTaker|how do I feed that to a miner node?
 94 2017-04-18 12:47:22	0|wumpus|SopaXorzTaker: different channel please, this is not development related
 95 2017-04-18 12:47:31	0|SopaXorzTaker|sorry
 96 2017-04-18 12:47:47	0|wumpus|general questions like that belong in#bitcoin
 97 2017-04-18 12:48:41	0|wumpus|alternatively, the bitcoin stack exchange can be useful for community support, it doesn't rely on people being who know being around at the time
 98 2017-04-18 12:48:53	0|wumpus|-being
 99 2017-04-18 13:16:39	0|SopaXorzTaker|offtopic: give an example of a miner node that I can feed the transaction to, please
100 2017-04-18 13:16:43	0|SopaXorzTaker|wumpus, sipa ^
101 2017-04-18 13:16:51	0|SopaXorzTaker|I can't find any
102 2017-04-18 13:17:09	0|sipa|SopaXorzTaker: not here, offtopic
103 2017-04-18 13:17:52	0|SopaXorzTaker|okay
104 2017-04-18 13:45:34	0|wumpus|this is not a "highlight developers to get support" channel, last warning
105 2017-04-18 13:54:24	0|SopaXorzTaker|wumpus, fine
106 2017-04-18 13:54:37	0|SopaXorzTaker|and sorry for that
107 2017-04-18 14:03:15	0|SopaXorzTaker|guys
108 2017-04-18 14:03:17	0|SopaXorzTaker|oops
109 2017-04-18 14:20:11	0|bincap|back to srs busines on other hand
110 2017-04-18 14:20:24	0|bincap|luke-jr: laanwj was so kind and confirmed gitian for knots+bip148 https://github.com/magmaship/bitcoin-special-gitian.sigs/pull/1
111 2017-04-18 14:20:47	0|bincap|dang wrong #bitcoin channel. Disregard that, moving to #bitcoin
112 2017-04-18 15:39:55	0|bitcoin-git|[13bitcoin] 15luke-jr opened pull request #10226: wallet: Use boost to more portably ensure -wallet specifies only a filename (06master...06refactor_wallet_pathsep) 02https://github.com/bitcoin/bitcoin/pull/10226
113 2017-04-18 17:21:45	0|bitcoin-git|[13bitcoin] 15jtimon opened pull request #10227: Make functions in validation.cpp static: (06master...06b14-chainparams-validation-static) 02https://github.com/bitcoin/bitcoin/pull/10227
114 2017-04-18 19:14:18	0|jtimon|so what's next for #10189 ?
115 2017-04-18 19:14:19	0|gribble|https://github.com/bitcoin/bitcoin/issues/10189 | devtools/net: add a verifier for scriptable changes. Use it to make CNode::id private. by theuni · Pull Request #10189 · bitcoin/bitcoin · GitHub
116 2017-04-18 19:15:28	0|jtimon|I also read the topic on last meeting which I missed, it seems we agree that this facilitates review but doesn't replace it
117 2017-04-18 19:15:52	0|BlueMatt|jtimon: I believe cfields has a few things to update on it?
118 2017-04-18 19:16:32	0|jtimon|BlueMatt: apart from requiring a specific prefix (which can be done later), anything else?
119 2017-04-18 19:16:40	0|BlueMatt|that was my only comment
120 2017-04-18 19:17:02	0|BlueMatt|dont think it should be done in a separate pr, though? you dont want to gratuitously change it so that old commits are no longer verifyable for no reason
121 2017-04-18 19:17:08	0|BlueMatt|(plus its super trivial)
122 2017-04-18 19:17:35	0|cfields|sure, will add
123 2017-04-18 19:18:23	0|jtimon|yeah, I actually didn't thought about making it mandatory for the script to be checked, just as a convention to put in the development notes with some explanation on how to use this, but ack on making the script check for the tittle prefix
124 2017-04-18 19:29:48	0|jtimon|BlueMatt: ack on completing it further, thanks guys
125 2017-04-18 19:30:31	0|jtimon|I'm also not sure if there's any blocker for #9494, maybe squashing #10119 into it?
126 2017-04-18 19:30:33	0|gribble|https://github.com/bitcoin/bitcoin/issues/9494 | Introduce an ArgsManager class encapsulating cs_args, mapArgs and mapMultiArgs by jtimon · Pull Request #9494 · bitcoin/bitcoin · GitHub
127 2017-04-18 19:30:34	0|gribble|https://github.com/bitcoin/bitcoin/issues/10119 | Util: Remove ArgsManager wrappers: by jtimon · Pull Request #10119 · bitcoin/bitcoin · GitHub
128 2017-04-18 19:31:28	0|jtimon|ping: jeremyrubin
129 2017-04-18 20:23:15	0|jtimon|btw, as much excited as I am about #10193, the part replacing BOOST_REVERSE_FOREACH isn't even compiling for prevector_tests.cpp (see https://github.com/bitcoin/bitcoin/pull/10193/commits/cfef34884684e71c6f43ef3e4f2e87590fc87c9e ), and thus https://github.com/bitcoin/bitcoin/pull/10193/commits/d0cbbbe1147dfdf407087816a4e999990907a565 should be done either as it is
130 2017-04-18 20:23:16	0|gribble|https://github.com/bitcoin/bitcoin/issues/10193 | scripted-diff: Remove #include foreach.hpp> by jtimon · Pull Request #10193 · bitcoin bitcoin · GitHub
131 2017-04-18 20:24:38	0|jtimon|perhaps I should reduce the scope if I can't find a fix (and I'm still pretty clueless about why the code I "stole" from the interwebs isn't working)
132 2017-04-18 23:32:59	0|bitcoin-git|[13bitcoin] 15theuni opened pull request #10228: build: regenerate bitcoin-config.h as necessary (06master...06fix-config-h) 02https://github.com/bitcoin/bitcoin/pull/10228