1 2017-04-26 01:50:11 0|bitcoin-git|[13bitcoin] 15TheBlueMatt opened pull request #10279: Add a CChainState class to validation.cpp to take another step towards clarifying internal interfaces (06master...062016-12-cconsensus) 02 https://github.com/bitcoin/bitcoin/pull/10279
2 2017-04-26 01:50:25 0|BlueMatt|jtimon: ^ this is rather much in your wheelhouse
3 2017-04-26 03:33:46 0|achow101|gmaxwell: any update with publishing the alert key?
4 2017-04-26 04:06:04 0|bitcoin-git|[13bitcoin] 15jimmysong opened pull request #10280: [test] Unit test amount.h/amount.cpp (06master...06test_amount) 02 https://github.com/bitcoin/bitcoin/pull/10280
5 2017-04-26 05:23:36 0|bitcoin-git|[13bitcoin] 15laanwj opened pull request #10281: doc: Add RPC interface guidelines (06master...062017_04_rpc_if_guidelines) 02 https://github.com/bitcoin/bitcoin/pull/10281
6 2017-04-26 06:51:06 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9930: Trivial: Correct indentation and bracing (06master...06fix-indent) 02 https://github.com/bitcoin/bitcoin/pull/9930
7 2017-04-26 07:35:04 0|bitcoin-git|13bitcoin/06master 141b14449 15Jimmy Song: [test] Add Unit Test for GetListenPort...
8 2017-04-26 07:35:04 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/9c94fb6c3257...8254a8ae213b
9 2017-04-26 07:35:05 0|bitcoin-git|13bitcoin/06master 148254a8a 15Wladimir J. van der Laan: Merge #10278: [test] Add Unit Test for GetListenPort...
10 2017-04-26 07:35:29 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10278: [test] Add Unit Test for GetListenPort (06master...06test_listenport) 02 https://github.com/bitcoin/bitcoin/pull/10278
11 2017-04-26 08:27:59 0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/8254a8ae213b...8979f4569e0e
12 2017-04-26 08:28:00 0|bitcoin-git|13bitcoin/06master 144f3ac7d 15Chris Gavin: Remove unused variable from `macdeployqtplus` script.
13 2017-04-26 08:28:00 0|bitcoin-git|13bitcoin/06master 148979f45 15Wladimir J. van der Laan: Merge #10273: [scripts] Minor improvements to `macdeployqtplus` script....
14 2017-04-26 08:28:00 0|bitcoin-git|13bitcoin/06master 14e8babc4 15Chris Gavin: Use `with` in `macdeployqtplus` script.
15 2017-04-26 08:28:43 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10273: [scripts] Minor improvements to `macdeployqtplus` script. (06master...06macdeployqtplus) 02 https://github.com/bitcoin/bitcoin/pull/10273
16 2017-04-26 08:46:18 0|MarcoFalke|wumpus: I am not convinced that we need to implement every function twice. (Once in the code and a second time in the unit tests; Then check for equality)
17 2017-04-26 08:46:26 0|MarcoFalke|(re 10278)
18 2017-04-26 08:46:45 0|MarcoFalke|Also, the SoftSetArg has effect on all test that run after it
19 2017-04-26 08:46:49 0|wumpus|MarcoFalke: this is just a very simple function to test
20 2017-04-26 08:47:03 0|wumpus|the test fully checks the behavior of GetListenPort, though
21 2017-04-26 08:47:48 0|wumpus|feel free to suggest other ways to test GetListenPort, or do you mean no unit test should exist for it at all?
22 2017-04-26 08:48:02 0|MarcoFalke|I mean it is a 1:1 copy of the implementation
23 2017-04-26 08:48:05 0|wumpus|yes, it doesn't reset the argument afterward, probaly should
24 2017-04-26 08:48:32 0|MarcoFalke|I more think of unit test to cover corner cases
25 2017-04-26 08:48:39 0|wumpus|it is, but I wouldn't know how to test this otherwise
26 2017-04-26 08:48:51 0|wumpus|it's just a silly little function that only does one thing
27 2017-04-26 08:49:17 0|wumpus|so the only way to test it is to do that silly little thing too
28 2017-04-26 08:49:41 0|wumpus|you could argue it is useless, I don't know, maybe it'll catch an error if someone changes the GetListenPort implementation
29 2017-04-26 08:50:52 0|MarcoFalke|Hmm, I suspect pretty much everything else breaks if the implementation is changed.
30 2017-04-26 08:52:39 0|MarcoFalke|I don't care too much about this very function, but I am worried there will be pulls coming up for literally any function.
31 2017-04-26 08:52:56 0|wumpus|possibly. But the point of the unit test is to check that function, and it does that.
32 2017-04-26 08:53:26 0|wumpus|yes, feel free to nudge him in the direction of writing more useful tests
33 2017-04-26 08:54:21 0|wumpus|just trying to encourage him a bit, it's good to have a new contributor that cares about testing
34 2017-04-26 08:54:58 0|MarcoFalke|Yes, getting that merged was probably a good way to motivate more contributions
35 2017-04-26 08:57:34 0|wumpus|right, he has admitted this is part of his learning process
36 2017-04-26 08:58:11 0|wumpus|later
37 2017-04-26 09:07:22 0|wumpus|oh wow TIL github has a "reviews -> awaiting review from you" selection for PRs
38 2017-04-26 09:07:51 0|wumpus|that could be useful, at least if someone had tagged me as reviewr for anything :)
39 2017-04-26 09:44:43 0|bitcoin-git|13bitcoin/06master 14b508424 15Wladimir J. van der Laan: contrib: github-merge improvements...
40 2017-04-26 09:44:43 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/8979f4569e0e...bd9ec0ef1ea7
41 2017-04-26 09:44:44 0|bitcoin-git|13bitcoin/06master 14bd9ec0e 15Wladimir J. van der Laan: Merge #9670: contrib: github-merge improvements...
42 2017-04-26 09:44:55 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9670: contrib: github-merge improvements (06master...062017_01_ghmerge_update) 02 https://github.com/bitcoin/bitcoin/pull/9670
43 2017-04-26 10:22:51 0|mryandao|hi, i'm looking at core's source and just wondering if I've got this right.
44 2017-04-26 10:23:26 0|mryandao|when a block is accepted, individual transactions that come with the blocks dont get verified?
45 2017-04-26 10:24:54 0|kallewoof|They do get verified
46 2017-04-26 10:24:58 0|sipa|correct, with the footnote that acceptance does not imply it's valid
47 2017-04-26 10:25:30 0|sipa|tx validation happens when a chain of blocks becomes the new longest chain, and we try to "activate" it
48 2017-04-26 10:25:31 0|kallewoof|Isn't the CheckTransaction for loop in CheckBlock verifying them?
49 2017-04-26 10:25:45 0|kallewoof|Ahh, ok.
50 2017-04-26 10:26:04 0|sipa|ok, yes, but that's isn't what most people would call verifying transactions
51 2017-04-26 10:26:30 0|sipa|CheckTransaction only does some basic sanity checking
52 2017-04-26 10:26:31 0|mryandao|yeah CheckTransaction is just checking is a transaction is malformed
53 2017-04-26 10:26:59 0|mryandao|so signature validation is only done for transactions that are to be accepted into mempool?
54 2017-04-26 10:27:14 0|sipa|also when a chain is activated
55 2017-04-26 10:27:26 0|sipa|via ConnectBlock
56 2017-04-26 10:28:06 0|mryandao|cool, thanks.
57 2017-04-26 10:29:26 0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/bd9ec0ef1ea7...6fdb31916589
58 2017-04-26 10:29:27 0|bitcoin-git|13bitcoin/06master 141d31093 15Pieter Wuille: fix tsan: utiltime race on nMockTime
59 2017-04-26 10:29:27 0|bitcoin-git|13bitcoin/06master 14321bbc2 15Pieter Wuille: fix ubsan: bitcoin-tx: not initialize context before IsFullyValid
60 2017-04-26 10:29:28 0|bitcoin-git|13bitcoin/06master 146fdb319 15Wladimir J. van der Laan: Merge #9743: Fix several potential issues found by sanitizers...
61 2017-04-26 10:29:44 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9743: Fix several potential issues found by sanitizers (06master...06fsanitize) 02 https://github.com/bitcoin/bitcoin/pull/9743
62 2017-04-26 10:50:07 0|bitcoin-git|[13bitcoin] 15fanquake closed pull request #9363: Reduce fingerprinting attacks (06master...06MinChainWorkBlocktxns) 02 https://github.com/bitcoin/bitcoin/pull/9363
63 2017-04-26 11:06:15 0|bitcoin-git|[13bitcoin] 15practicalswift closed pull request #9545: Add final where appropriate (06master...06add-overrides-where-appropriate) 02 https://github.com/bitcoin/bitcoin/pull/9545
64 2017-04-26 11:11:54 0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/6fdb31916589...cf5782508a3f
65 2017-04-26 11:11:55 0|bitcoin-git|13bitcoin/06master 1402d9f50 15Russell Yanofsky: [wallet] Remove unneeded legacy getbalance code
66 2017-04-26 11:11:55 0|bitcoin-git|13bitcoin/06master 1482b7dc3 15Russell Yanofsky: [wallet] Add GetLegacyBalance method to simplify getbalance RPC...
67 2017-04-26 11:11:56 0|bitcoin-git|13bitcoin/06master 14cf57825 15Wladimir J. van der Laan: Merge #9614: [wallet] [refactor] Simplify getbalance implementation...
68 2017-04-26 11:12:09 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9614: [wallet] [refactor] Simplify getbalance implementation (06master...06pr/getbalance-cleanup) 02 https://github.com/bitcoin/bitcoin/pull/9614
69 2017-04-26 14:12:22 0|bitcoin-git|[13bitcoin] 15luke-jr opened pull request #10282: Expire bitcoind & bitcoin-qt 7-8 years after its last change (06master...06timebomb) 02 https://github.com/bitcoin/bitcoin/pull/10282
70 2017-04-26 19:04:51 0|achow101|gmaxwell: any update on publishing the alert key?
71 2017-04-26 20:09:54 0|bitcoin-git|[13bitcoin] 15morcos opened pull request #10283: Cleanup: reduce to one GetMinimumFee call signature (06master...06oneGetMinimumFee) 02 https://github.com/bitcoin/bitcoin/pull/10283
72 2017-04-26 20:50:37 0|bitcoin-git|[13bitcoin] 15morcos opened pull request #10284: Always log debug information for fee calculation in CreateTransaction (06master...06debugEstimates) 02 https://github.com/bitcoin/bitcoin/pull/10284
73 2017-04-26 21:52:14 0|bitcoin-git|13bitcoin/06master 14dcb69fd 15Jimmy Song: [test] Unit test amount.h/amount.cpp...
74 2017-04-26 21:52:14 0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/cf5782508a3f...47535d7c3ec7
75 2017-04-26 21:52:15 0|bitcoin-git|13bitcoin/06master 1447535d7 15MarcoFalke: Merge #10280: [test] Unit test amount.h/amount.cpp...
76 2017-04-26 21:52:35 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #10280: [test] Unit test amount.h/amount.cpp (06master...06test_amount) 02 https://github.com/bitcoin/bitcoin/pull/10280
77 2017-04-26 22:52:26 0|sipa|great, our CCoinsCaching benchmark converts a CMutableTransaction to a CTransaction in its inner loop...
78 2017-04-26 22:53:08 0|sipa|i expect that's the majority of the time it measures
79 2017-04-26 23:21:09 0|BlueMatt|lol
80 2017-04-26 23:21:23 0|BlueMatt|thanks C++ magic type conversion