1 2017-05-02 00:31:57	0|bitcoin-git|[13bitcoin] 15kallewoof closed pull request #10304: [rpc] Allow a txid param in getrawmempool (06master...06getrawmempool-include-txid) 02https://github.com/bitcoin/bitcoin/pull/10304
 2 2017-05-02 00:43:09	0|bitcoin-git|[13bitcoin] 15kallewoof opened pull request #10310: [doc] Add hint about getmempoolentry to getrawmempool help. (06master...06doc-getrawmempool-getmempoolentry) 02https://github.com/bitcoin/bitcoin/pull/10310
 3 2017-05-02 05:14:06	0|fanquake|cfields Can you take a look another the zeromq changes when you get a chance. I've played around with defining D_WIN32_WINNT=0x0600, but obviously I'm not doing something quite right. Will PR other depends changes today as well.
 4 2017-05-02 05:53:41	0|bitcoin-git|13bitcoin/06master 14c26655e 15Wladimir J. van der Laan: doc: Add RPC interface guidelines
 5 2017-05-02 05:53:41	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/e4bbd3d230f2...0e8499c53f9e
 6 2017-05-02 05:53:42	0|bitcoin-git|13bitcoin/06master 140e8499c 15Wladimir J. van der Laan: Merge #10281: doc: Add RPC interface guidelines...
 7 2017-05-02 05:54:05	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10281: doc: Add RPC interface guidelines (06master...062017_04_rpc_if_guidelines) 02https://github.com/bitcoin/bitcoin/pull/10281
 8 2017-05-02 07:44:15	0|bitcoin-git|[13bitcoin] 15btcdrak opened pull request #10311: Remove unused args from GetFetchFlags() (06master...06getflags) 02https://github.com/bitcoin/bitcoin/pull/10311
 9 2017-05-02 12:49:31	0|bitcoin-git|13bitcoin/06master 1466082e0 15practicalswift: [trivial] Fix typos (tempoarily → temporarily, inadvertantly → inadvertently)
10 2017-05-02 12:49:31	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/0e8499c53f9e...e7b90f78f554
11 2017-05-02 12:49:32	0|bitcoin-git|13bitcoin/06master 14e7b90f7 15Wladimir J. van der Laan: Merge #10180: [trivial] Fix typos (tempoarily → temporarily, inadvertantly → inadvertently)...
12 2017-05-02 12:49:54	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10180: [trivial] Fix typos (tempoarily → temporarily, inadvertantly → inadvertently) (06master...06inadvertantly-and-tempoarily) 02https://github.com/bitcoin/bitcoin/pull/10180
13 2017-05-02 12:50:49	0|bitcoin-git|13bitcoin/06master 149a763d4 15practicalswift: Remove excess logic.
14 2017-05-02 12:50:49	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/e7b90f78f554...f4a6180607a8
15 2017-05-02 12:50:50	0|bitcoin-git|13bitcoin/06master 14f4a6180 15Wladimir J. van der Laan: Merge #10175: Remove excess logic....
16 2017-05-02 12:51:12	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10175: Remove excess logic. (06master...06excess-logic) 02https://github.com/bitcoin/bitcoin/pull/10175
17 2017-05-02 12:57:46	0|bitcoin-git|13bitcoin/06master 147278537 15Jonas Schnelli: [Qt] Don't add arguments of sensitive command to console window
18 2017-05-02 12:57:46	0|bitcoin-git|[13bitcoin] 15jonasschnelli pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/f4a6180607a8...a3e756b7d610
19 2017-05-02 12:57:47	0|bitcoin-git|13bitcoin/06master 14a3e756b 15Jonas Schnelli: Merge #10093: [Qt] Don't add arguments of sensitive command to console window...
20 2017-05-02 12:58:04	0|bitcoin-git|[13bitcoin] 15jonasschnelli closed pull request #10093: [Qt] Don't add arguments of sensitive command to console window (06master...062017/03/qt_console) 02https://github.com/bitcoin/bitcoin/pull/10093
21 2017-05-02 13:35:57	0|jonasschnelli|For the HD restore keypool topup during SyncTransaction: I can I can't block the thread in the middle of SyncTransaction. But halting after the block has been stream through SyncTransaction may results in missing funds.
22 2017-05-02 13:56:12	0|jonasschnelli|Should the wallet really freeze the validation/net process because we can't extend the keypool?
23 2017-05-02 13:56:58	0|jonasschnelli|What if the wallet just refuses to sync/write best block if it can't topup the keypool and wait until the wallet is unlocked, then topup and call ScanForWalletTransactions?
24 2017-05-02 13:57:21	0|wumpus|I think only in case of pruning, when there is the risk the blocks will be lost
25 2017-05-02 13:57:37	0|jonasschnelli|wumpus: Good point.
26 2017-05-02 13:58:55	0|jonasschnelli|Should the BlockConnected() (it's now the main signal that calls SyncTransaction) allows to halt the validation process? Or do we need another signal into the other direction?
27 2017-05-02 13:59:13	0|jonasschnelli|I think setting a validation flag directly from wallet is not ideal
28 2017-05-02 15:00:31	0|bitcoin-git|[13bitcoin] 15instagibbs opened pull request #10313: [Consensus] Add constant for maximum stack size (06master...06stackconst) 02https://github.com/bitcoin/bitcoin/pull/10313
29 2017-05-02 15:19:25	0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #10314: Remove unused forward declaration for non-existent ScriptPubKeyToJSON(...) (06master...06remove-unused-function) 02https://github.com/bitcoin/bitcoin/pull/10314
30 2017-05-02 16:42:39	0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/a3e756b7d610...faf2dea5ea81
31 2017-05-02 16:42:40	0|bitcoin-git|13bitcoin/06master 1477c54b2 15John Newbery: [net] listbanned RPC and QT should show correct banned subnets
32 2017-05-02 16:42:40	0|bitcoin-git|13bitcoin/06master 14d6732d8 15John Newbery: [tests] update disconnect_ban.py test case to work with listbanned
33 2017-05-02 16:42:41	0|bitcoin-git|13bitcoin/06master 14faf2dea 15Wladimir J. van der Laan: Merge #10234: [net] listbanned RPC and QT should show correct banned subnets...
34 2017-05-02 16:43:04	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10234: [net] listbanned RPC and QT should show correct banned subnets (06master...06list_banned_correctly) 02https://github.com/bitcoin/bitcoin/pull/10234
35 2017-05-02 16:49:51	0|bitcoin-git|13bitcoin/06master 14661caf8 15fanquake: [doc] Minor corrections to osx dependencies
36 2017-05-02 16:49:51	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/faf2dea5ea81...1d75597ba6e8
37 2017-05-02 16:49:52	0|bitcoin-git|13bitcoin/06master 141d75597 15Wladimir J. van der Laan: Merge #10260: [doc] Minor corrections to osx dependencies...
38 2017-05-02 16:50:19	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10260: [doc] Minor corrections to osx dependencies (06master...06osx-doc-update) 02https://github.com/bitcoin/bitcoin/pull/10260
39 2017-05-02 17:00:49	0|bitcoin-git|13bitcoin/06master 143fe8a83 15practicalswift: Remove unused forward declaration for non-existent ScriptPubKeyToJSON(...)
40 2017-05-02 17:00:49	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/1d75597ba6e8...2580ff81f442
41 2017-05-02 17:00:50	0|bitcoin-git|13bitcoin/06master 142580ff8 15Wladimir J. van der Laan: Merge #10314: Remove unused forward declaration for non-existent ScriptPubKeyToJSON(...)...
42 2017-05-02 17:01:21	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10314: Remove unused forward declaration for non-existent ScriptPubKeyToJSON(...) (06master...06remove-unused-function) 02https://github.com/bitcoin/bitcoin/pull/10314
43 2017-05-02 17:12:37	0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/2580ff81f442...8f3e38477e30
44 2017-05-02 17:12:38	0|bitcoin-git|13bitcoin/06master 142a52ae6 15John Newbery: Remove duplicate method definitions in NodeConnCB subclasses...
45 2017-05-02 17:12:38	0|bitcoin-git|13bitcoin/06master 1452e15aa 15John Newbery: Adds helper functions to NodeConnCB...
46 2017-05-02 17:12:39	0|bitcoin-git|13bitcoin/06master 148f3e384 15Wladimir J. van der Laan: Merge #10169: [tests] Remove func test code duplication...
47 2017-05-02 18:07:09	0|bitcoin-git|13bitcoin/06master 14c9cc76d 15John Newbery: [tests] Remove is_network_split from funtional test cases
48 2017-05-02 18:07:09	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/8f3e38477e30...dc8fc0c73beb
49 2017-05-02 18:07:10	0|bitcoin-git|13bitcoin/06master 14dc8fc0c 15MarcoFalke: Merge #10198: [tests] Remove is_network_split from functional test framework...
50 2017-05-02 18:07:31	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #10198: [tests] Remove is_network_split from functional test framework (06master...06remove_is_network_split) 02https://github.com/bitcoin/bitcoin/pull/10198
51 2017-05-02 18:15:44	0|bitcoin-git|[13bitcoin] 15parazyd opened pull request #10316: fix contrib/debian builds; prefer qt5 (06master...06debian-packaging) 02https://github.com/bitcoin/bitcoin/pull/10316
52 2017-05-02 18:21:05	0|bitcoin-git|13bitcoin/06master 14dadfee3 15Jimmy Song: [test] Add test for listaddressgroupings...
53 2017-05-02 18:21:05	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/dc8fc0c73beb...3c5e6c94caf4
54 2017-05-02 18:21:06	0|bitcoin-git|13bitcoin/06master 143c5e6c9 15MarcoFalke: Merge #10255: [test] Add test for listaddressgroupings...
55 2017-05-02 18:21:31	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #10255: [test] Add test for listaddressgroupings (06master...06test_listaddressgroupings) 02https://github.com/bitcoin/bitcoin/pull/10255
56 2017-05-02 18:25:51	0|BlueMatt|cfields: yo
57 2017-05-02 18:44:17	0|cfields|BlueMatt: pong
58 2017-05-02 18:53:47	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/3c5e6c94caf4...75171f099e82
59 2017-05-02 18:53:48	0|bitcoin-git|13bitcoin/06master 1473b3721 15practicalswift: Remove accidental trailing semicolons
60 2017-05-02 18:53:48	0|bitcoin-git|13bitcoin/06master 14b8d9a86 15practicalswift: Remove unused import
61 2017-05-02 18:53:49	0|bitcoin-git|13bitcoin/06master 1475171f0 15MarcoFalke: Merge #10137: Remove unused import. Remove accidental trailing semicolons....
62 2017-05-02 18:54:12	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #10137: Remove unused import. Remove accidental trailing semicolons. (06master...06python-20170402) 02https://github.com/bitcoin/bitcoin/pull/10137
63 2017-05-02 19:23:04	0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #10317: Remove unused Python imports (06master...06remove-unused-python-imports-ii) 02https://github.com/bitcoin/bitcoin/pull/10317
64 2017-05-02 19:54:12	0|BlueMatt|cfields: nvm, see review on #10285
65 2017-05-02 19:54:15	0|gribble|https://github.com/bitcoin/bitcoin/issues/10285 | net: refactor the connection process. moving towards async connections. by theuni · Pull Request #10285 · bitcoin/bitcoin · GitHub
66 2017-05-02 20:14:26	0|BlueMatt|cfields: yea, #10285 is super annoying because it seems to be a step in the wrong direction by itself
67 2017-05-02 20:14:27	0|BlueMatt|:/
68 2017-05-02 20:14:27	0|gribble|https://github.com/bitcoin/bitcoin/issues/10285 | net: refactor the connection process. moving towards async connections. by theuni · Pull Request #10285 · bitcoin/bitcoin · GitHub
69 2017-05-02 20:15:11	0|cfields|BlueMatt: yea, understood. I kinda expected that type of feedback :(
70 2017-05-02 20:15:38	0|cfields|BlueMatt: the next commits make things happen in callbacks, so the flow needs to be broken up. But I'm afraid that's just too much for one PR.
71 2017-05-02 20:15:40	0|BlueMatt|yea, i mean im not gonna nack it because i know you're going somewhere, but maybe open the next pr to get concept acks before this one gets merged?
72 2017-05-02 20:15:57	0|BlueMatt|(which is apparently what we're all doing now)
73 2017-05-02 20:16:26	0|cfields|heh, yea
74 2017-05-02 20:16:38	0|cfields|ok, I can do that.
75 2017-05-02 20:37:04	0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #10318: [tests] fix wait_for_inv() (06master...06fix_wait_for_inv) 02https://github.com/bitcoin/bitcoin/pull/10318
76 2017-05-02 21:02:25	0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #10319: Remove unused argument from MarkBlockAsInFlight(...) (06master...06remove-unused-argument) 02https://github.com/bitcoin/bitcoin/pull/10319
77 2017-05-02 21:53:42	0|questioner2|<questioner> ok guys. imagine its december 2017. segwit has activated. blocks are being made to segwit specification. all the major nodes are relaying and accepting to the consensus and policy of 0.13.2+.. now then. we have a legacy user making a legacy transaction. is the network and pool nodes only allowing 4k sigops (20k/5) or 16k (80k/5) for the legacy tx. can someone show me where the (20k/5) still exists as a rule
78 2017-05-02 21:55:17	0|luke-jr|questioner2: sigops in legacy scripts count 4x toward the 80k limit
79 2017-05-02 21:56:21	0|luke-jr|this is in validation.cpp:GetTransactionSigOpCost
80 2017-05-02 21:56:39	0|questioner2|so a legacy tx can make 4 tx of 20k each
81 2017-05-02 22:10:05	0|questioner2|ok after trying to read what you say. the consensus/policy is 80k/5 for tx sigops = 16k. but legacy tx has 4x of the 16k = 4k
82 2017-05-02 22:11:09	0|questioner2|so just 20 tx of 4k legacy can use up all the blocks sigops
83 2017-05-02 22:11:14	0|sipa|questioner2: the easiest way to see it is that from the point of view of an old wallet, nothing changed
84 2017-05-02 22:11:27	0|sipa|20k legacy sigops were allowed before, 20k legacy sigops are allowed after
85 2017-05-02 22:14:21	0|questioner2|is using up all 20k legacy treated as using up all 80k block sigops. or treated as legacy tx only use 25% of blocksigop limits allowing segwit transactions to still have 60x sigops spare to use in the base block
86 2017-05-02 22:14:42	0|questioner2|60k*
87 2017-05-02 22:14:54	0|sipa|a legacy sigop counts as 4 segwit sigops
88 2017-05-02 22:15:03	0|sipa|so 20k legacy sigops would fill a block
89 2017-05-02 22:15:57	0|questioner2|so 5 legacy tx of 4k sigops would fill the block not allowing segwit txdata to sit in base block
90 2017-05-02 22:16:48	0|questioner2|4k sigops each* (=20k legacy)
91 2017-05-02 22:17:13	0|sipa|just as 1M of non-segwit transactions would fill the whole block, not leaving space for segwit transactions
92 2017-05-02 22:17:19	0|sipa|*1M bytes
93 2017-05-02 22:20:57	0|questioner2|i understand data spam of 1m ;egacy in base block can stop segwit tx's as one spam attack vector. i am just looking at other attack vectors using sigops where it doesnt need 1m of data, just a certain number of sigops to hold up possible capcity utility
94 2017-05-02 23:01:52	0|bitcoin-git|[13bitcoin] 15sipa closed pull request #10299: Remove OpenSSL (06master...06simplerandom) 02https://github.com/bitcoin/bitcoin/pull/10299
95 2017-05-02 23:03:24	0|bitcoin-git|[13bitcoin] 15sipa opened pull request #10321: Use FastRandomContext for all tests (06master...06fast_rand_tests) 02https://github.com/bitcoin/bitcoin/pull/10321