1 2017-05-09 01:35:53	0|bitcoin-git|[13bitcoin] 15kallewoof opened pull request #10366: [test] Remove all * imports (06master...06tests-unstar-imports) 02https://github.com/bitcoin/bitcoin/pull/10366
  2 2017-05-09 02:28:22	0|bitcoin-git|[13bitcoin] 15kallewoof opened pull request #10367: [test] Test abortrescan command. (06master...06test-abort-rescan-2) 02https://github.com/bitcoin/bitcoin/pull/10367
  3 2017-05-09 06:35:46	0|jonasschnelli|Another ACK is required for the QT Fee Bumper: https://github.com/bitcoin/bitcoin/pull/9697
  4 2017-05-09 06:36:01	0|jonasschnelli|Maybe paveljanik, fanquake, MarcoFalke?
  5 2017-05-09 06:51:29	0|bitcoin-git|[13bitcoin] 15kallewoof opened pull request #10368: [wallet] Remove helper conversion operator from wallet (06master...06wallet-refactor-remove-ctrans-helper) 02https://github.com/bitcoin/bitcoin/pull/10368
  6 2017-05-09 07:06:11	0|paveljanik|jonasschnelli, Does it clean-compile for you? It does not here
  7 2017-05-09 07:06:24	0|jonasschnelli|paveljanik: Oh... what did you get?
  8 2017-05-09 07:06:33	0|paveljanik|mmnt, doing clean build now
  9 2017-05-09 07:06:39	0|paveljanik|to verify
 10 2017-05-09 07:07:00	0|jonasschnelli|Travis ran fine... but maybe a rebase-on-top-of-master issue?
 11 2017-05-09 07:07:17	0|paveljanik|yes
 12 2017-05-09 07:07:23	0|paveljanik|can you please rebase?
 13 2017-05-09 07:07:35	0|paveljanik|interesting that github doesn't show problem
 14 2017-05-09 07:07:52	0|paveljanik|I haed to add #include "policy/rbf.h" and yes, it is in .rej :-)
 15 2017-05-09 07:09:50	0|paveljanik|I'll test the PR later today then
 16 2017-05-09 07:11:43	0|jonasschnelli|paveljanik: Okay. I'll rebase.
 17 2017-05-09 07:12:24	0|jonasschnelli|paveljanik: where di you had to add the include?
 18 2017-05-09 07:12:34	0|paveljanik|walletmodel.cpp
 19 2017-05-09 07:12:56	0|paveljanik|you have it there in the PR, but some diff application issue/conflict
 20 2017-05-09 07:13:17	0|paveljanik|1 out of 2 hunks FAILED -- saving rejects to file src/qt/walletmodel.cpp.rej
 21 2017-05-09 07:13:17	0|paveljanik|Hunk #1 FAILED at 8.
 22 2017-05-09 07:13:17	0|paveljanik|Hunk #2 succeeded at 698 (offset 1 line).
 23 2017-05-09 07:13:17	0|paveljanik|patching file src/qt/walletmodel.cpp
 24 2017-05-09 07:13:18	0|gribble|https://github.com/bitcoin/bitcoin/issues/1 | JSON-RPC support for mobile devices ("ultra-lightweight" clients) · Issue #1 · bitcoin/bitcoin · GitHub
 25 2017-05-09 07:13:20	0|gribble|https://github.com/bitcoin/bitcoin/issues/2 | Long-term, safe, store-of-value · Issue #2 · bitcoin/bitcoin · GitHub
 26 2017-05-09 07:13:50	0|paveljanik|I have to leave now, sorry
 27 2017-05-09 07:20:16	0|bitcoin-git|13bitcoin/06master 14330bb5a 15Jorge Timón: Consensus: Minimal way to move dust out of consensus
 28 2017-05-09 07:20:16	0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/6a796b2b53fe...08a7316c144f
 29 2017-05-09 07:20:17	0|bitcoin-git|13bitcoin/06master 1408a7316 15Wladimir J. van der Laan: Merge #9279: Consensus: Move CFeeRate out of libconsensus...
 30 2017-05-09 07:20:17	0|bitcoin-git|13bitcoin/06master 14381a46e 15Jorge Timón: Consensus: Policy: MOVEONLY: Move CFeeRate out of the consensus module...
 31 2017-05-09 07:20:33	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #9279: Consensus: Move CFeeRate out of libconsensus (06master...060.13-consensus-dust-out-minimal) 02https://github.com/bitcoin/bitcoin/pull/9279
 32 2017-05-09 08:32:19	0|bitcoin-git|[13bitcoin] 15laanwj pushed 4 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/08a7316c144f...c973cc5a4318
 33 2017-05-09 08:32:20	0|bitcoin-git|13bitcoin/06master 142351a06 15Jorge Timón: Chainparams: Get rid of CChainParams& Params(std::string)
 34 2017-05-09 08:32:20	0|bitcoin-git|13bitcoin/06master 14f87f362 15Jorge Timón: Chainparams: Use a regular factory for creating chainparams
 35 2017-05-09 08:32:21	0|bitcoin-git|13bitcoin/06master 14c1082a7 15Jorge Timón: Chainparams: Use the factory for pow tests
 36 2017-05-09 11:03:28	0|bitcoin-git|13bitcoin/06master 14ed36de5 15Jimmy Song: [tests] Update Unit Test for addrman.h/addrman.cpp...
 37 2017-05-09 11:03:28	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/c973cc5a4318...776ba233e939
 38 2017-05-09 11:03:29	0|bitcoin-git|13bitcoin/06master 14776ba23 15MarcoFalke: Merge #10287: [tests] Update Unit Test for addrman.h/addrman.cpp...
 39 2017-05-09 11:03:53	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #10287: [tests] Update Unit Test for addrman.h/addrman.cpp (06master...06test_addrman) 02https://github.com/bitcoin/bitcoin/pull/10287
 40 2017-05-09 11:40:42	0|jtimon|ryanofsky: not sure what to do with https://github.com/bitcoin/bitcoin/pull/9279#discussion_r115361685 now, if you fix it ping me to utACK it. Same for https://github.com/bitcoin/bitcoin/pull/8855#discussion_r115374175
 41 2017-05-09 11:50:42	0|jtimon|BlueMatt: does this comment still apply? not sure I understand it : https://github.com/bitcoin/bitcoin/pull/9494#discussion_r115304251
 42 2017-05-09 11:51:06	0|jtimon|what intermediate commit breaks the locking and how?
 43 2017-05-09 11:59:22	0|bitcoin-git|[13bitcoin] 15sdaftuar closed pull request #10357: Allow setting nMinimumChainWork on command line (06master...062017-05-chainwork-commandline) 02https://github.com/bitcoin/bitcoin/pull/10357
 44 2017-05-09 12:19:51	0|bitcoin-git|[13bitcoin] 15runn1ng opened pull request #10370: [pull request idea] addressindex, spentindex, timestampindex (Bitcore patches) (06master...06rebase_bitcoin_master) 02https://github.com/bitcoin/bitcoin/pull/10370
 45 2017-05-09 12:24:58	0|ryanofsky|jtimon, ok i'll just create little prs for those, sorry for not being clear
 46 2017-05-09 12:25:40	0|jtimon|ryanofsky: great, although you were clear, I just didn't had the chance to fix the nits
 47 2017-05-09 13:54:32	0|BlueMatt|jtimon: yes?
 48 2017-05-09 13:54:56	0|BlueMatt|jtimon: after the first commit on #9494 mapMultiArgs is access without locks while being updated, this is a bug, but its fixed two commits later
 49 2017-05-09 13:54:58	0|gribble|https://github.com/bitcoin/bitcoin/issues/9494 | Introduce an ArgsManager class encapsulating cs_args, mapArgs and mapMultiArgs by jtimon · Pull Request #9494 · bitcoin/bitcoin · GitHub
 50 2017-05-09 13:55:03	0|BlueMatt|jtimon: its not a huge deal, but it would be nice to not do that
 51 2017-05-09 14:14:05	0|jtimon|BlueMatt: oh, I see, got you now, thanks for explaining
 52 2017-05-09 14:14:55	0|jtimon|trivial to fix, no problem, will eat first though
 53 2017-05-09 14:55:09	0|instagibbs|morcos, what interaction are you worried about exactly re:#10360? The Core wallet already aggressively picks lots of small inputs. My PR wasn't an attempt to fix this degenerate coin selection strategy.
 54 2017-05-09 14:55:11	0|gribble|https://github.com/bitcoin/bitcoin/issues/10360 | [WIP] [Wallet] Target effective value during transaction creation by instagibbs · Pull Request #10360 · bitcoin/bitcoin · GitHub
 55 2017-05-09 15:05:02	0|morcos|instagibbs: correct that the current algorithm is bad also..  and its possibly 10360 is better, but my concern is now there are more "small" inputs b/c they are effective size inputs.
 56 2017-05-09 15:05:19	0|instagibbs|ah... I see
 57 2017-05-09 15:05:54	0|instagibbs|however, previously we would pick even negative effective value inputs. Maybe not apples/oranges.
 58 2017-05-09 15:06:22	0|morcos|i don't have any code, yet, i was just working out a design...   but in looking at the code today.. i feel like it would behoove us to clean up some stuff first...
 59 2017-05-09 15:06:34	0|morcos|instagibbs: agreed, thats why i left it as a question mark
 60 2017-05-09 15:06:51	0|instagibbs|Yeah it's a good point.
 61 2017-05-09 15:07:18	0|morcos|for instance all the nBytes calculation in coincontroldialog could hopefully be abstracted away into the same DummySignTx
 62 2017-05-09 15:07:25	0|morcos|back in 2
 63 2017-05-09 15:08:39	0|morcos|ok back.   or if we are now caching delta nBytes (to include as input) in the wallets spendable outputs themselves, then possibly we just add up those numbers
 64 2017-05-09 15:09:37	0|morcos|i started thinking about this, b/c i didnt' like the way some of your changes were duplicating code that had previously been unduplicated..  like the maxTxFee check
 65 2017-05-09 15:10:20	0|morcos|anyway.. in my ideal world.. we'd refactor to clean up a bit first... and then start making changes
 66 2017-05-09 15:10:45	0|morcos|some of your commits do that
 67 2017-05-09 15:11:29	0|MarcoFalke|wumpus: The doxygen docs are last generated in April. Mind to kick the server?
 68 2017-05-09 15:20:10	0|instagibbs|morcos, missed the qt stuff. I think additional refactoring is fine if it makes it easier to manage long-term. I'll reply in thread.
 69 2017-05-09 16:13:27	0|bitcoin-git|[13bitcoin] 15jimmysong opened pull request #10371: [tests] Clean up addrman_tests.cpp (06master...06update_addressman_test) 02https://github.com/bitcoin/bitcoin/pull/10371
 70 2017-05-09 17:13:06	0|bitcoin-git|[13bitcoin] 15sipa pushed 4 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/776ba233e939...bc64b5aa0fc5
 71 2017-05-09 17:13:07	0|bitcoin-git|13bitcoin/06master 1433f853d 15Pieter Wuille: Test that GetPerformanceCounter() increments
 72 2017-05-09 17:13:07	0|bitcoin-git|13bitcoin/06master 14f544094 15Pieter Wuille: Use hardware timestamps in RNG seeding
 73 2017-05-09 17:13:08	0|bitcoin-git|13bitcoin/06master 142c0a6f1 15Pieter Wuille: Use sanity check timestamps as entropy
 74 2017-05-09 17:13:36	0|bitcoin-git|[13bitcoin] 15sipa closed pull request #10322: Use hardware timestamps in RNG seeding (06master...06rdtsc) 02https://github.com/bitcoin/bitcoin/pull/10322
 75 2017-05-09 17:25:34	0|bitcoin-git|13bitcoin/06master 1497477c5 15Pieter Wuille: Maintain state across GetStrongRandBytes calls
 76 2017-05-09 17:25:34	0|bitcoin-git|[13bitcoin] 15sipa pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/bc64b5aa0fc5...daf3e7def7b9
 77 2017-05-09 17:25:35	0|bitcoin-git|13bitcoin/06master 14daf3e7d 15Pieter Wuille: Merge #10338: Maintain state across GetStrongRandBytes calls...
 78 2017-05-09 17:25:44	0|bitcoin-git|[13bitcoin] 15sipa closed pull request #10338: Maintain state across GetStrongRandBytes calls (06master...06stateful_rng) 02https://github.com/bitcoin/bitcoin/pull/10338
 79 2017-05-09 19:08:42	0|jtimon|cfields: I'm going to update #9494 with BlueMatt's suggestion, do you want me to also fix your nit https://github.com/bitcoin/bitcoin/pull/9494#discussion_r115337114 ?
 80 2017-05-09 19:08:44	0|gribble|https://github.com/bitcoin/bitcoin/issues/9494 | Introduce an ArgsManager class encapsulating cs_args, mapArgs and mapMultiArgs by jtimon · Pull Request #9494 · bitcoin/bitcoin · GitHub
 81 2017-05-09 19:11:10	0|cfields|jtimon: doesn't really matter either way. It just stood out as odd
 82 2017-05-09 19:11:50	0|jtimon|yeah, I mean, not doing it would be less disruptive, but I guess doing it is "more correct"(tm)
 83 2017-05-09 19:15:51	0|cfields|jtimon: I only mentioned it because it looks like it was changed for a reason i was missing. If not, may as well leave it as a const ref, no?
 84 2017-05-09 19:17:17	0|jtimon|cfields: the only reason was https://github.com/bitcoin/bitcoin/pull/9494#discussion_r114871456 so yeah I think we can leave it as a const ref, even if there's no gain with it
 85 2017-05-09 19:18:17	0|cfields|jtimon: i see. I didn't realize you'd already changed it once
 86 2017-05-09 19:18:52	0|cfields|jtimon: it's really not worth the time we've put into it :). either way is fine
 87 2017-05-09 19:19:11	0|jtimon|cfields: fair enough, I'll leave it as it is now then
 88 2017-05-09 19:19:19	0|cfields|sounds good
 89 2017-05-09 19:30:10	0|bitcoin-git|[13bitcoin] 15TheBlueMatt opened pull request #10372: Add perf counter data to GetStrongRandBytes state in scheduler (06master...062017-05-scheduler-rng) 02https://github.com/bitcoin/bitcoin/pull/10372
 90 2017-05-09 19:30:16	0|BlueMatt|sipa: you said after 10338.... ^
 91 2017-05-09 19:55:27	0|BlueMatt|sipa: do you happen to have any idea why there is the huge jump at around 35/37% progress in #10195?
 92 2017-05-09 19:55:30	0|gribble|https://github.com/bitcoin/bitcoin/issues/10195 | Switch chainstate db and cache to per-txout model by sipa · Pull Request #10195 · bitcoin/bitcoin · GitHub
 93 2017-05-09 19:55:31	0|BlueMatt|in memory usage, that is
 94 2017-05-09 19:55:55	0|sipa|BlueMatt: dust spam attack
 95 2017-05-09 19:56:03	0|BlueMatt|ah, ok, i assume something as much
 96 2017-05-09 19:56:23	0|BlueMatt|they were txn with lots of outputs, i assume?
 97 2017-05-09 19:56:29	0|sipa|i believe so
 98 2017-05-09 19:56:33	0|BlueMatt|k
 99 2017-05-09 19:57:37	0|sipa|i have an earlier graph that shows it too
100 2017-05-09 19:57:41	0|BlueMatt|k
101 2017-05-09 19:57:41	0|sipa|let's see if i still have it
102 2017-05-09 19:57:46	0|BlueMatt|ehh, whatever
103 2017-05-09 19:58:19	0|sipa|BlueMatt: http://bitcoin.sipa.be/utxo_size.png
104 2017-05-09 19:59:10	0|BlueMatt|heh
105 2017-05-09 19:59:51	0|sipa|yay for 200 MiB of waste we'll get to carry around forever...
106 2017-05-09 20:02:06	0|BlueMatt|:(
107 2017-05-09 21:06:23	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/daf3e7def7b9...7ee523604851
108 2017-05-09 21:06:24	0|bitcoin-git|13bitcoin/06master 1456befa0 15John Newbery: [tests] increase timeouts in sendheaders test
109 2017-05-09 21:06:24	0|bitcoin-git|13bitcoin/06master 14b0bfa23 15John Newbery: [tests] Make wait_until timeout 60 seconds by default
110 2017-05-09 21:06:25	0|bitcoin-git|13bitcoin/06master 147ee5236 15MarcoFalke: Merge #10365: [tests] increase timeouts in sendheaders test...
111 2017-05-09 21:06:55	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #10365: [tests] increase timeouts in sendheaders test (06master...06improve_sendheaders) 02https://github.com/bitcoin/bitcoin/pull/10365
112 2017-05-09 21:13:19	0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #10374: qa: Warn when specified test is not found (06master...06Mf1705-qaWarnTestNotFound) 02https://github.com/bitcoin/bitcoin/pull/10374
113 2017-05-09 21:18:00	0|bitcoin-git|13bitcoin/06master 14fa7396d 15MarcoFalke: qa: disablewallet: Check that wallet is really disabled
114 2017-05-09 21:18:00	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/7ee523604851...f6241b3e420e
115 2017-05-09 21:18:01	0|bitcoin-git|13bitcoin/06master 14f6241b3 15MarcoFalke: Merge #10361: qa: disablewallet: Check that wallet is really disabled...
116 2017-05-09 21:18:31	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #10361: qa: disablewallet: Check that wallet is really disabled (06master...06Mf1705-disableWalletPass) 02https://github.com/bitcoin/bitcoin/pull/10361
117 2017-05-09 21:26:56	0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #10376: [tests] fix disconnect_ban intermittency (06master...06disconnect_ban_flakiness) 02https://github.com/bitcoin/bitcoin/pull/10376
118 2017-05-09 21:27:44	0|bitcoin-git|13bitcoin/06master 14a80f295 15Jimmy Song: [tests] Clean up addrman_tests.cpp...
119 2017-05-09 21:27:44	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/f6241b3e420e...4b766fcdd4ca
120 2017-05-09 21:27:45	0|bitcoin-git|13bitcoin/06master 144b766fc 15MarcoFalke: Merge #10371: [tests] Clean up addrman_tests.cpp...
121 2017-05-09 21:28:16	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #10371: [tests] Clean up addrman_tests.cpp (06master...06update_addressman_test) 02https://github.com/bitcoin/bitcoin/pull/10371
122 2017-05-09 22:14:42	0|bitcoin-git|[13bitcoin] 15sipa opened pull request #10377: Use rdrand as entropy source on supported platforms (06master...06hwrand) 02https://github.com/bitcoin/bitcoin/pull/10377
123 2017-05-09 22:25:35	0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #10378: Rename TxConfirmStats to CTxConfirmStats to achieve class naming consistency (06master...06TxConfirmStats) 02https://github.com/bitcoin/bitcoin/pull/10378
124 2017-05-09 22:44:06	0|cfields|sipa: out of curiosity, what are your CTxInUndo serialization plans mentioned in 10195?
125 2017-05-09 22:48:58	0|sipa|cfields: the TODO's you mean?
126 2017-05-09 22:49:34	0|cfields|sipa: https://github.com/bitcoin/bitcoin/pull/10195#discussion_r114689486
127 2017-05-09 22:50:05	0|sipa|cfields: create a VectorSerializer<typename E, typename ItemSerializer>(std::vector<E>& v), which instantiates an ItemSerializer<E>(x) for every x in v, and serializes with it
128 2017-05-09 22:50:19	0|cfields|some of those serializations are pretty clunky, but I'll ignore if you intend to replace
129 2017-05-09 22:50:23	0|sipa|the default std::vector serializer would just use a dummy ItemSerializer
130 2017-05-09 22:50:44	0|cfields|hmm
131 2017-05-09 22:52:53	0|cfields|ok, i see