1 2017-05-24 01:32:31	0|bitcoin-git|[13bitcoin] 15theuni opened pull request #10446: net: avoid extra dns query per seed (06master...06no-double-resolve) 02https://github.com/bitcoin/bitcoin/pull/10446
  2 2017-05-24 03:49:53	0|murchandamus|gmaxwell: Stupid question perhaps. If #frankensegwit activated by signaling on bit4, wouldn't that just get ignored by all current segwit-ready nodes? Except that those nodes wouldn't grok #frankensegwit, would there be more issues?
  3 2017-05-24 03:51:53	0|murchandamus|since #frankensegwit would be forking off at the same moment with their blocksize increase also, wouldn't it be a non-issue? :p
  4 2017-05-24 03:53:46	0|gmaxwell|murchandamus: they'd all end up banning each other.
  5 2017-05-24 03:54:19	0|gmaxwell|murchandamus: because frankensegwit nodes would hand witnesses to 0.14 nodes, and then get punted because things aren't supposted to have wittnesses yet.
  6 2017-05-24 03:54:42	0|gmaxwell|Segwit is more than the consensus rule, it's also a set of P2P changes.
  7 2017-05-24 03:54:51	0|gmaxwell|And the p2p parts are already in effect.
  8 2017-05-24 03:55:12	0|gmaxwell|Because we didn't want to have the p2p behavior suddenly change and light up a lot of new codepaths when segwit enforcement started.
  9 2017-05-24 03:55:20	0|gmaxwell|(as that sounded like a receipy for disaster! :) )
 10 2017-05-24 03:56:39	0|gmaxwell|Segwit has the bip9 activiation, and a network service type which is used to make sure the graph of segwit capable nodes is not partitioned, and new p2p messages for transfering messages (tx, blocks, compact blocks) with witnesses if they have them.
 11 2017-05-24 03:56:43	0|murchandamus|Ah right, I didn't realize that they'd actually hand over the full witness transactions
 12 2017-05-24 03:57:04	0|gmaxwell|Only the BIP9 part isn't triggered... so to redeploy segwit we have to also replace all those other parts, not just the bip9 bit.
 13 2017-05-24 03:57:39	0|gmaxwell|Which is a simple search and replace, but only if the BIP9 activation has reached its limit... otherwise we have the potential that it might activate under either.
 14 2017-05-24 03:57:47	0|murchandamus|gmaxwell: But since #frankensegwit would activate with the blocksize increase in unisono, the hardfork would be there anyway, right?
 15 2017-05-24 03:57:48	0|gmaxwell|Just thinking about making the tests for that makes my head hurt.
 16 2017-05-24 03:58:07	0|gmaxwell|murchandamus: maybe? people are saying directly contradictory things.
 17 2017-05-24 03:58:48	0|gmaxwell|if it's a hardfork why are they talking about percentages? e.g.  The thing DCG linked to was sergios proposal that had the hardfork and segwit as seperate things.
 18 2017-05-24 03:59:04	0|gmaxwell|thats also what bitfury was saying (seperate), but not what jihan was saying.
 19 2017-05-24 04:00:18	0|murchandamus|garzik stated that on Twatter. But since they can't even properly phrase the agreement to make it in anyway specific, I sincerely doubt that they came to agreement on details in that regard yet.
 20 2017-05-24 04:01:31	0|murchandamus|Anyway, I guess it'll fall apart anyway when they try to specify what they're trying to achieve exactly with the proposal. :p
 21 2017-05-24 04:02:01	0|murchandamus|gmaxwell: Did Adam or Samson finally attend at the meeting?
 22 2017-05-24 04:04:31	0|gmaxwell|murchandamus: no, we were expicitly disinvited. (then reinvited, then disinvited-- samson ended up cancling a flight)
 23 2017-05-24 04:05:07	0|gmaxwell|Yea, details matter, and not just to engineers.
 24 2017-05-24 04:05:42	0|murchandamus|gmaxwell: Ah, I see. I was only up to date with "invited, disinvited, reinvited". Samson is in NYC though, right? Saw him in some pictures, I think.
 25 2017-05-24 04:06:06	0|gmaxwell|murchandamus: their meeting was on sunday, so I guess he went later.
 26 2017-05-24 04:06:58	0|murchandamus|gmaxwell: It just pisses me off that after two years of debate, somebody trying to forge an agreement doesn't even invest the time to run it by someone to make the text any sort of clear. E.g. "2MB hardfork", "immediately/within six months" gnarf
 27 2017-05-24 04:07:03	0|murchandamus|Ah, I C
 28 2017-05-24 04:08:56	0|murchandamus|I'm so done with the debate. I want all the shiny things that come with SegWit.— I'm sick of having 10 "unconfirmed transaction" questions on Bitcoin.SE every day.
 29 2017-05-24 04:09:37	0|gmaxwell|look on the bright side, -- someone tries to add some kind of crazy AML thing to Bitcoin, good luck to them! :P
 30 2017-05-24 04:13:27	0|murchandamus|gmaxwell: heh. Indeed. — Although I just realized. within six months would end just after the BIP9 timeout of segwit, perhaps they suggest to activate it right then?
 31 2017-05-24 04:16:39	0|luke-jr|on the bright side, BIP148 is up to 10% of listening nodes
 32 2017-05-24 04:22:00	0|murchandamus|I wouldn't be surprised if Frankensegwit becomes a large motivator for more people to adopt UASF. j)
 33 2017-05-24 04:22:03	0|murchandamus|;)
 34 2017-05-24 05:29:15	0|paveljanik|luke-jr, you mean that 10% of nodes match /UASF/?
 35 2017-05-24 05:29:32	0|paveljanik|or how do you know that run it?
 36 2017-05-24 05:30:37	0|paveljanik|...they...
 37 2017-05-24 06:03:38	0|wumpus|the bright side, for me, is that people are finally enthousastic about running their own node. So much activity! More (direct) users in the longer run run will likely result in more contributors to the project.
 38 2017-05-24 06:04:54	0|wumpus|Gavin's tweet (combined with BIP148) seems to have the complete opposite effect of what he probably imagined.
 39 2017-05-24 06:06:44	0|gmaxwell|https://twitter.com/bergealex4/status/867241659897171968  tehehe
 40 2017-05-24 06:07:08	0|wumpus|even one of my (non bitcoin) friends asked me about how to do it
 41 2017-05-24 06:07:54	0|jcorgan|gmaxwell: three blind men and an elephant
 42 2017-05-24 06:08:57	0|gmaxwell|"oh. thats not its trunk."
 43 2017-05-24 06:09:16	0|wumpus|rofl
 44 2017-05-24 06:09:19	0|jcorgan|heh
 45 2017-05-24 06:28:05	0|jonasschnelli|Why does addrman needs to remember the IPs of the seeders?
 46 2017-05-24 06:28:22	0|jonasschnelli|-> https://github.com/bitcoin/bitcoin/pull/10446/files#diff-9a82240fe7dfe86564178691cc57f2f1R1603
 47 2017-05-24 06:29:50	0|gmaxwell|jonasschnelli: because it tracks where it learns addresses from, so no single source can get excessive influence on the table.
 48 2017-05-24 06:29:59	0|wumpus|the origin of an address is kept around to make sure the connections are balanced, e.g. a not all to those from a single dns seed
 49 2017-05-24 06:30:03	0|wumpus|right
 50 2017-05-24 06:30:13	0|jonasschnelli|Okay. That makes sense. Thanks.
 51 2017-05-24 06:31:12	0|jonasschnelli|I somehow though addrman does relay the seeders IP which sets the assumption that a seeder should also run a node on the same IP (my seeder runs no node on the same IP).
 52 2017-05-24 06:31:29	0|jonasschnelli|*thought
 53 2017-05-24 06:31:37	0|sipa|nope
 54 2017-05-24 06:31:40	0|wumpus|I was confused about that too in the past, but no, that's never an assumption
 55 2017-05-24 06:31:43	0|sipa|addrman is also just a database
 56 2017-05-24 06:32:02	0|sipa|indeed, it just uses the source ip to balance in the buckets
 57 2017-05-24 06:32:17	0|sipa|this is to prevent that a single source could poison your entire cache
 58 2017-05-24 06:36:52	0|wumpus|gah it's painful to read how some people are juggling wallet.dat files, let's please get multiwallet in for 0.15
 59 2017-05-24 06:41:30	0|gmaxwell|oh it's finally been rebased.
 60 2017-05-24 06:42:55	0|jonasschnelli|Whats the etymological source of "bogo"(size)? My humble english understanding does only point me to buy-one-get-one-for-free?
 61 2017-05-24 06:43:20	0|sipa|jonasschnelli: https://en.wikipedia.org/wiki/BogoMips
 62 2017-05-24 06:44:03	0|jonasschnelli|sipa: Ah. Thanks. bogus is it then...
 63 2017-05-24 06:44:35	0|sipa|indeed
 64 2017-05-24 06:47:06	0|bitcoin-git|13bitcoin/06master 145749a48 15Russell Yanofsky: Add Qt tests for wallet spends & bumpfee...
 65 2017-05-24 06:47:06	0|bitcoin-git|[13bitcoin] 15jonasschnelli pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/4cb8757aae1a...4314544d46e8
 66 2017-05-24 06:47:07	0|bitcoin-git|13bitcoin/06master 144314544 15Jonas Schnelli: Merge #10420: Add Qt tests for wallet spends & bumpfee...
 67 2017-05-24 06:47:37	0|bitcoin-git|[13bitcoin] 15jonasschnelli closed pull request #10420: Add Qt tests for wallet spends & bumpfee (06master...06pr/btest) 02https://github.com/bitcoin/bitcoin/pull/10420
 68 2017-05-24 06:48:35	0|jonasschnelli|Anyone working on the network code willing to review: https://github.com/bitcoin/bitcoin/pull/9502?
 69 2017-05-24 06:51:09	0|wumpus|yes it's orignally a Linux thing, they needed an estimate to calibrate a delay loop. They called it 'bogo' to prevent people from using it as an actual measure of processor speed, though some people still were using it for that in the 90's.
 70 2017-05-24 06:52:21	0|wumpus|bogosize is bogus in that it doesn't measure the actual size, it can be used for relative comporisons, but keeping in mind that it's... bogus
 71 2017-05-24 06:53:07	0|wumpus|the definition is fixed and shouldn't change between client versions, unlike the leveldb size, which is entirely implementation dependent
 72 2017-05-24 06:56:17	0|gmaxwell|also history of reorgs dependant.
 73 2017-05-24 06:59:38	0|wumpus|yep, noisy and path-dependent, makes you wonder what is the bogus one :)
 74 2017-05-24 07:03:16	0|jonasschnelli|For luke-jr's multiwallet: is it problematic to keep multiple wallet.dat files in the same directory? BDB does open(datadir()), right?
 75 2017-05-24 07:03:56	0|wumpus|I think that's the only scenario supported?
 76 2017-05-24 07:04:20	0|jonasschnelli|Yes. But can BDB handle that?
 77 2017-05-24 07:04:30	0|wumpus|like with -wallet, all wallet files are relative to the data directory, there is no support for multiple BDB environments
 78 2017-05-24 07:05:05	0|wumpus|sure - a BDB environment can contain as many databases as you want
 79 2017-05-24 07:06:16	0|wumpus|there used to be a few when all the other files were BDB databases as well (that's the etymology of ".dat" for many of the files)
 80 2017-05-24 07:07:12	0|jonasschnelli|I wasn't sure if some of the salvage/recover functions where treating the whole bdb env. But right,... seems to always be per db
 81 2017-05-24 07:07:47	0|wumpus|(which is annoying for some things, e.g. you can't simply list/copy all the wallets with *.dat)
 82 2017-05-24 07:19:24	0|wumpus|oh no we are still giving the "There is no RPC client functionality in bitcoind anymore" message, we should probably change that to something more helpful before 0.15: https://github.com/bitcoin/bitcoin/issues/10402#issuecomment-303639064
 83 2017-05-24 07:21:22	0|wumpus|I'll PR
 84 2017-05-24 07:31:24	0|bitcoin-git|[13bitcoin] 15laanwj opened pull request #10447: Make bitcoind invalid argument error message specific (06master...062017_05_bitcoind_commandline_error) 02https://github.com/bitcoin/bitcoin/pull/10447
 85 2017-05-24 07:42:25	0|jonasschnelli|PaymentServer::ipcParseCommandLine(argc, argv);
 86 2017-05-24 07:42:25	0|jonasschnelli|wumpus: not sure,... but the Qt part may need the "bitcoin:" argument...
 87 2017-05-24 07:42:44	0|wumpus|jonasschnelli: but that's bitcoind.cpp, it's not part of bitcoin-qt
 88 2017-05-24 07:43:11	0|jonasschnelli|Right.. indeed... I guess no URI scheme calls bitcoind
 89 2017-05-24 07:43:16	0|jonasschnelli|I guess it can be removed then
 90 2017-05-24 07:44:05	0|wumpus|that's why I diligently copied the boost::starts_with into my new code... then later I realized, oh, this makes no sense
 91 2017-05-24 07:45:09	0|wumpus|what you want to happen if you accidentally call bitcoind with a bitcoin: URL is to give an error
 92 2017-05-24 07:45:16	0|wumpus|not for it to be silently ignored :)
 93 2017-05-24 08:06:59	0|jonasschnelli|Can we reject non GPG signed email to security@bitcoincore.org?
 94 2017-05-24 09:03:58	0|wumpus|jonasschnelli: we don't even have a GPG key for security@bitcoincore.org
 95 2017-05-24 09:04:21	0|wumpus|I'm all for a secure way to report security issues to us, but we'll first have to solve that
 96 2017-05-24 09:05:04	0|wumpus|could just list who to encrypt it to
 97 2017-05-24 09:15:48	0|jonasschnelli|wumpus: I just though require a signature (encryption can be dealt later), as form of a spam protection
 98 2017-05-24 09:16:00	0|jonasschnelli|Auto-answer back (your mail needs to be signed)...
 99 2017-05-24 09:16:25	0|jonasschnelli|reduced the "can you please confirm my tx" mails
100 2017-05-24 09:16:29	0|jonasschnelli|*reduces
101 2017-05-24 09:41:48	0|wumpus|I'm also not sure about the technical side, I don't think the current mail alias provider supports running a custom script to check incoming mails
102 2017-05-24 09:43:20	0|wumpus|and - signing doesn't provide security - we'll need to decide either 1) list theGPG keys encrypts to (leaks the list of recipients) 2) generate a GPG key and share that between the recipients
103 2017-05-24 09:50:37	0|wumpus|(one might want to be able to submit security reports deniably, so that's another reason to not require signing)
104 2017-05-24 10:12:06	0|timothy|wumpus: you can use a pseudonimous GPG key
105 2017-05-24 10:38:28	0|wumpus|sure
106 2017-05-24 12:04:20	0|bitcoin-git|[13bitcoin] 15spencerlievens opened pull request #10448: Initial Rename (06master...06rename) 02https://github.com/bitcoin/bitcoin/pull/10448
107 2017-05-24 12:04:30	0|bitcoin-git|[13bitcoin] 15spencerlievens closed pull request #10448: Initial Rename (06master...06rename) 02https://github.com/bitcoin/bitcoin/pull/10448
108 2017-05-24 12:15:31	0|jonasschnelli|hmm... https://github.com/bitcoin/bitcoin/blob/master/src/wallet/walletdb.cpp#L606
109 2017-05-24 12:15:49	0|jonasschnelli|SoftSetBoolArg("-rescan", true); will be set regardless of that if statement above...
110 2017-05-24 12:15:56	0|jonasschnelli|I guess this is why we should always use brackets.. right?
111 2017-05-24 12:16:29	0|jonasschnelli|in the context, its non critical though
112 2017-05-24 12:24:35	0|wumpus|a comment is not a statement, so this should be ok
113 2017-05-24 12:24:51	0|wumpus|it's a coding style violation, sure
114 2017-05-24 12:26:56	0|jonasschnelli|Okay... thanks.
115 2017-05-24 12:36:40	0|bitcoin-git|[13bitcoin] 15jonasschnelli reopened pull request #7061: [Wallet] add rescanblockchain <height> RPC command (06master...062015/11/wallet_rescan_rpc) 02https://github.com/bitcoin/bitcoin/pull/7061
116 2017-05-24 12:40:45	0|jonasschnelli|I hope this is not to pro-active: https://github.com/bitcoin/bitcoin/pull/7061
117 2017-05-24 12:41:05	0|jonasschnelli|But if we want clean multiwallet, we need to move zap/salvage/rescan to per wallet basis and I think only RPC works for that
118 2017-05-24 15:13:20	0|bitcoin-git|[13bitcoin] 15jonasschnelli opened pull request #10449: Overhaul Qt fee bumper (06master...062016/05/bump_qt_overhaul) 02https://github.com/bitcoin/bitcoin/pull/10449
119 2017-05-24 18:09:54	0|kanzure|asicboost https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-9230
120 2017-05-24 19:43:50	0|gmaxwell|luke-jr: why is the gentoo ebuild of bitcoin broken since 0.13.1 at least?  it seems impossible to get it to build with wallet support if ljr is disabled.
121 2017-05-24 20:33:29	0|bitcoin-git|[13bitcoin] 15ryanofsky opened pull request #10450: Fix bumpfee rpc "errors" return value (06master...06pr/berr) 02https://github.com/bitcoin/bitcoin/pull/10450
122 2017-05-24 23:39:42	0|gmaxwell|qt/test/wallettests.cpp:105:41: error: ‘void QWidget::customContextMenuRequested(const QPoint&)’ is protected within this context
123 2017-05-24 23:47:43	0|gmaxwell|looks like master is not building w/ qt4 again