1 2017-06-17 00:24:52	0|bitcoin-git|[13bitcoin] 15gmaxwell opened pull request #10618: Remove confusing MAX_BLOCK_BASE_SIZE. (06master...06size_b_gone) 02https://github.com/bitcoin/bitcoin/pull/10618
 2 2017-06-17 00:38:18	0|bitcoin-git|13bitcoin/06master 149af207c 15Cory Fields: random: fix crash on some 64bit platforms...
 3 2017-06-17 00:38:18	0|bitcoin-git|[13bitcoin] 15sipa pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/de8db47b7ff3...cafe24f039e1
 4 2017-06-17 00:38:19	0|bitcoin-git|13bitcoin/06master 14cafe24f 15Pieter Wuille: Merge #10614: random: fix crash on some 64bit platforms...
 5 2017-06-17 00:38:48	0|bitcoin-git|[13bitcoin] 15sipa closed pull request #10614: random: fix crash on some 64bit platforms (06master...06fix-osx-crash) 02https://github.com/bitcoin/bitcoin/pull/10614
 6 2017-06-17 07:15:46	0|jonasschnelli|luke-jr: the source for DigitalBitbox is my wiki diff.
 7 2017-06-17 07:16:03	0|jonasschnelli|:-)
 8 2017-06-17 07:21:16	0|luke-jr|jonasschnelli: I noticed another company did a simple PGP signed message on a pastebin ;)
 9 2017-06-17 08:04:23	0|jonasschnelli|luke-jr: good idea. Though my bitcoin.it account looks authentic and it's public available that I am a co-founder of DigitalBitbox... though a tweet or pgp signed pastebin is a good idea.. will do
10 2017-06-17 08:09:21	0|luke-jr|jonasschnelli: yes, but having to inspect history is a pain
11 2017-06-17 08:09:45	0|jonasschnelli|Yeah
12 2017-06-17 11:28:23	0|bitcoin-git|[13bitcoin] 15pavlosantoniou opened pull request #10619: Avoid possibility of NULL pointer dereference in getblockchaininfo(...) (06master...06fix01) 02https://github.com/bitcoin/bitcoin/pull/10619
13 2017-06-17 16:00:51	0|instagibbs|what is vchDefaultKey for?
14 2017-06-17 16:02:25	0|instagibbs|checking if the wallet is fFirstRun only?
15 2017-06-17 16:06:26	0|sipa|it used to mean much more
16 2017-06-17 16:06:34	0|sipa|but now i guess that's pretty much it
17 2017-06-17 16:06:55	0|instagibbs|we're burning m/0'/0'/0', which makes naive importing of hd wallets impossible if the first address is used
18 2017-06-17 16:07:08	0|instagibbs|work around is obviously to manually import first address
19 2017-06-17 16:07:19	0|instagibbs|(looking at #9728)
20 2017-06-17 16:07:21	0|gribble|https://github.com/bitcoin/bitcoin/issues/9728 | Can create Watch Only HD wallet with -hdwatchonly by NicolasDorier · Pull Request #9728 · bitcoin/bitcoin · GitHub
21 2017-06-17 16:08:17	0|instagibbs|Can we just fill it with some valid constant key instead, for backwards compatibility?
22 2017-06-17 16:19:44	0|instagibbs|oh I'm mistaken, it's silently used and added to the wallet. I think that's slightly surprising.
23 2017-06-17 16:45:14	0|jonasschnelli|instagibbs: getting rid of vchDefaultKey would be good... though its currently used to find out if its the wallet first run...
24 2017-06-17 16:45:38	0|instagibbs|jonasschnelli, right, but any valid pubkey works
25 2017-06-17 16:46:00	0|instagibbs|just have new wallets put in a static pubkey, profit?
26 2017-06-17 16:46:22	0|jonasschnelli|yes. that works
27 2017-06-17 16:47:12	0|instagibbs|k sounds good
28 2017-06-17 18:22:55	0|NewBTCDev|Hello, new dev trying to build on windows. Getting a make error that I don't understand... Could someone please take a peek and point me in the right direction? Thanks. https://pastebin.com/nNHh1B0h
29 2017-06-17 18:35:05	0|jonasschnelli|NewBTCDev: Building on Windows itself is heavy and not supported out-of-the-box (AFAIK)... try cross compile via Linux?
30 2017-06-17 18:35:33	0|jonasschnelli|https://github.com/bitcoin/bitcoin/blob/master/doc/build-windows.md#cross-compilation
31 2017-06-17 18:39:11	0|NewBTCDev|Thanks Jonass, Those are the steps I'm taking. I'm also setting up a linux VM right now.... Will my life be a lot easier building on linux? I'm new to C++ projects
32 2017-06-17 18:44:37	0|jonasschnelli|NewBTCDev: A lot easier (if you ask me)
33 2017-06-17 18:44:58	0|jonasschnelli|Windows cross compile via mingw/depends is supereasy
34 2017-06-17 18:58:30	0|bitcoin-git|[13bitcoin] 15instagibbs opened pull request #10621: Use fixed pubkey during wallet init for default key (06master...06staticdefault) 02https://github.com/bitcoin/bitcoin/pull/10621
35 2017-06-17 22:50:34	0|Lightsword|what’s the function that serializes BIP34 height in core?
36 2017-06-17 23:01:18	0|sipa|Lightsword: ContextualCheckBlock
37 2017-06-17 23:03:10	0|Lightsword|sipa, that’s only checking it right? I mean the function that does the length prefixed height serialization when mining a block
38 2017-06-17 23:09:21	0|Lightsword|trying to fix this height length serialization function in pool software https://bitbucket.org/ckolivas/ckpool/src/4718cea30af47963aa55dcc4c452b9b2f9768ff8/src/libckpool.c?at=master&fileviewer=file-view-default#libckpool.c-1757:1774 doesn’t work at some lower block numbers it seems
39 2017-06-17 23:21:11	0|sipa|BlockAssembler::CreateNewBlock
40 2017-06-17 23:44:01	0|luke-jr|kallewoof: ping
41 2017-06-17 23:44:24	0|luke-jr|Lightsword: probably it's missing the sign bit
42 2017-06-17 23:45:56	0|luke-jr|Lightsword: the len2/len3 ought to be 32768 and 8388608
43 2017-06-17 23:46:04	0|luke-jr|0x8000 and 0x800000
44 2017-06-17 23:50:10	0|Lightsword|luke-jr, ah, I recall having trouble with it at block heights even below 10 as well
45 2017-06-17 23:50:26	0|Lightsword|luke-jr, if it was a sign bit issue wouldn’t it not work at all?
46 2017-06-17 23:51:02	0|phantomcircuit|Lightsword, iirc thre isn't any code in bitcoin to do the actual serialization
47 2017-06-17 23:51:06	0|phantomcircuit|just to check that it's right
48 2017-06-17 23:51:07	0|phantomcircuit|?
49 2017-06-17 23:51:10	0|phantomcircuit|i could be wrong
50 2017-06-17 23:51:20	0|luke-jr|Lightsword: it would work on and off, but it's not
51 2017-06-17 23:51:23	0|phantomcircuit|wait there has to be
52 2017-06-17 23:51:46	0|luke-jr|phantomcircuit: it checks by serialising and comparing
53 2017-06-17 23:57:49	0|Lightsword|luke-jr, see any other potential issues there?