1 2017-06-21 00:03:04	0|bitcoin-git|13bitcoin/06master 1495543d8 15practicalswift: [net] Avoid possibility of NULL pointer dereference in MarkBlockAsInFlight(...)...
 2 2017-06-21 00:03:04	0|bitcoin-git|[13bitcoin] 15sipa pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/d636f3943d39...b33ca14f594e
 3 2017-06-21 00:03:05	0|bitcoin-git|13bitcoin/06master 14b33ca14 15Pieter Wuille: Merge #9549: [net] Avoid possibility of NULL pointer dereference in MarkBlockAsInFlight(...)...
 4 2017-06-21 00:03:16	0|bitcoin-git|[13bitcoin] 15sipa closed pull request #9549: [net] Avoid possibility of NULL pointer dereference in MarkBlockAsInFlight(...) (06master...06avoid-potential-null-pointer-dereference-in-markblockasinflight) 02https://github.com/bitcoin/bitcoin/pull/9549
 5 2017-06-21 01:00:49	0|bitcoin-git|13bitcoin/06master 14d9bec88 15Pieter Wuille: Use REJECT_DUPLICATE for already known and conflicted txn
 6 2017-06-21 01:00:49	0|bitcoin-git|[13bitcoin] 15sipa pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/b33ca14f594e...efbcf2b1d5ff
 7 2017-06-21 01:00:50	0|bitcoin-git|13bitcoin/06master 14efbcf2b 15Pieter Wuille: Merge #10503: Use REJECT_DUPLICATE for already known and conflicted txn...
 8 2017-06-21 01:01:10	0|bitcoin-git|[13bitcoin] 15sipa closed pull request #10503: Use REJECT_DUPLICATE for already known and conflicted txn (06master...06more61duplicate) 02https://github.com/bitcoin/bitcoin/pull/10503
 9 2017-06-21 01:28:08	0|bitcoin-git|[13bitcoin] 15sipa pushed 5 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/efbcf2b1d5ff...b3eb0d648551
10 2017-06-21 01:28:09	0|bitcoin-git|13bitcoin/06master 143533fb4 15Matt Corallo: Return a bool in SpendCoin to restore pre-per-utxo assert semantics...
11 2017-06-21 01:28:09	0|bitcoin-git|13bitcoin/06master 14ec1271f 15Matt Corallo: Remove useless mapNextTx lookup in CTxMemPool::TrimToSize....
12 2017-06-21 01:28:10	0|bitcoin-git|13bitcoin/06master 14f58349c 15Matt Corallo: Restore some assert semantics in sigop cost calculations...
13 2017-06-21 01:28:41	0|bitcoin-git|[13bitcoin] 15sipa closed pull request #10537: Few Minor per-utxo assert-semantics re-adds and tweak (06master...062017-06-per-utxo-fixes) 02https://github.com/bitcoin/bitcoin/pull/10537
14 2017-06-21 11:22:51	0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #10642: Use the _MSC_VER macro only if it is defined (06master...06undefined-msc-ver) 02https://github.com/bitcoin/bitcoin/pull/10642
15 2017-06-21 12:54:27	0|bitcoin-git|[13bitcoin] 15laanwj pushed 4 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/b3eb0d648551...d083bd9b9c52
16 2017-06-21 12:54:28	0|bitcoin-git|13bitcoin/06master 143ec5ad8 15Andrew Chow: Add test for rpcuser/rpcpassword
17 2017-06-21 12:54:28	0|bitcoin-git|13bitcoin/06master 14c53c983 15Andrew Chow: Replace cookie auth in tests...
18 2017-06-21 12:54:29	0|bitcoin-git|13bitcoin/06master 14279fde5 15Andrew Chow: Check for rpcuser/rpcpassword first then for cookie...
19 2017-06-21 12:55:03	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10533: [tests] Use cookie auth instead of rpcuser and rpcpassword (06master...06tests-use-cookie-auth) 02https://github.com/bitcoin/bitcoin/pull/10533
20 2017-06-21 14:35:53	0|bitcoin-git|[13bitcoin] 15rexuslexus opened pull request #10643: TestCoin 0.0.1 (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/10643
21 2017-06-21 14:36:48	0|bitcoin-git|[13bitcoin] 15rexuslexus closed pull request #10643: TestCoin 0.0.1 (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/10643
22 2017-06-21 17:43:00	0|achow101|anyone know what's up with travis failing on #10637?
23 2017-06-21 17:43:01	0|gribble|https://github.com/bitcoin/bitcoin/issues/10637 | Coin Selection with Murchs algorithm by achow101 · Pull Request #10637 · bitcoin/bitcoin · GitHub
24 2017-06-21 18:06:16	0|jonasschnelli|achow101: unknown location(0): fatal error: in "coin_selection_tests/bnb_search_test": std::out_of_range: vector::_M_range_check
25 2017-06-21 18:06:54	0|jonasschnelli|mempool_limit.py               | ✖ Failed  | 4 s
26 2017-06-21 18:06:58	0|jonasschnelli|fundrawtransaction.py          | ✖ Failed  | 12 s
27 2017-06-21 18:07:21	0|sipa|sounds like an out of bounds access of a vector
28 2017-06-21 18:07:25	0|jonasschnelli|The rpc test failures are reported here: https://travis-ci.org/bitcoin/bitcoin/jobs/245174021
29 2017-06-21 18:07:42	0|achow101|jonasschnelli: there's also a build failure too
30 2017-06-21 18:07:48	0|jonasschnelli|unknown location(0): fatal error: in "coin_selection_tests/bnb_search_test": signal: SIGABRT (application abort requested)
31 2017-06-21 18:08:06	0|jonasschnelli|test_bitcoin: key.cpp:292: void ECC_Start(): Assertion `secp256k1_context_sign == __null' failed.
32 2017-06-21 18:08:28	0|jonasschnelli|haven't spotted the build error so far
33 2017-06-21 18:08:35	0|achow101|it's in one of the other travis builds
34 2017-06-21 18:09:04	0|achow101|https://travis-ci.org/bitcoin/bitcoin/jobs/245174020
35 2017-06-21 18:09:09	0|gmaxwell|some of the builds run with instrumented STL that detect things like out of range accesses to vectors. (often accessing [0] in an empty vector.)
36 2017-06-21 18:09:23	0|jonasschnelli|achow101: I guess compiling on a Trusty 14.04 VM and valgrund/lldb|gdb could help
37 2017-06-21 18:09:35	0|jonasschnelli|*valgrind
38 2017-06-21 18:09:59	0|gmaxwell|you can skip the vm stuff and just run valgrind on your test, it'll likely turn it up.
39 2017-06-21 18:10:07	0|achow101|I'll try
40 2017-06-21 18:38:33	0|achow101|valgrind reported no problems
41 2017-06-21 18:39:01	0|jonasschnelli|achow101: OSX?
42 2017-06-21 18:39:14	0|achow101|no, on ubuntu 17.04
43 2017-06-21 18:39:27	0|achow101|I don't have a windows or osx machine readily available
44 2017-06-21 18:39:57	0|jonasschnelli|I had this before and IIRC I could also not reproduce some of the test failures... maybe VM Trusty 14.04
45 2017-06-21 18:41:05	0|jonasschnelli|achow101: maybe double check the travis build env (see what gmaxwell mentioned above "some of the builds run with instrumented STL")?
46 2017-06-21 18:47:51	0|gmaxwell|achow101: https://stackoverflow.com/questions/5594686/gcc-stl-bound-checking
47 2017-06-21 18:50:40	0|jonasschnelli|sipa: the txdb update skipper prework is here: https://github.com/bitcoin/bitcoin/compare/master...jonasschnelli:2017/06/chainstate_update_prog?expand=1
48 2017-06-21 18:50:58	0|jonasschnelli|The progress is fake..
49 2017-06-21 18:51:20	0|jonasschnelli|And it's a bit hackish... I hope someone has a better design for the callback
50 2017-06-21 18:52:08	0|jonasschnelli|I detected db corruption when building a UTXO db on regtest with 0.14.2 (generate 100) and then exit on ShutdownRequested() in CCoinsViewDB::Upgrade()
51 2017-06-21 18:52:26	0|jonasschnelli|* exit on master + the work above
52 2017-06-21 18:52:48	0|cfields|achow101: note that the last time this came up, it was an issue of: memcpy(foo, bar[0], 0), where bar was empty. Valgrind won't report it because the out-of-bounds memory isn't actually copied, but it's still a bad an idea to [0] an empty container.
53 2017-06-21 18:53:50	0|achow101|I'm pretty sure I don't have anything like that in my changes
54 2017-06-21 18:54:53	0|sipa|jonasschnelli: i recently fixed a bug that could cause that
55 2017-06-21 18:55:11	0|jonasschnelli|sipa: already merged? Then I guess I should retest
56 2017-06-21 18:55:18	0|sipa|jonasschnelli: a few days ago
57 2017-06-21 18:56:23	0|jonasschnelli|Not sure if the approach of a "c" keypress in splashscreen to abort the UTXO-set upgrade makes sense..
58 2017-06-21 18:56:29	0|jonasschnelli|Though adding buttons on splashscreen is – with the current design – cumbersome
59 2017-06-21 19:10:37	0|bitcoin-git|[13bitcoin] 15jonasschnelli opened pull request #10644: Slightly overhaul NSI pixmaps (06master...062017/06/cleanup) 02https://github.com/bitcoin/bitcoin/pull/10644
60 2017-06-21 19:13:00	0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #10645: Use nullptr instead of zero (0) as the null pointer constant (06master...06welcome-nullptr-goodbye-0) 02https://github.com/bitcoin/bitcoin/pull/10645
61 2017-06-21 19:23:30	0|achow101|it seems that the problem may be due to my use of long instead of CAmount in one of the tests I wrote
62 2017-06-21 19:24:40	0|sipa|jonasschnelli: what is the sleep for?
63 2017-06-21 19:24:48	0|jonasschnelli|sipa: dummy progress
64 2017-06-21 19:24:52	0|jonasschnelli|only to test
65 2017-06-21 19:25:20	0|sipa|oh
66 2017-06-21 19:25:31	0|jonasschnelli|jonasschnelli: you should add the right code and replace "progress += 0.00001;"
67 2017-06-21 19:25:46	0|jonasschnelli|Now I start to ping myself
68 2017-06-21 19:25:57	0|jonasschnelli|sipa: ... and remove the sleep
69 2017-06-21 19:26:57	0|sipa|you should not remove sleep from yourself
70 2017-06-21 19:27:09	0|sipa|or you'll end up doing things like pining yourself
71 2017-06-21 19:27:33	0|jonasschnelli|hahaa
72 2017-06-21 19:31:51	0|sipa|jonasschnelli: uh... nvm
73 2017-06-21 19:32:05	0|sipa|the bug i was talking about is in the non-atomic upgrade PR
74 2017-06-21 19:32:07	0|sipa|not in master
75 2017-06-21 19:32:41	0|jonasschnelli|okay. Because I just tested with master and still have the corruption..
76 2017-06-21 19:33:03	0|jonasschnelli|reminds me that we should have a strategy of how to test upgrades (chainstate-db, old wallet files) in functional tests
77 2017-06-21 19:33:03	0|sipa|:(
78 2017-06-21 19:33:25	0|sipa|that's very hard, unless you store an old version's chainstate inside the test..
79 2017-06-21 19:33:31	0|sipa|just logistically
80 2017-06-21 19:33:47	0|jonasschnelli|I think that would be the simplest solution.
81 2017-06-21 19:33:58	0|jonasschnelli|Compiling an old version will not be possible (at lest not in travis CI)
82 2017-06-21 19:34:33	0|sdaftuar|yeah its hard to get to work in travis, but not so hard conceptually to write the test in our test framework.  passing in a custom binary to a functional test works fine.
83 2017-06-21 19:34:36	0|jonasschnelli|I think having some test old blobs fixtures may be okay
84 2017-06-21 19:35:11	0|sdaftuar|i believe i wrote a test like this in p2p-segwit (before we supported modifying bip9 parameters on the command line)
85 2017-06-21 19:35:18	0|jonasschnelli|It's one of the most lacking things in our test framework (migrations)
86 2017-06-21 19:35:43	0|sipa|those blobs could even be dependencies (as in, for the depends framework)
87 2017-06-21 19:35:52	0|sipa|with known hashes, but downloaded at build time
88 2017-06-21 19:36:05	0|jonasschnelli|yes.. sure.
89 2017-06-21 19:36:23	0|jonasschnelli|Especially if they are large...
90 2017-06-21 19:36:53	0|jonasschnelli|for wallet files, I don't mind having a couple of 20kb bdb 4.8 files in our test framework