1 2017-07-07 00:06:45	0|bitcoin-git|[13bitcoin] 15TheBlueMatt opened pull request #10758: Fix some chainstate-init-order bugs. (06master...062014-07-nonatomic-flush-fixes) 02https://github.com/bitcoin/bitcoin/pull/10758
  2 2017-07-07 00:10:58	0|jtimon|jamesob just finally learning how to use docker on my own now. yeah, I think it could simplify development by not requiring to install the dependencies in your local system. perhaps it could help simplifying further the process for deterministic builds? maybe others prefer it on another repo, but I think it wouldn't hurt on contrib
  3 2017-07-07 00:11:05	0|jtimon|in contrib
  4 2017-07-07 00:11:59	0|jtimon|but I think you still need a VM for the deterministic builds...not sure
  5 2017-07-07 01:01:09	0|jamesob|jtimon: is the need for deterministic builds obviated by the hash related to each docker image build? i.e. can we reference a single docker image in lieu of doing the vm builds?
  6 2017-07-07 01:02:36	0|jtimon|no, I don't think docker's determinism is enough for bitcoin's deterministic builds is what I'm saying, but I'm no expert on either of them, just used them by following tutorials and reading other people's code
  7 2017-07-07 01:02:56	0|jamesob|gotcha
  8 2017-07-07 01:03:09	0|sipa|jamesob: i think we want to push it the other direction really... where the build becomes deterministic even when not run in any controlled environment
  9 2017-07-07 01:03:16	0|sipa|(apart from compiler versions)
 10 2017-07-07 01:03:59	0|jamesob|sipa: yeah, makes sense... relying on a single trusted image is probably the counterpoint to the purpose of the build process :)
 11 2017-07-07 01:04:22	0|sipa|jamesob: exactly
 12 2017-07-07 01:04:35	0|jtimon|right, the point is everyone creating the same image on their own
 13 2017-07-07 01:04:56	0|sipa|jamesob: and it's already the case for the OSX build pretty much (as it builds the compiler etc as part of the build process)
 14 2017-07-07 01:05:40	0|jamesob|ah interesting
 15 2017-07-07 01:06:02	0|jtimon|my doubt was if docker could maybe remove the need for a VM
 16 2017-07-07 01:06:40	0|sipa|isn't docker effectively creating a VM?
 17 2017-07-07 01:06:48	0|sipa|(/me docket noob)
 18 2017-07-07 01:06:51	0|jamesob|I think there may be promise there... running a single container is less memory consumptive than, say, virtualbox afaik
 19 2017-07-07 01:07:07	0|jamesob|and certainly much faster for anyone who has the docker daemon already running
 20 2017-07-07 01:07:07	0|sipa|no need for virtualbox
 21 2017-07-07 01:07:46	0|jtimon|I mean, in the deterministic build tutorial for bitcoin, which I found easy to follow, you are required to create a debian vm
 22 2017-07-07 01:08:19	0|jtimon|perhaps that's just good habit, but it looked like a requirement
 23 2017-07-07 01:08:20	0|sipa|sure, because that's easiest to make sure the environment matches
 24 2017-07-07 01:08:39	0|sipa|but you can just use typical desktop linux environments as host
 25 2017-07-07 01:08:42	0|jtimon|well, that's where I wonder if docker could simplify things
 26 2017-07-07 01:09:05	0|sipa|i'm sure it can simlify things
 27 2017-07-07 01:09:24	0|sipa|but i'm questioning how it could replace the need for a VM... when (afaik) it internally runs things in a VM
 28 2017-07-07 01:09:28	0|jtimon|just use debian:jessie container or something
 29 2017-07-07 01:09:41	0|jamesob|jtimon right
 30 2017-07-07 01:10:42	0|jamesob|sipa docker is almost closer to a chroot than a VM IMO
 31 2017-07-07 01:11:03	0|sipa|jamesob: so is LXC
 32 2017-07-07 01:11:23	0|sipa|gitian right now has no need for a VM anywhere
 33 2017-07-07 01:11:29	0|jamesob|yep -- I think docker used to ride on top of LXC; think they may have ditched it recently
 34 2017-07-07 01:11:37	0|jamesob|gotcha
 35 2017-07-07 01:12:14	0|sipa|the instructions tell you to create a debian VM because that's an easy way to get a system in a simple to describe state
 36 2017-07-07 01:12:50	0|sipa|so if you can simplify that process with docker, feel free
 37 2017-07-07 01:13:24	0|jamesob|cool, I'll take a look
 38 2017-07-07 01:13:58	0|sipa|but at this point, i think can't avoid gitian
 39 2017-07-07 01:14:10	0|sipa|so you'd describe some docker system in which gitian can be run
 40 2017-07-07 01:15:06	0|jtimon|jamesob: yeah, if you modify the gitian guide to use docker instead of a VM and hopefully having to copy and paste less things I will be more than happy to try it locally
 41 2017-07-07 01:16:08	0|jtimon|https://github.com/bitcoin/bitcoin/blob/master/doc/gitian-building.md
 42 2017-07-07 01:17:53	0|jtimon|mhmm, "LXC, see also Gitian host docker container[ https://github.com/gdm85/tenku/blob/master/docker/gitian-bitcoin-host/README.md ] .
 43 2017-07-07 01:19:00	0|jtimon|perhaps that last link is what we're talking about and it's already done? then why the VM ?
 44 2017-07-07 01:48:08	0|grubles|i think that is out of date (2015). i tried following it the other day and it seems some of the scripts are maybe in the wrong directories? (https://github.com/gdm85/tenku/blob/master/docker/gitian-bitcoin-host/scripts/spawn-gitian-bitcoin-host.sh in particular 404s as it is in the wrong dir)
 45 2017-07-07 02:06:29	0|bitcoin-git|[13bitcoin] 15TheBlueMatt opened pull request #10759: Fix multi_rpc test for hosts that dont default to utf8 (06master...062017-07-fix-mult-rpc-test) 02https://github.com/bitcoin/bitcoin/pull/10759
 46 2017-07-07 07:56:13	0|bitcoin-git|[13bitcoin] 15sipa opened pull request #10760: Avoid dereference-of-casted-pointer (06master...0620170707_avoidcastptr) 02https://github.com/bitcoin/bitcoin/pull/10760
 47 2017-07-07 08:13:07	0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #10761: [tests] fix replace_by_fee.py (06master...06fix_replace_by_fee) 02https://github.com/bitcoin/bitcoin/pull/10761
 48 2017-07-07 09:57:19	0|jonasschnelli|For your info: promag (João Barbosa) does – AFAIK – work on reviewing stuff pretty much fulltime (he has just started, giving him some direction would be good in genereal I guess)
 49 2017-07-07 10:04:19	0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #10762: [WIP] Remove Wallet dependencies from init.cpp (06master...06walletinit) 02https://github.com/bitcoin/bitcoin/pull/10762
 50 2017-07-07 10:06:38	0|wumpus|jonasschnelli: cool
 51 2017-07-07 10:07:21	0|jonasschnelli|Lets just hope he doesn't loose endurance. :)
 52 2017-07-07 11:16:47	0|bitcoin-git|13bitcoin/06master 149bbf600 15darksh1ne: Use method name from __func__ macro...
 53 2017-07-07 11:16:47	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/5af657253498...ed88e3194c4b
 54 2017-07-07 11:16:48	0|bitcoin-git|13bitcoin/06master 14ed88e31 15MarcoFalke: Merge #10744: Use method name via __func__ macro...
 55 2017-07-07 11:17:21	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #10744: Use method name via __func__ macro (06master...06patch-2) 02https://github.com/bitcoin/bitcoin/pull/10744
 56 2017-07-07 11:28:35	0|bitcoin-git|13bitcoin/06master 14301fd51 15John Newbery: [tests] fix replace_by_fee.py...
 57 2017-07-07 11:28:35	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/ed88e3194c4b...d3b58704d1d3
 58 2017-07-07 11:28:36	0|bitcoin-git|13bitcoin/06master 14d3b5870 15MarcoFalke: Merge #10761: [tests] fix replace_by_fee.py...
 59 2017-07-07 11:29:04	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #10761: [tests] fix replace_by_fee.py (06master...06fix_replace_by_fee) 02https://github.com/bitcoin/bitcoin/pull/10761
 60 2017-07-07 11:32:07	0|bitcoin-git|13bitcoin/06master 14bc7d103 15Matt Corallo: Fix multi_rpc test for hosts that dont default to utf8...
 61 2017-07-07 11:32:07	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/d3b58704d1d3...1d4805ce0464
 62 2017-07-07 11:32:08	0|bitcoin-git|13bitcoin/06master 141d4805c 15MarcoFalke: Merge #10759: Fix multi_rpc test for hosts that dont default to utf8...
 63 2017-07-07 11:32:36	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #10759: Fix multi_rpc test for hosts that dont default to utf8 (06master...062017-07-fix-mult-rpc-test) 02https://github.com/bitcoin/bitcoin/pull/10759
 64 2017-07-07 11:55:33	0|jonasschnelli|Anyone know why I get this liner error in travis (doesn't happen with clang): https://travis-ci.org/bitcoin/bitcoin/jobs/246110728#L2103
 65 2017-07-07 11:55:46	0|jonasschnelli|Seems like a cirular dependency thing
 66 2017-07-07 11:55:51	0|jonasschnelli|*circular
 67 2017-07-07 11:56:12	0|jonasschnelli|HTTPReq_JSONRPC is implemented in httprpc.cpp which is part of bitcoind ....
 68 2017-07-07 12:17:20	0|wumpus|HTTPReq_JSONRPC is part of libbitcoin_server_a, which is valid to be used from wallet code
 69 2017-07-07 12:17:24	0|wumpus|I don't get the error either
 70 2017-07-07 12:18:39	0|jonasschnelli|Also have it on my Trusty 14.04 VM with gcc
 71 2017-07-07 12:19:02	0|jonasschnelli|maybe a bug with the function typedef
 72 2017-07-07 12:19:22	0|jonasschnelli|Question: what to do with the hybrid rpc calls (in terms of untangling the endpoints)...
 73 2017-07-07 12:19:29	0|wumpus|well the circular dependency between libbitcoin_server and libbitcoin_wallet, as you say
 74 2017-07-07 12:20:04	0|jonasschnelli|Example: I have set now signrawtx to the /v1/node side... but somehow you also want to be able to choose the wallet used for that call..
 75 2017-07-07 12:20:09	0|wumpus|I'd just ignore getinfo for the endpoints, we want to deprecate that anyway
 76 2017-07-07 12:20:26	0|wumpus|signrawtx maybe put it both on the node endpoint as the wallet endpoints?
 77 2017-07-07 12:20:32	0|wumpus|I don't know
 78 2017-07-07 12:20:33	0|jonasschnelli|Yes. Think so.
 79 2017-07-07 12:20:47	0|jonasschnelli|Maybe endpoint = "/v1/*" for now
 80 2017-07-07 12:25:11	0|jonasschnelli|The linker error: it's only test_bitcoin that has the linker error
 81 2017-07-07 12:33:32	0|wumpus|does test_bitcoin somehow link in a different order?
 82 2017-07-07 12:38:37	0|jonasschnelli|I don't know. Could it be some boost internal fixture template thing?
 83 2017-07-07 12:39:01	0|jonasschnelli|I guess no
 84 2017-07-07 12:40:34	0|jonasschnelli|wumpus: does the link order matters? see: https://0bin.net/paste/YVZoBu2vaap8-chr#wW2b3kICZ5rpRwZwvsTpxWJDeFIbrLM3Ng9OQYi24dY
 85 2017-07-07 12:44:03	0|jonasschnelli|wumpus: the only thing thats may be different for test_bitcoin is that we pass in a --static (but should not matter IMO)
 86 2017-07-07 12:50:38	0|bitcoin-git|[13bitcoin] 15ReneNyffenegger opened pull request #10764: Tests: address placement should be deterministic by default (06master...06test-addrman) 02https://github.com/bitcoin/bitcoin/pull/10764
 87 2017-07-07 13:11:28	0|bitcoin-git|[13bitcoin] 15fanquake closed pull request #10764: Tests: address placement should be deterministic by default (06master...06test-addrman) 02https://github.com/bitcoin/bitcoin/pull/10764
 88 2017-07-07 13:49:44	0|wumpus|link order matters, when linking static libraries. The libraries that need symbols should come before the library it needs symbols from
 89 2017-07-07 13:50:55	0|wumpus|so the most general libraries (such as utilities etc) should end up last, the more specific ones first. This is complicated by circular dependencies, in which case it's pretty much a gamble whether it works.
 90 2017-07-07 13:51:25	0|wumpus|(it's linker dependent, so it makes sense that you see differences between OSes)
 91 2017-07-07 14:00:11	0|jonasschnelli|wumpus: oh, if I move $(LIBBITCOIN_WALLET) in front of $(LIBBITCOIN_SERVER) (in test_bitcoin) it works...
 92 2017-07-07 14:16:56	0|bitcoin-git|[13bitcoin] 15ReneNyffenegger opened pull request #10765: Tests: address placement should be deterministic by default (06master...06test-addrman) 02https://github.com/bitcoin/bitcoin/pull/10765
 93 2017-07-07 14:44:37	0|jonasschnelli|Passes travis now https://github.com/bitcoin/bitcoin/pull/10650/commits/386c299270cd955aebc7984b319805ac7403e906
 94 2017-07-07 14:48:45	0|wumpus|great!
 95 2017-07-07 15:00:27	0|bitcoin-git|[13bitcoin] 15ReneNyffenegger opened pull request #10766: Building Environment: Set ARFLAGS to cr (06master...06ARFLAGS) 02https://github.com/bitcoin/bitcoin/pull/10766
 96 2017-07-07 15:00:29	0|jonasschnelli|wumpus: have you made any thought on #10251? Should I reduce it to the CWallet only cache (remove the GUI stuff)?
 97 2017-07-07 15:00:31	0|gribble|https://github.com/bitcoin/bitcoin/issues/10251 | Add balances cache / GUI: use a signal instead of a poll thread by jonasschnelli · Pull Request #10251 · bitcoin/bitcoin · GitHub
 98 2017-07-07 15:05:13	0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #10767: Clarify wallet initialization / destruction interface (06master...06walletinit2) 02https://github.com/bitcoin/bitcoin/pull/10767
 99 2017-07-07 15:34:08	0|bitcoin-git|[13bitcoin] 15ReneNyffenegger opened pull request #10768: Build System: Prevent warning about "maybe uninitialized variable" nStart in init.cpp (06master...06init-nStart) 02https://github.com/bitcoin/bitcoin/pull/10768
100 2017-07-07 17:03:12	0|spudowiar|What's the best way to check if a CTransaction is the same, apart from any scriptSigs?
101 2017-07-07 17:03:20	0|spudowiar|e.g. Compare a signed transaction to an unsigned transaction
102 2017-07-07 17:04:46	0|instagibbs|spudowiar, strip scriptsig/witness data and compare
103 2017-07-07 17:39:14	0|instagibbs|anyone know a good trick to figure out where bitcoind is spending it's time in? gdb attaching just gets me to the WaitForShutdown loop
104 2017-07-07 17:39:40	0|instagibbs|looking at valgrind's callgrind but not sure if that's the right tool for what I'm looking for
105 2017-07-07 17:41:49	0|gmaxwell|instagibbs: you're hung on shutdown and trying to find out where or?
106 2017-07-07 17:42:03	0|gmaxwell|instagibbs: are you looking at all threads when you connect with gdb?
107 2017-07-07 17:42:10	0|sipa|threall apply all bt
108 2017-07-07 17:42:13	0|instagibbs|no, spikes in cpu usage fairly consistently on one machine
109 2017-07-07 17:42:17	0|gmaxwell|thread apply all bt
110 2017-07-07 17:42:19	0|instagibbs|sipa, thanks just found via googling
111 2017-07-07 17:56:09	0|midnightmagic|hrm. I thought there was another shortcut for that command.. like bt all or something.
112 2017-07-07 18:21:00	0|spudowiar|instagibbs: Is there a utility function to do that or must I write it myself? :)
113 2017-07-07 18:22:49	0|instagibbs|don't think there's a utility function, although you could make one and upstream it for use in various places.
114 2017-07-07 18:23:44	0|spudowiar|I'll leave it for now. But I want to add it later to check whether the hardware wallet returned the correct transaction
115 2017-07-07 19:28:04	0|jonasschnelli|Hmm.. why does the Gui still changes the global payTxFee when fiddling with the fee slider? I though we have fixed this,.. or is this intentional?
116 2017-07-07 19:28:50	0|jonasschnelli|Maybe correct: we just set it to 0 when smartFees (the slider -> estimations) are enabled.
117 2017-07-07 19:59:52	0|BlueMatt|oh shit #10651 needs to go for 15... sipa what are your thoughts on loop/array/shell garbage?
118 2017-07-07 19:59:54	0|gribble|https://github.com/bitcoin/bitcoin/issues/10651 | Verify binaries from bitcoincore.org and bitcoin.org by TheBlueMatt · Pull Request #10651 · bitcoin/bitcoin · GitHub
119 2017-07-07 20:08:18	0|bitcoin-git|[13bitcoin] 15jonasschnelli opened pull request #10769: [Qt] replace fee slider with a Dropdown, extend conf. targets (06master...062017/07/qt_fee_slider) 02https://github.com/bitcoin/bitcoin/pull/10769
120 2017-07-07 20:09:12	0|jonasschnelli|Added 0.15 milestone to 10651
121 2017-07-07 21:12:02	0|bitcoin-git|[13bitcoin] 15TheBlueMatt opened pull request #10770: Drop upgrade-cancel callback registration for a generic "cancelable" (06master...062017-07-upgrade-cancel-nits) 02https://github.com/bitcoin/bitcoin/pull/10770
122 2017-07-07 22:17:54	0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #10771: Remove unused variables in shell scripts (06master...06unused-shell-variables) 02https://github.com/bitcoin/bitcoin/pull/10771
123 2017-07-07 22:42:14	0|spudowiar|Right, I'm going to have to change a lot of the RPC stuff to support hardware wallets