1 2017-07-10 05:18:51	0|bitcoin-git|[13bitcoin] 15practicalswift closed pull request #10776: Avoid unnecessary copying of non-cheaply-copied types (06master...06const-ref) 02https://github.com/bitcoin/bitcoin/pull/10776
  2 2017-07-10 05:39:35	0|gmaxwell|I wonder why non-conservative estimator on my node here says 11s/b for 6 blocks, my mempool suggests thats enough to get in the current block ... and 21inc says 80 for 6 blocks and 280 for now.
  3 2017-07-10 05:46:31	0|aj|gmaxwell: some (1 in 6 by hashpower?) pools are mining empty blocks and ignoring transactions under 20s/b?
  4 2017-07-10 05:50:53	0|gmaxwell|ah, that would be not very helpful for the estimators.
  5 2017-07-10 05:52:45	0|gmaxwell|yea, bitcoin.com censored my transaction, indeed.
  6 2017-07-10 05:55:10	0|gmaxwell|looks like thats actually costing them a lot of fees.
  7 2017-07-10 05:57:26	0|gmaxwell|Kano's not a censor, hurray
  8 2017-07-10 06:42:18	0|rodarmor|How will a current bitcoin core node interpret a block with a transaction whose version is greater than CURRENT_VERSION? I can see in the code that it's used for relay policy, and for BIP68 enforcement, is that it?
  9 2017-07-10 06:48:57	0|sipa|correct
 10 2017-07-10 06:52:39	0|rodarmor|sipa: Sweet, thanks!
 11 2017-07-10 08:05:01	0|dcousens|BlueMatt: are you sure about the std::move breaking the CFeeBumper code?
 12 2017-07-10 08:05:17	0|dcousens|IIRC std::move on a const& simply _doesn't_ move, unless it can guarantee safety
 13 2017-07-10 08:06:08	0|sipa|it casts to a const&&
 14 2017-07-10 08:06:32	0|sipa|std::move never moves; it just casts it to an rvalue
 15 2017-07-10 08:07:05	0|sipa|which indicates to wherever it's passed that it does not maintain the state
 16 2017-07-10 08:07:27	0|sipa|const&& almost always means it's not going to be touched
 17 2017-07-10 08:07:46	0|dcousens|sipa: right, non-issue ?
 18 2017-07-10 08:08:19	0|dcousens|(sipa: referencing https://github.com/bitcoin/bitcoin/pull/10776/files#r126318388)
 19 2017-07-10 08:12:45	0|dcousens|I don't see && constructor in the uint256, I think the PR could be re-opened
 20 2017-07-10 08:13:32	0|dcousens|(aka, what happens appear to be at face value, nothing out there)
 21 2017-07-10 11:04:25	0|luke-jr|thoughts? http://codepad.org/F8Kata4K
 22 2017-07-10 12:46:39	0|bitcoin-git|[13bitcoin] 15ReneNyffenegger opened pull request #10782: Use AC_ARG_VAR to set ARFLAGS (06master...06ARFLAGS-AC_ARG_VAR) 02https://github.com/bitcoin/bitcoin/pull/10782
 23 2017-07-10 13:34:06	0|jnewbery|Can I get #10711 added to https://github.com/bitcoin/bitcoin/projects/8 ? It's a test framework enhancement so not super urgent, but it moves quite a lot of code within test/functional/test_framework so I'd like to avoid too many rebases.
 24 2017-07-10 13:34:08	0|gribble|https://github.com/bitcoin/bitcoin/issues/10711 | [tests] Introduce TestNode by jnewbery · Pull Request #10711 · bitcoin/bitcoin · GitHub
 25 2017-07-10 13:34:39	0|jnewbery|It also reduces the time to run the functional test suite by about 25%, so it's quite a nice one to have.
 26 2017-07-10 13:43:58	0|BlueMatt|dcouin that case it is practically not an issue, but it is also very unsafe code
 27 2017-07-10 14:18:42	0|promag|morcos: are you planning to work on #9447?
 28 2017-07-10 14:18:44	0|gribble|https://github.com/bitcoin/bitcoin/issues/9447 | Allow 2 simultaneous block downloads by morcos · Pull Request #9447 · bitcoin/bitcoin · GitHub
 29 2017-07-10 14:19:21	0|bitcoin-git|[13bitcoin] 15laanwj reopened pull request #10753: test: Check RPC argument mapping (06master...062017_07_rpc_argument_check) 02https://github.com/bitcoin/bitcoin/pull/10753
 30 2017-07-10 14:26:02	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10745: Be consistent in using "opt_into_rbf" parameter for Opt-In RBF (06master...06opt_in_rbf-param) 02https://github.com/bitcoin/bitcoin/pull/10745
 31 2017-07-10 14:31:19	0|wumpus|jnewbery: sure
 32 2017-07-10 14:33:07	0|wumpus|jnewbery: done
 33 2017-07-10 14:41:37	0|BlueMatt|promag: I believe I told morcos I'd take that over
 34 2017-07-10 14:41:49	0|BlueMatt|I havent done anythong on it except for rebase the first few commits, however
 35 2017-07-10 14:42:12	0|BlueMatt|see #10652
 36 2017-07-10 14:42:13	0|gribble|https://github.com/bitcoin/bitcoin/issues/10652 | Small step towards demangling cs_main from CNodeState by TheBlueMatt · Pull Request #10652 · bitcoin/bitcoin · GitHub
 37 2017-07-10 14:42:19	0|promag|In #0652?
 38 2017-07-10 14:42:22	0|gribble|https://github.com/bitcoin/bitcoin/issues/0652 | Update contrib/debian/ for 0.5.0 release and fix copyright file. by TheBlueMatt · Pull Request #652 · bitcoin/bitcoin · GitHub
 39 2017-07-10 14:42:28	0|promag|ops, yeah
 40 2017-07-10 14:43:29	0|promag|BlueMatt: I have some nits for that PR, I can push to a branch and later you can rebase on that, wdyt?
 41 2017-07-10 14:45:17	0|BlueMatt|hmm? no, I havent yet taken it any further than that pr
 42 2017-07-10 14:46:14	0|BlueMatt|i plan to, but if you want to rewrite it, feel free
 43 2017-07-10 14:46:28	0|promag|kk
 44 2017-07-10 14:52:00	0|BlueMatt|promag: you almost certainly want to use 10652 as a base, fwiw, building on top of that should be easier, but its still a very thorny area
 45 2017-07-10 14:54:15	0|promag|BlueMatt: should we close 9447?
 46 2017-07-10 14:56:50	0|BlueMatt|no rush, but probably
 47 2017-07-10 14:56:56	0|BlueMatt|i mean open something to replace it first
 48 2017-07-10 15:03:23	0|morcos|promag: yeah, i'm fine if you or bluematt want to take it over, i just left it open b/c i feel we might still want it
 49 2017-07-10 15:06:50	0|instagibbs|wumpus, how annoyed would you be if I opened a PR that future-proofed rpc calls against failure to check isNull if additional arguments are added(as well as fixing named arg calls in a couple places)
 50 2017-07-10 15:36:58	0|wumpus|instagibbs: a lot of cleanup in regard to named argument handling needs to be done, all over the place, biggest issue is that intermediate nulls are not handled as default value by most calls
 51 2017-07-10 15:37:45	0|wumpus|instagibbs: in any case it seems too late for that for 0.15, but would be a nice goal for 0.16 to get that consistant
 52 2017-07-10 15:51:16	0|instagibbs|With only a few dozen easy to review line changes I think we can catch most of it for 0.15.
 53 2017-07-10 15:51:56	0|bitcoin-git|13bitcoin/06master 1458e9864 15John Newbery: [rpc] fix verbose argument for getblock in bitcoin-cli
 54 2017-07-10 15:51:56	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/1d4805ce0464...9edda0c5f5f2
 55 2017-07-10 15:51:57	0|bitcoin-git|13bitcoin/06master 149edda0c 15Wladimir J. van der Laan: Merge #10747: [rpc] fix verbose argument for getblock in bitcoin-cli...
 56 2017-07-10 15:52:26	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10747: [rpc] fix verbose argument for getblock in bitcoin-cli (06master...06fix_getblock_verbose_argument) 02https://github.com/bitcoin/bitcoin/pull/10747
 57 2017-07-10 16:00:43	0|wumpus|instagibbs: we already have so much to review before 0.15
 58 2017-07-10 16:01:14	0|instagibbs|I won't twist anyone's arm, and is easy to keep rebased, no worries
 59 2017-07-10 16:02:08	0|bitcoin-git|[13bitcoin] 15instagibbs opened pull request #10783: [RPC] Various rpc argument fixes (06master...06rpcargfixes) 02https://github.com/bitcoin/bitcoin/pull/10783
 60 2017-07-10 16:04:47	0|rhavar|murch: I was direct to ask you, is there a coin selection simulator I can use?
 61 2017-07-10 16:05:03	0|Murch|Hi Ryan
 62 2017-07-10 16:05:20	0|rhavar|I have an algorithm written in minizinc which I'd like to compare against the other stuff
 63 2017-07-10 16:05:21	0|Murch|I have a Scala simulator on Github which I used for my Master's thesis
 64 2017-07-10 16:05:29	0|rhavar|got a link?
 65 2017-07-10 16:05:40	0|rhavar|or is it private?
 66 2017-07-10 16:05:42	0|Murch|https://github.com/Xekyo/CoinSelectionSimulator
 67 2017-07-10 16:06:41	0|Murch|rhavar: Professional curiosity, what is the main idea of your selection strategy?
 68 2017-07-10 16:07:29	0|Murch|Also, if your spending patterns are still similar to moneypot, the scenario in the Simulator will simulate for your usecase. ;)
 69 2017-07-10 16:07:50	0|rhavar|Murch: https://gist.github.com/RHavar/0710144c713033d42f8f443a99fefbb7
 70 2017-07-10 16:07:52	0|rhavar|That's it in English
 71 2017-07-10 16:08:05	0|rhavar|I have the minizinc version if you're interested and keep it private :P
 72 2017-07-10 16:09:38	0|rhavar|murch: btw the dataset you're using is actually from bustabit not moneypot
 73 2017-07-10 16:09:52	0|rhavar|The project used to be called moneypot, but was renamed to bustabit
 74 2017-07-10 16:09:59	0|Murch|oh okay
 75 2017-07-10 16:10:07	0|rhavar|Then I created a totally unrelated project, and called it moneypot rofl
 76 2017-07-10 16:10:09	0|rhavar|(and then sold it)
 77 2017-07-10 16:10:24	0|rhavar|If you want, i can give you a lot more data for your dataset
 78 2017-07-10 16:11:32	0|Murch|rhavar: I would be very interested in that.
 79 2017-07-10 16:12:06	0|Murch|Especially amounts + fee levels would be exciting, as I could then start researching the effect of dynamic fee levels.
 80 2017-07-10 16:12:31	0|Murch|(fee levels for the outgoing transactions)
 81 2017-07-10 16:13:24	0|Murch|rhavar: So, I read your description, it seems to me that you only define the fitness function and then have some sort of optimizer solve it for you?
 82 2017-07-10 16:13:31	0|Murch|That's an interesting approach. :)
 83 2017-07-10 16:13:35	0|rhavar|Murch: correct yeah
 84 2017-07-10 16:15:12	0|Murch|Where does the "*10000" come from?
 85 2017-07-10 16:15:43	0|Murch|Is that a fee rate of 10k satoshi/Byte?
 86 2017-07-10 16:16:49	0|rhavar|No, that's just to break ties
 87 2017-07-10 16:16:57	0|Murch|oh, I see
 88 2017-07-10 16:16:57	0|rhavar|Its just a useless number
 89 2017-07-10 16:17:07	0|rhavar|It's so that things with more "optional outputs" are picked
 90 2017-07-10 16:17:12	0|rhavar|(if the fitness is the same)
 91 2017-07-10 16:17:39	0|Murch|Did you see achow101's push to get my Branch and Bound algorithm into Core?
 92 2017-07-10 16:18:02	0|Murch|Ah, thanks, I just realized that you don't work with a fixed set of outputs but optional number of outputs
 93 2017-07-10 16:18:02	0|rhavar|I heard of it, but I haven't looked at the code
 94 2017-07-10 16:18:16	0|rhavar|Murch: well that's for the future
 95 2017-07-10 16:18:21	0|rhavar|At the moment, i do
 96 2017-07-10 16:18:42	0|rhavar|But i'm using this strategy for queued withdrawals (in next release) i think it'll give a lot better results
 97 2017-07-10 16:18:45	0|rhavar|https://github.com/Xekyo/CoinSelectionSimulator/pull/6/files
 98 2017-07-10 16:19:23	0|rhavar|I don't have the feerates, or an easy way to query it. But I can give you the txid's if you sanitize the data before publishing
 99 2017-07-10 16:19:50	0|Murch|rhavar: wow, awesome :DDD
100 2017-07-10 16:20:35	0|Murch|I'm interested, and can do that, but I have a meeting in 40 min, can I get back to you later? :)
101 2017-07-10 16:20:40	0|rhavar|sure
102 2017-07-10 16:23:25	0|rhavar|Murch: If you can, can you update your README.md with installation / run instructions?
103 2017-07-10 16:23:40	0|rhavar|I'll add my minizinc one if you make it easy enough for me :P
104 2017-07-10 16:25:03	0|Murch|Okay, will do.
105 2017-07-10 16:26:57	0|Murch|Cliffnotes for the moment, you need to setup Scala, compile the Scala code and then run 'coinselection.Simulation'
106 2017-07-10 16:28:10	0|Chris_Stewart_5|Murch: Do you use sbt?
107 2017-07-10 16:29:52	0|Murch|Chris_Stewart_5: I cleaned up the repo at some point to use the sbt standard structure
108 2017-07-10 16:30:08	0|Murch|I'm not sure if I ever tried it out
109 2017-07-10 16:31:57	0|sipa|cliffnotes?
110 2017-07-10 16:32:41	0|Chris_Stewart_5|rhavar: You should be able to download sbt (scala build tool) from this link and then run 'sbt test' in the root directory for Murch's project
111 2017-07-10 16:32:44	0|Chris_Stewart_5|http://www.scala-sbt.org/download.html
112 2017-07-10 16:33:06	0|Murch|sipa: A short summary of a book
113 2017-07-10 16:33:40	0|BlueMatt|(used by american students to cheat by allowing them to "read the cliffnotes" instead of the book)
114 2017-07-10 16:33:51	0|rhavar|(In English class they make you read books and then write about it. But only suckers actually read the book, everyone else reads the cliffnotes)
115 2017-07-10 16:33:54	0|Chris_Stewart_5|I just tried it and it works (well one test fails for me) but whatever
116 2017-07-10 16:34:27	0|Murch|Mh, I'll have to look into it, thanks Chris
117 2017-07-10 16:34:35	0|sipa|Murch: ok, what does it mean in this context?
118 2017-07-10 16:34:41	0|rhavar|"summary"
119 2017-07-10 16:35:04	0|sipa|i'm still confused
120 2017-07-10 16:35:12	0|Murch|rhavar wanted to know how to run my project, and I was giving a summary, because I don't have time right now to write a set of instructions in full
121 2017-07-10 16:35:20	0|rhavar|sipa: It's just a way of saying: "The short version is..."
122 2017-07-10 16:35:23	0|Murch|rhavar wanted to use my coinselectionsimulator
123 2017-07-10 16:35:30	0|sipa|ah, ok
124 2017-07-10 16:38:28	0|sipa|i missed that it was the answer to a question
125 2017-07-10 16:39:09	0|Chris_Stewart_5|the fourth explanation is where you sick of studying a particular class's notes, so you find the nearest cliff and toss them off of it :P
126 2017-07-10 16:39:30	0|BlueMatt|+1
127 2017-07-10 17:16:19	0|midnightmagic|Origin is an actual series of book summaries *called* cliffnotes, as an academia short-circuit-to-study, and that company was named after an actual guy named cliff who started it.
128 2017-07-10 17:28:57	0|Murch|oh, @rhavar and anyone else running Coin Selection Simulations. You will probably not want to run with all strategies at the same time as especially the Bitcoin Core based selection takes quite a lot of computation time.
129 2017-07-10 17:29:16	0|Murch|If you run all strategies at the same time, my home desktop would take about four days.
130 2017-07-10 17:42:23	0|Murch|rhavar: Regarding the full set of the transactions. Thank you for the offer. I'm thinking that I might get back later to you regarding that set, as I'd first have to change my simulator to work with changing fee levels for the first place. For the moment having a much bigger set to play with is already pretty awesome.
131 2017-07-10 18:26:47	0|bitcoin-git|[13bitcoin] 15TheBlueMatt opened pull request #10784: Do not allow users to get keys from keypool without reserving them (06master...062017-07-keep-change) 02https://github.com/bitcoin/bitcoin/pull/10784
132 2017-07-10 18:29:49	0|bitcoin-git|[13bitcoin] 15sipa opened pull request #10785: Serialization improvements (06master...0620170707_noncastserial) 02https://github.com/bitcoin/bitcoin/pull/10785
133 2017-07-10 19:02:55	0|bitcoin-git|[13bitcoin] 15theuni closed pull request #10782: Use AC_ARG_VAR to set ARFLAGS (06master...06ARFLAGS-AC_ARG_VAR) 02https://github.com/bitcoin/bitcoin/pull/10782
134 2017-07-10 19:49:27	0|bitcoin-git|[13bitcoin] 15sipa opened pull request #10786: Add PR description to merge commit in github-merge.py (06master...0620170710_prbody) 02https://github.com/bitcoin/bitcoin/pull/10786