1 2017-07-18 00:28:35	0|bitcoin-git|[13bitcoin] 15jtimon opened pull request #10859: RPC: gettxout: Slightly improve doc and tests (06master...06b15-rpc-gettxout-mempool) 02https://github.com/bitcoin/bitcoin/pull/10859
  2 2017-07-18 01:07:47	0|Guest38971|lets say I wanted my node to support bip148. What do I need to configure in order to allow this? I am currently running bitcoin core 0.14.2 am I just ammending a line of code into the config file? I just need a reference if possible or is it advised to just wait for a release from bitcoin core?. I do not know if this is the proper channel for this so I apologize in advance. Thank you very much for the help.
  3 2017-07-18 01:11:22	0|sipa|Bitcoin Core at this point does not support BIP148
  4 2017-07-18 01:11:34	0|sipa|There are forks of the codebase that do.
  5 2017-07-18 01:22:59	0|Guest38971|Understood my question was hypethical.  My main concern is if I am running my node how can I test BIP148 suppost. I found a link that allows me to download bitcoin core with BIP148 support, but I did not know if this was trustworthy. Thank you
  6 2017-07-18 02:39:37	0|bitcoin-git|[13bitcoin] 15ryanofsky closed pull request #10829: Simple, backwards compatible RPC multiwallet support. (06master...06pr/multiparam) 02https://github.com/bitcoin/bitcoin/pull/10829
  7 2017-07-18 06:30:46	0|bitcoin-git|13bitcoin/06master 14077d01f 15Cory Fields: random: only use getentropy on openbsd
  8 2017-07-18 06:30:46	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/75b5643c47c3...81560b07ce8a
  9 2017-07-18 06:30:47	0|bitcoin-git|13bitcoin/06master 1481560b0 15Wladimir J. van der Laan: Merge #10855: random: only use getentropy on openbsd...
 10 2017-07-18 06:31:15	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10855: random: only use getentropy on openbsd (06master...06getentropy-openbsd) 02https://github.com/bitcoin/bitcoin/pull/10855
 11 2017-07-18 06:44:43	0|sipa|wumpus: how about a --sha256= option, which now defaults to basic, but can be changed to auto or a specific implementatio
 12 2017-07-18 06:44:46	0|sipa|?
 13 2017-07-18 06:46:16	0|wumpus|sipa: if you want to go that way, it needs to be future-proof to be able to add more sha algorithms in the future and select multiple, I guess
 14 2017-07-18 06:47:29	0|wumpus|that's why I proposed a a generic 'experimental assembly' flag, which is not so specific
 15 2017-07-18 06:47:40	0|wumpus|but sure, that makes sense
 16 2017-07-18 07:14:37	0|cfields|sipa: i think that's good to have either way. If nothing else, it makes benchmarking/comparing easier.
 17 2017-07-18 07:15:39	0|sipa|cfields: agree
 18 2017-07-18 07:16:29	0|gmaxwell|more complex is genreally less good because it's costly to test all the options.  --enable-expiremental-asm is also what we did in libsecp (and FWIW! how arm still is!)
 19 2017-07-18 07:21:36	0|sipa|gmaxwell: there are other advantages... like being able to run the tests and benchmarks on different hash function impls even if it's not the best available on your platform
 20 2017-07-18 07:22:48	0|wumpus|that doesn't need a compile time option
 21 2017-07-18 07:23:45	0|wumpus|e.g. bench could just cycle through all available sha algorithms
 22 2017-07-18 07:24:10	0|sipa|agree, like your branch did
 23 2017-07-18 07:24:24	0|wumpus|or some run-time override, if you want to do the other tests / a chain sync with it
 24 2017-07-18 07:24:43	0|wumpus|but maybe that's overkill to add an option for such a rare scenario
 25 2017-07-18 07:25:09	0|wumpus|but at least the tests should test all the possibilities (that run on the platform) I guess
 26 2017-07-18 07:25:13	0|sipa|wumpus: by --sha256 i meant a runtime option
 27 2017-07-18 07:25:20	0|wumpus|for basic sanity testing, not for running all tests
 28 2017-07-18 07:26:03	0|wumpus|okay
 29 2017-07-18 07:26:14	0|sipa|i'll keep it simple now
 30 2017-07-18 07:30:58	0|bitcoin-git|13bitcoin/06master 141fc8c3d 15Matt Corallo: No longer ever reuse keypool indexes...
 31 2017-07-18 07:30:58	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/81560b07ce8a...7b6e8bc44240
 32 2017-07-18 07:30:59	0|bitcoin-git|13bitcoin/06master 147b6e8bc 15Wladimir J. van der Laan: Merge #10795: No longer ever reuse keypool indexes...
 33 2017-07-18 07:31:06	0|sipa|wumpus: oh, i see, you meant a compile time option
 34 2017-07-18 07:31:08	0|sipa|ack
 35 2017-07-18 07:31:30	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10795: No longer ever reuse keypool indexes (06master...062017-07-wallet-keypool-overwrite) 02https://github.com/bitcoin/bitcoin/pull/10795
 36 2017-07-18 10:29:52	0|wumpus|yes, I meant a compile-time option, sorry for not being clear
 37 2017-07-18 12:04:37	0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #10862: Remove unused variable int64_t nEnd. Fix typo: "conditon" → "condition". (06master...06nEnd) 02https://github.com/bitcoin/bitcoin/pull/10862
 38 2017-07-18 13:07:52	0|bitcoin-git|[13bitcoin] 15corebob opened pull request #10863: Fix leaking a socket handle if call to SetSocketNonBlocking failed (06master...0620170718-fix-leak-1) 02https://github.com/bitcoin/bitcoin/pull/10863
 39 2017-07-18 13:13:22	0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #10864: Avoid redundant redeclaration of GetWarnings(const string&) (06master...06GetWarnings-in-warnings.h) 02https://github.com/bitcoin/bitcoin/pull/10864
 40 2017-07-18 13:28:54	0|bitcoin-git|[13bitcoin] 15corebob closed pull request #10863: Fix leaking a socket handle if call to SetSocketNonBlocking failed (06master...0620170718-fix-leak-1) 02https://github.com/bitcoin/bitcoin/pull/10863
 41 2017-07-18 14:33:17	0|bitcoin-git|[13bitcoin] 15corebob opened pull request #10865: Move CloseSocket out of SetSocketNonBlocking in netbase.cpp (06master...0620170718-refactor-1) 02https://github.com/bitcoin/bitcoin/pull/10865
 42 2017-07-18 14:50:03	0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #10866: Add mutex requirement for AddToCompactExtraTransactions(…) (06master...06lock-requirement-for-AddToCompactExtraTransactions) 02https://github.com/bitcoin/bitcoin/pull/10866
 43 2017-07-18 14:50:47	0|BlueMatt|wumpus: where did we land on freeze?
 44 2017-07-18 15:16:22	0|wumpus|#10849 and #10571 seem ready to go in
 45 2017-07-18 15:16:24	0|gribble|https://github.com/bitcoin/bitcoin/issues/10849 | Multiwallet: simplest endpoint support by jonasschnelli · Pull Request #10849 · bitcoin/bitcoin · GitHub
 46 2017-07-18 15:16:25	0|gribble|https://github.com/bitcoin/bitcoin/issues/10571 | [RPC]Move transaction combining from signrawtransaction to new RPC by achow101 · Pull Request #10571 · bitcoin/bitcoin · GitHub
 47 2017-07-18 15:16:38	0|wumpus|#10579 has missed the window imo
 48 2017-07-18 15:16:39	0|gribble|https://github.com/bitcoin/bitcoin/issues/10579 | [RPC] Split signrawtransaction into wallet and non-wallet RPC command by achow101 · Pull Request #10579 · bitcoin/bitcoin · GitHub
 49 2017-07-18 15:17:04	0|wumpus|same for #9502
 50 2017-07-18 15:17:07	0|gribble|https://github.com/bitcoin/bitcoin/issues/9502 | [Qt] Add option to pause/resume block downloads by jonasschnelli · Pull Request #9502 · bitcoin/bitcoin · GitHub
 51 2017-07-18 15:18:20	0|wumpus|I think the rest tagged for 0.15 qualifies as bug-fix, not feature
 52 2017-07-18 15:18:27	0|wumpus|BlueMatt: #10784 needs rebase btw
 53 2017-07-18 15:18:28	0|gribble|https://github.com/bitcoin/bitcoin/issues/10784 | Do not allow users to get keys from keypool without reserving them by TheBlueMatt · Pull Request #10784 · bitcoin/bitcoin · GitHub
 54 2017-07-18 15:19:16	0|bitcoin-git|[13bitcoin] 15laanwj pushed 7 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/7b6e8bc44240...bde4f937aebc
 55 2017-07-18 15:19:17	0|bitcoin-git|13bitcoin/06master 1431e0720 15Jonas Schnelli: Add wallet endpoint support to bitcoin-cli (-usewallet)
 56 2017-07-18 15:19:17	0|bitcoin-git|13bitcoin/06master 14dd2185c 15Jonas Schnelli: Register wallet endpoint
 57 2017-07-18 15:19:18	0|bitcoin-git|13bitcoin/06master 1432c9710 15Jonas Schnelli: Fix test_bitcoin circular dependency issue
 58 2017-07-18 15:20:07	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10849: Multiwallet: simplest endpoint support (06master...062017/07/mw_endpoint_simple) 02https://github.com/bitcoin/bitcoin/pull/10849
 59 2017-07-18 15:21:17	0|BlueMatt|wumpus: done
 60 2017-07-18 15:22:09	0|BlueMatt|wumpus: concept ack on 10571, I'm happy to see it merged now and I'll postumously ack it later today
 61 2017-07-18 15:22:42	0|wumpus|just found a bug in 10571
 62 2017-07-18 15:23:12	0|BlueMatt|heh, ok, nevermind, then
 63 2017-07-18 15:23:30	0|BlueMatt|no harm in pushing to 16 imo, no?
 64 2017-07-18 15:23:33	0|wumpus|a very minor one though just an error message
 65 2017-07-18 15:24:27	0|BlueMatt|up to you, we have a few weeks bugfix window anyway
 66 2017-07-18 15:25:21	0|wumpus|well it would be a waste with so many utacks, this is a trivial fix, will wait for achow101
 67 2017-07-18 15:28:55	0|wumpus|#10784 does need mention in release notes I guess
 68 2017-07-18 15:28:56	0|gribble|https://github.com/bitcoin/bitcoin/issues/10784 | Do not allow users to get keys from keypool without reserving them by TheBlueMatt · Pull Request #10784 · bitcoin/bitcoin · GitHub
 69 2017-07-18 15:29:38	0|BlueMatt|indeed
 70 2017-07-18 15:30:35	0|wumpus|but ok, shouldn't hold up merge
 71 2017-07-18 15:30:55	0|BlueMatt|heh, sorry
 72 2017-07-18 15:31:02	0|BlueMatt|been a mad rush this last week or two
 73 2017-07-18 15:31:32	0|bitcoin-git|13bitcoin/06master 14cf82a9e 15Matt Corallo: Do not allow users to get keys from keypool without reserving them...
 74 2017-07-18 15:31:32	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/bde4f937aebc...9e8d6a3fb43a
 75 2017-07-18 15:31:33	0|bitcoin-git|13bitcoin/06master 149e8d6a3 15Wladimir J. van der Laan: Merge #10784: Do not allow users to get keys from keypool without reserving them...
 76 2017-07-18 15:32:09	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10784: Do not allow users to get keys from keypool without reserving them (06master...062017-07-keep-change) 02https://github.com/bitcoin/bitcoin/pull/10784
 77 2017-07-18 15:59:51	0|bitcoin-git|[13bitcoin] 15jonasschnelli opened pull request #10867: Allow only a single -usewallet argument (06master...062017/07/multiwallet_bitcoincli) 02https://github.com/bitcoin/bitcoin/pull/10867
 78 2017-07-18 16:06:24	0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #10868: Remove -usewallet (06master...06remove_use_wallet) 02https://github.com/bitcoin/bitcoin/pull/10868
 79 2017-07-18 16:10:29	0|jonasschnelli|^^
 80 2017-07-18 16:25:46	0|jonasschnelli|Hmm... isn't the whole wallet endpoint URI encoding really required if we only allow "CHARS_ALPHA_NUM + ".-_"" for wallet filenames?!
 81 2017-07-18 16:26:01	0|jonasschnelli|I guess it's not. Ping ryanofsky
 82 2017-07-18 16:31:27	0|cfields|jonasschnelli: i wondered about that as well. I tried (unsuccessfully) to get wallets containing sneaky characters to load, and it failed as expected (though sometimes with a segfault that needs to be fixed). I fail to see why it's necessary
 83 2017-07-18 16:32:24	0|cfields|jonasschnelli: i assumed it was for more robust usage in the future
 84 2017-07-18 16:34:10	0|jonasschnelli|cfields: yes. That makes sense.
 85 2017-07-18 16:35:50	0|cfields|jonasschnelli: well that theory is based on absolutely nothing :)
 86 2017-07-18 16:38:34	0|jonasschnelli|Indeed
 87 2017-07-18 17:34:39	0|ryanofsky|url encoding was suggested when there were still wallet ids. if you want to check for CHARS_ALPHA_NUM in bitcoin-cli instead of percent encoding, that seems fine, though a little more fragile (because maybe we will allow another class of characters in bitcoind and bitcoin-cli will break)
 88 2017-07-18 17:36:49	0|sipa|i'd rather leave it this way
 89 2017-07-18 17:46:33	0|morcos|wumpus: #10817 is not really a bug fix, but its ready for merge and adds a couple strings
 90 2017-07-18 17:46:35	0|gribble|https://github.com/bitcoin/bitcoin/issues/10817 | Redefine Dust and add a discard_rate by morcos · Pull Request #10817 · bitcoin/bitcoin · GitHub
 91 2017-07-18 18:25:37	0|bitcoin-git|[13bitcoin] 15jonasschnelli opened pull request #10870: [Qt] Use wallet 0 in rpc console if running with multiple wallets (06master...062017/07/qt_mw) 02https://github.com/bitcoin/bitcoin/pull/10870
 92 2017-07-18 19:09:32	0|jtimon|jonasschnelli: I'm having problems explaining my suggestion in https://github.com/bitcoin/bips/pull/555
 93 2017-07-18 19:09:41	0|jtimon|do you understand my suggestion?
 94 2017-07-18 19:09:52	0|jtimon|perhaps you can help. communication is hard
 95 2017-07-18 19:42:29	0|goatpig|jtimon: you to provide the outpoint with the address?
 96 2017-07-18 19:42:32	0|goatpig|want*
 97 2017-07-18 19:44:36	0|jtimon|it seems I missunderstood this comment "The checksum should not contain any salted data. Otherwise with 30bits of non-cryptographic checksum one can easily calculate a TxID that is valid for more than one Network"
 98 2017-07-18 19:45:22	0|jtimon|he means that since it's only 30 bits of checksum, with 2^15 tries you can create a collision that is valid for more than 1 network.
 99 2017-07-18 22:19:50	0|bitcoin-git|[13bitcoin] 15achow101 opened pull request #10871: Handle getinfo in bitcoin-cli w/ -getinfo (revival of #8843) (06master...06cli-getinfo) 02https://github.com/bitcoin/bitcoin/pull/10871
100 2017-07-18 22:24:07	0|bitcoin-git|[13bitcoin] 15eklitzke opened pull request #10872: Docs: Syntax highlight shell commands in the building notes (06master...06hilite) 02https://github.com/bitcoin/bitcoin/pull/10872
101 2017-07-18 23:21:52	0|jtimon|mhmm it's just me... http://downforeveryoneorjustme.com/github.com
102 2017-07-18 23:23:41	0|jtimon|it's alive! now
103 2017-07-18 23:24:27	0|sipa|status.github.com
104 2017-07-18 23:33:59	0|bitcoin-git|[13bitcoin] 15eklitzke opened pull request #10873: Use a condition variable for shutdown notifications (06master...06shutdown_notify) 02https://github.com/bitcoin/bitcoin/pull/10873