1 2017-07-26 02:30:47	0|gmaxwell|Can someone remind me why we have a setting for turning on and off the standardness of bare multisig? it has no tests but seems kind of pointless to me..
  2 2017-07-26 04:13:31	0|jnewbery|
  3 2017-07-26 04:13:55	0|sipa|
  4 2017-07-26 04:19:34	0|jnewbery|gmaxwell : can you explain the tsan issue? The new keypool-rescan test checks that bitcoind will exit if the keypool drops below critical. bitcoind will also print to stderr if that happens. Without #10703, any output in stderr results in test failure
  5 2017-07-26 04:19:35	0|gribble|https://github.com/bitcoin/bitcoin/issues/10703 | [tests] Allow tests to pass when stderr is non-empty by jnewbery · Pull Request #10703 · bitcoin/bitcoin · GitHub
  6 2017-07-26 04:20:03	0|jnewbery|I'll work on it tomorrow to make it more targeted
  7 2017-07-26 04:23:18	0|sipa|jnewbery: tsan prints violations to stderr
  8 2017-07-26 04:25:07	0|sipa|i assume it's related to that; i haven't followed the discussion
  9 2017-07-26 04:33:03	0|luke-jr|gmaxwell: IIRC last time there was an effort to make it just policy-rejected always, some people didn't agree
 10 2017-07-26 04:36:05	0|gmaxwell|jnewbery: tsan and other dynamic analysis instrumention throws errors to stderr, so if we want to continue to use them for testing we can't just have their errors get eaten.
 11 2017-07-26 04:36:40	0|gmaxwell|jnewbery: for tests that are supposted to throw errors we sould probably actually test for that, rather than generally ignore stderr. I think.
 12 2017-07-26 05:39:20	0|bitcoin-git|[13bitcoin] 15DevlinShepherd opened pull request #10928: [bitcoin] Nits for README description (06master...06patch-1) 02https://github.com/bitcoin/bitcoin/pull/10928
 13 2017-07-26 05:40:08	0|bitcoin-git|[13bitcoin] 15sipa closed pull request #10928: [bitcoin] Nits for README description (06master...06patch-1) 02https://github.com/bitcoin/bitcoin/pull/10928
 14 2017-07-26 05:49:38	0|wumpus|gmaxwell: seems to me too that if bitcoind is supposed to print to stderr, it should specifically check for that, instead of a general "succeeded with warnings"
 15 2017-07-26 05:58:24	0|wumpus|BlueMatt: https://github.com/bitcoin/bitcoin/pull/10619#pullrequestreview-52181600   which automated warning?
 16 2017-07-26 06:00:40	0|wumpus|I also guess if that was the case, it'd need an assertion at *all* callsites of chainactive.tip, in which case why not check in the function itself?
 17 2017-07-26 06:00:56	0|wumpus|I don't see the point to randomly peppering around some assertions
 18 2017-07-26 06:03:09	0|wumpus|if there's an automated warning I'd like to know why it triggers just there
 19 2017-07-26 06:03:20	0|wumpus|not just add assertions and pray
 20 2017-07-26 06:12:25	0|bitcoin-git|13bitcoin/06master 140be03c7 15Brian McMichael: Qt: Use _putenv_s instead of setenv on Windows builds
 21 2017-07-26 06:12:25	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/8537187d4213...f29d5dbd04da
 22 2017-07-26 06:12:26	0|bitcoin-git|13bitcoin/06master 14f29d5db 15Wladimir J. van der Laan: Merge #10899: [test] Qt: Use _putenv_s instead of setenv on Windows builds...
 23 2017-07-26 06:13:02	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10899: [test] Qt: Use _putenv_s instead of setenv on Windows builds (06master...06testfix) 02https://github.com/bitcoin/bitcoin/pull/10899
 24 2017-07-26 06:15:35	0|bitcoin-git|13bitcoin/06master 14a56f8b0 15Matt Corallo: Add missing lock in CScheduler::AreThreadsServicingQueue()...
 25 2017-07-26 06:15:35	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/f29d5dbd04da...b995a374f727
 26 2017-07-26 06:15:36	0|bitcoin-git|13bitcoin/06master 14b995a37 15Wladimir J. van der Laan: Merge #10914: Add missing lock in CScheduler::AreThreadsServicingQueue()...
 27 2017-07-26 06:16:10	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10914: Add missing lock in CScheduler::AreThreadsServicingQueue() (06master...062017-04-fix-missing-scheduler-lock) 02https://github.com/bitcoin/bitcoin/pull/10914
 28 2017-07-26 06:45:28	0|bitcoin-git|13bitcoin/06master 149f8a46f 15Ryan Havar: Properly document target_confirmations in listsinceblock
 29 2017-07-26 06:45:28	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/b995a374f727...78f307b66428
 30 2017-07-26 06:45:29	0|bitcoin-git|13bitcoin/06master 1478f307b 15Wladimir J. van der Laan: Merge #10655: Properly document target_confirmations in listsinceblock...
 31 2017-07-26 06:45:51	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10655: Properly document target_confirmations in listsinceblock (06master...06listsinceblock) 02https://github.com/bitcoin/bitcoin/pull/10655
 32 2017-07-26 06:48:42	0|bitcoin-git|13bitcoin/06master 14095b917 15Gregory Maxwell: Avoid using sizes on non-fixed-width types to derive protocol constants....
 33 2017-07-26 06:48:42	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/78f307b66428...04d395e8327d
 34 2017-07-26 06:48:43	0|bitcoin-git|13bitcoin/06master 1404d395e 15Wladimir J. van der Laan: Merge #10854: Avoid using sizes on non-fixed-width types to derive protocol constants....
 35 2017-07-26 06:49:16	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10854: Avoid using sizes on non-fixed-width types to derive protocol constants. (06master...06rbf-numlimit-fix) 02https://github.com/bitcoin/bitcoin/pull/10854
 36 2017-07-26 07:13:24	0|jnewbery|Redone #10882 with stderr capture/checking done within the individual test. Ready for review. (sipa, gmaxwell)
 37 2017-07-26 07:13:26	0|gribble|https://github.com/bitcoin/bitcoin/issues/10882 | Keypool topup by jnewbery · Pull Request #10882 · bitcoin/bitcoin · GitHub
 38 2017-07-26 07:14:08	0|jnewbery|MarcoFalke: Not urgent for 0.15, but I'd love some review of #10711
 39 2017-07-26 07:14:10	0|gribble|https://github.com/bitcoin/bitcoin/issues/10711 | [tests] Introduce TestNode by jnewbery · Pull Request #10711 · bitcoin/bitcoin · GitHub
 40 2017-07-26 07:19:44	0|sipa|jnewbery: thanks!
 41 2017-07-26 07:34:05	0|luke-jr|FWIW, master upgraded my testnet3 UTXO set and then crashed syncing due to LevelDB giving $6 = "Corruption: not an sstable (bad magic number)"
 42 2017-07-26 07:34:27	0|luke-jr|leveldb LOG file hasn't changed in a month
 43 2017-07-26 07:44:13	0|luke-jr|https://github.com/bitcoin/bitcoin/pull/10457#pullrequestreview-52270582 wumpus: what do you mean?
 44 2017-07-26 08:05:47	0|luke-jr|jonasschnelli: btw, I think prune-to might be a good novice contributor thing, so might make sense to let it sit as an issue :p
 45 2017-07-26 08:06:09	0|luke-jr|(eg, manual pruning and chainstate obfuscation seemed to work out nicely)
 46 2017-07-26 08:21:51	0|wumpus|luke-jr: I mean: bring back the typedef instead of declaring a function type in a function argument
 47 2017-07-26 08:22:09	0|wumpus|I dont' understand why the typedef is being removed
 48 2017-07-26 08:25:04	0|wumpus|or am I alone in finding "CDBEnv::VerifyResult CDBEnv::Verify(const std::string& strFile, bool (*recoverFunc)(const std::string& strFile))" terribly hard to read?
 49 2017-07-26 08:26:49	0|sipa|no.
 50 2017-07-26 08:29:09	0|wumpus|and as for not being sure what the state of that PR is, I read the other discussion and people don't seem to agree wheter it's considered an improvement or not
 51 2017-07-26 08:29:37	0|wumpus|in which case it'd be better to close it instead of review it further
 52 2017-07-26 08:30:12	0|bitcoin-git|[13bitcoin] 15ryanofsky opened pull request #10931: Fix misleading "Method not found" multiwallet errors (06master...06pr/multierr) 02https://github.com/bitcoin/bitcoin/pull/10931
 53 2017-07-26 08:37:59	0|wumpus|jnewbery: yes, testnode is nice
 54 2017-07-26 08:41:09	0|midnightmagic|argh, sorry, was behind on scrollback and that had nothing to do with anything current.
 55 2017-07-26 08:41:28	0|wumpus|I already wondered who and why you were stabbing :)
 56 2017-07-26 08:42:53	0|wumpus|jnewbery: thanks for adding explicit check for stderr, I think this is much cleaner
 57 2017-07-26 09:01:19	0|luke-jr|wumpus: ah, got the before/after reversed
 58 2017-07-26 09:06:10	0|bitcoin-git|13bitcoin/06master 144a7a4ff 15Marko Bencun: developer-notes: add reference to snake_case and PascalCase...
 59 2017-07-26 09:06:10	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/04d395e8327d...5c003cb1afcb
 60 2017-07-26 09:06:11	0|bitcoin-git|13bitcoin/06master 145c003cb 15Wladimir J. van der Laan: Merge #10917: developer-notes: add reference to snake_case and PascalCase...
 61 2017-07-26 09:06:45	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10917: developer-notes: add reference to snake_case and PascalCase (06master...06pascalcase) 02https://github.com/bitcoin/bitcoin/pull/10917
 62 2017-07-26 09:08:11	0|bitcoin-git|[13bitcoin] 15Cr4shOv3rrid3 opened pull request #10932: Create models.js (06master...06patch-5) 02https://github.com/bitcoin/bitcoin/pull/10932
 63 2017-07-26 09:08:30	0|bitcoin-git|[13bitcoin] 15Cr4shOv3rrid3 opened pull request #10933: Create web3.js (06master...06patch-4) 02https://github.com/bitcoin/bitcoin/pull/10933
 64 2017-07-26 09:08:55	0|bitcoin-git|[13bitcoin] 15fanquake closed pull request #10933: Create web3.js (06master...06patch-4) 02https://github.com/bitcoin/bitcoin/pull/10933
 65 2017-07-26 09:09:50	0|bitcoin-git|[13bitcoin] 15Cr4shOv3rrid3 opened pull request #10934: Create transaction.js (06master...06patch-6) 02https://github.com/bitcoin/bitcoin/pull/10934
 66 2017-07-26 09:10:16	0|bitcoin-git|[13bitcoin] 15fanquake closed pull request #10934: Create transaction.js (06master...06patch-6) 02https://github.com/bitcoin/bitcoin/pull/10934
 67 2017-07-26 09:10:55	0|bitcoin-git|[13bitcoin] 15Cr4shOv3rrid3 opened pull request #10935: Create index.js (06master...06patch-7) 02https://github.com/bitcoin/bitcoin/pull/10935
 68 2017-07-26 09:11:11	0|bitcoin-git|[13bitcoin] 15fanquake closed pull request #10935: Create index.js (06master...06patch-7) 02https://github.com/bitcoin/bitcoin/pull/10935
 69 2017-07-26 09:11:58	0|wumpus|luke-jr: agree
 70 2017-07-26 09:12:10	0|bitcoin-git|[13bitcoin] 15Cr4shOv3rrid3 opened pull request #10936: Create balance.js (06master...06patch-8) 02https://github.com/bitcoin/bitcoin/pull/10936
 71 2017-07-26 09:12:30	0|bitcoin-git|[13bitcoin] 15fanquake closed pull request #10936: Create balance.js (06master...06patch-8) 02https://github.com/bitcoin/bitcoin/pull/10936
 72 2017-07-26 09:12:45	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10824: Avoid unnecessary work in SetNetworkActive (06master...062017-07-set-network-active) 02https://github.com/bitcoin/bitcoin/pull/10824
 73 2017-07-26 09:13:02	0|fanquake|sipa / wumpus want to block @https://github.com/Cr4shOv3rrid3
 74 2017-07-26 09:13:11	0|wumpus|fanquake: good idea
 75 2017-07-26 09:13:30	0|bitcoin-git|[13bitcoin] 15Cr4shOv3rrid3 opened pull request #10937: Create web3.js (06master...06patch-9) 02https://github.com/bitcoin/bitcoin/pull/10937
 76 2017-07-26 09:13:32	0|sipa|i was about to, if he opens one more
 77 2017-07-26 09:13:39	0|sipa|Done.
 78 2017-07-26 09:13:40	0|bitcoin-git|[13bitcoin] 15fanquake closed pull request #10937: Create web3.js (06master...06patch-9) 02https://github.com/bitcoin/bitcoin/pull/10937
 79 2017-07-26 09:13:54	0|wumpus|done at the same time lol
 80 2017-07-26 09:14:07	0|fanquake|/race
 81 2017-07-26 09:14:08	0|wumpus|oh we blocked a different one actually
 82 2017-07-26 09:14:14	0|luke-jr|hopefully it's not a toggle
 83 2017-07-26 09:14:22	0|wumpus|Cr4sh0verr1d3 versus Cr4shOv3rrid3
 84 2017-07-26 09:14:40	0|sipa|wumpus: you got the right one
 85 2017-07-26 10:06:47	0|bitcoin-git|13bitcoin/06master 14065039d 15practicalswift: [tests] Fix incorrect memory_cleanse(…) call in crypto_tests.cpp...
 86 2017-07-26 10:06:47	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/9dd6a2be4188...5c8eb7916de7
 87 2017-07-26 10:06:48	0|bitcoin-git|13bitcoin/06master 145c8eb79 15Wladimir J. van der Laan: Merge #10912: [tests] Fix incorrect memory_cleanse(…) call in crypto_tests.cpp...
 88 2017-07-26 10:07:17	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10912: [tests] Fix incorrect memory_cleanse(…) call in crypto_tests.cpp (06master...06arrays-are-not-pointers) 02https://github.com/bitcoin/bitcoin/pull/10912
 89 2017-07-26 15:00:32	0|BlueMatt|wumpus: I was referring to https://github.com/bitcoin/bitcoin/pull/10619#issuecomment-310257582
 90 2017-07-26 15:08:11	0|gmaxwell|wumpus: I'm glad you commented on the alarmist titles.
 91 2017-07-26 15:09:11	0|gmaxwell|wumpus: someone should also point out to practicalswift that these titles will confuse further troubleshooting, e.g. someone encounters a real crash, then sees commits with titles like "avoid null dereference" they may think "oh thats been fixed" and not report it.
 92 2017-07-26 15:09:39	0|gmaxwell|"Appease static analysis tool by adding an assert in X" is a fine title.
 93 2017-07-26 15:26:09	0|morcos|If the next PR literally says "X" in the title, you are responsible
 94 2017-07-26 15:31:20	0|gmaxwell|hahah
 95 2017-07-26 16:25:34	0|jtimon|can I build bitcoind but only bitcoind without bitcoin-cli, bitcoin-tx, libbitcoinconsensus.la, test/test_bitcoin_fuzzy, bench/bench_bitcoin and test/test_bitcoin ?
 96 2017-07-26 16:26:21	0|gmaxwell|make bitcoind
 97 2017-07-26 16:26:32	0|gmaxwell|(or make src/bitcoind )
 98 2017-07-26 16:28:12	0|jtimon|oops, right, I forgot the src/, thanks
 99 2017-07-26 17:43:17	0|bitcoin-git|[13bitcoin] 15laanwj reopened pull request #10301: Check if sys/random.h is required for getentropy. (06master...06getentropy-rand) 02https://github.com/bitcoin/bitcoin/pull/10301
100 2017-07-26 19:18:42	0|gmaxwell|Interesting observation from the now-public infomation about the mtgox thefts.  Non-HD walletness of MTGOX partially protected it from losses.
101 2017-07-26 19:20:15	0|gmaxwell|They had a wallet.dat stolen in 2011... and the theif was limited to steal coins that landed on the addresses in it and the 100 after it.
102 2017-07-26 19:21:35	0|morcos|Did you mean to say not having a bag of 10,000 keys protected them from losses
103 2017-07-26 19:22:15	0|gmaxwell|morcos: Yes. (though the keypool size is irrelevant for this now, because they're all determinstically derrived now)
104 2017-07-26 19:22:45	0|gmaxwell|Not using HD protected them, though -- it's pretty remarkable how little it protected them.
105 2017-07-26 19:22:49	0|achow101|gmaxwell: where is this info?
106 2017-07-26 19:23:31	0|gmaxwell|http://blog.wizsec.jp/2017/07/breaking-open-mtgox-1.html
107 2017-07-26 19:24:46	0|kakobrekla|hd was not a thing back then
108 2017-07-26 19:24:57	0|kakobrekla|maybe wallets werent even encrypted
109 2017-07-26 19:25:02	0|kakobrekla|i forgot when that came to be.
110 2017-07-26 19:25:47	0|gmaxwell|...
111 2017-07-26 19:27:56	0|eck|wallet.dat file was stolen sept 2011, the same month encryption was added to bitcoin core (0.4.0 released sep 23, 2011)
112 2017-07-26 19:29:11	0|grubles|https://bitcoin.org/en/release/v0.4.0
113 2017-07-26 19:29:24	0|gmaxwell|kakobrekla: you've missed my point.
114 2017-07-26 19:29:32	0|kakobrekla|i miss all the points :(
115 2017-07-26 19:31:08	0|grubles|the point was they only had access to the keys generated in that copy of the wallet.dat, and none generated afterwards
116 2017-07-26 19:32:30	0|kakobrekla|aha, if only the keypool size would be smaller...
117 2017-07-26 19:33:04	0|gmaxwell|kakobrekla: it no longer has anything to do with the keypool. Use of hdwallets means that there is no more leakage resistance.
118 2017-07-26 19:33:20	0|kakobrekla|sure
119 2017-07-26 19:33:30	0|gmaxwell|There has been a long discussion since 2011 if the 'unstealing' property is meaningfully protective or not. There have been some other examples where leakage resistance was useful, but this would be the largest yet.
120 2017-07-26 19:34:15	0|kakobrekla|so you stance on this is that hd wallets are bad for your health?
121 2017-07-26 19:34:18	0|kakobrekla|your*
122 2017-07-26 19:34:30	0|gmaxwell|No, but there is a tradeoff.
123 2017-07-26 19:34:34	0|kakobrekla|aha
124 2017-07-26 19:34:45	0|gmaxwell|also, I introduced these things fwiw.
125 2017-07-26 19:35:45	0|gmaxwell|personally I think the ideal functionality would be to rotate HD master keys on a timed basis, e.g. once a year, and only switch to a new one after a backup has happened.
126 2017-07-26 19:36:19	0|gmaxwell|though I think patterns like mtgox show that lazy rotation might not have been much more protective than no rotation at all... they still lost most of their coins even with the 100 key keypool.
127 2017-07-26 19:37:22	0|phantomcircuit|gmaxwell, exchange users insist on reusing very old addresses
128 2017-07-26 19:37:34	0|phantomcircuit|even i they're not displayed anywhere on the site
129 2017-07-26 19:37:41	0|phantomcircuit|it's quite a problem actually
130 2017-07-26 19:38:48	0|gmaxwell|phantomcircuit: yea.... I wondered if we should have added an expiration time to bech32 addresses; to make that a bit harder.
131 2017-07-26 19:38:56	0|gmaxwell|but it's such a mess.
132 2017-07-26 19:39:45	0|phantomcircuit|gmaxwell, the easiest is for exchanges to charge a fee that increases overtime or older addresses
133 2017-07-26 19:40:01	0|phantomcircuit|or at least make a big deal out of retiring addresses and then making it annoying to use old ones
134 2017-07-26 19:55:17	0|kakobrekla|i just checked my db, 4.6% of deposits were made to previously used address
135 2017-07-26 19:59:23	0|phantomcircuit|kakobrekla, by volume or number
136 2017-07-26 20:01:38	0|kakobrekla|just count of deposits
137 2017-07-26 23:10:10	0|sipa|hi, what did i miss?
138 2017-07-26 23:13:53	0|Murch|sipa: BTCe blew up, BCC implemented mandatory two-way replay protection
139 2017-07-26 23:14:23	0|Murch|apparently BTCe owner was involved at least in laundering Mt.Gox heist loot, or perhaps even the culprit
140 2017-07-26 23:14:41	0|Murch|were you in Tokyo after all?
141 2017-07-26 23:14:54	0|sipa|i'm in tokyo now
142 2017-07-26 23:14:56	0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #10939: Check that -blocknotify command is non-empty before executing (06master...06blocknotify-consistentcy) 02https://github.com/bitcoin/bitcoin/pull/10939
143 2017-07-26 23:15:05	0|Murch|ah, I see.