1 2017-08-02 02:57:04	0|warren|I'm putting together a presentation, trying to find a recent performance optimization PR that had hundreds of comments, anyone know which it was?
 2 2017-08-02 02:59:35	0|warren|Wow so many PR's merged.  Clearly development is stagnant here.
 3 2017-08-02 03:00:01	0|sipa|warren: eh
 4 2017-08-02 03:00:06	0|sipa|could be many things
 5 2017-08-02 03:00:46	0|gmaxwell|it's hard to tell how many comments there have been because github hides them
 6 2017-08-02 03:01:14	0|arubi|can add comments:>100 to the search string
 7 2017-08-02 03:01:25	0|warren|cool thanks
 8 2017-08-02 03:02:24	0|gmaxwell|https://github.com/bitcoin/bitcoin/pull/10195  might be what you were looking for
 9 2017-08-02 03:02:32	0|sipa|ah, yes
10 2017-08-02 03:02:35	0|warren|yes that's it!
11 2017-08-02 03:23:35	0|bitcoin-git|[13bitcoin] 15visvirial opened pull request #10974: Fix typo in sendcoinsdialog. (06master...06fix-typo-in-sendcoindialog) 02https://github.com/bitcoin/bitcoin/pull/10974
12 2017-08-02 06:55:11	0|bitcoin-git|13bitcoin/06master 147f121a0 15Masahiko Hyuga: Fix typo in sendcoinsdialog.
13 2017-08-02 06:55:11	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/f66c59650527...f0579bfea1db
14 2017-08-02 06:55:12	0|bitcoin-git|13bitcoin/06master 14f0579bf 15Wladimir J. van der Laan: Merge #10974: Fix typo in sendcoinsdialog....
15 2017-08-02 06:55:51	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10974: Fix typo in sendcoinsdialog. (06master...06fix-typo-in-sendcoindialog) 02https://github.com/bitcoin/bitcoin/pull/10974
16 2017-08-02 07:01:31	0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/f0579bfea1db...659c09613408
17 2017-08-02 07:01:32	0|bitcoin-git|13bitcoin/06master 1447f3e8c 15Pieter Wuille: Update LevelDB with latest Bitcoin-specific patches
18 2017-08-02 07:01:32	0|bitcoin-git|13bitcoin/06master 14b13a68e 15Pieter Wuille: Squashed 'src/leveldb/' changes from 196962ff0..c521b3ac6...
19 2017-08-02 07:01:33	0|bitcoin-git|13bitcoin/06master 14659c096 15Wladimir J. van der Laan: Merge #10958: Update to latest Bitcoin patches for LevelDB...
20 2017-08-02 07:01:57	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10958: Update to latest Bitcoin patches for LevelDB (06master...0620170731_leveldb) 02https://github.com/bitcoin/bitcoin/pull/10958
21 2017-08-02 08:07:03	0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #10975: [script] Return early if no valid opcodes found in CountWitnessSigOps(...) (06master...06return-early-in-CountWitnessSigOps) 02https://github.com/bitcoin/bitcoin/pull/10975
22 2017-08-02 10:50:39	0|jonasschnelli|Got a request from a miner: what is the best document to figure out how to create segwit coinbase transactions?
23 2017-08-02 10:50:49	0|jonasschnelli|https://github.com/bitcoin/bips/blob/master/bip-0141.mediawiki?
24 2017-08-02 12:06:38	0|bitcoin-git|[13bitcoin] 15ryanofsky opened pull request #10976: [MOVEONLY] Move some static functions out of wallet.h/cpp (06master...06pr/wmove) 02https://github.com/bitcoin/bitcoin/pull/10976
25 2017-08-02 12:10:31	0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #10977: [net] Fix use of uninitialized value in getnetworkinfo(const JSONRPCRequest& request) (06master...06valgrind-getnetworkinfo) 02https://github.com/bitcoin/bitcoin/pull/10977
26 2017-08-02 21:59:41	0|gmaxwell|jnewbery: https://twitter.com/jfnewbery/status/892856516985991170  I think this is misleading. Retarget modified the difficulty from the prior block, so it's likely to double apply a dip, not undo it.
27 2017-08-02 22:00:10	0|gmaxwell|Though it depends on when in the retarget window the crazy-change applies.
28 2017-08-02 22:00:47	0|gmaxwell|E.g. if 20 blocks before the retarget the 12h rule triggers, it will then drop the difficulty 73.7% (because when it triggers it triggers 6 times in a row...)
29 2017-08-02 22:01:23	0|gmaxwell|then you'll get to the retarget, and the code will go "oh wow, took longer than expected for the last 2016 blocks, better lower the difficulty".
30 2017-08-02 22:11:26	0|gmaxwell|E.g. the worst case is probably something like you run at 1/11th the hashrate for a whole retarget interval, then just before the end, hit the magic rule. This drops your difficulty by 3.8, then the retarget will apply and drop the diffuclty by a factor of 11, resuting in blocks being about 4x too fast.
31 2017-08-02 22:37:51	0|jnewbery|thanks gmaxwell. Yes, makes sense
32 2017-08-02 22:38:09	0|jnewbery|Having two difficulty readjustment algorithms is confusing :/
33 2017-08-02 22:39:06	0|jnewbery|I assumed that normal retarget was based on the previous retarget nBits, not pindexLast
34 2017-08-02 22:39:28	0|jnewbery|(which of course would be the same thing if you didn't change nBits within a retarget window)
35 2017-08-02 22:42:20	0|gmaxwell|jnewbery: yea, more or less an accident of software construction that it uses the last rather than the last retarget.
36 2017-08-02 22:42:41	0|gmaxwell|This actually creates a bug for testnet's diff1 rule, if it happens at the wrong block it'll warp testnet's difficulty back to 1.