1 2017-08-09 00:38:55 0|earlz|Has anyone tried porting the gitian build system to run on xenial instead of trusty since trusty is getting old and GCC 4.8's C++11 support is considered experimental? 2 2017-08-09 00:41:52 0|sipa|4.8 is enough 3 2017-08-09 00:51:01 0|earlz|Even with the (still somewhat far away) 2019 EOL for Trusty? 4 2017-08-09 00:51:45 0|sipa|we don't use any c++11 features that aren't in gcc 4.8 5 2017-08-09 00:52:52 0|gmaxwell|jnewbery: I really think we should split the PR and merge the mark-used and topup if possible stuff, and make the shutdown and don't update parts a seperate PR. The first part is done, solves the issue for unlocked wallets. And even for locked wallets results in rescan instructions that we can give to succesfully rescan "(unlock the wallet with a long time, run rescan)"... and doesn't have an r 6 2017-08-09 00:52:58 0|gmaxwell|isk of making things worse for anyone. 7 2017-08-09 00:53:15 0|earlz|My concern isn't bitcoin itself, but rather it's dependencies will start using C++11 features, making for more and more patches being required for gitian compiles 8 2017-08-09 00:53:47 0|sipa|earlz: i'm confused 9 2017-08-09 00:54:01 0|sipa|gitian is a fully deterministic environment, we control all the dependencies 10 2017-08-09 00:54:09 0|sipa|and their exact version 11 2017-08-09 00:54:36 0|earlz|yes of course, but at some point there will be a discussion "no, we can't upgrade boost because it will require patching out their use of things gcc 4.8 doesn't support" 12 2017-08-09 00:54:50 0|sipa|heh, then we'll just upgrade gcc... 13 2017-08-09 00:55:52 0|earlz|that seems... non-trivial without also upgrading from trusty to xenial or building our own compilers within gitian as another dependency 14 2017-08-09 00:56:43 0|sipa|which we should do anyway 15 2017-08-09 00:58:14 0|earlz|heh at that point might as well make a deterministic linux distro too ;) 16 2017-08-09 00:58:32 0|earlz|but seriously, I guess it's nothing to worry about for now, just concerning for the future, and if EOL affects gitian builds using trusty 17 2017-08-09 01:03:28 0|gmaxwell|earlz: eventually our depends system will compile GCC. 18 2017-08-09 01:03:56 0|gmaxwell|earlz: and wrt upgrading normally the barrier there is just that it often restricts our ability to produce binaries that will run on older systems. 19 2017-08-09 01:06:00 0|earlz|What is the official target for "older systems"? Like what distros and such? 20 2017-08-09 01:09:15 0|eck|earlz: btw if you wanted to upgrade gcc on gitian you'd probably have to upgrade it on travis as well, which is non-trivial/challenging, as trusty is the latest release supported by travis (and they didn't even roll that out until relatively recently) 21 2017-08-09 01:09:48 0|eck|thre are some changes they made to the std::string ABI in GCC 5.1+ but I'm not sure how pertinent they are here 22 2017-08-09 01:10:01 0|earlz|wow really? That's ridiculous 23 2017-08-09 01:10:30 0|eck|it's not ridiculous, c++11 changed the std::string spec 24 2017-08-09 01:11:05 0|eck|https://gcc.gnu.org/onlinedocs/libstdc++/manual/using_dual_abi.html 25 2017-08-09 01:11:08 0|earlz|No I mean about Travis just recently supporting a 4 year old distro 26 2017-08-09 01:11:52 0|earlz|regarding std::string ABI stuff, would that really matter that much? I know compiling Bitcoin outside of Gitian (ie with system deps) works fine in every version of GCC I've tried 27 2017-08-09 01:13:47 0|eck|libstdc++ now supports both ABIs but it would be an issue if you built an executable that used the new ABI and tried to run it on a system with an old copy of libstdc++ 28 2017-08-09 01:15:48 0|earlz|ah, and I assume static linking of stdc++ isn't feasible? 29 2017-08-09 01:20:22 0|eck|i would recommend against it, anyway it would presumably be less of an issue in a year when trusty is closer to EOL 30 2017-08-09 01:22:15 0|cfields_|we static link libstdc++ 31 2017-08-09 01:22:21 0|cfields_|so the abi is not an issue 32 2017-08-09 01:23:48 0|Chris_Stewart_5|funny, wumpus and i had a convo about upgrading gcc earlier today 33 2017-08-09 01:24:27 0|cfields_|yes, it was on my list for 0.15 but i didn't make it :( 34 2017-08-09 01:24:38 0|cfields_|0.16 will use a self-built toolchain 35 2017-08-09 01:24:58 0|Chris_Stewart_5|Is there consensus on what the oldest version of gcc will be that we support? 36 2017-08-09 01:25:16 0|cfields_|well that's independent of gitian and the release process 37 2017-08-09 01:25:17 0|Chris_Stewart_5|Just 4.9.x instead of 4.8? 38 2017-08-09 01:26:25 0|Chris_Stewart_5|What does gcc version have to do with a self built toolchain? Does your self built toolchain stuff require a bunch of fancy c++11 features? 39 2017-08-09 01:28:11 0|cfields_|no. maybe i'm the one who conflated things there. I'm not sure what you meant by "upgrading gcc". If you mean "bumping the minimum version required", i doubt that'll change soon 40 2017-08-09 01:30:57 0|Chris_Stewart_5|ah, yes that is what i meant. 41 2017-08-09 02:00:07 0|bitcoin-git|[13bitcoin] 15theuni opened pull request #11012: Make sure to clean up mapBlockSource if we've already seen the block (06master...06cleanup-blocksource) 02https://github.com/bitcoin/bitcoin/pull/11012 42 2017-08-09 02:21:35 0|bitcoin-git|[13bitcoin] 15eklitzke closed pull request #11005: Tests: Add a lint check for trailing whitespace (06master...06whitespace) 02https://github.com/bitcoin/bitcoin/pull/11005 43 2017-08-09 02:36:31 0|bitcoin-git|[13bitcoin] 15eklitzke opened pull request #11013: Build: Fix Automake warnings when running autogen.sh (06master...06override_gzip_env) 02https://github.com/bitcoin/bitcoin/pull/11013 44 2017-08-09 02:49:47 0|bitcoin-git|[13bitcoin] 15eklitzke closed pull request #10880: Update .gitignore to ignore more test files (06master...06gitignore) 02https://github.com/bitcoin/bitcoin/pull/10880 45 2017-08-09 03:18:29 0|luke-jr|Ã¢â¬Å½[20:23:44] Ã¢â¬Å½<Ã¢â¬Å½jonasschnelliÃ¢â¬Å½>Ã¢â¬Å½ sdaftuar, luke-jr: about NODE_NETWORK_LIMITED_*. If we would treat them independently, would this mean, a peer signalling NODE_NETWORK_LIMITED_HIGH will always singal NODE_NETWORK_LIMITED_LOW? <-- I disagree with this approach 46 2017-08-09 03:33:54 0|luke-jr|jonasschnelli: Ã¢â¬Â¦ but I didn't realise nodes would OR service bits themselves. Nevermind. 47 2017-08-09 07:00:46 0|bitcoin-git|[13bitcoin] 15lclc opened pull request #11015: [Qt] Search TX: Add delay before filtering (06master...06searchDelay) 02https://github.com/bitcoin/bitcoin/pull/11015 48 2017-08-09 07:15:44 0|sipa|kallewoof: MSG_WITNESS_FlAG is only used in getdata, not inv 49 2017-08-09 07:19:28 0|kallewoof|sipa: gotcha, thanks! 50 2017-08-09 07:39:06 0|achow101|kallewoof: see bip 141: "New inv types MSG_WITNESS_TX and MSG_WITNESS_BLOCK are added, only for use in getdata. Inventory messages themselves still use just MSG_TX and MSG_BLOCK" 51 2017-08-09 07:40:43 0|achow101|kallewoof: the response to an inv is a getdata, in which we will specify that we want the witnesses by setting MSG_WITNESS_FLAG. this also means that we won't break compatibility with old nodes 52 2017-08-09 07:49:05 0|kallewoof|achow101: Thanks for clarifying. I sort of missed that INV had a successor, or I forgot. I haven't dug around here in awhile. 53 2017-08-09 07:56:05 0|sipa|it's similar to BIP37's MSG_FILTERED_BLOCK btw 54 2017-08-09 08:09:50 0|kallewoof|Ahh yes, I noticed that too. Hence e.g. 55 2017-08-09 08:10:09 0|kallewoof|Will re-read BIPs though, while at it. 56 2017-08-09 08:18:17 0|kallewoof|sipa: since it kind of overlapped with BIP154 (anti-DoS via POW) I am interested in the work in replacing the misbehaving stuff with how useful a node has been that you mentioned before. Is there any work being done on this currently? 57 2017-08-09 08:21:34 0|sipa|kallewoof: i don't think so 58 2017-08-09 08:22:28 0|kallewoof|OK! 59 2017-08-09 08:45:11 0|bitcoin-git|[13bitcoin] 15kallewoof opened pull request #11017: [wallet] Close DB on error. (06master...06close-dbenv) 02https://github.com/bitcoin/bitcoin/pull/11017 60 2017-08-09 09:21:16 0|bitcoin-git|13bitcoin/06master 1413b1e9a 15Evan Klitzke: Capitalize bullet points in CONTRIBUTING guide... 61 2017-08-09 09:21:16 0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/929fd7276c0f...4b5a7ce0c301 62 2017-08-09 09:21:17 0|bitcoin-git|13bitcoin/06master 144b5a7ce 15MarcoFalke: Merge #11003: Docs: Capitalize bullet points in CONTRIBUTING guide... 63 2017-08-09 09:21:55 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #11003: Docs: Capitalize bullet points in CONTRIBUTING guide (06master...06contributing_grammar) 02https://github.com/bitcoin/bitcoin/pull/11003 64 2017-08-09 09:55:38 0|bitcoin-git|13bitcoin/06master 14fd05132 15practicalswift: Restore default format state of cout after printing with std::fixed/setprecision 65 2017-08-09 09:55:38 0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/4b5a7ce0c301...ecd21357f161 66 2017-08-09 09:55:39 0|bitcoin-git|13bitcoin/06master 14ecd2135 15MarcoFalke: Merge #10963: [bench] Restore format state of cout after printing with std::fixed/setprecision... 67 2017-08-09 09:56:13 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #10963: [bench] Restore format state of cout after printing with std::fixed/setprecision (06master...06restore-format-state-of-cout) 02https://github.com/bitcoin/bitcoin/pull/10963 68 2017-08-09 10:05:17 0|bitcoin-git|13bitcoin/06master 1467f6f1c 15Wladimir J. van der Laan: qt: Periodic translations update... 69 2017-08-09 10:05:17 0|bitcoin-git|[13bitcoin] 15laanwj pushed 1 new commit to 06master: 02https://github.com/bitcoin/bitcoin/commit/67f6f1c2d5c826d3062cb6b5c5d91190d1adcb76 70 2017-08-09 10:11:23 0|aj|wumpus: any thoughts on how to maybe progress #10267 or #10996 (includeconf and network.conf resp.), or busy with 0.15 stuff for now? 71 2017-08-09 10:11:25 0|gribble|https://github.com/bitcoin/bitcoin/issues/10267 | New -includeconf argument for including external configuration files by kallewoof ÃÂ· Pull Request #10267 ÃÂ· bitcoin/bitcoin ÃÂ· GitHub 72 2017-08-09 10:11:26 0|gribble|https://github.com/bitcoin/bitcoin/issues/10996 | [WIP] Add per-network config file network.conf by ajtowns ÃÂ· Pull Request #10996 ÃÂ· bitcoin/bitcoin ÃÂ· GitHub 73 2017-08-09 10:17:02 0|aj|wumpus: (in particular, not clear to me if -includeconf is basically okay to merge as is; or should be able to include multiple files and/or recursively like #include would) 74 2017-08-09 10:45:31 0|bitcoin-git|13bitcoin/06master 144d4fb33 15Pavel JanÃÂk: Rename member field according to the style guide. 75 2017-08-09 10:45:31 0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/67f6f1c2d5c8...e526ca6284b9 76 2017-08-09 10:45:32 0|bitcoin-git|13bitcoin/06master 14e526ca6 15MarcoFalke: Merge #10835: Rename member field according to the style guide... 77 2017-08-09 10:45:59 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #10835: Rename member field according to the style guide (06master...0620170715_Wshadow_reverseiterator) 02https://github.com/bitcoin/bitcoin/pull/10835 78 2017-08-09 14:12:39 0|jnewbery|gmaxwell : paring 10882 back to just mark-used and topup doesn't fix the most important issue: potentially missing txs and funds loss if you restore an old encrypted backup wallet 79 2017-08-09 14:59:07 0|bitcoin-git|[13bitcoin] 15jameshilliard closed pull request #10444: Implement BIP91 Reduced threshold Segwit MASF (060.14...06segsignal-v0.14.1) 02https://github.com/bitcoin/bitcoin/pull/10444 80 2017-08-09 17:54:11 0|bitcoin-git|[13bitcoin] 15achow101 closed pull request #10900: [0.14] Enforce segsignal activation height and rules (060.14...06early-uasf-bip91) 02https://github.com/bitcoin/bitcoin/pull/10900 81 2017-08-09 19:27:02 0|earlz|anyone ever seen this error from a gitian build? It recently popped up and won't go away "error: newly created file is older than distributed files!" 82 2017-08-09 19:33:36 0|remote|earlz: clock out of whack? 83 2017-08-09 19:40:46 0|earlz|ah, it is. I guess that happened from hibernating the virtualbox vm 84 2017-08-09 21:48:28 0|smill|Hello, I have a problem using bitcore-wallet-service and insight-api, I have everything working with bitcoind from bitcoin-0.12.1 bitcore build (the one that gets installed if you follow the dosc) but im trying to get the new release working from https://github.com/bitpay/bitcoin/releases and im basically having the same problem as this guy https://github.com/bitpay/insight-ui/issues/746 and there are no answers yet 85 2017-08-09 21:49:31 0|chainhead|bitcore is not from bitcoin core 86 2017-08-09 21:50:22 0|smill|my bad.