1 2017-08-15 00:01:43 0|gribble|https://github.com/bitcoin/bitcoin/issues/11049 | coincontrol can filter for segwit inputs, expose fundraw option by instagibbs ÷ Pull Request #11049 ÷ bitcoin/bitcoin ÷ GitHub
2 2017-08-15 04:52:39 0|dermoth|Hey... I worked out a small speedup to initial blockchain load from bootstrap.dat (and likely rescan operations)... If you're interested it would be best implemented as a separate thread in the bitcoin node...
3 2017-08-15 04:52:42 0|dermoth|https://gist.github.com/dermoth/b5462462d9edc69f6de79abcfcd017d5
4 2017-08-15 04:54:02 0|dermoth|the details are in comments, but basically I ensure each blockfile is loaded in OS cache before bitcoin-qt opens them while rescanning the whole blockchain
5 2017-08-15 05:12:51 0|gmaxwell|dermoth: did you benchmark it? did it help?
6 2017-08-15 05:18:00 0|dermoth|the percent per hour went from around 4 to 7... nothing really scientific
7 2017-08-15 05:18:47 0|gmaxwell|wumpus: I was looking at the rc1 release notes and I see there isn't a list of commits in it... are we dropping them or are they just not there yet?
8 2017-08-15 05:19:01 0|dermoth|but I know it's not going to spend much time on IO for the SSD, so the slowness comes manly from reading blocks.... There's a couple other things loading those disks too
9 2017-08-15 05:19:13 0|gmaxwell|wumpus: (and do you need help with them)
10 2017-08-15 05:19:28 0|dermoth|I just thought I'd share...
11 2017-08-15 05:19:33 0|gmaxwell|Thanks.
12 2017-08-15 05:22:11 0|sipa|gmaxwell: i assume the final list of commits will only be added when final
13 2017-08-15 05:22:20 0|sipa|and iirc wumpus has some tooling for that
14 2017-08-15 05:24:43 0|gmaxwell|OK. It's the best part of the release notes (IMO) :) so I just wanted to make sure we weren't losing it.
15 2017-08-15 05:30:46 0|dermoth|timed two days's import times each without and with the script running... without: Jan 15-16: 73s; Jan 16-17: 71s; -- with: Jan 18-19: 58s, Jan 19-20: 67s
16 2017-08-15 05:31:14 0|dermoth|not a big diff indeed, but does speed up a bit at least on my setup
17 2017-08-15 05:32:07 0|dermoth|that's blocks from January this year...
18 2017-08-15 05:38:31 0|dermoth|ugh, it's ionice not schedtool I should have been using :/
19 2017-08-15 05:41:44 0|dermoth|ionice -c 3 <command>
20 2017-08-15 06:43:39 0|wumpus|gmaxwell: yes, I'll add that in later
21 2017-08-15 06:44:36 0|wumpus|the only thing I've done is sync from the wiki, and then I had to get a list of names from git too, as crediting only the people mentioned on the wiki was a bit strange
22 2017-08-15 07:07:16 0|bitcoin-git|[13bitcoin] 15zhiweiwong96 opened pull request #11051: Test branch (06master...06testBranch) 02https://github.com/bitcoin/bitcoin/pull/11051
23 2017-08-15 07:15:48 0|bitcoin-git|[13bitcoin] 15fanquake closed pull request #11051: Test branch (06master...06testBranch) 02https://github.com/bitcoin/bitcoin/pull/11051
24 2017-08-15 07:26:42 0|arowser|Hi, if exists a place that can download the dbg file that split from the released bitcoin core ?
25 2017-08-15 07:31:36 0|jonasschnelli|arowser: dbg? You mean the debug symbols?
26 2017-08-15 07:31:44 0|arowser|yes
27 2017-08-15 07:31:55 0|wumpus|AFAIK no one hosts that - they're huge
28 2017-08-15 07:33:06 0|achow101|arowser: for which version?
29 2017-08-15 07:33:17 0|arowser|0.14.2
30 2017-08-15 07:34:20 0|achow101|hmm. I have those locally
31 2017-08-15 07:34:35 0|wumpus|I don't have them at the moment (they're easy to build though)
32 2017-08-15 07:35:17 0|achow101|is there a command line way to put release assets on github? I can upload mine to github, but I'm away from that computer right now
33 2017-08-15 07:36:19 0|wumpus|there might be a way through the API
34 2017-08-15 07:36:36 0|achow101|bleh. the API is a mess
35 2017-08-15 07:37:21 0|wumpus|that might be, but it's the way to do website things though e.g. a command line tool. Easier at least than reverse-engineering what the website does...
36 2017-08-15 07:40:44 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10752: Use quoted form when including primitives/transaction.h and wallet/wallet.h (06master...06transaction-h) 02https://github.com/bitcoin/bitcoin/pull/10752
37 2017-08-15 07:41:43 0|bitcoin-git|[13bitcoin] 15JennHorng opened pull request #11052: Jennhorng dev (06master...06jennhorng-dev) 02https://github.com/bitcoin/bitcoin/pull/11052
38 2017-08-15 07:42:13 0|bitcoin-git|[13bitcoin] 15fanquake closed pull request #11052: Jennhorng dev (06master...06jennhorng-dev) 02https://github.com/bitcoin/bitcoin/pull/11052
39 2017-08-15 07:58:45 0|wumpus|https://developer.github.com/v3/repos/releases/#upload-a-release-asset
40 2017-08-15 08:27:45 0|achow101|arowser: https://github.com/achow101/bitcoin/releases/tag/v0.14.2
41 2017-08-15 08:51:10 0|arowser|achow101: thank you, downloading...
42 2017-08-15 09:02:03 0|arowser|wumus: its not easy to me if not use gitian-builder, and my gitian-builder is broker now :(
43 2017-08-15 09:15:46 0|jonasschnelli|arowser, achow101, wumpus: would those *-debug.tar.gz files do the job: https://bitcoin.jonasschnelli.ch/build/177
44 2017-08-15 09:15:55 0|jonasschnelli|(its 0.14.1)
45 2017-08-15 09:15:58 0|jonasschnelli|(its 0.14.2)
46 2017-08-15 09:59:50 0|wumpus|arowser: I meant it's easy for me, and I'd have built them if achow101 and jonasschnelli hadn't jump in
47 2017-08-15 10:00:31 0|wumpus|jonasschnelli: yes
48 2017-08-15 15:15:18 0|promag|MarcoFalke: is nc something we could use in tests?
49 2017-08-15 15:15:42 0|MarcoFalke|Sorry, what is nc?
50 2017-08-15 15:15:51 0|promag|netcat
51 2017-08-15 15:16:16 0|MarcoFalke|The tests should run on windows as well, so I don't think this would be possible
52 2017-08-15 15:16:26 0|promag|right
53 2017-08-15 15:17:17 0|promag|the idea is to avoid files, have the blocknotify script write to a socket, then read it from python
54 2017-08-15 15:21:21 0|MarcoFalke|oh wait. I am sure blocknotify.py is unlikely to pass on native windows, due to echo.
55 2017-08-15 15:21:56 0|MarcoFalke|So my objection is invalid
56 2017-08-15 15:25:10 0|MarcoFalke|Though, I am not convinced this warrants the extra dependency. It should be doable with just files.
57 2017-08-15 15:29:29 0|promag|we can also ship util scripts to be used in these tests?
58 2017-08-15 15:34:20 0|MarcoFalke|There should be no "loose" scripts hanging around. You can extend ./test_framework/util.py with helper functions.
59 2017-08-15 15:37:37 0|promag|right
60 2017-08-15 15:47:21 0|bitcoin-git|[13bitcoin] 15laanwj opened pull request #11053: refactor: Make all #includes relative to project root (06master...062017_08_includes_absolute) 02https://github.com/bitcoin/bitcoin/pull/11053
61 2017-08-15 15:48:24 0|bitcoin-git|13bitcoin/06master 14f4c3d2c 15Gregory Maxwell: Enable disablesafemode by default....
62 2017-08-15 15:48:24 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/140de14a1222...3841aaf05963
63 2017-08-15 15:48:25 0|bitcoin-git|13bitcoin/06master 143841aaf 15Wladimir J. van der Laan: Merge #11008: Enable disablesafemode by default....
64 2017-08-15 15:49:03 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11008: Enable disablesafemode by default. (06master...06no-safe-mode) 02https://github.com/bitcoin/bitcoin/pull/11008
65 2017-08-15 15:52:09 0|MarcoFalke|^ does this require mention in the release notes for 0.16?
66 2017-08-15 15:56:25 0|MarcoFalke|oh already listed: #11054 :)
67 2017-08-15 15:56:29 0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #11055: getreceivedbyaddress should return error if called with address not owned by the wallet (06master...06getreceivedbyaddress_error) 02https://github.com/bitcoin/bitcoin/pull/11055
68 2017-08-15 15:58:46 0|gribble|https://github.com/bitcoin/bitcoin/issues/11054 | TODO for release notes 0.16.0 ÷ Issue #11054 ÷ bitcoin/bitcoin ÷ GitHub
69 2017-08-15 16:39:04 0|cfields|wumpus: i think #7522 broke version detection for gitian. v0.15.0rc1 binaries show -dirty :(
70 2017-08-15 16:40:08 0|cfields|imo that's no big deal for rc1. I'll try to track down the issue
71 2017-08-15 16:40:14 0|cfields|luke-jr: ^^
72 2017-08-15 16:41:18 0|luke-jr|hmm
73 2017-08-15 16:42:49 0|cfields|luke-jr: i'm just assuming 7522 is what did it, as I can't think of what else might've changed in that regard
74 2017-08-15 16:44:44 0|gribble|https://github.com/bitcoin/bitcoin/issues/7522 | Bugfix: Only use git for build info if the repository is actually the right one by luke-jr ÷ Pull Request #7522 ÷ bitcoin/bitcoin ÷ GitHub
75 2017-08-15 17:29:28 0|bitcoin-git|[13bitcoin] 15instagibbs opened pull request #11056: disable jni in builds (06master...06disablejni) 02https://github.com/bitcoin/bitcoin/pull/11056
76 2017-08-15 17:54:46 0|cfields|luke-jr: will you kill me if i suggest simply reverting 7522? the fixes that i see require moving several things around
77 2017-08-15 18:09:59 0|instagibbs|could someone give 11049 a kick
78 2017-08-15 18:22:50 0|jonasschnelli|instagibbs: done
79 2017-08-15 18:45:17 0|bitcoin-git|13bitcoin/06master 14d3d946a 15practicalswift: Pass SendCoinsRecipient (208 bytes) by const reference
80 2017-08-15 18:45:17 0|bitcoin-git|[13bitcoin] 15jonasschnelli pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/3841aaf05963...64e66bb26288
81 2017-08-15 18:45:18 0|bitcoin-git|13bitcoin/06master 1464e66bb 15Jonas Schnelli: Merge #10964: Pass SendCoinsRecipient (208 bytes) by reference...
82 2017-08-15 18:45:31 0|bitcoin-git|[13bitcoin] 15jonasschnelli closed pull request #10964: Pass SendCoinsRecipient (208 bytes) by reference (06master...06pass-big-parameters-by-reference) 02https://github.com/bitcoin/bitcoin/pull/10964
83 2017-08-15 18:55:27 0|jonasschnelli|Just catching up the last 1 week on mainnet with 0.15.0rc1 and the GUI is very responsive...
84 2017-08-15 19:17:23 0|cfields_|gitian builders: v0.15.0rc1 detached sigs have been pushed
85 2017-08-15 19:31:47 0|bitcoin-git|13bitcoin/06master 1403bc719 15Karl-Johan Alm: [wallet] Close DB on error.
86 2017-08-15 19:31:47 0|bitcoin-git|[13bitcoin] 15jonasschnelli pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/64e66bb26288...ae47724687a7
87 2017-08-15 19:31:48 0|bitcoin-git|13bitcoin/06master 14ae47724 15Jonas Schnelli: Merge #11017: [wallet] Close DB on error....
88 2017-08-15 19:32:09 0|bitcoin-git|[13bitcoin] 15jonasschnelli closed pull request #11017: [wallet] Close DB on error. (06master...06close-dbenv) 02https://github.com/bitcoin/bitcoin/pull/11017
89 2017-08-15 19:34:13 0|bitcoin-git|[13bitcoin] 15jonasschnelli closed pull request #10989: RPC: Restore backward compatibility, in multiwallet mode (06master...06multiwallet_rpccompat) 02https://github.com/bitcoin/bitcoin/pull/10989
90 2017-08-15 20:04:46 0|luke-jr|cfields_: 7522 is a bug fix. it should not be reverted.
91 2017-08-15 20:04:56 0|luke-jr|unless you have a better fix, I guess.
92 2017-08-15 20:09:50 0|cfields_|luke-jr: suggestions for fixing the issue, then? Setting GIT_DIR in the gitian script throws off 'git diff' in a way that i don't really understand
93 2017-08-15 20:10:28 0|luke-jr|probably the best way, would be to have the tarball-source build with the version we want, and don't rely on git at all
94 2017-08-15 20:10:48 0|luke-jr|maybe that's already the case, and we should just drop GIT_DIR?
95 2017-08-15 20:11:59 0|cfields_|luke-jr: agreed, but i think it's too late for those types of changes for 0.15
96 2017-08-15 20:12:11 0|luke-jr|what happens if we just drop GIT_DIR right now?
97 2017-08-15 20:12:41 0|cfields_|pretty sure it ends up with unknown version
98 2017-08-15 20:12:56 0|luke-jr|:/
99 2017-08-15 20:13:05 0|luke-jr|does that mean building from the source tarball is similarly broken?
100 2017-08-15 20:13:52 0|cfields_|hmm, probably
101 2017-08-15 20:14:52 0|cfields_|checking
102 2017-08-15 20:20:22 0|cfields_|"Bitcoin Core Daemon version v0.15.0.0-g252ca9c"
103 2017-08-15 20:21:08 0|luke-jr|I guess that's what we want?
104 2017-08-15 20:22:33 0|cfields_|well the tag would be ideal, but i don't think it's different from before
105 2017-08-15 20:23:24 0|cfields_|what's broken is the tag detection when building from git because the work-tree check now fails
106 2017-08-15 20:23:36 0|luke-jr|IMO we should have it so the result is the same as building from the source tarball, and if that isn't what is ideal, we should fix that so it is ;)
107 2017-08-15 20:24:06 0|cfields_|er, that's not right. I think that works, but 'git diff' thinks there are extra files dirtying things up
108 2017-08-15 20:24:08 0|luke-jr|the work-tree check *should* fail in gitian, since gitian doesn't build from git
109 2017-08-15 20:24:44 0|cfields_|it builds from a workdir that's part of the git tree
110 2017-08-15 20:25:07 0|luke-jr|it's not part of the git tree..
111 2017-08-15 20:25:21 0|luke-jr|it just happens to be in a directory below the git tree's root
112 2017-08-15 20:25:23 0|cfields_|it builds in a subdir of the repo
113 2017-08-15 20:25:24 0|cfields_|right
114 2017-08-15 20:25:44 0|cfields_|sorry, work-tree has a specific meaning in this discussion :)
115 2017-08-15 20:26:01 0|luke-jr|one that isn't met by what we're doing there ;)
116 2017-08-15 20:27:01 0|cfields_|yea, we need to change the gitian layout and embed the version into the tarball. But I'd really not do all that at this stage
117 2017-08-15 20:28:09 0|luke-jr|"v0.15.0.0-g252ca9c" seems fine until we do?
118 2017-08-15 20:29:45 0|cfields_|luke-jr: it's what shows on the splash screen. All other stable versions have had the correct (tag) string.
119 2017-08-15 20:33:28 0|luke-jr|a simple hacky workaround would be to have gitian make a build.h file
120 2017-08-15 21:38:37 0|bitcoin-git|13bitcoin/06master 147897338 15John Newbery: [tests] Introduce TestNode...
121 2017-08-15 21:38:37 0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/ae47724687a7...85aec87b11ec
122 2017-08-15 21:38:38 0|bitcoin-git|13bitcoin/06master 1485aec87 15MarcoFalke: Merge #10711: [tests] Introduce TestNode...
123 2017-08-15 21:38:56 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #10711: [tests] Introduce TestNode (06master...06testnode2) 02https://github.com/bitcoin/bitcoin/pull/10711
124 2017-08-15 22:33:35 0|bitcoin-git|13bitcoin/06master 14f42fc1d 15klemens: doc: spelling fixes
125 2017-08-15 22:33:35 0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/85aec87b11ec...d7be7b39fa10
126 2017-08-15 22:33:36 0|bitcoin-git|13bitcoin/06master 14d7be7b3 15MarcoFalke: Merge #10705: Trivial: spelling fixes...
127 2017-08-15 22:34:00 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #10705: Trivial: spelling fixes (06master...06feature/spelling) 02https://github.com/bitcoin/bitcoin/pull/10705
128 2017-08-15 22:40:39 0|bitcoin-git|13bitcoin/06master 149d5e98f 15practicalswift: Fix typos.
129 2017-08-15 22:40:39 0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/d7be7b39fa10...4fb258666147
130 2017-08-15 22:40:40 0|bitcoin-git|13bitcoin/06master 144fb2586 15MarcoFalke: Merge #10956: Fix typos...
131 2017-08-15 22:41:19 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #10956: Fix typos (06master...06typos-201708) 02https://github.com/bitcoin/bitcoin/pull/10956
132 2017-08-15 22:50:04 0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/4fb258666147...636694127534
133 2017-08-15 22:50:05 0|bitcoin-git|13bitcoin/06master 141d8df01 15MeshCollider: Fix MD formatting in REST-interface.md and spelling mistake in...
134 2017-08-15 22:50:05 0|bitcoin-git|13bitcoin/06master 1441f3e84 15MeshCollider: Fix inconsistencies and grammar in various files
135 2017-08-15 22:50:06 0|bitcoin-git|13bitcoin/06master 146366941 15MarcoFalke: Merge #10680: Fix inconsistencies and grammar in various files...
136 2017-08-15 22:50:26 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #10680: Fix inconsistencies and grammar in various files (06master...06fix_typos_and_inconsistencies) 02https://github.com/bitcoin/bitcoin/pull/10680
137 2017-08-15 23:32:26 0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/636694127534...7db65c363a0c
138 2017-08-15 23:32:27 0|bitcoin-git|13bitcoin/06master 1408f71c2 15Gregory Maxwell: [Trivial] Add a comment on the use of prevector in script.
139 2017-08-15 23:32:27 0|bitcoin-git|13bitcoin/06master 147db65c3 15MarcoFalke: Merge #11011: [Trivial] Add a comment on the use of prevector in script....
140 2017-08-15 23:33:00 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #11011: [Trivial] Add a comment on the use of prevector in script. (06master...06201708-prevector-comment) 02https://github.com/bitcoin/bitcoin/pull/11011