1 2017-08-16 00:13:09	0|bitcoin-git|13bitcoin/06master 146e8c48d 15practicalswift: Add const to methods that do not modify the object for which it is called
 2 2017-08-16 00:13:09	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/7db65c363a0c...b6a48914c506
 3 2017-08-16 00:13:10	0|bitcoin-git|13bitcoin/06master 14b6a4891 15MarcoFalke: Merge #9964: Add const to methods that do not modify the object for which it is called...
 4 2017-08-16 00:13:21	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #9964: Add const to methods that do not modify the object for which it is called (06master...06const) 02https://github.com/bitcoin/bitcoin/pull/9964
 5 2017-08-16 00:20:53	0|gmaxwell|0.15 branch has a warning now
 6 2017-08-16 00:20:55	0|gmaxwell|wallet/wallet.cpp:3668:38: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
 7 2017-08-16 00:20:58	0|gmaxwell|return setExternalKeyPool.size() >= min_keys && (setInternalKeyPool.size() >= min_keys || !CanSupportFeature(FEATURE_HD_SPLIT));
 8 2017-08-16 00:21:01	0|gmaxwell|^
 9 2017-08-16 00:21:04	0|gmaxwell|wallet/wallet.cpp:3668:80: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
10 2017-08-16 00:21:07	0|gmaxwell|return setExternalKeyPool.size() >= min_keys && (setInternalKeyPool.size() >= min_keys || !CanSupportFeature(FEATURE_HD_SPLIT));
11 2017-08-16 00:24:42	0|BlueMatt|well we're gonna do an rc2 anyway, for the version issue, right?
12 2017-08-16 00:27:06	0|Lightsword|has anyone verified that getentropy is getting built for release builds on osx?
13 2017-08-16 00:32:36	0|bitcoin-git|13bitcoin/06master 149862550 15practicalswift: Use the noexcept specifier (C++11) instead of deprecated throw()
14 2017-08-16 00:32:36	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/b6a48914c506...655970d9c60a
15 2017-08-16 00:32:37	0|bitcoin-git|13bitcoin/06master 14655970d 15MarcoFalke: Merge #10965: Replace deprecated throw() with noexcept specifier (C++11)...
16 2017-08-16 00:33:08	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #10965: Replace deprecated throw() with noexcept specifier (C++11) (06master...06noexcept) 02https://github.com/bitcoin/bitcoin/pull/10965
17 2017-08-16 00:34:08	0|jimpo|Is it preferred to have function/method comments in the header files or cpp files? (I would think header?)
18 2017-08-16 00:34:59	0|sipa|yes, header
19 2017-08-16 00:35:05	0|sipa|unless they're implementation details
20 2017-08-16 00:37:22	0|gmaxwell|jimpo: header should comment the interface, cpp the implementation, generally. (I don't think we've documented it in our coding style docs, but it's my preference)
21 2017-08-16 00:37:45	0|jimpo|Understood, thx
22 2017-08-16 00:48:39	0|bitcoin-git|13bitcoin/06master 143eb53b8 15practicalswift: Avoid returning a BIP9Stats object with uninitialized values...
23 2017-08-16 00:48:39	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/655970d9c60a...a46a671e2535
24 2017-08-16 00:48:40	0|bitcoin-git|13bitcoin/06master 14a46a671 15MarcoFalke: Merge #10957: Avoid returning a BIP9Stats object with uninitialized values...
25 2017-08-16 00:49:06	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #10957: Avoid returning a BIP9Stats object with uninitialized values (06master...06bip9status) 02https://github.com/bitcoin/bitcoin/pull/10957
26 2017-08-16 01:25:47	0|bitcoin-git|[13bitcoin] 15jimpo opened pull request #11058: Comments: More comments on functions/globals in standard.h. (06master...06standard-comments) 02https://github.com/bitcoin/bitcoin/pull/11058
27 2017-08-16 02:15:15	0|bitcoin-git|[13bitcoin] 15Ilikenumber0 opened pull request #11059: Its just for education, not a real pull request (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/11059
28 2017-08-16 02:17:42	0|bitcoin-git|[13bitcoin] 15sipa closed pull request #11059: Its just for education, not a real pull request (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/11059
29 2017-08-16 06:22:14	0|wumpus|cfields_: as long as it is deterministic, it is no big deal
30 2017-08-16 06:30:40	0|bitcoin-git|13bitcoin/06master 14844b73e 15Gregory Sanders: disable jni in builds
31 2017-08-16 06:30:40	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/a46a671e2535...d451d0bcf15d
32 2017-08-16 06:30:41	0|bitcoin-git|13bitcoin/06master 14d451d0b 15Wladimir J. van der Laan: Merge #11056: disable jni in builds...
33 2017-08-16 06:31:20	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11056: disable jni in builds (06master...06disablejni) 02https://github.com/bitcoin/bitcoin/pull/11056
34 2017-08-16 07:36:48	0|wumpus|as I had to test binary upload I've already uploaded rc1 to both sites https://bitcoin.org/bin/bitcoin-core-0.15.0/test.rc1/   https://bitcoincore.org/bin/bitcoin-core-0.15.0/test.rc1/ - but we should wait with announcing this publicly until there's at least two more gitian sigs for the code-signed executables
35 2017-08-16 08:25:23	0|bitcoin-git|[13bitcoin] 15kallewoof opened pull request #11062: [mempool] Mark mempool import fails that were found in mempool as 'already there' (06master...06mempool-alreadythere) 02https://github.com/bitcoin/bitcoin/pull/11062
36 2017-08-16 08:31:14	0|fanquake|wumpus I've pushed up signed sigs
37 2017-08-16 10:48:19	0|wumpus|fanquake: thanks!
38 2017-08-16 13:59:07	0|bitcoin-git|13bitcoin/06master 1436d326e 15practicalswift: Use nullptr instead of zero (0) as the null pointer constant
39 2017-08-16 13:59:07	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/d451d0bcf15d...c484ec6c9b85
40 2017-08-16 13:59:08	0|bitcoin-git|13bitcoin/06master 14c484ec6 15MarcoFalke: Merge #10645: Use nullptr (C++11) instead of zero (0) as the null pointer constant...
41 2017-08-16 13:59:27	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #10645: Use nullptr (C++11) instead of zero (0) as the null pointer constant (06master...06welcome-nullptr-goodbye-0) 02https://github.com/bitcoin/bitcoin/pull/10645
42 2017-08-16 14:12:49	0|bitcoin-git|13bitcoin/06master 14a622a17 15João Barbosa: Fix constness of ArgsManager methods
43 2017-08-16 14:12:49	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/c484ec6c9b85...22e301a3d56d
44 2017-08-16 14:12:50	0|bitcoin-git|13bitcoin/06master 1422e301a 15MarcoFalke: Merge #10901: Fix constness of ArgsManager methods...
45 2017-08-16 14:13:21	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #10901: Fix constness of ArgsManager methods (06master...062017-07-args-manager-constness) 02https://github.com/bitcoin/bitcoin/pull/10901
46 2017-08-16 15:07:28	0|BlueMatt|alrighty, what should I be reviewing?
47 2017-08-16 15:24:01	0|promag|BlueMatt: #11006 it's one line :P
48 2017-08-16 15:28:43	0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #11066: Document the preference of nullptr over NULL or (void*)0 (06master...06document-nullptr-preference) 02https://github.com/bitcoin/bitcoin/pull/11066
49 2017-08-16 15:36:06	0|gribble|https://github.com/bitcoin/bitcoin/issues/11006 | Improve shutdown process by promag · Pull Request #11006 · bitcoin/bitcoin · GitHub
50 2017-08-16 15:49:56	0|BlueMatt|cfields: can you rebase #10756 ?
51 2017-08-16 15:51:04	0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #11067: [qa] TestNode: Add wait_until_node_stopped helper method (06master...06Mf1708-qaTestnodeWaitStopHelper) 02https://github.com/bitcoin/bitcoin/pull/11067
52 2017-08-16 15:51:54	0|cfields|BlueMatt: sure
53 2017-08-16 16:01:17	0|gribble|https://github.com/bitcoin/bitcoin/issues/10756 | net processing: swap out signals for an interface class by theuni · Pull Request #10756 · bitcoin/bitcoin · GitHub
54 2017-08-16 16:08:02	0|BlueMatt|cfields: thnks, gonna take a crack at rebasing on it :)
55 2017-08-16 16:19:09	0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #11068: [WIP] qa: Replace wait_until with wait_until_mn (scripted) (06master...06Mf1708-qaWaitUntilMiniNode) 02https://github.com/bitcoin/bitcoin/pull/11068
56 2017-08-16 16:56:17	0|bitcoin-git|[13bitcoin] 15popenkomaksim opened pull request #11069: Trivial: Lossless image optimization. (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/11069
57 2017-08-16 17:31:49	0|cfields|morcos: ping
58 2017-08-16 17:33:17	0|cfields|morcos: while profiling some new net code yesterday, i noticed that TxConfirmStats::UpdateMovingAverages is a notable hotspot
59 2017-08-16 17:34:01	0|cfields|during IBD, it accounted for ~5-10% of the message handler thread
60 2017-08-16 17:35:46	0|cfields|cpu usage, that is
61 2017-08-16 17:39:20	0|sipa|cfields: during IBD? :o
62 2017-08-16 17:39:52	0|cfields|sipa: that was my thought :\
63 2017-08-16 17:40:04	0|cfields|IBD up to 200k blocks, anyway
64 2017-08-16 17:45:23	0|BlueMatt|cfields: well, it'll be in the background in 16 :/
65 2017-08-16 17:46:13	0|cfields|BlueMatt: surely it's not necessary until we're nearly caught up?
66 2017-08-16 17:51:41	0|sdaftuar|cfields: i'd guess the implementation is probably just trying to make sure that the estimates properly decay when a node is catching up after being down for a while
67 2017-08-16 17:55:08	0|cfields|well i have a quick optim to speed up that function, but i figured it'd just result in a discussion about avoiding it during early IBD
68 2017-08-16 17:55:24	0|gmaxwell|I assume a simple branch to skip decays when everything is zero would speed that right up.
69 2017-08-16 17:55:47	0|cfields|I'll PR the speedup, and create an issue to discuss avoidance
70 2017-08-16 17:56:23	0|gmaxwell|sipa: we test too much with reindex chainstate
71 2017-08-16 17:56:51	0|cfields|gmaxwell: ah, i was wondering why you hadn't nagged about it :)
72 2017-08-16 18:22:53	0|cfields|BlueMatt: rebased
73 2017-08-16 18:58:51	0|BlueMatt|gmaxwell: well its gonna be slow after sync anyway, so just move it into the background where it wont slow down ibd at all and will be fast later, too :p
74 2017-08-16 18:58:52	0|BlueMatt|cfields: thanks
75 2017-08-16 19:00:11	0|gmaxwell|BlueMatt: well I agree, but a branch on already zero is perhaps a four line change.
76 2017-08-16 19:04:18	0|BlueMatt|gmaxwell: a branch to put it in the background is probably 3 at this point :p
77 2017-08-16 19:06:29	0|BlueMatt|can someone remind me whats left to switch the sync.h stuff to std::mutex?
78 2017-08-16 19:06:41	0|BlueMatt|looks like it may be needed for #10923
79 2017-08-16 19:07:06	0|gribble|https://github.com/bitcoin/bitcoin/issues/10923 | Use -Wthread-safety-analysis if available (+ -Werror=[…] if --enable-werror) by practicalswift · Pull Request #10923 · bitcoin/bitcoin · GitHub
80 2017-08-16 19:34:28	0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #11071: Use static_assert(…, …) instead of assert(…) where appropriate (06master...06static_assert) 02https://github.com/bitcoin/bitcoin/pull/11071
81 2017-08-16 19:37:11	0|morcos|cfields: hmm...  that's somewhat surprising, but yes i guess if all the other operations are basically very quick with the early blocks, that one takes just as long
82 2017-08-16 19:37:20	0|morcos|i'd be happy to look at your speedup
83 2017-08-16 19:38:16	0|morcos|i think we could also do something relatively simple to avoid doing it if blocks are less than some reasonable checkpointed height or something
84 2017-08-16 19:55:06	0|BlueMatt|morcos: the height-at-which-0.15-was-released is sufficient, cause your estimates get wiped anyway :p
85 2017-08-16 21:00:46	0|jimpo|If I rebroadcast an already-confirmed transaction, will Bitcoin Core nodes add it as an orphan tx?
86 2017-08-16 21:03:14	0|sipa|it may
87 2017-08-16 21:04:54	0|jimpo|I see this https://github.com/bitcoin/bitcoin/blob/master/src/validation.cpp#L545
88 2017-08-16 21:05:42	0|jimpo|When would an old output be in the pcoinsTip cache?
89 2017-08-16 21:06:14	0|sipa|because its output isn't spent yet
90 2017-08-16 21:06:37	0|jimpo|OK, makes sense
91 2017-08-16 21:17:12	0|jimpo|So in the case where you rebroadcast a transaction with all spent outputs, and it is added as an orphan, the node will then reject all of the parent transactions to that one?
92 2017-08-16 21:17:21	0|jimpo|request* not reject
93 2017-08-16 21:17:40	0|sipa|right, which other peers likely don't have anymore