1 2017-08-25 01:02:44	0|bitcoin-git|13bitcoin/06master 14f1708ef 15practicalswift: Add recommendation: By default, declare single-argument constructors `explicit`
  2 2017-08-25 01:02:44	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/77fc469fc78c...3f726c99f819
  3 2017-08-25 01:02:45	0|bitcoin-git|13bitcoin/06master 143f726c9 15MarcoFalke: Merge #11112: [developer-notes] By default, declare single-argument constructors "explicit"...
  4 2017-08-25 01:03:18	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #11112: [developer-notes] By default, declare single-argument constructors "explicit" (06master...06declare-single-argument-constructors-explicit) 02https://github.com/bitcoin/bitcoin/pull/11112
  5 2017-08-25 03:09:03	0|luke-jr|hm, do we still warn about BIP91?
  6 2017-08-25 03:31:49	0|meshcollider|sipa: gmaxwell is the idea that the full serialised transaction has to be obtainable just from the compressed transaction, for hashing, etc? i.e. no throwing away of data even if it's unused but hashed?
  7 2017-08-25 03:45:03	0|Lightsword|luke-jr, warn about what in regards to BIP91?
  8 2017-08-25 03:46:15	0|sipa|meshcollider: indeed
  9 2017-08-25 03:46:48	0|luke-jr|Lightsword: unknown versionbit deployment
 10 2017-08-25 03:47:29	0|Lightsword|luke-jr, why would it be showing anything anymore? it didn’t use.a 2016 block activation period so it shouldn’t show as activated
 11 2017-08-25 03:49:06	0|Lightsword|hmm, well I do see “Warning: Unknown block versions being mined! It's possible unknown rules are in effect” but that’s not a version bit specific warning right?
 12 2017-08-25 03:49:47	0|Lightsword|warning='59 of last 100 blocks have unexpected version'
 13 2017-08-25 03:50:17	0|sipa|Lightsword: those are from miners who are still signalling segwit
 14 2017-08-25 03:50:27	0|sipa|not bip91
 15 2017-08-25 03:50:31	0|Lightsword|yep…guess I’ll tell them to turn that off
 16 2017-08-25 04:03:24	0|luke-jr|ah
 17 2017-08-25 04:10:34	0|gmaxwell|meshcollider: because the hashes are normative there is no unused data.
 18 2017-08-25 04:18:10	0|meshcollider|i mean unused in the sense of having no actual function, not just unused in general. E.g. the transaction locktime, if all the sequence numbers are set to 0xffffffff
 19 2017-08-25 04:19:55	0|gmaxwell|meshcollider: almost always the locktime is zero in that case, however.
 20 2017-08-25 04:23:13	0|meshcollider|yeah I'd imagine so, so most of the time it would be encoded in the TxHeader in that case right 👍
 21 2017-08-25 04:25:31	0|meshcollider|what is the reason for choosing 0-14 for the nLockTime = TxVersionCode? Why 14?
 22 2017-08-25 04:30:24	0|gmaxwell|that is a misprint, that is nVersion = TxVersionCode.
 23 2017-08-25 04:30:49	0|gmaxwell|(because why would nLocktime be _versionCode_ :) )
 24 2017-08-25 04:31:14	0|gmaxwell|so tx versions 0-14 are explicitly coded, and any version greater than that ends up as a uint32.
 25 2017-08-25 04:32:11	0|meshcollider|mhm I did wonder haha, seemed odd. sipa, you might want to update that
 26 2017-08-25 04:32:25	0|gmaxwell|the document isn't really intended for public consumption.
 27 2017-08-25 04:33:07	0|gmaxwell|(not to say that he won't fix it, but this is just working notes)
 28 2017-08-25 04:36:25	0|meshcollider|regardless, was there any specific reason for choosing 14 for the version code?
 29 2017-08-25 04:38:54	0|gmaxwell|because it room for plenty of transaction versions, and leaves space to signal future encoding versions.
 30 2017-08-25 04:45:24	0|meshcollider|makes sense :) are the blank sections not thought out or just not written up
 31 2017-08-25 04:46:14	0|meshcollider|guessing the latter because back references sounds like something which wouldn't just be added in without a plan
 32 2017-08-25 04:53:55	0|gmaxwell|it's just not written up. pieter implemented an encoder, which is how we know what the space savings is.
 33 2017-08-25 04:54:28	0|gmaxwell|(actually it looks like all the parts are actually describe in the bulleted lists, but not explained)
 34 2017-08-25 05:14:28	0|meshcollider|it looks really well thought out and comprehensive to me, that's awesome :) so would compressed blocks just have a new compressed block header and contain compressed transactions like this?
 35 2017-08-25 05:16:03	0|luke-jr|meshcollider: blocks aren't typically transmitted as a big data blob anymore anyway
 36 2017-08-25 05:16:26	0|gmaxwell|except in ibd.
 37 2017-08-25 05:16:42	0|gmaxwell|it's just an alternative encoding of transactions, and blocks are transmited as a header and a bunch of transactions.
 38 2017-08-25 05:18:02	0|meshcollider|Ah I guess block headers are only 80 bytes anyway, probably not worth even trying to compress them more?
 39 2017-08-25 05:18:34	0|luke-jr|they're already compressed somewhat IIRC
 40 2017-08-25 05:18:47	0|gmaxwell|well for headers messages it's useful to compact them, but thats pretty orthorgonal to blocks.
 41 2017-08-25 05:18:48	0|luke-jr|(when sent as a chain, the prevblock part is skipped)
 42 2017-08-25 05:19:11	0|gmaxwell|in a message that sends a lot of headers you can roughly halve their size.
 43 2017-08-25 07:07:58	0|gmaxwell|::sigh::
 44 2017-08-25 07:08:09	0|gmaxwell|2017-08-25 06:50:40.485126 UpdateTip: new best=0000000000000000007a3061573f5bba379cc02eb472e96f0941d37548fd2982 height=481946 version=0x20000002 log2_work=86.989803 tx=249281504 date='2017-08-25 06:50:23' progress=1.000000 cache=14.2MiB(50014txo) warning='60 of last 100 blocks have unexpected version'
 45 2017-08-25 07:17:34	0|gmaxwell|wumpus: gonna updates submittx for segwit?
 46 2017-08-25 07:18:17	0|wumpus|gmaxwell: it's in the plans
 47 2017-08-25 07:24:50	0|gmaxwell|wumpus: hurray.
 48 2017-08-25 07:52:16	0|Murch|gmaxwell: Am I correct to assume that SegWit will be supported in 0.15.1 and that could be expected shortly after 0.15?
 49 2017-08-25 07:54:31	0|gmaxwell|yes, thats our current tenative plan.
 50 2017-08-25 07:54:50	0|gmaxwell|(I say tenative just because the work hasn't been done yet, people are working on it)
 51 2017-08-25 07:55:20	0|gmaxwell|(of course, much of the backend wallet support was already done as part of the development of segwit itself... just not the more user facing parts)
 52 2017-08-25 07:59:08	0|Murch|okay
 53 2017-08-25 08:00:13	0|Murch|By the way that was our TX: https://www.smartbit.com.au/tx/bf031d49f30565e2c66a9ee736d1bf6ccebcadb46c922ee899d179aa1e1aaf45 :)
 54 2017-08-25 08:38:34	0|gmaxwell|00000000000000000139cb443e16442fcd07a4a0e0788dd045ee3cf268982016  ... A block larger than 1MB!
 55 2017-08-25 08:38:55	0|gmaxwell|also, three cheers for bc.i for actually displaying this fact! https://blockchain.info/block-height/481947
 56 2017-08-25 08:39:28	0|gmaxwell|murch: congrats on your txn.
 57 2017-08-25 09:11:56	0|juscamarena|I made this one that made it go over 1MB https://blockchain.info/tx/8ef2d3c3e8ff4d937746aa39677b347c043287c1fbfeda34b9c241f1e85173ec thanks again for segwit! Works great!
 58 2017-08-25 09:13:14	0|gmaxwell|juscamarena: thanks. we noticed the block earlier.
 59 2017-08-25 09:13:29	0|gmaxwell|we need to do more work reaching out to miners and getting them to fix their settings, lots of confusion.
 60 2017-08-25 09:13:53	0|gmaxwell|(there have been several other points where my node would have mined a greater than 1MB block... but the miner that got the block had a 1MB limit.)
 61 2017-08-25 09:13:58	0|juscamarena|We would have gotten an earlier one but yeah
 62 2017-08-25 10:59:06	0|bitcoin-git|[13bitcoin] 15laanwj opened pull request #11131: rpc: Write authcookie atomically (06master...062017_08_atomic_cookie) 02https://github.com/bitcoin/bitcoin/pull/11131
 63 2017-08-25 11:57:29	0|sturles|Is there a patch to make segwit addresses for change outputs?
 64 2017-08-25 12:36:01	0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #11132: [wallet] Document assumptions that must be fulfilled to avoid NULL pointer dereferences (06master...06document-non-nullptr-assumptions) 02https://github.com/bitcoin/bitcoin/pull/11132
 65 2017-08-25 13:01:18	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #11129: [qa] util: Poll cookie file size before reading (06master...06Mf1708-qaPollCookie) 02https://github.com/bitcoin/bitcoin/pull/11129
 66 2017-08-25 13:29:16	0|instagibbs|what exactly does contrib/verify-commits/verify-commits.sh do?
 67 2017-08-25 13:34:15	0|MarcoFalke|read the commits, starting from HEAD, checking if there is at least one signed parent
 68 2017-08-25 13:34:43	0|MarcoFalke|only taking into account the keys of maintainers
 69 2017-08-25 14:01:36	0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #11133: Document assumptions that must be fulfilled to avoid division by zero (06master...06div0) 02https://github.com/bitcoin/bitcoin/pull/11133
 70 2017-08-25 14:37:29	0|promag|Maybe we should make all RPC responses an JSON object, that way it is easier to avoid breaking changes cc instagibbs
 71 2017-08-25 14:40:00	0|instagibbs|promag, in general avoiding breakage is good, but I think verifytxoutproof is a bit less used(and isn't returning what's actually required to be entirely useful)
 72 2017-08-25 14:41:12	0|promag|yeah, I mean maybe add developer note for future calls.
 73 2017-08-25 14:55:28	0|bitcoin-git|[13bitcoin] 15promag opened pull request #11135: Add RPC response notes (06master...062017-08-rpc-response-notes) 02https://github.com/bitcoin/bitcoin/pull/11135
 74 2017-08-25 16:05:27	0|bitcoin-git|[13bitcoin] 15danra opened pull request #11136: Docs: Add python3 to list of dependencies on macOS (06master...06patch-1) 02https://github.com/bitcoin/bitcoin/pull/11136
 75 2017-08-25 16:24:05	0|bitcoin-git|[13bitcoin] 15danra opened pull request #11138: Compat: Simplify bswap_16 implementation (06master...06patch-2) 02https://github.com/bitcoin/bitcoin/pull/11138
 76 2017-08-25 16:29:34	0|luke-jr|jonasschnelli: what's the status of your stats_*_tmp branches? seems you added a typo? O.o
 77 2017-08-25 16:29:45	0|luke-jr|(precision -> percision)
 78 2017-08-25 16:30:28	0|luke-jr|hm, or maybe the rpc one is obsolete
 79 2017-08-25 16:30:48	0|luke-jr|or both are :x
 80 2017-08-25 16:32:01	0|bitcoin-git|[13bitcoin] 15danra opened pull request #11139: Trivial: Whitespace in bswap_64 implementation (06master...06patch-3) 02https://github.com/bitcoin/bitcoin/pull/11139
 81 2017-08-25 16:41:00	0|bitcoin-git|[13bitcoin] 15danra opened pull request #11140: Trivial: Improve #endif comments (06master...06patch-4) 02https://github.com/bitcoin/bitcoin/pull/11140
 82 2017-08-25 17:11:21	0|bitcoin-git|[13bitcoin] 15wrapperband opened pull request #11142: Enhance getinfo with regtest information (060.15...060.15-GetInfo-regtest) 02https://github.com/bitcoin/bitcoin/pull/11142
 83 2017-08-25 17:18:20	0|rhavar|For a "pure" segwit transaction (p2sh) is this formula correct:  estimatedVSizeOfSegwitTransaction(inputCount, outputCount) { return 92 * inputCount + 12 + 32 * outputCount; }
 84 2017-08-25 17:21:57	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #11142: Enhance getinfo with regtest information (060.15...060.15-GetInfo-regtest) 02https://github.com/bitcoin/bitcoin/pull/11142
 85 2017-08-25 17:28:15	0|bitcoin-git|[13bitcoin] 15danra opened pull request #11143: Fix include path for bitcoin-config.h (06master...06patch-5) 02https://github.com/bitcoin/bitcoin/pull/11143
 86 2017-08-25 18:43:41	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #11139: Trivial: Whitespace in bswap_64 implementation (06master...06patch-3) 02https://github.com/bitcoin/bitcoin/pull/11139
 87 2017-08-25 19:13:41	0|bitcoin-git|[13bitcoin] 15danra opened pull request #11144: Move local include to before system includes (06master...06patch-6) 02https://github.com/bitcoin/bitcoin/pull/11144
 88 2017-08-25 19:31:27	0|bitcoin-git|[13bitcoin] 15laanwj pushed 4 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/3f726c99f819...07c92b98e2a0
 89 2017-08-25 19:31:28	0|bitcoin-git|13bitcoin/06master 14d97fe20 15Russell Yanofsky: Move some static functions out of wallet.h/cpp...
 90 2017-08-25 19:31:28	0|bitcoin-git|13bitcoin/06master 14e7fe320 15Russell Yanofsky: MOVEONLY: Fee functions wallet/wallet.cpp -> wallet/fees.cpp
 91 2017-08-25 19:31:29	0|bitcoin-git|13bitcoin/06master 14f01103c 15Russell Yanofsky: MOVEONLY: Init functions wallet/wallet.cpp -> wallet/init.cpp
 92 2017-08-25 19:32:02	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10976: [MOVEONLY] Move some static functions out of wallet.h/cpp (06master...06pr/wmove) 02https://github.com/bitcoin/bitcoin/pull/10976
 93 2017-08-25 20:04:11	0|luke-jr|wumpus: can we get #7339 reopened and in? apparently it won't be n/a as early as expect
 94 2017-08-25 20:15:02	0|bitcoin-git|[13bitcoin] 15morcos opened pull request #11145: Fix rounding bug in calculation of minimum change (06master...06fixrounding) 02https://github.com/bitcoin/bitcoin/pull/11145
 95 2017-08-25 20:15:17	0|morcos|ok sorry guys if i killed 0.15 being on time, please review ^^ ASAP
 96 2017-08-25 20:23:50	0|instagibbs|you can blame the person reporting :P
 97 2017-08-25 20:27:20	0|sipa|oh, wait...
 98 2017-08-25 20:31:04	0|MarcoFalke|I blame Satoshi
 99 2017-08-25 20:39:09	0|gmaxwell|well I'm very glad to have found this, would have been an irritating issue. "payments randomly fail" :(
100 2017-08-25 21:12:40	0|bitcoin-git|[13bitcoin] 15eaxvac opened pull request #11147: Merge remote-tracking branch 'refs/remotes/bitcoin/master' (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/11147
101 2017-08-25 21:12:55	0|bitcoin-git|[13bitcoin] 15eaxvac closed pull request #11147: Merge remote-tracking branch 'refs/remotes/bitcoin/master' (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/11147
102 2017-08-25 21:17:42	0|bitcoin-git|[13bitcoin] 15danra opened pull request #11148: Trivial: Fix outdated comment (06master...06patch-7) 02https://github.com/bitcoin/bitcoin/pull/11148
103 2017-08-25 21:21:36	0|morcos|gmaxwell: yeah unfortunately there are a lot o changes in that code, where fees and change can be adjusted...  so its really hard to think through and be sure there isn't some edge case we're missing.
104 2017-08-25 21:22:38	0|gmaxwell|I feel like we should have some kind of exceptional case flagging infrastructure. So that there are varrious exceptional cases which are triggerable, but should only be triggered by a specific test and otherwise we want to know about them.
105 2017-08-25 21:22:40	0|morcos|it'll be nice to rewrite all this for 0.16...  and i think i still feel it's safer to error there rather than risk continuing in some way
106 2017-08-25 22:25:40	0|bitcoin-git|[13bitcoin] 15danra opened pull request #11149: Use prefix instead of postfix increment/decrement for non-trivial typ… (06master...06prefix-increment) 02https://github.com/bitcoin/bitcoin/pull/11149
107 2017-08-25 22:38:07	0|bitcoin-git|[13bitcoin] 15mess110 opened pull request #11150: [tests] Add getmininginfo functional tests (06master...06test_rpc_getmininginfo) 02https://github.com/bitcoin/bitcoin/pull/11150
108 2017-08-25 22:52:38	0|MarcoFalke|Where did juscamarena report the issue about the fee "rounding bug"?
109 2017-08-25 22:54:18	0|instagibbs|MarcoFalke, originally to me, I forwarded to morcos since it was code he wrote(IIRC)
110 2017-08-25 23:09:57	0|MarcoFalke|Ah
111 2017-08-25 23:10:27	0|MarcoFalke|So the issue is that fees are *underpayed*
112 2017-08-25 23:11:08	0|MarcoFalke|s/payed/paid/
113 2017-08-25 23:49:22	0|instagibbs|it re-tries assuming it has enough input value, then somehow doesn't, and panics