1 2017-09-07 00:01:14	0|wumpus|getting quite tired too
  2 2017-09-07 00:03:45	0|meshcollider|wumpus: re https://github.com/bitcoin/bitcoin/pull/10793#discussion_r137361636 did you want me to change it?
  3 2017-09-07 00:04:13	0|meshcollider|or was that just a reply to dcousens
  4 2017-09-07 00:05:27	0|wumpus|meshcollider: I'd prefer that - I think it'd make sense to restrict that PR what it says in the title;  generally changing &vec[i] to vec.data() + i does nothing to avoid UB
  5 2017-09-07 00:05:49	0|wumpus|which was the idea behind &var[0] to var.data()
  6 2017-09-07 00:06:40	0|sipa|wumpus: &var[0] is inherently invalid for empty vectorz
  7 2017-09-07 00:06:52	0|sipa|while var.data() is allowed for empty vectors
  8 2017-09-07 00:07:09	0|sipa|you're still not allowed to dereference the result of var.data()
  9 2017-09-07 00:07:26	0|sipa|but with &var[0] it's already invalid, whether you use it not
 10 2017-09-07 00:07:53	0|wumpus|yes, I know that
 11 2017-09-07 00:08:23	0|wumpus|that was my point, &var[0] to .data() makes sense, but e.g. &var[42] to var.data()+42 does not
 12 2017-09-07 00:08:36	0|wumpus|which is what meshcollider has extended to scope to in some places in that PR
 13 2017-09-07 00:08:40	0|sipa|oh, i see
 14 2017-09-07 00:08:42	0|meshcollider|yeah I'll revert that
 15 2017-09-07 00:09:13	0|sipa|well, &var[42] is also invalid for a var of length 42 or less
 16 2017-09-07 00:09:32	0|sipa|while var.data() + 42 is always valid, as long as you don't use it
 17 2017-09-07 00:10:09	0|wumpus|still, it's getting used in all those cases
 18 2017-09-07 00:10:19	0|sipa|okay!
 19 2017-09-07 00:10:21	0|wumpus|which is UB in any case
 20 2017-09-07 00:10:32	0|meshcollider|yeah its usually used with memcpy()'s
 21 2017-09-07 00:16:23	0|meshcollider|fixed
 22 2017-09-07 00:16:44	0|meshcollider|poor Travis will be having a hard time with all these commits recently lol
 23 2017-09-07 00:19:39	0|promag|speaking of that, wumpus any idea when you'll check #11006?
 24 2017-09-07 00:20:53	0|promag|It can save some travis resources
 25 2017-09-07 00:25:29	0|wumpus|I'm really confused about that one
 26 2017-09-07 00:28:29	0|wumpus|can't reproduce any problems with it locally, but I'm afraid of bringing back random travis failures. I much prefer it taking somewhat longer to random failures that make people lose trust in the tests
 27 2017-09-07 00:29:10	0|wumpus|I'm not sure what the problem was back then and if you can remove that workaround now, what made it go away
 28 2017-09-07 00:30:05	0|promag|I would say merge as it get a couple more ACK, revert later if needed
 29 2017-09-07 00:31:27	0|promag|I can't figure out if you did that, pass nullptr to timeout
 30 2017-09-07 00:32:04	0|wumpus|no, I never did that, because it means that bitcoind will never terminate if there are open rpc connectinos
 31 2017-09-07 00:32:07	0|wumpus|AFAIK
 32 2017-09-07 00:34:20	0|promag|that is correct, but if the connections are closed then it quits immediately, if not then it will break as it is now
 33 2017-09-07 00:34:37	0|wumpus|so the timeout is there to force any existing RPC connections to terminate
 34 2017-09-07 00:35:03	0|promag|right, for instance, some dumb tests, whatever
 35 2017-09-07 00:36:02	0|wumpus|yes, could be for various reasons, our examples pretty much encourage keeping connections open between commands
 36 2017-09-07 00:36:17	0|promag|in the best scenario, there are no active events and the loop can exit right away
 37 2017-09-07 00:36:33	0|wumpus|(which is more efficient than opening a new connection for every commmand, but we don't want this to hold up the shutdown process, people will get confused)
 38 2017-09-07 00:36:58	0|wumpus|stop means that the process must exit, despite open connections
 39 2017-09-07 00:37:20	0|wumpus|yes, I agree ideally it should exit immediately if there are no active eventw
 40 2017-09-07 00:37:29	0|wumpus|and in say, 3 seconds if there are active events
 41 2017-09-07 00:37:35	0|wumpus|that's why the code is so complicated
 42 2017-09-07 00:39:09	0|promag|so, on my side I did test with different libevent versions, run test suite multiple times.. no issue so far
 43 2017-09-07 00:40:03	0|wumpus|yes, but did you try keeping connections open to the daemon after sending stop?
 44 2017-09-07 00:40:16	0|wumpus|e.g. trying to prevent it from exiting
 45 2017-09-07 00:40:32	0|promag|yes, I did this https://github.com/bitcoin/bitcoin/pull/11006#issuecomment-321954764
 46 2017-09-07 00:40:46	0|wumpus|you've checked that it doesn't quit prematurely, which is great, but only part of the functionality
 47 2017-09-07 00:41:21	0|wumpus|what if you change the sleep(3) to sleep(1000)
 48 2017-09-07 00:41:27	0|wumpus|does it wait 1000 seconds to actually exit?
 49 2017-09-07 00:41:30	0|wumpus|or does it give up after a while
 50 2017-09-07 00:41:51	0|promag|1001sec please
 51 2017-09-07 00:42:14	0|wumpus|lol
 52 2017-09-07 00:42:25	0|promag|but I guess it will break, because of the current code
 53 2017-09-07 00:42:47	0|promag|I mean, it's not graceful quit
 54 2017-09-07 00:43:40	0|promag|err, rebuild, removed worktree
 55 2017-09-07 00:50:15	0|bitcoin-git|13bitcoin/06master 14e91b961 15flack: Create dependencies.md, and link dependencies file from README & build docs
 56 2017-09-07 00:50:15	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/645a7ecc0b8d...f65614726de2
 57 2017-09-07 00:50:16	0|bitcoin-git|13bitcoin/06master 14f656147 15Wladimir J. van der Laan: Merge #10779: Create dependencies.md...
 58 2017-09-07 00:50:40	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10779: Create dependencies.md (06master...06patch-2) 02https://github.com/bitcoin/bitcoin/pull/10779
 59 2017-09-07 00:56:08	0|meshcollider|also wumpus, re #11237, do you want me to fix the weird commit split or leave it as-is
 60 2017-09-07 01:12:54	0|esotericnonsense|hm. promag: i'm looking at adding tests for the weight field in mempool now. can get it to work for txid2 and txid3 but not txid1. sdaftuar's 'add wtxid to mempool entry output'
 61 2017-09-07 01:13:04	0|esotericnonsense|also fails on txid1 if I reuse his test.
 62 2017-09-07 01:16:15	0|bitcoin-git|13bitcoin/06master 14ca67ddf 15esneider: Move the AreInputsStandard documentation next to its implementation
 63 2017-09-07 01:16:15	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/f65614726de2...2a56baf395bf
 64 2017-09-07 01:16:16	0|bitcoin-git|13bitcoin/06master 142a56baf 15MarcoFalke: Merge #10682: Trivial: Move the AreInputsStandard documentation next to its implementation...
 65 2017-09-07 01:16:37	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #10682: Trivial: Move the AreInputsStandard documentation next to its implementation (06master...06move-doc) 02https://github.com/bitcoin/bitcoin/pull/10682
 66 2017-09-07 01:20:51	0|esotericnonsense|i've amended the PR and pointed out the test that fails. my knowledge here is lacking unfortunately.
 67 2017-09-07 02:54:15	0|meshcollider|esotericnonsense: isn't it failing because txid1 has no witness
 68 2017-09-07 02:58:31	0|meshcollider|hmm idk
 69 2017-09-07 02:59:42	0|esotericnonsense|meshcollider: it might be that i'm getting lost in the python framework's definitions
 70 2017-09-07 03:02:04	0|esotericnonsense|from BIP141 i interpret 'base tx size' as tx.serialize() (because it is equivalent to tx.serialize_without_witness()), and tx.serialize_with_witness() as being total transaction size BIP141
 71 2017-09-07 03:03:50	0|meshcollider|yeah that sounds right
 72 2017-09-07 03:05:12	0|esotericnonsense|'size' in the mempool rpc is virtual tx size (weight/4)
 73 2017-09-07 03:06:21	0|esotericnonsense|argh. doh. this makes the entire thing pointless. brain fart.
 74 2017-09-07 03:07:19	0|meshcollider|hmm not quite, virtual size is rounded up to the nearest integer so they're not entirely the same
 75 2017-09-07 03:07:29	0|esotericnonsense|ah yes that's true.
 76 2017-09-07 03:09:50	0|sipa|it's (3*size_without_witness + size + 3)/4
 77 2017-09-07 03:11:23	0|esotericnonsense|size == math.ceil(weight/4) checks out for all three tx in segwit.py. it's just this one for which tx.serialize()*3 + tx.serialize_with_witness() != weight.
 78 2017-09-07 03:11:32	0|esotericnonsense|hm.
 79 2017-09-07 03:11:51	0|meshcollider|sipa: where does the extra +3 come from?
 80 2017-09-07 03:12:16	0|esotericnonsense|meshcollider: it just accomplishes the ceiling function
 81 2017-09-07 03:13:17	0|esotericnonsense|e.g. (3*nowitness + size + 3)/4 == ceil((3*nowitness+size)/4)
 82 2017-09-07 03:13:30	0|esotericnonsense|(where the former uses integer division)
 83 2017-09-07 03:15:59	0|sipa|meshcollider: to round up
 84 2017-09-07 03:16:07	0|sipa|esotericnonsense: right
 85 2017-09-07 03:16:25	0|meshcollider|ok yeah so it relies on integer division, that's where I was confused
 86 2017-09-07 03:16:41	0|meshcollider|Was thinking there might be some reason it was always exactly an integer lol
 87 2017-09-07 03:16:45	0|esotericnonsense|the problem is that i misinterpreted the original rpc call, so knowing size and weight is not useful for my particular case, which means that my PR is probably pointless :)
 88 2017-09-07 03:16:57	0|esotericnonsense|(the intention was to know 'is this a segwit tx')
 89 2017-09-07 03:17:19	0|meshcollider|also kinda relevant is issue #11218, sipa suggested renaming size to vsize
 90 2017-09-07 03:18:21	0|esotericnonsense|the other PR accomplishes what I need, (just check wtxid against txid)
 91 2017-09-07 03:20:01	0|esotericnonsense|if it were base size and not vsize, then my check of bsize*4 != weight would work
 92 2017-09-07 04:30:25	0|jtimon|jnewbery: does BitcoinTestFramework.add_nodes() need to get num_nodes as param, isn't that internal now?
 93 2017-09-07 04:31:42	0|jtimon|never mind, let me read more...
 94 2017-09-07 05:05:11	0|meshcollider|can someone with travis powers restart the failed one here, should be unrelated: https://travis-ci.org/bitcoin/bitcoin/jobs/272710677
 95 2017-09-07 05:07:09	0|meshcollider|can only members with write access restart travis? Seems like that should be a weaker permission, but not really sure how githubs permission model works
 96 2017-09-07 05:15:09	0|kallewoof|meshcollider: restarted
 97 2017-09-07 07:06:34	0|meshcollider|thanks :)
 98 2017-09-07 07:56:02	0|meshcollider|So no IRC meeting this week right?
 99 2017-09-07 11:34:07	0|meshcollider|is this intended behavior? https://i.imgur.com/juKAf1O.png the credit shows the full 7 BTC which was received by the wallet, but it was received on 2 separate addresses in the same transaction (3 and 4 BTC respectively), because from looking at that transaction details window it looks like the full 7 BTC was received on just that one address
100 2017-09-07 11:35:50	0|meshcollider|heh I forgot, everyones in SF so no one will be online at 4:30am sf time
101 2017-09-07 11:37:50	0|meshcollider|but I have a feeling this might be what the change to transactiondesc.cpp in #7101 was trying to fix
102 2017-09-07 11:46:20	0|esotericnonsense|meshcollider: this is feeling oddly familiar, i think i encountered this years ago when splitting coins
103 2017-09-07 12:10:11	0|esotericnonsense|meshcollider: i just tried to test this but forgot that there's special behaviour if you send to your own wallet, doh
104 2017-09-07 12:11:17	0|meshcollider|I just ran 2 regtest nodes on the same machine to do this
105 2017-09-07 12:12:01	0|meshcollider|just run one with -port=whatever and then addnode=127.0.0.1:whatever in the other nodes config
106 2017-09-07 12:13:58	0|esotericnonsense|crafted another one by using -wallet.
107 2017-09-07 12:14:35	0|esotericnonsense|this tx, with 4 outputs, 3 to 'wallet2' and 1 to change in 'wallet1', is showing as three seperate entries/rows in the 'wallet2' node.
108 2017-09-07 12:15:15	0|meshcollider|yep but if you go into the full details of each row, do they all just give the total, not the individual received by that address?
109 2017-09-07 12:15:43	0|esotericnonsense|ah yes.
110 2017-09-07 12:16:13	0|esotericnonsense|it's a bit odd in any case. on the 'sending wallet' it apportions the fee arbitrarily to one output.
111 2017-09-07 12:17:57	0|meshcollider|indeed
112 2017-09-07 12:18:09	0|meshcollider|seems like lots of little bugs are mixed up in this
113 2017-09-07 12:18:18	0|esotericnonsense|receiving end https://i.imgur.com/w4zF6FL.png https://i.imgur.com/SjAAd4x.png https://live.blockcypher.com/btc-testnet/tx/a739c64487f122f8b41644d2f703811167e8613ef616d17346a4570d72f20698/
114 2017-09-07 12:19:00	0|esotericnonsense|it's difficult for me to reason about what you even want it to show really :P
115 2017-09-07 12:21:06	0|meshcollider|Yeah I guess the fee being attributed to a random output kinda makes sense right, its gotta be shown somewhere and you wouldn't want to make another whole row for it in the table
116 2017-09-07 12:22:45	0|meshcollider|its just the full details page, if you open it for any row from the same transaction it should show all inputs from that same transaction right, not just the one. Then it would make sense to have a total on there
117 2017-09-07 12:23:30	0|meshcollider|in a similar way to how its shown on the sending node
118 2017-09-07 12:26:05	0|meshcollider|like, this makes sense for sending https://i.imgur.com/Oz5X45l.png but this doesn't make sense to me for receiving https://i.imgur.com/H5wHdmJ.png
119 2017-09-07 12:27:14	0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #11264: [doc] Fix broken Markdown table in dependencies.md (06master...06dependencies-capitalization) 02https://github.com/bitcoin/bitcoin/pull/11264
120 2017-09-07 15:58:43	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #10731: Escape rather than remove any printable characters in UAs (06master...06log_more_uacomment) 02https://github.com/bitcoin/bitcoin/pull/10731
121 2017-09-07 16:00:03	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #10748: [config] Help text cleanup (06master...06helptextcleanup) 02https://github.com/bitcoin/bitcoin/pull/10748
122 2017-09-07 16:01:48	0|bitcoin-git|13bitcoin/06master 14d2be7b2 15James Evans: Typo in optionsdialog.ui...
123 2017-09-07 16:01:48	0|bitcoin-git|[13bitcoin] 15jonasschnelli pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/2a56baf395bf...9c8f3655cc68
124 2017-09-07 16:01:49	0|bitcoin-git|13bitcoin/06master 149c8f365 15Jonas Schnelli: Merge #10911: [qt] Fix typo and access key in optionsdialog.ui...
125 2017-09-07 16:02:23	0|bitcoin-git|[13bitcoin] 15jonasschnelli closed pull request #10911: [qt] Fix typo and access key in optionsdialog.ui (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/10911
126 2017-09-07 16:04:28	0|MarcoFalke|wumpus: Mind to add the git log to the release notes?
127 2017-09-07 16:04:37	0|MarcoFalke|I'd like to take a look before tagging final
128 2017-09-07 16:20:23	0|bitcoin-git|[13bitcoin] 15laanwj opened pull request #11267: rpc: update cli for estimatefee argument rename (06master...062017_09_renamed_estimatefee_arg) 02https://github.com/bitcoin/bitcoin/pull/11267
129 2017-09-07 16:20:47	0|wumpus|MarcoFalke: ah shit, still need to do that, good point. Not sure I have all the tooling here.
130 2017-09-07 16:21:23	0|bitcoin-git|13bitcoin/06master 14ee4d149 15Matt Corallo: Drop upgrade-cancel callback registration for a generic "resumeable"...
131 2017-09-07 16:21:23	0|bitcoin-git|[13bitcoin] 15jonasschnelli pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/9c8f3655cc68...ea729d55b4db
132 2017-09-07 16:21:24	0|bitcoin-git|13bitcoin/06master 14ea729d5 15Jonas Schnelli: Merge #10770: Drop upgrade-cancel callback registration for a generic "cancelable"...
133 2017-09-07 16:21:48	0|bitcoin-git|[13bitcoin] 15jonasschnelli closed pull request #10770: Drop upgrade-cancel callback registration for a generic "cancelable" (06master...062017-07-upgrade-cancel-nits) 02https://github.com/bitcoin/bitcoin/pull/10770
134 2017-09-07 16:52:14	0|bitcoin-git|[13bitcoin] 15MarcoFalke reopened pull request #10748: [config] Help text cleanup (06master...06helptextcleanup) 02https://github.com/bitcoin/bitcoin/pull/10748
135 2017-09-07 17:02:50	0|bitcoin-git|13bitcoin/06master 149b348ff 15Dan Raviv: Fix memory leaks in qt/guiutil.cpp...
136 2017-09-07 17:02:50	0|bitcoin-git|13bitcoin/06master 14a3624dd 15Jonas Schnelli: Merge #11156: Fix memory leaks in qt/guiutil.cpp...
137 2017-09-07 17:02:50	0|bitcoin-git|[13bitcoin] 15jonasschnelli pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/ea729d55b4db...a3624ddb1a3b
138 2017-09-07 17:03:23	0|bitcoin-git|[13bitcoin] 15jonasschnelli closed pull request #11156: Fix memory leaks in qt/guiutil.cpp (06master...06fix/qt-guiutil-memory-leaks) 02https://github.com/bitcoin/bitcoin/pull/11156
139 2017-09-07 17:16:30	0|bitcoin-git|[13bitcoin] 15jonasschnelli opened pull request #11268: [macOS] remove Growl support, remove unused code (06master...062017/09/rm_growl) 02https://github.com/bitcoin/bitcoin/pull/11268
140 2017-09-07 17:49:34	0|MarcoFalke|cfields: Our travis builds are still broken since yesterday (they bumped the trusty image)
141 2017-09-07 17:49:40	0|MarcoFalke|I have no idea what is going on
142 2017-09-07 17:49:44	0|MarcoFalke|Mind to take a look?
143 2017-09-07 17:49:47	0|MarcoFalke|https://github.com/travis-ci/travis-ci/issues/8315#issuecomment-327537437
144 2017-09-07 17:50:38	0|MarcoFalke|We could reroll to the deprecated image, maybe
145 2017-09-07 18:17:05	0|bitcoin-git|[13bitcoin] 15donaloconnor opened pull request #11269: [Trivial Fix] CTxMemPoolEntry::UpdateAncestorState: modifySiagOps param type (06master...06fix_params_branch) 02https://github.com/bitcoin/bitcoin/pull/11269
146 2017-09-07 18:20:05	0|wumpus|uh oh, the travis upgrade thing happened?
147 2017-09-07 18:20:23	0|wumpus|travisgeddon
148 2017-09-07 18:21:46	0|MarcoFalke|Yeah, looks like other projects are switichg back to the "deprecated" image
149 2017-09-07 18:22:21	0|MarcoFalke|If someone feels like creating a pr: Add `group: deprecated-2017Q3` to .travis.yml
150 2017-09-07 18:47:18	0|kanzure|for this meeting i will be typing everyone's messages. thanks.
151 2017-09-07 18:52:48	0|aj|kanzure: always wanted to be a relay bot when you grew up?
152 2017-09-07 18:55:21	0|wumpus|MarcoFalke etc: draft PR list for 0.15.0 is here https://github.com/bitcoin-core/bitcoin-devwiki/wiki/Pulls-listing-for-0.15.0-(temporary)
153 2017-09-07 18:56:07	0|sipa|that's a long list!
154 2017-09-07 18:56:42	0|wumpus|yes, it's scary :)
155 2017-09-07 18:57:08	0|wumpus|and that's already with most trivials and refactors removed
156 2017-09-07 18:57:11	0|sipa|is it usually that long for a major release?
157 2017-09-07 18:57:54	0|wumpus|a new record every release
158 2017-09-07 18:58:32	0|wumpus|unless I screwed something up while generating it and this is the list since 0.3.x instead ;)
159 2017-09-07 18:58:45	0|sipa|ha
160 2017-09-07 19:00:08	0|sipa|MEETING
161 2017-09-07 19:00:28	0|wumpus|lol
162 2017-09-07 19:01:02	0|achow101|meeting
163 2017-09-07 19:01:04	0|achow101|?
164 2017-09-07 19:01:04	0|sdaftuar|hi
165 2017-09-07 19:01:12	0|jnewbery|hi
166 2017-09-07 19:01:24	0|meshcollider|Hello :)
167 2017-09-07 19:01:38	0|gmaxwell|#bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101
168 2017-09-07 19:01:53	0|instagibbs|hi
169 2017-09-07 19:01:55	0|BlueMatt|no?
170 2017-09-07 19:02:00	0|bitcoin-git|[13bitcoin] 15laanwj opened pull request #11270: travis: Use deprecated trusty image (06master...062017_09_travis_deprecated_image) 02https://github.com/bitcoin/bitcoin/pull/11270
171 2017-09-07 19:02:01	0|MarcoFalke|wha?
172 2017-09-07 19:02:02	0|CodeShark|are we doing this meeting? lol
173 2017-09-07 19:02:08	0|MarcoFalke|topics ... ?
174 2017-09-07 19:02:13	0|cfields|hi
175 2017-09-07 19:02:15	0|BlueMatt|we already said we were not doing meeting this week
176 2017-09-07 19:02:17	0|BlueMatt|iirc
177 2017-09-07 19:02:24	0|BlueMatt|^^^
178 2017-09-07 19:02:25	0|wumpus|lol did you ac tually start the meeting?
179 2017-09-07 19:02:37	0|achow101|no one started it yet
180 2017-09-07 19:02:56	0|cdecker|The one time I could participate...
181 2017-09-07 19:03:17	0|jonasschnelli|hi
182 2017-09-07 19:03:43	0|achow101|how about we meet irl ad kanzure transcribes to irc
183 2017-09-07 19:03:52	0|achow101|s/ad/and/
184 2017-09-07 19:04:11	0|gmaxwell|We can tell sdaftuar all the great work we came up with for him to handle.
185 2017-09-07 19:04:34	0|BlueMatt|yea, sdaftuar is building segwit-wallet, right?
186 2017-09-07 19:04:57	0|BlueMatt|and sipa is being force-nominated wallet maintainer,  so gets to review all of it :p
187 2017-09-07 19:05:06	0|luke-jr|I thought we would meet IRL, and kanzure transcribe it all to IRC
188 2017-09-07 19:05:33	0|meshcollider|lol
189 2017-09-07 19:06:01	0|kanzure|hi.
190 2017-09-07 19:06:19	0|kanzure|yeah i'm fine wit hthat
191 2017-09-07 19:06:34	0|sdaftuar|if you can predict the times i'll chime in and type that up as well that'd be great k thanks
192 2017-09-07 19:06:45	0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/a3624ddb1a3b...e7f125562fbb
193 2017-09-07 19:06:46	0|bitcoin-git|13bitcoin/06master 143b69a08 15MeshCollider: Fix division by zero in time remaining
194 2017-09-07 19:06:47	0|bitcoin-git|13bitcoin/06master 14c8d38ab 15MeshCollider: Refactor tipUpdate as per style guide
195 2017-09-07 19:06:47	0|bitcoin-git|13bitcoin/06master 14e7f1255 15Wladimir J. van der Laan: Merge #11237: qt: Fixing division by zero in time remaining...
196 2017-09-07 19:07:23	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11237: qt: Fixing division by zero in time remaining (06master...06201709_fix_estimated_time) 02https://github.com/bitcoin/bitcoin/pull/11237
197 2017-09-07 19:08:38	0|jtimon|perhaps a short summary of how are things going in the phisical meeting instead of the IRC meeting?
198 2017-09-07 19:08:57	0|jtimon|or kanzure's option sounds good too
199 2017-09-07 19:09:38	0|kanzure|there's various text from last few days, although not as much as zurich
200 2017-09-07 19:09:43	0|bitcoin-git|13bitcoin/06master 14061297f 15jjz: Ensure that data types are consistent...
201 2017-09-07 19:09:43	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/e7f125562fbb...2f0d3e604aa9
202 2017-09-07 19:09:44	0|bitcoin-git|13bitcoin/06master 142f0d3e6 15Wladimir J. van der Laan: Merge #11232: Ensure that data types are consistent...
203 2017-09-07 19:09:54	0|meshcollider|wumpus: #11265 can be closed now that #11237 was merged, GitHub must not understand a comma separated list of issues being fixed
204 2017-09-07 19:10:23	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11232: Ensure that data types are consistent (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/11232
205 2017-09-07 19:11:49	0|instagibbs|kanzure, are the digests published already
206 2017-09-07 19:11:59	0|wumpus|meshcollider: thanks for letting me know
207 2017-09-07 19:12:54	0|kanzure|there's one or two vulnerabilities that i shouldn't publish
208 2017-09-07 19:15:16	0|instagibbs|meshcollider, sdaftuar and anyone else not physically present, please bring up topics of choice if you have them.
209 2017-09-07 19:17:50	0|jtimon|so what topics have you been talking about there?
210 2017-09-07 19:18:23	0|jtimon|I assume 0.15.1 has bee na big topic
211 2017-09-07 19:18:24	0|kanzure|signature aggregation
212 2017-09-07 19:18:31	0|kanzure|coin selection
213 2017-09-07 19:19:35	0|wumpus|0.15.1 (segwit wallet) was a big topic, yes
214 2017-09-07 19:19:40	0|kanzure|rescans
215 2017-09-07 19:21:02	0|gmaxwell|I think we know what we're doing for segwit wallet.
216 2017-09-07 19:21:26	0|gmaxwell|after discussion pieter proposed a quick path for it that basically does an addwitness on every address in the wallet.
217 2017-09-07 19:21:42	0|gmaxwell|Which we concluded didn't create any more debt than we already have, since people aleady can do that.
218 2017-09-07 19:22:28	0|gmaxwell|(We also spent a while talking about ways that things could be handled in the future and have good ideas there too)
219 2017-09-07 19:24:07	0|meshcollider|gmaxwell: would this happen if the user decides to do a full wallet upgrade to segwit?
220 2017-09-07 19:24:22	0|meshcollider|No mix between segwit and non-segwit right?
221 2017-09-07 19:24:27	0|kanzure|i wanted to cause more discussion about rolling utxo hashes but one of the necessary people seems to be absent today
222 2017-09-07 19:24:53	0|gmaxwell|meshcollider: we must support mixed wallets already because people already have them.
223 2017-09-07 19:25:23	0|kanzure|also jonasschnelli gave a talk on bip150 and bip151 the other day http://diyhpl.us/wiki/transcripts/sf-bitcoin-meetup/2017-09-04-jonas-schenlli-bip150-bip151/
224 2017-09-07 19:25:30	0|wumpus|mixed wallets are pretty much a neccesity
225 2017-09-07 19:25:31	0|gmaxwell|we won't be supporting 'segwit only' in 0.15.1 at least just because it's a bigger change. (rather than the couple line core change needed to just auto-addwitness to everything)
226 2017-09-07 19:25:41	0|gmaxwell|kanzure: that talk will have a video online in a bit.
227 2017-09-07 19:25:58	0|meshcollider|addwitness newaddresses or existing addresses too?
228 2017-09-07 19:26:05	0|gmaxwell|But perhaps in the future we will have wallets that are segwit only except for imported keys.
229 2017-09-07 19:26:12	0|gmaxwell|meshcollider: all due to backup recovery.
230 2017-09-07 19:26:38	0|michagogo|fakeping :-(
231 2017-09-07 19:26:44	0|gmaxwell|if you only do 'new' then you need a way of storing where you started doing that.
232 2017-09-07 19:27:58	0|meshcollider|Right, makes sense yep 👍
233 2017-09-07 19:29:59	0|MarcoFalke|cfields: https://github.com/bitcoin/bitcoin/pull/10753
234 2017-09-07 19:30:39	0|kanzure|luke-jr wanted to talk about #7533 and #10391
235 2017-09-07 19:32:08	0|MarcoFalke|cfields: You can find a MWE here: https://github.com/travis-ci/travis-ci/issues/8315#issuecomment-327537437
236 2017-09-07 19:32:30	0|MarcoFalke|(scroll up a bit)
237 2017-09-07 19:32:40	0|MarcoFalke|for the yaml
238 2017-09-07 19:33:49	0|jtimon|any talks about creating a testnet for developing and testing signature aggregation? (shameless escuse to review beg https://github.com/bitcoin/bitcoin/pull/8994 )
239 2017-09-07 19:34:18	0|kanzure|signature aggregation will land in libsecp256k1 at some point
240 2017-09-07 19:35:34	0|jtimon|yeah, still too early to create a testnet, on the bright side I'm reading a lot of test code every time I rebase that...
241 2017-09-07 19:40:34	0|meshcollider|I'll review that a bit later today jtimon, I like the sound of it
242 2017-09-07 19:40:46	0|meshcollider|Any new bugs reported in rc3?
243 2017-09-07 19:40:47	0|jtimon|meshcollider: awesome!
244 2017-09-07 19:41:56	0|meshcollider|This segfault issue with Qt keeps coming up, #11262 yesterday is the third issue I've seen
245 2017-09-07 19:44:37	0|jonasschnelli|Yes. The segfault things is ugly... it seems to happen for self-compiled Bitcoin-Qts only. So it could be a Qt5.5 bug. Couldn't track it down so far
246 2017-09-07 19:45:26	0|meshcollider|Dooglus used 5.7.1 here https://github.com/bitcoin/bitcoin/issues/9883#issuecomment-325217617
247 2017-09-07 19:49:13	0|jonasschnelli|hmm... good point.
248 2017-09-07 19:50:38	0|wumpus|yes the crashes in the sorting of the transaction list are vaguely worrying
249 2017-09-07 19:51:00	0|wumpus|seems some rare race condition
250 2017-09-07 20:00:32	0|jtimon|end meeting?
251 2017-09-07 20:01:06	0|kanzure|it's endless
252 2017-09-07 20:01:12	0|jtimon|thanks for the summary, looking forward to see the talks and transcripts
253 2017-09-07 20:01:29	0|kanzure|there's not as much text, but there's some.
254 2017-09-07 20:03:05	0|meshcollider|Are there any PRs for things like segwit wallet ready for review yet, are they incoming next few days or what
255 2017-09-07 20:04:11	0|MarcoFalke|cfields: With group edge `pyenv versions` is empty: https://travis-ci.org/MarcoFalke/bitcoin/jobs/273047509/config
256 2017-09-07 20:05:06	0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/2f0d3e604aa9...e6ab88a4524a
257 2017-09-07 20:05:07	0|bitcoin-git|13bitcoin/06master 145cb3da0 15Marko Bencun: keystore GetKeys(): return result instead of writing to reference...
258 2017-09-07 20:05:07	0|bitcoin-git|13bitcoin/06master 14fe09b01 15Marko Bencun: add missing lock to crypter GetKeys()...
259 2017-09-07 20:05:08	0|bitcoin-git|13bitcoin/06master 14e6ab88a 15Wladimir J. van der Laan: Merge #10916: add missing lock to crypter GetKeys()...
260 2017-09-07 20:05:34	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10916: add missing lock to crypter GetKeys() (06master...06GetKeys) 02https://github.com/bitcoin/bitcoin/pull/10916
261 2017-09-07 20:06:02	0|wumpus|meshcollider: some from https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.15.1
262 2017-09-07 20:07:04	0|wumpus|so if everyone is ok with the pull list in  https://github.com/bitcoin-core/bitcoin-devwiki/wiki/Pulls-listing-for-0.15.0-(temporary)  I'm going to paste it into the relnotes for 0.15.0 and tag final, if anyone still plans on looking through it (to find misattributions and such) let me know
263 2017-09-07 20:11:16	0|bitcoin-git|13bitcoin/06master 14fa40b0e 15MarcoFalke: travis: Assert default datadir isn't created, Run scripted diff only once
264 2017-09-07 20:11:16	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/e6ab88a4524a...52f8877525d5
265 2017-09-07 20:11:17	0|bitcoin-git|13bitcoin/06master 1452f8877 15MarcoFalke: Merge #11260: travis: Assert default datadir isn't created, Run scripted diff only once...
266 2017-09-07 20:11:20	0|sipa|i'd like to see #11174 addressed
267 2017-09-07 20:11:56	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #11260: travis: Assert default datadir isn't created, Run scripted diff only once (06master...06Mf1708-travisYaml) 02https://github.com/bitcoin/bitcoin/pull/11260
268 2017-09-07 20:14:02	0|meshcollider|#11245 got tagged for 0.15.0 four hours ago, what's happening there
269 2017-09-07 20:15:19	0|meshcollider|If the issue isnt present in rc3 then there isn't much point including the fix in 0.15.0 release notes, but we don't know if it really got fixed
270 2017-09-07 20:21:27	0|bitcoin-git|[13bitcoin] 15theuni opened pull request #11271: travis: filter out pyenv (06master...06travis-fix-pyenv) 02https://github.com/bitcoin/bitcoin/pull/11271
271 2017-09-07 20:22:27	0|MarcoFalke|wumpus: I will look at the pull list
272 2017-09-07 20:28:57	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11270: travis: Use deprecated trusty image (06master...062017_09_travis_deprecated_image) 02https://github.com/bitcoin/bitcoin/pull/11270
273 2017-09-07 20:29:27	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11245: [0.15] Mention offscreen issue in release notes (060.15...06201709_offscreen_release_note) 02https://github.com/bitcoin/bitcoin/pull/11245
274 2017-09-07 20:30:19	0|kyzeeruz|Hello world!
275 2017-09-07 20:31:02	0|meshcollider|What's needed for 11174 re: rescanning?
276 2017-09-07 20:31:27	0|meshcollider|I can make a PR if no one else is going to
277 2017-09-07 20:31:51	0|kyzeeruz|what is PR?
278 2017-09-07 20:32:03	0|meshcollider|Pull request
279 2017-09-07 20:32:30	0|meshcollider|But it sounded like gmaxwell was leaving a mental note for himself
280 2017-09-07 20:32:58	0|kyzeeruz|Is there somebody can give me a free web link to learn bitcoin coding?
281 2017-09-07 20:33:35	0|meshcollider|I think you're in the wrong channel, try #bitcoin :)
282 2017-09-07 20:33:38	0|bitcoin-git|[13bitcoin] 15rawodb closed pull request #11177: Support for SegWit Addresses in RPC  calls and change addresses (06master...06pr/rpc_getsegwitaddresses) 02https://github.com/bitcoin/bitcoin/pull/11177
283 2017-09-07 20:35:02	0|kyzeeruz|I want to create and build a bitcoin web game or either transforming an online game while playing earn a real bitcoin on it live online.
284 2017-09-07 20:35:23	0|bitcoin-git|[13bitcoin] 15jonasschnelli opened pull request #11272: CKeystore/CCrypter: move relevant implementation out of the header (06master...062017/09/wallet_refact) 02https://github.com/bitcoin/bitcoin/pull/11272
285 2017-09-07 20:35:44	0|meshcollider|Is the meeting over?
286 2017-09-07 20:35:56	0|bitcoin-git|[13bitcoin] 15Xekyo opened pull request #11273: WIP: Ignore old format estimation file (06master...06ignoreOldFeeEstimates) 02https://github.com/bitcoin/bitcoin/pull/11273
287 2017-09-07 20:36:23	0|kyzeeruz|Is there any possible to use an old computer as a main miner to generate bitcoin?
288 2017-09-07 20:36:28	0|michagogo|meshcollider: it didn't happen
289 2017-09-07 20:36:30	0|jonasschnelli|meshcollider: because most of the devs are working in the same physical location right now, the meeting was not really happening...
290 2017-09-07 20:36:30	0|michagogo|despite the ping
291 2017-09-07 20:36:44	0|michagogo|kyzeeruz: short answer: no. Anyway, this is the wrong place
292 2017-09-07 20:36:53	0|jonasschnelli|yeah.. next week it will be again in the normal fashion
293 2017-09-07 20:36:58	0|jonasschnelli|sorry about that.
294 2017-09-07 20:37:11	0|kyzeeruz|thanks michagogo
295 2017-09-07 20:38:07	0|meshcollider|Ok sweet, just confused about the ping and thought it was started :)
296 2017-09-07 20:38:50	0|meshcollider|Hope the last day of SF goes well then
297 2017-09-07 20:45:52	0|bitcoin-git|[13bitcoin] 15mess110 opened pull request #11274: [tests] Cleanup wildcard imports in functional tests (06master...06cleanup-wildcard-in-functional-tests) 02https://github.com/bitcoin/bitcoin/pull/11274
298 2017-09-07 20:59:46	0|kyzeeruz|What repositories maen?
299 2017-09-07 20:59:55	0|sipa|kyzeeruz: #bitcoin please
300 2017-09-07 21:07:59	0|esotericnonsense|is it expected that pruning can become a limiting factor in IBD? testing now and by increasing my prune size (essentially, temporarily disabling it) it seems to have increased sync rate by approx 30%
301 2017-09-07 21:08:36	0|esotericnonsense|the cache seems to flush on each pruning event
302 2017-09-07 21:09:26	0|esotericnonsense|testing ramdisk with prune=5000 vs ssd with prune=50000 -> 30% faster off the ssd (and seemingly improving as dbcache increases)
303 2017-09-07 21:12:58	0|MarcoFalke|wumpus: Pull list looks fine
304 2017-09-07 21:31:05	0|wumpus|MarcoFalke: thanks for checking
305 2017-09-07 22:07:26	0|BlueMatt|gah, mk229797 shows up on an issue and tells someone to download a datadir snapshot
306 2017-09-07 22:07:36	0|BlueMatt|I assume its not a real person...wumpus wanna ban that account?
307 2017-09-07 22:08:06	0|BlueMatt|hmm, maybe not?
308 2017-09-07 22:08:09	0|wumpus|banned
309 2017-09-07 22:08:16	0|BlueMatt|seems like a person, but thats a strange response
310 2017-09-07 22:08:40	0|BlueMatt|eh, whatever
311 2017-09-07 22:08:47	0|BlueMatt|they'll come here and complain if they're real
312 2017-09-07 22:09:23	0|wumpus|right, it was definitely not ok
313 2017-09-07 22:15:08	0|wumpus|hm, strange, I pushed the PR list in the release notes to the 0.15 branch and github's bot didnt trigger
314 2017-09-07 22:15:23	0|BlueMatt|:O
315 2017-09-07 22:16:05	0|wumpus|maybe it's overloaded
316 2017-09-07 22:16:30	0|BlueMatt|github has had a lot of notification delays of late...there's been a few days where their email was super slow for a few hours
317 2017-09-07 22:16:54	0|wumpus|I hope it's not our fault for merging so much :)
318 2017-09-07 22:20:50	0|BlueMatt|heh, I hope it is :p
319 2017-09-07 22:20:56	0|BlueMatt|(though other projects are larger...)
320 2017-09-07 22:26:38	0|bitcoin-git|[13bitcoin] 15jonasschnelli opened pull request #11276: Update CONTRIBUTRING.md to reduce unnecesarry review workload (06master...062017/09/cont) 02https://github.com/bitcoin/bitcoin/pull/11276
321 2017-09-07 22:30:27	0|wumpus|the IRC bot is definitely backlogged
322 2017-09-07 22:30:54	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11205: Make fixed CAmounts and related sanity function constexpr (06master...06refactor/constexpr-amount) 02https://github.com/bitcoin/bitcoin/pull/11205
323 2017-09-07 22:32:33	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #11274: [tests] Cleanup wildcard imports in functional tests (06master...06cleanup-wildcard-in-functional-tests) 02https://github.com/bitcoin/bitcoin/pull/11274
324 2017-09-07 22:32:41	0|bitcoin-git|[13bitcoin] 15ryanofsky opened pull request #11277: Fix uninitialized URI in batch RPC requests (06master...06pr/mb) 02https://github.com/bitcoin/bitcoin/pull/11277
325 2017-09-07 22:34:54	0|bitcoin-git|13bitcoin/060.15 14d4c9d00 15Wladimir J. van der Laan: doc: Add PRs list to release notes...
326 2017-09-07 22:34:54	0|bitcoin-git|[13bitcoin] 15laanwj pushed 1 new commit to 060.15: 02https://github.com/bitcoin/bitcoin/commit/d4c9d00e7e79958dea9586f927778dba2be8230a
327 2017-09-07 22:39:16	0|bitcoin-git|13bitcoin/06master 14aa2e0f0 15Cory Fields: travis: filter out pyenv
328 2017-09-07 22:39:16	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/52f8877525d5...638e6c59da4f
329 2017-09-07 22:39:17	0|bitcoin-git|13bitcoin/06master 14638e6c5 15MarcoFalke: Merge #11271: travis: filter out pyenv...
330 2017-09-07 22:39:24	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #11271: travis: filter out pyenv (06master...06travis-fix-pyenv) 02https://github.com/bitcoin/bitcoin/pull/11271
331 2017-09-07 22:41:28	0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #11279: doc: Add missing contributors to release notes (060.15...06Mf1708-doc015rel) 02https://github.com/bitcoin/bitcoin/pull/11279
332 2017-09-07 22:44:46	0|bitcoin-git|13bitcoin/060.15 14fad16a9 15MarcoFalke: doc: Add missing contributors to release notes...
333 2017-09-07 22:44:46	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 060.15: 02https://github.com/bitcoin/bitcoin/compare/d4c9d00e7e79...adcc788f2a89
334 2017-09-07 22:44:47	0|bitcoin-git|13bitcoin/060.15 14adcc788 15Wladimir J. van der Laan: Merge #11279: doc: Add missing contributors to release notes...
335 2017-09-07 22:44:54	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11279: doc: Add missing contributors to release notes (060.15...06Mf1708-doc015rel) 02https://github.com/bitcoin/bitcoin/pull/11279
336 2017-09-07 22:49:24	0|meshcollider|in #11174, it says to add release notes for rescanning an encrypted wallet
337 2017-09-07 22:49:34	0|meshcollider|is that basically putting https://github.com/bitcoin/bitcoin/issues/11249 into the release notes
338 2017-09-07 22:51:17	0|MarcoFalke|meshcollider: pulls welcome :)
339 2017-09-07 22:51:39	0|meshcollider|yeah I'm working on it at the moment but I'm just trying to work out what gmaxwell's mental note meant ;)
340 2017-09-07 22:51:48	0|meshcollider|< gmaxwell> mental note: we need release notes on the topup stuff and instructions for rescanning
341 2017-09-07 22:52:42	0|meshcollider|Also should this be a new section in the release notes? 'Notes for 0.15.0' or something?
342 2017-09-07 22:54:45	0|wumpus|maybe at the beginning, after the upgrade/compatibility instructions
343 2017-09-07 23:01:52	0|bitcoin-git|[13bitcoin] 15MeshCollider opened pull request #11280: [0.15] Final to-do's for 0.15.0 release notes (060.15...06201709_release_note_015_todo) 02https://github.com/bitcoin/bitcoin/pull/11280
344 2017-09-07 23:02:19	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10756: net processing: swap out signals for an interface class (06master...06no-net-signals2) 02https://github.com/bitcoin/bitcoin/pull/10756
345 2017-09-07 23:18:14	0|bitcoin-git|13bitcoin/06master 14592404f 15MeshCollider: Changing &vec[0] to vec.data(), what 9804 missed
346 2017-09-07 23:18:14	0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/723e5806578b...efb4383ef6c6
347 2017-09-07 23:18:15	0|bitcoin-git|13bitcoin/06master 14efb4383 15Wladimir J. van der Laan: Merge #10793: Changing &var[0] to var.data()...
348 2017-09-07 23:18:39	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10793: Changing &var[0] to var.data() (06master...06prefer-vector-data) 02https://github.com/bitcoin/bitcoin/pull/10793
349 2017-09-07 23:33:01	0|wumpus|can people please review https://github.com/bitcoin/bitcoin/pull/11280? (final release notes updates for 0.15.0)
350 2017-09-07 23:37:02	0|meshcollider|especially sipa and gmaxwell since they added the todo list :)
351 2017-09-07 23:37:29	0|wumpus|yes
352 2017-09-07 23:38:10	0|wumpus|I think this is the first time that tagging a release is blocked on the release notes :)
353 2017-09-07 23:39:36	0|sipa|haha
354 2017-09-07 23:40:25	0|bitcoin-git|[13bitcoin] 15jonasschnelli opened pull request #11281: Avoid pemanent cs_main/cs_wallet lock during RescanFromTime (06master...062017/09/rescan_locks) 02https://github.com/bitcoin/bitcoin/pull/11281
355 2017-09-07 23:41:54	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 9 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/efb4383ef6c6...791a0e6ddade
356 2017-09-07 23:41:55	0|bitcoin-git|13bitcoin/06master 141b9cee6 15John Newbery: [wallet] Rename WalletVerify() to VerifyWallets()...
357 2017-09-07 23:41:55	0|bitcoin-git|13bitcoin/06master 149c76ba1 15John Newbery: [wallet] Rename InitLoadWallet() to OpenWallets()...
358 2017-09-07 23:41:55	0|meshcollider|hmm i'm not sure how to fix instagibbs comment, it would sound weird to just say "(this is not a regression)" right
359 2017-09-07 23:41:56	0|bitcoin-git|13bitcoin/06master 142da5eaf 15John Newbery: [wallet] Add FlushWallets() function to wallet/init.cpp
360 2017-09-07 23:42:14	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #10767: [wallet] Clarify wallet initialization / destruction interface (06master...06walletinit2) 02https://github.com/bitcoin/bitcoin/pull/10767
361 2017-09-07 23:42:52	0|meshcollider|actually dw I think I've got it
362 2017-09-07 23:52:42	0|meshcollider|All good to go? Cancel travis again if you want :)
363 2017-09-07 23:53:44	0|luke-jr|wumpus: well, to be fair, IMO it *should* be blocked on the hiding GUI issue <.<
364 2017-09-07 23:54:07	0|meshcollider|wouldn't that require an rc4 though?
365 2017-09-07 23:54:12	0|luke-jr|yes :/
366 2017-09-07 23:56:21	0|meshcollider|According to discussion in #11245 it might have been fixed somehow upstream or something
367 2017-09-07 23:57:15	0|meshcollider|no one is really sure so I don't think blocking release on that would be worth it, the fix can get  in to 0.15.1 anyway