1 2017-09-08 00:00:47	0|wumpus|luke-jr: no, it's not even clear the issue exists on the rc binaries, jonasschnelli tried on a few windows VMs andcouldn't reproduce with the rcs
  2 2017-09-08 00:01:38	0|jonasschnelli|luke-jr: I could reproduce the GUI offset issue with 0.14.1 on Win7, 8.1 and 10. But 0.15.0rc2 did not had the issue anymore.
  3 2017-09-08 00:01:49	0|jonasschnelli|Either its fixed in Qt5.7 or without our sources
  4 2017-09-08 00:02:07	0|jonasschnelli|It may still happen to users compiling with an older Qt version (not confirmed)
  5 2017-09-08 00:02:31	0|jonasschnelli|(like the tray icon but, etc.)
  6 2017-09-08 00:02:40	0|luke-jr|hmm
  7 2017-09-08 00:02:45	0|wumpus|yes don't get started on the tray icon... :p
  8 2017-09-08 00:03:03	0|luke-jr|can we contact the users who experienced it in RCs, and confirm their setup?
  9 2017-09-08 00:03:24	0|luke-jr|gmaxwell said he knew of at least a few
 10 2017-09-08 00:05:10	0|midnightmagic|jonasschnelli: Is there somewhere that you've more-strongly linked your GPG key to yourself? Maybe a video or something?
 11 2017-09-08 00:05:44	0|wumpus|a gpg key video? lol
 12 2017-09-08 00:07:05	0|wumpus|if it is an issue in 0.14.1 it's not a regression in 0.15 anyhow
 13 2017-09-08 00:07:29	0|wumpus|there's 0 reasons to hold the release for it, sorry
 14 2017-09-08 00:07:42	0|luke-jr|just strange that the reports came in when 0.15rc was out
 15 2017-09-08 00:07:47	0|midnightmagic|wumpus: :-) peter todd did one where he reads out the fingerprint.
 16 2017-09-08 00:08:09	0|luke-jr|midnightmagic: jonas has lots of signatures on his key :P
 17 2017-09-08 00:08:54	0|meshcollider|gmaxwell did you see instagibbs comment on #11280
 18 2017-09-08 00:08:59	0|meshcollider|there is no rescan RPC
 19 2017-09-08 00:09:48	0|jonasschnelli|midnightmagic: a video?
 20 2017-09-08 00:10:33	0|jonasschnelli|there are tons of merges and commits with my GPG signature... what would a video improve?
 21 2017-09-08 00:10:49	0|jonasschnelli|There will soon be a video from the SF bitcoin dev meetup with my key fingerprint on the slides.
 22 2017-09-08 00:10:52	0|jonasschnelli|That may help
 23 2017-09-08 00:11:45	0|wumpus|no, there is no rescan RPC, just the command line argument
 24 2017-09-08 00:12:02	0|midnightmagic|luke-jr: yep. secondary trust is sort of meaningless to me in this context
 25 2017-09-08 00:12:05	0|luke-jr|also rescanning isn't possible for pruned nodes?
 26 2017-09-08 00:12:19	0|meshcollider|so what's gmaxwell talking about in his comment, if restarting with -rescan won't work with encrypted wallets then is there no fix?
 27 2017-09-08 00:12:31	0|wumpus|import* have a  'rescan' argument but I'm not sure that's what is meant
 28 2017-09-08 00:12:53	0|luke-jr|I think the "fix" is to unlock the wallet immediately when it starts?
 29 2017-09-08 00:13:17	0|meshcollider|nah I doubt that's what he meant, would be pretty hacky if people were required to use an import command to get the rescan going
 30 2017-09-08 00:13:35	0|jonasschnelli|There is a rescan RPC call PR: https://github.com/bitcoin/bitcoin/pull/7061
 31 2017-09-08 00:13:43	0|jonasschnelli|(begs for reviews)
 32 2017-09-08 00:14:14	0|jonasschnelli|with that rescans would be possible for pruned peers (if one wants to rescan not below the pruned depth)
 33 2017-09-08 00:15:50	0|meshcollider|hmm yeah that'd be good, I'll review that later too, but that means we have no fix for 0.15.0?
 34 2017-09-08 00:16:14	0|meshcollider|Should I remove that section from the notes entirely or just make a note that support for rescanning will come in a new version
 35 2017-09-08 00:16:26	0|gmaxwell|meshcollider: you can rescan from RPC.
 36 2017-09-08 00:16:38	0|meshcollider|using import commands?
 37 2017-09-08 00:16:43	0|gmaxwell|you can use yea..
 38 2017-09-08 00:16:47	0|gmaxwell|importmulti
 39 2017-09-08 00:17:05	0|wumpus|importmulti without any actual keys or so?
 40 2017-09-08 00:17:17	0|wumpus|that definitely needs to be documented, I was not aware of that
 41 2017-09-08 00:17:20	0|gmaxwell|but indeed I was forgetting that there is no freestanding 'rescan'.
 42 2017-09-08 00:17:26	0|jonasschnelli|with a dummy key/address generated in bip32.org or so
 43 2017-09-08 00:17:35	0|gmaxwell|you can scan with a dummy.
 44 2017-09-08 00:17:47	0|gmaxwell|which I guess we need to suggest. :(
 45 2017-09-08 00:18:30	0|meshcollider|importmulti [] {"rescan":true}
 46 2017-09-08 00:18:38	0|meshcollider|empty array will work or nah?
 47 2017-09-08 00:18:52	0|meshcollider|it doesnt seem to throw any errors
 48 2017-09-08 00:18:55	0|jonasschnelli|i don't think so
 49 2017-09-08 00:19:29	0|gmaxwell|It won't rescan if there is nothing to do.
 50 2017-09-08 00:20:08	0|wumpus|that kind of makes sense, though it's sad in this case
 51 2017-09-08 00:20:52	0|midnightmagic|.../lastlog jonasschnelli
 52 2017-09-08 00:21:01	0|midnightmagic|sorry
 53 2017-09-08 00:21:06	0|luke-jr|jonasschnelli: ! no:|
 54 2017-09-08 00:21:17	0|jonasschnelli|aha. :)
 55 2017-09-08 00:21:20	0|luke-jr|importing random untrusted stuff is not safe and should definitely not be advised..
 56 2017-09-08 00:21:43	0|wumpus|there are certainly some risks to that
 57 2017-09-08 00:22:05	0|midnightmagic|jonasschnelli: Yes. That SF bitcoin meetup is perfect. That's neat that peter todd stuffed a blockchain hash into his signature in a certificate notation. I wonder if I'm the only one that's actually checked that. :-)
 58 2017-09-08 00:22:15	0|jonasschnelli|Yes. Indeed. You may import a random address from another wallet to trigger a rescan
 59 2017-09-08 00:22:30	0|jonasschnelli|But that's why we need #7061
 60 2017-09-08 00:22:34	0|jonasschnelli|We are claiming rescans are not required since years... but it seems like they are
 61 2017-09-08 00:23:06	0|midnightmagic|jonasschnelli: The consistency of the signatures is not an identity verification of the guy that everyone else has met (but I have not.) :-)
 62 2017-09-08 00:24:07	0|jonasschnelli|midnightmagic: happy to drink a coffee with you somewhere in the world.
 63 2017-09-08 00:24:25	0|midnightmagic|I would be happy to have a coffee with you if we are ever in the same place together. \o
 64 2017-09-08 00:25:01	0|jonasschnelli|That's the difficulty... indeed
 65 2017-09-08 00:27:09	0|meshcollider|something like this fine then? https://github.com/bitcoin/bitcoin/pull/11280
 66 2017-09-08 00:27:12	0|luke-jr|so encrypted HD backup tl;dr = no solution?
 67 2017-09-08 00:27:57	0|meshcollider|no good solution, yeah, they'd have to load another wallet, generate a dummy address, then load their encrypted one and import with rescan
 68 2017-09-08 00:28:53	0|bitcoin-git|[13bitcoin] 15laanwj pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/791a0e6ddade...c22a53cd6351
 69 2017-09-08 00:28:54	0|bitcoin-git|13bitcoin/06master 14713a920 15Andrew Chow: Remove usehd option and warn when it is used...
 70 2017-09-08 00:28:54	0|bitcoin-git|13bitcoin/06master 14d4c18f7 15Andrew Chow: Bump wallet version number to 159900
 71 2017-09-08 00:28:55	0|bitcoin-git|13bitcoin/06master 14c22a53c 15Wladimir J. van der Laan: Merge #11250: Bump wallet version to 159900 and remove the `usehd` option...
 72 2017-09-08 00:29:33	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11250: Bump wallet version to 159900 and remove the `usehd` option (06master...06bump-wallet-version) 02https://github.com/bitcoin/bitcoin/pull/11250
 73 2017-09-08 00:30:32	0|luke-jr|not sure if release notes are really the place for hacky workarounds for long-standing issues
 74 2017-09-08 00:30:36	0|wumpus|meshcollider: thanks for doing 11280, seems it's more work than planned for
 75 2017-09-08 00:30:55	0|wumpus|how long-standing?
 76 2017-09-08 00:31:18	0|meshcollider|thats fine :) Yeah I'm happy to remove the rescan stuff if needed
 77 2017-09-08 00:31:22	0|luke-jr|ever since HD wallets were introduced?
 78 2017-09-08 00:31:52	0|meshcollider|Yeah ^ and it will be a hacky-fix-issue until the rescan RPC is merged I guess which means we should all go review jonas's PR asap lol
 79 2017-09-08 00:32:12	0|wumpus|well a hacky workaround is better than losing funds
 80 2017-09-08 00:32:57	0|luke-jr|wumpus: right, but it's not a new issue, so maybe it should just be a blog post or smth?
 81 2017-09-08 00:33:04	0|meshcollider|True, people can still ask for support on stackexchange or whatever though, doesn't have to be in the release notes I guess
 82 2017-09-08 00:33:41	0|meshcollider|Has anyone reported having issues with it so far or is it just a 'could happen'
 83 2017-09-08 00:35:31	0|meshcollider|Well, my vote is to leave it in there, having a short Notes/Known Issues section in each release notes is quite a nice idea anyway imo
 84 2017-09-08 00:35:53	0|luke-jr|meshcollider: we're all packing up and leaving, so expect a delay in response
 85 2017-09-08 05:30:48	0|bitcoin-git|[13bitcoin] 15ajtowns opened pull request #11284: Fix invalid memory access in CScript::operator+= (06master...06cscript_insert) 02https://github.com/bitcoin/bitcoin/pull/11284
 86 2017-09-08 07:19:05	0|meshcollider|the fact that -usehd is still used in wallet.cpp#L3845 is causing all travis builds on master to fail
 87 2017-09-08 07:19:23	0|meshcollider|because contrib/devtools/check-doc.py thinks it needs documentation
 88 2017-09-08 07:19:55	0|meshcollider|so we can either remove it from wallet.cpp, or add an exclusion to check-doc.py I guess
 89 2017-09-08 07:20:27	0|meshcollider|oh wait actually theres already a list of excluded arguments in check-doc, ill just add it in there
 90 2017-09-08 07:24:26	0|bitcoin-git|[13bitcoin] 15MeshCollider opened pull request #11285: Add -usehd to excluded args in check-doc.py (06master...06201709_fix_usehd_checkdocs) 02https://github.com/bitcoin/bitcoin/pull/11285
 91 2017-09-08 07:25:51	0|meshcollider|That should probably be reviewed quickly because all Travis builds depend on it ^
 92 2017-09-08 08:33:35	0|bitcoin-git|[13bitcoin] 15fanquake opened pull request #11286: [depends] Don't build libevent sample code (06master...06dont-build-libevent-samples) 02https://github.com/bitcoin/bitcoin/pull/11286
 93 2017-09-08 10:37:48	0|bitcoin-git|[13bitcoin] 15danra opened pull request #11287: DRY config header inclusion (06master...06refactor/dry-config) 02https://github.com/bitcoin/bitcoin/pull/11287
 94 2017-09-08 11:43:44	0|bitcoin-git|[13bitcoin] 15MeshCollider opened pull request #11288: More user-friendly error message when partially signing (06master...06201709_partial_sign_error) 02https://github.com/bitcoin/bitcoin/pull/11288
 95 2017-09-08 12:23:51	0|bitcoin-git|[13bitcoin] 15MeshCollider opened pull request #11289: Add wallet backup text to import* and add* RPCs (06master...06201709_add_help_text) 02https://github.com/bitcoin/bitcoin/pull/11289
 96 2017-09-08 13:57:36	0|jtimon|Args undocumented: 1
 97 2017-09-08 13:57:36	0|jtimon|set(['-usehd'])
 98 2017-09-08 16:10:40	0|sdaftuar|sipa: is using upper case in the human readable part of bech32 addresses not allowed?  that wasn't clear to me from the bip, but it seems to result in broken behavior with eg the python implementation (if i'm doing this right)
 99 2017-09-08 16:12:06	0|sdaftuar|ie if you call encode and pass an hrp that contains an upper-case character, then the result doesn't seem to decode
100 2017-09-08 16:33:47	0|Guest9986|sdaftuar: you have to make the whole thing uppercase or whole thing lowercase.
101 2017-09-08 16:34:14	0|sdaftuar|Guest9986: if i understand hrp expansion correctly though, that changes the interpretation of the hrp
102 2017-09-08 16:34:26	0|sdaftuar|implying that only lower case is allowed for hrp?
103 2017-09-08 16:37:09	0|Guest9986|That isn't the intent, for the checksum the lowercase value is used. I think the BIP may be a big ambigious there.
104 2017-09-08 16:37:51	0|sdaftuar|i don't think the lowercase value of the hrp is used -- just the lowercase value of the data
105 2017-09-08 16:39:40	0|sdaftuar|so do you think hrp expansion should first convert to lowercase?
106 2017-09-08 16:42:39	0|gmaxwell|both bc1qw508d6qejxtdg4y5r3zarvary0c5xw7kv8f3t4 and BC1QW508D6QEJXTDG4Y5R3ZARVARY0C5XW7KV8F3T4 are accepted by the reference code for me
107 2017-09-08 16:43:00	0|sdaftuar|right, but try encoding something with an hrp using capital letters, say "BC"
108 2017-09-08 16:43:05	0|sdaftuar|and then try decoding
109 2017-09-08 16:43:24	0|sdaftuar|i think that will fail
110 2017-09-08 16:45:07	0|gmaxwell|The BIP says: "The lowercase form is used when determining a character's value for checksum purposes.", and the ref code correctly accepts upper and lowercase versions of the same string.  So I think what you're saying is that the encoder doesn't convert the case, but the decoder works fine.
111 2017-09-08 16:45:29	0|gmaxwell|So if one uses the encoder with an uppercase hrp you'll get a value that never decodes.
112 2017-09-08 16:45:33	0|sdaftuar|yes
113 2017-09-08 16:46:14	0|gmaxwell|seems plausable to me, sounds like an implementation bug, though not one that would be a problem for us. (not like the HRP is a user specified value)
114 2017-09-08 16:47:05	0|sdaftuar|well i wasn't sure if it was an implementation bug or a misunderstanding in my reading of the BIP
115 2017-09-08 16:48:03	0|gmaxwell|No misunderstanding on your part, I think: consider, since the decoder works with strings converted to uppercase, your uppercase encodes could never work, not exactly all that useful. :P
116 2017-09-08 16:48:05	0|sdaftuar|if we are converting the hrp to lowercase when we encode, then the BIP should probably just make that clear, that hrp values are more restricted
117 2017-09-08 16:49:13	0|sdaftuar|if the hrp expansion function treated upper case hrp's the same as lower-case hrp's, it woulnd't be a problem either i guess
118 2017-09-08 17:31:35	0|jimpo|Would appreciate reviews on 11113 and 11116
119 2017-09-08 17:43:08	0|achow101|seems like travis is all messed up now
120 2017-09-08 18:21:21	0|instagibbs|achow101, ok, not just me then
121 2017-09-08 18:22:44	0|achow101|instagibbs: apparently that's my fault. We need to merge 11285.
122 2017-09-08 18:23:22	0|achow101|I guess this is what happens when things are merged right before leaving for dinner
123 2017-09-08 18:41:09	0|jamesob|Have 4 hours on a plane to write some unittests. Any recommendations?
124 2017-09-08 18:41:46	0|bitcoin-git|13bitcoin/06master 147d03418 15MeshCollider: Add -usehd to excluded args in check-doc.py
125 2017-09-08 18:41:46	0|bitcoin-git|[13bitcoin] 15sipa pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/c22a53cd6351...3255d6347b1f
126 2017-09-08 18:41:47	0|bitcoin-git|13bitcoin/06master 143255d63 15Pieter Wuille: Merge #11285: Add -usehd to excluded args in check-doc.py...
127 2017-09-08 18:42:33	0|bitcoin-git|[13bitcoin] 15sipa closed pull request #11285: Add -usehd to excluded args in check-doc.py (06master...06201709_fix_usehd_checkdocs) 02https://github.com/bitcoin/bitcoin/pull/11285
128 2017-09-08 18:44:18	0|sipa|restarting jobs that failed due to usehd doc
129 2017-09-08 18:45:30	0|instagibbs|jamesob, feel like there should be a coverage report to look at...
130 2017-09-08 19:15:46	0|jamesob|instagibbs thanks, I'll take a look at the gcov output
131 2017-09-08 19:16:36	0|achow101|jamesob: you can do `./configure --enable-lcov` and then `make cov` and that will make you a testing coverage report
132 2017-09-08 19:17:19	0|jamesob|thanks, achow101.
133 2017-09-08 21:25:26	0|meshcollider|Anyone else want to review #11280 (release notes)?
134 2017-09-08 22:35:28	0|bitcoin-git|[13bitcoin] 15dongsam opened pull request #11291: Fix PEP8 warnings about formatting (06master...06Fix-PEP8-warnings) 02https://github.com/bitcoin/bitcoin/pull/11291
135 2017-09-08 22:41:31	0|meshcollider|sipa: the fix for travis isn't on the 0.15 branch
136 2017-09-08 22:41:53	0|meshcollider|That's why its failing for the release notes
137 2017-09-08 22:42:25	0|sipa|meshcollider: oh!
138 2017-09-08 22:42:34	0|sipa|meshcollider: what commit needs backport?
139 2017-09-08 22:43:09	0|meshcollider|https://github.com/bitcoin/bitcoin/commit/aa2e0f09ec94dd0908f792ebc2249859ad174586 I believe
140 2017-09-08 23:21:22	0|bitcoin-git|[13bitcoin] 15sipa opened pull request #11292: travis: filter out pyenv (060.15...06backport_11271) 02https://github.com/bitcoin/bitcoin/pull/11292
141 2017-09-08 23:54:26	0|bitcoin-git|13bitcoin/060.15 140ced455 15Cory Fields: travis: filter out pyenv
142 2017-09-08 23:54:26	0|bitcoin-git|[13bitcoin] 15sipa pushed 2 new commits to 060.15: 02https://github.com/bitcoin/bitcoin/compare/adcc788f2a89...5f2cf88c2311
143 2017-09-08 23:54:27	0|bitcoin-git|13bitcoin/060.15 145f2cf88 15Pieter Wuille: Merge #11292: travis: filter out pyenv...