1 2017-09-12 00:49:36	0|BlueMatt|grrrr why is practicalswift not in the contributors list so I can auto-complete his long-ass name
  2 2017-09-12 00:50:19	0|luke-jr|that would be too … practical
  3 2017-09-12 00:51:36	0|BlueMatt|lol, oh so punny
  4 2017-09-12 00:52:01	0|sipa|* luke-jr hides swiftly
  5 2017-09-12 00:57:00	0|gmaxwell|luke-jr: you live!
  6 2017-09-12 00:57:39	0|BlueMatt|(and have internet)
  7 2017-09-12 00:57:59	0|BlueMatt|lol errrr maybe not
  8 2017-09-12 00:58:29	0|kallewoof|he made puns, so he seems to be doing okay. :) i dont think i'd be punning if i was in trouble.
  9 2017-09-12 00:58:58	0|BlueMatt|kallewoof: well he ping-timeout'd, so at least the internet part may not be so stable :p
 10 2017-09-12 01:00:05	0|kallewoof|he'll be okay. he was trained in the art of no internet at tokyo core dev when he was without his computer for basically an entire day.
 11 2017-09-12 01:00:14	0|BlueMatt|:O
 12 2017-09-12 01:00:33	0|kallewoof|yeah. *shudders*
 13 2017-09-12 01:07:52	0|kallewoof|Running a modified master but I just ran into EXCEPTION: 15dbwrapper_error and Database corrupted abd Corruption: not an sstable (bad magic number) etc. I can provide access to the machine with the node if someone feels intrigued by this, or I will just try to fix it. sipa etc?
 14 2017-09-12 01:08:05	0|sipa|meshcollider: you should be able to restart travis jobs now
 15 2017-09-12 01:08:19	0|kallewoof|^Cing gave Error: Error: A fatal internal error occurred, see debug.log for details a few times.
 16 2017-09-12 01:08:37	0|sipa|kallewoof: very little i can do...
 17 2017-09-12 01:08:55	0|kallewoof|Okay. Seemed like a nice debugging opportunity, but ah well.
 18 2017-09-12 01:09:18	0|sipa|i'd like to hear about the circumstances that led to the corruption though
 19 2017-09-12 01:09:40	0|kallewoof|Node crashed due to my code (which was logging stuff to a file).
 20 2017-09-12 01:10:47	0|kallewoof|It was also running from gdb. I suspect that may have been a problem too.
 21 2017-09-12 01:11:06	0|sipa|ouch.
 22 2017-09-12 01:11:13	0|sipa|that shouldn't cause corruption
 23 2017-09-12 01:11:15	0|kallewoof|To clarify, I ran in gdb, hit the crash, killed process, and then restarted node and it started spewing these.
 24 2017-09-12 01:11:23	0|kallewoof|My kill may have caused it?
 25 2017-09-12 01:11:34	0|sipa|killing a process shouldn't cause db corruption
 26 2017-09-12 01:13:58	0|kallewoof|Yeah, I've done it all the time. I didn't really do anything else noteworthy.
 27 2017-09-12 01:15:06	0|kallewoof|As a sidenote, despite the "see debug.log for details" message, there was nothing in the debug.log related to this.
 28 2017-09-12 01:16:57	0|sipa|wow, that must be very old, and referring to bdb's debug log?
 29 2017-09-12 01:18:40	0|kallewoof|Ohhh..
 30 2017-09-12 01:19:33	0|sipa|or perhaps not
 31 2017-09-12 01:19:50	0|kallewoof|It's in AbortNode in validation.cpp so seems to be about bitcoin, yeah.
 32 2017-09-12 01:22:50	0|kallewoof|This is on a digital ocean instance, btw, which I assume us running everything RAIDed, so an actual disk corruption doesn't sound likely.
 33 2017-09-12 01:36:26	0|sipa|that's also irrelevant; it's not the OS or the hardware that crashed, just a process
 34 2017-09-12 01:38:01	0|kallewoof|If an actual disk error (bad block/sector/etc) was present surely it could cause a corruption in the db
 35 2017-09-12 01:52:17	0|kallewoof|In case someone else has the issue, restarting the node actually solved it on my side.
 36 2017-09-12 06:08:29	0|sipa|should the "this wallet is segwit" flag be a version number or a separate key in the wallet?
 37 2017-09-12 07:30:23	0|sipa|wumpus morcos sdaftuar BlueMatt jonasschnelli achow101 ^
 38 2017-09-12 07:45:04	0|MarcoFalke|sipa: If it is a new version, we'd have to backport the usehd change to 0.15.1. Is that desired?
 39 2017-09-12 07:46:19	0|sipa|MarcoFalke: if it's not a new version, downgrading to 0.15.0 may cause lost funds
 40 2017-09-12 07:47:28	0|sipa|(not disagreeing with you, but there are issues both ways - i'm just wondering whether this was discussed already)
 41 2017-09-12 07:47:55	0|MarcoFalke|right. So there will only be segwit HD wallets
 42 2017-09-12 07:58:48	0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #11305: [doc] Update release notes and manpages for 0.16 (06master...06Mf1709-doc016) 02https://github.com/bitcoin/bitcoin/pull/11305
 43 2017-09-12 10:26:14	0|bitcoin-git|[13bitcoin] 15danra opened pull request #11306: Refactor: Move core files from src root to src/core and improve inclu… (06master...06refactor/core-files) 02https://github.com/bitcoin/bitcoin/pull/11306
 44 2017-09-12 10:50:09	0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #11307: wallet: Display non-HD error on first run (06master...06Mf1709-walletHDfirst) 02https://github.com/bitcoin/bitcoin/pull/11307
 45 2017-09-12 11:36:37	0|morcos|sipa: Why would it cause funds loss?  Isn't it adding the segwit scrips to the wallet, which would be recognized by lower versions of wallets?
 46 2017-09-12 11:37:05	0|morcos|Yes old backups wouldn't work, but that's true for 0.15.1 as well
 47 2017-09-12 11:37:51	0|morcos|I thought the idea was to fix that with 0.16.0 by essentially tripling every existing key in the wallet (for all the segwit scripts)
 48 2017-09-12 11:39:59	0|morcos|I think it would be helpful to write up an issue the explains the whole 0.15.1 wallet plan in one place (in english) and the 0.16.0 wallet plan.  just so we can think through everything now
 49 2017-09-12 11:42:44	0|meshcollider|morcos: by tripling, do you mean one P2PKH, one P2SH and one BIP173?
 50 2017-09-12 11:43:31	0|meshcollider|+1 for doing a write up
 51 2017-09-12 11:48:06	0|morcos|yes, P2SH wrapped segwit script for the middle one..  (and that's not exactly right, b/c i think we might add more than P2PKH for the legacy, but thats the idea)
 52 2017-09-12 11:53:09	0|meshcollider|so will P2SH-P2WPKH will be treated identically to the same address in P2PKH from the users perspective
 53 2017-09-12 11:59:29	0|morcos|meshcollider: the goal is no.  you should not get paid at an address you did not give out.  so if you give out a P2PKH, then that is how you should be paid and no one should be trying to wrap that up in some script or program and paying you to it
 54 2017-09-12 12:00:17	0|morcos|but for backwards compatibility with the way 0.15.0 and previous wallets worked, once we implement that functionality, then on upgrade your wallet will treat it as if you've given out all 3 variations for pre existing keys
 55 2017-09-12 12:00:26	0|morcos|but future keys will only be used for 1 variation
 56 2017-09-12 12:01:36	0|morcos|but we need the writeup to make sure it all makes sense...  seems like sipa was assuming that some level of upgrade is happening at 0.15.1 , but i thought there was no upgrade until 0.16.0, and that we weren't marking 0.15.1 wallets as special
 57 2017-09-12 12:01:54	0|morcos|other than that we'd be adding segwit addresses to them by default
 58 2017-09-12 13:48:10	0|BlueMatt|sipa: yea, what morcos said...I didnt think we were adding a "this wallet is segwit" flag for 0.15.1
 59 2017-09-12 13:48:23	0|BlueMatt|)
 60 2017-09-12 13:48:23	0|BlueMatt|(and then a version bump in 16ish when we do a second hd split
 61 2017-09-12 14:30:35	0|RealM9|What? ae you going to release 0.15.1 with SW address support?
 62 2017-09-12 14:30:40	0|RealM9|Are*
 63 2017-09-12 14:38:50	0|MarcoFalke|jnewbery: I don't think we should be encouraging refactoring pulls that change all apostrophes into quotation marks in python code
 64 2017-09-12 14:39:06	0|MarcoFalke|re #11291
 65 2017-09-12 14:39:08	0|gribble|https://github.com/bitcoin/bitcoin/issues/11291 | Fix PEP8 warnings about formatting by dongsam · Pull Request #11291 · bitcoin/bitcoin · GitHub
 66 2017-09-12 14:40:12	0|MarcoFalke|Also, we don't bulk-rename vars to snake_case in python.
 67 2017-09-12 14:40:26	0|MarcoFalke|All of this is a pain to review
 68 2017-09-12 15:25:48	0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #11308: [qa] zapwallettxes: Wait up to 3s for mempool reload (06master...06Mf1709-qaZap3s) 02https://github.com/bitcoin/bitcoin/pull/11308
 69 2017-09-12 15:35:19	0|BlueMatt|does anyone have numbers on transaction confirmation for rbf replacement txn?  I have a feeling it might be time to start tracking those in fee estimation
 70 2017-09-12 16:59:51	0|jnewbery|MarcoFalke : sure. I didn't push back because the PR also does the useful job of updating the os.path calls in the same file. I'm not too concerned about accepting those changes but saying 'in general we don't accept style-only PRs', but if you want to take a harder line I think that's also fine.
 71 2017-09-12 17:02:36	0|MarcoFalke|I am not keen on reviewing that. If you feel like making sure that all the refactoring parts preserve functionality 100%, go ahead. I am not aware of a good way to do that when it is not a scripted diff. And a scripted diff is overkill for those formatting changes
 72 2017-09-12 17:08:42	0|jnewbery|MarcoFalke : can you merge #11230 ? dbcrash.py is still failing
 73 2017-09-12 17:08:44	0|gribble|https://github.com/bitcoin/bitcoin/issues/11230 | [tests] fixup dbcrash interaction with add_nodes() by jnewbery · Pull Request #11230 · bitcoin/bitcoin · GitHub
 74 2017-09-12 17:08:46	0|bitcoin-git|[13bitcoin] 15morcos opened pull request #11309: Minor cleanups for AcceptToMemoryPool (06master...06ATMP_cleanup) 02https://github.com/bitcoin/bitcoin/pull/11309
 75 2017-09-12 17:24:56	0|MarcoFalke|sure. Thx, somehow missed that
 76 2017-09-12 17:30:19	0|bitcoin-git|13bitcoin/06master 148fdb6f9 15John Newbery: [tests] fixup dbcrash interaction with add_nodes()
 77 2017-09-12 17:30:19	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/b9bceaf1c081...b37cab65c63e
 78 2017-09-12 17:30:20	0|bitcoin-git|13bitcoin/06master 14b37cab6 15MarcoFalke: Merge #11230: [tests] fixup dbcrash interaction with add_nodes()...
 79 2017-09-12 17:30:59	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #11230: [tests] fixup dbcrash interaction with add_nodes() (06master...06fixup_dbcrash) 02https://github.com/bitcoin/bitcoin/pull/11230
 80 2017-09-12 17:32:18	0|jnewbery|MarcoFalke : thanks!
 81 2017-09-12 17:36:59	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/b37cab65c63e...c377feaad87f
 82 2017-09-12 17:37:00	0|bitcoin-git|13bitcoin/06master 1424697c4 15Wladimir J. van der Laan: rpc: update cli for estimatefee argument rename...
 83 2017-09-12 17:37:00	0|bitcoin-git|13bitcoin/06master 145acd82d 15Wladimir J. van der Laan: rpc: make estimatesmartfee argument naming consistent with documentation...
 84 2017-09-12 17:37:01	0|bitcoin-git|13bitcoin/06master 14c377fea 15MarcoFalke: Merge #11267: rpc: update cli for estimate*fee argument rename...
 85 2017-09-12 17:37:35	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #11267: rpc: update cli for estimate*fee argument rename (06master...062017_09_renamed_estimatefee_arg) 02https://github.com/bitcoin/bitcoin/pull/11267
 86 2017-09-12 17:47:17	0|bitcoin-git|13bitcoin/06master 14b8d91e0 15practicalswift: [Docs] Fix broken Markdown table in dependencies.md. Cleanups....
 87 2017-09-12 17:47:17	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/c377feaad87f...b148803b181e
 88 2017-09-12 17:47:18	0|bitcoin-git|13bitcoin/06master 14b148803 15MarcoFalke: Merge #11264: [doc] Fix broken Markdown table in dependencies.md...
 89 2017-09-12 17:47:55	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #11264: [doc] Fix broken Markdown table in dependencies.md (06master...06dependencies-capitalization) 02https://github.com/bitcoin/bitcoin/pull/11264
 90 2017-09-12 18:03:54	0|sipa|morcos: right, starting to remember
 91 2017-09-12 18:04:35	0|sipa|morcos: so really all we need is automatically addwitnessifying newly generated addresses (while properly marking them as change, ...)
 92 2017-09-12 18:58:54	0|bitcoin-git|[13bitcoin] 15mess110 opened pull request #11310: [tests] Test listwallets RPC (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/11310
 93 2017-09-12 19:01:35	0|morcos|sipa: yes, i think.  depending on what you mean by properly marking them as change?
 94 2017-09-12 19:06:39	0|sipa|morcos: addwitnessaddress currently always assigns a label to the address, causing it to be treated as non-change
 95 2017-09-12 19:09:12	0|morcos|sipa: right ok, so sometimes you'll do that, and sometimes you won't depending on the path by which we got to that
 96 2017-09-12 19:10:05	0|sipa|right
 97 2017-09-12 19:11:53	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/b148803b181e...ce829855cfca
 98 2017-09-12 19:11:54	0|bitcoin-git|13bitcoin/06master 14581c411 15Kyuntae Ethan Kim: Properly comment about shutdown process in init.cpp file
 99 2017-09-12 19:11:54	0|bitcoin-git|13bitcoin/06master 14ce82985 15MarcoFalke: Merge #10691: Trivial: Properly comment about shutdown process in init.cpp file....
100 2017-09-12 19:12:19	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #10691: Trivial: Properly comment about shutdown process in init.cpp file. (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/10691
101 2017-09-12 19:54:01	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/ce829855cfca...801dd40666d1
102 2017-09-12 19:54:02	0|bitcoin-git|13bitcoin/06master 146d2aac8 15Luke Dashjr: Travis: Test build against system libs (& Qt4)
103 2017-09-12 19:54:02	0|bitcoin-git|13bitcoin/06master 148d82e13 15Luke Dashjr: Travis: Remove bc tool from dependencies
104 2017-09-12 19:54:03	0|bitcoin-git|13bitcoin/06master 14801dd40 15MarcoFalke: Merge #7142: Travis: Test build against system libs (& Qt4)...
105 2017-09-12 21:01:31	0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #11311: travis: Revert default datadir check (06master...06Mf1709-travisDatadirRevert) 02https://github.com/bitcoin/bitcoin/pull/11311
106 2017-09-12 21:17:46	0|seone|Heya all :)
107 2017-09-12 21:19:01	0|seone|Though i should join here from time to time, if you mention me to be here on the Translations site xD
108 2017-09-12 21:22:18	0|sipa|ohai
109 2017-09-12 21:33:03	0|bitcoin-git|13bitcoin/06master 14fa4fad9 15MarcoFalke: travis: Revert default datadir check
110 2017-09-12 21:33:03	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/801dd40666d1...cce94c518a46
111 2017-09-12 21:33:04	0|bitcoin-git|13bitcoin/06master 14cce94c5 15MarcoFalke: Merge #11311: travis: Revert default datadir check...
112 2017-09-12 21:33:38	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #11311: travis: Revert default datadir check (06master...06Mf1709-travisDatadirRevert) 02https://github.com/bitcoin/bitcoin/pull/11311
113 2017-09-12 21:59:44	0|bitcoin-git|13bitcoin/06master 14fb1f325 15Cristian Mircea Messel: Add listwallets RPC test to multiwallet.py
114 2017-09-12 21:59:44	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/cce94c518a46...96ac26e56627
115 2017-09-12 21:59:45	0|bitcoin-git|13bitcoin/06master 1496ac26e 15MarcoFalke: Merge #11310: [tests] Test listwallets RPC...
116 2017-09-12 22:00:28	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #11310: [tests] Test listwallets RPC (06master...06master) 02https://github.com/bitcoin/bitcoin/pull/11310
117 2017-09-12 22:02:08	0|BlueMatt|OK, 0.15 PPAs are (finally) up...just had to hack in xvfb and backport 11210...
118 2017-09-12 22:03:05	0|BlueMatt|hmm, no, well x86 builds worked, test_bitcoin-qt still failed on arm :(
119 2017-09-12 23:50:51	0|bitcoin-git|[13bitcoin] 15mess110 opened pull request #11314: Add abortrescan RPC test (06master...06add-abortrescan-rpc-test) 02https://github.com/bitcoin/bitcoin/pull/11314