1 2017-09-14 01:50:04	0|bitcoin-git|[13bitcoin] 15OrfanMiner opened pull request #11325: Corrected year (06master...06patch-1) 02https://github.com/bitcoin/bitcoin/pull/11325
  2 2017-09-14 01:51:35	0|bitcoin-git|[13bitcoin] 15fanquake closed pull request #11325: Corrected year (06master...06patch-1) 02https://github.com/bitcoin/bitcoin/pull/11325
  3 2017-09-14 07:01:03	0|mryandao|heya, while running bitcoind in docker, i tried to symlink debug.log to /dev/stderr and bitcoind crashed when a boost function tried to read the path, is that expected behaviour?
  4 2017-09-14 07:03:00	0|NicolasDorier|Running bitcoin-core-0.15.0/test.rc3 on one of my server, getting "2017-09-14 06:55:48 socket send error The operation completed successfully.  (0)"  in logs _without_ debug=net. Then the connection drop to the peer. My peer is a NBitcoin peer, and I could not reproduce the error on the same 0.15.0/test.rc3 running on my machine.
  5 2017-09-14 07:03:28	0|NicolasDorier|"socket send error The operation completed successfully. (0)", interesting message at least...
  6 2017-09-14 07:38:04	0|promag|Can I have some feedback here #11316?
  7 2017-09-14 07:38:05	0|gribble|https://github.com/bitcoin/bitcoin/issues/11316 | [qt] Add use available balance in send coins dialog by promag · Pull Request #11316 · bitcoin/bitcoin · GitHub
  8 2017-09-14 07:43:16	0|NicolasDorier|mmh I doubt the bug comes from bitcoin core actually
  9 2017-09-14 08:10:16	0|bitcoin-git|[13bitcoin] 15MeshCollider opened pull request #11326: Fix crash on shutdown with invalid wallet (06master...06201709_shutdown_crash) 02https://github.com/bitcoin/bitcoin/pull/11326
 10 2017-09-14 08:10:55	0|meshcollider|thats such a small fix it doesn't even feel right to make a whole PR lol
 11 2017-09-14 08:29:07	0|earlz|How exactly do you debug the bitcoin-qt on 64bit windows? I know the gitian builds produce both the binaries and debug symbols, but not sure what the best way to debug a crash is
 12 2017-09-14 09:11:18	0|wumpus|earlz: the debug symbols can be used in combination with the stack trace and a memory map to find out what symbol was involved. I don't know of any way to do debugging *on* windows sanely, there's a mingw gdb but I don't think it works very well
 13 2017-09-14 09:26:39	0|promag|wdyt return txid in signrawtransaction? (at least if complete)
 14 2017-09-14 09:28:01	0|promag|there is this pattern decoderaw(signraw().hex).txid
 15 2017-09-14 09:28:22	0|promag|could be simplified to signraw().txid
 16 2017-09-14 09:30:06	0|wumpus|could be, though I always run decoderaw after signraw anyhow, to check the transaction one last time before broadcasting it
 17 2017-09-14 09:31:27	0|wumpus|so it wouldn't help me at least - but if you think many would be helped by having txid on signrawtransaction output object why not open a PR
 18 2017-09-14 09:33:31	0|wumpus|also, sendrawtransaction(hex) returns the txid - so you really need the txid before broadcasting the transaction?
 19 2017-09-14 09:34:02	0|wumpus|or is this useful if you use an alternative way to broadcast transactions
 20 2017-09-14 09:34:30	0|promag|ah, so in https://github.com/bitcoin/bitcoin/pull/11167/files#diff-e239d66ea758103213db73bf934d0918R601
 21 2017-09-14 09:34:41	0|promag|there is no need to decoderawtransaction
 22 2017-09-14 09:35:49	0|wumpus|indeed, it could take the result from sendrawtransaction instead
 23 2017-09-14 09:36:14	0|wumpus|this way of working makes sense though if it's testing decoderawtransaction
 24 2017-09-14 09:37:18	0|promag|don't think so, if it's testing decoderawtransaction then it's incomplete
 25 2017-09-14 09:37:36	0|wumpus|in any case, I don't think we should fix test inconsistencies by changing the API :)
 26 2017-09-14 09:39:36	0|promag|no, that's why I asked before opening the PR
 27 2017-09-14 09:40:14	0|promag|but having the txid back and forward doesn't sound too bad
 28 2017-09-14 09:42:41	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 3 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/7fcd61b2613c...f4ed44ab4a8f
 29 2017-09-14 09:42:42	0|bitcoin-git|13bitcoin/06master 141f379b1 15MeshCollider: Add tab char lint check and exclude imported dependencies
 30 2017-09-14 09:42:42	0|bitcoin-git|13bitcoin/06master 14dd36561 15Evan Klitzke: Add a lint check for trailing whitespace....
 31 2017-09-14 09:42:43	0|bitcoin-git|13bitcoin/06master 14f4ed44a 15MarcoFalke: Merge #11300: Tests: Add a lint check for trailing whitespace...
 32 2017-09-14 09:43:25	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #11300: Tests: Add a lint check for trailing whitespace (06master...06201709_whitespace_lint) 02https://github.com/bitcoin/bitcoin/pull/11300
 33 2017-09-14 12:53:16	0|bitcoin-git|13bitcoin/06master 1486700d3 15Wladimir J. van der Laan: doc: add release-notes for 0.15.0 to master...
 34 2017-09-14 12:53:16	0|bitcoin-git|[13bitcoin] 15laanwj pushed 1 new commit to 06master: 02https://github.com/bitcoin/bitcoin/commit/86700d3d056caf54b091a6673dd6dabb65fac1f2
 35 2017-09-14 13:02:32	0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11280: [0.15] Final to-do's for 0.15.0 release notes (060.15...06201709_release_note_015_todo) 02https://github.com/bitcoin/bitcoin/pull/11280
 36 2017-09-14 13:18:17	0|NicolasDorier|https://www.irccloud.com/pastebin/hIAM1dLB/
 37 2017-09-14 13:18:30	0|NicolasDorier|using 0.15rc3
 38 2017-09-14 13:20:21	0|NicolasDorier|my node can't even start again after restarting it
 39 2017-09-14 13:20:28	0|NicolasDorier|it is doing that every time it starts
 40 2017-09-14 13:28:38	0|wumpus|afaik that one (if it's during init) is fixed on master
 41 2017-09-14 13:28:54	0|NicolasDorier|yep during init
 42 2017-09-14 13:29:12	0|wumpus|https://github.com/bitcoin/bitcoin/pull/11126
 43 2017-09-14 13:29:33	0|NicolasDorier|cool
 44 2017-09-14 13:29:39	0|NicolasDorier|thanks I try that now
 45 2017-09-14 13:29:44	0|wumpus|doesn't affect the release executables as they're not built with DEBUG_LOCKORDER
 46 2017-09-14 13:30:06	0|wumpus|(and it's not an actual possible deadlock - will be backported to 0.15.1 though)
 47 2017-09-14 13:47:12	0|NicolasDorier|wumpus: no luck, this is unrelated to this PR
 48 2017-09-14 13:47:19	0|wumpus|ok
 49 2017-09-14 13:47:25	0|NicolasDorier|this is indeed not a real deadlock though
 50 2017-09-14 13:47:42	0|NicolasDorier|will just deactivate debug for now and find out what happen
 51 2017-09-14 14:18:07	0|bitcoin-git|[13bitcoin] 15laanwj pushed 1 new commit to 060.15: 02https://github.com/bitcoin/bitcoin/commit/7c53587101eaf206a6a6a11a9398d43f139eadcf
 52 2017-09-14 14:18:08	0|bitcoin-git|13bitcoin/060.15 147c53587 15Wladimir J. van der Laan: doc: Clean out release notes on 0.15 branch...
 53 2017-09-14 14:22:02	0|bitcoin-git|[13bitcoin] 15laanwj pushed 1 new commit to 06master: 02https://github.com/bitcoin/bitcoin/commit/96d91b79bdfe1c0a58bd645f0f1d657caba16deb
 54 2017-09-14 14:22:03	0|bitcoin-git|13bitcoin/06master 1496d91b7 15Wladimir J. van der Laan: contrib: Ignore historical release notes for whitespace check...
 55 2017-09-14 14:23:01	0|NicolasDorier|how to remove DEBUG_LOCKORDER ? I tried to compile withount --enable-debug, but no luck it see;s
 56 2017-09-14 14:27:29	0|NicolasDorier|meh I must have screwed up somewhere... will redeploy
 57 2017-09-14 14:29:20	0|wumpus|it's --enable-debug that adds it, so rebuilding without it (you'd need to 'make clean' too) will get rid of it
 58 2017-09-14 14:41:12	0|NicolasDorier|yeah sorry, I messed up by replacing the wrong bitcoind on my server :/
 59 2017-09-14 14:41:51	0|NicolasDorier|so actually I did not tried https://github.com/bitcoin/bitcoin/pull/11126 yet. But the path of the locks is different from the PR so I guess this is different error.
 60 2017-09-14 14:41:56	0|NicolasDorier|filed an issue
 61 2017-09-14 14:48:50	0|MarcoFalke|15000 commits. This thing explodes 🎉
 62 2017-09-14 14:48:58	0|bitcoin-git|13bitcoin/06master 1477939f2 15MeshCollider: Fix uninitialized g_connman crash in Shutdown()
 63 2017-09-14 14:48:58	0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/96d91b79bdfe...0f399a9ff227
 64 2017-09-14 14:48:59	0|bitcoin-git|13bitcoin/06master 140f399a9 15MarcoFalke: Merge #11326: Fix crash on shutdown with invalid wallet...
 65 2017-09-14 14:49:35	0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #11326: Fix crash on shutdown with invalid wallet (06master...06201709_shutdown_crash) 02https://github.com/bitcoin/bitcoin/pull/11326
 66 2017-09-14 15:01:53	0|bitcoin-git|[13bitcoin] 15danra opened pull request #11328: Move comment about transaction/block weight calculation (06master...06fix/weight-comment) 02https://github.com/bitcoin/bitcoin/pull/11328
 67 2017-09-14 15:09:26	0|bitcoin-git|[13bitcoin] 15jnewbery closed pull request #10044: [tests] [build] Run functional tests in `make check` (06master...06reorg_makefiles) 02https://github.com/bitcoin/bitcoin/pull/10044
 68 2017-09-14 15:31:26	0|mryandao|has anyone here using tmux experience extreme lag when they `git clone` the bitcoin repo for the first time?
 69 2017-09-14 15:32:41	0|wumpus|never noticed - though i guess git does a lot of terminal updates during the progress update so maybe that is slowed by running in tmux?
 70 2017-09-14 15:33:18	0|wumpus|MarcoFalke: heh yes also noticed, 15000, wow that's a milestone in itself I guess
 71 2017-09-14 15:33:24	0|mryandao|it was particularly bad after i did a git pull on my fork that was 1000+ commits behind.
 72 2017-09-14 15:33:41	0|mryandao|i had to remove the whole repo and clone with depth=1
 73 2017-09-14 15:33:47	0|wumpus|well better to run git outside tmux then?
 74 2017-09-14 15:33:55	0|wumpus|at least initial clones
 75 2017-09-14 15:34:09	0|wumpus|if you think cloning bitcoin is bad, try cloning the linux kernel
 76 2017-09-14 15:35:08	0|mryandao|heh
 77 2017-09-14 15:36:15	0|mryandao|ah actually, it might be tmux-airline that was tracking the 1000+ commit that's pending
 78 2017-09-14 16:05:27	0|wumpus|ok
 79 2017-09-14 16:25:45	0|luke-jr|wumpus: mryandao: interesting, usually GNU Screen (similar to tmux) reduces screen update lag O.o
 80 2017-09-14 16:28:39	0|bitcoin-git|[13bitcoin] 15mess110 opened pull request #11329: [test] Test abortrescan command (06master...06kallewoof/test-abort-rescan-2) 02https://github.com/bitcoin/bitcoin/pull/11329
 81 2017-09-14 16:30:08	0|wumpus|interesting, it probably does some update coalescing on the background. I've personally never noticed tmux making things slower, but I don't have any fancy plugins iether
 82 2017-09-14 16:34:48	0|luke-jr|right
 83 2017-09-14 17:23:53	0|bitcoin-git|[13bitcoin] 15danra opened pull request #11330: Trivial: Fix comments for DEFAULT_WHITELIST[FORCE]RELAY (06master...06patch-10) 02https://github.com/bitcoin/bitcoin/pull/11330
 84 2017-09-14 17:28:02	0|achow101|if anyone sees any issue remotely like #11171, please get the GUI settings (from windows registry or from ~/.config/Bitcoin/Bitcoin-Qt.conf) before doing -resetguisettings
 85 2017-09-14 17:28:04	0|gribble|https://github.com/bitcoin/bitcoin/issues/11171 | RC2 Exits After Initialization · Issue #11171 · bitcoin/bitcoin · GitHub
 86 2017-09-14 17:28:27	0|achow101|I would like to see what the gui settings are before they are reset as that should give a clue as to how that crash is happening
 87 2017-09-14 17:30:16	0|wumpus|yes that would be very useful to know
 88 2017-09-14 17:30:51	0|wumpus|will you ask in the issue too?
 89 2017-09-14 17:31:06	0|achow101|yep, asked
 90 2017-09-14 17:32:00	0|achow101|I didn't realize someone else was experiencing the same problem. otherwise I would have asked them for their gui settings earlier, but they already reset them
 91 2017-09-14 17:32:39	0|gmaxwell|Has anyone encountered this on Linux?
 92 2017-09-14 17:33:17	0|achow101|gmaxwell: I don't think so
 93 2017-09-14 17:34:47	0|ryanofsky|BlueMatt got a report from someone yesterday using linux
 94 2017-09-14 17:36:06	0|wumpus|so from achow101's analysis it looks like something to do with the proxy configuration? that could be the case ,proxy can be set from the gui settings
 95 2017-09-14 17:36:07	0|BlueMatt|yea, someone complaining that 0.15 on the ppa was busted
 96 2017-09-14 17:36:18	0|BlueMatt|his response to me claimed he assumed it was proxy
 97 2017-09-14 17:36:43	0|BlueMatt|i asked for more details but havent heard back yet (to try to confirm it if possible)
 98 2017-09-14 17:36:51	0|achow101|I think it has to do with the proxy setting although I couldn't think of a proxy string that would replicate the problem
 99 2017-09-14 17:36:55	0|wumpus|if that is true, though, it should be possible to trigger it from the command line too, as the proxy simply gets passed in in a similar way
100 2017-09-14 17:38:38	0|wumpus|yes exactly then it will be some string that crashes it
101 2017-09-14 17:39:06	0|wumpus|apparently starting with 0.15 branch
102 2017-09-14 17:39:15	0|achow101|well I tried a lot of weird strings and couldn't get anything to crash it :/
103 2017-09-14 17:39:39	0|achow101|I got it to crash after it all loaded and I tried to modify the settings though. There's an open issue for that
104 2017-09-14 17:39:40	0|wumpus|I don't remember if there were any proxy handling changes for 0.15
105 2017-09-14 17:42:17	0|gmaxwell|thats it's a crash limits the number of possibiltty.
106 2017-09-14 17:42:21	0|gmaxwell|er possibilities.
107 2017-09-14 17:43:55	0|gmaxwell|Merge #9774: Enable host lookups for -proxy and -onion parameters
108 2017-09-14 17:43:57	0|gribble|https://github.com/bitcoin/bitcoin/issues/9774 | Enable host lookups for -proxy and -onion parameters by jmcorgan · Pull Request #9774 · bitcoin/bitcoin · GitHub
109 2017-09-14 17:43:59	0|gmaxwell|looks like it was in 0.15
110 2017-09-14 17:44:53	0|wumpus|yes, that one would certainly be a possibility
111 2017-09-14 17:48:32	0|bitcoin-git|[13bitcoin] 15jnewbery closed pull request #10748: [config] Help text cleanup (06master...06helptextcleanup) 02https://github.com/bitcoin/bitcoin/pull/10748
112 2017-09-14 17:48:48	0|wumpus|I don't see how though
113 2017-09-14 17:50:21	0|wumpus|if it's something in paymentserver crashing, it's not the lookup itself that crashes it, but something in the transfer of the proxy address to a qt structure
114 2017-09-14 17:51:47	0|gmaxwell|well for example, I wonder if Lookup would crash with a e.g. 0xff input. otherwise I don't see how the lookup change could be it
115 2017-09-14 17:52:25	0|gmaxwell|(or maybe a truncated multibyte character)
116 2017-09-14 17:53:12	0|wumpus|it happens after the argument parsing though
117 2017-09-14 17:54:01	0|wumpus|in the log in 11171 it's even handling peers already
118 2017-09-14 17:54:53	0|gmaxwell|the obvious way to try to repro is to get these things set in the registry, then edit the registry manually to set the keys to empty strings.
119 2017-09-14 17:55:23	0|achow101|gmaxwell: been there done that. A lot of invalid things are caught that makes it fail to start entirely (throws initerror)
120 2017-09-14 17:56:18	0|wumpus|yes, it help so much to have an example of a failing config
121 2017-09-14 17:59:59	0|harrymm|i got matt's ppa to my ubuntu 17.04 system when it was available. i had the gui crash you're talking about and got it working with -resetguisettings.
122 2017-09-14 18:00:12	0|harrymm|i still have the processed core dump if that helps ya.
123 2017-09-14 18:01:03	0|achow101|harding: it would be better to have your gui config
124 2017-09-14 18:01:03	0|gmaxwell|you have a core dump!
125 2017-09-14 18:01:13	0|harrymm|it actually said the seg was SIGSEGV at QAbstractButton:setChecked(bool) from libQtGui.so.4.
126 2017-09-14 18:01:16	0|gmaxwell|achow101: not harding, harrymm
127 2017-09-14 18:01:18	0|bitcoin-git|[13bitcoin] 15danra opened pull request #11331: Trivial: Update outdated comment in validation.h (06master...06patch-11) 02https://github.com/bitcoin/bitcoin/pull/11331
128 2017-09-14 18:01:23	0|achow101|oops
129 2017-09-14 18:02:07	0|harrymm|yep. i'm not sure how to analyse it. it's a whoopsie thing.
130 2017-09-14 18:02:31	0|harrymm|gdb doesn't do the job. sorry i'm not too skillful at this :)
131 2017-09-14 18:03:25	0|harrymm|it was produced when i allowed it to send the bug info to launchpad trackers (I thought)
132 2017-09-14 18:04:59	0|BlueMatt|harrymm: I mean what settings do you recall having? custom datadir, encrypted wallet, selected different buttons for fees in the send tab.....?
133 2017-09-14 18:05:06	0|BlueMatt|minimize to tray?
134 2017-09-14 18:06:19	0|harrymm|yes to all of those iirc
135 2017-09-14 18:06:52	0|harrymm|i had a backup i made during this process but cleaned it out today when the thing finally worked. :(
136 2017-09-14 18:07:52	0|gmaxwell|harrymm: can you get a backtrace from it?    gdb -c corefile ./path-to/bitcoin-qt    then "thread apply all bt full"
137 2017-09-14 18:08:42	0|harrymm|i'll have a shot...
138 2017-09-14 18:10:06	0|harrymm|no. that gives me the same result i got before. it doesn't recognize the apport/whoopsie processed file
139 2017-09-14 18:10:52	0|gmaxwell|okay I don't know what that does it it.
140 2017-09-14 18:11:03	0|wumpus|it's possible to extract a gdb core dump from the processed file, don't remember the steps though
141 2017-09-14 18:11:06	0|harrymm|i couldn't find out how to load it locally either. but the file info was sent off to a bug tracker at the time (severl times in fact). launchpad should have it.
142 2017-09-14 18:11:55	0|harrymm|tho. this file is 100MB. i'm sure not that much was in the bug report :)
143 2017-09-14 18:11:57	0|wumpus|apport-unpack apparently https://wiki.ubuntu.com/Apport#I.27m_a_developer._How_do_I_use_these_crash_reports.3F
144 2017-09-14 18:12:32	0|wumpus|yes, these are steps for examining it locally, not sure what parts are uploaded
145 2017-09-14 18:14:40	0|BlueMatt|i see no bugs anywhere...no idea what reporting it did
146 2017-09-14 18:14:55	0|BlueMatt|unless you're the "john" who emailed previously
147 2017-09-14 18:17:30	0|harrymm|not me. tho i did see a comment with this same fault. someone suggested a new report be opened but afaik it was not done.
148 2017-09-14 18:17:51	0|BlueMatt|a comment? where?
149 2017-09-14 18:17:53	0|harrymm|that was in github iirc
150 2017-09-14 18:17:58	0|BlueMatt|ohoh, yea, github
151 2017-09-14 18:18:14	0|BlueMatt|i dont know what blackhole the launchpad reports went into
152 2017-09-14 18:18:27	0|harrymm|i tried to find it too .. failed
153 2017-09-14 18:18:41	0|harrymm|so shall i try to unpack this thing?
154 2017-09-14 18:18:47	0|BlueMatt|yes, please
155 2017-09-14 18:19:17	0|harrymm|k. i didn't have much luck with apport options yesterday but i didn't try this particular one.
156 2017-09-14 18:20:12	0|wumpus|yes, the core dump inside it can hopefully give us a useful backtrace
157 2017-09-14 18:20:56	0|harrymm|wow. that worked and it was quick. i now have a whole bunch of separate files
158 2017-09-14 18:21:51	0|harrymm|destination "%rbx" ok
159 2017-09-14 18:21:51	0|harrymm|PC (0x7fd6466e033d) ok
160 2017-09-14 18:21:51	0|harrymm|source "0x8(%rdi)" (0x00000008) not located in a known VMA region (needed readable region)!
161 2017-09-14 18:21:51	0|harrymm|the segvanalysis file says: Segfault happened at: 0x7fd6466e033d <_ZN15QAbstractButton10setCheckedEb+13>:   mov    0x8(%rdi),%rbx
162 2017-09-14 18:22:45	0|wumpus|can you pastebin the output of: <gmaxwell> harrymm: can you get a backtrace from it?    gdb -c corefile ./path-to/bitcoin-qt    then "thread apply all bt full"
163 2017-09-14 18:22:49	0|harrymm|segvreason: reading NULL VMA
164 2017-09-14 18:23:18	0|harrymm|i can't make gdb process this thing
165 2017-09-14 18:23:23	0|wumpus|I guess something called setChecked on a NULL pointer
166 2017-09-14 18:23:37	0|wumpus|there should be a corefile between those unpacked files, that works with gdb in that way
167 2017-09-14 18:23:51	0|harrymm|oh. wait..
168 2017-09-14 18:25:36	0|harrymm|haha. i missed that CoreDump file. Ok. I've got gdb opened.
169 2017-09-14 18:26:52	0|wumpus|these are all uses of setChecked in the code base: https://0bin.net/paste/CMyf3KukY-4bWwpS#MpZG+6rLJIl-1gwTfsKUe4baTOHnCmPDtVpJcLMpos2
170 2017-09-14 18:27:11	0|BlueMatt|wumpus: where do you think my list of possible settings in use came from :p
171 2017-09-14 18:27:44	0|harrymm|how do i get a file out containg the backtrace?
172 2017-09-14 18:28:12	0|BlueMatt|just copy/paste the output of the above command into a site like 0bin or pastebin
173 2017-09-14 18:28:14	0|harrymm|no symbols of course, but i can prolly get it up to pastebin
174 2017-09-14 18:28:14	0|wumpus|to make gdb log, "set logging file <filename>" "set logging on"
175 2017-09-14 18:28:20	0|BlueMatt|or that
176 2017-09-14 18:28:27	0|wumpus|no symbols in the ppa?
177 2017-09-14 18:29:08	0|wumpus|we don't have separate debug info for that one either :/
178 2017-09-14 18:29:31	0|BlueMatt|you can get symbols from ppa
179 2017-09-14 18:29:35	0|BlueMatt|but you have to manually download that
180 2017-09-14 18:29:38	0|BlueMatt|sec
181 2017-09-14 18:29:57	0|BlueMatt|what ubuntu version?
182 2017-09-14 18:30:44	0|harrymm|17.04
183 2017-09-14 18:31:17	0|harrymm|i got a log file. i'll wait to see oif i can get symbols tho
184 2017-09-14 18:31:26	0|BlueMatt|https://launchpad.net/~bitcoin/+archive/ubuntu/bitcoin/+build/13367431/+files/bitcoind-dbgsym_0.15.0-zesty6_amd64.ddeb
185 2017-09-14 18:31:29	0|BlueMatt|from https://launchpad.net/~bitcoin/+archive/ubuntu/bitcoin/+build/13367431
186 2017-09-14 18:31:36	0|BlueMatt|i assume you ended up with 0.15.0-zesty6
187 2017-09-14 18:31:51	0|harrymm|sounds right.
188 2017-09-14 18:32:16	0|harrymm|not sure about that 6 but iirc it was :)
189 2017-09-14 18:32:50	0|BlueMatt|i dont actually know how to turn that into debugsyms in gdb, but I believe dpkg -i will let you install the ddeb file
190 2017-09-14 18:35:30	0|BlueMatt|harrymm: I think it might magic....if you download the ddeb file there, dpkg -i it (or otherwise install it like a normal package) and then re-open gdb, it may know to search usr/lib/debug
191 2017-09-14 18:38:09	0|harrymm|double-click worked. lol. gdb is showing symbols now.
192 2017-09-14 18:42:37	0|achow101|harrymm: got the gdb output yet?
193 2017-09-14 18:46:45	0|harrymm|https://pastebin.com/XDzaeFrS
194 2017-09-14 18:47:07	0|harrymm|but it frustratingly seems to not have the symbols dammit. it loaded them ok ...
195 2017-09-14 18:53:02	0|harrymm|aww. should i have told gdb to load symbols from the symbols downloaded? it says it's reading them from bitcoin-qt (which doesn't have them)
196 2017-09-14 18:53:38	0|achow101|harrymm: I believe so. I don't remember the gdb commands/params for that though
197 2017-09-14 18:54:03	0|harrymm|i see a -s <file> but dunno what file i got
198 2017-09-14 18:54:30	0|harrymm|i apologize for my naivety :)
199 2017-09-14 18:57:44	0|BlueMatt|your file is /usr/lib/debug/usr/bin/bitcoind
200 2017-09-14 18:57:54	0|harrymm|ahh
201 2017-09-14 18:58:15	0|harrymm|wait. bitcoind or bitcoin-qt?
202 2017-09-14 18:58:23	0|BlueMatt|oh, no, bitcoin-qt, sorry
203 2017-09-14 18:58:28	0|BlueMatt|oh, wait, lol wrong file
204 2017-09-14 18:58:28	0|BlueMatt|sec
205 2017-09-14 18:58:29	0|harrymm|ok
206 2017-09-14 18:58:48	0|BlueMatt|yea, obviously you want the -qt dbgsym ddeb instead
207 2017-09-14 18:59:07	0|BlueMatt|https://launchpad.net/~bitcoin/+archive/ubuntu/bitcoin/+build/13367431/+files/bitcoin-qt-dbgsym_0.15.0-zesty6_amd64.ddeb
208 2017-09-14 18:59:37	0|gmaxwell|30 seconds till meeting.
209 2017-09-14 18:59:43	0|harrymm|lol. i see it now too.
210 2017-09-14 19:00:07	0|wumpus|#startmeeting
211 2017-09-14 19:00:08	0|lightningbot|Meeting started Thu Sep 14 19:00:07 2017 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
212 2017-09-14 19:00:08	0|lightningbot|Useful Commands: #action #agreed #help #info #idea #link #topic.
213 2017-09-14 19:00:11	0|sipa|present
214 2017-09-14 19:00:21	0|gmaxwell|sipa: you're late
215 2017-09-14 19:00:21	0|instagibbs|hi
216 2017-09-14 19:00:23	0|jonasschnelli|Hy
217 2017-09-14 19:00:31	0|wumpus|#bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101
218 2017-09-14 19:00:53	0|cfields_|hi
219 2017-09-14 19:01:01	0|sipa|short topic: congrats for 0.15.0!
220 2017-09-14 19:01:09	0|Chris_Stewart_5|yay!
221 2017-09-14 19:01:14	0|cfields_|woohoo
222 2017-09-14 19:01:21	0|wumpus|congrats and thanks everyone
223 2017-09-14 19:01:26	0|instagibbs|\o/
224 2017-09-14 19:01:27	0|jonasschnelli|!
225 2017-09-14 19:01:38	0|harrymm|:)
226 2017-09-14 19:01:51	0|wumpus|#topic high priority for review
227 2017-09-14 19:01:55	0|instagibbs|beatings will continue until 0.15.1 is out the door
228 2017-09-14 19:02:18	0|wumpus|we managed to merge quite a lot during the coredev meet, so there's some place for new things in https://github.com/bitcoin/bitcoin/projects/8
229 2017-09-14 19:03:05	0|wumpus|so any suggestions?
230 2017-09-14 19:03:15	0|achow101|hi
231 2017-09-14 19:03:53	0|BlueMatt|s
232 2017-09-14 19:04:07	0|BlueMatt|sipa: you dont have one
233 2017-09-14 19:04:18	0|wumpus|anything for 0.15.1 maybe?
234 2017-09-14 19:04:27	0|sipa|#11167 then
235 2017-09-14 19:04:29	0|gribble|https://github.com/bitcoin/bitcoin/issues/11167 | Full BIP173 (Bech32) support by sipa · Pull Request #11167 · bitcoin/bitcoin · GitHub
236 2017-09-14 19:04:40	0|instagibbs|#11089
237 2017-09-14 19:04:42	0|gribble|https://github.com/bitcoin/bitcoin/issues/11089 | Enable various p2sh-p2wpkh functionality by luke-jr · Pull Request #11089 · bitcoin/bitcoin · GitHub
238 2017-09-14 19:04:52	0|wumpus|added 11167
239 2017-09-14 19:04:56	0|BlueMatt|where are we on 0.15.1?
240 2017-09-14 19:05:17	0|cfields_|i have a pretty long stream of stuff to prep for libevent, but i don't want to burn everyone out by nagging too much. would you all prefer a few prs, all of which build on each-other, and a final one that incorporates everything?
241 2017-09-14 19:05:24	0|sipa|i'll work on the segwit-by-default stuff for 0.15.1
242 2017-09-14 19:05:31	0|wumpus|added 11089
243 2017-09-14 19:06:18	0|wumpus|cfields_: that depends; if some part stands on itself, it might make sense to PR it first then give it as a blocker
244 2017-09-14 19:06:19	0|cfields_|(#10663 is the first of those. It's by no means high priority, other than it's necessary for the rest)
245 2017-09-14 19:06:20	0|gribble|https://github.com/bitcoin/bitcoin/issues/10663 | net: split resolve out of connect by theuni · Pull Request #10663 · bitcoin/bitcoin · GitHub
246 2017-09-14 19:06:42	0|wumpus|that says enough, added 10663
247 2017-09-14 19:06:46	0|jonasschnelli|cfields_ I Prefer a single one to get the overall pictures
248 2017-09-14 19:07:07	0|cfields_|wumpus: thanks
249 2017-09-14 19:07:07	0|wumpus|but if it's a single one there's just so damn much to review
250 2017-09-14 19:07:10	0|instagibbs|jonasschnelli, or all of them, chained, with backpointers to first one to review
251 2017-09-14 19:07:17	0|gmaxwell|this gui crash issues should be considered a 0.15.1 blocker, but we still aren't sure of the precise cause.
252 2017-09-14 19:07:26	0|BlueMatt|jonasschnelli: sure, but you cant merge that...opening one which will be final eventually and then breaking it into chunks is also ok
253 2017-09-14 19:07:30	0|wumpus|gmaxwell: agree
254 2017-09-14 19:07:34	0|BlueMatt|gmaxwell: yup :(
255 2017-09-14 19:07:46	0|cfields_|jonasschnelli: ok, i can break them up into nice chunks, and have a tracking PR with them all rebased on top of eachother
256 2017-09-14 19:07:52	0|gmaxwell|considering the flood of reports I am really no longer able to believe we didn't recently introduce it.
257 2017-09-14 19:07:57	0|cfields_|i think that's pretty common these days
258 2017-09-14 19:08:08	0|wumpus|cfields_: sounds good to me
259 2017-09-14 19:08:13	0|gmaxwell|(maybe via a dep upgrade)
260 2017-09-14 19:08:14	0|michagogo|o/
261 2017-09-14 19:08:28	0|jonasschnelli|one for conceptual overview and multiple for real merge
262 2017-09-14 19:08:29	0|wumpus|gmaxwell: agreed
263 2017-09-14 19:08:42	0|cfields_|gmaxwell: possible that other clients are dinking with config files?
264 2017-09-14 19:09:01	0|jonasschnelli|(sorry phone typping)
265 2017-09-14 19:09:05	0|gmaxwell|that was a theory I had too but have seen no evidence of it.
266 2017-09-14 19:09:21	0|gmaxwell|harrymm: have you run bitcoin unlimited or bitcoin cash or likewise on that system you crashed on?
267 2017-09-14 19:09:25	0|morcos|Wouldn't we see 0.14 reports in that case
268 2017-09-14 19:09:29	0|wumpus|we really need a config or regtest dump from someone that has the issue
269 2017-09-14 19:09:34	0|BlueMatt|harrymm: how are those -qt debug symbols coming?
270 2017-09-14 19:09:41	0|wumpus|before they run -resetguisettings
271 2017-09-14 19:09:55	0|wumpus|in retrospect we should have made resetguisettings dump the settings to a backup file
272 2017-09-14 19:10:01	0|jonasschnelli|cfields_ : perfect
273 2017-09-14 19:10:15	0|cfields_|gmaxwell: iirc we didn't bump qt for 0.15. so deps seem unlikely
274 2017-09-14 19:10:24	0|achow101|wumpus: we should start doing that now
275 2017-09-14 19:10:26	0|wumpus|I mean you only run it when something is wrong
276 2017-09-14 19:10:31	0|wumpus|achow101: yes
277 2017-09-14 19:11:06	0|wumpus|#action Make -resetguisettings dump settings to troubleshooting file in datadir
278 2017-09-14 19:11:10	0|gmaxwell|cfields_: well I'm not completely sure that the issue is 0.15.x specific based on report load it could have been, say, 0.14.2 too ... and just a lot of people are upgrading.
279 2017-09-14 19:11:33	0|sipa|"oh, it's faster, i'll try running a full node again"
280 2017-09-14 19:12:05	0|cfields_|gmaxwell: what's the OS diversity?
281 2017-09-14 19:12:07	0|wumpus|but it was *never* reported for 0.14.x
282 2017-09-14 19:12:15	0|sipa|wumpus: fair point...
283 2017-09-14 19:12:15	0|wumpus|it would explain more reports, sure
284 2017-09-14 19:12:23	0|gmaxwell|we have a linux report now. so far mostly windows reports.
285 2017-09-14 19:12:42	0|achow101|gmaxwell: I suspect that's because more people use windows than linux
286 2017-09-14 19:12:43	0|gmaxwell|I don't think we've had a mac report. maybe there are just no mac users. :P
287 2017-09-14 19:13:06	0|cfields_|ah damn, i was thinking it could be a windows update
288 2017-09-14 19:13:07	0|sipa|did we update qt in between 0.14.2 and 0.15.0?
289 2017-09-14 19:13:21	0|harrymm|gmaxwell: not those you mentioned. i did try some other bitcoin python stuff at various times tho
290 2017-09-14 19:13:33	0|cfields_|hmm. I can run on osx and plug/unplug monitors like a madman.
291 2017-09-14 19:13:38	0|gmaxwell|harrymm: thanks.
292 2017-09-14 19:13:44	0|achow101|cfields_: it's not a monitor problem
293 2017-09-14 19:13:50	0|gmaxwell|So thats counter evidence to the theory that bch or bu is corrupting it.
294 2017-09-14 19:14:04	0|wumpus|the monitor problem just disappears the window
295 2017-09-14 19:14:08	0|wumpus|I think this is unrelated
296 2017-09-14 19:14:16	0|achow101|This is definitely unrelated
297 2017-09-14 19:14:26	0|cfields_|ok
298 2017-09-14 19:14:39	0|jonasschnelli|is that still the offscreen issue?
299 2017-09-14 19:14:45	0|gmaxwell|There may be two issues fixed with the same thing or two manifestiations of the same issue.
300 2017-09-14 19:14:57	0|harrymm|BlueMatt: i got the right symbols down and loaded into gdb, but there's still many symbols i don't have. i was checking if the relevant ones were there but not sure i have the right skills anyway so i will pastebin what i have
301 2017-09-14 19:15:01	0|achow101|jonasschnelli: it's the #11171 issue
302 2017-09-14 19:15:03	0|gribble|https://github.com/bitcoin/bitcoin/issues/11171 | RC2 Exits After Initialization · Issue #11171 · bitcoin/bitcoin · GitHub
303 2017-09-14 19:15:18	0|achow101|which is not an offscreen issue although we initially thought it was
304 2017-09-14 19:15:22	0|jonasschnelli|again:  GUI: TransactionTablePriv::refreshWallet
305 2017-09-14 19:15:49	0|wumpus|jonasschnelli: was that the same problem?
306 2017-09-14 19:16:02	0|wumpus|jonasschnelli: I don'tremember that one was fixed by clearing gui settings
307 2017-09-14 19:16:11	0|wumpus|the offscreen issue is not a segfault, ever
308 2017-09-14 19:16:15	0|jonasschnelli|no... not possible IMO
309 2017-09-14 19:16:32	0|jonasschnelli|11171 seems totally unrelated to the offscreen issue
310 2017-09-14 19:16:34	0|wumpus|the refreshWallet crash was intermittent, very hard to reproduce
311 2017-09-14 19:16:38	0|wumpus|this one is 100% reproducible
312 2017-09-14 19:16:44	0|wumpus|unless you clear the settings
313 2017-09-14 19:16:57	0|jonasschnelli|Okay. I'll track down 11171
314 2017-09-14 19:17:02	0|BlueMatt|harrymm: yea, pastebin what you have would be great
315 2017-09-14 19:17:12	0|achow101|jonasschnelli: that's what we're doing now with harrymm :)
316 2017-09-14 19:17:32	0|jonasschnelli|xyzzy099 == harrymm?
317 2017-09-14 19:17:35	0|gmaxwell|BlueMatt: offscreen gets the same report from users though:  window doesn't appear, resetting the gui settings fixes it.
318 2017-09-14 19:17:52	0|jonasschnelli|gmaxwell: I have tracked this down and it's no longer present in 0.15
319 2017-09-14 19:17:53	0|achow101|jonasschnelli: no, different people, same symptoms, possibly same problem
320 2017-09-14 19:17:57	0|jonasschnelli|(official builds)
321 2017-09-14 19:18:09	0|jonasschnelli|It may happen if you self compile with <Qt5.6
322 2017-09-14 19:18:13	0|achow101|(symptoms being crash after splash screen)
323 2017-09-14 19:18:33	0|wumpus|yes the offscreen one has unclear status on the release binaries, jonasschnelli's testing points at it being fixed
324 2017-09-14 19:18:34	0|BlueMatt|jonasschnelli: which issue is that?
325 2017-09-14 19:18:41	0|BlueMatt|ah, offscreen
326 2017-09-14 19:18:53	0|achow101|wumpus: I believe the offscreen issue should be fixed in 0.15
327 2017-09-14 19:19:01	0|wumpus|achow101: yes
328 2017-09-14 19:19:02	0|BlueMatt|it'd be nice to fix the qt5 issues so that ppa can upgrade to it instead of being stuck on qt4......
329 2017-09-14 19:19:16	0|jonasschnelli|It's fixed in 0.15.0 (I have tested with Win7,8.1/10)
330 2017-09-14 19:19:17	0|wumpus|BlueMatt: just wait for unity to die
331 2017-09-14 19:19:20	0|gmaxwell|jonasschnelli: how does <Qt5.6 come into it?
332 2017-09-14 19:19:53	0|wumpus|wasn't the most serious qt5 problem on ubuntu the tray icon thing? no such issue on GNOME
333 2017-09-14 19:20:03	0|jonasschnelli|gmaxwell: I'm not sure if Qt is related. I could not find if the bug was fixed upstream (I think we had a Qt depdendency upgrade from 0.14 to 0.15) or if its fixed in out sources.
334 2017-09-14 19:20:06	0|BlueMatt|wumpus: heh, I mean there was discussion of killing the tray icon
335 2017-09-14 19:20:13	0|BlueMatt|wumpus: yes, I believe the tray icon was ~the only blocker
336 2017-09-14 19:20:18	0|gmaxwell|jonasschnelli: the problem is that we've had users reporting all through the rcs something that sounds like that, and now in releases. So just saying its fixed isn't helpful, since there is clearly something that isn't fixed.
337 2017-09-14 19:20:33	0|wumpus|anyhow that's yet another different issue
338 2017-09-14 19:20:38	0|BlueMatt|wumpus: there was some minimize issue that was also there, but I believe it was related...just kill the tray icon and its fixed, I think
339 2017-09-14 19:20:47	0|achow101|gmaxwell: jonasschnelli: I think you're talking about different issues
340 2017-09-14 19:20:48	0|jonasschnelli|gmaxwell: IMO its an upstream bug.
341 2017-09-14 19:20:49	0|harrymm|BlueMatt: best backtrace I have: https://pastebin.com/ZEZUhEDW
342 2017-09-14 19:20:58	0|wumpus|it's almost as if we have a lot of GUI issues and not many people working on the GUI :)
343 2017-09-14 19:21:05	0|sipa|jonasschnelli: i don't understand
344 2017-09-14 19:21:14	0|sipa|jonasschnelli: is it fixed, or is it an upstream bug?
345 2017-09-14 19:21:24	0|wumpus|both - upstream bug that is fixed
346 2017-09-14 19:21:30	0|jonasschnelli|the offscreen issue was present in our official 0.14.x bninaries while it's gone in our 0.15.0 binary
347 2017-09-14 19:21:38	0|gmaxwell|or "is it fixed" or "can't reproduce"?
348 2017-09-14 19:21:39	0|sipa|we're not talking about the offscreen issue...
349 2017-09-14 19:21:49	0|wumpus|let's discuss one issue at a time
350 2017-09-14 19:21:52	0|jonasschnelli|sipa: it is fixed,.. very likely in an upstream fix (could not track down the commit)
351 2017-09-14 19:21:52	0|wumpus|this is getting crazy
352 2017-09-14 19:22:01	0|sipa|jonasschnelli: then why are we getting reports?
353 2017-09-14 19:22:12	0|gmaxwell|jonasschnelli: what patch fixed it in 0.15?
354 2017-09-14 19:22:26	0|jonasschnelli|sipa: offscreen bug: could be because people compile with an Qt version below qt5.6?
355 2017-09-14 19:22:32	0|wumpus|we really need a test for the offscreen issue, right now we have *no* way to evaluate any fix
356 2017-09-14 19:22:41	0|wumpus|we could merge another PR that claims to fix it
357 2017-09-14 19:22:46	0|wumpus|but I'm kind of sick of that
358 2017-09-14 19:22:50	0|BlueMatt|https://github.com/bitcoin/bitcoin/blob/0.15/src/qt/sendcoinsdialog.cpp#L131 <-- the bug
359 2017-09-14 19:22:50	0|sipa|wait, i thought we were talking about the crash-at-startup issue?
360 2017-09-14 19:22:59	0|jonasschnelli|gmaxwell: I need to track it down. I just tested 0.14.1 and 0.15.0 on win7,8.1,10 and verfied that it is fixed in 0.15
361 2017-09-14 19:23:10	0|achow101|BlueMatt: yay!
362 2017-09-14 19:23:10	0|BlueMatt|ok, but lets be clear there are multiple bugs here
363 2017-09-14 19:23:14	0|jonasschnelli|sipa: sorry,... we slipped to the offscreen issue.
364 2017-09-14 19:23:19	0|sipa|okay, ignore me
365 2017-09-14 19:23:20	0|BlueMatt|the offscreen issue, which jonasschnelli believes to be fixed
366 2017-09-14 19:23:23	0|gmaxwell|jonasschnelli: what does verified that it's fixed in 0.15 mean?  Does that just mean you were unable to reproduce it at all?
367 2017-09-14 19:23:32	0|BlueMatt|also the settings issue, which is L131 as above based on harrymm's backtrace
368 2017-09-14 19:23:37	0|wumpus|gmaxwell: yes, that means it
369 2017-09-14 19:23:52	0|jonasschnelli|gmaxwell: I set the window position by RegEdit to 3000,3000, 0.14 has the issue, 0.15 doens't
370 2017-09-14 19:24:07	0|achow101|BlueMatt: I don't see how there's a bug there
371 2017-09-14 19:24:24	0|wumpus|jonasschnelli: thanks for doing a sane, reproducible test :)
372 2017-09-14 19:25:03	0|jonasschnelli|11171 is far more important
373 2017-09-14 19:25:11	0|gmaxwell|jonasschnelli: okay, but if the issue users are hitting is that the use positions the window in the bottom left of the screen (below task bar) then they'd still be hitting it... since the reproduction was synthetic.
374 2017-09-14 19:25:11	0|wumpus|I agree
375 2017-09-14 19:25:21	0|wumpus|crash bugs are more important, and this happens for a lot more users
376 2017-09-14 19:25:46	0|gmaxwell|I know that at least one of the users I helped during the RCs wasn't crashing (Because they had to kill bitcoin-qt in their task manager)
377 2017-09-14 19:25:53	0|jtimon|oops, I'm late
378 2017-09-14 19:25:58	0|jonasschnelli|gmaxwell: I can investigate again and report
379 2017-09-14 19:25:58	0|jtimon|yay 0.15!
380 2017-09-14 19:26:04	0|sipa|gmaxwell: sure, but there's only so much we can do
381 2017-09-14 19:26:20	0|gmaxwell|sipa: we could stop saving the position.
382 2017-09-14 19:26:30	0|wumpus|yes, ideally we should test all 8 areas outside the screen, something for an automated test
383 2017-09-14 19:26:50	0|wumpus|or just nuke the remember-position functionality
384 2017-09-14 19:27:04	0|jonasschnelli|my observation is that Qt handles offscreen situation pretty well... if a certain area of the window is offscreen, it re-centers.
385 2017-09-14 19:27:05	0|wumpus|the longer this remains an issue the more I'm tempted to the latter
386 2017-09-14 19:27:18	0|sipa|does -resetguisettings change anything but the remembered window coordinates?
387 2017-09-14 19:27:36	0|gmaxwell|jonasschnelli: QT5 but perhaps not QT4? (which, for example, the ppa uses, I believe)
388 2017-09-14 19:27:37	0|wumpus|sipa: yes, it clears all settings set through the gui optioins dialog
389 2017-09-14 19:27:39	0|jonasschnelli|It may kill your dbcache / proxy settings
390 2017-09-14 19:27:48	0|sipa|oh!
391 2017-09-14 19:27:57	0|jonasschnelli|Oh. PPA / QT4
392 2017-09-14 19:28:03	0|achow101|Oh, I think I found harrymm's bug
393 2017-09-14 19:28:04	0|jonasschnelli|Yes. The issue is very likely present there...
394 2017-09-14 19:28:04	0|wumpus|as well as all other things the GUI remembers (there might be something in the send dialog with fee, I vaguely remember)
395 2017-09-14 19:28:08	0|gmaxwell|sipa: you missed earlier discussion, based on debuglog traffic achow has suggested its actually the proxy that is implicated in the crash.,
396 2017-09-14 19:28:12	0|jonasschnelli|I don't see a reason to do the PPA with Qt4?
397 2017-09-14 19:28:23	0|BlueMatt|achow101: yea, there's only one button in that group
398 2017-09-14 19:28:24	0|gmaxwell|sipa: I pointed out that 0.15 did change proxy handling (name lookup) but a cause of a crash isn't obvious there.
399 2017-09-14 19:28:26	0|sipa|gmaxwell: ah
400 2017-09-14 19:28:49	0|achow101|BlueMatt: I mean how different settings for nCustomFeeRadio cause a segfault
401 2017-09-14 19:28:51	0|jonasschnelli|Maybe we just add a failsafe: if offscreen then re-center... (but sounds simpler then it is)
402 2017-09-14 19:29:00	0|gmaxwell|the user in here with the crash on linux knows the function where the segfault happens for him (inside a qt button setting function)
403 2017-09-14 19:29:09	0|wumpus|achow101: interesting, so it might be the custom fee setting?
404 2017-09-14 19:29:13	0|BlueMatt|achow101: yes
405 2017-09-14 19:29:22	0|wumpus|achow101: I forgot about that one completely as it's not in the options dialog
406 2017-09-14 19:29:26	0|BlueMatt|wumpus: it appears to be a what-button-had-you-clicked-on-in-14.2 issue
407 2017-09-14 19:29:30	0|achow101|wumpus: yes
408 2017-09-14 19:29:37	0|achow101|I set nCustomFeeRadio=1 and that causes a segfault
409 2017-09-14 19:29:38	0|gmaxwell|oh we also changed the options for fees at some point in recent memory, could people have settings that made sense in 0.14 but not now?
410 2017-09-14 19:29:46	0|wumpus|gmaxwell: ouch
411 2017-09-14 19:29:54	0|sipa|achow101: nice catch
412 2017-09-14 19:29:57	0|gmaxwell|sounds like it.
413 2017-09-14 19:29:59	0|BlueMatt|we deleted a button
414 2017-09-14 19:30:05	0|jonasschnelli|could it happend by https://github.com/bitcoin/bitcoin/pull/10769?
415 2017-09-14 19:30:10	0|BlueMatt|there is only one button in that group
416 2017-09-14 19:30:10	0|gmaxwell|consistent with the segfault location that harrymm reported too
417 2017-09-14 19:30:13	0|BlueMatt|so it obviously segfaults
418 2017-09-14 19:30:58	0|morcos|well that was a productive first half of the meeting
419 2017-09-14 19:31:13	0|wumpus|so nCustomFeeRadio should be removed completely? or are there other settitngs?
420 2017-09-14 19:31:29	0|harrymm|good work :)
421 2017-09-14 19:31:38	0|gmaxwell|0.15.1 next week? :P
422 2017-09-14 19:31:45	0|wumpus|debugging an issue during the meeting is kinda cool
423 2017-09-14 19:31:58	0|jonasschnelli|heh...
424 2017-09-14 19:32:01	0|dgenr8|my money was on sinister alt clients
425 2017-09-14 19:32:01	0|sipa|bughunting-by-committee
426 2017-09-14 19:32:28	0|gmaxwell|oh had nothing to do with sinister, just incompatible.
427 2017-09-14 19:32:35	0|sipa|where everyone forgets it's really achow101 who found it
428 2017-09-14 19:32:41	0|wumpus|sinister alt clients could have more custom fee settings, we should be robust against corrupt configuration in any case :)
429 2017-09-14 19:32:55	0|gmaxwell|thats the advantages of committess, one guy does all the work and everyone gets the credit!
430 2017-09-14 19:33:02	0|achow101|lol
431 2017-09-14 19:33:10	0|wumpus|haha good old USSR-style
432 2017-09-14 19:33:15	0|achow101|I found a way to reliably reproduce it
433 2017-09-14 19:33:28	0|achow101|which is the ncustomefeeradio thing, but I'm not sure what to do going forward
434 2017-09-14 19:33:28	0|gmaxwell|committees*
435 2017-09-14 19:33:39	0|sipa|achow101: i'm pretty sure that's the root cause
436 2017-09-14 19:33:41	0|wumpus|so how do we solve it?
437 2017-09-14 19:33:53	0|sipa|do we have to figure that out now?
438 2017-09-14 19:34:05	0|gmaxwell|achow101 will figure it out. our work here is done.
439 2017-09-14 19:34:05	0|sipa|if there are no other topics, why not, i guess
440 2017-09-14 19:34:06	0|wumpus|no, not really, I just wonder what is the use of a radio button with one option
441 2017-09-14 19:34:21	0|jonasschnelli|I'll can tackle the groupCustomFee segfault today
442 2017-09-14 19:34:28	0|wumpus|anyhow, any other topics?
443 2017-09-14 19:34:36	0|gmaxwell|wumpus: so you have the freedom to choose the Correct option, of course.
444 2017-09-14 19:34:49	0|instagibbs|any color car as long as it is black
445 2017-09-14 19:35:03	0|wumpus|gmaxwell: lol!
446 2017-09-14 19:35:04	0|gmaxwell|time to ford ahead.
447 2017-09-14 19:35:21	0|BlueMatt|ok, fix is easy, I'll get it fixed right after meeting
448 2017-09-14 19:35:23	0|achow101|jonasschnelli: great!
449 2017-09-14 19:35:24	0|wumpus|anything to discuss for 0.15.1?
450 2017-09-14 19:35:27	0|BlueMatt|https://github.com/bitcoin/bitcoin/commit/6ba2214e0fe57ecb9271819d2422ec44a9020a8d fixes it for now
451 2017-09-14 19:35:35	0|sipa|if there's nothing else; i have some open questions about segwit-by-default support in 0.15.1
452 2017-09-14 19:35:47	0|wumpus|#topic segwit-by-default support in 0.15.1
453 2017-09-14 19:35:55	0|BlueMatt|oh, wait, hmm
454 2017-09-14 19:36:14	0|sipa|my idea was to have a cmdline option to select a default address style, which could be p2pkh, p2sh-p2wpkh, or p2wpkh
455 2017-09-14 19:36:24	0|BlueMatt|or jonasschnelli can do it
456 2017-09-14 19:36:28	0|sipa|(where the middle one is default)
457 2017-09-14 19:36:32	0|sipa|and have an optional argument to getnewaddress to override it
458 2017-09-14 19:36:35	0|BlueMatt|sipa: seems reasonable?
459 2017-09-14 19:36:44	0|sipa|open question: separate option for change?
460 2017-09-14 19:37:06	0|instagibbs|imo yes
461 2017-09-14 19:37:15	0|BlueMatt|imo yes
462 2017-09-14 19:37:25	0|achow101|sipa: yes
463 2017-09-14 19:37:27	0|sipa|open question: do we want to return both p2wpkh and p2sh-p2wpkh (for now), as there is an efficiency gain when you want to give both to a peer
464 2017-09-14 19:37:43	0|sipa|downside: may not want we want to support longer term with split chains
465 2017-09-14 19:37:47	0|achow101|no, I think that will confuse people
466 2017-09-14 19:37:50	0|sipa|upside: more efficient to rescan
467 2017-09-14 19:37:52	0|instagibbs|I'd say no
468 2017-09-14 19:37:59	0|jonasschnelli|may confuse
469 2017-09-14 19:38:11	0|instagibbs|users who care will crank the option surely
470 2017-09-14 19:38:17	0|gmaxwell|we can't do that by default, interface breaking change.  If you want to call getnewaddress with style=gangnam and it returns both, that would be fine.
471 2017-09-14 19:38:40	0|achow101|style=gangnam <-- lol
472 2017-09-14 19:38:56	0|morcos|yep, i tested, running 0.14, setting the at least button, 0.15 crashes
473 2017-09-14 19:39:01	0|sipa|but style=gangnam would be pre-deprecated, and scheduled for removal in a future version
474 2017-09-14 19:39:03	0|morcos|oops was backlogged
475 2017-09-14 19:39:13	0|achow101|morcos: good to know that
476 2017-09-14 19:39:14	0|wumpus|hahahahaa
477 2017-09-14 19:39:58	0|BlueMatt|achow101: morcos also tested the 6ba2...fix from above, which fixed it, though the real fix isnt something that stupidly hacky
478 2017-09-14 19:40:06	0|sipa|ok, end of my topic
479 2017-09-14 19:40:08	0|cfields_|let's just let users decide with a 1-option combo-box :p
480 2017-09-14 19:40:11	0|gmaxwell|I'd say we could make the GUI show both too, except the URI/qr code can't really do that.
481 2017-09-14 19:40:19	0|cfields_|er, radio
482 2017-09-14 19:40:26	0|sipa|cfields_: unary encoding, i like it
483 2017-09-14 19:40:39	0|morcos|wait, i'm confused
484 2017-09-14 19:40:44	0|morcos|are you serious about giving both addresses
485 2017-09-14 19:40:48	0|morcos|no, why would we do that
486 2017-09-14 19:40:50	0|BlueMatt|lets not do that
487 2017-09-14 19:40:57	0|BlueMatt|you could also just call getnewaddress twice
488 2017-09-14 19:40:59	0|BlueMatt|who cares
489 2017-09-14 19:41:18	0|gmaxwell|morcos: as an option. The reason is so you can say "here is the bech32 one if you can pay to it, otherwise use X"
490 2017-09-14 19:41:18	0|morcos|you should have a way of selecting which type of address you want for change or for getnewaddress
491 2017-09-14 19:41:29	0|morcos|then give them 2 different keys
492 2017-09-14 19:41:34	0|morcos|that's how it'll work in 0.16
493 2017-09-14 19:41:56	0|morcos|lets not try to be cheap and save a couple of keys and start teaching people that you can use one or the other
494 2017-09-14 19:41:58	0|sipa|BlueMatt: my wallet.dat barely fits on a 3.5" floppy disk anymore...
495 2017-09-14 19:42:16	0|cfields_|morcos: +1
496 2017-09-14 19:42:18	0|instagibbs|will there be an argument to getnewaddress to override?
497 2017-09-14 19:42:21	0|instagibbs|id hope so
498 2017-09-14 19:42:22	0|morcos|i agree that's a downside, but its more important to set the precedent that these thigns are NOT interoperable
499 2017-09-14 19:42:25	0|morcos|yes
500 2017-09-14 19:42:25	0|sipa|instagibbs: i hope so, yes
501 2017-09-14 19:42:30	0|instagibbs|ok, then that's fine
502 2017-09-14 19:42:35	0|gmaxwell|okay... when I talked to sipa about it my objection was that we couldn't support it in the future. his counter was that we don't have to offer it in the future.
503 2017-09-14 19:42:35	0|instagibbs|i prefer
504 2017-09-14 19:42:43	0|BlueMatt|somehow I doubt bdb is useable on floppy-latency disks anyway :p
505 2017-09-14 19:42:54	0|gmaxwell|instagibbs: yes, there would be an option, setting would just set the default.
506 2017-09-14 19:43:14	0|instagibbs|then I see no reason to return both
507 2017-09-14 19:43:21	0|wumpus|yes,we need to make it very clear they're not interoperable, that you can't, in general just convert the one to the othe and have it work
508 2017-09-14 19:43:31	0|BlueMatt|then require two getnewaddress calls
509 2017-09-14 19:43:39	0|sipa|sounds good, you need to call getnewaddress twice
510 2017-09-14 19:43:41	0|sipa|ack
511 2017-09-14 19:43:45	0|achow101|+1
512 2017-09-14 19:43:47	0|sipa|no gangnam
513 2017-09-14 19:44:30	0|morcos|also in the scheme of things, each 0.15.1 wallet is wasting 2000 + N * (# getnewaddress calls) + (# changes) keys.... where N is 2 if you do what I want (only in the cases where you give out both) or 1 if you do what you want
514 2017-09-14 19:44:41	0|morcos|it makes no difference relatively speaking for almost all users
515 2017-09-14 19:45:27	0|jtimon|wumpus: ack on removing remember position functionality until we can test it automatically
516 2017-09-14 19:45:49	0|gmaxwell|jtimon has the gribble disease.
517 2017-09-14 19:45:56	0|wumpus|jtimon: that'd make sense, I guess
518 2017-09-14 19:46:10	0|gmaxwell|(20 minutes behind. :) )
519 2017-09-14 19:46:16	0|wumpus|seems the segwit-by-default topic is conclded, anything else?
520 2017-09-14 19:47:16	0|gmaxwell|I think we need to announce a workaround for this issue we all collectively figured out through our joint effort where no one person did all the work during the meeting.
521 2017-09-14 19:47:23	0|wumpus|haha yes gribble's behavior seemed very curious and random, before I realized it was just backlogged (or rather, github was?)
522 2017-09-14 19:47:44	0|BlueMatt|yes, do we have a mechanism for release errata?
523 2017-09-14 19:47:46	0|wumpus|or make a 0.15.0.1
524 2017-09-14 19:48:04	0|BlueMatt|given the ppa is still not up (cause arm qt...) I'll probably ship that with the hacky workaround patch posted above
525 2017-09-14 19:48:16	0|BlueMatt|unless there are objections
526 2017-09-14 19:48:18	0|wumpus|did you manage to debug the ARM qt issue? I'm curious
527 2017-09-14 19:48:29	0|wumpus|no objections, if you can patch it in your distro, do so
528 2017-09-14 19:48:36	0|wumpus|it's zero risk...
529 2017-09-14 19:48:45	0|BlueMatt|there appear to now be at least two separate issues, a miscompile, and I now have a stacktrace for another test_bitcoin-qt fail that I'm looking at now
530 2017-09-14 19:48:47	0|achow101|BlueMatt: I believe (not tested yet) that you can just remove L131 entirely
531 2017-09-14 19:48:56	0|sipa|let's fix the things at least in the 0.15 branch
532 2017-09-14 19:49:17	0|gmaxwell|I won't ack 0.15.0.1 because I do none of the required work for it but it might be nice.
533 2017-09-14 19:49:17	0|sipa|then depending on progress we can see whether it goes in 0.15.1, or if a 0.15.0.1 may be needed (at release manager's discretion...)
534 2017-09-14 19:49:20	0|wumpus|achow101: possibly, but BlueMatt's fix is obviosuly correct, a better fix is to just remove the setting completely
535 2017-09-14 19:49:22	0|BlueMatt|achow101: well the commit linked above works, so whatever
536 2017-09-14 19:49:27	0|wumpus|achow101: and the single-choice radio button
537 2017-09-14 19:49:28	0|gmaxwell|what sipa said
538 2017-09-14 19:49:43	0|wumpus|but for a quick hack that change is good
539 2017-09-14 19:49:53	0|morcos|in master can we please fix properly, remove the whole group
540 2017-09-14 19:49:59	0|wumpus|yes
541 2017-09-14 19:50:02	0|sipa|yes
542 2017-09-14 19:50:04	0|achow101|yes
543 2017-09-14 19:50:14	0|gmaxwell|yes
544 2017-09-14 19:50:54	0|gmaxwell|someone will need to contemplate how to prevent this kind of issue in the future.
545 2017-09-14 19:50:57	0|wumpus|well yes let's fix it on the branch then decide whether to do 0.15.0.1
546 2017-09-14 19:51:11	0|wumpus|better testing of the gui is the only answer
547 2017-09-14 19:51:14	0|achow101|gmaxwell: fuzz the qsettings options :)
548 2017-09-14 19:51:18	0|instagibbs|remove all features until qt is a single button
549 2017-09-14 19:51:33	0|jonasschnelli|Better GUI tests... but more important, "upgrade tests"
550 2017-09-14 19:51:34	0|gmaxwell|"moon"
551 2017-09-14 19:51:41	0|wumpus|hah
552 2017-09-14 19:51:45	0|gmaxwell|(responding to instagibbs)
553 2017-09-14 19:51:45	0|jonasschnelli|Non of our test do cover upgrade of wallets, etc.
554 2017-09-14 19:52:00	0|instagibbs|jonasschnelli, hmm good point
555 2017-09-14 19:52:27	0|jonasschnelli|Upgrade tests would probably require static data files from older versions....
556 2017-09-14 19:52:31	0|wumpus|well at least the reduced one radio buttons group to one button, that's a start...
557 2017-09-14 19:52:35	0|morcos|was fuzz qsettings a joke?   i did that with the fee estimation changes manually, i think thats a good idea
558 2017-09-14 19:52:38	0|wumpus|s/the/we/
559 2017-09-14 19:52:43	0|achow101|morcos: not really
560 2017-09-14 19:52:56	0|wumpus|no, it's not a joke, it'd help with robustness against corrupt configs a lot
561 2017-09-14 19:53:04	0|morcos|ok, the smiley threw me
562 2017-09-14 19:53:05	0|wumpus|but as we're not even fuzzing bitcoin.conf settings yet
563 2017-09-14 19:53:08	0|achow101|but it would mean a lot more changes since weird shit in qsettings totally screws up qt
564 2017-09-14 19:53:22	0|morcos|ha ha, fuzzing bitcoin.conf DEFINITELY breaks things
565 2017-09-14 19:53:24	0|achow101|we would need better bad-setting rejection
566 2017-09-14 19:53:30	0|jtimon|sipa: yeah, both formats seems like un ugly optimization. Doesn't look like it's worth it
567 2017-09-14 19:53:30	0|wumpus|gui testing is always at least 3 times as much work
568 2017-09-14 19:54:09	0|gmaxwell|sipa: I think he's still 20min behind.
569 2017-09-14 19:54:12	0|jonasschnelli|Not sure if fuzzing qt-settings (QSettings) make sense. It's not a file edited by users
570 2017-09-14 19:54:17	0|morcos|is jtimon working on-site on the blockstream Mars project
571 2017-09-14 19:54:18	0|BlueMatt|jtimon: is stuck on moon
572 2017-09-14 19:54:22	0|jtimon|gmaxwell: well, I arrived 30 mins late
573 2017-09-14 19:54:23	0|jonasschnelli|Fuzzing peers.dat or similar would also make little sense I guess
574 2017-09-14 19:54:23	0|wumpus|jonasschnelli: but it can get corrupt, like anything
575 2017-09-14 19:54:44	0|wumpus|though I agree there's a limit
576 2017-09-14 19:54:55	0|instagibbs|that would at least test it handles corrupted files right
577 2017-09-14 19:55:01	0|instagibbs|recently ran into a case where we werent
578 2017-09-14 19:55:18	0|jonasschnelli|Corrupt files should be handled by Qt IMO
579 2017-09-14 19:55:25	0|morcos|usually with bitcoin.conf we don't change the meaning of the options (cough cough sipa)
580 2017-09-14 19:55:27	0|jonasschnelli|The file itself is hidden on our application layer
581 2017-09-14 19:55:31	0|jonasschnelli|We just deal with QSettings
582 2017-09-14 19:55:42	0|morcos|we could be better about making sure we rename options in QT if we are goign to change their meaning
583 2017-09-14 19:55:48	0|wumpus|yes
584 2017-09-14 19:56:01	0|wumpus|much, much better to lose the setting than crash
585 2017-09-14 19:56:04	0|jonasschnelli|morcos: yes!
586 2017-09-14 19:56:07	0|wumpus|unless it's soomething like the proxy
587 2017-09-14 19:56:41	0|wumpus|but a nicety like remembering the fee setting? nah
588 2017-09-14 19:56:43	0|jonasschnelli|I don't understand why the crash does not happen on OSX (could only reproduce on Linux)
589 2017-09-14 19:56:43	0|jtimon|0.15.0.1 ? why not 15.0.1 directly and we stop writing the 0. prefix now? /me hides
590 2017-09-14 19:57:12	0|wumpus|likely the implementation of radio button group is different there
591 2017-09-14 19:57:37	0|wumpus|making it return e.g. a dummy object instead of corruption or null when reading out of range
592 2017-09-14 19:57:44	0|wumpus|macosx users just got lucky
593 2017-09-14 19:58:10	0|sipa|wumpus: we have occasionally had x.x.x.1 released for bugfixes that affect just some platforms
594 2017-09-14 19:58:14	0|instagibbs|2 minutes
595 2017-09-14 19:58:14	0|sipa|*releases
596 2017-09-14 19:58:16	0|morcos|one could argue they were silently forced to lose their at least setting which made them erroneously pay the wrong fees
597 2017-09-14 19:58:27	0|wumpus|sipa: yes, I wouldn't like to burn 0.15.1 on this mainly
598 2017-09-14 19:58:33	0|sipa|wumpus: agreed
599 2017-09-14 19:58:48	0|jtimon|finally catched up...to late to suggest a topic, but perhaps we can talk about it after the meeting
600 2017-09-14 19:59:22	0|jtimon|is about an index for scriptPubKeys
601 2017-09-14 19:59:42	0|wumpus|yes, we're done for today
602 2017-09-14 19:59:45	0|wumpus|#endmeeting
603 2017-09-14 19:59:46	0|lightningbot|Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2017/bitcoin-core-dev.2017-09-14-19.00.log.html
604 2017-09-14 19:59:46	0|lightningbot|Meeting ended Thu Sep 14 19:59:45 2017 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
605 2017-09-14 19:59:46	0|lightningbot|Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2017/bitcoin-core-dev.2017-09-14-19.00.html
606 2017-09-14 19:59:46	0|lightningbot|Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2017/bitcoin-core-dev.2017-09-14-19.00.txt
607 2017-09-14 19:59:54	0|achow101|ok bye. laptop is about to die
608 2017-09-14 19:59:56	0|jtimon|https://github.com/bitcoin/bitcoin/pull/9806 seems abandoned
609 2017-09-14 20:00:13	0|wumpus|jtimon: you mean of the utxo set?
610 2017-09-14 20:00:52	0|jtimon|how acceptable would be to maintain a scriptPubKey -> [list of outpoints using it] index ?
611 2017-09-14 20:01:18	0|jtimon|wumpus: well, spent outputs could be removed from the index or not
612 2017-09-14 20:01:35	0|wumpus|nack on a global index, concept ack on such an index over the UTXO set, would make it so easy to query any balance
613 2017-09-14 20:01:44	0|jtimon|perhaps with an option, or perhaps it's only acceptable for the utxo
614 2017-09-14 20:02:07	0|sipa|yeah, please no indexes that require the full chain
615 2017-09-14 20:02:29	0|wumpus|exactly
616 2017-09-14 20:03:10	0|adiabat|address index over utxo would be fun, I'd enable & use that
617 2017-09-14 20:03:18	0|jonasschnelli|ui->groupCustomFee->button((int)std::max(0, std::min(1, settings.value("nCustomFeeRadio").toInt())))->setChecked(true); <--- pretty fragile
618 2017-09-14 20:03:19	0|jonasschnelli|button() can return a nullptr
619 2017-09-14 20:03:31	0|adiabat|probably not too huge either
620 2017-09-14 20:03:38	0|jtimon|well, my thought was give an option -deletespent or something of the short, if you start using the index, it starts with an utxo at a given height, if you select the option, it conserves spent outputs but won't go to the past: if you want it full you need to reorg
621 2017-09-14 20:03:48	0|jonasschnelli|calling setChecked() on a nullptr won't crash OSX but does segfault (correctly) on linux
622 2017-09-14 20:04:13	0|BlueMatt|jonasschnelli: uhhhhhhh
623 2017-09-14 20:04:15	0|BlueMatt|I hope not?
624 2017-09-14 20:04:39	0|jtimon|but perhaps that's not acceptable either, anyway, thanks wumpus sipa that's useful to know
625 2017-09-14 20:04:42	0|jonasschnelli|Yeah.. seems strage... maybe a local issue.. it should crash
626 2017-09-14 20:04:53	0|wumpus|does it really return null when out of range though on osx?
627 2017-09-14 20:05:01	0|wumpus|or some softly padded dummy object
628 2017-09-14 20:06:38	0|cfields_|jonasschnelli: huh, i just saw something related to that in a recent qt changelog
629 2017-09-14 20:08:10	0|cfields_|jonasschnelli: no clue if related. not as relevant as i was thinking: https://bugreports.qt.io/browse/QTBUG-59391
630 2017-09-14 20:08:35	0|jonasschnelli|cfields_: thanks... will check later (on the run)
631 2017-09-14 20:09:50	0|bitcoin-git|[13bitcoin] 15jonasschnelli opened pull request #11332: Fix possible crash with invalid nCustomFeeRadio in QSettings (06master...062017/09/qsettings_1) 02https://github.com/bitcoin/bitcoin/pull/11332
632 2017-09-14 20:11:06	0|BlueMatt|jonasschnelli: I really dont think thats the right fix...groupCustomFee literally only contains one button now
633 2017-09-14 20:11:16	0|BlueMatt|jonasschnelli: better to just literally remove groupCustomFee and the button wholesale
634 2017-09-14 20:11:23	0|BlueMatt|as well as delete the nCustomFeeRadio setting
635 2017-09-14 20:11:48	0|gmaxwell|there are a half dozen places in the code where we ->button()->foo
636 2017-09-14 20:11:51	0|gmaxwell|fwiw
637 2017-09-14 20:13:56	0|achow101|Report of possibly same bug on osx: https://bitcointalk.org/index.php?topic=2132893.msg21842556#msg21842556 from droark
638 2017-09-14 20:15:22	0|jonasschnelli|BlueMatt: yes. Agree. I just created the minimal possble fix (for backports).
639 2017-09-14 20:15:38	0|BlueMatt|jonasschnelli: see my above patch which I think is maybe cleaner if we're looking at backports
640 2017-09-14 20:15:43	0|BlueMatt|s/maybe//
641 2017-09-14 20:15:50	0|BlueMatt|but whats the harm in fixing it right for 0.15.1?
642 2017-09-14 20:17:03	0|jonasschnelli|BlueMatt: sorry,... where is your patch?
643 2017-09-14 20:17:34	0|BlueMatt|<BlueMatt> https://github.com/bitcoin/bitcoin/commit/6ba2214e0fe57ecb9271819d2422ec44a9020a8d fixes it for now
644 2017-09-14 20:17:35	0|wumpus|bluematt's is the minimum possible - just make it always use button(0)
645 2017-09-14 20:18:20	0|jonasschnelli|BlueMatt: wumpus: okay. Makes more sense!... BlueMatt: do you pr?
646 2017-09-14 20:18:27	0|jonasschnelli|Or should I update my PR?
647 2017-09-14 20:18:28	0|sipa|minimal patch is "std::min(1, " -> "std::min(0, "
648 2017-09-14 20:18:33	0|sipa|:p
649 2017-09-14 20:18:36	0|jonasschnelli|heh
650 2017-09-14 20:19:53	0|wumpus|hah... yes, good point
651 2017-09-14 20:20:33	0|wumpus|that would have been the obvious correct fix too if the number of buttons was reduced to something else than 1
652 2017-09-14 20:21:38	0|BlueMatt|jonasschnelli: can we please just delete the buttons?
653 2017-09-14 20:21:53	0|BlueMatt|jonasschnelli: I see absolutely no harm in simply removing the group/button for 0.15.1
654 2017-09-14 20:22:05	0|achow101|I think removing the group is the right way to go here
655 2017-09-14 20:22:08	0|BlueMatt|(this is why i did not open my pr)
656 2017-09-14 20:24:22	0|wumpus|removing the whole group is a riskier change, though, it could potenitally introduce new issues
657 2017-09-14 20:24:29	0|wumpus|which is the right thing for master
658 2017-09-14 20:24:34	0|wumpus|but maybe not for 0.15.0.1 or w/e
659 2017-09-14 20:24:53	0|BlueMatt|hmm, alright up to you
660 2017-09-14 20:24:57	0|BlueMatt|i can pr mine against 15 if you like
661 2017-09-14 20:26:04	0|jonasschnelli|BlueMatt: remove for 0.16 is okay... but for a backport?
662 2017-09-14 20:26:15	0|BlueMatt|i figured it was fine, but...up to y'all
663 2017-09-14 20:27:11	0|achow101|Removing it could be backported to 0.15.1. for 0.15.0.1, BlueMatt's hack should be fine
664 2017-09-14 20:27:23	0|BlueMatt|wait, are we doing an 0.15.0.1?
665 2017-09-14 20:29:11	0|achow101|Are we?
666 2017-09-14 20:32:05	0|jonasschnelli|okay,... overhauled #11332
667 2017-09-14 20:32:07	0|gribble|https://github.com/bitcoin/bitcoin/issues/11332 | Fix possible crash with invalid nCustomFeeRadio in QSettings by jonasschnelli · Pull Request #11332 · bitcoin/bitcoin · GitHub
668 2017-09-14 20:33:15	0|jonasschnelli|BlueMatt: I'm trying to cherry-pick your https://github.com/bitcoin/bitcoin/commit/6ba2214e0fe57ecb9271819d2422ec44a9020a8d to keep you as author
669 2017-09-14 20:33:33	0|sipa|jonasschnelli: you can use git commit --author="..."
670 2017-09-14 20:33:47	0|sipa|if cherry picking is too hard, but you still want to retain author
671 2017-09-14 20:33:58	0|jonasschnelli|sipa: Oh... didn't knew you can.
672 2017-09-14 20:34:07	0|jonasschnelli|I guess the signature does not matter
673 2017-09-14 20:34:27	0|sipa|if you're cherry picking, the gpg signature is removed anyway
674 2017-09-14 20:34:35	0|sipa|(as it would be invalid)
675 2017-09-14 20:34:37	0|jonasschnelli|Oh. Right
676 2017-09-14 20:34:42	0|jonasschnelli|hash will change
677 2017-09-14 20:35:17	0|MarcoFalke|You can still sign the cherry-pick with your key, if you prefer that
678 2017-09-14 20:35:19	0|BlueMatt|heh, for that fix I dont really care
679 2017-09-14 20:35:28	0|BlueMatt|we all figured out the bug live during meeting anyway
680 2017-09-14 20:35:32	0|BlueMatt|group effort :)
681 2017-09-14 20:35:43	0|jonasschnelli|Okay. Retained authorship: https://github.com/bitcoin/bitcoin/pull/11332/commits
682 2017-09-14 20:46:12	0|achow101|I'm not sure if that solves 11171. The op tells me that he doesn't remember having that option set
683 2017-09-14 20:50:13	0|meshcollider|11171 was a segfault in QTableView::setSortingEnabled
684 2017-09-14 20:50:19	0|meshcollider|This sounds unrelated to that?
685 2017-09-14 20:52:10	0|meshcollider|#11262 has 2 separate issues in it, one in the OP and one in the comments, I think they're different
686 2017-09-14 20:52:12	0|gribble|https://github.com/bitcoin/bitcoin/issues/11262 | bitcoin-qt segmentation fault · Issue #11262 · bitcoin/bitcoin · GitHub
687 2017-09-14 20:53:10	0|meshcollider|Or at least probably a separate issue to 9683 and 9883
688 2017-09-14 21:02:12	0|achow101|Meshcollder: I think you are talking about 11262
689 2017-09-14 21:02:25	0|achow101|Not 11171
690 2017-09-14 21:02:30	0|luke-jr|setSortingEnabled is a distraction: the crash is "free(): invalid next size (fast)" which indicates corrupt memory before it got there
691 2017-09-14 21:02:51	0|luke-jr|it could very well be 11332-related
692 2017-09-14 21:03:14	0|luke-jr|the only way to confirm is valgrind
693 2017-09-14 21:03:30	0|luke-jr|(on an affected system)
694 2017-09-14 21:05:21	0|jnewbery|jonasschnelli: (slightly delayed) you can also `get commit -C <hash>` if you want to retain the entire commit message including author - and there's no risk of mistyping the author's name
695 2017-09-14 21:05:45	0|jnewbery|s/get/git
696 2017-09-14 21:06:48	0|achow101|Git has a lot of fun options that most people don't know about
697 2017-09-14 21:07:24	0|luke-jr|I'm probably the only one in the world who uses git write-tree <.<
698 2017-09-14 21:07:41	0|achow101|What's that?
699 2017-09-14 21:07:48	0|luke-jr|git-write-tree - Create a tree object from the current index
700 2017-09-14 21:08:17	0|luke-jr|typically followed by git commit-tree
701 2017-09-14 21:08:31	0|luke-jr|in my case, I do this sequence to produce commits with more than 2 parents
702 2017-09-14 21:08:42	0|ShaunR|Has anybody ever proposed making bitcoind's blocknotify and walletnotify options support a URL?  So you could set -blocknotify="https://domain.com/bitcoind/notify/block.php" and have it POST %s?  I'm thinking about attempting to write that functionallity into bitcoind but unsure if anyone else would find it useful or if the devs would even consider adding it.
703 2017-09-14 21:09:01	0|luke-jr|ShaunR: -blocknotify='curl https://domain.com/bitcoind/notify/block.php?hash=%s'
704 2017-09-14 21:09:11	0|luke-jr|probably a trivial way to make it POST too
705 2017-09-14 21:09:24	0|ShaunR|luke-jr: thats true, you could do something like that i guess.
706 2017-09-14 21:09:51	0|ShaunR|I was thinking about making it a bit more elaborate, like if the POST failed to queue the notification or something.
707 2017-09-14 21:10:07	0|luke-jr|could make blocknotify retry if the exit code is non-zero?
708 2017-09-14 21:10:09	0|ShaunR|but your solution may be the simplist right now.
709 2017-09-14 21:10:31	0|luke-jr|but tbh, retry logic could be outside too
710 2017-09-14 21:11:59	0|ShaunR|I wanted to avoid the requirement of a outside script/binary too
711 2017-09-14 21:12:13	0|esotericnonsense|yes, you could create an external script that queues notifications to do stuff with
712 2017-09-14 21:12:48	0|luke-jr|ShaunR: avoiding that requirement, is not a design goal IMO
713 2017-09-14 21:12:50	0|esotericnonsense|it'd probably be easier to use the zmq notification for that, just listen on it, add new entries to a queue, periodically try and flush the queue into this post mechanism
714 2017-09-14 21:13:03	0|luke-jr|ShaunR: better to run as little code in the security-critical process as possible
715 2017-09-14 21:13:05	0|esotericnonsense|indeed, it's not really bitcoind's responsibility
716 2017-09-14 21:13:19	0|luke-jr|esotericnonsense: ZMQ is good at losing notifications
717 2017-09-14 21:14:08	0|esotericnonsense|luke-jr: using IPC? tcp over seperate machines, perhaps
718 2017-09-14 21:15:12	0|esotericnonsense|regardless of whether you use zmq or not it's similarly easy though :)
719 2017-09-14 21:16:30	0|achow101|harrymm: do you have a debug.log file from the time of the crash?
720 2017-09-14 21:17:09	0|esotericnonsense|from #bitcoin:  dingus | TYPO at the very top of https://bitcoin.org/en/release/v0.15.0 "14 October 2017" <- It's not October, yet, I hope
721 2017-09-14 21:17:16	0|luke-jr|‎[21:11:33] ‎<‎dingus‎>‎ TYPO at the very top of https://bitcoin.org/en/release/v0.15.0 "14 October 2017" <- It's not October, yet, I hope
722 2017-09-14 21:17:18	0|luke-jr|yeah
723 2017-09-14 21:17:49	0|achow101|Lol
724 2017-09-14 21:27:14	0|kakobrekla|does `addwitnessaddress` work with watch-only addresses?
725 2017-09-14 21:27:58	0|sipa|yes
726 2017-09-14 21:28:04	0|kakobrekla|cool!
727 2017-09-14 21:28:40	0|sipa|kakobrekla: however, if it isn't, you can still use importaddress on the result
728 2017-09-14 21:28:53	0|sdaftuar|sipa: only if its solvable, right?  isn't it possible to have a watch-only address that is not solvable?
729 2017-09-14 21:30:07	0|sipa|right
730 2017-09-14 21:30:36	0|BlueMatt|11326 likely needs 0.15 backport, no?
731 2017-09-14 21:30:37	0|wbnns|@esotericnonsense @lukejr Submitted #1803 to fix the typo.
732 2017-09-14 21:30:39	0|gribble|https://github.com/bitcoin/bitcoin/issues/1803 | Apply MIT license to md2k7 art by luke-jr · Pull Request #1803 · bitcoin/bitcoin · GitHub
733 2017-09-14 21:31:35	0|esotericnonsense|actual url (wrong repo): https://github.com/bitcoin-dot-org/bitcoin.org/pull/1803
734 2017-09-14 21:31:58	0|wbnns|@esotericnonsense Thanks.
735 2017-09-14 21:32:10	0|esotericnonsense|you too :)
736 2017-09-14 21:32:38	0|wbnns|:)
737 2017-09-14 21:48:58	0|bitcoin-git|[13bitcoin] 15danra opened pull request #11333: Use `std::nth_element` instead of `std::sort` to calculate median time past (06master...06improve/median-time-past) 02https://github.com/bitcoin/bitcoin/pull/11333
738 2017-09-14 23:09:03	0|tloriato|Hello! I was looking for how I could import a BIP32 Extended Key into the Bitcoin Core wallet? I've tried the RPC Documentation but got no luck there.
739 2017-09-14 23:09:10	0|sipa|you can't
740 2017-09-14 23:10:00	0|tloriato|So I have to derive each desired path using another lib and import it with WIF?
741 2017-09-14 23:10:31	0|sipa|for now, yes
742 2017-09-14 23:11:36	0|tloriato|thank you, sipa
743 2017-09-14 23:12:41	0|tloriato|oh, one more thing, sorry! bitcoin core uses m/0'/0'/k' for derivation path
744 2017-09-14 23:12:58	0|tloriato|is there a way I could request a new address from an arbitrary path from the rpc?
745 2017-09-14 23:13:22	0|tloriato|or at least associate one i ( m/0'/i'/k' ) for one account?
746 2017-09-14 23:13:32	0|sipa|no, new addresses come from the keypool, which is preloaded with keys from one chain
747 2017-09-14 23:13:43	0|sipa|in 0.15, there are two chains (one for normal addresses, one for change)
748 2017-09-14 23:13:57	0|sipa|and no, you can't configure the path - especially not for accounts, which are deprecated
749 2017-09-14 23:14:49	0|tloriato|Well, I think I have the information that I need now.
750 2017-09-14 23:14:55	0|tloriato|Thanks sipa, it was really helpful
751 2017-09-14 23:14:59	0|sipa|yw
752 2017-09-14 23:19:38	0|tloriato|sipa in which cases does the bitcoin wallet changes the i from the path?
753 2017-09-14 23:20:09	0|tloriato|( for reference m/0'/i'/k' )
754 2017-09-14 23:20:27	0|sipa|i=0 for normal addresses, i=1 for change
755 2017-09-14 23:21:01	0|tloriato|oh, ok! thanks