1 2017-09-29 00:00:49 0|sipa|unless SetAddressBook needs a lock, let me see
2 2017-09-29 00:01:06 0|sipa|nope
3 2017-09-29 00:01:48 0|promag|right, AddCScript is thread safe
4 2017-09-29 00:03:16 0|promag|sipa: however CWallet::AddCScript should be atomic, and it's not
5 2017-09-29 00:04:17 0|sipa|promag: ?
6 2017-09-29 00:04:47 0|promag|nevermind, it exits
7 2017-09-29 02:39:21 0|bitcoin-git|[13bitcoin] 15jonasschnelli closed pull request #11412: Simplify GetWarnings() (06master...062017/09/getwarnings) 02 https://github.com/bitcoin/bitcoin/pull/11412
8 2017-09-29 03:59:48 0|achow101|how do we handle RPC api changes?
9 2017-09-29 03:59:49 0|ossifrage|I think I just managed to get the client to take the fee from the wrong side of the transaction
10 2017-09-29 04:00:33 0|achow101|I want to change addmultisigaddress's output from an address to a json object with an address and redeemscript field, so what's the best way to do that?
11 2017-09-29 04:02:21 0|jonasschnelli|achow101: just do it and make sure it's mentioned in the release notes?
12 2017-09-29 04:02:45 0|jonasschnelli|API changes should be avoided, yes. But also we should not have every new RPC call static made in stone
13 2017-09-29 04:03:36 0|luke-jr|IMO just do it for that specific case, mainly because it's not useful for non-testing
14 2017-09-29 04:04:33 0|achow101|ok
15 2017-09-29 04:30:01 0|bitcoin-git|[13bitcoin] 15achow101 opened pull request #11415: [RPC] Disallow using addresses in createmultisig (06master...06createmultisig-no-addr) 02 https://github.com/bitcoin/bitcoin/pull/11415
16 2017-09-29 06:15:07 0|esotericnonsense|looking back on the meeting; I've done some work previously on serverside ZMQ tracking of topics, it's kind of a hack on the protocol but you can detect when a client disconnects and queue up messages for them for some period, if you combine that with sequence numbers and overlap them you can mitigate missing messages to some extent, but it's still a hack on the ZMQ semantics for pubsub
17 2017-09-29 06:15:32 0|esotericnonsense|(and makes the notifications stateful)
18 2017-09-29 06:53:31 0|bitcoin-git|[13bitcoin] 15jl2012 opened pull request #11417: Correct typo in comments (06master...06patch-19) 02 https://github.com/bitcoin/bitcoin/pull/11417
19 2017-09-29 08:19:27 0|bitcoin-git|[13bitcoin] 15laanwj pushed 10 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/a72003d794f3...aa624b61c928
20 2017-09-29 08:19:28 0|bitcoin-git|13bitcoin/06master 141e46ebd 15Pieter Wuille: Implement {Encode,Decode}Destination without CBitcoinAddress
21 2017-09-29 08:19:29 0|bitcoin-git|13bitcoin/06master 146565c55 15Pieter Wuille: Convert base58_tests from type/payload to scriptPubKey comparison
22 2017-09-29 08:19:29 0|bitcoin-git|13bitcoin/06master 148fd2267 15Pieter Wuille: Import Bech32 C++ reference code & tests...
23 2017-09-29 08:19:59 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11167: Full BIP173 (Bech32) support (06master...06201708_bech32) 02 https://github.com/bitcoin/bitcoin/pull/11167
24 2017-09-29 08:21:01 0|bitcoin-git|13bitcoin/06master 146f33d8c 15Johnson Lau: Correct typo in comments
25 2017-09-29 08:21:01 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/aa624b61c928...0ec9c91623fc
26 2017-09-29 08:21:02 0|bitcoin-git|13bitcoin/06master 140ec9c91 15Wladimir J. van der Laan: Merge #11417: Correct typo in comments...
27 2017-09-29 08:21:31 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11417: Correct typo in comments (06master...06patch-19) 02 https://github.com/bitcoin/bitcoin/pull/11417
28 2017-09-29 08:25:24 0|bitcoin-git|13bitcoin/06master 14bb174e1 15fanquake: [docs] Remove partial gitian instructions from descriptors dir
29 2017-09-29 08:25:24 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/0ec9c91623fc...bbc901d3a683
30 2017-09-29 08:25:25 0|bitcoin-git|13bitcoin/06master 14bbc901d 15Wladimir J. van der Laan: Merge #11414: [docs] Remove partial gitian build instructions from descriptors dir....
31 2017-09-29 08:26:04 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11414: [docs] Remove partial gitian build instructions from descriptors dir. (06master...06gitian-cleanups) 02 https://github.com/bitcoin/bitcoin/pull/11414
32 2017-09-29 08:28:33 0|esotericnonsense|wumpus: on the Termux thing; I did get it to work, I had to hack a few of the #defines in leveldb, compile libevent, and make that #include change from the issue.\
33 2017-09-29 08:29:12 0|esotericnonsense|I'm heading off to work now but I can write it up later if you're interested, it's running on a few different phones I have here.
34 2017-09-29 08:56:54 0|bitcoin-git|[13bitcoin] 15maaku opened pull request #11418: Add error string for CLEANSTACK script violation (06master...06cleanstack-error-code) 02 https://github.com/bitcoin/bitcoin/pull/11418
35 2017-09-29 09:16:18 0|bitcoin-git|[13bitcoin] 15OmeGak opened pull request #11419: Utils: Fix launchctl not being able to stop bitcoind (06master...06fix-macos-init) 02 https://github.com/bitcoin/bitcoin/pull/11419
36 2017-09-29 10:38:04 0|ThomasV|bip173 merged :)
37 2017-09-29 11:05:32 0|mryandao|hi, i just ran `ldd` on bitcoin-cli and noticed that it requires libboost, is it really necessary?
38 2017-09-29 11:43:20 0|timothy|mryandao: yes
39 2017-09-29 11:55:51 0|meshcollider|Awesome to see 11167 merged now
40 2017-09-29 11:55:58 0|meshcollider|Exciting stuff
41 2017-09-29 12:00:21 0|rabidus|#11167
42 2017-09-29 12:00:26 0|gribble|https://github.com/bitcoin/bitcoin/issues/11167 | Full BIP173 (Bech32) support by sipa ÷ Pull Request #11167 ÷ bitcoin/bitcoin ÷ GitHub
43 2017-09-29 12:42:08 0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #11420: Bump univalue subtree and fix json formatting in tests (06master...06Mf1709-bumpUnivalue) 02 https://github.com/bitcoin/bitcoin/pull/11420
44 2017-09-29 13:11:26 0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 4 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/bbc901d3a683...93d20a734d2e
45 2017-09-29 13:11:27 0|bitcoin-git|13bitcoin/06master 1404f78ab 15Alex Morcos: Do not reject based on mempool min fee when bypass_limits is set....
46 2017-09-29 13:11:27 0|bitcoin-git|13bitcoin/06master 14fd849e1 15Alex Morcos: Change AcceptToMemoryPool function signature...
47 2017-09-29 13:11:28 0|bitcoin-git|13bitcoin/06master 14bf64c3c 15Alex Morcos: Ignore transactions added to mempool during a reorg for fee estimation purposes.
48 2017-09-29 13:12:14 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #11309: Minor cleanups for AcceptToMemoryPool (06master...06ATMP_cleanup) 02 https://github.com/bitcoin/bitcoin/pull/11309
49 2017-09-29 14:00:45 0|wumpus|esotericnonsense: cool! can you post the patch somewhere please? we should probably handle the leveldb changes through upstream but it'd be nice to try
50 2017-09-29 14:21:44 0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #11421: Merge current secp256k1 subtree (06master...06Mf1709-subtree-secp256k1) 02 https://github.com/bitcoin/bitcoin/pull/11421
51 2017-09-29 17:48:29 0|bitcoin-git|13bitcoin/06master 14d3677ab 15Andrew Chow: Tests for zmqpubrawtx and zmqpubrawblock
52 2017-09-29 17:48:29 0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/93d20a734d2e...9c3c9cdae3e2
53 2017-09-29 17:48:30 0|bitcoin-git|13bitcoin/06master 149c3c9cd 15MarcoFalke: Merge #10552: [Test] Tests for zmqpubrawtx and zmqpubrawblock...
54 2017-09-29 17:48:49 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #10552: [Test] Tests for zmqpubrawtx and zmqpubrawblock (06master...06zmq-raw-tests) 02 https://github.com/bitcoin/bitcoin/pull/10552
55 2017-09-29 18:27:39 0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 3 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/9c3c9cdae3e2...ff4cd6075b12
56 2017-09-29 18:27:40 0|bitcoin-git|13bitcoin/06master 14a782042 15Suhas Daftuar: qa: Treat mininode p2p exceptions as fatal
57 2017-09-29 18:27:40 0|bitcoin-git|13bitcoin/06master 14f97ab35 15Suhas Daftuar: qa: Fix bug introduced in p2p-segwit.py...
58 2017-09-29 18:27:41 0|bitcoin-git|13bitcoin/06master 14ff4cd60 15MarcoFalke: Merge #11319: [qa] Fix error introduced into p2p-segwit.py, and prevent future similar errors...
59 2017-09-29 18:28:14 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #11319: [qa] Fix error introduced into p2p-segwit.py, and prevent future similar errors (06master...062017-09-fix-p2p-segwit) 02 https://github.com/bitcoin/bitcoin/pull/11319
60 2017-09-29 18:29:35 0|esotericnonsense|wumpus: sure. i'll recompile on master and post a diff (I just downloaded the tarball and hacked about so it's annoying, also i've make cleaned so might as well wait it out anyway).
61 2017-09-29 18:30:07 0|esotericnonsense|i'll try test_bitcoin as well. pretty sure the issue is just fs::temp_directory_path() giving an inaccessible directory.
62 2017-09-29 18:32:23 0|esotericnonsense|unrelated, i would appreciate input on https://github.com/bitcoin/bitcoin/pull/11359 if someone could be so kind. it's a tiny diff, just curious on whether anyone has a better approach.
63 2017-09-29 18:58:39 0|BlueMatt|jonasschnelli: care to close 8757 (superceded)
64 2017-09-29 19:03:17 0|BlueMatt|cfields: wanna just close 9000? It needed rebase a long time ago and you even said you dont particularly care if it goes upstream
65 2017-09-29 19:03:52 0|esotericnonsense|yeah, that's it. boost::filesystem::temp_directory_path() gives /data/local/tmp which is denied access (if it even exists, i don't have root on this device).
66 2017-09-29 19:04:15 0|bitcoin-git|[13bitcoin] 15theuni closed pull request #9000: miner debugging: faux-mining (06master...06faux-mining) 02 https://github.com/bitcoin/bitcoin/pull/9000
67 2017-09-29 19:04:37 0|esotericnonsense|ah it is there, just not accessible by the user.
68 2017-09-29 19:04:39 0|cfields|BlueMatt: sure :)
69 2017-09-29 19:42:09 0|bitcoin-git|[13bitcoin] 15sipa closed pull request #9101: [Wallet] Do not parse ssValue in CWalletDB::Recover (06master...062016-11-07-cwalletdb-recover) 02 https://github.com/bitcoin/bitcoin/pull/9101
70 2017-09-29 20:20:56 0|bitcoin-git|[13bitcoin] 15jonasschnelli closed pull request #8757: Fix issue with conflicted mempool tx in listsinceblock (06master...062016/09/listsinceblock) 02 https://github.com/bitcoin/bitcoin/pull/8757
71 2017-09-29 21:03:05 0|esotericnonsense|wumpus: patches against bitcoin master and libevent master https://esotericnonsense.com/tmp/
72 2017-09-29 21:03:42 0|esotericnonsense|it's pretty much the bare minimum hack to get it to compile and for test_bitcoin / bitcoind to run, hardcoding #define OS_ANDROID is my lazy way of not wanting to face autotools stuff :P
73 2017-09-29 21:04:00 0|esotericnonsense|i'm guessing it just sees Linux in uname -a or whatever and that's that
74 2017-09-29 21:05:43 0|esotericnonsense|i'm using ./configure --disable-wallet, and also termux-chroot, i didn't note the dependencies as I went along, unfortunately, but everything else should be in termux repos
75 2017-09-29 21:37:09 0|bitcoin-git|[13bitcoin] 15TheBlueMatt opened pull request #11422: Verify DBWrapper iterators are taking snapshots (06master...062017-09-leveldb-check-snapshots) 02 https://github.com/bitcoin/bitcoin/pull/11422
76 2017-09-29 21:44:53 0|bitcoin-git|[13bitcoin] 15jl2012 opened pull request #11423: [Policy] Make OP_CODESEPARATOR and FindAndDelete in non-segwit scripts non-std (06master...06const_scriptcode) 02 https://github.com/bitcoin/bitcoin/pull/11423
77 2017-09-29 22:06:06 0|bitcoin-git|13bitcoin/06master 14cee28fb 15Mark Friedenbach: Add error string for CLEANSTACK script violation, preventing an "unknown error" if the CLEANSTACK error condition is set.
78 2017-09-29 22:06:06 0|bitcoin-git|[13bitcoin] 15sipa pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/ff4cd6075b12...38c201f47c0b
79 2017-09-29 22:06:07 0|bitcoin-git|13bitcoin/06master 1438c201f 15Pieter Wuille: Merge #11418: Add error string for CLEANSTACK script violation...
80 2017-09-29 22:06:49 0|bitcoin-git|[13bitcoin] 15sipa closed pull request #11418: Add error string for CLEANSTACK script violation (06master...06cleanstack-error-code) 02 https://github.com/bitcoin/bitcoin/pull/11418