1 2017-10-09 03:31:38 0|bitcoin-git|[13bitcoin] 15dusty-wil opened pull request #11465: rpc: Update named args documentation for importprivkey (06master...06master) 02 https://github.com/bitcoin/bitcoin/pull/11465
2 2017-10-09 09:55:47 0|bitcoin-git|[13bitcoin] 15MeshCollider opened pull request #11466: [WIP] Specify custom wallet directory with -walletdir param (06master...06201710_walletdir) 02 https://github.com/bitcoin/bitcoin/pull/11466
3 2017-10-09 13:19:05 0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #11467: Fix typos. Use nullptr instead of NULL. Use quote form for local includes. (06master...06cleanups-20171009) 02 https://github.com/bitcoin/bitcoin/pull/11467
4 2017-10-09 14:09:46 0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #11468: [tests] Make comp test framework more debuggable (06master...06comp_test_debuggable) 02 https://github.com/bitcoin/bitcoin/pull/11468
5 2017-10-09 14:11:05 0|bitcoin-git|13bitcoin/06master 14ce2418f 15Cristian Mircea Messel: [gui] reset addrProxy/addrSeparateProxyTor if colon char missing...
6 2017-10-09 14:11:05 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/17f2acedbe07...d473e6ddc55c
7 2017-10-09 14:11:06 0|bitcoin-git|13bitcoin/06master 14d473e6d 15Wladimir J. van der Laan: Merge #11448: [gui] reset addrProxy/addrSeparateProxyTor if colon char missing...
8 2017-10-09 14:11:52 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11448: [gui] reset addrProxy/addrSeparateProxyTor if colon char missing (06master...06ensure_colon_in_proxies_qsettings_storage) 02 https://github.com/bitcoin/bitcoin/pull/11448
9 2017-10-09 14:20:16 0|promag|wumpus: addrProxy and addrSeparateProxyTor are always loaded with qsettings, and qsettings supports external changes
10 2017-10-09 14:21:29 0|promag|just saying.. I know that changing the settings externally is bad usage
11 2017-10-09 14:22:16 0|promag|For reference see http://doc.qt.io/qt-5/qsettings.html#sync
12 2017-10-09 14:23:07 0|wumpus|promag: addrProxy and addrSeparateProxy are only loaded *from* the qsettings in the constructor, right?
13 2017-10-09 14:23:34 0|promag|no
14 2017-10-09 14:23:36 0|wumpus|I know qsettings can be updated extenrally, but we don't pay attention to changes in the qsettings after the initial start
15 2017-10-09 14:23:51 0|wumpus|then what triggers a re-load of settings from qsettings to bitcoin core settings?
16 2017-10-09 14:23:56 0|promag|doesn't matter, qsettings will refresh it's internal data
17 2017-10-09 14:24:03 0|wumpus|I know , but we don't look at that
18 2017-10-09 14:24:12 0|wumpus|we don't care about qsettings internal data
19 2017-10-09 14:24:14 0|wumpus|we don't parse it
20 2017-10-09 14:24:27 0|promag|I know, but then in runtime we do settings.value("addrProxy").toString().split(":")
21 2017-10-09 14:24:29 0|wumpus|after the one0-time constructor of the optionsmodel
22 2017-10-09 14:24:43 0|wumpus|oh really? crap
23 2017-10-09 14:25:02 0|promag|that was my point, sorry if I didn't explain it well
24 2017-10-09 14:25:02 0|wumpus|that shouldn't be the case
25 2017-10-09 14:25:09 0|wumpus|goddamnit that code is crap
26 2017-10-09 14:25:14 0|promag|in the constructor we only sanitize
27 2017-10-09 14:25:42 0|promag|I can submit a PR dealing with qsettings.value()
28 2017-10-09 14:26:08 0|wumpus|yeah, probably shouldn't even have merged this
29 2017-10-09 14:26:14 0|wumpus|it's that it had so many acks
30 2017-10-09 14:26:16 0|promag|either we store in memory the value or we validate the (possible new) qsettings.value
31 2017-10-09 14:26:48 0|promag|it has mine too
32 2017-10-09 14:27:07 0|wumpus|it would take so much to handle external changes to qsettings sanely
33 2017-10-09 14:27:22 0|wumpus|and as I mentioned I don't think this was an issue worth fixing in any case
34 2017-10-09 14:27:39 0|wumpus|there's tons of ways to crash bitcoin with corrupted settings
35 2017-10-09 14:28:03 0|promag|can be improved for sure
36 2017-10-09 14:28:17 0|wumpus|but is it any kind of goal? why?
37 2017-10-09 14:28:47 0|wumpus|please, let's focus on things that matter
38 2017-10-09 14:29:06 0|wumpus|there's 240 PRs open, more every day
39 2017-10-09 14:29:41 0|wumpus|no one can review all of this, there's not even any getting started to it anymore
40 2017-10-09 14:31:57 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10907: Prefer iterators arrow operator over iterator dereference (06master...0620170722-refactor-arrow-1) 02 https://github.com/bitcoin/bitcoin/pull/10907
41 2017-10-09 14:41:38 0|bitcoin-git|13bitcoin/06master 14c6a995e 15practicalswift: Improve readability of DecodeBase58Check(...)
42 2017-10-09 14:41:38 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/d473e6ddc55c...da0478e6e5d9
43 2017-10-09 14:41:39 0|bitcoin-git|13bitcoin/06master 14da0478e 15Wladimir J. van der Laan: Merge #10961: Improve readability of DecodeBase58Check(...)...
44 2017-10-09 14:42:03 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #10961: Improve readability of DecodeBase58Check(...) (06master...06DecodeBase58Check-cleanup) 02 https://github.com/bitcoin/bitcoin/pull/10961
45 2017-10-09 15:04:56 0|bitcoin-git|13bitcoin/06master 14b7dfc6c 15Daniel Edgecumbe: [rpc] getblockchaininfo: add size_on_disk, prune_target_size, automatic_pruning...
46 2017-10-09 15:04:56 0|bitcoin-git|[13bitcoin] 15laanwj pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/da0478e6e5d9...3a93270c5587
47 2017-10-09 15:04:57 0|bitcoin-git|13bitcoin/06master 143a93270 15Wladimir J. van der Laan: Merge #11367: [rpc] getblockchaininfo: add size_on_disk, prune_target_size...
48 2017-10-09 15:05:29 0|bitcoin-git|[13bitcoin] 15laanwj closed pull request #11367: [rpc] getblockchaininfo: add size_on_disk, prune_target_size (06master...062017-09-getblockchaininfo-addsize) 02 https://github.com/bitcoin/bitcoin/pull/11367
49 2017-10-09 17:13:24 0|bitcoin-git|13bitcoin/06master 14aa57590 15Dusty Williams: Update importprivkey named args documentation...
50 2017-10-09 17:13:24 0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/3a93270c5587...92eadc395071
51 2017-10-09 17:13:25 0|bitcoin-git|13bitcoin/06master 1492eadc3 15MarcoFalke: Merge #11465: rpc: Update named args documentation for importprivkey...
52 2017-10-09 17:14:08 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #11465: rpc: Update named args documentation for importprivkey (06master...06master) 02 https://github.com/bitcoin/bitcoin/pull/11465
53 2017-10-09 17:17:01 0|bitcoin-git|[13bitcoin] 15kanigsson opened pull request #11469: fix typo in comment of chain.cpp (06master...06typo-fix-in-comment) 02 https://github.com/bitcoin/bitcoin/pull/11469
54 2017-10-09 19:03:42 0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 4 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/92eadc395071...c63364610f4a
55 2017-10-09 19:03:43 0|bitcoin-git|13bitcoin/06master 145864e9c 15John Newbery: [tests] remove direct testing on JSONRPCException from individual test cases
56 2017-10-09 19:03:43 0|bitcoin-git|13bitcoin/06master 14677d893 15John Newbery: [tests] do not allow assert_raises_message to be called with JSONRPCException
57 2017-10-09 19:03:44 0|bitcoin-git|13bitcoin/06master 1447ba8cf 15John Newbery: scripted-diff: rename assert_raises_jsonrpc to assert_raises_rpc error...
58 2017-10-09 19:04:07 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #10853: [tests] Fix RPC failure testing (again) (06master...06cleanup_jsonrpc_asserts) 02 https://github.com/bitcoin/bitcoin/pull/10853
59 2017-10-09 19:45:46 0|jimpo|Ping again on #11113
60 2017-10-09 19:45:48 0|gribble|https://github.com/bitcoin/bitcoin/issues/11113 | [net] Ignore getheaders requests for very old side blocks by jimpo ÷ Pull Request #11113 ÷ bitcoin/bitcoin ÷ GitHub
61 2017-10-09 19:48:01 0|bitcoin-git|[13bitcoin] 15jonasschnelli pushed 3 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/c63364610f4a...e022463a4b23
62 2017-10-09 19:48:02 0|bitcoin-git|13bitcoin/06master 1446b752a 15fanquake: [depends] native_mac_alias 2.0.6
63 2017-10-09 19:48:02 0|bitcoin-git|13bitcoin/06master 14f617d1b 15fanquake: [depends] native_ds_store 1.1.2
64 2017-10-09 19:48:03 0|bitcoin-git|13bitcoin/06master 14e022463 15Jonas Schnelli: Merge #11460: [depends] mac_alias 2.0.6, ds_store 1.1.2...
65 2017-10-09 19:48:37 0|bitcoin-git|[13bitcoin] 15jonasschnelli closed pull request #11460: [depends] mac_alias 2.0.6, ds_store 1.1.2 (06master...06update-mac-alias) 02 https://github.com/bitcoin/bitcoin/pull/11460
66 2017-10-09 19:48:43 0|jonasschnelli|wumpus: I think #11113 is RTM
67 2017-10-09 19:48:45 0|gribble|https://github.com/bitcoin/bitcoin/issues/11113 | [net] Ignore getheaders requests for very old side blocks by jimpo ÷ Pull Request #11113 ÷ bitcoin/bitcoin ÷ GitHub
68 2017-10-09 21:20:27 0|bitcoin-git|[13bitcoin] 15jonasschnelli opened pull request #11471: [Qt] Optimize SendToSelf rendering with a single non-change output (06master...062017/10/qt_sendtoself) 02 https://github.com/bitcoin/bitcoin/pull/11471
69 2017-10-09 22:07:01 0|bitcoin-git|[13bitcoin] 15MarcoFalke opened pull request #11472: qa: Make tmpdir option an absolute path (06master...06Mf1710-qaMultiwalletRelDir) 02 https://github.com/bitcoin/bitcoin/pull/11472