1 2017-10-17 02:07:49 0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #11513: [trivial] [tests] A few Python3 tidy ups (06master...06authproxy_tidyups) 02 https://github.com/bitcoin/bitcoin/pull/11513
2 2017-10-17 12:26:45 0|aj|jtimon: re: getblockstats rpc tests, aren't tx sizes non-deterministic due to the signatures sometimes being a byte short due to a leading \x00 getting skipped due to DER encoding?
3 2017-10-17 12:32:43 0|jtimon|aj: oh, right, that must be it...
4 2017-10-17 12:33:20 0|jtimon|isn't there a way to solve that?
5 2017-10-17 12:39:46 0|sipa|aj: how does thatmake them nondeterministic?
6 2017-10-17 12:39:54 0|sipa|DER is deterministic
7 2017-10-17 12:52:50 0|sipa|or you mean the low-S malleability?
8 2017-10-17 13:11:17 0|gmaxwell|sipa: I think he thinks the signature is non-determinstic?
9 2017-10-17 13:29:52 0|aj|sipa: running the same test case repeatedly doesn't generate the same R each time does it?
10 2017-10-17 13:30:18 0|gmaxwell|it will if the transaction is the same.
11 2017-10-17 13:30:34 0|gmaxwell|(and key)
12 2017-10-17 13:32:07 0|aj|context is https://github.com/bitcoin/bitcoin/pull/10757#issuecomment-337212106 fwiw
13 2017-10-17 13:38:00 0|sipa|aj: you can always choose to create a tx with a larger or smaller sig
14 2017-10-17 13:38:05 0|sipa|by grinding
15 2017-10-17 13:38:52 0|sipa|but if you have an actual tx, the serialization of that sig is fixed
16 2017-10-17 13:41:08 0|aj|sipa: ack. but the test suite doesn't ensure it produces a deterministic chain, so txes will vary between test suite runs, yes/no?
17 2017-10-17 13:42:44 0|sipa|no, our own signing is deterministic
18 2017-10-17 13:43:18 0|sipa|you can't assume that other's signatures are - but the ones we create ourselves are
19 2017-10-17 14:02:45 0|aj|sipa: okay, again, correct me if i'm wrong, but i'm seeing "self.nodes[0].getnewaddress()" giving different results between test_runner.py invocations, which (even despite deterministic signing) should result in non-deterministic tx sizes aiui
20 2017-10-17 14:03:15 0|sipa|aj: oh, sure
21 2017-10-17 14:03:20 0|sipa|if the the transaction isn't the same
22 2017-10-17 14:04:38 0|aj|sipa: yeah. i wasn't following whether the implication was that there was meant to be deterministic generation of addresses/chains to have the test suite results be deterministic
23 2017-10-17 14:05:16 0|sipa|aj: i just read some more context of the discussion, i wasn't aware you were talking about entire tests being deterministic
24 2017-10-17 14:08:18 0|bitcoin-git|[13bitcoin] 15promag opened pull request #11514: Iterate and remove nodes without container copy (06master...06201710-node-iterate-and-erase) 02 https://github.com/bitcoin/bitcoin/pull/11514
25 2017-10-17 14:11:10 0|bitcoin-git|[13bitcoin] 15promag opened pull request #11515: Assert cs_main is held when retrieving node state (06master...06201710-node-state-guard) 02 https://github.com/bitcoin/bitcoin/pull/11515
26 2017-10-17 14:45:03 0|bitcoin-git|[13bitcoin] 15practicalswift opened pull request #11516: crypto: Avoid creating of one-past-the-end pointer and performing a noop memset call (HMAC-SHA{256,512}) (06master...06one-past-the-end) 02 https://github.com/bitcoin/bitcoin/pull/11516
27 2017-10-17 14:56:36 0|bitcoin-git|[13bitcoin] 15simonmulser closed pull request #11510: Net: Log when peer reached MAX_BLOCKS_IN_TRANSIT_PER_PEER (06master...06add_log) 02 https://github.com/bitcoin/bitcoin/pull/11510
28 2017-10-17 15:42:52 0|pedrobranco|Hello, any change of getting https://github.com/bitcoin/bitcoin/pull/11483 merged soon since it's a bug in importmulti?
29 2017-10-17 16:08:45 0|jonasschnelli|pedrobranco: Needs more reviews first..
30 2017-10-17 16:09:00 0|jonasschnelli|Is it something we want to backport, right?
31 2017-10-17 16:21:34 0|pedrobranco|jonasschnelli: Yes it needs more reviews.
32 2017-10-17 16:29:03 0|bitcoin-git|[13bitcoin] 15martinus opened pull request #11517: Tests: Improve benchmark precision by inlining performance critical code (06master...06improved-benchmarking) 02 https://github.com/bitcoin/bitcoin/pull/11517
33 2017-10-17 16:33:02 0|jonasschnelli|pedrobranco: I guess another one and we'll be fine. Its a simple change
34 2017-10-17 17:07:03 0|pedrobranco|jonasschnelli: ty
35 2017-10-17 17:28:04 0|BlueMatt|#11483 could get a merge, imo, dunno if anyone merging is around today, though
36 2017-10-17 17:28:06 0|gribble|https://github.com/bitcoin/bitcoin/issues/11483 | Fix importmulti bug when importing an already imported key by pedrobranco ÷ Pull Request #11483 ÷ bitcoin/bitcoin ÷ GitHub
37 2017-10-17 17:39:11 0|mess110|hi, working on adding a proxy icon, wanted to ask for feedback.
38 2017-10-17 17:39:16 0|mess110|do you think this icon https://ibb.co/eP9mGR is better than https://user-images.githubusercontent.com/226170/31521305-99c43f22-afb1-11e7-9daf-d1ed6347daa8.png ?
39 2017-10-17 17:39:20 0|mess110|it is made out of chevron-left and 3 device-desktop from http://s-ings.com/typicons/
40 2017-10-17 19:07:25 0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 5 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/2c66cea2d186...14b860bf6402
41 2017-10-17 19:07:26 0|bitcoin-git|13bitcoin/06master 14323d8f6 15John Newbery: [tests] fix flake8 warnings in authproxy.py
42 2017-10-17 19:07:26 0|bitcoin-git|13bitcoin/06master 14fc0176d 15John Newbery: [tests] use python3 for authproxy.py
43 2017-10-17 19:07:27 0|bitcoin-git|13bitcoin/06master 148f9e362 15John Newbery: [tests] authproxy.py: tidy up __init__()
44 2017-10-17 19:08:01 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #11513: [trivial] [tests] A few Python3 tidy ups (06master...06authproxy_tidyups) 02 https://github.com/bitcoin/bitcoin/pull/11513
45 2017-10-17 19:44:36 0|bitcoin-git|13bitcoin/06master 14a44a215 15Pedro Branco: Fix importmulti bug when importing an already imported key
46 2017-10-17 19:44:36 0|bitcoin-git|[13bitcoin] 15MarcoFalke pushed 2 new commits to 06master: 02 https://github.com/bitcoin/bitcoin/compare/14b860bf6402...808c84f89d0e
47 2017-10-17 19:44:37 0|bitcoin-git|13bitcoin/06master 14808c84f 15MarcoFalke: Merge #11483: Fix importmulti bug when importing an already imported key...
48 2017-10-17 19:45:06 0|bitcoin-git|[13bitcoin] 15MarcoFalke closed pull request #11483: Fix importmulti bug when importing an already imported key (06master...06bugfix/fix-importmulti-bug) 02 https://github.com/bitcoin/bitcoin/pull/11483
49 2017-10-17 20:10:45 0|cfields|sipa: i forget your preference. You like a github review (batch), or individual comments?
50 2017-10-17 20:21:31 0|BlueMatt|cfields: for the sake of (most peoples') inbox, batch
51 2017-10-17 20:23:20 0|cfields|heh, fair enough. iirc someone complained about the batches because it screwed up their workflow.
52 2017-10-17 20:23:33 0|cfields|hmm, maybe that was you, with your online/offline split?
53 2017-10-17 20:39:39 0|sdaftuar|cfields: i'm thinking about adding a way to mock out addrman for the purposes of regtest-testing our outbound peer logic. does that sound like a reasonable thing to do?
54 2017-10-17 20:40:10 0|cfields|sdaftuar: yep! I've already got it halfway done, though...
55 2017-10-17 20:40:20 0|sdaftuar|oh, cool
56 2017-10-17 20:40:29 0|sdaftuar|any chance you have a commit i can steal then? :)
57 2017-10-17 20:40:46 0|cfields|heh, it's just waiting on #11457
58 2017-10-17 20:40:48 0|gribble|https://github.com/bitcoin/bitcoin/issues/11457 | Introduce BanMan by theuni ÷ Pull Request #11457 ÷ bitcoin/bitcoin ÷ GitHub
59 2017-10-17 20:40:55 0|cfields|sure
60 2017-10-17 20:41:08 0|cfields|it's broken out the same way
61 2017-10-17 20:42:27 0|cfields|sdaftuar: will push it up tonight, need to clean up/rebase
62 2017-10-17 20:42:44 0|sdaftuar|cool, thanks. i'll takea look at 11457
63 2017-10-17 20:48:10 0|bitcoin-git|[13bitcoin] 15jnewbery opened pull request #11518: [WIP] [tests] Simplify/clarify the NodeConn/NodeConnCB mininode classes (06master...06node_conn_big_refactor) 02 https://github.com/bitcoin/bitcoin/pull/11518
64 2017-10-17 22:08:49 0|promag|jnewbery: where is P2PInterface?
65 2017-10-17 22:10:03 0|promag|jnewbery: https://travis-ci.org/bitcoin/bitcoin/jobs/289221884#L741
66 2017-10-17 22:11:34 0|promag|nevermind 1st question